Re: [PATCH] leds-ot200: Fix error caused by shifted mask

2013-02-04 Thread Bryan Wu
mably missed this in the lkml flood. > > You are right... > > ~/kernel/linux-3.7.6$ ./scripts/get_maintainer.pl -f drivers/leds/leds-ot200.c > Bryan Wu (maintainer:LED SUBSYSTEM) > Richard Purdie (maintainer:LED SUBSYSTEM) > linux-l...@vger.kernel.org (open list:LED SUBSYSTEM

[GIT PULL] LED subsystem update for v3.9

2013-02-22 Thread Bryan Wu
The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7: Linux 3.8-rc6 (2013-02-01 12:08:14 +1100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for-next for you to fetch changes up to 4b07c5d5123f76487c61cf

Re: [GIT PULL] LED subsystem update for v3.9

2013-02-26 Thread Bryan Wu
On Tue, Feb 26, 2013 at 9:30 AM, Linus Torvalds wrote: > On Fri, Feb 22, 2013 at 6:21 PM, Bryan Wu wrote: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git >> for-next > > Pulled, but I'd *really* like to see some human-readable ex

Re: [PATCH 1/2] leds: add new LP5562 LED driver

2013-03-12 Thread Bryan Wu
On Mon, Feb 18, 2013 at 9:10 PM, Kim, Milo wrote: > LP5562 can drive up to 4 channels, RGB and White. > LEDs can be controlled directly via the led class control interface. > > LP55xx common driver > LP5562 is one of LP55xx family device, so LP55xx common code are used. > On the other hand, c

Re: [PATCH 2/3] leds: add LED Trigger for camera function

2013-03-12 Thread Bryan Wu
On Wed, Feb 20, 2013 at 12:36 AM, Kim, Milo wrote: > Some LED devices support flash/torch functionality through the LED subsystem. > This patch enables direct LED trigger controls by the driver. > Flash on/off and torch on/off can be done simply by other driver space. > Two trigger APIs are added,

Re: [PATCH 3/3] leds: lm355x, lm3642: support Camera LED triggers for flash/torch

2013-03-12 Thread Bryan Wu
On Wed, Feb 20, 2013 at 12:36 AM, Kim, Milo wrote: > LM355x and LM3642 support flash and torch functionality. > > (Camera driver) (LED trigger for camera) (LED driver) > Turn on the flash ...> ledtrig_flash_ctrl(true) ...> LM355x or LM3642 >

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > The Palmas familly of chips has LED support. This is not always muxed > to output pins so depending on the setting of the mux this driver > will create the appropriate LED class devices. > > Signed-off-by: Graeme Gregory > Signed-off-by: Ian La

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Tue, Mar 12, 2013 at 12:10 PM, Mark Brown wrote: > On Tue, Mar 12, 2013 at 11:57:50AM -0700, Bryan Wu wrote: >> On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > >> > + spinlock_t value_lock; > >> I think you don't need this spinlock to protect

Re: [PATCH 2/3] leds: add LED Trigger for camera function

2013-03-13 Thread Bryan Wu
On Wed, Mar 13, 2013 at 4:16 PM, Kim, Milo wrote: >> > +#if defined(CONFIG_LEDS_TRIGGER_CAMERA) || >> defined(CONFIG_LEDS_TRIGGER_CAMERA_MODULE) >> > +extern void ledtrig_flash_ctrl(bool on); >> > +extern void ledtrig_torch_ctrl(bool on); >> > +#else >> > +#define ledtrig_flash_ctrl(x) do {} while

Re: [PATCH v2 0/3] leds: replace macros with inline functions and support camera LED triggers

2013-03-14 Thread Bryan Wu
On Thu, Mar 14, 2013 at 4:29 AM, Kim, Milo wrote: > Patch v2 > (1) LED trigger macros are replaced with inline function in case of > !CONFIG_LED_TRIGGERS and !CONFIG_LEDS_TRIGGER_IDE_DISK. > (2) Use an inline function when CONFIG_LEDS_TRIGGER_CAMERA is not configured. > > Patch v1 > Initia

Re: [PATCH] leds: lp55xx: fix the sysfs read operation

2013-03-14 Thread Bryan Wu
On Thu, Mar 14, 2013 at 5:19 PM, Kim, Milo wrote: > According to a sysfs documentation(Documentation/filesystem/sysfs.txt), > scnprintf() should be used in a read operation method. > It guarantees safe buffer size(PAGE_SIZE) which is allocated by the sysfs. > Oh, I missed that. Great, I merged it

Re: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep

2013-03-15 Thread Bryan Wu
On Tue, Mar 12, 2013 at 3:06 AM, Florian Vaussard wrote: > Hi Bryan, > > > > Bryan, I assume that you'll be taking this? It doesn't apply cleanly to > my tree, probably because of Peter's recent changes that you took > through your tree and Florian based his patches on top of that.

Re: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep

2013-03-15 Thread Bryan Wu
On Fri, Mar 15, 2013 at 1:09 PM, Florian Vaussard wrote: > Hi, > > > On 03/15/2013 07:59 PM, Thierry Reding wrote: >>> >>> >>> Hi Florian and Thierry, >>> >>> Sorry, guys. My bad! I'm using GMAIL filtering my emails. This email >>> goes into my arm-linux mail list archive and I totally missed it.

Re: [PATCH 1/3] leds: move LED trigger drivers into new subdirectory

2013-03-15 Thread Bryan Wu
On Wed, Feb 20, 2013 at 1:29 AM, Kim, Milo wrote: >> For this kind of patches you should really use the "-M" flag of "git >> format-patch" to activate rename detection. The patch becomes much >> more >> readable. For example, the diffstat for this one using -M is: > > Thanks for useful tip! > I

Re: [PATCH 1/3] leds-lp5523: support new LP55231 device

2012-09-04 Thread Bryan Wu
gines. > + If you say yes here you get support for TI/National Semiconductor > + LP5523/55231 LED driver. > + It is 9 channel chip with programmable engines. > Driver provides direct control via LED class and interface for > programming th

Re: [PATCH 2/3] leds-lp5523: add new device id for LP55231

2012-09-04 Thread Bryan Wu
231 }, > { } > }; > > @@ -1013,7 +1019,7 @@ MODULE_DEVICE_TABLE(i2c, lp5523_id); > > static struct i2c_driver lp5523_driver = { > .driver = { > - .name = "lp5523", > + .name = "lp5523x", >

Re: [PATCH 3/3] leds-lp5523: use the i2c device id rather than fixed name

2012-09-04 Thread Bryan Wu
; > - ret = lp5523_init_led(&chip->leds[led], &client->dev, i, > pdata); > + ret = lp5523_init_led(&chip->leds[led], &client->dev, i, > pdata, > + id->name); > if (ret) { >

Re: [PATCH 1/1 v2] leds: Add new LED driver for lm355x chips

2012-09-04 Thread Bryan Wu
t; +{ > + struct lm355x_chip_data *chip = i2c_get_clientdata(client); > + struct lm355x_reg_data *preg = chip->regs; > + flush_workqueue(chip->wqueue); use flush_work(); > + regmap_write(chip->regmap, preg[REG_OPMODE].regno, 0); > + if (chip->type

Re: [PATCH 1/1 v3] leds: Add new LED driver for lm355x chips

2012-09-05 Thread Bryan Wu
_classdev_unregister(&chip->cdev_indicator); > + flush_work_sync(&chip->work_indicator); flush_work_sync() is deprecated, please find "[PATCH 4/6] workqueue: deprecate flush[_delayed]_work_sync()" from Tejun. So I changed this to flush_work() and applied this patch to

Re: [PATCH 1/2] leds-lp5523: turn off the LED engines on unloading the driver

2012-09-12 Thread Bryan Wu
*chip = i2c_get_clientdata(client); > int i; > > + /* Disable engine mode */ > + lp5523_write(client, LP5523_REG_OP_MODE, LP5523_CMD_DISABLED); > + > lp5523_unregister_sysfs(client); > > for (i = 0; i < chip->num_leds; i++) { > -- >

Re: [PATCH 2/2] leds-lp5523: Fix riskiness of the page fault

2012-09-12 Thread Bryan Wu
s-lp5523.c > @@ -759,6 +759,7 @@ static struct attribute *lp5523_attributes[] = { > &dev_attr_engine2_leds.attr, > &dev_attr_engine3_load.attr, > &dev_attr_engine3_leds.attr, > + NULL, > }; > > static const struct attribute_group lp5

Re: [PATCH 1/1] leds: Add new LED driver for lm3642 chips

2012-09-13 Thread Bryan Wu
struct lm3642_chip_data *chip = i2c_get_clientdata(client); > + > + led_classdev_unregister(&chip->cdev_indicator); > + flush_work(&chip->work_indicator); > + device_remove_file(chip->cdev_torch.dev, &dev_attr_torch_pin); > + led_classdev_u

[RFC] [PATCH 0/2] leds: use workqueue in led_set_brightness() API internally

2012-09-14 Thread Bryan Wu
worry about it. With the first patch, we can remove all the workqueue handling code in class drivers. For example, workqueue was removed from leds-gpio.c Bryan Wu (2): leds: use workqueue in led_set_brightness() API internally leds-gpio: remove workqueue in .brightness_set() drivers/led

[PATCH 1/2] leds: use workqueue in led_set_brightness() API internally

2012-09-14 Thread Bryan Wu
r own driver. Also this patch unified the led_set_brightness() and __led_set_brightness() Signed-off-by: Bryan Wu --- drivers/leds/led-class.c | 23 --- drivers/leds/led-core.c | 15 +++ drivers/leds/leds.h | 11 ++- drivers

[PATCH 2/2] leds-gpio: remove workqueue in .brightness_set()

2012-09-14 Thread Bryan Wu
LED core use workqueue internally now, need to use it in the class driver. Signed-off-by: Bryan Wu --- drivers/leds/leds-gpio.c | 43 ++- 1 file changed, 6 insertions(+), 37 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c

Re: [spi-devel-general] [PATCH 2/6] [Blackfin] SPI driver: Use SPI device name to do gpio peripheral request

2008-01-30 Thread Bryan Wu
On Jan 31, 2008 5:48 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 30 January 2008, Bryan Wu wrote: > > When got some gpio conflict, it is easy to know which SPI device driver not > > just got "bfin-spi" > > > > Signed-off-by: Bryan Wu &

[PATCH 11/12 try #2] [Blackfin] serial driver: ADSP-BF52x arch/mach support

2008-01-30 Thread Bryan Wu
Mike Frysinger <[EMAIL PROTECTED]> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/serial/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index d7e1996..5b70d14 100644 --- a/drivers/serial/K

Re: [PATCH] [BLACKFIN] Remove duplicate line discipline definitions

2008-01-31 Thread Bryan Wu
On Thu, 2008-01-31 at 09:51 +0800, Tilman Schmidt wrote: > The definitions of the line discipline numbers N_* have been moved > from asm-*/termios.h to linux/tty.h, but the Blackfin architecture > has somehow evaded that move. Bring it in line with the others. > Thanks a lot. Acked-

Re: [PATCH 23/37] Suspend: Clean up Kconfig (V2)

2008-02-01 Thread Bryan Wu
upport suspend are modified > accordingly. > Thanks, OK for Blackfin Acked-by: Bryan Wu <[EMAIL PROTECTED]> > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> > Acked-by: Russell King <[EMAIL PROTECTED]> > Acked-by: Paul Mackerras <[EMAIL PROTECTED]> > Acke

Re: [spi-devel-general] [PATCH 0/6] [Blackfin] SPI driver updates

2008-02-01 Thread Bryan Wu
On Feb 1, 2008 4:50 AM, David Brownell <[EMAIL PROTECTED]> wrote: > I've forwarded these to Andrew, with my signoff and updated comments. > You still need to work on having your patch descriptions match up > to what the patches actually do... > Thanks a lot, I will try to make it more clearer next

Re: [REVIEW for merge] kbuild updates including silence of section mismatch check

2008-02-02 Thread Bryan Wu
rev=`echo $rev | awk '{print $NF}'` > > + changes=`svn status 2>/dev/null | grep '^[AMD]' | wc -l` > > I prefer to this one. A updated version will be sent out soon. > > or alternatively: > > +if rev=`svn info 2>/dev/null | grep '^Revi

[PATCH try#2 ] kbuild: add svn revision information to setlocalversion

2008-02-02 Thread Bryan Wu
>From 0a7a2c6f19d32a85ca1a7887382325170ef19a66 Mon Sep 17 00:00:00 2001 From: Bryan Wu <[EMAIL PROTECTED]> Date: Sun, 3 Feb 2008 14:05:00 +0800 Subject: [PATCH] [Scripts] add svn revision information to setlocalversion follow git and mercurial style, include uncommitted changes detect

[PATCH try#2] [MTD/MAPS] Blackfin BF5xx Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

2008-02-02 Thread Bryan Wu
>From 974192a0bf168e84370377b835a2858948789088 Mon Sep 17 00:00:00 2001 From: Bryan Wu <[EMAIL PROTECTED]> Date: Sun, 3 Feb 2008 14:27:09 +0800 Subject: [PATCH] [MTD/MAPS] Blackfin BF5xx Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

Re: [PATCH 3/3] Blackfin serial driver: this driver enable SPORTs on Blackfin emulate UART

2008-02-04 Thread Bryan Wu
On Feb 4, 2008 11:35 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > My review comments for this patch remain unaddressed so > I have put it on hold. > -- > I forgot to send out the patch. It will be there soon. Thanks -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-ker

[PATCH 1/1] Input/Touchscreen Driver: add support AD7877 touchscreen driver

2008-02-14 Thread Bryan Wu
ad7877 ts driver not dependent on Blackfin specific cs_change_per_word_option Cc: Dmitry Torokhov <[EMAIL PROTECTED]> Signed-off-by: Michael Hennerich <[EMAIL PROTECTED]> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/input/touchscreen/Kconfig | 13 + driver

Re: linux-next: first tree

2008-02-15 Thread Bryan Wu
On Thu, Feb 14, 2008 at 9:35 PM, Stephen Rothwell <[EMAIL PROTECTED]> wrote: > Hi all, > > I have created the first cut of the linux-next tree at > git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git. > > Things to know about this tree: > > It has two branches - master and stable.

Re: [PATCH] leds: triggers: send uevent when changing triggers

2012-07-25 Thread Bryan Wu
On Thu, Jul 26, 2012 at 11:59 AM, Greg KH wrote: > On Thu, Jul 26, 2012 at 11:29:48AM +0800, Bryan Wu wrote: >> On Thu, Jul 26, 2012 at 2:54 AM, Colin Cross wrote: >> > On Tue, Jul 24, 2012 at 11:11 PM, Bryan Wu wrote: >> >> On Wed, Jul 25, 2012 at 8:32 AM, C

[GIT PULL] LED subsystem update for v3.6

2012-07-26 Thread Bryan Wu
changes up to d45bb11616c94c76c6e40960a120c0687b708a2e: leds-lp8788: forgotten unlock at lp8788_led_work (2012-07-27 08:16:07 +0800) Axel Lin (1): leds: max8997: Simplify max8997_led_set_mode implementation Bryan Wu (22

[PATCH 0/3] add new API to sysfs and device core code

2012-07-26 Thread Bryan Wu
Send out a uevent when create file in sysfs, which is required by userspace application such udev in Android Bryan Wu (3): sysfs: introduce a sysfs_create_file_uevent new API drivers: add a new device_create_file_uevent API ledtrig-timer: convert to use device_create_file_uevent API

[PATCH 1/3] sysfs: introduce a sysfs_create_file_uevent new API

2012-07-26 Thread Bryan Wu
Send a uevent notification whenever a new sysfs file is created to allow userspace processes such as udev to modify permissions on the new files. This new API function helps to do this. Signed-off-by: Bryan Wu --- fs/sysfs/file.c | 28 include/linux/sysfs.h

[PATCH 2/3] drivers: add a new device_create_file_uevent API

2012-07-26 Thread Bryan Wu
This will use sysfs_create_file_uevent to create a sysfs file and send out a uevent to userspace application such as udev. Signed-off-by: Bryan Wu --- drivers/base/core.c| 19 +++ include/linux/device.h | 4 2 files changed, 23 insertions(+) diff --git a/drivers/base

[PATCH 3/3] ledtrig-timer: convert to use device_create_file_uevent API

2012-07-26 Thread Bryan Wu
To send KOBJ_CHANGE uevent to userspace which is required by Android Signed-off-by: Bryan Wu --- drivers/leds/ledtrig-timer.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/leds/ledtrig-timer.c b/drivers/leds/ledtrig-timer.c index 9010f7a..d8b6296 100644 --- a

Re: [PATCH] leds: triggers: send uevent when changing triggers

2012-07-26 Thread Bryan Wu
On Fri, Jul 27, 2012 at 12:51 AM, Greg KH wrote: > On Thu, Jul 26, 2012 at 01:03:11PM +0800, Bryan Wu wrote: >> Just one quick patch for my idea: emitting a uevent in sysfs_create_file(). >> >> -- >> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c >> index 00012e3.

Re: [PATCH 1/3] sysfs: introduce a sysfs_create_file_uevent new API

2012-07-28 Thread Bryan Wu
On Fri, Jul 27, 2012 at 11:52 PM, Greg KH wrote: > On Fri, Jul 27, 2012 at 12:02:41PM +0800, Bryan Wu wrote: >> Send a uevent notification whenever a new sysfs file is created to allow >> userspace processes such as udev to modify permissions on the new files. > > This ma

Re: [GIT PULL] LED CPU trigger driver and ARM LED code consolidation

2012-07-31 Thread Bryan Wu
On Fri, Jun 8, 2012 at 4:20 PM, Olof Johansson wrote: > Hi, > > On Wed, Jun 6, 2012 at 11:12 PM, Bryan Wu wrote: >> Hi Arnd and Olof, >> >> Is there any chance to pull this LED code into ARM SoC tree? >> >> Thanks, >> -Bryan >> >> On Mon,

Re: [GIT PULL] LED CPU trigger driver and ARM LED code consolidation

2012-07-31 Thread Bryan Wu
On Tue, Jul 31, 2012 at 6:15 PM, Russell King - ARM Linux wrote: > On Tue, Jul 31, 2012 at 05:53:41PM +0800, Bryan Wu wrote: >> On Fri, Jun 8, 2012 at 4:20 PM, Olof Johansson wrote: >> > Hi, >> > >> > On Wed, Jun 6, 2012 at 11:12 PM, Bryan Wu wrote: >>

Re: [GIT PULL] LED CPU trigger driver and ARM LED code consolidation

2012-07-31 Thread Bryan Wu
On Tue, Jul 31, 2012 at 7:08 PM, Bryan Wu wrote: > On Tue, Jul 31, 2012 at 6:15 PM, Russell King - ARM Linux > wrote: >> On Tue, Jul 31, 2012 at 05:53:41PM +0800, Bryan Wu wrote: >>> On Fri, Jun 8, 2012 at 4:20 PM, Olof Johansson wrote: >>> > Hi, >>&g

Re: [PATCH] leds: lm3642: Use regmap_update_bits() in lm3642_chip_init()

2012-09-24 Thread Bryan Wu
- >> - reg_val &= (~EX_PIN_ENABLE_MASK); >> - reg_val |= pdata->tx_pin; >> - ret = regmap_write(chip->regmap, REG_ENABLE, reg_val); >> - if (ret < 0) >> - goto out; >> - >> -out: >> - dev_err(chip->dev, &

Re: [PATCH RFT] leds: blinkm: Don't init a workqueue per brightness_set call

2012-10-30 Thread Bryan Wu
On Tue, Oct 30, 2012 at 8:49 PM, Axel Lin wrote: > > > 2012/10/29 Axel Lin >> >> Calling INIT_WORK in blinkm_led_common_set() means we init a workqueue >> every time >> when brightness_set callback is called. >> Move INIT_WORK to blinkm_probe() so we only need to init the workqueue >> once. >> >>

Re: [PATCH] leds: trigger: ledtrig-backlight: Fix invalid memory access in fb_event notification callback

2013-08-26 Thread Bryan Wu
On Tue, Aug 13, 2013 at 4:17 AM, Manfred Schlaegl wrote: > fb_notifier_callback is called on any event fired by fb_notifier_call_chain. > Events may, or may not contain some data (fb_event.data). > In case of FB_EVENT_BLANK fb_event.data contains a pointer to an integer > holding the blank state

Re: [PATCH][resend] leds-gpio: of: led should not be created if its status is disabled

2013-10-02 Thread Bryan Wu
On Thu, Sep 26, 2013 at 4:27 AM, Josh Wu wrote: > now the leds-gpio driver will create every child led node without > checking the status is disabled or not. > > for example, if we have a led node like d3, and its status is disabled: > leds { > d3 { >

Re: [PATCH re-send] leds: support new LP8501 device - another LP55xx common

2013-07-12 Thread Bryan Wu
On Tue, Jul 9, 2013 at 2:11 AM, Kim, Milo wrote: > LP8501 can drive up to 9 channels like LP5523. > LEDs can be controlled directly via the I2C and programmable engines are > supported. > > LP55xx common driver > LP8501 is one of LP55xx family device, so LP55xx common code are used. > Chip speci

Re: [gcv v3 18/35] drivers/leds: Replace __get_cpu_var uses

2013-09-03 Thread Bryan Wu
Index: linux/drivers/leds/trigger/ledtrig-cpu.c > === > --- linux.orig/drivers/leds/trigger/ledtrig-cpu.c 2013-08-27 > 14:46:42.043176071 -0500 > +++ linux/drivers/leds/trigger/ledtrig-cpu.c2013-08-27 14:

Re: [PATCH] leds-gpio: of: led should not be created if its status is disabled

2013-09-24 Thread Bryan Wu
On Tue, Sep 24, 2013 at 1:04 AM, Josh Wu wrote: > now the leds-gpio driver will create every child led node without > checking the status is disabled or not. > > for example, if we have a led node like d3, and its status is disabled: > leds { > d3 { >

[GIT PULL] LED subsystem update for v3.7

2012-10-08 Thread Bryan Wu
Hi Linus, Please consider to pull the following changes since commit 55d512e245bc7699a8800e23df1a24195dd08217: Linux 3.6-rc5 (2012-09-08 16:43:45 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for-next for you to fetch c

Re: [PATCH v2 1/3] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-03 Thread Bryan Wu
On Mon, Dec 3, 2012 at 6:13 AM, Peter Ujfalusi wrote: > Hi Bryan, > > On 11/14/2012 02:14 AM, Bryan Wu wrote: >> On Mon, Nov 12, 2012 at 6:41 AM, Peter Ujfalusi >> wrote: >>> Update the driver to use the new API for requesting pwm so we can take >>> advant

Re: [patch] leds: leds-lp5521: return an error code on error in probe()

2012-12-03 Thread Bryan Wu
On Sun, Dec 2, 2012 at 9:29 AM, Dan Carpenter wrote: > If "buf" wasn't equal to LP5521_REG_R_CURR_DEFAULT the probe fails but > we still return zero. I've changed it to print an error message and > return -EINVAL. > Looks fine with me, I applied it to my for-next branch. -Bryan > Reported-by:

Re: [PATCH v4 2/2] Add documentation for tca6507 devicetree bindings.

2012-12-03 Thread Bryan Wu
On Fri, Nov 30, 2012 at 2:00 PM, Marek Belisko wrote: > Signed-off-by: Marek Belisko > --- > Documentation/devicetree/bindings/leds/tca6507.txt | 33 > > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/tca6507.txt > > diff --g

Re: [PATCH v4 2/2] Add documentation for tca6507 devicetree bindings.

2012-12-03 Thread Bryan Wu
On Mon, Dec 3, 2012 at 3:21 PM, Belisko Marek wrote: > On Mon, Dec 3, 2012 at 8:29 PM, Bryan Wu wrote: >> On Fri, Nov 30, 2012 at 2:00 PM, Marek Belisko >> wrote: >>> Signed-off-by: Marek Belisko >>> --- >>> Documentation/d

Re: [PATCH v4 1/2] leds/tca6507: Add support for devicetree.

2012-12-03 Thread Bryan Wu
Looks like this patch is based on linux-next tree, I fixed this. And I will solve the conflict when we do actually merge in next cycle. -Bryan On Fri, Nov 30, 2012 at 2:00 PM, Marek Belisko wrote: > Support added only for leds (not for gpio's). > > Signed-off-by: Marek Belisko > --- > Changes f

Re: [PATCH v2 1/3] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-04 Thread Bryan Wu
On Tue, Dec 4, 2012 at 12:11 AM, Peter Ujfalusi wrote: > Hi Bryan, > > On 12/03/2012 07:32 PM, Bryan Wu wrote: >> On Mon, Dec 3, 2012 at 6:13 AM, Peter Ujfalusi wrote: >> Actually, I'm waiting for some feedback from DT maintainers about this >> new binding. But i

[PATCH] ledtrig-cpu: use spin_lock to replace mutex lock

2012-10-18 Thread Bryan Wu
te+0x4d/0x7a [] tracesys+0xdd/0xe2 --- This patch replace mutex lock with spin lock which is safe for this case. Reported-by: Miles Lane Reported-by: Rafael J. Wysocki Cc: Linus Walleij Signed-off-by: Bryan Wu --- drivers/leds/ledtrig-cpu.c | 21 ++--- 1 file changed, 10 ins

Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock

2012-10-18 Thread Bryan Wu
t 11:18 AM, Bryan Wu wrote: > Mutex lock is not safe in atomic context like the bug reported by > Miles Lane: > > --- > ACPI: Preparing to enter system sleep state S3 > PM: Saving platform NVS memory > Disabling non-boot CPUs ... > numa_remove_cpu cpu 1 node 0: mask

Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock

2012-10-18 Thread Bryan Wu
On Thu, Oct 18, 2012 at 11:35 AM, Linus Walleij wrote: > On Thu, Oct 18, 2012 at 8:18 PM, Bryan Wu wrote: > >> Mutex lock is not safe in atomic context like the bug reported by >> Miles Lane: > (...) >> This patch replace mutex lock with spin lock which is safe for t

Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock

2012-10-22 Thread Bryan Wu
Hiya, Can I get some Acked or Tested-by from Rafael or Miles before I put it in my linux-leds tree? Thanks, -Bryan On Thu, Oct 18, 2012 at 12:34 PM, Bryan Wu wrote: > On Thu, Oct 18, 2012 at 11:35 AM, Linus Walleij > wrote: >> On Thu, Oct 18, 2012 at 8:18 PM, Bryan Wu wrote:

Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock

2012-10-22 Thread Bryan Wu
On Mon, Oct 22, 2012 at 3:28 PM, Nathan Lynch wrote: > Hi Bryan, > > On Thu, 2012-10-18 at 11:18 -0700, Bryan Wu wrote: >> @@ -117,14 +117,14 @@ static int __init ledtrig_cpu_init(void) >> for_each_possible_cpu(cpu) { >> struct led_trigger_cpu *tr

Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock

2012-10-22 Thread Bryan Wu
On Mon, Oct 22, 2012 at 3:38 PM, Rafael J. Wysocki wrote: > On Monday 22 of October 2012 11:59:19 Bryan Wu wrote: >> Hiya, >> >> Can I get some Acked or Tested-by from Rafael or Miles before I put it >> in my linux-leds tree? > > Well, I just explained

Re: [PATCH 4/4] MAINTAINERS: add LP8788 MFD driver entry

2012-12-10 Thread Bryan Wu
On Sun, Dec 9, 2012 at 9:27 PM, Kim, Milo wrote: > Cc: Anton Vorontsov > Cc: Bryan Wu > Cc: Jonathan Cameron > Cc: Mark Brown > Cc: Samuel Ortiz > Signed-off-by: Milo(Woogyom) Kim Acked-by: Bryan Wu Thanks, -Bryan > --- > MAINTAINERS | 10 ++ > 1

[GIT PULL] a LED fix for 3.7

2012-11-11 Thread Bryan Wu
Hi Linus, Please consider the following changes since commit 77b67063bb6bce6d475e910d3b886a606d0d91f7: Linux 3.7-rc5 (2012-11-11 13:44:33 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git fixes-for-3.7 for you to fetch chan

Re: [PATCH v2 RESEND] leds: add led_trigger_rename function

2012-11-13 Thread Bryan Wu
On Sun, Nov 4, 2012 at 1:54 AM, Fabio Baltieri wrote: > Implements a "led_trigger_rename" function to rename a trigger with > proper locking. > > This assumes that led name was originally allocated in non-constant > storage. > > Signed-off-by: Fabio Baltieri >

Re: [PATCH v3 1/2] leds/tca6507: Add support for devicetree.

2012-11-13 Thread Bryan Wu
On Mon, Nov 12, 2012 at 1:25 PM, Marek Belisko wrote: > Support added only for leds (not for gpio's). > > Signed-off-by: Marek Belisko > --- > > Changes from v2: > - change compatible property to "ti,tca6507" > - add documentation for linux,default-trigger > > Changes from v1: > - return proper e

Re: [PATCH v3 2/2] Add documentation for tca6507 devicetree bindings.

2012-11-13 Thread Bryan Wu
It looks fine to me, but I need a DT maintainer's ack. Stephen, could you help on this. I will merge this patch via my tree. Thanks, -Bryan On Mon, Nov 12, 2012 at 1:25 PM, Marek Belisko wrote: > Signed-off-by: Marek Belisko > --- > Documentation/devicetree/bindings/leds/tca6507.txt | 40 >

Re: [PATCH v2 1/3] leds: leds-pwm: Convert to use devm_get_pwm

2012-11-13 Thread Bryan Wu
On Mon, Nov 12, 2012 at 6:41 AM, Peter Ujfalusi wrote: > Update the driver to use the new API for requesting pwm so we can take > advantage of the pwm_lookup table to find the correct pwm to be used for the > LED functionality. > If the devm_get_pwm fails we fall back to legacy mode to try to get

Re: [PATCH v3 2/2] Add documentation for tca6507 devicetree bindings.

2012-11-14 Thread Bryan Wu
On Wed, Nov 14, 2012 at 11:26 AM, Stephen Warren wrote: > On 11/13/2012 06:05 PM, Bryan Wu wrote: >> It looks fine to me, but I need a DT maintainer's ack. Stephen, could >> you help on this. I will merge this patch via my tree. > > I'm not actually a DT maintain

Re: [PATCH v2 RESEND] leds: add led_trigger_rename function

2012-11-14 Thread Bryan Wu
OK, I will apply this patch to my tree. Thanks, -Bryan On Wed, Nov 14, 2012 at 12:30 AM, Fabio Baltieri wrote: > Hi Bryan, > > On Tue, Nov 13, 2012 at 04:33:14PM -0800, Bryan Wu wrote: >> > +void led_trigger_rename_static(const char *name, struct led_trigger *trig) >>

Re: [PATCH] ledtrig-cpu: kill useless mutex to fix sleep in atomic context

2012-11-05 Thread Bryan Wu
On Mon, Nov 5, 2012 at 6:20 AM, Nathan Lynch wrote: > Seeing the following every time the CPU enters or leaves idle on a > Beagleboard: > > BUG: sleeping function called from invalid context at kernel/mutex.c:269 > in_atomic(): 1, irqs_disabled(): 0, pid: 0, name: swapper/0 > no locks held by swap

Re: [PATCH 1/2] leds/tca6507: Add support for devicetree.

2012-11-06 Thread Bryan Wu
On Tue, Oct 30, 2012 at 2:45 PM, Marek Belisko wrote: > Support added only for leds (not for gpio's). > > Signed-off-by: Marek Belisko > --- > drivers/leds/leds-tca6507.c | 73 > +-- > 1 file changed, 70 insertions(+), 3 deletions(-) > Overall, this lo

Re: [PATCH 1/2] leds/tca6507: Add support for devicetree.

2012-11-06 Thread Bryan Wu
On Tue, Nov 6, 2012 at 12:32 PM, Belisko Marek wrote: > Hi, > > On Tue, Nov 6, 2012 at 7:24 PM, Bryan Wu wrote: >> >> On Tue, Oct 30, 2012 at 2:45 PM, Marek Belisko >> wrote: >> > Support added only for leds (not for gpio's). >> > >> >

Re: [PATCH RESEND] leds: leds-gpio: Defer probing in case of deferred gpio probing

2012-11-07 Thread Bryan Wu
On Wed, Nov 7, 2012 at 5:06 AM, Roland Stigge wrote: > This patch makes leds-gpio's probe() return -EPROBE_DEFER if any of the gpios > to register are deferred themselves. This makes a change of > gpio_leds_create_of()'s return value necessary: Instead of returning NULL on > error, we now use ERR_

Re: [PATCH] leds: leds-pwm: Convert to use devm_get_pwm

2012-11-09 Thread Bryan Wu
On Wed, Nov 7, 2012 at 3:42 AM, Peter Ujfalusi wrote: > Update the driver to use the new API for requesting pwm so we can take > advantage of the pwm_lookup table to find the correct pwm to be used for the > LED functionality. > If the devm_get_pwm fails we fall back to legacy mode to try to get t

[GIT PULL] a LED fix for 3.8

2013-01-02 Thread Bryan Wu
Hi Linus: Please consider the following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: Linux 3.8-rc1 (2012-12-21 17:19:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git fixes-for-3.8 for you to fetch chan

Re: [GIT PULL] a LED fix for 3.8

2013-01-02 Thread Bryan Wu
Sorry, I signed off with wrong email address. Please ignore this pull request email. I will resent one. -Bryan On Wed, Jan 2, 2013 at 5:50 PM, Bryan Wu wrote: > Hi Linus: > > Please consider the following changes since commit > a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: > > L

[GIT PULL] a LED fix for 3.8 (try2)

2013-01-02 Thread Bryan Wu
Hi Linus: Please consider the following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565: Linux 3.8-rc1 (2012-12-21 17:19:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git for you to fetch changes up to 2d7c

Re: [PATCH v5 0/7] leds: leds-pwm: Device tree support

2013-01-02 Thread Bryan Wu
nding documentation changed to reflect the changes > > Changes since v1: > - As suggested by Bryan Wu: the legacy pwm_request() has been removed from > patch 1 > - Device tree bindings added for leds-pwm driver. > > When we boot with Device tree we handle one LED per device to b

Re: [PATCH v5 0/7] leds: leds-pwm: Device tree support

2013-01-03 Thread Bryan Wu
On Wed, Jan 2, 2013 at 11:22 PM, Thierry Reding wrote: > On Wed, Jan 02, 2013 at 06:10:13PM -0800, Bryan Wu wrote: >> Hi Peter, >> >> I merged this patchset into my for-next branch already. >> >> Thanks for pushing this. > > Hi Bryan, > > Did you al

Re: [PATCH] leds-lp8788: fix a parent device in _probe()

2013-01-03 Thread Bryan Wu
On Wed, Jan 2, 2013 at 10:28 PM, Kim, Milo wrote: > The lp8788-keyled is a platform driver of lp8788-mfd. > The platform device is allocated when mfd_add_devices() is called > in lp8788-mfd. > On the other hand, 'lp->dev' is the i2c client device. > > Therefore, this 'platform_device' is a pr

Re: [PATCH 00/33] leds: cleanup LP5521/5523 LED driver

2013-01-04 Thread Bryan Wu
On Thu, Dec 20, 2012 at 4:17 PM, Kim, Milo wrote: >> Hi Kim >> >> This patchset looks good, but I need some time to review it more >> carefully especially during this merge window + holiday time. > > OK, thanks for the reply. > Please let me know if any problem in the git tree. > Happy holidays! >

Re: [PATCH 00/33] leds: cleanup LP5521/5523 LED driver

2012-12-18 Thread Bryan Wu
Hi Kim This patchset looks good, but I need some time to review it more carefully especially during this merge window + holiday time. Thanks, -Bryan On Wed, Dec 12, 2012 at 5:59 AM, Kim, Milo wrote: > LP5521, LP5523 and L55231 have common features as below. > > Register access via the I2C. >

Re: [RFC PATCH] led: add Cycle LED trigger.

2013-06-20 Thread Bryan Wu
On Thu, Jun 20, 2013 at 2:44 AM, Gaël PORTAY wrote: > On 19/06/2013 00:05, Joe Perches wrote: >> >> On Tue, 2013-06-18 at 18:24 +0200, Gaël PORTAY wrote: >>> >>> Currently, none of available triggers supports playing with the LED >>> brightness >>> level. The cycle trigger provides a way to defin

Re: [PATCH] leds: Convert led class driver from legacy pm ops to dev_pm_ops

2013-06-20 Thread Bryan Wu
On Thu, Jun 20, 2013 at 12:08 PM, Shuah Khan wrote: > Convert drivers/leds/led-class to use dev_pm_ops for power management and > remove Legacy PM ops hooks. With this change, led class registers > suspend/resume callbacks via class->pm (dev_pm_ops) instead of Legacy > class->suspend/resume. When

[GIT PULL] leds: updates for 3.11

2013-07-02 Thread Bryan Wu
Hi Linus, LED subsystem updates for 3.11: - lp55xx device tree updates - mc13xxx driver updates - some clean up So please consider the following changes since commit 7d132055814ef17a6c7b69f342244c410a5e000f: Linux 3.10-rc6 (2013-06-15 11:51:07 -1000) are available in the git repository at:

Re: [PATCH 1/2] leds: lp55xx: use common clock framework when external clock is used

2013-03-25 Thread Bryan Wu
On Wed, Mar 20, 2013 at 5:37 PM, Kim, Milo wrote: > Program execution is timed with 32768Hz clock in the LP55xx family devices. > To run LED functionalities, LP55xx devices provide two options. > One is using internal clock. The other is using external clock. > This patch enables external clock de

Re: [PATCH v4 1/5] leds-pca9633: Add support for PCA9634

2013-08-14 Thread Bryan Wu
On Wed, Aug 14, 2013 at 12:14 AM, Ricardo Ribalda Delgado wrote: > Add support for PCA9634 chip, which belongs to the same family as the > 9633 but with support for 8 outputs instead of 4. > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/leds/Kconfig|7 +-- > drivers/leds/l

Re: [PATCH v4 0/5] PCA9633: Add support to PCA9634 and fix some problems

2013-08-16 Thread Bryan Wu
register with a mutex to support updates of more than leds at > the same time > Fix device tree parsing > > v5: Contains feedback from Bryan Wu > Bryan: Fix device tree bindings documentation > Thanks, I've already merged this new patchset into my tree. -Bryan > v4: Rebase

Re: leds-lp5523: Broken commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0

2013-08-05 Thread Bryan Wu
On Mon, Aug 5, 2013 at 12:31 AM, Pali Rohár wrote: > On Monday 05 August 2013 09:26:46 Kim, Milo wrote: >> > Hello, >> > >> > git commit "leds-lp5523: use generic firmware interface" >> > db6eaf8388a413a5ee1b4547ce78506b9c6456b0 introduced in >> > kernel 3.10 changed user space API for modifing lp

Re: [PATCH v2 1/3] leds-pca9633: Add support for PCA9634

2013-08-08 Thread Bryan Wu
On Thu, Aug 8, 2013 at 9:45 AM, Ricardo Ribalda Delgado wrote: > Add support for PCA9634 chip, which belongs to the same family as the > 9633 but with support for 8 outputs instead of 4. > Basically I like this method to add a new chip supporting. Please find my comments below. > Signed-off-by:

Re: [PATCH v2 2/3] leds-pca9633: Unique naming of the LEDs

2013-08-08 Thread Bryan Wu
On Thu, Aug 8, 2013 at 9:45 AM, Ricardo Ribalda Delgado wrote: > If there is more than one pca963x chips on the system and there are > some LEDs without platform_data names, the driver wont be able to > provide unique naming to them. > > This will cause led_class_dev_register to fail, unregisterin

Re: [PATCH v2 1/3] leds-pca9633: Add support for PCA9634

2013-08-08 Thread Bryan Wu
On Thu, Aug 8, 2013 at 3:36 PM, Peter Meerwald wrote: > Hello, > >> > Add support for PCA9634 chip, which belongs to the same family as the >> > 9633 but with support for 8 outputs instead of 4. > >> Basically I like this method to add a new chip supporting. Please find >> my comments below. > > m

Re: [PATCH 10/36] leds: convert class code to use dev_groups

2013-07-26 Thread Bryan Wu
On Wed, Jul 24, 2013 at 3:05 PM, Greg Kroah-Hartman wrote: > The dev_attrs field of struct class is going away soon, dev_groups > should be used instead. This converts the led class code to use the > correct field. > > Cc: Bryan Wu > Cc: Richard Purdie > Signed-off-b

Re: [PATCH v3 1/4] leds-pca9633: Add support for PCA9634

2013-08-13 Thread Bryan Wu
On Tue, Aug 13, 2013 at 7:49 AM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > Did you have a chance to look at the new series? > Sorry for the delay. I have no problem for this series. Could you please rebase to my tree's for-next branch [1]? And post again? Because recently there were severa

  1   2   3   4   5   6   7   8   >