Re: [PATCH v3 09/14] ARM: tegra: acer-a500: Rename avdd to vdda of touchscreen node

2021-03-24 Thread Dmitry Osipenko
24.03.2021 18:11, Thierry Reding пишет: > On Tue, Mar 02, 2021 at 03:09:58PM +0300, Dmitry Osipenko wrote: >> Rename avdd supply to vdda of the touchscreen node. The old supply name >> was incorrect. >> >> Signed-off-by: Dmitry Osipenko >> --- >> arch/arm

Re: [PATCH] mm: cma: fix corruption cma_sysfs_alloc_pages_count

2021-03-24 Thread Dmitry Osipenko
24.03.2021 22:20, Minchan Kim пишет: > static int __init cma_sysfs_init(void) > { > - int i = 0; > + struct kobject *cma_kobj_root; > + struct cma_kobject *cma_kobj; > struct cma *cma; > + unsigned int i; > while (--i >= 0) { Do you realize that this doesn't work any

Re: [PATCH] mm: cma: fix corruption cma_sysfs_alloc_pages_count

2021-03-24 Thread Dmitry Osipenko
24.03.2021 22:43, Dmitry Osipenko пишет: > 24.03.2021 22:20, Minchan Kim пишет: >> static int __init cma_sysfs_init(void) >> { >> -int i = 0; >> +struct kobject *cma_kobj_root; >> +struct cma_kobject *cma_kobj; >> struct cma *cma; >&g

Re: [PATCH] mm: cma: fix corruption cma_sysfs_alloc_pages_count

2021-03-24 Thread Dmitry Osipenko
24.03.2021 22:57, Minchan Kim пишет: > On Wed, Mar 24, 2021 at 10:49:58PM +0300, Dmitry Osipenko wrote: >> 24.03.2021 22:43, Dmitry Osipenko пишет: >>> 24.03.2021 22:20, Minchan Kim пишет: >>>> static int __init cma_sysfs_init(void) >>>> { >>>&g

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
ttps://lore.kernel.org/linux-mm/ycoamxqt6dzkc...@kroah.com/ > > Reported-by: Dmitry Osipenko > Tested-by: Dmitry Osipenko > Suggested-by: Dmitry Osipenko The tags are incorrect, I haven't suggested this change. > Suggested-by: John Hubbard > Suggested-by: Matth

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 00:31, Dmitry Osipenko пишет: >> Reported-by: Dmitry Osipenko >> Tested-by: Dmitry Osipenko >> Suggested-by: Dmitry Osipenko > The tags are incorrect, I haven't suggested this change. The reported-by also should be removed.

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 01:01, John Hubbard пишет: > On 3/24/21 2:31 PM, Dmitry Osipenko wrote: >> ... >>> +#include >>> + >>> +struct cma_kobject { >>> +    struct cma *cma; >>> +    struct kobject kobj; >> >> If you'll place the kobj

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 00:55, Minchan Kim пишет: >> There are no dereferences fixed by this patch. > Let me add this: > https://lore.kernel.org/linux-mm/20210316100433.17665-1-colin.k...@canonical.com/ > The tag is invalid now, since you squashed the fix. I think you may add "Co-developed-by: Colin Ian King

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 01:10, Dmitry Osipenko пишет: > 25.03.2021 00:55, Minchan Kim пишет: >>> There are no dereferences fixed by this patch. >> Let me add this: >> https://lore.kernel.org/linux-mm/20210316100433.17665-1-colin.k...@canonical.com/ >> > > The tag is invali

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 00:55, Minchan Kim пишет: >>> +static ssize_t alloc_pages_success_show(struct kobject *kobj, >>> + struct kobj_attribute *attr, char *buf) >>> +{ >>> + struct cma *cma = cma_from_kobj(kobj); >>> + >>> + return sysfs_emit(buf, "%llu\n", >>> +

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 00:55, Minchan Kim пишет: >> The tags are incorrect, I haven't suggested this change. > During the development, you have suggested many things > to make it clean. That suggested-by couldn't represent > all the detail but wanted to give credit for you, too > since you spent the time to ma

Re: [PATCH v7] mm: cma: support sysfs

2021-03-24 Thread Dmitry Osipenko
25.03.2021 01:23, John Hubbard пишет: > On 3/24/21 3:11 PM, Dmitry Osipenko wrote: >> 25.03.2021 01:01, John Hubbard пишет: >>> On 3/24/21 2:31 PM, Dmitry Osipenko wrote: >>>> ... >>>>> +#include >>>>> + >>>>> +stru

Re: [PATCH v4 5/5] soc/tegra: pmc: Rate-limit error message about failed to acquire of reset

2021-03-25 Thread Dmitry Osipenko
25.03.2021 17:42, Thierry Reding пишет: > On Tue, Mar 02, 2021 at 03:25:02PM +0300, Dmitry Osipenko wrote: >> PMC domain could be easily bombarded with the enable requests if there is >> a problem in regards to acquiring reset control of a domain and kernel >> log will be f

Re: [PATCH v4 3/5] soc/tegra: pmc: Ensure that clock rates aren't too high

2021-03-25 Thread Dmitry Osipenko
25.03.2021 17:39, Thierry Reding пишет: > On Tue, Mar 02, 2021 at 03:25:00PM +0300, Dmitry Osipenko wrote: >> Switch all clocks of a power domain to a safe rate which is suitable >> for all possible voltages in order to ensure that hardware constraints >> aren't violat

Re: [PATCH v4 3/5] soc/tegra: pmc: Ensure that clock rates aren't too high

2021-03-25 Thread Dmitry Osipenko
25.03.2021 18:02, Dmitry Osipenko пишет: > 25.03.2021 17:39, Thierry Reding пишет: >> On Tue, Mar 02, 2021 at 03:25:00PM +0300, Dmitry Osipenko wrote: >>> Switch all clocks of a power domain to a safe rate which is suitable >>> for all possible voltages in order to ensur

Re: [PATCH v1 1/2] memory: tegra20: Correct comment to MC_STAT registers writes

2021-03-25 Thread Dmitry Osipenko
24.03.2021 00:04, Dmitry Osipenko пишет: > The code was changed multiple times and the comment to MC_STAT > registers writes became slightly outdated. The MC_STAT programming > now isn't hardcoded to the "bandwidth" mode, let's clarify this in > the comment. >

Re: [PATCH v4 3/6] dt-bindings: power: tegra: Add binding for core power domain

2021-03-25 Thread Dmitry Osipenko
25.03.2021 17:49, Thierry Reding пишет: > On Wed, Mar 24, 2021 at 02:01:29AM +0300, Dmitry Osipenko wrote: >> 24.03.2021 01:48, Rob Herring пишет: >>> On Sun, Mar 14, 2021 at 07:48:07PM +0300, Dmitry Osipenko wrote: >>>> All NVIDIA Tegra SoCs have a core power dom

Re: [PATCH v1] memory: tegra20: Add debug statistics

2021-03-18 Thread Dmitry Osipenko
18.03.2021 18:23, Krzysztof Kozlowski пишет: ... >> +mc->debugfs.root = debugfs_create_dir("mc", NULL); >> +if (!mc->debugfs.root) >> +dev_err(&pdev->dev, "failed to create debugfs directory\n"); > > It's error pointer, not null, but anyway there is no need for handling > debug

Re: [PATCH v1] memory: tegra20: Add debug statistics

2021-03-18 Thread Dmitry Osipenko
18.03.2021 19:20, Krzysztof Kozlowski пишет: > On 18/03/2021 17:18, Dmitry Osipenko wrote: >> 18.03.2021 18:23, Krzysztof Kozlowski пишет: >> >>>> + >>>> + /* collect memory controller utilization percent for each client */ >>>&

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
09.03.2021 09:23, Minchan Kim пишет: > Since CMA is getting used more widely, it's more important to > keep monitoring CMA statistics for system health since it's > directly related to user experience. > > This patch introduces sysfs statistics for CMA, in order to provide > some basic monitoring

[PATCH v2] memory: tegra20: Add debug statistics

2021-03-19 Thread Dmitry Osipenko
oven to be useful by helping to improve memory bandwidth management of the display driver. Signed-off-by: Dmitry Osipenko --- Changelog: v2: - Removed handling of debugfs creation errors. - Added more consts to the code. - Reduced scope of local variables. - Switc

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 15:44, Dmitry Osipenko пишет: ... >> #include >> +#include >> + >> +struct cma_stat { >> +spinlock_t lock; >> +/* the number of CMA page successful allocations */ >> +unsigned long nr_pages_succeeded; >> +

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 16:42, Greg Kroah-Hartman пишет: > On Fri, Mar 19, 2021 at 04:39:41PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 15:44, Dmitry Osipenko пишет: >> ... >>>> #include >>>> +#include >>>> + >>>> +struct cma_stat { >&g

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 16:39, Dmitry Osipenko пишет: > 19.03.2021 15:44, Dmitry Osipenko пишет: > ... >>> #include >>> +#include >>> + >>> +struct cma_stat { >>> + spinlock_t lock; >>> + /* the number of CMA page successful allocations */ >

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 16:47, Greg Kroah-Hartman пишет: > On Fri, Mar 19, 2021 at 04:45:21PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 16:42, Greg Kroah-Hartman пишет: >>> On Fri, Mar 19, 2021 at 04:39:41PM +0300, Dmitry Osipenko wrote: >>>> 19.03.2021 15:44, Dmitry Osipenko пи

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 16:51, Dmitry Osipenko пишет: > 19.03.2021 16:47, Greg Kroah-Hartman пишет: >> On Fri, Mar 19, 2021 at 04:45:21PM +0300, Dmitry Osipenko wrote: >>> 19.03.2021 16:42, Greg Kroah-Hartman пишет: >>>> On Fri, Mar 19, 2021 at 04:39:41PM +0300, Dmitry Osipenko

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 17:27, Greg Kroah-Hartman пишет: > On Fri, Mar 19, 2021 at 05:19:47PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 16:51, Dmitry Osipenko пишет: >>> 19.03.2021 16:47, Greg Kroah-Hartman пишет: >>>> On Fri, Mar 19, 2021 at 04:45:21PM +0300, Dmitry Osipenko

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 18:50, Greg Kroah-Hartman пишет: >> Then initialization order won't be a problem. > I don't understand the problem here, what is wrong with the patch as-is? The cma->stat is NULL at the time when CMA is used on ARM because cma->stat is initialized at the subsys level. This is the proble

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 19:30, Minchan Kim пишет: > On Fri, Mar 19, 2021 at 07:24:05PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 18:50, Greg Kroah-Hartman пишет: >>>> Then initialization order won't be a problem. >>> I don't understand the problem here, what is wrong w

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 20:29, Dmitry Osipenko пишет: > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count) > +{ > + atomic64_add(count, &cma->nr_pages_succeeded); > +} > + > +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count) > +{ > + atomic64_a

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 20:41, Dmitry Osipenko пишет: > 19.03.2021 20:29, Dmitry Osipenko пишет: >> +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count) >> +{ >> +atomic64_add(count, &cma->nr_pages_succeeded); >> +} >> + >> +void cma_sysfs_

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 19:30, Minchan Kim пишет: > +static void cma_kobj_release(struct kobject *kobj) > +{ > + struct cma_kobject *cma_kobj = container_of(kobj, struct cma_kobject, > kobj); > + > + kfree(cma_kobj); > +} Oh, wait.. I think this kfree wrong since cma_kobj belongs to the array.

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 21:21, Minchan Kim пишет: > On Fri, Mar 19, 2021 at 08:56:06PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 19:30, Minchan Kim пишет: >>> +static void cma_kobj_release(struct kobject *kobj) >>> +{ >>> + struct cma_kobject *cma_kobj = container_of

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 21:18, Minchan Kim пишет: >>> + if (ZERO_OR_NULL_PTR(cma_kobjs)) >>> + goto out; >>> + >>> + do { >>> + cma = &cma_areas[i]; >>> + cma->kobj = &cma_kobjs[i]; >> Does cma really need are pointer to cma_kobj? > Do you mean something like this? > > struct

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 21:18, Minchan Kim пишет: >>> +#define CMA_ATTR_RO(_name) \ >>> + static struct kobj_attribute _name##_attr = __ATTR_RO(_name) >>> + >>> +static ssize_t alloc_pages_success_show(struct kobject *kobj, >>> + struct kobj_attribute *attr, char *buf) >> The indentations ar

Re: [PATCH v4] mm: cma: support sysfs

2021-03-19 Thread Dmitry Osipenko
19.03.2021 22:03, Minchan Kim пишет: > On Fri, Mar 19, 2021 at 09:48:11PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 21:21, Minchan Kim пишет: >>> On Fri, Mar 19, 2021 at 08:56:06PM +0300, Dmitry Osipenko wrote: >>>> 19.03.2021 19:30, Minchan Kim пишет: >>>

[PATCH v1 1/2] ARM: multi_v7_defconfig: Stop using deprecated USB_EHCI_TEGRA

2021-03-20 Thread Dmitry Osipenko
The USB_EHCI_TEGRA option is deprecated now and replaced by USB_CHIPIDEA_TEGRA. Replace USB_EHCI_TEGRA with USB_CHIPIDEA_TEGRA in multi_v7_defconfig. Signed-off-by: Dmitry Osipenko --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch

[PATCH v1 2/2] usb: host: ehci-tegra: Select USB_GADGET Kconfig option

2021-03-20 Thread Dmitry Osipenko
: ehci-tegra: Remove the driver") Reported-by: kernel test robot Signed-off-by: Dmitry Osipenko --- drivers/usb/host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index b94f2a070c05..df9428f1dc5e 100644 --- a/drivers/usb/host/

[PATCH v1 1/2] memory: tegra20: Correct comment to MC_STAT registers writes

2021-03-23 Thread Dmitry Osipenko
The code was changed multiple times and the comment to MC_STAT registers writes became slightly outdated. The MC_STAT programming now isn't hardcoded to the "bandwidth" mode, let's clarify this in the comment. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra20

[PATCH v1 2/2] memory: tegra20: Protect debug code with a lock

2021-03-23 Thread Dmitry Osipenko
Simultaneous accesses to MC_STAT h/w shouldn't be allowed since one collection process stomps on another. There is no good reason for polling stats in parallel in practice, nevertheless let's add a protection lock, just for consistency. Signed-off-by: Dmitry Osipenko --- drivers/me

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Dmitry Osipenko
23.03.2021 22:50, Minchan Kim пишет: > Since CMA is getting used more widely, it's more important to > keep monitoring CMA statistics for system health since it's > directly related to user experience. > > This patch introduces sysfs statistics for CMA, in order to provide > some basic monitoring

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Dmitry Osipenko
24.03.2021 00:19, Dmitry Osipenko пишет: >> +if (!kobj) >> +goto out; >> + >> +kobj->cma = cma; >> +cma->kobj = kobj; >> +if (kobject

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Dmitry Osipenko
23.03.2021 22:50, Minchan Kim пишет: > +#ifdef CONFIG_CMA_SYSFS > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count); > +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count); I'd also rename cma_sysfs_alloc_pages_count to cma_sysfs_account_success_pages and cma_sysfs_fail_p

Re: [PATCH v4 3/6] dt-bindings: power: tegra: Add binding for core power domain

2021-03-23 Thread Dmitry Osipenko
24.03.2021 01:48, Rob Herring пишет: > On Sun, Mar 14, 2021 at 07:48:07PM +0300, Dmitry Osipenko wrote: >> All NVIDIA Tegra SoCs have a core power domain where majority of hardware >> blocks reside. Add binding for the core power domain. >> >> Signed-off-by: Dmitry Osi

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-04 Thread Dmitry Osipenko
04.03.2021 02:08, Michał Mirosław пишет: > On Tue, Mar 02, 2021 at 03:44:44PM +0300, Dmitry Osipenko wrote: >> Display controller (DC) performs isochronous memory transfers, and thus, >> has a requirement for a minimum memory bandwidth that shall be fulfilled, >> otherwise f

Re: [PATCH v1 4/5] cpuidle: Add Tegra194 cpuidle driver

2021-03-05 Thread Dmitry Osipenko
04.03.2021 09:08, Sowjanya Komatineni пишет: ... > +static int __init tegra194_cpuidle_probe(struct platform_device *pdev) > +{ > + struct cpumask *cpumask; > + int cpu, ret; > + > + if (!check_mce_version()) { > + pr_err("cpuidle: incompatible MCE version, cannot register

Re: [PATCH v1 4/6] dt-bindings: memory: tegra20: mc: Convert to schema

2021-03-30 Thread Dmitry Osipenko
30.03.2021 11:37, Krzysztof Kozlowski пишет: >> +properties: >> + compatible: >> +const: nvidia,tegra20-mc-gart >> + >> + reg: >> +minItems: 1 >> +maxItems: 2 > I think you always need two regs, don't you? If so, then better to use > "description" like in > Documentation/devicetree/bi

Re: [PATCH v1 4/6] dt-bindings: memory: tegra20: mc: Convert to schema

2021-03-30 Thread Dmitry Osipenko
30.03.2021 16:46, Rob Herring пишет: > On Tue, Mar 30, 2021 at 08:08:43AM -0500, Rob Herring wrote: >> On Mon, 29 Mar 2021 22:46:00 +0300, Dmitry Osipenko wrote: >>> Convert Tegra20 Memory Controller binding to schema. >>> >>> Signed-off-by: Dmitry Osipenko

Re: [PATCH v1 5/6] dt-bindings: memory: tegra20: emc: Convert to schema

2021-03-30 Thread Dmitry Osipenko
30.03.2021 11:48, Krzysztof Kozlowski пишет: >> + power-domains: >> +$ref: /schemas/types.yaml#/definitions/phandle >> +description: >> + Phandle of the SoC "core" power domain. > I think the core checks the type, so you only need to limit max items. > It's a bit confusing that both

Re: [PATCH v1 5/6] dt-bindings: memory: tegra20: emc: Convert to schema

2021-03-30 Thread Dmitry Osipenko
30.03.2021 11:48, Krzysztof Kozlowski пишет: >> + nvidia,use-ram-code: >> +type: boolean >> +description: >> + If present, the emc-tables@ sub-nodes will be addressed. >> + >> +patternProperties: >> + "^emc-table@[0-9]+$": > This might not be easy but you should add constraints when

Re: [PATCH v1 5/6] dt-bindings: memory: tegra20: emc: Convert to schema

2021-03-30 Thread Dmitry Osipenko
30.03.2021 11:48, Krzysztof Kozlowski пишет: >> + "^emc-tables@[a-z0-9\\-]+$": > Why \ and - in the pattern? Good catch, I thought that '-' needs to be escaped, but then forgot to remove the unnecessary slashes.

Re: [PATCH v6 0/7] Couple improvements for Tegra clk driver

2021-03-30 Thread Dmitry Osipenko
20.03.2021 18:26, Dmitry Osipenko пишет: > This series fixes couple minor standalone problems of the Tegra clk > driver. Hello Stephen, Do you have any objects if Thierry will take this series into the Tegra tree? Or will you be able to take the patches into the clk tree? Please let u

Re: [PATCH v1 5/6] dt-bindings: memory: tegra20: emc: Convert to schema

2021-03-30 Thread Dmitry Osipenko
30.03.2021 18:29, Dmitry Osipenko пишет: > 30.03.2021 11:48, Krzysztof Kozlowski пишет: >>> + power-domains: >>> +$ref: /schemas/types.yaml#/definitions/phandle >>> +description: >>> + Phandle of the SoC "core" power domain. >>

Re: [PATCH v5 3/5] i2c: add support for HiSilicon I2C controller

2021-03-30 Thread Dmitry Osipenko
30.03.2021 17:19, Yicong Yang пишет: ... > +struct hisi_i2c_controller { > + struct i2c_adapter adapter; > + void __iomem *iobase; > + struct device *dev; > + int irq; > + > + /* Intermediates for recording the transfer process */ > + struct completion *completion; > + s

Re: [PATCH v5 1/5] i2c: core: add managed function for adding i2c adapters

2021-03-30 Thread Dmitry Osipenko
r *adap) > */ > #if IS_ENABLED(CONFIG_I2C) > int i2c_add_adapter(struct i2c_adapter *adap); > +int devm_i2c_add_adapter(struct device *dev, struct i2c_adapter *adapter); > void i2c_del_adapter(struct i2c_adapter *adap); > int i2c_add_numbered_adapter(struct i2c_adapter *adap); > > Reviewed-by: Dmitry Osipenko

Re: [PATCH v5 3/5] i2c: add support for HiSilicon I2C controller

2021-03-30 Thread Dmitry Osipenko
30.03.2021 19:24, Dmitry Osipenko пишет: >> +struct hisi_i2c_controller { >> +struct i2c_adapter adapter; >> +void __iomem *iobase; >> +struct device *dev; >> +int irq; >> + >> +/* Intermediates for recording the transfer proces

Re: [PATCH v5 3/5] i2c: add support for HiSilicon I2C controller

2021-03-30 Thread Dmitry Osipenko
d, 517 insertions(+) > create mode 100644 drivers/i2c/busses/i2c-hisi.c Reviewed-by: Dmitry Osipenko

Re: [PATCH v1 2/6] dt-bindings: memory: tegra30: emc: Replace core regulator with power domain

2021-03-30 Thread Dmitry Osipenko
31.03.2021 01:23, Rob Herring пишет: > On Mon, Mar 29, 2021 at 10:45:58PM +0300, Dmitry Osipenko wrote: >> Power domain fits much better than a voltage regulator in regards to >> a proper hardware description and from a software perspective as well. >> Hence replace the co

[PATCH v2 1/6] dt-bindings: memory: tegra20: emc: Replace core regulator with power domain

2021-03-30 Thread Dmitry Osipenko
ulator yet, and thus, it's okay to change it. Reviewed-by: Rob Herring Signed-off-by: Dmitry Osipenko --- .../bindings/memory-controllers/nvidia,tegra20-emc.txt| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/memory-controllers

[PATCH v2 0/6] NVIDIA Tegra memory improvements

2021-03-30 Thread Dmitry Osipenko
s are converted to schema. I also made a small improvement to the memory drivers. Changelog: v2: - Fixed typos in the converted schemas. - Corrected reg entry of tegra20-mc-gart schema to use fixed number of items. - Made power-domain to use maxItems instead of $ref phandle in schemas. D

[PATCH v2 2/6] dt-bindings: memory: tegra30: emc: Replace core regulator with power domain

2021-03-30 Thread Dmitry Osipenko
ulator yet, and thus, it's okay to change it. Signed-off-by: Dmitry Osipenko --- .../bindings/memory-controllers/nvidia,tegra30-emc.yaml| 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml

[PATCH v2 5/6] dt-bindings: memory: tegra20: emc: Convert to schema

2021-03-30 Thread Dmitry Osipenko
Convert Tegra20 External Memory Controller binding to schema. Signed-off-by: Dmitry Osipenko --- .../memory-controllers/nvidia,tegra20-emc.txt | 130 .../nvidia,tegra20-emc.yaml | 294 ++ 2 files changed, 294 insertions(+), 130 deletions(-) delete

[PATCH v2 4/6] dt-bindings: memory: tegra20: mc: Convert to schema

2021-03-30 Thread Dmitry Osipenko
Convert Tegra20 Memory Controller binding to schema. Signed-off-by: Dmitry Osipenko --- .../memory-controllers/nvidia,tegra20-mc.txt | 40 -- .../memory-controllers/nvidia,tegra20-mc.yaml | 79 +++ 2 files changed, 79 insertions(+), 40 deletions(-) delete mode 100644

[PATCH v2 3/6] dt-bindings: memory: tegra124: emc: Replace core regulator with power domain

2021-03-30 Thread Dmitry Osipenko
ulator yet, and thus, it's okay to change it. Signed-off-by: Dmitry Osipenko --- .../bindings/memory-controllers/nvidia,tegra124-emc.yaml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml

[PATCH v2 6/6] memory: tegra: Print out info-level once per driver probe

2021-03-30 Thread Dmitry Osipenko
Probing of EMC drivers may be deferred and in this case we get duplicated info messages during kernel boot. Use dev_info_once() helper to silence the duplicated messages. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra124-emc.c | 12 ++-- drivers/memory/tegra/tegra20-emc.c

Re: [PATCH v2 5/6] dt-bindings: memory: tegra20: emc: Convert to schema

2021-03-31 Thread Dmitry Osipenko
31.03.2021 16:40, Rob Herring пишет: > On Wed, 31 Mar 2021 02:04:44 +0300, Dmitry Osipenko wrote: >> Convert Tegra20 External Memory Controller binding to schema. >> >> Signed-off-by: Dmitry Osipenko >> --- >> .../memory-controllers/nvidia,tegra20-emc.txt | 13

Re: [PATCH v4 1/6] soc/tegra: Add devm_tegra_core_dev_init_opp_table()

2021-03-31 Thread Dmitry Osipenko
18.03.2021 13:37, Dmitry Osipenko пишет: > 18.03.2021 13:32, Viresh Kumar пишет: >> On 18-03-21, 13:27, Dmitry Osipenko wrote: >>> 14.03.2021 19:48, Dmitry Osipenko пишет: >>>> Add common helper which initializes OPP table for Tegra SoC core devices. >>>&

Re: [PATCH v1 5/5] ASoC: tegra30: i2s: Add reset control

2021-03-03 Thread Dmitry Osipenko
02.03.2021 14:21, Dmitry Osipenko пишет: > The I2S reset may be asserted at a boot time. Tegra30 I2S driver doesn't > manage the reset control and currently it happens to work because reset > is implicitly deasserted by the Tegra AHUB driver, but the reset of I2C > controller shou

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

2021-03-03 Thread Dmitry Osipenko
03.03.2021 07:01, Viresh Kumar пишет: > On 02-03-21, 16:40, Dmitry Osipenko wrote: >> 20.01.2021 19:01, Dmitry Osipenko пишет: >>> 01.01.2021 19:54, Yangtao Li пишет: >>>> Hi, >>>> >>>> This patchset add devm_pm_opp_set_clkname, de

Re: [PATCH] iommu/tegra-smmu: Fix mc errors on tegra124-nyan

2021-03-03 Thread Dmitry Osipenko
03.03.2021 02:08, Nicolin Chen пишет: > On Sat, Feb 27, 2021 at 12:59:17PM +0300, Dmitry Osipenko wrote: >> 25.02.2021 09:27, Nicolin Chen пишет: >> ... >>>> The partially revert should be okay, but it's not clear to me what makes >>>> difference fo

Re: [PATCH v1 5/5] ASoC: tegra30: i2s: Add reset control

2021-03-04 Thread Dmitry Osipenko
03.03.2021 15:09, Philipp Zabel пишет: > Hi Dmitry, > > On Wed, 2021-03-03 at 11:28 +0300, Dmitry Osipenko wrote: >> 02.03.2021 14:21, Dmitry Osipenko пишет: >>> The I2S reset may be asserted at a boot time. Tegra30 I2S driver doesn't >>> manage the reset co

[PATCH v6 0/7] Couple improvements for Tegra clk driver

2021-03-20 Thread Dmitry Osipenko
v1: - Collected clk patches into a single series. Dmitry Osipenko (7): clk: tegra30: Use 300MHz for video decoder by default clk: tegra: Fix refcounting of gate clocks clk: tegra: Ensure that PLLU configuration is applied properly clk: tegra: Halve SCLK rate on Tegra20 MAINTAINERS: Hand

[PATCH v6 2/7] clk: tegra: Fix refcounting of gate clocks

2021-03-20 Thread Dmitry Osipenko
27;t cause any real problems for the drivers and boards supported by the kernel today. Acked-by: Thierry Reding Signed-off-by: Dmitry Osipenko --- drivers/clk/tegra/clk-periph-gate.c | 72 +++-- drivers/clk/tegra/clk-periph.c | 11 + 2 files changed, 58 inserti

[PATCH v6 5/7] MAINTAINERS: Hand Tegra clk driver to Jon and Thierry

2021-03-20 Thread Dmitry Osipenko
Peter and Prashant aren't actively maintaining Tegra clock driver anymore. Jonathan and Thierry will pick up maintaining of the driver from now on. Acked-by: Thierry Reding Signed-off-by: Dmitry Osipenko --- CREDITS | 6 ++ MAINTAINERS | 4 ++-- 2 files changed, 8 insertions(

[PATCH v6 6/7] clk: tegra: Don't allow zero clock rate for PLLs

2021-03-20 Thread Dmitry Osipenko
el on Samsung Galaxy Tab, which happened due to a bug in Tegra DRM driver that erroneously sets PLL rate to zero. This issues came over again recently during of kernel bring up on ASUS TF700T. Signed-off-by: Dmitry Osipenko --- drivers/clk/tegra/clk-pll.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH v6 1/7] clk: tegra30: Use 300MHz for video decoder by default

2021-03-20 Thread Dmitry Osipenko
ot;) Acked-by: Thierry Reding Signed-off-by: Dmitry Osipenko --- drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c index 16dbf83d2f62..a33688b2359e 100644 --- a/drivers/clk/tegra/c

[PATCH v6 7/7] dt-bindings: clock: tegra: Convert to schema

2021-03-20 Thread Dmitry Osipenko
Convert NVIDIA Tegra clock bindings to schema. Signed-off-by: Dmitry Osipenko --- .../bindings/clock/nvidia,tegra114-car.txt| 63 -- .../bindings/clock/nvidia,tegra124-car.txt| 107 .../bindings/clock/nvidia,tegra124-car.yaml | 115

[PATCH v6 3/7] clk: tegra: Ensure that PLLU configuration is applied properly

2021-03-20 Thread Dmitry Osipenko
reprograms it, which could be unsafe to do. The correct way should be to skip enabling of the PLL if it's already enabled and then apply configuration to the outputs. This patch doesn't fix any known problems, it's a minor improvement. Acked-by: Thierry Reding Signed-off-by:

[PATCH v6 4/7] clk: tegra: Halve SCLK rate on Tegra20

2021-03-20 Thread Dmitry Osipenko
ed-by: Thierry Reding Signed-off-by: Dmitry Osipenko --- drivers/clk/tegra/clk-tegra20.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c index 3efc651b42e3..3664593a5ba4 100644 --- a/drivers/clk/tegra/clk-te

Re: [PATCH v6 0/3] Support wakeup methods of Atmel maXTouch controllers

2021-03-20 Thread Dmitry Osipenko
02.03.2021 13:21, Dmitry Osipenko пишет: > Some Atmel maXTouch controllers, like mXT1386 and mXT3432S1 for example, > have a WAKE line that needs to be asserted in order to wake controller > from a deep sleep, otherwise it will be unusable. This series implements > support for the wa

Re: [PATCH v6 0/3] Support wakeup methods of Atmel maXTouch controllers

2021-03-21 Thread Dmitry Osipenko
22.03.2021 01:44, Dmitry Torokhov пишет: > Hi Dmitry, > > On Sat, Mar 20, 2021 at 07:02:43PM +0300, Dmitry Osipenko wrote: >> 02.03.2021 13:21, Dmitry Osipenko пишет: >>> Some Atmel maXTouch controllers, like mXT1386 and mXT3432S1 for example, >>> have a WAKE

Re: [PATCH v4] mm: cma: support sysfs

2021-03-22 Thread Dmitry Osipenko
20.03.2021 10:52, Greg Kroah-Hartman пишет: .. >> I found the Greg's original argument and not sure that it's really >> worthwhile to worry about the copycats since this is not a driver's code.. >> >> Maybe we could just add a clarifying comment for the kobj, telling why >> it's okay for CMA. Greg,

Re: [PATCH v15 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-15 Thread Dmitry Osipenko
15.03.2021 01:31, Michał Mirosław пишет: > On Thu, Mar 11, 2021 at 08:22:54PM +0300, Dmitry Osipenko wrote: >> Display controller (DC) performs isochronous memory transfers, and thus, >> has a requirement for a minimum memory bandwidth that shall be fulfilled, >> otherwise f

Re: [PATCH v4] iommu/tegra-smmu: Add pagetable mappings to debugfs

2021-03-15 Thread Dmitry Osipenko
Total PDE count: 1 > Total PTE count: 1 > > Signed-off-by: Nicolin Chen > --- Good to me, thanks. Tested-by: Dmitry Osipenko Reviewed-by: Dmitry Osipenko > + for (pd_index = 0; pd_index < SMMU_NUM_PDE; pd_index++) { > + struct page *pt_page; > +

Re: [PATCH v4 7/7] dt-bindings: clock: tegra: Convert to schema

2021-03-15 Thread Dmitry Osipenko
15.03.2021 18:53, Rob Herring пишет: > On Fri, Mar 12, 2021 at 07:36:32PM +0300, Dmitry Osipenko wrote: >> Convert NVIDIA Tegra clock bindings to schema. >> >> Signed-off-by: Dmitry Osipenko >> --- >> .../bindings/clock/nvidia,tegra-car.yaml | 118

Re: linux-next: build warning after merge of the opp tree

2021-03-16 Thread Dmitry Osipenko
16.03.2021 07:48, Viresh Kumar пишет: > On 16-03-21, 11:15, Stephen Rothwell wrote: >> Hi all, >> >> After merging the opp tree, today's linux-next build (powerpc >> ppc64_defconfig) produced this warning: >> >> In file included from include/linux/devfreq.h:15, >> from drivers/base

Re: [PATCH v2] phy: tegra: depend on COMMON_CLK to fix compile tests

2021-03-16 Thread Dmitry Osipenko
16.03.2021 10:55, Krzysztof Kozlowski пишет: > From: Krzysztof Kozlowski > > The Tegra USB PHY driver uses Common Clock Framework thus it cannot be > built on platforms without it (e.g. compile test on MIPS with RALINK and > SOC_RT305X): > > /usr/bin/mips-linux-gnu-ld: drivers/usb/phy/phy-te

Re: [PATCH v2] phy: tegra: depend on COMMON_CLK to fix compile tests

2021-03-16 Thread Dmitry Osipenko
16.03.2021 18:51, Krzysztof Kozlowski пишет: > On Tue, 16 Mar 2021 at 16:47, Krzysztof Kozlowski > wrote: >> >> On Tue, 16 Mar 2021 at 16:43, Dmitry Osipenko wrote: >>> >>> 16.03.2021 10:55, Krzysztof Kozlowski пишет: >>>> From: Krzysztof Kozlowski

Re: [PATCH v15 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-16 Thread Dmitry Osipenko
15.03.2021 21:39, Dmitry Osipenko пишет: >>> + /* >>> +* Horizontal downscale needs a lower memory latency, which roughly >>> +* depends on the scaled width. Trying to tune latency of a memory >>> +* client alone will likely result in a strong

Re: [PATCH v5] iommu/tegra-smmu: Add pagetable mappings to debugfs

2021-03-16 Thread Dmitry Osipenko
15.03.2021 23:36, Nicolin Chen пишет: > +static unsigned long pd_pt_index_iova(unsigned int pd_index, unsigned int > pt_index) > +{ > + return ((dma_addr_t)pd_index & (SMMU_NUM_PDE - 1)) << SMMU_PDE_SHIFT | > +((dma_addr_t)pt_index & (SMMU_NUM_PTE - 1)) << SMMU_PTE_SHIFT; > +} Loo

Re: [PATCH v5] iommu/tegra-smmu: Add pagetable mappings to debugfs

2021-03-16 Thread Dmitry Osipenko
15.03.2021 23:36, Nicolin Chen пишет: > +static int tegra_smmu_mappings_show(struct seq_file *s, void *data) > +{ > + struct tegra_smmu_group_debug *group_debug = s->private; > + const struct tegra_smmu_swgroup *group; > + struct tegra_smmu_as *as; > + struct tegra_smmu *smmu; > +

Re: [PATCH v5] iommu/tegra-smmu: Add pagetable mappings to debugfs

2021-03-16 Thread Dmitry Osipenko
16.03.2021 14:16, Thierry Reding пишет: >> +seq_puts(s, "}\n"); >> +seq_printf(s, "Total PDE count: %u\n", pde_count); >> +seq_printf(s, "Total PTE count: %llu\n", pte_count); > Some of the above looks like it wouldn't be very easily consumed by > scripts. Is that something we want to d

Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-16 Thread Dmitry Osipenko
16.03.2021 20:57, Krzysztof Kozlowski пишет: > The Ralink MIPS platform does not use Common Clock Framework and does > not define certain clock operations leading to compile test failures: > > /usr/bin/mips-linux-gnu-ld: drivers/usb/phy/phy-tegra-usb.o: in function > `tegra_usb_phy_init': >

Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-16 Thread Dmitry Osipenko
17.03.2021 00:58, Thomas Bogendoerfer пишет: > On Tue, Mar 16, 2021 at 06:57:25PM +0100, Krzysztof Kozlowski wrote: >> The Ralink MIPS platform does not use Common Clock Framework and does >> not define certain clock operations leading to compile test failures: >> >> /usr/bin/mips-linux-gnu-ld:

[PATCH v1] i2c: tegra: Improve handling of i2c_recover_bus()

2021-03-29 Thread Dmitry Osipenko
The i2c_recover_bus() returns -EOPNOTSUPP if bus recovery isn't wired up, which the case for older Tegra SoCs at the moment. This error code is then propagated to I2C client and might be confusing, thus return -EIO instead. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c

Re: [PATCH v1] i2c: tegra: Improve handling of i2c_recover_bus()

2021-03-29 Thread Dmitry Osipenko
29.03.2021 22:15, Wolfram Sang пишет: > On Mon, Mar 29, 2021 at 10:05:46PM +0300, Dmitry Osipenko wrote: >> The i2c_recover_bus() returns -EOPNOTSUPP if bus recovery isn't wired up, >> which the case for older Tegra SoCs at the moment. This error code is then >> propagat

[PATCH v1 0/6] NVIDIA Tegra memory improvements

2021-03-29 Thread Dmitry Osipenko
s are converted to schema. I also made a small improvement to the memory drivers. Dmitry Osipenko (6): dt-bindings: memory: tegra20: emc: Replace core regulator with power domain dt-bindings: memory: tegra30: emc: Replace core regulator with power domain dt-bindings: memory: tegra124

[PATCH v1 3/6] dt-bindings: memory: tegra124: emc: Replace core regulator with power domain

2021-03-29 Thread Dmitry Osipenko
ulator yet, and thus, it's okay to change it. Signed-off-by: Dmitry Osipenko --- .../bindings/memory-controllers/nvidia,tegra124-emc.yaml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml

[PATCH v1 4/6] dt-bindings: memory: tegra20: mc: Convert to schema

2021-03-29 Thread Dmitry Osipenko
Convert Tegra20 Memory Controller binding to schema. Signed-off-by: Dmitry Osipenko --- .../memory-controllers/nvidia,tegra20-mc.txt | 40 -- .../memory-controllers/nvidia,tegra20-mc.yaml | 78 +++ 2 files changed, 78 insertions(+), 40 deletions(-) delete mode 100644

[PATCH v1 6/6] memory: tegra: Print out info-level once per driver probe

2021-03-29 Thread Dmitry Osipenko
Probing of EMC drivers may be deferred and in this case we get duplicated info messages during kernel boot. Use dev_info_once() helper to silence the duplicated messages. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra124-emc.c | 12 ++-- drivers/memory/tegra/tegra20-emc.c

<    4   5   6   7   8   9   10   11   12   13   >