MC_CMD_UPD_CLK |
> - SDMMC_CMD_PRV_DAT_WAIT, 0);
> + clk_en_a_old = mci_readl(host, CLKENA);
> +
> + if (card->type == MMC_TYPE_SDIO ||
> + card->type == MMC_TYPE_SD_COMBO) {
> + set_bit(D
Hi Doug
On 12/03/2014 09:36 AM, Doug Anderson wrote:
> Jaehoon,
>
> On Tue, Dec 2, 2014 at 4:17 PM, Jaehoon Chung wrote:
>>> @@ -1245,27 +1246,37 @@ static int dw_mci_get_cd(struct mmc_host *mmc)
>>> return present;
>>> }
>>>
>>> -/*
Doug.
On 12/03/2014 10:12 AM, Doug Anderson wrote:
> Jaehoon,
>
> On Tue, Dec 2, 2014 at 5:06 PM, Jaehoon Chung wrote:
>> Hi Doug
>>
>> On 12/03/2014 09:36 AM, Doug Anderson wrote:
>>> Jaehoon,
>>>
>>> On Tue, Dec 2, 2014 at 4:17 PM,
Hi, Doug.
Add one comment.
On 10/16/2014 05:19 PM, Jaehoon Chung wrote:
> Hi, Doug.
>
> Looks good to me.
>
> Tested-by: Jaehoon Chung
> with exynos3/4 series.
>
> Need to check exynos5 with using other "card detect" mechanism.
>
> Best Regards,
>
On 10/16/2014 08:09 PM, Vivek Gautam wrote:
> Hi Prabu,
>
>
> On Thu, Oct 16, 2014 at 4:09 PM, Prabu Thangamuthu
> wrote:
>>
>> Hi Jaehoon, Vivek, Alim,
>>
>> Thanks for your review comments.
>>
>> On Thu, Oct 16, 2014 at 12:20 PM, Jaehoon Chu
> We tested this on an Exynos 5800 with HS200 and didn't notice any
> difference in sequential read throughput.
Didn't affect the write throughput?
I tested this on exynos3/4 with DDR50 and HS200.
Acked-by: Jaehoon Chung
Tested-by: Jaehoon Chung
>
> Signed-off-by: Sonny Rao
that..but probably sometime next week, as I will out
> of office for few days.
>>
>>> And as Jaehoon pointed out,probably lets look in TRM if there are some
>>> recommended steps for cd-detect.
>>> Otherwise this looks good to me.
>>
>> If you see so
than Addy's. There's
>> already a 10ms delay between "power up" and "power on" in the MMC core
>> in mmc_power_up() state. That delay is commented as:
>>
> Well, my suggestion (adding 5ms in switch_volatge) was based on DW_MMC
> databook (V2
Hi, Doug.
It makes sense. Looks good to me. Thanks!
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 02/21/2015 03:57 AM, Doug Anderson wrote:
> It appears that we can confuse things if we try to turn on the MMC
> clock when the power is off. Adjust is so that we turn the cl
Dear, Doug.
Looks good to me. Thanks!
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 02/21/2015 03:57 AM, Doug Anderson wrote:
> We should give dw_mmc a good reset after we apply power. On some
> boards vqmmc may actually be connected to the IP block in the SoC so
> it&
Hi, Addy.
Acked-by: Jaehoon Chung
Thanks!
Best Regards,
Jaehoon Chung
On 02/20/2015 11:37 AM, Addy Ke wrote:
> To support HS200 and UHS mode, mmc core will call init_card() to
> execute tuning:
> - sdio: init_card can be executed at runtime resume.
> - sd and mmc: init_card can be
Hi, Karol.
This patch can't apply. You need to rebase on latest mmc-next.
Then i will check this patch.
Best Regards,
Jaehoon Chung
On 03/06/2015 10:29 PM, Karol Wrona wrote:
> This patch adds runtime pm handling to dw_mmc.
> It mainly uses mci_request/mci_request_end for mmc
st *mmc,
> struct mmc_ios *ios)
> int min_uv, max_uv;
> int ret;
>
> + pm_runtime_get_sync(host->dev);
> +
> /*
>* Program the voltage. Note that some instances of dw_mmc may use
>* the UHS_REG for this. For other instances (
Hi, Doug.
This patch is not related with [patch 2/4~4/4].
"[PATCH v4 2/4] mmc: core: Add mmc_regulator_set_vqmmc()" is discussing..
So i think if you're ok, i will pick this one [PATCH v4 1/4]. how about?
Best Regards,
Jaehoon Chung
On 03/12/2015 07:15 AM, Doug Ander
ught I confirmed it
> was the core trying to call MMC_POWER_OFF when the power was already
> off, but now I'm less certain. I looked back at my debug session and
> I don't see where I got that evidence. :-/ Certainly if I put a
> printout here right now I can't
Dear Doug,
I'm considering to control HLE error..So holding this patch.
If this is absolutely necessary patch, let me know, plz.
Best Regards,
Jaehoon Chung
On 03/16/2015 02:56 PM, Jaehoon Chung wrote:
> Hi, Doug.
>
> On 03/14/2015 05:27 AM, Doug Anderson wrote:
>> Hi,
Hi,
Sorry for missing warning, and Thanks for pointing out.
Best Regards,
Jaehoon Chung
On 03/05/2015 07:02 PM, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu
> ---
> dw_mmc-exynos.c |2 +-
> dw_mmc.c|2 +-
> 2 files changed, 2 insertio
le = "regulator-fixed";
> + regulator-name = "vbat-supply";
> + regulator-min-microvolt = <500>;
> + regulator-max-microvolt = <500>;
> + gpio = <>;
gpio = <> ? What do you mean?
And this is described at
Documentati
> + struct dw_mci *host = (struct dw_mci *)arg;
> +
> + if (host->state != STATE_SENDING_CMD11)
> + dev_info(host->dev, "Unexpected CMD11 timeout\n");
If Unexpected CMD11 timeout, can it do just" return"?
Well, I think Unexpected CMD11 ti
red when card inserting/ejecting.(This case is the case of
removable card.)
Did you test with eMMC? We needs to consider how control HLE error.
But I think this patch can't solve all of HLE problem.
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Doug Anderson
> ---
> Note that t
Hi Doug,
Will apply. Thanks!
Best Regards,
Jaehoon Chung
On 03/12/2015 07:15 AM, Doug Anderson wrote:
> If dw_mci_init_slot() returns that we got a probe deferral then it may
> leave slot->mmc as NULL. That will cause dw_mci_enable_cd() to crash
> when it calls mmc_gpio_get_cd().
&
Hi, Heiko.
On 03/13/2015 09:10 PM, Heiko Stuebner wrote:
> Hi,
>
> Am Freitag, 13. März 2015, 20:32:43 schrieb Jaehoon Chung:
>> Hi Doug,
>>
>> Will apply. Thanks!
>
> just to make sure, you'll take patches 1-3 and I'll take the dts change from
>
Hi, Ulf.
If Ben is oK, I will want to maintain all files of sdhci-s3c*.
(sdhci-s3c is Samsung specific driver code. So i can maintain it.)
I think he didn't maintain sdhci-s3c. How about?
Best Regards,
Jaehoon Chung
On 03/13/2015 09:51 PM, Ulf Hansson wrote:
> Cc: Ben Dooks
> Si
Hi, Doug.
On 03/14/2015 05:27 AM, Doug Anderson wrote:
> Hi,
>
> On Fri, Mar 13, 2015 at 4:30 AM, Jaehoon Chung wrote:
>> Hi, Doug.
>>
>> On 03/11/2015 12:48 AM, Doug Anderson wrote:
>>> The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but
blocked. To avoid this, we need reset mmc controller.
I know that it needs to check whether card is busy or not, before clock-off.
This patch seems to related with it. right?
Best Regards,
Jaehoon Chung
>>>
>>> Signed-off-by: Addy Ke
>>
>> Hi Addy,
>>
>>
> + dw_mci_ctrl_reset(host, SDMMC_CTRL_ALL_RESET_FLAGS);
If reset is failed, then dw_mci_ctrl_reset should return "false".
ret = dw_mci_ctrl_reset();
WARN_ON(!ret || dw_mci_card_busy(slot->mmc));
Is it right?
In my experiment, if reset is failed or car
Hi.
Tested-by: Jaehoon Chung
(with exynos4 board)
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 02/04/2015 06:16 PM, Paul Osmialowski wrote:
> This change addresses following problem:
>
> [2.560726] [ cut here ]
> [2.565341] WARNING: CPU:
Hi,
I will apply into my-tree after change the subject and fix typo.
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 02/26/2015 03:17 AM, Javier Martinez Canillas wrote:
> Hello Addy,
>
> On 02/20/2015 03:55 AM, Addy Ke wrote:
>> The STOP command can terminate a data t
merated
> and listed in /sys/bus/sdio/devices/
it needs to check when clock value only update.
As Javier and Alim are mentioned, if check whether card is busy or not in
setup_bus(),
should be processed unnecessary checking.
(According to TRM, before disabling clock, check whether card is busy o
Hi Pradu,
On 04/20/2016 04:00 PM, Prabu Thangamuthu wrote:
> Hi Jaehoon Chung,
>
> Thank you for detailed review comments.
>
> On 04/19/2016 04:31 PM, Jaehoon Chung wrote:
>> On 04/19/2016 04:18 PM, Prabu Thangamuthu wrote:
>>> Synopsys DWC_MSHC is compliant wit
Hi Shawn,
On 03/18/2016 12:46 AM, Shawn Lin wrote:
> Hi jaehoon,
>
> On 2016/3/2 9:29, Jaehoon Chung wrote:
>> Hi Shawn.
>>
>> On 03/01/2016 04:12 PM, Shawn Lin wrote:
>>> Without MMC_CAP_ERASE support, we fail to mount partition
>>> with "discar
heir relationship.
I have tested with this patch..but there also are side-effects.
Exynos4 series has the two host controller..one is sdhci, one is dwmmc for eMMC.
In this case, dwmmc controller is probed after sdhci controller.
Then eMMC is always assigned to mmcblk1.
I think it's not good th
I think it's more easier to check the mmc error at booting time or some
time.
Best Regards,
Jaehoon Chung
>
> Thanks
>
>>
>> Signed-off-by: Baolin Wang
>> ---
>> drivers/mmc/core/core.c | 52
>> ---
>>
Hi
On 04/19/2016 06:42 PM, Olliver Schinagl wrote:
> Hi Ulf,
>
> On 19-04-16 11:29, Ulf Hansson wrote:
>> On 19 April 2016 at 09:12, Olliver Schinagl wrote:
>>> In patch 81f8a7be66 Hans de Goede added a patch to allow marking an mmc
>>> device as to having an broken HPI implementation. After tal
return 0;
> +
> +}
> +
> +int sdhci_pci_probe_slot_snps(struct sdhci_pci_slot *slot)
> +{
> + int ret = 0;
> + struct sdhci_host *host;
> +
> + host = slot->host;
> + sdhci_ops = host->ops;
> + host->ops = &sdhci_pci_ops_snp
Hi Olliver,
On 04/19/2016 09:20 PM, Olliver Schinagl wrote:
> Hey Jaehoon,
>
> On 19-04-16 11:49, Jaehoon Chung wrote:
>> Hi
>>
>> On 04/19/2016 06:42 PM, Olliver Schinagl wrote:
>>> Hi Ulf,
>>>
>>> On 19-04-16 11:29, Ulf Hansson wrote:
&
t; [PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards
> [PATCH v2 1/1] mmc: dw_mmc: Wait for data transfer after response errors.
What changed from patch V1?
Anyway, thanks for reminding! :)
Best Regards,
Jaehoon Chung
>
> 2016-04-25 17:18 GMT+02:00 Enric Balletbo i Serra
&
_ptr));
>> +reg &= ~SDHC_TUNING_RX_CLK_SEL_MASK;
>> +reg |= (SDHC_TUNING_RX_CLK_SEL_MASK &
>> +rx_clk_phase_val);
>> + sdhci_writel(host, reg, (SDHC_DBOUNCE +
modified Rob's mail address.
On 03/30/2016 04:24 PM, Guodong Xu wrote:
> mmc registers may in abnormal state if mmc is used in bootloader,
> eg. to support booting from eMMC. So we need reset mmc registers
> when kernel boots up, instead of assuming mmc is in clean state.
Do you mean mmc(card sid
On 03/31/2016 02:16 AM, Enric Balletbo Serra wrote:
> 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux :
>> On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote:
>>> Russell,
>> ...
>>> Presumably this is similar to what you saw: the host saw the CRC error
>>> but the card knew nothing
or adding setup_clk argument.
"mmc: dw_mmc: add setup_clk for init hook"
Could you resend the patch-set after applying my patch?
Best Regards,
Jaehoon Chung
>
>
> Shawn Lin (4):
> mmc: dw_mmc-rockchip: remove setup_clock for rockchip
> mmc: dw_mmc: add setup_clk for
p_clock)(struct dw_mci *host);
Could you remove the description for setup_clock?
* @init: early implementation specific initialization.
- * @setup_clock: implementation specific clock configuration.
* @set_ios: handle bus specific extensions.
* @parse_dt: parse implementation specific device tre
nit hook after resume, so we add new argument in init hook
> to indicate whether it needs do clk stuff or not.
Thanks for resending these. This message looks like previous message..
Anyway, i will pick you patch with my patch..
Best Regards,
Jaehoon Chung
>
>
> Changes in v2:
> - reb
Hi,
Picked this patch-set on my repository.
Best Regards,
Jaehoon Chung
On 03/31/2016 04:33 PM, Shawn Lin wrote:
> Hello Jeahoon
>
> Currently dw_mmc is a little too queen-size. As we had cleanup
> prepare_command callback some days before, there are also some
> ones deserve to
On 04/02/2016 03:42 AM, Heiko Stuebner wrote:
> Am Mittwoch, 30. März 2016, 20:40:31 schrieb Jaehoon Chung:
>> modified Rob's mail address.
>>
>> On 03/30/2016 04:24 PM, Guodong Xu wrote:
>>> mmc registers may in abnormal state if mmc is used in bootloader,
>&
t the interrupt storm from flooding the kernel,
> once
> the event triggered and the interrupt was handled no more card
> insertions/ejections would be detected.
If HLE error will be reproduce with the generic sequence, I think we can find
the generic solution.
So could you explain to me
On 11/24/2015 10:55 AM, Jorge Ramirez-Ortiz wrote:
> On 11/23/2015 07:11 PM, Jaehoon Chung wrote:
>> Dear, Jorge.
>>
>> On 11/24/2015 02:29 AM, Jorge Ramirez-Ortiz wrote:
>>> On 11/23/2015 11:57 AM, Doug Anderson wrote:
>>>> Jorge,
>>>>
>
Hi,
Is sdhost based on SDHCI controller?
Why don't use sdhci.c? Is there any reason?
Best Regards,
Jaehoon Chung
On 07/01/2015 04:12 PM, Chunyan Zhang wrote:
> From: Billows Wu
>
> The Spreadtrum MMC host driver is used to support EMMC, SD, and
> SDIO types of memory cards
Hi, Alexey.
Sorry for reviewing late. i missed this patch.
I will check your patch and reply at mailing.
Thanks a lot for noticing this.
Best Regards,
Jaehoon Chung
On 07/01/2015 07:02 PM, Alexey Brodkin wrote:
> Hi Jaehoon, Seungwon, Ulf,
>
> On Thu, 2015-06-25 at 11:25 +0300, Alexe
ich DMA interface to use */
> -#ifdef CONFIG_MMC_DW_IDMAC
> - host->dma_ops = &dw_mci_idmac_ops;
> - dev_info(host->dev, "Using internal DMA controller.\n");
> -#endif
> + if (trans_mode == TRANS_MODE_IDMAC) {
> + /*
> + *
Hi, Shawn.
Looks good to me.
Acked-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
On 08/24/2015 10:25 AM, Shawn Lin wrote:
> This patch add some macros for HCON register operations
> to make code more readable.
>
> Signed-off-by: Shawn Lin
> ---
>
> Changes in v7: None
de that control the register
relevant to CLK_DRV/SMPL PHASE.
It seems that posted the similar patches at u-boot mailing list..
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Alexandru M Stan
>
> Convert to mmc_send_tuning()
> Fold in from the ChromeOS-tree:
> - mmc: dw_mmc:
Hi,
On 09/16/2015 07:09 AM, Heiko Stübner wrote:
> Hi,
>
> Am Dienstag, 15. September 2015, 17:25:38 schrieb Jaehoon Chung:
>> On 09/01/2015 03:24 AM, Heiko Stuebner wrote:
>>> From: Alexandru M Stan
>>>
>>> This algorithm will try 1 degree increme
Hi,
On 10/12/2015 01:29 PM, Krzysztof Kozlowski wrote:
> On 12.10.2015 00:46, Anand Moon wrote:
>> From: Jaehoon Chung
>>
>> To detect sd-card use the cd-gpio method.
>> It can decrease the interrupt for detecting sd-card.
>>
>> Signed-off-by: Jaeh
regs + fifo_offset;
>>
>> dst_addr is dma_addr_t?
>
> Sort of. It doesn't really fit into any of the categories, and we actually
> had a patch to change the type in the past, see
> https://lkml.org/lkml/2015/7/10/167. Not sure what is going on there.
why isn't the p
ever trigger the usb interrupt.
Signed-off-by: Jaehoon Chung
---
drivers/usb/dwc2/hcd_intr.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c
index 88b5dcf..8d3b155 100644
--- a/drivers/usb/dwc2/hcd_intr.c
+++ b/drivers
Hi Minas,
On 2/14/19 8:43 PM, Minas Harutyunyan wrote:
> Hi Jaehoon Chung,
>
> On 2/14/2019 2:04 PM, Jaehoon Chung wrote:
>> This patch is referred to Robert's patch
>> commit cf54772b913b ("usb: dwc2: call dwc2_is_controller_alive() under
>> spinlock&quo
bgcc and so
>> code gets compiled on all 32-bit platforms as opposed to usage
>> of DIV_ROUND_UP when we may only compile stuff on a very few arches.
>>
>> Lets cast this multiply to u64 type which prevents overflow.
>
> Reviewed-by: Jisheng Zhang
Acked-by: Jaeho
On 03/15/2018 07:22 PM, Ulf Hansson wrote:
> On 23 February 2018 at 07:41, Jaehoon Chung wrote:
>> 'clock-freq-min-max' property had already deprecated.
>> Remove the 'clock-freq-min-max' property that is kept to maintain
>> the compatibility.
>&g
On 11/22/2016 04:51 PM, Andrzej Hajda wrote:
> On 22.11.2016 02:24, Jaehoon Chung wrote:
>> On 11/22/2016 02:06 AM, Krzysztof Kozlowski wrote:
>>> On Mon, Nov 21, 2016 at 04:10:32PM +0900, Jaehoon Chung wrote:
>>>> Odroid-xu3/4 didn't need to use the cd-gpios fo
TM2 can support the HS400 mode, but eMMC is working as the lowest mode.
This patch added the properties for HS400 and other modes.
Signed-off-by: Jaehoon Chung
---
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos
s are keeping better than changing.
When someone contribute the patches relevant to these, it can be also changed,
(It's more meaningful.)
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Ziyuan Xu
> ---
>
> drivers/mmc/host/dw_mmc.c | 33 +
Doesn't it need Shawn's Signed-off tag?
Best Regards,
Jaehoon Chung
>
> ---
>
> Changes in v2:
> - update the commit message
> - use dw_mci_reset instead of dw_mci_ctrl_reset
>
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deleti
hread+0x60/0x548)
> [6.329215] [] (worker_thread) from []
> (kthread+0x128/0x158)
> [6.336614] [] (kthread) from []
> (ret_from_fork+0x14/0x24)
> [6.343836] Code: e52de004 e8bd4000 e3035d00 e34c50c0 (e5909004)
> [6.349974] ---[ end trace b2215a1ef671f11e ]---
On 01/05/2017 02:52 AM, Krzysztof Kozlowski wrote:
> On Wed, Jan 04, 2017 at 09:34:32PM +0900, Jaehoon Chung wrote:
>> This patch supports to use Generic Phy framework for Exynos PCIe phy.
>> When Exynos that supported the pcie want to use the PCIe,
>> it needs to control the
On 01/05/2017 02:58 AM, Krzysztof Kozlowski wrote:
> On Wed, Jan 04, 2017 at 09:34:35PM +0900, Jaehoon Chung wrote:
>> Add phy-pcie node for using Exynos5440 pcie.
>> And use the reg-names as "elbi" and "config".
>
> 'and' is only for joining
On 01/05/2017 02:50 AM, Krzysztof Kozlowski wrote:
> On Wed, Jan 04, 2017 at 09:34:34PM +0900, Jaehoon Chung wrote:
>> This patch is for using PHY generic framework.
>> To maintain backward compatibility, check whether phy is supported or
>> not with 'using_phy'.
&
different Exynos SoC.
>
> No functional change intended.
>
> Signed-off-by: Niyas Ahmed S T
> Signed-off-by: Pankaj Dubey
> Acked-by: Krzysztof Kozlowski
> Reviewed-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> This pat
Rename the simple pointer name as "ep" instead of "exynos_pcie".
After applying this patch, it can save the 10 characthers within one
line.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- Split from pr
Removed the duplicated codes.
It can use the more simply than now.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- None
Changelog on V2:
- None
drivers/pci/host/pci-exynos.c | 22 --
1 file changed, 8 insertions
There is no reason to maintain *_blk/phy/elbi_* as register accessors.
It can be replaced to one accessor for maintaining more easier.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- Split from previous [PATCH V2 1/4]
&quo
Remove the unnecessary variables(elbi/phy/block_base).
It needs one resource structure for assigning each resource.
So it replaces with one 'res' variable.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- None
Changelog on
:
- Changes the all pointer names as "ep" instead of "exynos_pcie"
Jaehoon Chung (5):
PCI: exynos: Rename all pointer names from "exynos_pcie" to "ep"
PCI: exynos: Replace the *_blk/*_phy/*_elb accessors
PCI: exynos: Remove the unnecessary variabl
Just use the bitops api to operate the bit.
Signed-off-by: Jaehoon Chung
Reviewed-by: Pankaj Dubey
Acked-by: Krzysztof Kozlowski
---
Changelog on V3:
- None
Changelog on V2:
- None
drivers/pci/host/pci-exynos.c | 24
1 file changed, 12 insertions(+), 12 deletions
Hi,
On 01/16/2017 05:37 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 04 January 2017 06:04 PM, Jaehoon Chung wrote:
>> This patch supports to use Generic Phy framework for Exynos PCIe phy.
>> When Exynos that supported the pcie want to use the PCIe,
>>
On 02/01/2017 06:16 AM, Jingoo Han wrote:
> On Saturday, January 28, 2017 4:28 PM, Bjorn Helgaas wrote:
>> On Mon, Jan 16, 2017 at 03:31:33PM +0900, Jaehoon Chung wrote:
>>> Current pci-exynos.c is used for only EXYNOS5440.
>>> It's too complex to support t
dw_mci_setup_bus(slot, true);
>>
>> So the spamming message about
>>
>> "Bus speed (slot %d) = %dHz (slot req %dHz, actual %dHZ div = %d)\n"
>>
>> will always be there, right? So you could append a new patch to shut
>> up it as I think it's useless no matter for system pm or rpm to print
>> it. How about?
>
> Fine, it's favourable with dev_vdbg if the dw_mmc rpm is enabled.
> Hi Jaehoon,
> What's your opinion? If you think this patch and shawn's advice are
> acceptable, I will send the v5 patch.
I don't agreed to use dev_vdbg()..but it needs not to display at everytime.
Hmm..It needs to consider more..because we needs to see the clock value when
it's initialized.
Best Regards,
Jaehoon Chung
>
> BR
> Ziyuan Xu
>
>>
>>> }
>>>
>>> /* Now that slots are all setup, we can enable card detect */
>>>
>>
>>
>
>
>
>
>
Hi Vivek,
On 01/10/2017 03:07 PM, Vivek Gautam wrote:
> Hi Jaehoon,
>
>
> On 01/04/2017 06:04 PM, Jaehoon Chung wrote:
>> This patch supports to use Generic Phy framework for Exynos PCIe phy.
>> When Exynos that supported the pcie want to use the PCIe,
>> it need
rmation as needed.
>>> The fix is on the way,
>>>
>>> https://patchwork.kernel.org/patch/9498527/
>> Great - thanks for letting me know.
>
> Can you share the result ?
Sorry for late. If it's working fine, I will apply it on fixes.
Best Regards,
Jaehoon
After that, i will decide whether revert or not.
Best Regards,
Jaehoon Chung
>
> Thanks,
> Romain
>
>
> Le 17/01/2017 à 14:28, Romain Perier a écrit :
>> Hello,
>>
>> This commit also breaks reboot and poweroff (the pmic no longer turn the
>> power sup
Hi John,
On 01/23/2017 08:24 PM, John Keeping wrote:
> Hi,
>
> On Fri, 20 Jan 2017 15:08:57 +0900, Jaehoon Chung wrote:
>> On 01/17/2017 10:38 PM, Romain Perier wrote:
>>> In my case I can reproduce the issue on the rock2 and the firefly-rk3288. A
>>> workarou
age = dw_mci_hi6220_switch_voltage,
> .set_ios= dw_mci_hi6220_set_ios,
> .parse_dt = dw_mci_hi6220_parse_dt,
> + .prepare_command= dw_mci_hi6220_prepare_command,
> };
There is no "prepare_command" hooks.
Best Regards,
Jaehoo
Hi Shawn,
On 06/21/2016 04:39 PM, Shawn Lin wrote:
> 在 2016/6/21 13:32, Jaehoon Chung 写道:
>> Hi guys,
>>
>> On 06/21/2016 11:31 AM, Shawn Lin wrote:
>>> On 2016/6/21 10:24, Seung-Woo Kim wrote:
>>>> Hello Shawn,
>>>>
>>>>> --
On 06/24/2016 10:25 AM, Shawn Lin wrote:
> Hi Jaehoon,
>
> On 2016/6/23 19:39, Jaehoon Chung wrote:
>> Hi Shawn,
>>
>> On 06/21/2016 04:39 PM, Shawn Lin wrote:
>>> 在 2016/6/21 13:32, Jaehoon Chung 写道:
>>>> Hi guys,
>>>>
>>>>
"Bus speed (slot %d) = %dHz (slot req %dHz,
> actual %dHZ div = %d)\n",
>slot->id, host->bus_hz, clock,
> @@ -1129,7 +1130,7 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot,
> bool force_clkinit)
> mci_send_cmd(s
the patch on next.
At that time, i will check this patch.
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/driv
time we was considering to take it away. The fact is
> that there are none of dts using the deprecated way since v3.18
> or even earlier. So personally I don't believe the old dtb
> would/could bootup current kernel(may not?). Let's remove it now.
>
> Signed-off-b
; cases because this is DTB misconfiguration.
>>
>> Signed-off-by: Krzysztof Kozlowski
>> ---
>
> Reviewed-by: Alim Akhtar
Applied on my repository. Thanks!
Before applied, I modified the prefix of subject from "dwmmc" to "dw_mmc"
Best Regards,
Jaehoon
is made eMMC modes higher than HS-DDR unusable.
>
> Fix this by checking for a positive return value instead.
>
> Fixes: 287980e49ffc ("remove lots of IS_ERR_VALUE abuses")
> Cc: Arnd Bergmann
> Signed-off-by: Chen-Yu Tsai
Acked-by: Jaehoon Chung
Best Regards,
efault.
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Jerome Forissier
> ---
> drivers/mmc/host/dw_mmc-k3.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index 63c2e2e..8e9d886 100644
>
lising MMC card
Signed-off-by: Jaehoon Chung
---
drivers/mmc/core/mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index c984321..aafb73d 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1276,7 +1276,7
On 05/30/2016 06:45 PM, Shawn Lin wrote:
> Hi,
>
> 在 2016/5/30 15:40, Jaehoon Chung 写道:
>> After applied "remove lots of IS_ERR_VALUE abuses", it shoold be
>> misoperation. (commit 287980e49)
>> If mmc_bus_test is successful, it returned the bus-witdh
ill cannot boot up until revert the
> patch "arm64: dts: hi6220: add resets property into dwmmc nodes".
Could you share the log? Is there any log about failure?
Best Regards,
Jaehoon Chung
>
> [1]
> http://builds.96boards.org/snapshots/hikey/linaro/uefi-openplatformpkg/latest/
>
> Thanks,
> Leo Yan
>
>
>
Hi,
On 10/28/2016 04:38 PM, Leo Yan wrote:
> On Fri, Oct 28, 2016 at 04:33:41PM +0900, Jaehoon Chung wrote:
>
> [...]
>
>>>>> Guodong: Is there any bootloader dependency on that change?
>>>>
>>>> FYI, I use firmwares available in AOSP
>&g
Hi,
On 10/28/2016 06:43 PM, Jaehoon Chung wrote:
> Hi,
>
> On 10/28/2016 04:38 PM, Leo Yan wrote:
>> On Fri, Oct 28, 2016 at 04:33:41PM +0900, Jaehoon Chung wrote:
>>
>> [...]
>>
>>>>>> Guodong: Is there any bootloader dependency on that change?
Hi,
On 10/28/2016 07:19 PM, Leo Yan wrote:
> On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:
>
> [...]
>
>>>>> Could you share the log? Is there any log about failure?
>>>>
>>>> Sure, please see below log:
>>&
Hi Colin,
On 11/17/2016 03:55 AM, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake "desciptor" to "descriptor" in
> dev_dbg message.
Applied on my dwmmc repository. Thanks!
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Col
Add the mshc_2 node for supporting T-flash.
And it needs to add the "mshc*" aliases. Because dwmmc driver should be
assigned to "ctrl_id" after parsing to "mshc".
If there is no aliases for mshc, then it might be set to the wrong
capabilities.
Signed-off-by: Jaeho
controller".
Then developer who refer to mmc.txt will add the property "broken-highspeed".
I'm not sure what is correct way..but to prevent confusing..you mentioned only
"sdhci" driver or supporting other controller.
Best Regards,
Jaehoon Chung
>
> The broke
Add reset-names property for binding dw-mmc controller.
It might be used together with "reset" property.
- Note: It must be "reset" as name.
Fixes: d6786fefe816 ("mmc: dw_mmc: add reset support to dwmmc host controller")
Signed-off-by: Jaehoon Chung
---
Documen
201 - 300 of 487 matches
Mail list logo
