Re: PROBLEM: Network hanging - Tulip driver with Netgear (Lite-On)

2001-02-22 Thread Jeff Garzik
On Thu, 22 Feb 2001, Alan Cox wrote: > > three Netgear NICs and am experiencing considerable trouble with the=20 > > combination: > > > > Kernel 2.4.[01]:ifconfig shows that the card see's traffic on t= > > he=20 > > network, but does not transmit anything (no response to ping). > > Use

Re: Linux 2.4.2ac1

2001-02-22 Thread Jeff Garzik
On Thu, 22 Feb 2001, Adrian Bunk wrote: > Hi Alan, > > is it possible that you send a list of all the changes in 2.4.2ac1 > compared to plain 2.4.2? I doubt Alan has time for requests like this (but more power to him, if he does)... His patch is diff'd against 2.4.2, so just look at the patch.

Re: [PATCH] drivers/char/serial.c unchecked ioremap() calls

2001-02-23 Thread Jeff Garzik
ecked, but it seems as if you don't release the previous > successful mappings on failure. Wipe out this message if I was too quick to > answer and this is not true. 8) Also, the proper return from a failed ioremap is -ENOMEM, so I think Andrey's serial.c patch should modify some functio

New net features for added performance

2001-02-24 Thread Jeff Garzik
te from per-CPU lists.. Disadvantages? Doing this might increase cache pollution due to increased code and data size, but I think the hot path is much improved (dequeue a properly sized, initialized, skb-reserved'd skb off a list) and would help mitigate the impact of sudden bursts of traffic.

Re: New net features for added performance

2001-02-24 Thread Jeff Garzik
Andi Kleen wrote: > > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > Advantages: A de-allocation immediately followed by a reallocation is > > eliminated, less L1 cache pollution during interrupt handling. > > Potentially less DMA traffic between card and host

Re: New net features for added performance

2001-02-24 Thread Jeff Garzik
Jeff Garzik wrote: > > Andi Kleen wrote: > > > > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > > > Advantages: A de-allocation immediately followed by a reallocation is > > > eliminated, less L1 cache pollution during interrupt handling. > >

Re: PROBLEM: Network hanging - Tulip driver with Netgear (Lite-On)

2001-02-26 Thread Jeff Garzik
r-phy, on the other hand. Pat, Manfred, in pnic_check_duplex, make this change: > -negotiated = mii_reg5 & tp->advertising[0]; > +negotiated = mii_reg5 & tulip_mdio_read(dev, tp->phys[0], 4); and let me know how it goes. I'm tempted to just remove tp->advertising[

Re: New net features for added performance

2001-02-26 Thread Jeff Garzik
"David S. Miller" wrote: > Jeff Garzik writes: > > 2) Tx packet grouping. > ... > > Disadvantages? > > See Torvalds vs. world discussion on this list about API entry points > which pass multiple pages at a time versus simpler ones which pass > only a si

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Jeff Garzik
use of the existing local 'pkt_len', and it checks off another item that should probably be on the janitor's todo list: Set 'dev->last_rx=jiffies' immediately after netif_rx. Jeff -- Jeff Garzik | "You see, in this world there's two kinds of B

Re: [PATCH] fmvj18x_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Jeff Garzik
Ditto... -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who dig. You dig." --Blondie Index: drivers/net/pcmc

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Jeff Garzik
And here are the rest of the ones in pcmcia. -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who dig. You dig." --Blondie Index: drivers/net/pc

Re: [PATCH] dlci: update last_rx after netif_rx

2001-02-26 Thread Jeff Garzik
dlp->stats.rx_packets++; > + dev->last_rx = jiffies; You need to update dlp->stats.rx_bytes too. -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft |

Re: [PATCH] cycx_x25: update last_rx after netif_rx

2001-02-26 Thread Jeff Garzik
is... For this function it is sending an event, not really a packet. So should we really timestamp it like a real packet? If so, you should increase rx_packets and rx_bytes stats too, as well as update last_rx here. Jeff -- Jeff Garzik | "You see, in this world there's

Re: PATCH] via-rhine.c: don't reference skb after passing it tonetif_rx

2001-02-27 Thread Jeff Garzik
t, and then ship them to Linus as they are proven stable. Jeff -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who dig. You dig." --Blondie - To unsubscribe

Re: Tulip 2-card problem with 2.4.2-ac5

2001-02-28 Thread Jeff Garzik
It looks like the tulip in the 'ac' patchkit includes some bad changes for 2104x-based cards. Fix in the works... NetGear/PNIC owners: let me know if 2.4.2-ac6 doesn't fix your problems. -- Jeff Garzik | "You see, in this world there's two kinds of Buildi

Re: [RFC] pci_dma_set_mask()

2001-02-28 Thread Jeff Garzik
kernel norm is to return zero on success, and -EFOO on error. I like your proposal with the extremely minor nit that I think pci_set_dma_mask should return ENODEV or EIO or something on error, and zero on success. Jeff -- Jeff Garzik | "You see, in this world there's t

Re: [patch] 2.4.2 Advantech WDT driver

2001-02-28 Thread Jeff Garzik
_STOP, 1, "Advantech WDT"); > +#endif > + request_region(WDT_START, 1, "Advantech WDT"); check return.. > + register_reboot_notifier(&advwdt_notifier); ditto -- Jeff Garzik | "You see, in this world there's two kinds of Building 10

Re: via 686a audio driver rate locked at 48Khz

2001-02-28 Thread Jeff Garzik
sourceforge (and the gtf.org URL > is gone). It's in the tarball in the download section of http://sourceforge.net/projects/gkernel/ Jeff -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns Ma

Re: patch for mini-pci ethernet card

2001-02-28 Thread Jeff Garzik
Gnt=255.Max Lat=255. > I/O at 0x1c00 [0x1cff]. > Non-prefetchable 32 bit memory at 0xe800 [0xe80003ff]. I didn't use your patch, but this support should now be in the latest test driver, in Alan Cox's "ac" series of patches. -- Jeff Garzik | "Yo

Re: via 686a audio driver rate locked at 48Khz

2001-03-02 Thread Jeff Garzik
Sergei Haller wrote: > > On Wed, 28 Feb 2001, Jeff Garzik wrote: > > > Wayne Whitney wrote: > > > I have a system with an MSI-6321 motherboard with the Via 686a > > > southbridge, and I'm having a little trouble with the via82cxxx_audio > > > soun

Re: PATCH 2.4.0 parisc PCI support

2001-03-02 Thread Jeff Garzik
[2] = child->parent->resource[2]; > + /* Base > limit means the prefetchable mem is disabled.*/ > } IIRC these "assuming transparent" lines were put in to -fix- PCI-PCI bridges on at least some x86 boxes... I didn't really understand the bridge c

Re: PROBLEM: Network hanging - Tulip driver with Netgear (Lite-On)

2001-03-02 Thread Jeff Garzik
ntroller with multiple MII phys... how does one select the phy of choice (for tulip, in the absence of SROM media table...)? And once phy A has been selected out of N available as the active phy, should you care about the others at all? Jeff -- Jeff Garzik | "You see, in thi

Re: PATCH 2.4.0 parisc PCI support

2001-03-02 Thread Jeff Garzik
hine. Two attachments... "diff -u" output for dmesg before and after your patch, and "diff -u" output for lspci before and after your patch. -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded gun

Re: The IO problem on multiple PCI busses

2001-03-03 Thread Jeff Garzik
#x27;s what MMIO is for. :) Just do void outb (u8 val, u16 addr) { void *addr = ioremap (ISA_IO_BASE + addr); if (addr) { writeb (val, addr); iounmap (addr); } } You can map and unmap for each call :) Ugly and slow, but hey, it's I/O...

Re: [patch] pci_release_region and pci_request_region

2001-03-03 Thread Jeff Garzik
buses); > EXPORT_SYMBOL(pci_enable_device); > EXPORT_SYMBOL(pci_find_capability); > +EXPORT_SYMBOL(pci_release_regions); > +EXPORT_SYMBOL(pci_request_regions); > EXPORT_SYMBOL(pci_find_class); > EXPORT_SYMBOL(pci_find_device); > EXPORT_SYMBOL(pci_find_slot); Thanks, Jeff -- J

Re: [patch] 2.4.2 Advantech WDT driver

2001-03-03 Thread Jeff Garzik
27;t do it with the misc_register, request_region > and register_reboot_notifier calls. (Should it? Cc: Alan Cox) Yes, the return codes should be checked. :) -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded

Re: How can I get promise FastTrak 66 work in kernel?

2001-03-04 Thread Jeff Garzik
Thomas Lau wrote: > > anyone have idea? > I am helping my friend to ask this question, Thanks > I mean kernel 2.4.1 Read Documentation/SubmittingDrivers -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend:

Re: Loop stuck in -D state

2001-03-05 Thread Jeff Garzik
with 2.4.2 that makes you want to go back? Anyway, if > you grab Jens' patch, all will be peachy (at least for that kind of > basic usage). 2.4.3-pre2 should be the one to test... it should include the latest loop fixes.. -- Jeff Garzik | "You see, in this world there's

Re: Linux 2.4.2ac12

2001-03-05 Thread Jeff Garzik
d by db2 and db3. db1 is where the "original" Berkeley db stuff now lives. Apparently aicasm needs db 1. So, update your packages, or create the proper symlinks if you've already got db1 installed in some other location. -- Jeff Garzik | "You see, in this world there&

Re: Linux 2.4.2ac12

2001-03-05 Thread Jeff Garzik
that driver, then :) You do what ya gotta do... -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who dig. You dig." --Blondie - To unsubscribe from this list: send t

Re: 3c509 2.4.2-ac12 compilation fails

2001-03-05 Thread Jeff Garzik
el3_isapnp_adapters[i].name, ioaddr, irq); > + printk ("ISAPnP reports %d at i/o 0x%x, irq %d\n", > + el3_isapnp_adapters[i].card_device, ioaddr, That should be s/name/driver_data/... /me begins to downl

Re: Kernel support for hot-plugging PCI adapters

2001-03-05 Thread Jeff Garzik
pci.txt. Look for 'probe', 'id_table', etc. I don't think there is support in the current tree for a controller that supports physical hotplugging of PCI adapters, yet. Compaq has a driver outside the tree to do such a thing (needing only very minor kernel patches), see

[PATCH] Re: 3c509 2.4.2-ac12 compilation fails

2001-03-05 Thread Jeff Garzik
ttached patch (which needs to be applied anyway). -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who dig. You dig." --

Re: Drivers under 2.4

2001-01-11 Thread Jeff Garzik
00 0300 > 03b4ef22 002a 0300 03f9a882 007e 0300 > 03f9a982 007e 0300 03f9aa82 007e 0300 > eth0: pcnet32_start_xmit() called, csr0 05f3. > eth0: pcnet32_start_xmit() called, csr0 07f3. > > etc... Does this patch help at all? Jeff --

Re: ACPI lockup on boot in 2.4.0

2001-01-11 Thread Jeff Garzik
t a more verbose failure scenario, grab the ACPI debug version from http://developer.intel.com/technology/IAPC/acpi/downloads.htm Jeff -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft

Re: [PATCH] 8139too.c patch to allow setting of MAC address to actually work.

2001-01-11 Thread Jeff Garzik
is broken too, but I think Donald is going to send > the fixes for it. I have updated 8139too to include this and other changes. The new version can be downloaded from the SourceForge project page (http://sourceforge.net/projects/gkernel/), and hopefully it should show up in a release kernel eve

Re: QUESTION: Network hangs with BP6 and 2.4.x kernels, hardware related?

2001-01-11 Thread Jeff Garzik
if you unplug a cable suddenly, or if your hardware isn't delivering interrupts, or many other things... Jeff -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who

Re: Updated zerocopy patch up on kernel.org

2001-01-09 Thread Jeff Garzik
t it is > working perfectly fine and adds no new bugs, testers are thus in > nirvana and thus have nothing to report. :-) Is there any value to supporting fragments in a driver which doesn't do hardware checksumming? IIRC Alexey had a patch to do such for Tulip, but I don't se

Re: [PATCH] make drivers/scsi/atari_scsi.c check request_irq (240p3)

2001-01-14 Thread Jeff Garzik
return 0; > + } request_irq returns zero on success, not on failure. Further, you need to return the request_irq error value back to the caller, if possible. Jeff -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | pe

pre5 VM feedback..

2001-01-15 Thread Jeff Garzik
sion should be drawn from this data. I just thought that the VM folks might find it interesting and/or useful. Jeff -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and

Re: pre5 VM feedback..

2001-01-15 Thread Jeff Garzik
Linus Torvalds wrote: > In article <[EMAIL PROTECTED]>, > Jeff Garzik <[EMAIL PROTECTED]> wrote: > >$!@#@! pre6 is already out :) > Yes, and for heavens sake don't use it, [...] Too late... First and foremost, a correction: The VM data I posted was for pre1

Re: 2.4.0 config breaks /dev/fd0* major/minor ?

2001-01-17 Thread Jeff Garzik
Jeffrey Rose wrote: > I get a wrong major/minor reported when attempting > to mount /dev/fd0 ... Sounds like it can't find the floppy driver, for whatever reason... -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my frie

Re: Linux not adhering to BIOS Drive boot order?

2001-01-17 Thread Jeff Garzik
mount(8) supports mounting by '-L ' and '-U '. Most modern mke2fs proggies will assign a UUID to each newly created filesystem. For /etc/fstab, you can specify LABEL=xxx or UUID=xxx instead of a device name. The one thing I don't know is... can the kernel mount the root

Re: 2.4.0-ac10 patching issue

2001-01-19 Thread Jeff Garzik
Frank Davis wrote: > > Hello, >I just applied 2.4.0-ac10 to 2.4.0(patch -p1 and include/iinux/autoconf.h and include/linux/modversion.h didn't apply cleanly. I >received .rej files. make mrproper, those files are generated by the build -- Jeff Garzik | "

Re: Linux 2.4.0-ac10 build errors

2001-01-19 Thread Jeff Garzik
Steven Cole wrote: > > I got the following errors building 2.4.0-ac10: > The first three digits are the line number in the build log. Always run 'make mrproper' before building. Alan's patch accidentally includes some files that are generated by the build system.

Re: Ethernet drivers: SiS 900, Netgear FA311

2001-01-20 Thread Jeff Garzik
ates the existing sis900 driver, the > FA311 is not yet supported by the kernel. Not true, see natsemi.c (in 2.4.x at least). -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those

Re: Q: natsemi.c spinlocks

2001-01-21 Thread Jeff Garzik
should use pci_alloc_consistent and pci_map_single? Eventually, all drivers which use PCI DMA of some sort -should- use pci_alloc_consistent, etc. Jeff -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with

[PATCH] Re: Q: natsemi.c spinlocks

2001-01-21 Thread Jeff Garzik
would prefer. Comments? The Tx locking is a bit conservative -- I think Donald suggested it could be removed completely -- but I would prefer to have something I am 100% certain will work, and then test the driver without locking under stress conditions to make sure no race or other bug exists.

Re: Ethernet drivers: SiS 900, Netgear FA311

2001-01-21 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: > > On Sun, Jan 21, 2001 at 01:54:34PM +0100, [EMAIL PROTECTED] wrote: > > On 20 Jan, Jeff Garzik wrote: > > > > > Not true, see natsemi.c (in 2.4.x at least). > > > > Correct, and the cards really work with it. > > natsemi

Re: 2.4.1-test10

2001-01-22 Thread Jeff Garzik
t; pre10: > > - got a few too-new R128 #defines in the Radeon merge. Fix. > > - tulip driver update from Jeff Garzik > > - more cpq and DAC elevator fixes from Jens. Looks good. > > - Petr Vandrovec: nicer ncpfs behaviour > > - Andy Grover: APCI update > > -

Re: [PATCH] pcmcia event thread. (fwd)

2000-11-13 Thread Jeff Garzik
ot; != "n" ]; then > # if [ "$CONFIG_PCI" != "n" ]; then > # bool ' CardBus support' CONFIG_CARDBUS > # fi > # bool ' i82365 compatible bridge support' CONFIG_I82365 > # bool ' Databook TCIC host bridge support' CON

Re: ns558 pci/isa change

2000-11-13 Thread Jeff Garzik
is something like the attached patch... -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso Index: drivers/char/joystick/ns558.c ==

Re: [PATCH] tulip oops

2000-11-13 Thread Jeff Garzik
ry at: http://sourceforge.net/projects/tulip/ It will be merged to the stable branch and 2.4.0-test11-preXX after some testing of this and some other changes... -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft|

Re: [patch] acenic driver update

2000-11-13 Thread Jeff Garzik
ope, you don't need that. if you are start_xmit, and you didn't stop the queue yourself, there's no need to start it, and definitely no need to wake... you can probably remove 'tx_full' as well, as it is usually redundant to tbusy/netif_{start,stop}_queue. Jeff

Re: newbie, 2.4.0-test11-pre4 no compile when CONFIG_AGP=y

2000-11-14 Thread Jeff Garzik
g file gives undefined results. Make > all changes through menuconfig or xconfig. The config system does lots > of work behind the scenes which is not peformed if you hand edit. Hand editing works just fine... You just have to remember to run "make oldconfig" afterwards.

Re: [PATCH] CONFIG_EISA note in Documentation/Configure.help

2000-11-14 Thread Jeff Garzik
set of working machines. Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH] CONFIG_EISA note in Documentation/Configure.help

2000-11-14 Thread Jeff Garzik
in the above comparison. When !CONFIG_EISA, the global variable 'EISA_bus' is unconditionally zero. Therefore you merely need to test EISA_bus, as existing code already should be doing.. As for 3c59x patches, they should go to the maintainer, Andrew Morton.. Jeff -- Jeff

PATCH 2.4.0.11.4: loopback block device fixes

2000-11-14 Thread Jeff Garzik
Since I am not a block device expert, I am interested to know if these fixes look ok, and if they fix the reported loopback deadlocks. I added calls to deactive_page and flush_dcache_page, and made sure that any error returns were propagated back to the caller. This is UNTESTED but it looks ok t

Re: [PATCH] Re: test11-pre5

2000-11-14 Thread Jeff Garzik
"Space.c" file). It is the name > * the interface. > */ > charname[IFNAMSIZ]; -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso - To unsubsc

Re: Patch(?): linux-2.4.0-test11-pre4/drivers/sound/yss225.c compilefailure

2000-11-14 Thread Jeff Garzik
people of some memory that could otherwise be freed at boot. And the number of CONFIG_HOTPLUG people is not small, it includes not only the CardBus users but USB users too... Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense

Re: [PATCH] Re: test11-pre5

2000-11-14 Thread Jeff Garzik
Dan Aloni wrote: > > On Tue, 14 Nov 2000, Jeff Garzik wrote: > > > Dan Aloni wrote: > > > > > > reason: Correct me if I'm wrong, but 3c501.c:init_module() calls > > > net_init.c:register_netdev(&dev_3c501), which calls strchr(), > >

Re: Patch(?): linux-2.4.0-test11-pre4/drivers/sound/yss225.c compilefailure

2000-11-14 Thread Jeff Garzik
ease discuss this on linux-kernel, so we can have a coherent hotplug strategy for the entire kernel. If we are going to create CONFIG_USB_HOTPLUG, we must -eliminate- CONFIG_HOTPLUG, and create CONFIG_PCI_HOTPLUG, and CONFIG_ANOTHERBUS_HOTPLUG and so on, for each hotplug bus. Jeff --

Re: Patch(?): linux-2.4.0-test11-pre4/drivers/sound/yss225.c compilefailure

2000-11-14 Thread Jeff Garzik
Greg KH wrote: > On Wed, Nov 15, 2000 at 12:29:15AM -0500, Jeff Garzik wrote: > > If we are going to create CONFIG_USB_HOTPLUG, we must -eliminate- > > CONFIG_HOTPLUG, and create CONFIG_PCI_HOTPLUG, and > > CONFIG_ANOTHERBUS_HOTPLUG and so on, for each hotplug bus. >

Re: CONFIG_USB_HOTPLUG (was Patch(?): linux-2.4.0-test11-pre4/drivers/sound/yss225.c compile failure)

2000-11-15 Thread Jeff Garzik
elves in the foot. I don't see that __devinitdata should be removed. *plonk* -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso - To unsubscribe from this list: send the line "un

Re: [CFT] dmfe.c network driver update for 2.4

2000-11-15 Thread Jeff Garzik
s... Thanks, Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

Re: PCI configuration changes

2000-11-16 Thread Jeff Garzik
ds' CONFIG_NET_ISA $CONFIG_ISA > > to eliminate more drivers from non-ISA arch configs ? > > Looks good to me. Anything to remove clutter from config menus Patch looks ok to me, applied. -- Jeff Garzik | Building 1024 | The chief enemy of creativity is &

Re: PCI configuration changes

2000-11-16 Thread Jeff Garzik
bus should be unconditionally defined to zero. Look at how 'EISA_bus' is handled in test11-pre5... Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso - To unsubscribe

Re: [PATCH] pcmcia event thread. (fwd)

2000-11-16 Thread Jeff Garzik
Alan Cox wrote: > the modules from David Hinds and Linus > pcmcia are not 100% binary compatible for all cases. What cases are these? David's been pretty good about putting 2.4.x support into pcmcia_cs package... -- Jeff Garzik | Building 1024 | The chi

Re: PATCH: 8139too kernel thread

2000-11-16 Thread Jeff Garzik
hen net drivers poll media selection here. Regards, Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

RFC: "SubmittingPatches" text

2000-11-16 Thread Jeff Garzik
I'd like to put the following document into the kernel tree as linux/Documentation/SubmittingPatches, and would like to get comments on it. I've likely left out a lot in Section 2... additions welcome. I don't want to get too domain-specific in section 2, but I would like to cover as many "unwrit

Re: [CFT] dmfe.c network driver update for 2.4

2000-11-16 Thread Jeff Garzik
Tobias Ringstrom wrote: > On Wed, 15 Nov 2000, Jeff Garzik wrote: > > Tobias Ringstrom wrote: > > > I have updated the dmfe.c network driver for 2.4.0-test by adding proper > > > locking (I hope), and also made transmission much efficient. > > Would you mind cre

Re: 2.4.0-test11-pre6 fails compile (dev.c)

2000-11-16 Thread Jeff Garzik
ks ok to me, though I prefer that #endif include a comment following it that names the cpp symbol it encloses. Applied... Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso - To uns

Re: test11-pre6

2000-11-17 Thread Jeff Garzik
ty is no longer > compile-time dependent (always compiled in) ? Surround the networking code with CONFIG_HOTPLUG. A patch has already been posted to lkml. Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft

Re: Error in x86 CPU capabilities starting with test5/6

2000-11-17 Thread Jeff Garzik
s?) proposed the solution of a 'magic page' which holds information like gettimeofday() stuff, but could be handled much more rapidly than a standard syscall. -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft

Re: Error in x86 CPU capabilities starting with test5/6

2000-11-17 Thread Jeff Garzik
Andi Kleen wrote: > No it would not. Often you want cycle accurate couting for profiling > purposes. Isn't that why /dev/cpu/%d/msr exists? -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft|

Re: VGA PCI IO port reservations

2000-11-17 Thread Jeff Garzik
the fbdev driver's "clarifying the picture" of the hardware resource usage. [again, this hullabaloo might only be necessary on x86] Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft

Re: [PATCH] pcmcia event thread. (fwd)

2000-11-17 Thread Jeff Garzik
: none > host opts [3]: none > ISA irqs (default) = none! polling interval = 1000 ms For these two, it sounds to me like you need to be doing a PCI probe, and getting the irq and I/O port info from pci_dev. And calling pci_enable_device, which may or may not be a s

Re: VGA PCI IO port reservations

2000-11-17 Thread Jeff Garzik
Russell King wrote: > Jeff Garzik writes: > > > For example, S3 cards typically use: > > > > > > 0x0102, 0x42e8, 0x46e8, 0x4ae8, 0x8180 - 0x8200, 0x82e8, 0x86e8, > > > 0x8ae8, 0x8ee8, 0x92e8, 0x96e8, 0x9ae8, 0x9ee8, 0xa2e8, 0xa6e8, > >

Re: VGA PCI IO port reservations

2000-11-17 Thread Jeff Garzik
cifically, you can do 100% MMIO, and simply turn off all I/O decoding. Check out Keith Packard's kdrive/s3trio in the XFree86 tree... Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft|

Re: VGA PCI IO port reservations

2000-11-17 Thread Jeff Garzik
Russell King wrote: > Jeff Garzik writes: > > If XFree86 not fbdev is using the hardware, you can always have a stub > > driver that does nothing but reserve the ports. Remember, too, that the > > ports claimed depend on register settings in the video card and PCI > >

Re: who's maintaning vgacon.c ?

2000-11-17 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: > > or in any way responsible for it? > James Simmons maybe ? No one, AFAIK. James has been hacking around in fbdev for a while and knows his way around video stuff, so he has posted a few patches for vgacon. Jeff -- Je

Re: duplicate entries in rtl8129 driver

2000-11-17 Thread Jeff Garzik
ble. :) RealTek sent me a RTL8130 so I can test the MII stuff finally. Note that those duplicate ids should be commented out of rtl8129.c, also. -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso

Re: [CFT] dmfe.c network driver update for 2.4

2000-11-17 Thread Jeff Garzik
rather fix those non-SMP compliant drivers to be SMP compliant, > then keeping them 'broken'. Adding the print statements would only be a > temporary solution. Agreed. If people have SMP safety patches for net drivers, let me know... Jeff -- Jeff Garzik | Buil

EXPORT_NO_SYMBOLS vs. (null) ?

2000-11-17 Thread Jeff Garzik
What is the difference between a module that exports no symbols and includes EXPORT_NO_SYMBOLS reference, and such a module that lacks EXPORT_NO_SYMBOLS? Alan once upbraided me for assuming they were the same :) -- Jeff Garzik | Building 1024 | The chief enemy of

Re: sound and scsi pci MODULE_DEVICE_TABLE entries? (primary for Alan Cox)

2000-11-17 Thread Jeff Garzik
"Adam J. Richter" wrote: > Hello Alan, > > Jeff Garzik tells me that you, with some help from some other > kernel developers, are hacking on the sound drivers right now. I > would like to add PCI MODULE_DEVICE_TABLE entries to three of > the four PCI soun

Re: test11-pre6 still very broken

2000-11-17 Thread Jeff Garzik
including my dinky Presario, use Via for their north/southbridge chipset. Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso - To unsubscribe from this list: send the line "uns

Re: EXPORT_NO_SYMBOLS vs. (null) ?

2000-11-18 Thread Jeff Garzik
^^^ and statics > > I consider that a bug, but... eh? Can you give an example of this? This should definitely -not- be the case. Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft|

Re: EXPORT_NO_SYMBOLS vs. (null) ?

2000-11-18 Thread Jeff Garzik
Rogier Wolff wrote: > > Jeff Garzik wrote: > > Rogier Wolff wrote: > > > > > > Alan Cox wrote: > > > > > What is the difference between a module that exports no symbols and > > > > > includes EXPORT_NO_SYMBOLS referen

Re: [PATCH] megaraid driver update for 2.4.0-test10

2000-11-18 Thread Jeff Garzik
READ_PROC("status", proc_read_status); > + megaCfg->proc_stat = CREATE_READ_PROC("stat", proc_read_stat); > + megaCfg->proc_mbox = CREATE_READ_PROC("mailbox", proc_read_mbox); what happens if any of these fail? > +#define PROCBUFSIZE 4096

Re: [CFT] dmfe.c network driver update for 2.4

2000-11-18 Thread Jeff Garzik
a warning, but it can take days > or weeks to find someone to really fix the driver. That was my point. Marking them with a #warning is fine with me. -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft|

Re: PROBLEM: 3c509 driver broken in 2.4.0-test10, not in -test9

2000-11-19 Thread Jeff Garzik
;-) that is 2.0.x, > 2.2.x, and 2.4.0-test up to 9. In 2.4.0-test10 it opes upon modprobing. > lsmod says "initializing" in the 3c509 entry, forever. > > 3. > 3c509, 3C509, Ethernet, networking, 2.4.0-test10 fixed in test11-preXX -- Jeff Garzik | Buildi

Re: Where did kgcc go in 2.4.0-test10 ?

2000-11-01 Thread Jeff Garzik
um linux_2_4]$ kgcc -v Reading specs from /usr/lib/gcc-lib/i586-mandrake-linux/egcs-2.91.66/specs gcc driver version 2.95.3 19991030 (prerelease) executing gcc version egcs-2.91.66 Thanks, Jeff -- Jeff Garzik | "Mind if I drive?" -Sam Building 1024 |

PATCH 2.4.0.10 v2: Update hotplug

2000-11-03 Thread Jeff Garzik
BOL(hotplug_path), modules don't need it * constify netdev_event_name[] array Now, time to track down that elusive thing called sleep... :) -- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft| -/usr/games/fortune In

Re: Linux 2.4.0test11-ac1

2000-11-21 Thread Jeff Garzik
kwards... [un]load_8390_module is null, has been for a while. A bombing run was made recently through most drivers to -remove- the now-null calls to *_8390_module. > o Tulip crash fix on weird eeproms Hopefully an update with this and more will be out this week. Jeff -

Re: 3c59x: Using bad IRQ 0

2000-11-21 Thread Jeff Garzik
I hope that is an exception rather than the rule. Regards, Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft| -- Picasso - To unsubscribe from this list: send the line "unsubscribe

Re: [uPATCH] fix IDE/ServerWorks OSB4 config option (test11)

2000-11-21 Thread Jeff Garzik
nd it looks pretty well-written and portable to me... Nothing X86 specific about it. Ditto some of the others depending on CONFIG_X86. IMHO even if the southbridge is currently only known to be used on x86's, that doesn't mean that the hardware, or the driver, will always be limited

Re: Patch: linux-2.4.0-test11/drivers/sound/maestro.c port to new PCI interface

2000-11-21 Thread Jeff Garzik
ro_power seems sufficient. or maybe stop_dma+free_irq+poweroff. Unrelated to your change: Feel free to submit patches to update Documentation/pci.txt if you feel it is missing information. Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is &qu

Re: [PATCH] removal of "static foo = 0" from drivers/ide (test11)

2000-11-21 Thread Jeff Garzik
s of the compiler ??? There is nothing wrong with that change. Standard kernel style cleanup, which saves a few bytes in the output kernel image. Jeff -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSoft|

Re: Patch(?): pci_device_id tables for linux-2.4.0-test11/drivers/block

2000-11-22 Thread Jeff Garzik
ss_pci_tbl); hell no > --- linux-2.4.0-test11/drivers/block/cpqarray.c Thu Nov 16 11:30:29 2000 > +++ linux/drivers/block/cpqarray.c Wed Nov 22 12:34:53 2000 ok -- Jeff Garzik | Building 1024 | The chief enemy of creativity is "good" sense MandrakeSo

Re: Patch(?): pci_device_id tables for linux-2.4.0-test11/drivers/block

2000-11-22 Thread Jeff Garzik
Andi Kleen wrote: > > On Wed, Nov 22, 2000 at 05:14:38PM -0500, Jeff Garzik wrote: > > *This* is the over-engineering attitude I was talking about. The only > > reason why you are preferring named initializers is because > > pci_device_id MIGHT be changed. And if it

<    1   2   3   4   5   6   7   8   9   10   >