> On Jul 1, 2020, at 14:46, Takashi Iwai wrote:
>
> On Wed, 01 Jul 2020 07:21:35 +0200,
> Kai-Heng Feng wrote:
>>
>> If a system has two GPIO controlled LED, one for mute and another one
>> for micmute, and both of them are on before system suspend, sometimes
() may affect other drivers' suspend routines,
take a more contained approach which uses blocking op to make sure the
LED gets turned off.
Signed-off-by: Kai-Heng Feng
---
drivers/leds/led-core.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/leds/led-core.c b/drivers/leds/led
Hi,
> On Jul 3, 2020, at 20:27, Hans de Goede wrote:
>
> Hi,
>
> On 7/1/20 8:46 AM, Kai-Heng Feng wrote:
>>> On Jun 19, 2020, at 17:56, Hans de Goede wrote:
>>>
>>> Hi,
>>>
>>> On 6/19/20 6:16 AM, Kai-Heng Feng wrote:
&g
the wakeup capability
so users can enable it at their own discretion.
Signed-off-by: Kai-Heng Feng
---
v4:
- Enable the capability, but disable the wakeup default.
v3:
- Use device_init_wakeup().
- Wording change.
v2:
- Fix compile error when ACPI is not enabled.
drivers/hid/i2c-hid/i2c-hid-core.c
kernel: atlantic: probe of :01:00.0 failed with error -95
As a pure guesswork, simply adding the firmware version to the driver
can make it function. Doing iperf3 as a smoketest doesn't show any
abnormality either.
Signed-off-by: Kai-Heng Feng
---
drivers/net/ethernet/aquantia/atlantic/hw_atl
> On Jun 30, 2020, at 16:37, Kai-Heng Feng wrote:
>
>
>> On Jun 10, 2020, at 15:55, Kai-Heng Feng wrote:
>>
>> On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port
>> becomes useless and never responds to cable hotplugging:
>>
> On Jun 17, 2020, at 23:50, Takashi Iwai wrote:
>
> On Wed, 17 Jun 2020 17:24:30 +0200,
> Kai-Heng Feng wrote:
>>
>>
>>
>>> On Jun 17, 2020, at 19:55, Takashi Iwai wrote:
>>>
>>> On Wed, 17 Jun 2020 12:29:01 +0200,
>>>
Hi Jens,
> On Jun 3, 2020, at 16:40, John Garry wrote:
>
> On 03/06/2020 08:48, Kai-Heng Feng wrote:
>> Commit 130f4caf145c ("libata: Ensure ata_port probe has completed before
>> detach") may cause system freeze during suspend.
>> Using async_synchronize_f
> On Jun 18, 2020, at 15:32, Takashi Iwai wrote:
>
> On Thu, 18 Jun 2020 07:15:21 +0200,
> Kai-Heng Feng wrote:
>>
>>
>>
>>> On Jun 17, 2020, at 23:50, Takashi Iwai wrote:
>>>
>>> On Wed, 17 Jun 2020 17:24:30 +0200,
>>> K
Many laptops can be woken up from Suspend-to-Idle by touchpad. This is
also the default behavior on other OSes.
So let's enable the wakeup support if the system defaults to
Suspend-to-Idle.
Signed-off-by: Kai-Heng Feng
---
v3:
- Use device_init_wakeup().
- Wording change.
v2:
- Fix compile
Hi,
> On Jun 18, 2020, at 23:28, Hans de Goede wrote:
>
> Hi,
>
> On 6/18/20 4:55 PM, Kai-Heng Feng wrote:
>> Many laptops can be woken up from Suspend-to-Idle by touchpad. This is
>> also the default behavior on other OSes.
>> So let's enable the wake
mandates.
Signed-off-by: Kai-Heng Feng
---
v2:
- Wording change.
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
index f491d8b4e24c
Hi Mathias,
> On Jun 9, 2020, at 18:15, Kai-Heng Feng wrote:
>
>
>
>> On Jun 8, 2020, at 19:21, Mathias Nyman
>> wrote:
>>
>> On 20.5.2020 13.18, Kai-Heng Feng wrote:
>>> USB2 devices with LPM enabled may interrupt the system suspend:
>
> On Jun 10, 2020, at 23:49, mario.limoncie...@dell.com wrote:
>
>> -Original Message-
>> From: platform-driver-x86-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Kai-Heng Feng
>> Sent: Wednesday, June 10, 2020 10:38 AM
>> To: alex.h..
> On Jun 11, 2020, at 01:41, Alex Hung wrote:
>
> On 2020-06-10 9:49 a.m., mario.limoncie...@dell.com wrote:
>>> -Original Message-
>>> From: platform-driver-x86-ow...@vger.kernel.org >> ow...@vger.kernel.org> On Behalf Of Kai-Heng Feng
>>
> On Jun 10, 2020, at 23:58, Mathias Nyman
> wrote:
>
> On 10.6.2020 18.43, Kai-Heng Feng wrote:
>>
>>
>>> On Jun 10, 2020, at 22:32, Alan Stern wrote:
>>>
>>> On Wed, Jun 10, 2020 at 02:42:30PM +0800, Kai-Heng Feng wrote:
>>>&
> On May 21, 2020, at 12:43, Kai-Heng Feng wrote:
>
> Hi Srinivas,
>
>> On May 9, 2020, at 01:45, Srinivas Pandruvada
>> wrote:
>>
>> On Tue, 2020-05-05 at 21:17 +0800, Kai-Heng Feng wrote:
>>> PCI_DEV_FLAGS_NO_D3 should not be used outs
pad.net/bugs/1867983
Suggested-by: John Garry
Signed-off-by: Kai-Heng Feng
---
v2:
- Sync up to cookie + 1.
- Squash the synchronization into the same loop.
drivers/ata/libata-core.c | 9 -
include/linux/libata.h| 3 +++
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git
Hi Srinivas,
> On May 9, 2020, at 01:45, Srinivas Pandruvada
> wrote:
>
> On Tue, 2020-05-05 at 21:17 +0800, Kai-Heng Feng wrote:
>> PCI_DEV_FLAGS_NO_D3 should not be used outside of PCI core.
>>
>> Instead, we can use pci_save_state() to hint PCI core that t
pad.net/bugs/1867983
Suggested-by: John Garry
Signed-off-by: Kai-Heng Feng
---
v3:
- Move the comment to properly align with the code.
v2:
- Sync up to cookie + 1.
- Squash the synchronization into the same loop.
drivers/ata/libata-core.c | 11 +--
include/linux/libata.h| 3 +++
> On Jun 16, 2020, at 18:05, Aaron Ma wrote:
>
> After commit "e1000e: disable s0ix entry and exit flows for ME systems",
> some ThinkPads always failed to disable ulp by ME.
> commit "e1000e: Warn if disabling ULP failed" break out of init phy:
>
> error log:
> [ 42.364753] e1000e
call_micmute_led_update() to control both case.
In addition to that, add LED_CORE_SUSPENDRESUME flag since some systems
don't restore the LED properly after suspend.
Signed-off-by: Kai-Heng Feng
---
v2:
- Prevent platforms like Dell, Lenovoe and Huawei create double LED
class devices.
sound
There are two more HP systems control mute LED from HDA codec and need
to expose micmute led class so SoF can control micmute LED.
Add quirks to support them.
Signed-off-by: Kai-Heng Feng
---
v2:
- Wording.
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
There are two more HP systems control mute LED from HDA codec and need
to expose micmute led class so SoF can control micmute LED.
Add quirks to support them.
Signed-off-by: Kai-Heng Feng
---
v3:
- No change.
v2:
- Wording.
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions
to that, add LED_CORE_SUSPENDRESUME flag since some systems
don't restore the LED properly after suspend.
Signed-off-by: Kai-Heng Feng
---
v3:
- Wording.
- Properly prefix exported symbol.
v2:
- Prevent platforms like Dell, Lenovoe and Huawei create double LED
class devices.
sound/pci/hda
> On Jun 17, 2020, at 19:55, Takashi Iwai wrote:
>
> On Wed, 17 Jun 2020 12:29:01 +0200,
> Kai-Heng Feng wrote:
>>
>> Currently, HDA codec LED class can only be used by GPIO controlled LED.
>> However, there are some new systems that control LED via COEF inste
> On Jun 17, 2020, at 19:55, Takashi Iwai wrote:
>
> On Wed, 17 Jun 2020 12:29:02 +0200,
> Kai-Heng Feng wrote:
>>
>> There are two more HP systems control mute LED from HDA codec and need
>> to expose micmute led class so SoF can control micmute LED.
>
> On May 6, 2020, at 18:28, Kai-Heng Feng wrote:
>
> On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port
> becomes useless and never responds to cable hotplugging:
> [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon
> [3.031945] [
> On May 5, 2020, at 01:16, Kai-Heng Feng wrote:
>
> Etron EJ168 USB 3.0 Host Controller stops working after S3, if it was
> runtime suspended previously:
> [ 370.080359] pci :02:00.0: can't change power state from D3cold to D0
> (config space inaccessible)
> [
> On May 7, 2020, at 18:35, Mathias Nyman wrote:
>
> On 7.5.2020 11.21, Greg Kroah-Hartman wrote:
>> On Thu, May 07, 2020 at 03:58:36PM +0800, Kai-Heng Feng wrote:
>>>
>>>
>>>> On May 7, 2020, at 15:31, Greg Kroah-Hartman
>>>> w
> On May 20, 2020, at 18:18, Kai-Heng Feng wrote:
>
> USB2 devices with LPM enabled may interrupt the system suspend:
> [ 932.510475] usb 1-7: usb suspend, wakeup 0
> [ 932.510549] hub 1-0:1.0: hub_suspend
> [ 932.510581] usb usb1: bus suspend, wakeup 0
> [ 932.510
The HP Thunderbolt Dock has two separate USB devices, one is for speaker
and one is for headset. Add names for them so userspace can apply UCM
settings.
Signed-off-by: Kai-Heng Feng
---
sound/usb/quirks-table.h | 20
1 file changed, 20 insertions(+)
diff --git a/sound/usb
the same
interface.
In addition to that, add LED_CORE_SUSPENDRESUME flag since some systems
don't restore the LED properly after suspend.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/hda_generic.c | 28
sound/pci/hda/patch_realtek.c | 30
There are two more HP systems control mute LED from HDA and control
micmute LED from SoF. Add IDs to support them.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> On Jun 16, 2020, at 16:01, Takashi Iwai wrote:
>
> On Tue, 16 Jun 2020 06:46:58 +0200,
> Kai-Heng Feng wrote:
>>
>> Currently, only HDA codec GPIO controlled LED class is supported, and
>> only via platform specific quirk.
>>
>> There are systems
TS5847/RTS5852 cameras have been
reported to work well.
Cc: sta...@vger.kernel.org
Signed-off-by: ming_qian
[Factor out code to helper function, update size checks]
Signed-off-by: Laurent Pinchart
I tested this new patch and it works well.
Tested-by: Kai-Heng Feng
diff -
using a kernel
> with the named commit is causing this behaviour. This is the result from the
> bisection:
>
> a99790bf5c7f3d68d8b01e015d3212a98ee7bd57 is the first bad commit
> commit a99790bf5c7f3d68d8b01e015d3212a98ee7bd57
> Author: Kai-Heng Feng
> Date: Thu Jun 21 1
> On Jan 25, 2019, at 4:05 AM, Bjorn Helgaas wrote:
>
> On Thu, Jan 24, 2019 at 11:29:37PM +0800, Kai Heng Feng wrote:
>>> On Jan 24, 2019, at 11:15 PM, Bjorn Helgaas wrote:
>>> On Wed, Jan 23, 2019 at 03:17:37PM +0800, Kai Heng Feng wrote:
>>>>>
Hi Kieran,
> On Jan 28, 2019, at 4:48 PM, Kieran Bingham
> wrote:
>
> Hi Kai-Heng,
>
> On 27/01/2019 05:56, Kai-Heng Feng wrote:
>> Hi,
>>
>> We have a bug report [1] that the ipu3 doesn’t work.
>> Does ipu3 need special userspace to work?
>
that doesn't work well
with ON/SLEEP commands. Disable runtime PM to fix the issue.
Signed-off-by: Kai-Heng Feng
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/i2c-hid/i2c-hid.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 3171db744c1c
> On Jan 14, 2019, at 19:18, Jiri Kosina wrote:
>
> On Mon, 14 Jan 2019, Kai-Heng Feng wrote:
>
>> A Goodix touchpad doesn't work. Touching the touchpad can trigger IRQ
>> but there's no input event from HID subsystem.
>>
>> Turns out it reports some inv
> On Jan 16, 2019, at 16:21, Kai Heng Feng wrote:
>
>
>
>> On Jan 14, 2019, at 19:18, Jiri Kosina wrote:
>>
>> On Mon, 14 Jan 2019, Kai-Heng Feng wrote:
>>
>>> A Goodix touchpad doesn't work. Touching the touchpad can trigger IRQ
>
-by: Kai-Heng Feng
---
drivers/input/mouse/elantech.c | 58 +-
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 9fe075c137dc..5bcf1c147eb1 100644
--- a/drivers/input/mouse
> On Jan 17, 2019, at 16:06, Benjamin Tissoires
> wrote:
>
> On Thu, Jan 17, 2019 at 6:02 AM Kai-Heng Feng
> wrote:
[snipped]
>> Goodix says the firmware needs at least 60ms to fully respond ON and
>> SLEEP command.
>
> I was about to say that this is no
> On Jan 17, 2019, at 10:42 PM, Benjamin Tissoires
> wrote:
>
> Hi Kai-Heng,
>
> On Thu, Jan 17, 2019 at 10:30 AM Kai-Heng Feng
> wrote:
>>
>> There are some new HP laptops with Elantech touchpad don't support
>> multitouch
> On Jan 29, 2019, at 18:05, Benjamin Tissoires
> wrote:
>
> On Mon, Jan 21, 2019 at 4:30 AM Kai-Heng Feng
> wrote:
>>
>>
>>
>>> On Jan 18, 2019, at 23:50, Benjamin Tissoires
>>> wrote:
>>>
>>> Hi Kai-H
> On Jan 30, 2019, at 16:21, Greg KH wrote:
>
> On Thu, Jan 24, 2019 at 02:16:43PM +0800, Kai-Heng Feng wrote:
>> The QCA Rome USB Bluetooth controller has several issues once LPM gets
>> enabled:
>> - Fails to get enumerated in coldboot. [1]
>> - Drains mo
The return value of rtl_load_file() can be either firmware length or
error code.
For consistency, always return error code and pass firmware length via
another pointer.
Signed-off-by: Kai-Heng Feng
---
drivers/bluetooth/btrtl.c | 21 ++---
1 file changed, 10 insertions(+), 11
: https://bugzilla.kernel.org/show_bug.cgi?id=201921
Signed-off-by: Kai-Heng Feng
---
drivers/bluetooth/btrtl.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index c36f500d8313..e2f89d57dd14 100644
--- a/drivers
oth
vendor helpers.
Signed-off-by: Kai-Heng Feng
---
drivers/bluetooth/btrtl.c | 43 +-
drivers/bluetooth/btrtl.h | 5 +++--
drivers/bluetooth/hci_h5.c | 16 ++
3 files changed, 23 insertions(+), 41 deletions(-)
diff --git a/drivers/bluetooth/btrtl.c
> On Jan 24, 2019, at 11:15 PM, Bjorn Helgaas wrote:
>
> On Wed, Jan 23, 2019 at 03:17:37PM +0800, Kai Heng Feng wrote:
>>> On Jan 23, 2019, at 7:51 AM, Bjorn Helgaas wrote:
>>> On Tue, Jan 22, 2019 at 02:45:44PM +0800, Kai-Heng Feng wrote:
>>>>
> On Jan 25, 2019, at 08:55, Daniel Drake wrote:
>
> On Thu, Jan 24, 2019 at 11:23 PM Kai-Heng Feng
> wrote:
>> Realtek bluetooth may not work after reboot:
>> [ 12.446130] Bluetooth: hci0: RTL: rtl: unknown IC info, lmp subver a99e,
>> hci rev 826c,
Hi,
We have a bug report [1] that the ipu3 doesn’t work.
Does ipu3 need special userspace to work?
[1] https://bugs.launchpad.net/bugs/1812114
Kai-Heng
503ad25de8 ("Bluetooth: btrtl: split the device initialization into
smaller parts")
Cc: sta...@vger.kernel.org # 4.19+
Signed-off-by: Kai-Heng Feng
---
drivers/bluetooth/btrtl.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/bluetooth/btrtl.c b/drive
on the work from Chunhao Lin .
Signed-off-by: Kai-Heng Feng
---
v4:
- Improve commit message.
- Move the empty line to where it belongs.
v3:
- Change commit message wording.
- Rename the function to rtl_hw_aspm_clkreq_enable().
v2:
- Remove module parameter.
- Remove pci_disable_link_state
This patch can make audio controller in AMD Raven Ridge gets runtime
suspended to D3, to save ~1W power when it's not in use.
Cc: Vijendar Mukunda
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/hda_intel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda
at 10:30 PM, mario.limoncie...@dell.com wrote:
-Original Message-
From: Pali Rohár [mailto:pali.ro...@gmail.com]
Sent: Friday, April 20, 2018 2:29 AM
To: Kai-Heng Feng
Cc: mj...@srcf.ucam.org; dvh...@infradead.org; a...@infradead.org;
Limonciello, Mario; platform-driver
://bugzilla.kernel.org/show_bug.cgi?id=199451
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200039
Signed-off-by: Kai-Heng Feng
---
drivers/bluetooth/btusb.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 572fd75fbcf6..60f2832c4ff2
Cc: Mario Limonciello
Signed-off-by: Kai-Heng Feng
---
drivers/acpi/bus.c | 38 +++---
1 file changed, 7 insertions(+), 31 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 84b4a62018eb..f61f8927d843 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/
Hi Benjamin,
It appears the Elantech SMBus support breaks some users’ touchpad.
Please have a look at [1] [2], thanks!
[1] https://bugs.launchpad.net/bugs/1803600
[2] https://bugs.archlinux.org/task/59714
Kai-Heng
feedbacks from the users:
L480:
cat /sys/bus/serio/devices/serio1/firmware_id
PNP: LEN2036 PNP0f13
P52:
"cat /sys/bus/serio/devices/serio1/firmware_id":
PNP: LEN2132 PNP0f13
So looks like it’s different to LEN2131.
Kai-Heng
>
> Cheers,
> Benjamin
>
> On T
It's similar to other AMD audio devices, it also supports D3, which can
save some power drain.
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/hda_intel.c | 4
1 file changed, 4 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index d8eb2b5f51ae
Cirque Touchpad/Pointstick combo is similar to Alps devices, it requires
MT_CLS_WIN_8_DUAL to expose its pointstick as a mouse.
Signed-off-by: Kai-Heng Feng
---
drivers/hid/hid-ids.h| 3 +++
drivers/hid/hid-multitouch.c | 6 ++
2 files changed, 9 insertions(+)
diff --git a/drivers
resumed and received
an ON command.
- In the shutdown callback, it receives another SLEEP command.
I failed to find a reliable interval between ON/SLEEP commands that can
make it work, so let's simply disable runtime PM for the device.
Signed-off-by: Kai-Heng Feng
---
drivers/hid/hid-ids.h
> On Dec 13, 2018, at 08:35, Pkshih wrote:
>
> On Wed, 2018-12-12 at 13:13 +0800, Kai-Heng Feng wrote:
>> Once BSS STA mode gets started, it can be scanned by other clients but
>> cannot entablish a connection.
> ^^^ typo: establish
>>
>>
> On Dec 13, 2018, at 15:39, Pkshih wrote:
>
> On Thu, 2018-12-13 at 13:36 +0800, Kai Heng Feng wrote:
>>> On Dec 13, 2018, at 08:35, Pkshih wrote:
>>>
>>> On Wed, 2018-12-12 at 13:13 +0800, Kai-Heng Feng wrote:
>>>> Once BSS STA mode
to high after I2C host has done reading its data.
Since the host receives all useful data, let's ignore the input report
when there's no data.
Signed-off-by: Kai-Heng Feng
---
drivers/hid/i2c-hid/i2c-hid-core.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/hid/i2c-hid/i2c
>
> Signed-off-by: Elie Morisse
Re-test v5 on Dell Latitude 5495, works good.
Tested-by: Kai-Heng Feng
> ---
> Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html)
> -> Add fix for IOMMU
> -> Add depedency of ACPI
> -> Add locks to avoid the
e1000e always use suspend callback to set correct WoL during system
suspend.
Signed-off-by: Kai-Heng Feng
---
drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
b/drivers/net/ethernet/intel/e1000e/netdev.c
always use suspend callback to set correct WoL during system
suspend.
Signed-off-by: Kai-Heng Feng
---
drivers/net/ethernet/intel/igb/igb_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/drivers/net/ethernet/intel/igb/igb_main.c
index
mode
start to work.
Signed-off-by: Kai-Heng Feng
---
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c
b/drivers/net/wireless/realtek/rtlwifi/core.c
index 4bf7967590ca..11d27a5cc576 100644
event
0x3f.
Signed-off-by: Kai-Heng Feng
---
drivers/platform/x86/dell-wmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 16c7f3d9a335..c3166ba73e9a 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers
Hi Dan,
There are two different BUG_ON() incidents get recently reported on Launchpad
[1].
The first one is BUG_ON(dev->written) in ops_run_biodrain().
The second one (comment #23) is BUG_ON(!test_bit(R5_UPTODATE, >flags)) in
handle_parity_checks5().
I am not familiar with raid 5 so I am not
Hi Ulf,
Sorry for the late reply.
at 21:14, Ulf Hansson wrote:
On 31 July 2018 at 08:17, Kai-Heng Feng
wrote:
In order to let host's parent device, rtsx_usb, to use USB remote wake
up signaling to do card detection, it needs to be suspended. Hence it's
necessary to add runtime PM support
at 21:29, Ulf Hansson wrote:
[...]
-#ifdef CONFIG_PM_SLEEP
-static int rtsx_usb_ms_suspend(struct device *dev)
+#ifdef CONFIG_PM
+static int rtsx_usb_ms_runtime_suspend(struct device *dev)
{
struct rtsx_usb_ms *host = dev_get_drvdata(dev);
struct memstick_host *msh =
To avoid the firmware loading race between Bluetooth and WiFi on Intel
8260, load firmware exclusively when IWLWIFI is enabled.
Signed-off-by: Kai-Heng Feng
---
drivers/bluetooth/btusb.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth
and iwlwifi load firmwares exclusively can avoid the issue, so
introduce a lock to use in btusb and iwlwifi.
Signed-off-by: Kai-Heng Feng
---
drivers/bluetooth/btintel.c | 14 ++
drivers/bluetooth/btintel.h | 10 ++
include/linux/intel-wifi-bt.h | 8
3 files
To avoid the firmware loading race between Bluetooth and WiFi on Intel
8260, load firmware exclusively when BT_INTEL is enabled.
Signed-off-by: Kai-Heng Feng
---
.../net/wireless/intel/iwlwifi/pcie/trans.c | 39 ++-
1 file changed, 38 insertions(+), 1 deletion(-)
diff --git
To avoid the firmware loading race between Bluetooth and WiFi on Intel
8260, load firmware exclusively when IWLWIFI is enabled.
Signed-off-by: Kai-Heng Feng
---
drivers/bluetooth/btusb.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth
and iwlwifi load firmwares exclusively can avoid the issue, so
introduce a lock to use in btusb and iwlwifi.
Signed-off-by: Kai-Heng Feng
---
drivers/bluetooth/btintel.c | 14 ++
drivers/bluetooth/btintel.h | 10 ++
include/linux/intel-wifi-bt.h | 8
3 files
> On Oct 3, 2018, at 5:10 PM, Jiri Kosina wrote:
>
> On Mon, 1 Oct 2018, Kai-Heng Feng wrote:
>
>> Raydium touchpanel (2386:4B33) sometimes does not workin desktop session
>> although it works in display manager.
>>
>> During user logging, the display
gs/1775068
Signed-off-by: Kai-Heng Feng
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 6f3c8e888c2a..69283633ae91 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch
device, then the device gets
runtime resumed and powered on.
If the trasition from display manager to desktop sesesion is fast, the
touchpanel cannot switch from powered off to powered on in short
timeframe. So add a small delay to workaround the issue.
Signed-off-by: Kai-Heng Feng
---
v2:
- Use
Hi Jiri and Benjamin,
> On Oct 5, 2018, at 12:46, Kai-Heng Feng wrote:
>
> Raydium touchpanel (2386:4B33) sometimes does not work in desktop session
> although it works in display manager.
>
> During user logging, the display manager exits, close the HID device,
> then th
> On Oct 15, 2018, at 16:04, Benjamin Tissoires
> wrote:
>
> On Fri, Oct 5, 2018 at 6:46 AM Kai-Heng Feng
> wrote:
>>
>> Raydium touchpanel (2386:4B33) sometimes does not work in desktop session
>> although it works in display manager.
>>
>> D
device, then the device gets
runtime resumed and powered on.
If the trasition from display manager to desktop sesesion is fast, the
touchpanel cannot switch from powered off to powered on in short
timeframe. So add a small delay to workaround the issue.
Signed-off-by: Kai-Heng Feng
---
drivers/hid
On Oct 1, 2018, at 3:00 PM, Benjamin Tissoires
wrote:
On Mon, Oct 1, 2018 at 5:53 AM Kai-Heng Feng
wrote:
Raydium touchpanel (2386:4B33) sometimes does not workin desktop session
although it works in display manager.
During user logging, the display manager exits, close the HID device
the same results as with the edge-triggered interrupt
patch/hack,
right?
Are you still using the edge-triggered interrupt patch, or just the new
patch Kai-Heng Feng provided.
To me it sounds like the patch Kai-Heng Feng provided at least removes
the need for the edge-triggered interrupt patch/hack
at 9:49 PM, wrote:
Hi. I did the suggested echo and, if I clearly understood, switched to
s2idle mode without deep-mode.
For tests I use 4.19.28 on Debian-like system (Parrot OS).
If the system defaults to use S2I, then it’s better to stick with it.
Lots of ODM/OEM don’t really test S3.
ing
>> packet.
>>
>> Disabling it via event mask can prevent the issue from happening.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1823029
>> Signed-off-by: Kai-Heng Feng
>> ---
>> drivers/bluetooth/btusb.c | 12
>> 1 file cha
at 17:42, Benjamin Tissoires wrote:
Hi,
On Fri, Mar 8, 2019 at 6:11 AM Kai-Heng Feng
wrote:
Commit 71f6fa90a353 ("HID: increase maximum global item tag report size
to 256") increases the max report size from 128 to 256.
We also need to update the report size in hid_fie
at 02:28, Pavel Shilovsky wrote:
вт, 7 мая 2019 г. в 09:13, Steve French via samba-technical
:
merged into cifs-2.6.git for-next
On Tue, May 7, 2019 at 10:17 AM Christoph Probst via samba-technical
wrote:
Change strcat to strncpy in the "None" case to fix a buffer overflow
when
y: Theodore Ts'o
Signed-off-by: Mario Limonciello
Signed-off-by: Kai-Heng Feng
---
drivers/nvme/host/core.c | 8 +++
drivers/nvme/host/nvme.h | 8 +++
drivers/nvme/host/pci.c | 102 +--
3 files changed, 115 insertions(+), 3 deletions(-)
diff --git a/drivers/nv
at 02:42, Pavel Shilovsky wrote:
ср, 8 мая 2019 г. в 01:23, Kai-Heng Feng :
at 02:28, Pavel Shilovsky wrote:
вт, 7 мая 2019 г. в 09:13, Steve French via samba-technical
:
merged into cifs-2.6.git for-next
On Tue, May 7, 2019 at 10:17 AM Christoph Probst via samba-technical
wrote
at 03:16, Keith Busch wrote:
On Thu, May 09, 2019 at 02:59:55AM +0800, Kai-Heng Feng wrote:
+static int nvme_do_resume_from_idle(struct pci_dev *pdev)
+{
+ struct nvme_dev *ndev = pci_get_drvdata(pdev);
+ int result;
+
+ pdev->dev_flags &= ~PCI_DEV_FLAGS_NO_D3;
+
Cc Rafael and linux-pm
at 14:12, Christoph Hellwig wrote:
On Wed, May 08, 2019 at 08:28:30PM +, mario.limoncie...@dell.com wrote:
You might think this would be adding runtime_suspend/runtime_resume
callbacks, but those also get called actually at runtime which is not
the goal here. At
at 17:07, Rafael J. Wysocki wrote:
On Thu, May 9, 2019 at 8:49 AM Kai-Heng Feng
wrote:
Cc Rafael and linux-pm
I would have been much more useful to CC the patch to linux-pm at
least from the outset.
at 14:12, Christoph Hellwig wrote:
On Wed, May 08, 2019 at 08:28:30PM +
at 17:56, Christoph Hellwig wrote:
On Thu, May 09, 2019 at 05:42:30PM +0800, Kai-Heng Feng wrote:
That would be a set of 6 new suspend and resume callbacks, mind you,
and there's quite a few of them already. And the majority of drivers
would not need to use them anyway.
I think
at 18:31, Christoph Hellwig wrote:
On Thu, May 09, 2019 at 06:28:32PM +0800, Kai-Heng Feng wrote:
Based on my testing if queues (IRQ) are not disabled, NVMe controller
won’t be quiesced.
Symptoms can be high power drain or system freeze.
I can check with vendors whether this also necessary
at 06:19, wrote:
-Original Message-
From: Keith Busch
Sent: Thursday, May 9, 2019 4:54 PM
To: Limonciello, Mario
Cc: kai.heng.f...@canonical.com; h...@lst.de; ax...@fb.com;
s...@grimberg.me; raf...@kernel.org; linux...@vger.kernel.org;
rafael.j.wyso...@intel.com;
801 - 900 of 1093 matches
Mail list logo
