Re: [PATCH 3/4] ARM: dts: qcom: msm8974-klte: add support for display

2021-01-25 Thread Konrad Dybcio
> I know how bad it is, so I understand your desire to not have to rebase > that, but I will merge things as they become ready on the list. > > So please post your change (perhaps it's posted and I'm failing to find > it in my inbox?) and I'd be happy to merge it so we get it cleaned up! > >

[PATCH] drm/msm/dsi: Correct io_start for MSM8994 (20nm PHY)

2021-01-18 Thread Konrad Dybcio
The previous registers were *almost* correct, but instead of PHYs, they were pointing at DSI PLLs, resulting in the PHY id autodetection failing miserably. Fixes: dcefc117cc19 ("drm/msm/dsi: Add support for msm8x94") Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_

[PATCH] clk: qcom: smd: Add missing RPM clocks for msm8992/4

2021-01-18 Thread Konrad Dybcio
This was omitted when first adding the clocks for these SoCs. Fixes: b4297844995 ("clk: qcom: smd: Add support for MSM8992/4 rpm clocks") Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/clk-smd-rpm.c | 16 include/dt-bindings/clock/qcom,rpmcc.h | 2 ++ inc

[PATCH 1/2] drivers: soc: qcom: rpmpd: Add msm8994 RPM Power Domains

2021-01-18 Thread Konrad Dybcio
though. Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + drivers/soc/qcom/rpmpd.c | 28 +++ include/dt-bindings/power/qcom-rpmpd.h| 9 ++ 3 files changed, 38 insertions(+) diff --git a/Documentation/devicetree

[PATCH 2/2] arm64: dts: qcom: msm8992/4: Add RPM Power Domains

2021-01-18 Thread Konrad Dybcio
Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8992.dtsi | 30 +++ arch/arm64/boot/dts/qcom/msm8994.dtsi | 30 +++ 2 files changed, 60 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom

[PATCH 07/11] arm64: dts: qcom: msm8994-kitakami: Add uSD card support

2021-01-18 Thread Konrad Dybcio
Assign regulators and enable regulator-set-load on VMMC so as to provide sufficient power. Signed-off-by: Konrad Dybcio --- .../boot/dts/qcom/msm8994-sony-xperia-kitakami.dtsi| 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8994-sony-xperia

[PATCH 02/11] arm64: dts: qcom: msm8992-bullhead: Update regulator config

2021-01-18 Thread Konrad Dybcio
* Include pm(i)8994 dtsi * Add PMI8994 RPM regulators * Add comments concerning "missing" regulators Signed-off-by: Konrad Dybcio --- .../dts/qcom/msm8992-bullhead-rev-101.dts | 39 +-- 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/arch/arm64/boo

[PATCH 09/11] arm64: dts: qcom: msm8994: Fix BLSP2_UART2 node

2021-01-18 Thread Konrad Dybcio
Fix up the node to make the peripheral functional. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8994.dtsi | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi index

[PATCH 03/11] arm64: dts: qcom: msm8992-libra: Update regulator config

2021-01-18 Thread Konrad Dybcio
* Add PMI8994 RPM regulators * Add missing PM8994 LVSes * Add comments concerning "missing" regulators Signed-off-by: Konrad Dybcio --- .../boot/dts/qcom/msm8992-xiaomi-libra.dts| 53 +++ 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/arch/arm6

[PATCH 04/11] arm64: dts: qcom: msm8992/4: Rename vreg_vph_pwr to vph_pwr

2021-01-18 Thread Konrad Dybcio
Rename the fixed regulator to follow the common naming scheme Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8992.dtsi | 5 ++--- arch/arm64/boot/dts/qcom/msm8994.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b

[PATCH 10/11] arm64: dts: qcom: msm8994/8994-kitakami: Fix up the memory map

2021-01-18 Thread Konrad Dybcio
The previous map was wrong. Fix it up. Signed-off-by: Konrad Dybcio --- .../qcom/msm8994-sony-xperia-kitakami.dtsi| 45 +++ arch/arm64/boot/dts/qcom/msm8994.dtsi | 45 ++- 2 files changed, 60 insertions(+), 30 deletions(-) diff --git a/arch/arm64

[PATCH 06/11] arm64: dts: qcom: msm8994-kitakami: Add Synaptics RMI touchscreen

2021-01-18 Thread Konrad Dybcio
All Kitakami phones use Synaptics RMI4 touchscreens attached to the same i2c bus. Configure and enable it. Signed-off-by: Konrad Dybcio --- .../msm8994-sony-xperia-kitakami-karin.dts| 2 + .../qcom/msm8994-sony-xperia-kitakami.dtsi| 45 ++- 2 files changed, 46

[PATCH 11/11] arm64: dts: qcom: msm8994-kitakami: Add missing email in the copyright

2021-01-18 Thread Konrad Dybcio
I forgot to do this the first time around. Signed-off-by: Konrad Dybcio --- .../arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dts | 2 +- arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64

[PATCH 08/11] arm64: dts: qcom: msm8994-kitakami: Add VDD_GFX regulator

2021-01-18 Thread Konrad Dybcio
This is required for the GPU to function. Signed-off-by: Konrad Dybcio --- .../dts/qcom/msm8994-sony-xperia-kitakami.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami.dtsi b/arch/arm64/boot/dts/qcom/msm8994-sony

[PATCH 01/11] arm64: dts: qcom: Add support for remaining Sony Kitakami boards

2021-01-18 Thread Konrad Dybcio
. While at it, update comments describing hardware used: SMB charger seems to not be used after all, PMI8994 charger is in use instead. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/Makefile | 5 + ...q8094-sony-xperia-kitakami-karin_windy.dts | 20

[PATCH 05/11] arm64: dts: qcom: msm/apq8994-kitakami: Add regulator config

2021-01-18 Thread Konrad Dybcio
Add regulator config for all Kitakami devices, commonizing where applicable. Signed-off-by: Konrad Dybcio --- ...q8094-sony-xperia-kitakami-karin_windy.dts | 3 + .../qcom/msm8994-sony-xperia-kitakami-ivy.dts | 13 + .../msm8994-sony-xperia-kitakami-karin.dts| 22 ++ .../msm8994-sony

Re: [PATCH v3 1/2] arm64: dts: sdm845: add oneplus6/6t devices

2021-01-14 Thread Konrad Dybcio
> The device definitely doesn't support USB3, although downstream does > leave the USB3 phy enabled the hardware doesn't support it. So it made > sense to disable it here. Sure. > OnePlus' bootloader doesn't seem to care about these values so I left > them out for simplicity. Sounds

Re: [PATCH v3 1/2] arm64: dts: sdm845: add oneplus6/6t devices

2021-01-14 Thread Konrad Dybcio
Hi! > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-enchilada.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-fajita.dtb >

Re: [PATCH 1/4] phy: qcom-qmp: Add SM8350 USB QMP PHYs

2021-01-15 Thread Konrad Dybcio
Hi, I might be wrong but it looks as if you forgot to add a compatible for the "sm8350_usb3_uniphy_cfg" configuration. Konrad

Re: [PATCH v4 1/2] arm64: dts: sdm845: add oneplus6/6t devices

2021-01-15 Thread Konrad Dybcio
regulator-initial-mode = ; > + }; > + vdda_mipi_dsi0_1p2: Add a newline between the "};" and "vdda_mipi_dsi0_1p2:" to keep it consistent. After that, you can add: Reviewed-by: Konrad Dybcio

[PATCH] soc: qcom: socinfo: Add MDM9607 IDs

2021-01-15 Thread Konrad Dybcio
Along with IDs for its derivatives. Signed-off-by: Konrad Dybcio --- drivers/soc/qcom/socinfo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c index d21530d24253..f8829e1e344d 100644 --- a/drivers/soc/qcom/socinfo.c +++ b

[PATCH] pinctrl: qcom-pmic-gpio: Add support for pm8019

2021-01-15 Thread Konrad Dybcio
PM8019 provides 6 GPIOs. Add a compatible to support that. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 1 + drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + 2 files changed, 2 insertions(+) diff --git a/Documentation

[PATCH] pinctrl: qcom: spmi-mpp: Add PM8019 compatible

2021-01-15 Thread Konrad Dybcio
PM8019 provides 6 MPPs. Add a compatible to support them. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 1 + drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/Documentation

Re: [PATCH 2/3] arm64: dts: qcom: msm8916: Add blsp_i2c3

2021-01-24 Thread Konrad Dybcio
efault>; > + pinctrl-1 = <_sleep>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > blsp_spi3: spi@78b7000 { > compatible = "qcom,spi-qup-v2.2.1"; > reg = <0x078b7000 0x500>; > Reviewed-by: Konrad Dybcio Things to consider for the future: * DMA on I2C * Merging in the -pins.dtsi to 8916.dtsi? Konrad

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add gpu support

2021-01-24 Thread Konrad Dybcio
Hi, > + gpu_opp_table: opp_table { > + status = "disabled"; Is there a good reason to disable this? > + opp-8 { > + opp-hz = /bits/ 64 <8>; > + }; No. A330 can't go lightspeed

Re: [PATCH 1/3] arm64: dts: qcom: Add device tree for BQ Aquaris X5 (Longcheer L8910)

2021-01-24 Thread Konrad Dybcio
The sorting on smd_rpm_regulators & msmgpio seems off.. unless it's the new thing to put it at the end? Also, did you forget the copyright header or is that on purpose? Otherwise, LGTM Konrad

Re: [PATCH 3/4] ARM: dts: qcom: msm8974-klte: add support for display

2021-01-24 Thread Konrad Dybcio
> All msm8974 dts(i) files use this style. Deviating from it for this doesn't > make sense. And yes msm8974 should probably be converted to the newer label > style (as was done with msm8916 a while ago). I have a >3k lines commit fixing that. Adding more code that strays from the new style

Re: [PATCH 2/4] ARM: dts: qcom: msm8974-klte: add support for GPU

2021-01-24 Thread Konrad Dybcio
> + opp_table { > + status = "ok"; > + }; > + > + adreno@fdb0 { > + status = "ok"; > + }; > }; Could you use instead? Reminds me that I should perhaps finally submit my 8974 cleanups one day.. Konrad

Re: [PATCH 3/4] ARM: dts: qcom: msm8974-klte: add support for display

2021-01-24 Thread Konrad Dybcio
> + mdss@fd90 { > + status = "ok"; > + > + mdp@fd90 { > + status = "ok"; > + }; > + > + dsi@fd922800 { > + status = "ok"; > + > + vdda-supply = <_l2>; > +

Re: [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8910: Add imu/magnetometer

2021-01-24 Thread Konrad Dybcio
> +_i2c3 { > + status = "okay"; > + > + imu@68 { > + compatible = "bosch,bmi160"; > + reg = <0x68>; > + > + vdd-supply = <_l17>; > + vddio-supply = <_l6>; > + > + mount-matrix = "0", "1", "0", > +

Re: [PATCH 4/4] ARM: dts: qcom: msm8974-klte: Mark essential regulators

2021-01-24 Thread Konrad Dybcio
regulator-max-microvolt = > <180>; > + regulator-always-on; > }; > > pma8084_l13: l13 { Reviewed-by: Konrad Dybcio Konrad

[PATCH] clk: qcom: gcc-msm8994: Add missing clocks, resets and GDSCs

2020-10-05 Thread Konrad Dybcio
This change adds GDSCs, resets and most of the missing clocks to the msm8994 GCC driver. The remaining ones are of local_vote_clk and gate_clk type, which are not yet supported upstream. Also reorder them to match the original downstream driver. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom

[PATCH 10/11] arm64: dts: qcom: msm8992: Add USB support

2020-10-05 Thread Konrad Dybcio
This is a very basic dwc3 configuration (no PHYs yet), but it works. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8992.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom/msm8992

[PATCH 09/11] arm64: dts: qcom: msm8994: Add USB support

2020-10-05 Thread Konrad Dybcio
This is a very basic dwc3 configuration (no PHYs yet), but it works. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8994.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994

[PATCH 07/11] arm64: dts: qcom: msm8992: Add BLSP_I2C1 support

2020-10-05 Thread Konrad Dybcio
This will be required to support touchscreen on Lumia devices. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8992.dtsi | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom/msm8992.dtsi

[PATCH 00/11] pm8994 / msm8992/4 DT updates

2020-10-05 Thread Konrad Dybcio
And converts spmi-gpio on pm8994 to use gpio-ranges. [1] https://patchwork.kernel.org/patch/11816733/ Konrad Dybcio (11): arm64: dts: qcom: pm8994: Add VADC node arm64: dts: qcom: pm8994: Add temperature alarm node arm64: dts: qcom: pm8994: Add thermal-zones for temp alarm arm64: dts: qcom

[PATCH 08/11] arm64: dts: qcom: talkman: Add Synaptics RMI4 touchscreen

2020-10-05 Thread Konrad Dybcio
This adds touchscreen capabilities to the Lumia 950. Signed-off-by: Konrad Dybcio --- .../dts/qcom/msm8992-msft-lumia-talkman.dts | 28 +++ 1 file changed, 28 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8992-msft-lumia-talkman.dts b/arch/arm64/boot/dts/qcom

[PATCH 02/11] arm64: dts: qcom: pm8994: Add temperature alarm node

2020-10-05 Thread Konrad Dybcio
Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/pm8994.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi index ea2a3d53f859..7825208b0d8b 100644 --- a/arch/arm64/boot/dts/qcom/pm8994.dtsi +++ b

[PATCH 11/11] arm64: dts: qcom: Add support for Microsoft Lumia 950 XL (Cityman)

2020-10-05 Thread Konrad Dybcio
EFIFB * SDHCI * I2C * UART * PSCI core bringup Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/Makefile | 1 + .../dts/qcom/msm8994-msft-lumia-cityman.dts | 73 +++ 2 files changed, 74 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8994-msft

[PATCH 04/11] arm64: dts: qcom: pm8994: Fix up spmi-gpio node

2020-10-05 Thread Konrad Dybcio
Add a common compatible and switch to gpio-ranges. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/pm8994.dtsi | 27 --- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi

[PATCH 01/11] arm64: dts: qcom: pm8994: Add VADC node

2020-10-05 Thread Konrad Dybcio
Add VADC note and some of its channels to allow for voltage/temperature reading. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/pm8994.dtsi | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch

[PATCH 05/11] arm64: dts: qcom: msm8992: Add support for SDHCI2

2020-10-05 Thread Konrad Dybcio
This will let us use SD cards on our devices. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8992.dtsi | 59 +++ 1 file changed, 59 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom/msm8992.dtsi index 8626b3a50eda

[PATCH 06/11] arm64: dts: qcom: msm8994: Add SDHCI2 node

2020-10-05 Thread Konrad Dybcio
Add SDHCI2 to enable use of uSD cards on msm8994. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8994.dtsi | 59 +++ 1 file changed, 59 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi index

[PATCH 03/11] arm64: dts: qcom: pm8994: Add thermal-zones for temp alarm

2020-10-05 Thread Konrad Dybcio
This will shut down the platform in case the PMIC overheats. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/pm8994.dtsi | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi index

[PATCH] arm64: dts: Add support for remaining Sony Kitakami boards

2020-10-05 Thread Konrad Dybcio
This patch adds support for the following Xperias: * Z3+ [aka Z4 in some regions] (Ivy) * Z4 Tablet (Karin) * Z5 Compact (Suzuran) * Z5 Premium (Satsuki) These devices are very similar in terms of hardware, with the main differences being display and touch panels. Signed-off-by: Konrad Dybcio

Re: [PATCH 11/11] arm64: dts: qcom: Add support for Microsoft Lumia 950 XL (Cityman)

2020-10-05 Thread Konrad Dybcio
>+dtb-$(CONFIG_ARCH_QCOM)+= msm8994-msft-lumia-cityman.dts I made a typo and instead of .dtb I wrote .dts here. Could that be fixed when applying so that I don't have to spam you guys with 11 more mails? Konrad

Re: [PATCH 03/11] arm64: dts: qcom: pm8994: Add thermal-zones for temp alarm

2020-10-05 Thread Konrad Dybcio
>Don't you want to add a 'hot' trip point, so userspace can get the >notification and have an opportunity to do some action like unplugging >some CPU before a wild shutdown happens ? PM8998 doesn't do that and so I followed. Anyway, msm8992/4 will never have all CPUs online at once, unless it's

Re: [PATCH 03/11] arm64: dts: qcom: pm8994: Add thermal-zones for temp alarm

2020-10-05 Thread Konrad Dybcio
>What do you mean by they are not "online at once" ? msm8992/4 are infamous for their thermal issues. Manufacturers have been known for straight up disabling some cores or tuning the kernel in such a way that some cores get disabled due to the thermal constraints. Konrad

Re: [PATCH 06/11] arm64: dts: qcom: msm8994: Add SDHCI2 node

2020-10-06 Thread Konrad Dybcio
Please note that the bot is correct (this patch does not build if applied on its own), but I mentioned its dependence on a clk patch in the cover letter. Konrad

Re: [PATCH 05/11] arm64: dts: qcom: msm8992: Add support for SDHCI2

2020-10-06 Thread Konrad Dybcio
Please note that the bot is correct (this patch does not build if applied on its own), but I mentioned its dependence on a clk patch in the cover letter. Konrad

Re: [PATCH v2 00/10] msm8992/4 updates

2020-08-04 Thread Konrad Dybcio
Bumping in case it was overlooked, hope to get this in the 5.9 merge window :) Konrad

Re: [GIT PULL 0/5] ARM: SoC: changes for v5.9

2020-08-05 Thread Konrad Dybcio
Thanks for all the kind words, I really appreciate it. >My impression is that the newly added phones are still fairly rudimentary, >but some others that were added in the past releases have gotten >further. I don't know any details, but I've added Konrad to Cc, he can >comment on his work.

Re: [GIT PULL 0/5] ARM: SoC: changes for v5.9

2020-08-05 Thread Konrad Dybcio
> I did not know how popular PinePhone is. Does it currently have useful > battery life? It basically sells out in a few days after a new batch is up :D You might want to join some pine64 irc/matrix/telegram channels. Currently, as far as I'm aware (I haven't got one), it can survive a full day

Re: [GIT PULL 0/5] ARM: SoC: changes for v5.9

2020-08-05 Thread Konrad Dybcio
>Regarding msm8992/4, there is a need for the 20nm DSI PHY driver. Well... Of course I meant DSI PLL there. It's so easy to mistake three-letter acronyms.. Konrad

Re: [PATCH] phy: qcom-qusb2: Add support for SDM630/660

2020-09-29 Thread Konrad Dybcio
>You should just pull this from the driver data. I reused 8996's phy_cfg so as to change one line and not repeat dozens for what's essentially the same thing, so I don't think it's the better option.. Konrad

Re: [PATCH v4 3/4] arm64: dts: qcom: msm8996: Add mpp and lpg blocks

2020-10-01 Thread Konrad Dybcio
Hi, Just a nitpick: the title says "qcom: msm8996", whereas the file being changed is pm(i)8994.dtsi. This also applies to most msm8992/94 platforms, as the PMIC was used there too. Konrad

Re: [PATCH 1/1] iommu/arm-smmu: Implement qcom,skip-init

2020-08-03 Thread Konrad Dybcio
> Sounds like things are progressing nicely for a while there, presumably > until the next time the display is being refreshed. > > Would you be willing to try out the following work in progress: > https://lore.kernel.org/linux-arm-msm/20200717001619.325317-1-bjorn.anders...@linaro.org/ I sure

Re: [PATCH v5] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-21 Thread Konrad Dybcio
Hi First of all, sorry if anybody sees this twice. I've been messing with Thunderbird lately. > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm845-beryllium.dtb [B]eryllium should come before

Re: [RESEND][PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-09-11 Thread Konrad Dybcio
I'm not a maintainer, but I reviewed this earlier, so I guess it's only appropriate: Reviewed-by: Konrad Dybcio Looking forward to future patches for this device! :D Konrad

[PATCH] arm64: dts: qcom: msm8996: Add missing device_type under pcie[01]

2020-12-24 Thread Konrad Dybcio
Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index fd6ae5464dea..e7eb2c9f37af 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b

Re: [PATCH 1/7] clk: qcom: clk-alpha-pll: Add support for Stromer PLLs

2020-12-25 Thread Konrad Dybcio
Hi, are you going to resubmit this patch? Looks like MDM9607 uses Stromer PLL for its CPU clocks and could benefit from it. Konrad

[PATCH] clk: qcom: mmcc-msm8974: Fix mmss_s0_axi clock

2020-12-26 Thread Konrad Dybcio
(MMCC)") Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/mmcc-msm8974.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c index 015426262d08..6220b62ece1e 100644 --- a/drivers/clk/qcom/mmcc-msm8974.c +++ b/d

[PATCH RFC] remoteproc: qcom: wcnss: Adjust voltage requirements for Pronto v2

2020-12-26 Thread Konrad Dybcio
This is required for MSM8974 devices that cannot afford to push the regulators further. Signed-off-by: Konrad Dybcio --- drivers/remoteproc/qcom_wcnss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c index

Re: [PATCH 4/5] clk: qcom: Add A7 PLL support

2021-01-04 Thread Konrad Dybcio
Hi, could you explicitly state in the probe function (or just in the driver in general, as there's not much more?) and the config structs that the target SoC is X55? A few more SoCs (MDM9607, MSM8x26 and some others) also use what's known as "A7PLL" downstream, but all of them have a separate

[PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-04 Thread Konrad Dybcio
Using this code on A5xx (and probably older too) causes a smmu bug. Fixes: 474dadb8b0d5 ("drm/msm/a6xx: Add support for using system cache(LLC)") Signed-off-by: Konrad Dybcio Tested-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 21

Re: [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-02 Thread Konrad Dybcio
Kind reminder that MSM8974, 8994, 8992 and friends are held back by the lack of IOMMU support upstream. There has been an attempt back in 2014(!) [1], but it was either overlooked or forgotten about ever since. I'd be more than happy to see someone look into this, as I have some other bits

Re: [PATCH 4/4] arm64: cpu_errata: Apply Erratum 845719 to KRYO2XX Silver

2020-11-09 Thread Konrad Dybcio
> From what I see from the docs, this is the only version used > in MSM8998(silver cores are based on Cortex A53) and it maps > to r0p4. @Konrad, can you include (rap4 => r0p4) in comment. Hi, Thanks for looking into it. Could you perhaps check if it's also the case on sdm630/636/660? Konrad

Re: [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-09-06 Thread Konrad Dybcio
> Thank you for the pointer. I dug around the vph_pwr fixed-regulator > node used by fellow sdm845 devices. I assume it is safe to copy it > from sdm845-mtp but I couldn't verify it in the downstream > device-tree, so I'm a bit hesitant. My main concern is that I don't > want to burn down my only

Re: [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-31 Thread Konrad Dybcio
> Hi Konrad, > > I couldn't find answer to your question around missing > (regulatorname)-supply properties. Need help in figuring out that > part. When the phone boots up and RPM(H) kicks in, you should see regulators probing like "s1 supplied by foo". Without the *-supply stuff, you will likely

Re: [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-08-31 Thread Konrad Dybcio
>This happens here Forgot this part [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/regulator/core.c?h=v5.9-rc3#n398

[no subject]

2020-08-06 Thread Konrad Dybcio
Subject: Re: [PATCH v4] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium) >// This removed_region is needed to boot the device > // TODO: Find out the user of this reserved memory > removed_region: memory@88f0 { This region seems to belong to the Trust

[PATCH 1/2] [-next] mmc: host: msm: Add optional full power cycle property.

2020-08-14 Thread Konrad Dybcio
On some eMMCs (at least the ones used on Sony msm8994 boards) enabling full power cycle is required to prevent permanent damage to the flash memory, whereas on others it results in better performance. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4

[PATCH 2/2] [-next] arm64: dts: qcom: kitakami: Enable qcom,full-pwr-cycle on SDHCI1

2020-08-14 Thread Konrad Dybcio
This is required to prevent permanent eMMC damage. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami.dtsi b/arch/arm64/boot/dts/qcom/msm8994

Re: [PATCH v2 00/10] msm8992/4 updates

2020-08-14 Thread Konrad Dybcio
Bumping again, merge window closes soon.. Konrad

[PATCH] arm64: dts: qcom: kitakami: Temporarily disable SDHCI1

2020-08-14 Thread Konrad Dybcio
There is an issue with Kitakami eMMCs dying when a quirk isn't addressed. Until that happens, disable it. Signed-off-by: Konrad Dybcio --- This supersides my previous "mmc: host: msm: Add optional full power cycle property." series in which I incorrectly addressed the issue N

Re: [PATCH 1/2] [-next] mmc: host: msm: Add optional full power cycle property.

2020-08-14 Thread Konrad Dybcio
As I mentioned in the next email, please ignore this patch. The whole idea is incorrect and does not solve the problem. Konrad

[PATCH 0/4] Add KRYO2XX Errata / mitigations data

2020-11-04 Thread Konrad Dybcio
This series adds Spectre mitigations and errata data for Qualcomm KRYO2XX Gold (big) and Silver (LITTLE) series of CPU cores, used for example in MSM8998 and SDM660-series SoCs. Konrad Dybcio (4): arm64: Add MIDR value for KRYO2XX gold/silver CPU cores arm64: kpti: Add KRYO2XX gold/silver CPU

[PATCH 1/4] arm64: Add MIDR value for KRYO2XX gold/silver CPU cores

2020-11-04 Thread Konrad Dybcio
Add MIDR value for KRYO2XX gold (big) and silver (LITTLE) CPU cores which are used in Qualcomm Technologies, Inc. SoCs. This will be used to identify and apply errata which are applicable for these CPU cores. Signed-off-by: Konrad Dybcio --- arch/arm64/include/asm/cputype.h | 4 1 file

[PATCH 4/4] arm64: cpu_errata: Apply Erratum 845719 to KRYO2XX Silver

2020-11-04 Thread Konrad Dybcio
QCOM KRYO2XX Silver cores are Cortex-A53 based and are susceptible to the 845719 erratum. Add them to the lookup list to apply the erratum. Signed-off-by: Konrad Dybcio --- arch/arm64/kernel/cpu_errata.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/kernel/cpu_errata.c b/arch

[PATCH 2/4] arm64: kpti: Add KRYO2XX gold/silver CPU cores to kpti safelist

2020-11-04 Thread Konrad Dybcio
QCOM KRYO2XX gold (big) silver (LITTLE) CPU cores are based on Cortex-A73 and Cortex-A53 respectively and are meltdown safe, hence add them to kpti_safe_list[]. Signed-off-by: Konrad Dybcio --- arch/arm64/kernel/cpufeature.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64

[PATCH 3/4] arm64: proton-pack: Add KRYO2XX silver CPUs to spectre-v2 safe-list

2020-11-04 Thread Konrad Dybcio
KRYO2XX silver (LITTLE) CPUs are based on Cortex-A53 and they are not affected by spectre-v2. Signed-off-by: Konrad Dybcio --- arch/arm64/kernel/proton-pack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/proton-pack.c b/arch/arm64/kernel/proton-pack.c index c18eb7d41274

Re: [PATCH 00/11] pm8994 / msm8992/4 DT updates

2020-11-05 Thread Konrad Dybcio
Hi, bumping this series as it's been quite a while and the required clk patch has since been merged. Konrad Dybcio

Re: [PATCH 4/4] arm64: cpu_errata: Apply Erratum 845719 to KRYO2XX Silver

2020-11-05 Thread Konrad Dybcio
> Is this the only affected version? If this is actually an A53, how do the > revisions map between Kryo and Cortex cores? Hi, sadly, I do not have access to such information. Only this specific revision has been marked as affected in the BSP kernel. Konrad

[PATCH] clk: qcom: gcc-sdm660: Fix wrong parent_map

2020-09-22 Thread Konrad Dybcio
This was likely overlooked while porting the driver upstream. Reported-by: Pavel Dubrova Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sdm660.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/gcc-sdm660.c index

Re: [PATCH -next] clk: qcom: Remove set but not used variable

2020-09-22 Thread Konrad Dybcio
Hi, This is not the correct solution. I sent a proper fix here [1]. Please do not modify critical platform drivers without having tested them on real hardware (I don't see any Tested-by's?). Instead, file a bug report so that more people can take a look at this. If this got merged, it would

Re: [PATCH] clk: qcom: gcc-sdm660: Fix wrong parent_map

2020-09-22 Thread Konrad Dybcio
Sheesh, I cannot stop forgetting these... Fixes: f2a76a2955c0 (clk: qcom: Add Global Clock controller (GCC) driver for SDM660) Konrad

[PATCH] drm/msm/disp/mdp5: mdp5_cfg: Fix msm8974v2 max_clk

2021-02-03 Thread Konrad Dybcio
The maximum mdp clock rate on msm8974v2 is 320MHz. Fix it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c index

Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

2021-02-04 Thread Konrad Dybcio
Hi! >vreg_l14a_1p88: ldo14 { >+ regulator-min-microvolt = <180>; >+ regulator-max-microvolt = <180>; Should probably be renamed to vreg_l14a_1p8 then. >+ ports { >+ port@1 { >+ endpoint { >+

[PATCH] thermal: qcom: tsens-v0_1: Add support for MDM9607

2021-01-27 Thread Konrad Dybcio
MDM9607 TSENS IP is very similar to the one of MSM8916, with minor adjustments to various tuning values. Signed-off-by: Konrad Dybcio --- .../bindings/thermal/qcom-tsens.yaml | 2 + drivers/thermal/qcom/tsens-v0_1.c | 100 +- drivers/thermal/qcom/tsens.c

[PATCH v2] thermal: qcom: tsens-v0_1: Add support for MDM9607

2021-01-27 Thread Konrad Dybcio
MDM9607 TSENS IP is very similar to the one of MSM8916, with minor adjustments to various tuning values. Signed-off-by: Konrad Dybcio --- Changes since v1: - Move the defines so as not to cut into the middle of 8974 regs .../bindings/thermal/qcom-tsens.yaml | 2 + drivers/thermal

Re: [PATCH] thermal: qcom: tsens-v0_1: Add support for MDM9607

2021-01-27 Thread Konrad Dybcio
> Afaict, there's no need to initialize base0 and base1, they are both > assigned to before used. > > Also, they are temporary variables within each case (even with the > fallthrough), so you should only need a single "base". > Right. Fixed, will send in a v3 (I sent a v2 shortly after this one

Re: [PATCH v2 4/4] arm64: dts: qcom: msm8916-alcatel-idol347: Add framebuffer support

2021-01-30 Thread Konrad Dybcio
On 30.01.2021 11:57, Vincent Knecht wrote: > Add simple-framebuffer support and related reserved-memory block. > > Signed-off-by: Vincent Knecht > --- > .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git

Re: [PATCH v2 3/4] arm64: dts: qcom: Disable MDSS by default for 8916/8016 devices

2021-01-30 Thread Konrad Dybcio
rm64/boot/dts/qcom/msm8916.dtsi > index 402e891a84ab..8f9a651d3827 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -913,6 +913,7 @@ tcsr: syscon@1937000 { > }; > > mdss: mdss@1a0 { >

Re: [PATCH v2 00/11] Clock fixes for MSM8998 GCC, MMCC, GPUCC

2021-01-30 Thread Konrad Dybcio
On 14.01.2021 23:10, AngeloGioacchino Del Regno wrote: > This patch series fixes some issues with the MSM8998 clocks and, in > particular, brings a very important fix to the GCC PLLs. > > These fixes are enhancing this SoC's stability and also makes it > possible to eventually enable the Adreno

Re: [PATCH v2 2/4] arm64: dts: qcom: Add device tree for Alcatel Idol 3 (4.7")

2021-01-30 Thread Konrad Dybcio
icrovolt = <330>; > + }; > + > + l15 { > + regulator-min-microvolt = <180>; > + regulator-max-microvolt = <3300000>; > + }; > + > + l16 { > + regulator-min-microvolt = <180>; > + regulator-max-microvolt = <330>; > + }; > + > + l17 { > + regulator-min-microvolt = <285>; > + regulator-max-microvolt = <285>; > + }; > + > + l18 { > + regulator-min-microvolt = <270>; > + regulator-max-microvolt = <270>; > + }; > +}; > + > + { > + accel_int_default: accel-int-default { > + pins = "gpio31"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-disable; > + }; > + > + gpio_keys_default: gpio-keys-default { > + pins = "gpio107"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + gyro_int_default: gyro-int-default { > + pins = "gpio97", "gpio98"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-disable; > + }; > + > + mag_reset_default: mag-reset-default { > + pins = "gpio8"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-disable; > + }; > + > + proximity_int_default: proximity-int-default { > + pins = "gpio12"; > + function = "gpio"; > + > + drive-strength = <6>; > + bias-pull-up; > + }; > + > + usb_id_default: usb-id-default { > + pins = "gpio69"; > + function = "gpio"; > + > + drive-strength = <8>; > + bias-pull-up; > + }; > +}; > Reviewed-by: Konrad Dybcio Konrad

[PATCH 17/18] arm64: dts: qcom: msm8994-octagon: Add TAS2553 codec

2021-01-30 Thread Konrad Dybcio
From: Gustave Monce Lumia 950/XL feature a TAS2553 codec. Configure it using the TAS2552 driver. Signed-off-by: Gustave Monce Signed-off-by: Konrad Dybcio --- .../dts/qcom/msm8994-msft-lumia-octagon.dtsi | 20 +++ 1 file changed, 20 insertions(+) diff --git a/arch/arm64

[PATCH 04/18] arm64: dts: qcom: msm8992: Make the DT an overlay on top of 8994

2021-01-30 Thread Konrad Dybcio
This saves a good thousand lines of code, perhaps even more in the long run. Co-authored-by: Gustave Monce Signed-off-by: Konrad Dybcio --- .../dts/qcom/msm8992-bullhead-rev-101.dts | 2 +- .../boot/dts/qcom/msm8992-xiaomi-libra.dts| 39 +- arch/arm64/boot/dts/qcom/msm8992.dtsi

[PATCH 18/18] arm64: dts: qcom: msm8994-octagon: Add AD7147 and APDS9930 sensors

2021-01-30 Thread Konrad Dybcio
From: Gustave Monce Add and configure AD7147 grip sensor and APDS9930 proximity sensor. Signed-off-by: Gustave Monce Signed-off-by: Konrad Dybcio --- .../dts/qcom/msm8994-msft-lumia-octagon.dtsi | 50 +++ 1 file changed, 50 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH 15/18] arm64: dts: qcom: msm8994-octagon: Add NXP NFC node

2021-01-30 Thread Konrad Dybcio
From: Gustave Monce Octagon devices use PN544 connected over I2C. Configure it. Signed-off-by: Gustave Monce Signed-off-by: Konrad Dybcio --- .../dts/qcom/msm8994-msft-lumia-octagon.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/qcom

[PATCH 16/18] arm64: dts: qcom: msm8994-octagon: Add sensors on blsp1_i2c5

2021-01-30 Thread Konrad Dybcio
From: Gustave Monce Add AK09912 magnetometer, ZPA2326 barometer and MPU6500 accelerometer nodes. Signed-off-by: Gustave Monce Signed-off-by: Konrad Dybcio --- .../dts/qcom/msm8994-msft-lumia-octagon.dtsi | 36 +++ 1 file changed, 36 insertions(+) diff --git a/arch/arm64

  1   2   3   4   5   6   7   >