[PATCH v3] pinctrl/pinconfig: add debug interface

2013-04-18 Thread Linus Walleij
readibility - limit size of global variable pinconf_dbg_conf - remove req_type as it can easily be added later when add/delete requests support is implemented Signed-off-by: Laurent Meunier Signed-off-by: Linus Walleij --- drivers/pinctrl/pinconf.c | 232

Re: [PATCH v3] pinctrl/pinconfig: add debug interface

2013-04-19 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:52 PM, Russell King - ARM Linux wrote: > On Thu, Apr 18, 2013 at 12:35:14PM +0200, Linus Walleij wrote: >> + if (map->type != dbg->map_type) >> + continue; >> + if (!!strcmp(map->dev_name, dbg-&

[PATCH 2/4] clocksource: nomadik-mtu: support of probe

2013-04-20 Thread Linus Walleij
From: Rabin Vincent Support device tree probe of the nomadik-mtu clocksource. Signed-off-by: Rabin Vincent --- drivers/clocksource/nomadik-mtu.c | 70 --- 1 file changed, 58 insertions(+), 12 deletions(-) diff --git a/drivers/clocksource/nomadik-mtu.c b/dr

[PATCH 1/4] clocksource: nomadik-mtu: fix up clocksource/timer

2013-04-20 Thread Linus Walleij
The Nomadik clocksource driver has had a bad define making it impossible to use it for sched_clock() for a while. Fix this and also enable it for the Nomadik. Signed-off-by: Linus Walleij --- arch/arm/mach-nomadik/Kconfig | 1 + drivers/clocksource/nomadik-mtu.c | 4 ++-- 2 files changed, 3

[PATCH 4/4] ARM: nomadik: register clocksource from device tree

2013-04-20 Thread Linus Walleij
This switches the Nomadik platform to also registering its clocksource from the device tree, removing unused support code as we go along. Signed-off-by: Linus Walleij --- arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 11 --- arch/arm/mach-nomadik/Kconfig | 1 + arch/arm

[PATCH 3/4] ARM: nomadik: convert all clocks except timer to dt

2013-04-20 Thread Linus Walleij
This moves all Nomadik clocks except the one used for the timer/clocksource over to the device tree. Signed-off-by: Linus Walleij --- .../devicetree/bindings/arm/ste-nomadik.txt| 5 ++ arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 54 ++ arch/arm/mach-nomadik

Re: [PATCH 1/4] clocksource: nomadik-mtu: fix up clocksource/timer

2013-04-20 Thread Linus Walleij
ARM SoC folks: On Sat, Apr 20, 2013 at 3:08 PM, Linus Walleij wrote: > The Nomadik clocksource driver has had a bad define making it > impossible to use it for sched_clock() for a while. Fix this > and also enable it for the Nomadik. > > Signed-off-by: Linus Walleij This o

Re: [RESEND][PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5

2013-04-20 Thread Linus Walleij
(...) }; As you can see in amba_lookup() in drivers/amba/bus.c the table is traversed from the top, so for the new "3" variant this entry will match, while the next entry will match all older versions. Yours, Linus Walleij -- To unsubscribe from this list: send the line "u

Re: [PATCH] ARM: ux500: Supply a DTS file for the u8540 platform

2013-04-23 Thread Linus Walleij
On Thu, Apr 4, 2013 at 9:29 AM, Lee Jones wrote: > This is a skeleton DTS file which only enables serial. Just using > this simple file yields a terminal when booting u8540. > > Signed-off-by: Lee Jones I've queued this patch for v3.11. Yours, Linus Walleij -- To unsubscri

Re: [PATCH] ARM: ux500: Supply a DTS file for the u8540 platform

2013-04-23 Thread Linus Walleij
what happened here? It also has the side effect that patch 5/9 does not apply... By the way, since I already applied 4/9, please squash 5/9 into this patch to avoid problems. Finally, please patch arch/arm/boot/dts/Makefile in the obvious way so that the DTB gets compiled. Yours, Linus Walleij --

Re: [PATCH] ARM: ux500: Over-ride TCDM size when booting the DB8540 platform

2013-04-23 Thread Linus Walleij
vely over-ride the previous values with more accurate > ones. > > Signed-off-by: Lee Jones As mentioned this patch does not apply. Some whitespace trouble. And please squash it into the patch adding the ccu8540, 3/9. Yours, Linus Walleij -- To unsubscribe from this list: send the line "

Re: [PATCH v5 2/3] gpio: grgpio: Add device driver for GRGPIO cores

2013-04-23 Thread Linus Walleij
On Mon, Apr 15, 2013 at 2:38 PM, Andreas Larson wrote: > On 2013-04-10 20:50, Linus Walleij wrote: >>> +Required properties: >>> + >>> +- name : Should be "GAISLER_GPIO" or "01_01a" >> >> What is this? Don't we usually use a

Re: [PATCH v5 3/3] gpio: grgpio: Add irq support

2013-04-23 Thread Linus Walleij
On Mon, Apr 15, 2013 at 2:38 PM, Andreas Larson wrote: > On 2013-04-10 21:25, Linus Walleij wrote: >>> +int grgpio_irq_map(struct irq_domain *d, unsigned int virq, (...) >>> + /* Request underlying irq if not already requested */ >>> + lirq->virq

Re: pinctrl:when two device use the same pin

2013-06-13 Thread Linus Walleij
he above has to be done from process context. The reservation of the pins will be done when the state is activated, so in effect one specific pin can be used by different functions at different times on a running system. Yours, Linus Walleij -- To unsubscribe from this list: send the line "

Re: [PATCH -next v2] dmaengine: ste_dma40: fix error return code in d40_probe()

2013-06-13 Thread Linus Walleij
On Wed, Jun 12, 2013 at 11:54 AM, Vinod Koul wrote: >> Let me know how you want it, I've removed it from my >> dma40 branch for the time being. > > Have you removed, Also I see a v3 of this, do you want to ack that before I > apply Acked-by: Linus Walleij I haven&#x

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Linus Walleij
nd on the whole making the argument redundant? This is true, and the plan is surely for the core to not allow or print a big fat warning if someone does something really stupid like activate pull up and pull down at the same time (unless s/he's constructing a heater radiator or something). Curre

Re: [PATCH 00/32] ARM: ux500: Enable clocks for Device Tree

2013-06-13 Thread Linus Walleij
ve lots of time to discuss it. Why 3.12: my five pull request for ux500 stuff to ARM SoC is still outstanding, and this stuff will clash with that unless we get a common merge base. So we have to wait for ARM SoC to settle at this point. Yours, Linus Walleij -- To unsubscribe from this list: send th

Re: [RFC] Allow GPIO ranges based on pinctl pin groups

2013-06-13 Thread Linus Walleij
p > + */ > +int pinctrl_get_group_pins(struct pinctrl_dev *pctldev, > + const char *pin_group, > + unsigned const **pins, unsigned * const npins) > +{ > + const struct pinctrl_ops *pctlops = pctldev->desc->pctlops; &g

Re: [PATCH 1/3] pinctrl: exynos: Add spinlocks to irq_mask and irq_unmask

2013-06-13 Thread Linus Walleij
; Add the spinlock there. > > Signed-off-by: Doug Anderson Patch applied with Tomasz and Kukjin's ACKs. Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH 2/3] pinctrl: exynos: reorder xyz_irq_unmask() so future patch can ack

2013-06-13 Thread Linus Walleij
the result on my "devel" branch when I push it out shortly (will be sent to linux-next as well). Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Linus Walleij
s not enough. > > Signed-off-by: Luigi Semenzato > Signed-off-by: Doug Anderson I'm holding this off until Tomasz' comments are addressed. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: [PATCH v2 06/11] ARM:stixxxx: Add STiH415 SOC support

2013-06-13 Thread Linus Walleij
L2X0_AUX_CTRL_DATA_PREFETCH_SHIFT) | >> > + (0x1 << L2X0_AUX_CTRL_INSTR_PREFETCH_SHIFT) | >> > + (way_size << L2X0_AUX_CTRL_WAY_SIZE_SHIFT); >> > >> > >> > >> > #include >> > Linus Walleij would write use

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 4:35 PM, Heiko Stübner wrote: > Am Donnerstag, 13. Juni 2013, 10:11:28 schrieb Linus Walleij: >> Tisdagen den 13:e Juni 2013 klock 12:22 AM, skrev Heiko Stübner >> > The only other candidate I could find was low-power-mode which really >> > coul

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Linus Walleij
both these forms: bias-pull-up; bias-pull-up = <15>; Should be allowed. So when parsing, you first check if it exists, then if there is an argument, if there is no value supplied, just set it to 1, as that is clearly != 0... Yours, Linus Walleij -- To unsubscribe from this list: send t

Re: [PATCH v2 0/1] gpio driver for Intel Baytrail platforms

2013-06-13 Thread Linus Walleij
asking something more pinctrl-like in reality, it will be way more flexible the day that you just want to add "this one little quirk for this pin config thing", then it'll fit just fine. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v2 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Linus Walleij
lready applied parts 1 and 2, so not resending. Thanks, this v2 version applied with Tomasz ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 7:25 PM, Doug Anderson wrote: >>> +PIN CONTROLLER - SAMSUNG >>> +M: Linus Walleij >>> +M: Kukjin Kim >> >> So actually this would be: >> M: Thomas Abraham >> M: Tomasz Figa >> >> Thomas

Re: [PATCH 1/2] Add pin list based GPIO ranges

2013-06-13 Thread Linus Walleij
is patch and it seems to be useful for other purposes so I've applied it so we get some rotation on it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

2013-06-13 Thread Linus Walleij
e before applying so that others get a chance to comment on this, but I'm happy! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

[PATCH] pinctrl: move the pm state stubs

2013-06-13 Thread Linus Walleij
From: Linus Walleij The stubs for the !PINCTRL case were placed in the wrong part of the file, causing breakage in linux-next when compiling SH without pinctrl. Fix it up by moving the stubs to the right place. Signed-off-by: Linus Walleij --- include/linux/pinctrl/consumer.h | 40

Re: [PATCH] pinctrl: document the pinctrl PM states

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 9:39 PM, Stephen Warren wrote: > On 06/11/2013 01:59 PM, Linus Walleij wrote: >> From: Linus Walleij >> >> This document snippet tries to be helpful and define the pin >> PM states and helpers, and how they should be used to create >> so

Re: Re: pinctrl:when two device use the same pin

2013-06-15 Thread Linus Walleij
this? Obviously you have either NOR or NAND connected? Don't you know from the system board file or device tree which one it is? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More maj

Re: [RFC] pinctrl: generic: Add DT bindings

2013-06-15 Thread Linus Walleij
onally* be written like just: bias-pull-up; Without the parameter? I think that Heiko's implementation does this anyway. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH v2 0/1] gpio driver for Intel Baytrail platforms

2013-06-15 Thread Linus Walleij
ler after all. I know there is some BIOS or ROM very much wanting it to look simpler than it is, but it sure is a pin controller :-) Thanks, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-15 Thread Linus Walleij
On Mon, Jun 10, 2013 at 12:50 PM, Grant Likely wrote: > On Mon, Jun 10, 2013 at 8:40 AM, Linus Walleij > wrote: >> On Mon, Jun 10, 2013 at 2:49 AM, Grant Likely >> wrote: >> >>> This is an RFC patch to convert the versatile FPGA irq controller driver >>

Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-15 Thread Linus Walleij
On Sat, Jun 15, 2013 at 11:19 PM, Linus Walleij wrote: > On Mon, Jun 10, 2013 at 12:50 PM, Grant Likely > wrote: >> On Mon, Jun 10, 2013 at 8:40 AM, Linus Walleij >> wrote: >>> On Mon, Jun 10, 2013 at 2:49 AM, Grant Likely >>> wrote: >>> >&

Re: [RFC] pinctrl: generic: Add DT bindings

2013-06-15 Thread Linus Walleij
On Sun, Jun 16, 2013 at 1:35 AM, Laurent Pinchart wrote: > On Saturday 15 June 2013 22:16:13 Heiko Stübner wrote: >> Am Samstag, 15. Juni 2013, 21:56:05 schrieb Linus Walleij: >> Disable would the be either >> bias-disable; >> or >> bias-pull-up = &l

Re: [RFC] pinctrl: generic: Add DT bindings

2013-06-15 Thread Linus Walleij
On Sun, Jun 16, 2013 at 1:52 AM, Laurent Pinchart wrote: > Hi Linus, > On Sunday 16 June 2013 01:51:32 Linus Walleij wrote: >> As dicussed earlier this was designed for systems where >> you could set the pull-up resistance, like >> >> bias-pull-up = <60&g

Re: [PATCH] drivers: pinctrl: add active state to core

2013-06-16 Thread Linus Walleij
On Tue, Jun 11, 2013 at 10:16 AM, Linus Walleij wrote: > From: Linus Walleij > > In addition to the recently introduced pinctrl core > control, the PM runtime pin control for the OMAP platforms > require a fourth state in addtition to the default, idle and > sleep states alre

Re: [PATCH] pinctrl: document the pinctrl PM states

2013-06-16 Thread Linus Walleij
On Fri, Jun 14, 2013 at 5:43 PM, Stephen Warren wrote: > On 06/13/2013 02:34 PM, Linus Walleij wrote: >> On Thu, Jun 13, 2013 at 9:39 PM, Stephen Warren >> wrote: >>> On 06/11/2013 01:59 PM, Linus Walleij wrote: >>>> From: Linus Walleij >>>> &g

Re: [PATCH] Fix comment on pinctrl_gpio_range.pin_base

2013-06-16 Thread Linus Walleij
On Fri, Jun 14, 2013 at 10:24 AM, Christian Ruppert wrote: > The comment introduced with the recently added pinctrl_gpio_range.pins > element was wrong. This corrects it. > Thanks to Patrice Chotard for pointing this out. > > Signed-off-by: Christian Ruppert Patch applied

[PATCH] pinctrl: update GPIO range doc

2013-06-16 Thread Linus Walleij
From: Linus Walleij This updates the GPIO range documentation with the API changes for sparse/random/arbitrary pin-to-GPIO mappings. Cc: Christian Ruppert Signed-off-by: Linus Walleij --- Documentation/pinctrl.txt | 24 +--- 1 file changed, 21 insertions(+), 3 deletions

Re: [PATCH 1/5] pinctrl: update the documentation for some pinconfig params

2013-06-16 Thread Linus Walleij
if it is 0, > - * the pull is disabled. > + * If the argument is != 0 pull up/down is enabled. On hardware > supporting > + * this, the argument should contain the strength of the pull in Ohm. > + * If it is 0, pull is disabled. Dito. Can't we rely on PIN_CONFIG

Re: [PATCH 2/5] pinctrl: clarify some dt pinconfig options

2013-06-16 Thread Linus Walleij
r-mode option into low-power-enable and -disable. > > Update the documentation to describe the param arguments better. > > Wrong default options > Reported-by: James Hogan > > Signed-off-by: Heiko Stuebner Patch applied. Yours, Linus Walleij -- To unsubscribe from this list:

Re: [PATCH 3/5] pinctrl: handle zero found dt pinconfig properties better

2013-06-16 Thread Linus Walleij
On Fri, Jun 14, 2013 at 5:43 PM, Heiko Stübner wrote: > This adds a shortcut when no valid pinconf properties are found > in the parsed dt node, to set the values immediately and return. > > Suggested-by: Laurent Pinchart > Signed-off-by: Heiko Stuebner Patch applied. Yours

Re: [PATCH 4/5] pinctrl: dynamically alloc temp array when parsing dt pinconf options

2013-06-16 Thread Linus Walleij
t; Suggested-by: Laurent Pinchart > Signed-off-by: Heiko Stuebner Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/maj

Re: [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of pinconf options

2013-06-16 Thread Linus Walleij
pull = rockchip_get_pull(bank, pin - bank->pin_base); > + *config = (pull == param) ? 1 : 0; And then I guess you should emit PIN_CONFIG_BIAS_DISABLE here as well. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-16 Thread Linus Walleij
ould actually mean "connect the pin to VDD" and bias-pull-down = <0>; should mean "ground the pin". This makes a lot of sense from the electronics side of things, let's not create a terminology that appeals to programmers, such that "zero always me

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-16 Thread Linus Walleij
On Fri, Jun 14, 2013 at 12:02 AM, Stephen Warren wrote: > On 06/11/2013 02:28 AM, Linus Walleij wrote: >> I tried to create a refactoring patch for this but couldn't come >> up with anything apropriate along the lines above. For example >> this function: > ... >

Re: [PATCH 2/6] pinctrl: sunxi: Move the pins definitions to a separate header

2013-06-16 Thread Linus Walleij
-off-by: Maxime Ripard Patch applied. Since you will anyway have to bring the ARM SoC branch on top of the pinctrl tree, I might as well apply this to my tree. If everything else fails, you'll have a nice development base in v3.11 with this in place, right? Yours, Linus Walleij -- To unsubs

Re: [PATCH 3/6] pinctrl: sunxi: Add Allwinner A10s pins

2013-06-16 Thread Linus Walleij
On Sun, Jun 9, 2013 at 6:36 PM, Maxime Ripard wrote: > Signed-off-by: Maxime Ripard Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver

2013-06-16 Thread Linus Walleij
a native pinctrl driver (see original post) > but there was some disagreement about exposing kernel internal pin > numbering to device tree users. But that is an orthogonal issue I believe. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

[PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-16 Thread Linus Walleij
From: Linus Walleij It is counter-intuitive to have "0" mean disable in a boolean manner for electronic properties of pins such as pull-up and pull-down. Therefore, define that a pull-up/pull-down argument of 0 to such a generic option means that the pin is short-circuited to VDD or GR

Re: [PATCH 1/5] pinctrl: update the documentation for some pinconfig params

2013-06-16 Thread Linus Walleij
On Sun, Jun 16, 2013 at 12:45 PM, Heiko Stübner wrote: > Am Sonntag, 16. Juni 2013, 12:26:38 schrieb Linus Walleij: >> Can't we rely on PIN_CONFIG_BIAS_DISABLE for all this? > > you're the boss on this, I'll do whatever you say :-) Oh that's not good. As ca

Re: [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of pinconf options

2013-06-16 Thread Linus Walleij
t; > Say the pin is in the "pin-default" pull state and the query in config_get is > for "bias-disable", what would be the expected bahviour/return value in this > case? return -EINVAL; ? Hm it was some time since I designed this... Yours, Linus Walleij -- To unsubs

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-16 Thread Linus Walleij
t; hierarchy than subsystem maintainers. Well I don't really like hiearchies, as I'm basically anarchist :-P Anyway, as long as the get-mainater script output both Thomas and my name I don't really care, the only practical intent with this file is to be able to mail the right pe

Re: Linux 3.10-rc6

2013-06-16 Thread Linus Walleij
ters, and I declined a couple of >> pull requests, but let's face it, it was pretty halfhearted. Most of >> the time things were good. > > Do you really think your cursing controls how other people behave? Consider spending some time reading Documentation/ManagementStyle And you

Re: [PATCH 1/2] GPIO: Add support for dual channel in gpio-xilinx.c

2013-06-16 Thread Linus Walleij
On Fri, May 31, 2013 at 9:34 AM, Michal Simek wrote: > On 05/31/2013 09:14 AM, Linus Walleij wrote: >> It's OK, but fix the boolean member so as to just needing to >> be present: >> >> xlnx,is-dual; >> >> Rather than >> >> xlnx,is-dual = &l

Re: [PATCH 1/3] ARM: msm: Remove gpiomux-v2 and re-organize MSM_GPIOMUX configs

2013-06-16 Thread Linus Walleij
ux.h |5 --- > drivers/gpio/gpio-msm-v2.c |5 +-- > 8 files changed, 24 insertions(+), 125 deletions(-) > delete mode 100644 arch/arm/mach-msm/gpiomux-8x60.c > delete mode 100644 arch/arm/mach-msm/gpiomux-v2.c > delete mode 100644 arch/arm/mach-msm/gpiomux-v2

Re: [PATCH v2 1/6] GPIO: xilinx: Simplify driver probe function

2013-06-16 Thread Linus Walleij
ch in this series Patch applied. Nice cleanup! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 2/6] GPIO: xilinx: Add support for dual channel

2013-06-16 Thread Linus Walleij
On Mon, Jun 3, 2013 at 2:31 PM, Michal Simek wrote: > Supporting the second channel in the driver. > Offset is 0x8 and both channnels share the same > IRQ. > > Signed-off-by: Michal Simek > > --- > Changes in v2: > - Use kernel doc format - suggested by Linus Walleij

Re: [PATCH v2 3/6] GPIO: xilinx: Use __raw_readl/__raw_writel IO functions

2013-06-16 Thread Linus Walleij
can't be used > is that it won't work on Microblaze LE when > I fix Microblaze IO function implementation which > is broken right now. Makes perfect sense. Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH v2 4/6] GPIO: xilinx: Use BIT macro

2013-06-16 Thread Linus Walleij
On Mon, Jun 3, 2013 at 2:31 PM, Michal Simek wrote: > Use BIT macro from linux/bitops.h. > > Signed-off-by: Michal Simek > --- > Changes in v2: > - New patch in this series suggested by Linus Valleij Patch applied. Yours, Linus Walleij -- To unsubscribe from this l

Re: [PATCH v2 6/6] DT: Add documentation for gpio-xilinx

2013-06-16 Thread Linus Walleij
default = <0x0>; > + xlnx,dout-default-2 = <0x0>; > + xlnx,gpio-width = <0x2>; > + xlnx,gpio2-width = <0x2>; > + xlnx,interrupt-present = <0x1>; > + xlnx,is-dual = <0x1>; xlnx,is-dual; I'm not giving up on this s

Re: [PATCH] gpio: devres: make comments proper

2013-06-16 Thread Linus Walleij
On Tue, Jun 4, 2013 at 5:48 PM, Wolfram Sang wrote: > The free-function mentioned "interrupt" instead of "GPIO". While we are > here, use "GPIO" (capital letters) consistently. > > Signed-off-by: Wolfram Sang Patch applied. Yours, Linus Walleij -- To

Re: [PATCH v2 5/6] GPIO: xilinx: Enable driver for Xilinx zynq

2013-06-16 Thread Linus Walleij
On Mon, Jun 3, 2013 at 2:31 PM, Michal Simek wrote: > Enable gpio driver for usage on Xilinx ARM zynq platform. > > Signed-off-by: Michal Simek > --- > Changes in v2: > - New patch in this series Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the

Re: [PATCH] gpio: msm-v1: Remove errant __devinit to fix compile

2013-06-16 Thread Linus Walleij
ephen Boyd Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] gpio_msm: Remove __devinit attribute

2013-06-17 Thread Linus Walleij
On Mon, Jun 10, 2013 at 10:05 AM, Tushar Behera wrote: > The definition of __devinit has been removed from the kernel. Remove > this to fix compilation error. > > Signed-off-by: Tushar Behera I already had a similar patch from Stephen Boyd queued so dropping this. Yours, Linus W

Re: [PATCH] gpio MIPS/OCTEON: Add a driver for OCTEON's on-chip GPIO pins.

2013-06-17 Thread Linus Walleij
; + chip->direction_input = octeon_gpio_dir_in; > + chip->get = octeon_gpio_get; > + chip->direction_output = octeon_gpio_dir_out; > + chip->set = octeon_gpio_set; > + err = gpiochip_add(chip); > + if (err) > + goto out; >

Re: [PATCH 05/15] gpio-sta2x11: Convert to use devm_ioremap_resource

2013-06-17 Thread Linus Walleij
ux-g...@vger.kernel.org > CC: Grant Likely > CC: Linus Walleij Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo

Re: [PATCH] gpio: Enable pcf857x GPIO expander for Device Tree

2013-06-17 Thread Linus Walleij
doesn't then get rid of this flag. > +- reg: I2C address of the chip. > + > +Device speific properties: > +- n_latch: optional bit-inverse of initial register value; if > + you leave this initialized to zero the driver will act > + l

Re: [PATCH v2 6/6] DT: Add documentation for gpio-xilinx

2013-06-17 Thread Linus Walleij
On Mon, Jun 17, 2013 at 8:21 AM, Michal Simek wrote: > On 06/17/2013 07:50 AM, Linus Walleij wrote: >> On Mon, Jun 3, 2013 at 2:31 PM, Michal Simek wrote: >>> +- xlnx,tri-default : if n-th bit is 1, GPIO-n is in tristate mode >>> +- xlnx,is-dual : if 1, controller a

Re: [PATCH 4/7] mfd: stmpe: use irq_get_trigger_type() to get IRQ flags

2013-06-17 Thread Linus Walleij
On Fri, Jun 14, 2013 at 6:40 PM, Javier Martinez Canillas wrote: > Use irq_get_trigger_type() to get the IRQ trigger type flags > instead calling irqd_get_trigger_type(irq_get_irq_data(irq)) > > Signed-off-by: Javier Martinez Canillas Acked-by: Linus Walleij If you get the o

Re: [PATCH] gpio: ich: add GPO_BLINK support

2013-06-17 Thread Linus Walleij
does not apply on my current GPIO tree, i.e. this: https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/commit/?h=next Care to rebase it? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH] spi: pl022: remove unused ret and pins_state variables

2013-06-17 Thread Linus Walleij
> > f1c9cf0 spi: pl022: use pinctrl PM helpers > > Signed-off-by: Fabio Baltieri How sloppy of me. Applied with Mark's ACK. Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH Resend] pinctrl: exynos: Fix build breakage

2013-06-17 Thread Linus Walleij
: implicit declaration of > function ‘exynos_wkup_irq_ack’ [-Werror=implicit-function-declaration] >exynos_wkup_irq_ack(irqd); > > Signed-off-by: Sachin Kamat > Cc: Doug Anderson > --- > Fixed the commit message. > --- Applied. Usually you should state which commit caused

Re: [PATCH 01/11] pinctrl: single: adopt pinctrl sleep mode management

2013-06-17 Thread Linus Walleij
On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja wrote: > Make pinctrl-single able to handle suspend/resume events and change > hogged pins states accordingly. > > Signed-off-by: Hebbar Gururaja > Cc: Linus Walleij Noone said anything about this patch, but it looks very stra

Re: [PATCH -next v2] dmaengine: ste_dma40: fix error return code in d40_probe()

2013-06-17 Thread Linus Walleij
On Mon, Jun 17, 2013 at 3:50 PM, Vinod Koul wrote: > On Thu, Jun 13, 2013 at 09:49:04AM +0200, Linus Walleij wrote: >> I haven't sent this patch to ARM SoC so it will not appear from any other >> source >> in the merge window or cause any conflicts. > > Doesnt a

Re: [PATCH] ARM: ux500: set coherent_dma_mask for dma40

2013-06-17 Thread Linus Walleij
to the next/drivers branch (I think). I have also queued it on ux500-fixes so it won't be lost. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] pinctrl: rockchip: correctly handle arguments of pinconf options

2013-06-17 Thread Linus Walleij
e old commit message, least somebody else reads it and takes > it as true. OK took out the v1 and put in this v2 version instead... Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-17 Thread Linus Walleij
On Mon, Jun 17, 2013 at 7:57 AM, Lothar Waßmann wrote: > Linus Walleij writes: >> - * if it is 0, pull-up is disabled. >> + * if it is 0, pull-up it total, i.e. the pin is connected to VDD. > ^^ > 'is'? Thanks for noticing, fixe

Re: [PATCH] pinctrl: document the pinctrl PM states

2013-06-17 Thread Linus Walleij
rent sets of pins (IIRC). For runtime pin config I have many more examples, we change a lot of those to so-called "GPIO mode" (basically just turned into an input with wakeup, or pulled to ground) at sleep. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] pinctrl: document the pinctrl PM states

2013-06-17 Thread Linus Walleij
er is config, like pull-ups etc. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 01/11] pinctrl: single: adopt pinctrl sleep mode management

2013-06-17 Thread Linus Walleij
On Mon, Jun 17, 2013 at 2:03 PM, Tony Lindgren wrote: > * Linus Walleij [130617 04:38]: >> On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja >> wrote: >> >> > Make pinctrl-single able to handle suspend/resume events and change >> > hogged pins states accor

Re: [PATCH 2/6] pinctrl: sunxi: Move the pins definitions to a separate header

2013-06-17 Thread Linus Walleij
or ATM7029. They don't even publish their kernel sources nor datasheet so no chance of supporting that thing. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH] pinctrl: update GPIO range doc

2013-06-17 Thread Linus Walleij
On Mon, Jun 17, 2013 at 7:20 AM, Rob Landley wrote: > On 06/16/2013 05:18:29 AM, Linus Walleij wrote: >> >> From: Linus Walleij >> >> This updates the GPIO range documentation with the API changes >> for sparse/random/arbitrary pin-to-GPIO mappings. > > Ac

Re: [PATCH Resend] pinctrl: exynos: Fix build breakage

2013-06-17 Thread Linus Walleij
of unmask. OK probably I just had git am fail on me and used patch -p1 < ... > Linus, could you fix it? No I'm afraid I will cause more trouble. I took out Doug's commit and this fi from my tree. Doug, can you respin the patch "pinctrl: exynos: ack level-triggered interr

Re: [PATCH] pinctrl: export pinctrl_pm_select_*_state

2013-06-17 Thread Linus Walleij
Bergmann That's right, sorry for missing this :-( Patch applied! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.

Re: [PATCH v2 1/2] MAINTAINERS: Add Samsung pinctrl entries

2013-06-17 Thread Linus Walleij
and Tomasz; removed Linus since he's already > there as part of the general pinctrl match. Patch applied with all the ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH] ARM: ux500: add restart support via prcmu

2013-06-17 Thread Linus Walleij
meriging "reboot reason" code, rename "reason" to "cause" everywhere. Cause and effect. Causality. Not the age of reason. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Re: [PATCH v2 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-17 Thread Linus Walleij
On Thu, Jun 13, 2013 at 8:20 PM, Linus Walleij wrote: > On Thu, Jun 13, 2013 at 6:38 PM, Doug Anderson wrote: > >> A level-triggered interrupt should be acked after the interrupt line >> becomes inactive and before it is unmasked, or else another interrupt >> will

Re: [PATCH v3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-17 Thread Linus Walleij
s not enough. > > Signed-off-by: Luigi Semenzato > Signed-off-by: Doug Anderson > Acked-by: Tomasz Figa > --- > Changes in v3: > - Rebased atop (44b6d93 pinctrl: rockchip: correctly handle arguments > of pinconf options) OK patch applied (cleanly this time). Yours, Linus Wall

Re: [PATCH 01/10] clocksource: dw_apb_timer_of: use the clocksource as sched clock if necessary

2013-06-03 Thread Linus Walleij
like some more careful handling of the device tree input making the sched_timer optional, it doesn't really "add" anything, does it? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

Re: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-04 Thread Linus Walleij
tput, 0 for input */ > + if (!input) > + data |= (1 << pin); > + else > + data &= ~(1 << pin); Here again I would use and: data |= BIT(pin); etc, but it's a matter of taste so if you prefer this, do keep it. (...) > +

Re: [PATCH 09/11] mmc: omap_hsmmc: enhance pinctrl support

2013-06-04 Thread Linus Walleij
tates are not available, to remove this warning message > pass respective state name with null phandler. > > Signed-off-by: Hebbar Gururaja > Cc: Balaji T K > Cc: Chris Ball > Cc: linux-...@vger.kernel.org > Cc: linux-o...@vger.kernel.org This is perfectly correct. Acked-by

Re: [PATCH 02/11] leds: leds-gpio: Enhance pinctrl support

2013-06-04 Thread Linus Walleij
hat I planned to do but never got around to. Please? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 09/11] mmc: omap_hsmmc: enhance pinctrl support

2013-06-04 Thread Linus Walleij
On Tue, Jun 4, 2013 at 9:11 AM, Linus Walleij wrote: > On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja > wrote: > >> Amend the hsmmc controller to optionally take a pin control handle and >> set the state of the pins to: >> >> - "default" on boot,

Re: [PATCH 11/11] i2c: omap: enhance pinctrl support

2013-06-04 Thread Linus Walleij
tates, but you may see even further... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 00/11] drivers: Add Pinctrl PM support

2013-06-04 Thread Linus Walleij
that will just have to call pinctrl_select_pm_sleep(), pinctrl_select_pm_default() pinctrl_select_pm_idle() instead of all the complex code. This is what I planned to do but never got around to. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: [PATCH] ARM: ux500: Reduce PRCMU reg-names to shorter form for u8540 DT

2013-06-04 Thread Linus Walleij
On Thu, May 30, 2013 at 10:31 AM, Lee Jones wrote: > After some discussion and deliberation we have decided to only use the > short form of the PRCMU register names i.e. not mention the peripheral > in which the registers reside. > > Signed-off-by: Lee Jones Patch applied

<    6   7   8   9   10   11   12   13   14   15   >