Hi,
> From: Lothar Waßmann Sent: Friday, November 27,
> 2015 9:39 PM
> > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Kevin Hao; Lothar
> > Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe Reynes; Russell King;
> > Uwe Kleine-König; linux-ker
NULL is a valid argument to clk_enable()/clk_disable(). Remove
redundant checks before calling those functions.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/net
Use gpiod_get_optional() instead of checking for a valid GPIO number
and calling devm_gpio_request_one() conditionally.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/net
This patchset fixes a regression introduced by
commit 8fff755e9f8d ("net: fec: Ensure clocks are enabled while using mdio bus")
for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6
or i.MX28)
The first patch is a cleanup patch that removes redundant NULL checks.
The second patch
.ethernet eth0: Link is Down
fec 02188000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx
fec 02188000.ethernet eth0: Link is Down
[...]
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec.h | 1 +
drivers/net/ethernet/freescale/fec_main.c | 46
Hi,
> From: Lothar Waßmann Sent: Monday, November 30,
> 2015 7:33 PM
> > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer;
> > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe
> > Reynes; Richard Cochran; Russell King; Sascha Ha
Hi,
> From: Lothar Waßmann Sent: Monday, November 30,
> 2015 7:33 PM
> > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer;
> > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe
> > Reynes; Richard Cochran; Russell King; Sascha Ha
Hi,
> From: Lothar Waßmann Sent: Monday, November 30,
> 2015 7:33 PM
> > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer;
> > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe
> > Reynes; Richard Cochran; Russell King; Sascha Ha
Hi,
> On Wed, Jan 20, 2016 at 01:29:51PM +0100, Lothar Waßmann wrote:
>
> > This pin is used as IRQ pin for the LTC3589 PMIC on the Ka-Ro
> > electronics TX48 module. Make the IRQ optional in the driver and use a
> > polling routine instead if no IRQ is specified in DT.
Hi,
> On Thu, Jan 21, 2016 at 08:05:24AM +0100, Lothar Waßmann wrote:
> > > On Wed, Jan 20, 2016 at 01:29:51PM +0100, Lothar Waßmann wrote:
>
> > > > This pin is used as IRQ pin for the LTC3589 PMIC on the Ka-Ro
> > > > electronics TX48 module. Make t
Hi,
> On Thu, Jan 21, 2016 at 11:26:11AM +0100, Lothar Waßmann wrote:
> > > On Thu, Jan 21, 2016 at 08:05:24AM +0100, Lothar Waßmann wrote:
> > > > > On Wed, Jan 20, 2016 at 01:29:51PM +0100, Lothar Waßmann wrote:
>
> > > > > > This pin is u
Hi,
> On Thu, Jan 21, 2016 at 12:33:11PM +0100, Lothar Waßmann wrote:
> > > On Thu, Jan 21, 2016 at 11:26:11AM +0100, Lothar Waßmann wrote:
> > > > > On Thu, Jan 21, 2016 at 08:05:24AM +0100, Lothar Waßmann wrote:
> > > > > > > On Wed, Jan 20
This patchset adds missing input_sel settings to imx6ul-pinfunc.h.
The first patch is a cleanup patch with no functional changes
intended.
Various pads are missing the input_sel offset and value. Fix this.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6ul-pinfunc.h | 90 +++---
1 file changed, 45 insertions(+), 45 deletions(-)
diff --git a/arch/arm/boot/dts/imx6ul-pinfunc.h
b/arch/arm
Hi,
On Sun, 28 Feb 2016 14:43:26 +0800 Shawn Guo wrote:
> On Wed, Jan 20, 2016 at 11:09:09AM +0100, Lothar Waßmann wrote:
[...]
> > +/dts-v1/;
> > +#include "imx6ul.dtsi"
> > +#include "imx6ul-txul.dtsi"
> > +
> > +/ {
> > + model
Pad DISPB2_SER_RS has no function DISP1_EXT_CLK.
The definition is obviusly a copy/paste error from
MX51_PAD_DISPB2_SER_RS__DISP1_PIN16.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx51-pinfunc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-pinfunc.h
b
_get_drvdata(dev);
> >> +struct platform_device *pdev = container_of(dev,
> >> +struct platform_device, dev);
> >> struct net_device *ndev = platform_get_drvdata(pdev);
> >> struct xcan_priv *priv = netdev_priv(ndev);
>
Why not
Hi,
David Laight wrote:
> From: Lothar Waßmann
> > David Laight wrote:
> > > From: Eric Dumazet
> > > > On Tue, 2014-10-07 at 15:19 +0200, Lothar Wamann wrote:
> > > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx
> &g
/marsboard.html
>
> Signed-off-by: Sergio Prado
> ---
> arch/arm/boot/dts/imx6q-marsboard.dts | 411
> ++
> 1 file changed, 411 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6q-marsboard.dts
>
No Makefile entry?
Lothar Waßmann
to the clock_freq of the can serial clock being reported as '0'.
Signed-off-by: Lothar Waßmann
---
drivers/clk/imx/clk-imx6q.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
index 02e1818..2beb396f 100644
---
Hi,
On Thu, 31 Mar 2016 14:10:23 +0800 Shawn Guo wrote:
> On Tue, Mar 08, 2016 at 09:04:03AM +0100, Lothar Waßmann wrote:
> > Add support for the following i.MX6 based modules from Ka-Ro
> > electronics GmbH:
> > TX6S-8034:
> > ProcessorFreescale i.MX 6 Solo, 800
5.5V
Size 31mm SO-DIMM
Temp. Range Extended Consumer Grade (-20°C to 105°C Tj)
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile | 4 +
arch/arm/boot/dts/imx6dl-tx6s-8034.dts | 237 ++
arch/arm/boot/dts/imx6dl-tx6s-8035.dts | 253
Add missing pinctrl for the RTS/CTS lines to uart1 and set the
fsl,uart-has-rtscts property on all UARTs to enable support for HW
handshake.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot
DT maintainers don't like the 'simple-bus' container around the
regulator nodes. So remove it.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 166 +
1 file changed, 75 insertions(+), 91 deletions(-)
diff --git a/ar
This patch set updates the Ka-Ro electronics i.MX6 based module
support and adds support for some new modules and a new baseboard.
changes vs. v1:
- relicense DTS files under GPLv2/X11
- dropped patches which have been applied already
- added some cleanup patches
changes vs. v2:
- dropped patches
Move the pinctrl setting for the board LED from the hoggrp node
to a separate node referenced by the LED driver, so that the pin is
free to be used for different purpose when the LED driver is disabled.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 9 -
1 file
This baseboard can be used with all TX6 SoMs, but only a certain set
of combinations can be ordered by default. Add support for these
combinations in mainline, so that users can easily adopt their own
combination of SoM and baseboard themselves.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot
e it can remove the unnecessary step back and forth. (dev -> pdev ->
> dev).
>
Did you check whether the compiler generates different (better) code
with and without your patch? My guess is it won't.
Lothar Waßmann
fset,
> buf++;
> }
>
> - memcpy(val, (u8 *)p + offset % 4, bytes);
> + memcpy(val, (u8 *)p, bytes);
>
> kfree(p);
>
With these changes you could use the 'val' pointer directly
as the destination for ocotp_read() without need for an intermediate
buffer.
Lothar Waßmann
Hi,
On Fri, 5 Jul 2019 02:46:32 + Andy Duan wrote:
> From: Andy Duan Sent: Friday, July 5, 2019 12:08 AM
> > From: Lothar Waßmann Sent: Thursday, July 4,
> > 2019 11:46 PM
> > > Hi,
> > >
> > > On Thu, 4 Jul 2019 22:20:15 +0800 fugang.d...@
> + dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
> + }
>
You changed the braces in the wrong place!
The comment applied to the previous 'if (ret)' which has an else clause
with braces, so the if clause needs braces too.
Lothar Waßmann
ce size */
> + if (flash->spimem->spi->size == 0)
> + flash->spimem->spi->size = nor->mtd.size;
> +
If the 'size' is an spimem specific variable it should be added to the
spi_mem struct rather than the spi_device struct.
Lothar Waßmann
-0 = <&pinctrl_backlight_gpio>;
> > + pinctrl-1 = <&pinctrl_backlight_pwm>;
> > +}
> > +
> > +pinctrl_backlight_gpio: pwm1grp-gpio {
> > + fsl,pins = <
> > + /* GPIO with 22kOhm pull-up */
> > + MX6QDL_PAD_GPI
Michal Vokáč wrote:
> On 31.8.2018 14:45, Lothar Waßmann wrote:
> > Rob Herring wrote:
> >
> >> On Tue, Aug 21, 2018 at 04:38:52PM +0200, Michal Vokáč wrote:
> >>> Output of the PWM block of i.MX SoCs is always zero volts when the block
> >>>
down bit offset
> + * @power_invert: set powerdown bit to power up the PLL
s/set/clear/ ?
Lothar Waßmann
Hi,
On Thu, 9 Jun 2016 14:51:25 +0100 Lee Jones wrote:
> On Tue, 07 Jun 2016, Lothar Waßmann wrote:
>
> > 'brightness' is usually an index into a table of duty_cycle values,
> > where the value at index 0 may well be non-zero
> > (tegra30-apalis-eval.dts and te
Hi,
On Fri, 10 Jun 2016 08:44:49 +0100 Lee Jones wrote:
> On Fri, 10 Jun 2016, Lothar Waßmann wrote:
>
> > Hi,
> >
> > On Thu, 9 Jun 2016 14:51:25 +0100 Lee Jones wrote:
> > > On Tue, 07 Jun 2016, Lothar Waßmann wrote:
> > >
> > > > '
out a good knowledge of mio's board
> design!\n");
>
There is already a continuation line that has a whitespace in front. It
would be nice to be consistent and also add the missing whitespace in
front of the succeeding line...
Lothar Waßmann
dev_err(&pdev->dev, "getting ipg clock failed with %ld\n",
> - PTR_ERR(imx->clk_ipg));
> - return PTR_ERR(imx->clk_ipg);
> - }
> -
> imx->chip.ops = &imx_pwm_ops;
> imx->chip.dev = &pdev->dev;
> imx->chip.base = -1;
>
If the IPG clock is not needed by the driver it should be removed from
DT as well.
Lothar Waßmann
Hi,
On Wed, 2 Nov 2016 08:36:14 +0100 Sascha Hauer wrote:
> On Wed, Nov 02, 2016 at 08:18:52AM +0100, Lothar Waßmann wrote:
> > Hi,
> >
> > On Mon, 31 Oct 2016 06:59:04 +0100 Sascha Hauer wrote:
> > > As said, even the commit 7b27c160c68 introducing the registe
Hi,
On Wed, 2 Nov 2016 09:06:45 +0100 Sascha Hauer wrote:
> On Wed, Nov 02, 2016 at 08:56:20AM +0100, Lothar Waßmann wrote:
> > Hi,
> >
> > On Wed, 2 Nov 2016 08:36:14 +0100 Sascha Hauer wrote:
> > > On Wed, Nov 02, 2016 at 08:18:52AM +0100, Lothar Waßmann wrote:
&
> + /* bring chip out of reset */
> + dev_info(&client->dev, "releasing reset\n");
> + gpiod_set_value(chip->reset_gpio, 0);
>
The pin is already initialized to the inactive state thru the
GPIOD_OUT_LOW flag in devm_gpiod_get_optional(), so this call to
gpiod_set_value() is useless.
Lothar Waßmann
0 {
> vddcore-supply = <&ldo8_reg>;
> vddio-supply = <&ldo10_reg>;
> + samsung,burst-clock-frequency = <5>;
> + samsung,esc-clock-frequency = <2000>;
> samsung,pll-clock-frequency = <2400>;
> status = "okay";
>
Lothar Waßmann
Hi,
On Mon, 6 Jun 2016 15:02:21 +0300 Tomi Valkeinen wrote:
> Hi,
>
> On 06/06/16 13:44, Lothar Waßmann wrote:
> > 'brightness' is usually an index into a table of duty_cycle values,
> > where the value at index 0 may well be non-zero
> > (tegra30-apalis-eva
Check for 'duty_cycle == 0' rather than 'brightness == 0' to decide
whether to disable the PWM.
Signed-off-by: Lothar Waßmann
---
Changes wrt. v1:
- update binding docs to reflect the change
.../devicetree/bindings/leds/backlight/pwm-backlight.txt | 9 ++---
dr
The power and reset handling of the FEC ethernet driver is sufficient
to get the ethernet PHY on the TX28 into a usable state.
Remove the code that does the PHY initialization on startup.
Signed-off-by: Lothar Waßmann
---
arch/arm/mach-mxs/mach-mxs.c | 77
Hi,
On Wed, 25 May 2016 15:18:16 +0200 Lothar Waßmann wrote:
> The 'de-active' and 'pixelclk-active' DT properties are evaluated
> by of_parse_display_timing() called from of_get_drm_display_mode(),
> but later lost in the conversion from videomode.flags to
>
The 'de-active' and 'pixelclk-active' DT properties are evaluated
by of_parse_display_timing() called from of_get_drm_display_mode(),
but later lost in the conversion from videomode.flags to
drm_display_mode.flags.
Changes vs. v3:
- split the patch as suggested by Daniel Vetter
Changes vs. v2
of_get_drm_display_mode() may fail. Check its return code and bail out
on error.
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/imx/parallel-display.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/parallel-display.c
b/drivers/gpu/drm/imx
flags in a
separate variable, so that they can be passed on to the ipu-di
driver.
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/drm_modes.c| 5 -
drivers/gpu/drm/imx/imx-ldb.c | 11 ---
drivers/gpu/drm/imx/parallel-display.c | 8 ++--
include/drm/drm_modes.h
add a helper function to extract information about pixel clock and DE
polarity from DT for use by of_get_drm_display_mode().
While at it, convert spaces to tabs in indentation in drm_modes.h.
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/drm_modes.c | 15 +++
include/drm
Hi,
On Fri, 10 Jun 2016 15:54:49 +0100 Lee Jones wrote:
> On Fri, 10 Jun 2016, Lothar Waßmann wrote:
> > On Fri, 10 Jun 2016 08:44:49 +0100 Lee Jones wrote:
> > > On Fri, 10 Jun 2016, Lothar Waßmann wrote:
> > >
> > > > Hi,
> > > >
> &
Check for 'duty_cycle == 0' rather than 'brightness == 0' to decide
whether to disable the PWM.
Signed-off-by: Lothar Waßmann
---
drivers/video/backlight/pwm_bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/
[PATCHv3 1/2] ARM: dts: imx6ul: add support for Ka-Ro electronics TXUL modules
[PATCHv3 2/2] ARM: dts: imx6ul: add support for Ka-Ro electronics TXUL mainboard
This patchset adds more functionality to the i.MX6UL machines.
Changes vs. v1:
- added patch to implement KPP clock for i.MX6UL to preven
)
Power supply Single 3.3 to 5V
Size 26mm SO-DIMM
Temp. Range -40°C to 85°C
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile | 4 +-
arch/arm/boot/dts/imx6ul-tx6ul-0010.dts | 53 ++
arch/arm/boot/dts/imx6ul-tx6ul-0011.dts | 68 +++
arch/arm/boot/dts/imx6ul
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile | 3 +-
arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dts | 271 +++
2 files changed, 273 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dts
diff --git
> > I didn't report it because it contained 0 at all times. So no information.
> >
> >> Also, in the error case, can you check if the watchdog times out at all
> >> after you applied your patch ?
> >
> > It times out after 16s as expected, and reboot
Hi,
On Fri, 4 Mar 2016 16:26:59 +0100 Romain Izard wrote:
> Hi Lothar,
>
> 2016-03-04 15:59 GMT+01:00 Lothar Waßmann :
> >> >>>>> I also check the WDT_MR register before and after enabling
> >> >>>>> watchdog, the WDV and WDD fields
This baseboard can be used with all TX6 SoMs, but only a certain set
of combinations can be ordered by default. Add support for these
combinations in mainline, so that users can easily adopt their own
combination of SoM and baseboard themselves.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot
Add an empty line between properties and subnode in the clocks node.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
index 5d348d9..912f284 100644
GPLv2-only devicetrees make reuse difficult for software components
licensed under a different license.
The consensus is that a GPL/X11 dual-license should allow all necessary
uses, so relicense the imx6*-tx6* files to this combination.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts
, but leave the configuration intact otherwise.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
index ec374f5..9509b44 100644
--- a/arch/arm/b
Add mdio node and an appropriate PHY configuration to enable use of
the PHY interrupt for link status changes.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 14 ++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
b/arch/arm
DT maintainers don't like the 'simple-bus' container around the
regulator nodes. So remove it.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 178 +
1 file changed, 81 insertions(+), 97 deletions(-)
diff --git a/ar
This patch set updates the Ka-Ro electronics i.MX6 based module
support and adds support for some new modules and a new baseboard.
changes vs. v1:
- relicense DTS files under GPLv2/X11
- dropped patches which have been applied already
- added some cleanup patches
[PATCHv2 1/8] ARM: dts: imx6-tx6:
5.5V
Size 31mm SO-DIMM
Temp. Range Extended Consumer Grade (-20°C to 105°C Tj)
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile | 4 +
arch/arm/boot/dts/imx6dl-tx6s-8034.dts | 249
arch/arm/boot/dts/imx6dl-tx6s-8035.dts | 246
Remove the function node around the pinctrl nodes that was obsoleted
by commit 5fcdf6a7ed95 ("pinctrl: imx: Allow parsing DT without
function nodes"), we can save this container node.
Also move the iomux node to the bottom of the file to improve
readability of the file.
Signed-off-
The mxs-dma unit is also available on i.MX6UL. Make it possible to
select it in Kconfig.
Changes vs. V1:
- use SOC_IMX6UL rather than SOC_MX6UL
Signed-off-by: Lothar Waßmann
Acked-by: Vinod Koul
---
drivers/dma/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a
Hi,
On Tue, 2 Feb 2016 14:18:42 +0800 Shawn Guo wrote:
> On Wed, Jan 20, 2016 at 01:23:39PM +0100, Lothar Waßmann wrote:
> > The TX51-8xxx module series is a System On Module manufactured by
> > Ka-Ro electronics GmbH with the following characteristics:
> > Processor
Hi,
On Thu, 28 Jan 2016 15:08:47 -0800 Nicolin Chen wrote:
> On Thu, Jan 28, 2016 at 11:33:52PM +0100, Mark Brown wrote:
> > On Wed, Jan 20, 2016 at 01:30:38PM +0100, Lothar Waßmann wrote:
> >
> > > - select SND_SOC_FSL_SSI
> > > + select SND_SOC_FSL
Hi,
On Thu, 28 Jan 2016 23:33:52 +0100 Mark Brown wrote:
> On Wed, Jan 20, 2016 at 01:30:38PM +0100, Lothar Waßmann wrote:
>
> > - select SND_SOC_FSL_SSI
> > + select SND_SOC_FSL_SAI if SOC_IMX6UL
> > + select SND_SOC_FSL_SSI if SOC_IMX6Q || SOC_IMX6SL || SOC_IMX6SX
Hi,
On Thu, 28 Jan 2016 22:30:13 -0800 Nicolin Chen wrote:
> On Fri, Jan 29, 2016 at 06:59:38AM +0100, Lothar Waßmann wrote:
> > Hi,
> >
> > On Thu, 28 Jan 2016 23:33:52 +0100 Mark Brown wrote:
> > > On Wed, Jan 20, 2016 at 01:30:38PM +0100, Lothar Waßmann wrote:
Hi,
On Thu, 28 Jan 2016 22:25:30 -0800 Nicolin Chen wrote:
> On Fri, Jan 29, 2016 at 06:51:33AM +0100, Lothar Waßmann wrote:
> > Hi,
> >
> > On Thu, 28 Jan 2016 15:08:47 -0800 Nicolin Chen wrote:
> > > On Thu, Jan 28, 2016 at 11:33:52PM +0100, Mark Brown wrote:
>
ze checks, as they were before the offending commit.
Signed-off-by: Lothar Waßmann
---
kernel/module.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c
index 8358f46..40d8e42 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1
Hi,
On Fri, 22 Jan 2016 16:26:10 + Mark Brown wrote:
> On Fri, Jan 22, 2016 at 06:41:45AM +0100, Lothar Waßmann wrote:
> > > On Thu, Jan 21, 2016 at 12:33:11PM +0100, Lothar Waßmann wrote:
>
> > > Your commit message (quoted above) claims that without this patch
Hi,
On Mon, 25 Jan 2016 12:41:23 + Mark Brown wrote:
> On Mon, Jan 25, 2016 at 01:37:31PM +0100, Lothar Waßmann wrote:
> > On Fri, 22 Jan 2016 16:26:10 + Mark Brown wrote:
>
> > > You're not just making the interrupt optional, you are also implementing
>
zero parameter and thus apply_to_page_range() in
> > mm/memory.c barfs due to:
> > unsigned long end = addr + size;
> > ...
> > BUG_ON(addr >= end);
>
> Hit this BUG_ON() on a mt8173 platform with v4.5-rc1.
>
I just found a patch that fixes this problem in a different way (making
the set_memory_*() functions accept a zero size argument):
<1453561543-14756-1-git-send-email-mika.pentt...@nextfour.com>
http://lkml.iu.edu/hypermail/linux/kernel/1601.2/04934.html
So this patch is obsolete.
Lothar Waßmann
tion.
Removing the bogus call to m_can_class_suspend() in the
m_can_runtime_suspend() function fixes this.
Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework")
Fixes: 0704c5743694 ("can: m_can_platform: remove unnecessary
m_can_class_resume() call")
Signed
> }
>
sport is devm_kzalloc()ed, so the variables are initialized to 0 anyway.
Lothar Waßmann
inding is kept around because it works fine on imx6qdl.
>
> This was initially reported by Lothar Waßmann in
> reply
> to a patch adding imx6ul/ull support:
>
> Link: https://lkml.org/lkml/2017/6/9/578
>
> ---
> Changes since v1:
> * Move nvmem_cell_read_u32 to nvme
Hi,
On Mon, 5 Feb 2018 15:56:22 +0800 Shawn Guo wrote:
> On Fri, Jan 26, 2018 at 09:52:18AM +0100, Lothar Waßmann wrote:
> > imx6ull-14x14-evk.dts currently includes the imx6ul.dtsi file for an
> > i.MX6ULL SoC which is plain wrong.
> >
> > Rename the current imx6ul
Hi,
On Mon, 5 Feb 2018 18:37:20 +0800 Shawn Guo wrote:
> On Mon, Feb 05, 2018 at 10:55:43AM +0100, Lothar Waßmann wrote:
> > Hi,
> >
> > On Mon, 5 Feb 2018 15:56:22 +0800 Shawn Guo wrote:
> > > On Fri, Jan 26, 2018 at 09:52:18AM +0100, Lothar Waßmann wrote:
According to the "i.MX 6Solo/6DualLite Applications Processor
Reference Manual" Rev. 3, 09/2017 there is no LCDIF unit on the
i.MX6DL.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6dl.dtsi | 5 -
1 file changed, 5 deletions(-)
diff --git a/arch/arm/boot/dts/imx6dl.dtsi
lvds_encoder->bridge.funcs = &funcs;
> + drm_bridge_add(&lvds_encoder->bridge);
>
> - platform_set_drvdata(pdev, bridge);
> + platform_set_drvdata(pdev, lvds_encoder);
>
> return 0;
> }
>
> static int lvds_encoder_remove(struct platform_device *pdev)
> {
> - struct drm_bridge *bridge = platform_get_drvdata(pdev);
> + struct lvds_encoder *lvds_encoder = platform_get_drvdata(pdev);
>
> - drm_bridge_remove(bridge);
> + drm_bridge_remove(&lvds_encoder->bridge);
>
> return 0;
> }
>
Tested-by: Lothar Waßmann
Lothar Waßmann
files all have this:
| memory { device_type = "memory"; reg = <0 0>; };
Thus you will end up with a 'memory' node with a reg = <0 0> entry and
an additional 'memory@...' node with the correct 'reg' values.
Lothar Waßmann
cted as
MLC NAND with 4KiB page size rather than SLC with 2KiB page size.
Add a call to nand_get_bits_per_cell() before calling the .detect hook
function in nand_manufacturer_detect(), so that the nand_is_slc()
calls in the manufacturer specific code will return correct results.
Signed-off-by: Lothar
chip->bits_per_cell which is used to determine the NAND cell type
(SLC/MLC) should always have a value != 0.
Complain loudly if the value is 0 in nand_is_slc() to catch use before
correct initialization.
Signed-off-by: Lothar Waßmann
---
include/linux/mtd/rawnand.h | 2 ++
1 file changed
commit c51d0ac59f24 ("mtd: nand: Move Samsung specific init/detection
logic in nand_samsung.c") introduced a regression for Samsung SLC NAND
chips by skipping the initialization of chip->bits_per_cell that is
done in nand_decode_ext_id() from which the manufacturer dependent
code was extracted.
The
Hi,
On Tue, 29 Aug 2017 14:16:58 +0200 Boris Brezillon wrote:
> Hi Lothar,
>
> On Tue, 29 Aug 2017 12:17:12 +0200
> Lothar Waßmann wrote:
>
> > commit c51d0ac59f24 ("mtd: nand: Move Samsung specific init/detection
> > logic in nand_samsung.c") introdu
Hi,
On Tue, 29 Aug 2017 15:41:44 +0200 Boris Brezillon wrote:
> On Tue, 29 Aug 2017 15:18:07 +0200
> Lothar Waßmann wrote:
>
> > Hi,
> >
> > On Tue, 29 Aug 2017 14:16:58 +0200 Boris Brezillon wrote:
> > > Hi Lothar,
> > >
> > > On Tue,
GE_H
> #define __ASM_LINKAGE_H
>
> -#define __ALIGN .align 4
> -#define __ALIGN_STR ".align 4"
> +#define __ALIGN .align 2
> +#define __ALIGN_STR ".align 2"
>
> #endif
>
My math tells me, that 2 is one half of 4 but 4 is one fourth of 16, so
this change doesn't line up with your commit message, or am I missing
something?
Lothar Waßmann
rough other gates/dividers.
>
> Setting this to IMX6UL_CLK_DUMMY will cause temperature reads to fail.
> Even if PLL3 usually ends up being constantly enabled because of uarts
> this is not true at imx_thermal_probe time (or uarts can be disabled).
>
Since the driver is accessing the OCOTP registers it definitely needs
the IMX6UL_CLK_OCOTP too!
Lothar Waßmann
Hi,
On Fri, 9 Jun 2017 18:34:44 +0300 Leonard Crestez wrote:
> On Fri, 2017-06-09 at 15:46 +0200, Lothar Waßmann wrote:
> > On Fri, 9 Jun 2017 13:58:15 +0300 Leonard Crestez wrote:
> > > On Thu, 2017-06-08 at 13:45 -0300, Fabio Estevam wrote:
> > > > On Thu, J
> Most likely because U-Boot enabled the OCOTP clock as it reads the
> speed grading fuse.
>
No, the imx6q_opp_check_speed_grading() runs on an i.MX6Q which, as
mentioned in my other mail <20170612124029.16434...@karo-electronics.de>,
does not require any clock to be enabled for accessing the OCOTP regs.
Lothar Waßmann
This patch set brings the Ka-Ro electronics GmbH TX53 module series
dts files up to date.
It is not recommended to place the regulator nodes inside 'simple-bus',
so adjust them accordingly.
The motivation for rearranging this is to make it easier to add new
regulator nodes in the future.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx28-tx28
As the DS1339 driver now supports enabling the trickle charge feature
via DTB, add the appropriate properties to utilize this feature.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx53-tx53.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi
b
Use the correct interrupt flags and change the 'interrupt-parent',
'interrupts' property pairs to 'interrupts-extended'.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx28-tx28.dts | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
The display, that incorporates this touchpanel is obsolete and won't
be supported any more.
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx53-tx53-x13x.dts | 35 ---
1 file changed, 35 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.d
The current GPL only licensing on the dts file makes it very
impractical for other software components licensed under another
license.
In order to make it easier for them to reuse our device trees,
relicense our dts files first under a GPL/X11 dual-license.
Signed-off-by: Lothar Waßmann
301 - 400 of 454 matches
Mail list logo
