Hi Boris,
> -Original Message-
> From: Borislav Petkov [mailto:b...@alien8.de]
> Sent: Saturday, August 4, 2018 10:49 AM
> Subject: Re: [PATCH v3 1/4] edac: synps: Add platform specific structures for
> ddrc controller
>
> On Thu, Aug 02, 2018 at 06:21:19PM +0530
Add platform specific structures, so that we can add different IP
support later using quirks.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 83 ++--
1 file changed, 65 insertions(+), 18 deletions(-)
diff --git a/drivers/edac
This patch adds information of ZynqMP DDRC which reports the single bit
errors that are corrected and the double bit errors that are detected.
Signed-off-by: Manish Narani
---
.../bindings/memory-controllers/synopsys.txt | 27 ++
1 file changed, 22 insertions(+), 5
Add EDAC ECC support for ZynqMP DDRC IP. Also add support for ECC Error
Injection in ZynqMP. The corrected and uncorrected error interrupts
support is added. The Row, Column, Bank, Bank Group and Rank bits
positions are determined via Address Map registers of Synopsys DDRC.
Signed-off-by: Manish
This patch adds ddrc memory controller node in dts. The size mentioned
in dts is 0x3, because we need to access DDR_QOS INTR registers
located at fd090208 from this driver.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++
1 file changed, 7 insertions
v4:
- Updated the commit message in (1/4)
- Renamed function pointer names removing 'synps_' in (1/4)
- Shortened unnecessary long lines as per the review comment on (1/4)
Manish Narani (4):
edac: synps: Add platform specific structures for ddrc controller
dt: bindi
Hi Boris,
> -Original Message-
> From: Borislav Petkov [mailto:b...@alien8.de]
> Sent: Saturday, August 4, 2018 10:03 PM
> Subject: Re: [PATCH v4 0/4] EDAC: Enhancements to Synopsys EDAC driver
>
> On Sat, Aug 04, 2018 at 02:55:31PM +0530, Manish Narani wrote:
>
Hi Mark,
> -Original Message-
> From: Mark Rutland [mailto:mark.rutl...@arm.com]
> Sent: Thursday, June 7, 2018 6:18 PM
> To: Manish Narani
> Cc: robh...@kernel.org; catalin.mari...@arm.com; will.dea...@arm.com;
> m...@kernel.org; stefan.krsmano...@aggios.com
Hi Adrian,
> -Original Message-
> From: Adrian Hunter [mailto:adrian.hun...@intel.com]
> Sent: Tuesday, June 19, 2018 5:08 PM
> To: Manish Narani ; robh...@kernel.org;
> catalin.mari...@arm.com; will.dea...@arm.com; m...@kernel.org;
> stefan.krsmano...@aggios.
f AMS, PS, PL Sysmon
Channels.
Manish Narani (3):
dt-bindings: iio: adc: Add Xilinx AMS binding documentation
iio: adc: Add Xilinx AMS driver
arm64: zynqmp: DT: Add Xilinx AMS node
.../devicetree/bindings/iio/adc/xilinx-ams.txt | 159 +++
arch/arm64/boot/dts/xilinx/zynqmp.dtsi
The Xilinx AMS includes an ADC as well as on-chip sensors that can be
used to sample external and monitor on-die operating conditions, such as
temperature and supply voltage levels.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 26 ++
1 file
channels for measuring
external voltages.
The voltage and temperature monitoring channels also have event
capability which allows to generate an interrupt when their value falls
below or raises above a set threshold.
Signed-off-by: Manish Narani
---
drivers/iio/adc/Kconfig | 10 +
drivers
Xilinx AMS have several ADC channels that can be used for measurement of
different voltages and temperatures. Document the same in the bindings.
Signed-off-by: Manish Narani
---
.../devicetree/bindings/iio/adc/xilinx-ams.txt | 159 +
1 file changed, 159 insertions
Hi Boris,
Thank you so much for the review.
> -Original Message-
> From: Borislav Petkov [mailto:b...@alien8.de]
> Sent: Tuesday, August 21, 2018 6:37 PM
> To: Manish Narani
> Cc: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com;
> will.dea...@arm
Hi Boris,
Thanks a lot for the review.
> -Original Message-
> From: Borislav Petkov [mailto:b...@alien8.de]
> Sent: Tuesday, August 21, 2018 6:40 PM
> To: Manish Narani
> Cc: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com;
> will.dea...@arm.com; Mic
Hi Jonathan,
> -Original Message-
> From: Jonathan Cameron [mailto:ji...@kernel.org]
> Sent: Sunday, July 29, 2018 5:21 PM
> To: Manish Narani
> Cc: Sai Krishna Potthuri ; Michal Simek
> ; pme...@pmeerw.net; l...@metafoo.de;
> knaac...@gmx.de; Anirudha Sarangi ; Sr
This patch documents Synopsys EDAC driver which reports the single bit
errors that are corrected and the double bit errors that are detected.
Signed-off-by: Manish Narani
---
.../bindings/memory-controllers/synopsys.txt | 25 ++
1 file changed, 21 insertions(+), 4
This patch adds platform specific structures, so that we can add
different IP support later using quirks.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 70
1 file changed, 58 insertions(+), 12 deletions(-)
diff --git a/drivers/edac
Synopsys DDRC.
Signed-off-by: Manish Narani
---
drivers/edac/Kconfig | 2 +-
drivers/edac/synopsys_edac.c | 848 ++-
2 files changed, 833 insertions(+), 17 deletions(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 57304b2
This patch adds ddrc memory controller node in dts. The size mentioned
in dts is 0x3, because we need to access DDR_QOS INTR registers
located at fd090208 from this driver.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++
1 file changed, 7 insertions
This patch series enhances the current EDAC driver to support different
platforms.This series adds support for ZynqMP DDRC controller in synopsys
EDAC driver. This series also adds Device tree properties and relevant
binding documentation.
Manish Narani (4):
edac: synps: Add platform specific
Hi Uffe,
> -Original Message-
> From: Ulf Hansson [mailto:ulf.hans...@linaro.org]
> Sent: Tuesday, July 10, 2018 2:02 PM
> To: Manish Narani
> Cc: Rob Herring ; Mark Rutland
> ; Catalin Marinas ; Will
> Deacon ; Moritz Fischer ;
> stefan.krsmano...@ag
Hi Lars,
> -Original Message-
> From: Lars-Peter Clausen [mailto:l...@metafoo.de]
> Sent: Thursday, July 19, 2018 10:08 PM
> To: Manish Narani ; ji...@kernel.org;
> knaac...@gmx.de; pme...@pmeerw.net; Michal Simek
> ; linux-...@vger.kernel.org; linux-arm-
> ker..
Hi Jonathan,
Thanks for your comments.
> -Original Message-
> From: Jonathan Cameron [mailto:ji...@kernel.org]
> Sent: Saturday, July 21, 2018 9:54 PM
> To: Lars-Peter Clausen
> Cc: Manish Narani ; knaac...@gmx.de;
> pme...@pmeerw.net; Michal Simek ; linux-
> i...@v
This patch adds ddrc memory controller node in dts. The size mentioned
in dts is 0x3, because we need to access DDR_QOS INTR registers
located at fd090208 from this driver.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++
1 file changed, 7 insertions
DDR_ECC_INTR_SUPPORT from (1/4) to (3/4) as it is
a feature of ZynqMP DDRC
- The Binding Documentation in (2/4) is modified as per the review
comments
Manish Narani (4):
edac: synps: Add platform specific structures for ddrc controller
dt: bindings: Document ZynqMP DDRC in
This patch documents Synopsys EDAC driver which reports the single bit
errors that are corrected and the double bit errors that are detected.
Signed-off-by: Manish Narani
---
.../bindings/memory-controllers/synopsys.txt | 27 ++
1 file changed, 22 insertions(+), 5
This patch adds platform specific structures, so that we can add
different IP support later using quirks.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 64
1 file changed, 53 insertions(+), 11 deletions(-)
diff --git a/drivers/edac
Synopsys DDRC.
Signed-off-by: Manish Narani
---
drivers/edac/Kconfig | 2 +-
drivers/edac/synopsys_edac.c | 857 ++-
2 files changed, 841 insertions(+), 18 deletions(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 57304b2
This patch adds platform specific structures, so that we can add
different IP support later using quirks.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 64
1 file changed, 53 insertions(+), 11 deletions(-)
diff --git a/drivers/edac
DDR_ECC_INTR_SUPPORT from (1/4) to (3/4) as it is
a feature of ZynqMP DDRC
- The Binding Documentation in (2/4) is modified as per the review
comments
Changes in v3:
- The commit message in (2/4) is modified (Synopsys EDAC Driver -->
ZynqMP DDRC)
Manish Narani
This patch adds ddrc memory controller node in dts. The size mentioned
in dts is 0x3, because we need to access DDR_QOS INTR registers
located at fd090208 from this driver.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++
1 file changed, 7 insertions
Synopsys DDRC.
Signed-off-by: Manish Narani
---
drivers/edac/Kconfig | 2 +-
drivers/edac/synopsys_edac.c | 857 ++-
2 files changed, 841 insertions(+), 18 deletions(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 57304b2
This patch adds information of ZynqMP DDRC which reports the single bit
errors that are corrected and the double bit errors that are detected.
Signed-off-by: Manish Narani
---
.../bindings/memory-controllers/synopsys.txt | 27 ++
1 file changed, 22 insertions(+), 5
of XADC_CFG register to make timings better in the interface. So to
avoid alteration of these bits every time, the pcap value should not
cross the Fmax limit.
Signed-off-by: Manish Narani
---
drivers/iio/adc/xilinx-xadc-core.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a
This patch adds check for return values from clock related functions.
This was reported by static code analysis tool.
Signed-off-by: Manish Narani
---
drivers/iio/adc/xilinx-xadc-core.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/xilinx-xadc
Signed-off-by: Manish Narani
---
drivers/iio/adc/xilinx-xadc-core.c | 10 +-
drivers/iio/adc/xilinx-xadc.h | 1 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/adc/xilinx-xadc-core.c
b/drivers/iio/adc/xilinx-xadc-core.c
index 0dd306d..44a2519 100644
--- a/dr
interrupts.
Manish Narani (4):
iio: adc: xilinx: Check for return values in clk related functions
iio: adc: xilinx: limit pcap clock frequency value
iio: adc: xilinx: Remove platform_get_irq from xadc_remove function
iio: adc: xilinx: Move request_irq before enabling interrupts
drivers/iio
Enabling the Interrupts before registering the irq handler is a bad
idea. This patch corrects the same for XADC driver.
Signed-off-by: Manish Narani
---
drivers/iio/adc/xilinx-xadc-core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/xilinx-xadc
obtained SDHC tuned tap value.
Signed-off-by: Manish Narani
---
.../devicetree/bindings/mmc/arasan,sdhci.txt | 1 +
drivers/mmc/host/sdhci-of-arasan.c | 219 -
2 files changed, 219 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree
Ping
> -Original Message-
> From: Manish Narani
> Sent: Thursday, June 21, 2018 6:25 PM
> To: Adrian Hunter ; robh...@kernel.org;
> catalin.mari...@arm.com; will.dea...@arm.com; m...@kernel.org;
> stefan.krsmano...@aggios.com; linux-arm-ker...@lists.infradead
Ping for RFC
> -Original Message-
> From: Manish Narani [mailto:manish.nar...@xilinx.com]
> Sent: Thursday, June 7, 2018 5:42 PM
> To: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com;
> will.dea...@arm.com; m...@kernel.org; stefan.krsmano...@aggios.com;
Ping.
> -Original Message-
> From: Manish Narani [mailto:manish.nar...@xilinx.com]
> Sent: Saturday, August 4, 2018 2:56 PM
> To: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com;
> will.dea...@arm.com; Michal Simek ; b...@alien8.de;
> mche...@kernel.or
Ping.
> -Original Message-
> From: Manish Narani [mailto:manish.nar...@xilinx.com]
> Sent: Saturday, August 4, 2018 2:56 PM
> To: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com;
> will.dea...@arm.com; Michal Simek ; b...@alien8.de;
> mche...@kernel.or
Hi Boris,
> -Original Message-
> From: Borislav Petkov [mailto:b...@alien8.de]
> Sent: Tuesday, November 6, 2018 3:34 PM
> To: Manish Narani
> Cc: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek
> ; mche...@kernel.org; amit.kuche...@linaro.org;
> sudeep.h
Add macro defines for ZynqMP DDR controller. These macros will be used
for ZynqMP ECC operations.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 168 +++
1 file changed, 168 insertions(+)
diff --git a/drivers/edac/synopsys_edac.c b
r return value of of_device_get_match_data() function
in (1/6).
- From v8 the first 5 patches are removed in this series as they are
applied on:
https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/?h=edac-for-4.20-synps
- Updated Kconfig to che
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for
corrected and uncorrected errors. Add interrupt handlers for the same.
Signed-off-by: Manish Narani
---
drivers/edac/Kconfig | 2 +-
drivers/edac/synopsys_edac.c | 324
Add ddrc memory controller node in dts. The size mentioned in dts is
0x3, because we need to access DDR_QOS INTR registers located at
0xFD090208 from this driver.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git
Add support for Error Injection for ZynqMP DDRC IP. For injecting
errors, the Row, Column, Bank, Bank Group and Rank bits positions are
determined via Address Map registers of Synopsys DDRC.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 420
The function of_device_get_match_data() can return NULL in case of
error. Add error handling for the same in probe().
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
Add information of ZynqMP DDRC which reports the single bit errors that
are corrected and the double bit errors that are detected.
Signed-off-by: Manish Narani
Reviewed-by: Rob Herring
---
.../bindings/memory-controllers/synopsys.txt | 27 ++
1 file changed, 22
Modify the driver with some changes for code clean up. Update the debug
messages for EDAC errors reported. Increase the indentation of the
macros for better readability.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 104 +--
1 file
The current driver has functions which are always returning 0. Those
functions can be modified to void.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/edac/synopsys_edac.c b
Add platform specific structures, so that we can add different IP
support later using quirks.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 91 +++-
1 file changed, 65 insertions(+), 26 deletions(-)
diff --git a/drivers/edac
Add ddrc memory controller node in dts. The size mentioned in dts is
0x3, because we need to access DDR_QOS INTR registers located at
0xFD090208 from this driver.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git
Rename the static functions to a shorter name. Since this is Synopsys
EDAC driver, better to remove unnecessary 'synps_' prefix in function
names.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 56 ++--
1 file changed, 28
Add support for Error Injection for ZynqMP DDRC IP. For injecting
errors, the Row, Column, Bank, Bank Group and Rank bits positions are
determined via Address Map registers of Synopsys DDRC.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 421
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for
corrected and uncorrected errors. Add interrupt handlers for the same.
Signed-off-by: Manish Narani
---
drivers/edac/Kconfig | 2 +-
drivers/edac/synopsys_edac.c | 328
Add information of ZynqMP DDRC which reports the single bit errors that
are corrected and the double bit errors that are detected.
Signed-off-by: Manish Narani
Reviewed-by: Rob Herring
---
.../bindings/memory-controllers/synopsys.txt | 27 ++
1 file changed, 22
Too many parentheses' review comment in patch (5)
- Corrected comments as per the v7 review feedback
- Made dedicated functions for IRQ setup, IRQ enable and IRQ disable in
patch (8)
- Addressed review comments in patch (10)
Manish Narani (10):
edac: synopsys:
Add macro defines for ZynqMP DDR controller. These macros will be used
for ZynqMP ECC operations.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 168 +++
1 file changed, 168 insertions(+)
diff --git a/drivers/edac/synopsys_edac.c b
There are some comments which can be updated for better readability of
the driver. Update abbreviations to capital letters in the comments.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 98 ++--
1 file changed, 48 insertions(+), 50
4, 2018 at 09:05:20PM +0530, Manish Narani wrote:
> > Rename the static functions to a shorter name. Since this is Synopsys
> > EDAC driver, better to remove unnecessary 'synps_' prefix in function
> > names.
> >
> > Signed-off-by:
Ping!
> -Original Message-
> From: Manish Narani [mailto:manish.nar...@xilinx.com]
> Sent: Thursday, October 25, 2018 11:37 AM
> To: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek
> ; b...@alien8.de; mche...@kernel.org; Manish Narani
> ; amit.kuche...@lin
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for
corrected and uncorrected errors. Add interrupt handlers for the same.
Signed-off-by: Manish Narani
---
drivers/edac/Kconfig | 2 +-
drivers/edac/synopsys_edac.c | 322
Add information of ZynqMP DDRC which reports the single bit errors that
are corrected and the double bit errors that are detected.
Signed-off-by: Manish Narani
Reviewed-by: Rob Herring
---
.../bindings/memory-controllers/synopsys.txt | 27 ++
1 file changed, 22
check for ARCH_ZYNQMP instead of ARM64
Change in v10:
- Moved the checking for ce_cnt and ue_cnt before the readl() call
- Aligned arguments on the opening brace in setup_irq()
Manish Narani (6):
edac: synopsys: Add error handling for NULL in probe()
dt: bindings: Document ZynqMP
The function of_device_get_match_data() can return NULL in case of
error. Add error handling for the same in probe().
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
Add support for Error Injection for ZynqMP DDRC IP. For injecting
errors, the Row, Column, Bank, Bank Group and Rank bits positions are
determined via Address Map registers of Synopsys DDRC.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 420
Add macro defines for ZynqMP DDR controller. These macros will be used
for ZynqMP ECC operations.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 168 +++
1 file changed, 168 insertions(+)
diff --git a/drivers/edac/synopsys_edac.c b
Add ddrc memory controller node in dts. The size mentioned in dts is
0x3, because we need to access DDR_QOS INTR registers located at
0xFD090208 from this driver.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git
- Splitted the patches according to functionalities
- Addressed code style comments from v5 review
- Moved the Error Injection to CONFIG_EDAC_DEBUG mode
Manish Narani (6):
edac: synopsys: Fix code comments and naming convention
edac: synps: Add platform specific structures f
Update the comments in the Synopsys EDAC driver. Minor changes to function
names and return types are also included.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 176 ---
1 file changed, 80 insertions(+), 96 deletions(-)
diff --git a
Add support for Error Injection for ZynqMP DDRC IP. For injecting
errors, the Row, Column, Bank, Bank Group and Rank bits positions are
determined via Address Map registers of Synopsys DDRC.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 423
Add information of ZynqMP DDRC which reports the single bit errors that
are corrected and the double bit errors that are detected.
Signed-off-by: Manish Narani
Reviewed-by: Rob Herring
---
.../bindings/memory-controllers/synopsys.txt | 27 ++
1 file changed, 22
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for
corrected and uncorrected errors. Add interrupt handlers for the same.
Signed-off-by: Manish Narani
---
drivers/edac/Kconfig | 2 +-
drivers/edac/synopsys_edac.c | 304
Add platform specific structures, so that we can add different IP
support later using quirks.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 91 +++-
1 file changed, 65 insertions(+), 26 deletions(-)
diff --git a/drivers/edac
Add macro defines for ZynqMP DDR controller. These macros will be used
for ZyqnMP ECC operations.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 168 +++
1 file changed, 168 insertions(+)
diff --git a/drivers/edac/synopsys_edac.c b
- Splitted the patches according to functionalities
- Addressed code style comments from v5 review
- Moved the Error Injection to CONFIG_EDAC_DEBUG mode
Changes in v7:
- Included DTS patch (6/7) which was missed in v6 patch set
Manish Narani (7):
edac: synopsys: Fix
Update the comments in the Synopsys EDAC driver. Minor changes to function
names and return types are also included.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 176 ---
1 file changed, 80 insertions(+), 96 deletions(-)
diff --git a
Add platform specific structures, so that we can add different IP
support later using quirks.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 91 +++-
1 file changed, 65 insertions(+), 26 deletions(-)
diff --git a/drivers/edac
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for
corrected and uncorrected errors. Add interrupt handlers for the same.
Signed-off-by: Manish Narani
---
drivers/edac/Kconfig | 2 +-
drivers/edac/synopsys_edac.c | 304
Add ddrc memory controller node in dts. The size mentioned in dts is
0x3, because we need to access DDR_QOS INTR registers located at
0xFD090208 from this driver.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git
Add support for Error Injection for ZynqMP DDRC IP. For injecting
errors, the Row, Column, Bank, Bank Group and Rank bits positions are
determined via Address Map registers of Synopsys DDRC.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 423
Add information of ZynqMP DDRC which reports the single bit errors that
are corrected and the double bit errors that are detected.
Signed-off-by: Manish Narani
Reviewed-by: Rob Herring
---
.../bindings/memory-controllers/synopsys.txt | 27 ++
1 file changed, 22
Add macro defines for ZynqMP DDR controller. These macros will be used
for ZyqnMP ECC operations.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 168 +++
1 file changed, 168 insertions(+)
diff --git a/drivers/edac/synopsys_edac.c b
This series of patches are created On top of the
below series of patches.
https://lkml.org/lkml/2018/8/3/687
Manish Narani (4):
firmware: xilinx: Add SD Node and DLL Reset Data APIs
dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller
mmc: sdhci-of-arasan: Add a
Add support of SD auto tuning for ZynqMP platform. Before tuning
execution, reset the DLL and after the auto tuning process gets
completed, reset the DLL to load the newly obtained SDHC tuned tap
value.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 83
Add ZynqMP firmware SD Node data API to be used in call from SDHCI
driver. Also add DLL Reset data API to used for DLL reset calls from any
drivers.
Signed-off-by: Manish Narani
---
include/linux/firmware/xlnx-zynqmp.h | 12
1 file changed, 12 insertions(+)
diff --git a/include
Mainline kernel has arasan compatible string now. Append this new
compatible string for ZynqMP SDHCI controller. Also add a required
property indicating ZynqMP SDHCI controller device ID.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 6 --
1 file changed, 4
Add documentation for 'xlnx,zynqmp-8.9a' SDHCI controller and required
properties followed by example.
Signed-off-by: Manish Narani
---
Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 14 ++
1 file changed, 14 insertions(+)
diff --git a/Documentation/devicetre
Add runtime PM support in Arasan SDHCI driver.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 80 +-
1 file changed, 78 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c
b/drivers/mmc/host/sdhci-of-arasan.c
This patch adds support for using devm_ functions for requesting irq.
This will let the core free irq itself whenever the error condition
happens in probe or when xadc_remove is called.
Signed-off-by: Manish Narani
---
drivers/iio/adc/xilinx-xadc-core.c | 18 +++---
1 file changed
This patch removes dead code from xadc_zynq_setup. The condition
"if (tck_rate > XADC_ZYNQ_TCK_RATE_MAX)" cannot be true at any point of
time. There is also an incompatible parameter used in the code.
This patch fixes the same reported by coverity.
Signed-off-by: Manish Narani
---
This patch adds check for return values from clock related functions.
This was reported by static code analysis tool.
Signed-off-by: Manish Narani
---
drivers/iio/adc/xilinx-xadc-core.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc
This patch series resolves code style problems as reported by code analysis
tools.
Manish Narani (4):
iio: adc: xilinx: Rename 'channels' variable name to
'iio_xadc_channels'
iio: adc: xilinx: Remove dead code from xadc_zynq_setup
iio: adc: xilinx: Check for return v
This patch fix the following checkpatch warning in xadc driver.
- Reusing the krealloc arg is almost always a bug.
Renamed the 'channels' variable as 'iio_xadc_channels' to fix the above
warning.
Signed-off-by: Manish Narani
---
drivers/iio/adc/xilinx-xadc-core.c | 16
Hi Lars,
> -Original Message-
> From: Lars-Peter Clausen [mailto:l...@metafoo.de]
> Sent: Wednesday, July 18, 2018 4:49 PM
> To: Manish Narani ; ji...@kernel.org;
> knaac...@gmx.de; pme...@pmeerw.net; Michal Simek
> ; linux-...@vger.kernel.org; linux-arm-
> ker..
);
...
}
$ ./scripts/checkpatch.pl -f file.c
WARNING: Reusing the krealloc arg is almost always a bug
+ abc.def_var = krealloc(def_var, sizeof(*def_var),
This patch resolves the above false warning.
Signed-off-by: Manish Narani
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion
1 - 100 of 254 matches
Mail list logo