RE: [PATCH v3 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-03 Thread Manish Narani
Hi Boris, > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, August 4, 2018 10:49 AM > Subject: Re: [PATCH v3 1/4] edac: synps: Add platform specific structures for > ddrc controller > > On Thu, Aug 02, 2018 at 06:21:19PM +0530

[PATCH v4 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-04 Thread Manish Narani
Add platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 83 ++-- 1 file changed, 65 insertions(+), 18 deletions(-) diff --git a/drivers/edac

[PATCH v4 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-08-04 Thread Manish Narani
This patch adds information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22 insertions(+), 5

[PATCH v4 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-04 Thread Manish Narani
Add EDAC ECC support for ZynqMP DDRC IP. Also add support for ECC Error Injection in ZynqMP. The corrected and uncorrected error interrupts support is added. The Row, Column, Bank, Bank Group and Rank bits positions are determined via Address Map registers of Synopsys DDRC. Signed-off-by: Manish

[PATCH v4 4/4] arm64: zynqmp: Add DDRC node

2018-08-04 Thread Manish Narani
This patch adds ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at fd090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions

[PATCH v4 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-04 Thread Manish Narani
v4: - Updated the commit message in (1/4) - Renamed function pointer names removing 'synps_' in (1/4) - Shortened unnecessary long lines as per the review comment on (1/4) Manish Narani (4): edac: synps: Add platform specific structures for ddrc controller dt: bindi

RE: [PATCH v4 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-06 Thread Manish Narani
Hi Boris, > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, August 4, 2018 10:03 PM > Subject: Re: [PATCH v4 0/4] EDAC: Enhancements to Synopsys EDAC driver > > On Sat, Aug 04, 2018 at 02:55:31PM +0530, Manish Narani wrote: >

RE: [RFC PATCH 2/3] dt: bindings: Add SD tap value properties details

2018-06-21 Thread Manish Narani
Hi Mark, > -Original Message- > From: Mark Rutland [mailto:mark.rutl...@arm.com] > Sent: Thursday, June 7, 2018 6:18 PM > To: Manish Narani > Cc: robh...@kernel.org; catalin.mari...@arm.com; will.dea...@arm.com; > m...@kernel.org; stefan.krsmano...@aggios.com

RE: [RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-06-21 Thread Manish Narani
Hi Adrian, > -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Tuesday, June 19, 2018 5:08 PM > To: Manish Narani ; robh...@kernel.org; > catalin.mari...@arm.com; will.dea...@arm.com; m...@kernel.org; > stefan.krsmano...@aggios.

[PATCH 0/3] Add Xilinx AMS Driver

2018-08-30 Thread Manish Narani
f AMS, PS, PL Sysmon Channels. Manish Narani (3): dt-bindings: iio: adc: Add Xilinx AMS binding documentation iio: adc: Add Xilinx AMS driver arm64: zynqmp: DT: Add Xilinx AMS node .../devicetree/bindings/iio/adc/xilinx-ams.txt | 159 +++ arch/arm64/boot/dts/xilinx/zynqmp.dtsi

[PATCH 3/3] arm64: zynqmp: DT: Add Xilinx AMS node

2018-08-30 Thread Manish Narani
The Xilinx AMS includes an ADC as well as on-chip sensors that can be used to sample external and monitor on-die operating conditions, such as temperature and supply voltage levels. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 26 ++ 1 file

[PATCH 2/3] iio: adc: Add Xilinx AMS driver

2018-08-30 Thread Manish Narani
channels for measuring external voltages. The voltage and temperature monitoring channels also have event capability which allows to generate an interrupt when their value falls below or raises above a set threshold. Signed-off-by: Manish Narani --- drivers/iio/adc/Kconfig | 10 + drivers

[PATCH 1/3] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2018-08-30 Thread Manish Narani
Xilinx AMS have several ADC channels that can be used for measurement of different voltages and temperatures. Document the same in the bindings. Signed-off-by: Manish Narani --- .../devicetree/bindings/iio/adc/xilinx-ams.txt | 159 + 1 file changed, 159 insertions

RE: [PATCH v4 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-22 Thread Manish Narani
Hi Boris, Thank you so much for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, August 21, 2018 6:37 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm

RE: [PATCH v4 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-22 Thread Manish Narani
Hi Boris, Thanks a lot for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, August 21, 2018 6:40 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; Mic

RE: [PATCH v2 2/4] iio: adc: xilinx: limit pcap clock frequency value

2018-07-30 Thread Manish Narani
Hi Jonathan, > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: Sunday, July 29, 2018 5:21 PM > To: Manish Narani > Cc: Sai Krishna Potthuri ; Michal Simek > ; pme...@pmeerw.net; l...@metafoo.de; > knaac...@gmx.de; Anirudha Sarangi ; Sr

[PATCH 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-07-19 Thread Manish Narani
This patch documents Synopsys EDAC driver which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 25 ++ 1 file changed, 21 insertions(+), 4

[PATCH 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-07-19 Thread Manish Narani
This patch adds platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 70 1 file changed, 58 insertions(+), 12 deletions(-) diff --git a/drivers/edac

[PATCH 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-07-19 Thread Manish Narani
Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 848 ++- 2 files changed, 833 insertions(+), 17 deletions(-) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 57304b2

[PATCH 4/4] arm64: zynqmp: Add DDRC node

2018-07-19 Thread Manish Narani
This patch adds ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at fd090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions

[PATCH 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-07-19 Thread Manish Narani
This patch series enhances the current EDAC driver to support different platforms.This series adds support for ZynqMP DDRC controller in synopsys EDAC driver. This series also adds Device tree properties and relevant binding documentation. Manish Narani (4): edac: synps: Add platform specific

RE: [RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-07-19 Thread Manish Narani
Hi Uffe, > -Original Message- > From: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Tuesday, July 10, 2018 2:02 PM > To: Manish Narani > Cc: Rob Herring ; Mark Rutland > ; Catalin Marinas ; Will > Deacon ; Moritz Fischer ; > stefan.krsmano...@ag

RE: [PATCH 4/4] iio: adc: xilinx: Use devm_ functions while requesting irq

2018-07-23 Thread Manish Narani
Hi Lars, > -Original Message- > From: Lars-Peter Clausen [mailto:l...@metafoo.de] > Sent: Thursday, July 19, 2018 10:08 PM > To: Manish Narani ; ji...@kernel.org; > knaac...@gmx.de; pme...@pmeerw.net; Michal Simek > ; linux-...@vger.kernel.org; linux-arm- > ker..

RE: [PATCH 3/4] iio: adc: xilinx: Check for return values in clk related functions

2018-07-23 Thread Manish Narani
Hi Jonathan, Thanks for your comments. > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: Saturday, July 21, 2018 9:54 PM > To: Lars-Peter Clausen > Cc: Manish Narani ; knaac...@gmx.de; > pme...@pmeerw.net; Michal Simek ; linux- > i...@v

[PATCH v2 4/4] arm64: zynqmp: Add DDRC node

2018-08-02 Thread Manish Narani
This patch adds ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at fd090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions

[PATCH v2 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-02 Thread Manish Narani
DDR_ECC_INTR_SUPPORT from (1/4) to (3/4) as it is a feature of ZynqMP DDRC - The Binding Documentation in (2/4) is modified as per the review comments Manish Narani (4): edac: synps: Add platform specific structures for ddrc controller dt: bindings: Document ZynqMP DDRC in

[PATCH v2 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-08-02 Thread Manish Narani
This patch documents Synopsys EDAC driver which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22 insertions(+), 5

[PATCH v2 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-02 Thread Manish Narani
This patch adds platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 64 1 file changed, 53 insertions(+), 11 deletions(-) diff --git a/drivers/edac

[PATCH v2 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-02 Thread Manish Narani
Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 857 ++- 2 files changed, 841 insertions(+), 18 deletions(-) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 57304b2

[PATCH v3 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-02 Thread Manish Narani
This patch adds platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 64 1 file changed, 53 insertions(+), 11 deletions(-) diff --git a/drivers/edac

[PATCH v3 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-02 Thread Manish Narani
DDR_ECC_INTR_SUPPORT from (1/4) to (3/4) as it is a feature of ZynqMP DDRC - The Binding Documentation in (2/4) is modified as per the review comments Changes in v3: - The commit message in (2/4) is modified (Synopsys EDAC Driver --> ZynqMP DDRC) Manish Narani

[PATCH v3 4/4] arm64: zynqmp: Add DDRC node

2018-08-02 Thread Manish Narani
This patch adds ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at fd090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions

[PATCH v3 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-02 Thread Manish Narani
Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 857 ++- 2 files changed, 841 insertions(+), 18 deletions(-) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 57304b2

[PATCH v3 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-08-02 Thread Manish Narani
This patch adds information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22 insertions(+), 5

[PATCH v2 2/4] iio: adc: xilinx: limit pcap clock frequency value

2018-07-23 Thread Manish Narani
of XADC_CFG register to make timings better in the interface. So to avoid alteration of these bits every time, the pcap value should not cross the Fmax limit. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a

[PATCH v2 1/4] iio: adc: xilinx: Check for return values in clk related functions

2018-07-23 Thread Manish Narani
This patch adds check for return values from clock related functions. This was reported by static code analysis tool. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc

[PATCH v2 3/4] iio: adc: xilinx: Remove platform_get_irq from xadc_remove function

2018-07-23 Thread Manish Narani
Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 10 +- drivers/iio/adc/xilinx-xadc.h | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index 0dd306d..44a2519 100644 --- a/dr

[PATCH v2 0/4] iio: adc: xilinx: XADC driver Enhancements and bug fixes

2018-07-23 Thread Manish Narani
interrupts. Manish Narani (4): iio: adc: xilinx: Check for return values in clk related functions iio: adc: xilinx: limit pcap clock frequency value iio: adc: xilinx: Remove platform_get_irq from xadc_remove function iio: adc: xilinx: Move request_irq before enabling interrupts drivers/iio

[PATCH v2 4/4] iio: adc: xilinx: Move request_irq before enabling interrupts

2018-07-23 Thread Manish Narani
Enabling the Interrupts before registering the irq handler is a bad idea. This patch corrects the same for XADC driver. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc

[RFC PATCH] mmc: sdhci-of-arasan: Add auto tuning support for ZynqMP Platform

2018-01-30 Thread Manish Narani
obtained SDHC tuned tap value. Signed-off-by: Manish Narani --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 1 + drivers/mmc/host/sdhci-of-arasan.c | 219 - 2 files changed, 219 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree

RE: [RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-07-09 Thread Manish Narani
Ping > -Original Message- > From: Manish Narani > Sent: Thursday, June 21, 2018 6:25 PM > To: Adrian Hunter ; robh...@kernel.org; > catalin.mari...@arm.com; will.dea...@arm.com; m...@kernel.org; > stefan.krsmano...@aggios.com; linux-arm-ker...@lists.infradead

RE: [RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-06-13 Thread Manish Narani
Ping for RFC > -Original Message- > From: Manish Narani [mailto:manish.nar...@xilinx.com] > Sent: Thursday, June 7, 2018 5:42 PM > To: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; m...@kernel.org; stefan.krsmano...@aggios.com;

RE: [PATCH v4 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-18 Thread Manish Narani
Ping. > -Original Message- > From: Manish Narani [mailto:manish.nar...@xilinx.com] > Sent: Saturday, August 4, 2018 2:56 PM > To: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; Michal Simek ; b...@alien8.de; > mche...@kernel.or

RE: [PATCH v4 4/4] arm64: zynqmp: Add DDRC node

2018-08-18 Thread Manish Narani
Ping. > -Original Message- > From: Manish Narani [mailto:manish.nar...@xilinx.com] > Sent: Saturday, August 4, 2018 2:56 PM > To: robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; Michal Simek ; b...@alien8.de; > mche...@kernel.or

RE: [PATCH v10 0/6] EDAC: Enhancements to Synopsys EDAC driver

2018-11-06 Thread Manish Narani
Hi Boris, > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, November 6, 2018 3:34 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek > ; mche...@kernel.org; amit.kuche...@linaro.org; > sudeep.h

[PATCH v9 3/6] edac: synopsys: Add macro defines for ZynqMP DDRC

2018-10-14 Thread Manish Narani
Add macro defines for ZynqMP DDR controller. These macros will be used for ZynqMP ECC operations. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 168 +++ 1 file changed, 168 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b

[PATCH v9 0/6] EDAC: Enhancements to Synopsys EDAC driver

2018-10-14 Thread Manish Narani
r return value of of_device_get_match_data() function in (1/6). - From v8 the first 5 patches are removed in this series as they are applied on: https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/?h=edac-for-4.20-synps - Updated Kconfig to che

[PATCH v9 4/6] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-10-14 Thread Manish Narani
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for corrected and uncorrected errors. Add interrupt handlers for the same. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 324

[PATCH v9 5/6] arm64: zynqmp: Add DDRC node

2018-10-14 Thread Manish Narani
Add ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at 0xFD090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v9 6/6] edac: synopsys: Add Error Injection support for ZynqMP DDRC

2018-10-14 Thread Manish Narani
Add support for Error Injection for ZynqMP DDRC IP. For injecting errors, the Row, Column, Bank, Bank Group and Rank bits positions are determined via Address Map registers of Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 420

[PATCH v9 1/6] edac: synopsys: Add error handling for NULL in probe()

2018-10-14 Thread Manish Narani
The function of_device_get_match_data() can return NULL in case of error. Add error handling for the same in probe(). Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c

[PATCH v9 2/6] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-10-14 Thread Manish Narani
Add information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22

[PATCH v8 01/10] edac: synopsys: Update the driver code for better readability

2018-10-04 Thread Manish Narani
Modify the driver with some changes for code clean up. Update the debug messages for EDAC errors reported. Increase the indentation of the macros for better readability. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 104 +-- 1 file

[PATCH v8 04/10] edac: synopsys: Make return type void for functions always returning 0

2018-10-04 Thread Manish Narani
The current driver has functions which are always returning 0. Those functions can be modified to void. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b

[PATCH v8 05/10] edac: synps: Add platform specific structures for ddrc controller

2018-10-04 Thread Manish Narani
Add platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 91 +++- 1 file changed, 65 insertions(+), 26 deletions(-) diff --git a/drivers/edac

[PATCH v8 09/10] arm64: zynqmp: Add DDRC node

2018-10-04 Thread Manish Narani
Add ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at 0xFD090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v8 02/10] edac: synopsys: Rename the static functions to a shorter name

2018-10-04 Thread Manish Narani
Rename the static functions to a shorter name. Since this is Synopsys EDAC driver, better to remove unnecessary 'synps_' prefix in function names. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 56 ++-- 1 file changed, 28

[PATCH v8 10/10] edac: synopsys: Add Error Injection support for ZynqMP DDRC

2018-10-04 Thread Manish Narani
Add support for Error Injection for ZynqMP DDRC IP. For injecting errors, the Row, Column, Bank, Bank Group and Rank bits positions are determined via Address Map registers of Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 421

[PATCH v8 08/10] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-10-04 Thread Manish Narani
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for corrected and uncorrected errors. Add interrupt handlers for the same. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 328

[PATCH v8 06/10] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-10-04 Thread Manish Narani
Add information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22

[PATCH v8 00/10] EDAC: Enhancements to Synopsys EDAC driver

2018-10-04 Thread Manish Narani
Too many parentheses' review comment in patch (5) - Corrected comments as per the v7 review feedback - Made dedicated functions for IRQ setup, IRQ enable and IRQ disable in patch (8) - Addressed review comments in patch (10) Manish Narani (10): edac: synopsys:

[PATCH v8 07/10] edac: synopsys: Add macro defines for ZynqMP DDRC

2018-10-04 Thread Manish Narani
Add macro defines for ZynqMP DDR controller. These macros will be used for ZynqMP ECC operations. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 168 +++ 1 file changed, 168 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b

[PATCH v8 03/10] edac: synopsys: Modify the comments in the driver

2018-10-04 Thread Manish Narani
There are some comments which can be updated for better readability of the driver. Update abbreviations to capital letters in the comments. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 98 ++-- 1 file changed, 48 insertions(+), 50

RE: [PATCH v8 02/10] edac: synopsys: Rename the static functions to a shorter name

2018-10-08 Thread Manish Narani
4, 2018 at 09:05:20PM +0530, Manish Narani wrote: > > Rename the static functions to a shorter name. Since this is Synopsys > > EDAC driver, better to remove unnecessary 'synps_' prefix in function > > names. > > > > Signed-off-by:

RE: [PATCH v10 0/6] EDAC: Enhancements to Synopsys EDAC driver

2018-11-02 Thread Manish Narani
Ping! > -Original Message- > From: Manish Narani [mailto:manish.nar...@xilinx.com] > Sent: Thursday, October 25, 2018 11:37 AM > To: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek > ; b...@alien8.de; mche...@kernel.org; Manish Narani > ; amit.kuche...@lin

[PATCH v10 4/6] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-10-24 Thread Manish Narani
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for corrected and uncorrected errors. Add interrupt handlers for the same. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 322

[PATCH v10 2/6] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-10-24 Thread Manish Narani
Add information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22

[PATCH v10 0/6] EDAC: Enhancements to Synopsys EDAC driver

2018-10-24 Thread Manish Narani
check for ARCH_ZYNQMP instead of ARM64 Change in v10: - Moved the checking for ce_cnt and ue_cnt before the readl() call - Aligned arguments on the opening brace in setup_irq() Manish Narani (6): edac: synopsys: Add error handling for NULL in probe() dt: bindings: Document ZynqMP

[PATCH v10 1/6] edac: synopsys: Add error handling for NULL in probe()

2018-10-24 Thread Manish Narani
The function of_device_get_match_data() can return NULL in case of error. Add error handling for the same in probe(). Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c

[PATCH v10 6/6] edac: synopsys: Add Error Injection support for ZynqMP DDRC

2018-10-24 Thread Manish Narani
Add support for Error Injection for ZynqMP DDRC IP. For injecting errors, the Row, Column, Bank, Bank Group and Rank bits positions are determined via Address Map registers of Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 420

[PATCH v10 3/6] edac: synopsys: Add macro defines for ZynqMP DDRC

2018-10-24 Thread Manish Narani
Add macro defines for ZynqMP DDR controller. These macros will be used for ZynqMP ECC operations. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 168 +++ 1 file changed, 168 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b

[PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-10-24 Thread Manish Narani
Add ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at 0xFD090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v6 0/6] EDAC: Enhancements to Synopsys EDAC driver

2018-09-17 Thread Manish Narani
- Splitted the patches according to functionalities - Addressed code style comments from v5 review - Moved the Error Injection to CONFIG_EDAC_DEBUG mode Manish Narani (6): edac: synopsys: Fix code comments and naming convention edac: synps: Add platform specific structures f

[PATCH v6 1/6] edac: synopsys: Fix code comments and naming convention

2018-09-17 Thread Manish Narani
Update the comments in the Synopsys EDAC driver. Minor changes to function names and return types are also included. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 176 --- 1 file changed, 80 insertions(+), 96 deletions(-) diff --git a

[PATCH v6 6/6] edac: synopsys: Add Error Injection support for ZynqMP DDRC

2018-09-17 Thread Manish Narani
Add support for Error Injection for ZynqMP DDRC IP. For injecting errors, the Row, Column, Bank, Bank Group and Rank bits positions are determined via Address Map registers of Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 423

[PATCH v6 3/6] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-09-17 Thread Manish Narani
Add information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22

[PATCH v6 5/6] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-09-17 Thread Manish Narani
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for corrected and uncorrected errors. Add interrupt handlers for the same. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 304

[PATCH v6 2/6] edac: synps: Add platform specific structures for ddrc controller

2018-09-17 Thread Manish Narani
Add platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 91 +++- 1 file changed, 65 insertions(+), 26 deletions(-) diff --git a/drivers/edac

[PATCH v6 4/6] edac: synopsys: Add macro defines for ZynqMP DDRC

2018-09-17 Thread Manish Narani
Add macro defines for ZynqMP DDR controller. These macros will be used for ZyqnMP ECC operations. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 168 +++ 1 file changed, 168 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b

[PATCH v7 0/7] EDAC: Enhancements to Synopsys EDAC driver

2018-09-17 Thread Manish Narani
- Splitted the patches according to functionalities - Addressed code style comments from v5 review - Moved the Error Injection to CONFIG_EDAC_DEBUG mode Changes in v7: - Included DTS patch (6/7) which was missed in v6 patch set Manish Narani (7): edac: synopsys: Fix

[PATCH v7 1/7] edac: synopsys: Fix code comments and naming convention

2018-09-17 Thread Manish Narani
Update the comments in the Synopsys EDAC driver. Minor changes to function names and return types are also included. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 176 --- 1 file changed, 80 insertions(+), 96 deletions(-) diff --git a

[PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller

2018-09-17 Thread Manish Narani
Add platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 91 +++- 1 file changed, 65 insertions(+), 26 deletions(-) diff --git a/drivers/edac

[PATCH v7 5/7] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-09-17 Thread Manish Narani
Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts for corrected and uncorrected errors. Add interrupt handlers for the same. Signed-off-by: Manish Narani --- drivers/edac/Kconfig | 2 +- drivers/edac/synopsys_edac.c | 304

[PATCH v7 6/7] arm64: zynqmp: Add DDRC node

2018-09-17 Thread Manish Narani
Add ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at 0xFD090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v7 7/7] edac: synopsys: Add Error Injection support for ZynqMP DDRC

2018-09-17 Thread Manish Narani
Add support for Error Injection for ZynqMP DDRC IP. For injecting errors, the Row, Column, Bank, Bank Group and Rank bits positions are determined via Address Map registers of Synopsys DDRC. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 423

[PATCH v7 3/7] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-09-17 Thread Manish Narani
Add information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22

[PATCH v7 4/7] edac: synopsys: Add macro defines for ZynqMP DDRC

2018-09-17 Thread Manish Narani
Add macro defines for ZynqMP DDR controller. These macros will be used for ZyqnMP ECC operations. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 168 +++ 1 file changed, 168 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b

[RFC PATCH 0/4] Add auto tuning support for ZynqMP SDHCI controller

2018-09-18 Thread Manish Narani
This series of patches are created On top of the below series of patches. https://lkml.org/lkml/2018/8/3/687 Manish Narani (4): firmware: xilinx: Add SD Node and DLL Reset Data APIs dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller mmc: sdhci-of-arasan: Add a

[RFC PATCH 3/4] mmc: sdhci-of-arasan: Add auto tuning support for ZynqMP platform

2018-09-18 Thread Manish Narani
Add support of SD auto tuning for ZynqMP platform. Before tuning execution, reset the DLL and after the auto tuning process gets completed, reset the DLL to load the newly obtained SDHC tuned tap value. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 83

[RFC PATCH 1/4] firmware: xilinx: Add SD Node and DLL Reset Data APIs

2018-09-18 Thread Manish Narani
Add ZynqMP firmware SD Node data API to be used in call from SDHCI driver. Also add DLL Reset data API to used for DLL reset calls from any drivers. Signed-off-by: Manish Narani --- include/linux/firmware/xlnx-zynqmp.h | 12 1 file changed, 12 insertions(+) diff --git a/include

[RFC PATCH 4/4] arm64: zynqmp: Add new SDHCI compatible string

2018-09-18 Thread Manish Narani
Mainline kernel has arasan compatible string now. Append this new compatible string for ZynqMP SDHCI controller. Also add a required property indicating ZynqMP SDHCI controller device ID. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 6 -- 1 file changed, 4

[RFC PATCH 2/4] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller

2018-09-18 Thread Manish Narani
Add documentation for 'xlnx,zynqmp-8.9a' SDHCI controller and required properties followed by example. Signed-off-by: Manish Narani --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetre

[PATCH] sdhci: arasan: Add runtime PM support

2018-09-18 Thread Manish Narani
Add runtime PM support in Arasan SDHCI driver. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 80 +- 1 file changed, 78 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c

[PATCH 4/4] iio: adc: xilinx: Use devm_ functions while requesting irq

2018-07-18 Thread Manish Narani
This patch adds support for using devm_ functions for requesting irq. This will let the core free irq itself whenever the error condition happens in probe or when xadc_remove is called. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 18 +++--- 1 file changed

[PATCH 2/4] iio: adc: xilinx: Remove dead code from xadc_zynq_setup

2018-07-18 Thread Manish Narani
This patch removes dead code from xadc_zynq_setup. The condition "if (tck_rate > XADC_ZYNQ_TCK_RATE_MAX)" cannot be true at any point of time. There is also an incompatible parameter used in the code. This patch fixes the same reported by coverity. Signed-off-by: Manish Narani ---

[PATCH 3/4] iio: adc: xilinx: Check for return values in clk related functions

2018-07-18 Thread Manish Narani
This patch adds check for return values from clock related functions. This was reported by static code analysis tool. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc

[PATCH 0/4] iio: adc: xilinx: XADC driver enhancements and bug fixes

2018-07-18 Thread Manish Narani
This patch series resolves code style problems as reported by code analysis tools. Manish Narani (4): iio: adc: xilinx: Rename 'channels' variable name to 'iio_xadc_channels' iio: adc: xilinx: Remove dead code from xadc_zynq_setup iio: adc: xilinx: Check for return v

[PATCH 1/4] iio: adc: xilinx: Rename 'channels' variable name to 'iio_xadc_channels'

2018-07-18 Thread Manish Narani
This patch fix the following checkpatch warning in xadc driver. - Reusing the krealloc arg is almost always a bug. Renamed the 'channels' variable as 'iio_xadc_channels' to fix the above warning. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 16

RE: [PATCH 1/4] iio: adc: xilinx: Rename 'channels' variable name to 'iio_xadc_channels'

2018-07-18 Thread Manish Narani
Hi Lars, > -Original Message- > From: Lars-Peter Clausen [mailto:l...@metafoo.de] > Sent: Wednesday, July 18, 2018 4:49 PM > To: Manish Narani ; ji...@kernel.org; > knaac...@gmx.de; pme...@pmeerw.net; Michal Simek > ; linux-...@vger.kernel.org; linux-arm- > ker..

[PATCH] checkpatch: Resolve improper warning for krealloc arg reuse

2018-07-18 Thread Manish Narani
); ... } $ ./scripts/checkpatch.pl -f file.c WARNING: Reusing the krealloc arg is almost always a bug + abc.def_var = krealloc(def_var, sizeof(*def_var), This patch resolves the above false warning. Signed-off-by: Manish Narani --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion

  1   2   3   >