[PATCH v3 2/2] regulator: pfuze100: add support to en-/disable switch regulators

2018-07-23 Thread Marco Felsch
switch""). Disabling the switch regulators will only be done if the user specifies "fsl,pfuze-support-disable-sw" in its device tree to keep backward compatibility with current dtb's [1]. [1] https://patchwork.kernel.org/patch/10490381/ Signed-off-by: Marco Felsch ---

[PATCH v3 1/2] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-23 Thread Marco Felsch
1/ Signed-off-by: Marco Felsch --- Changes in v3: - rename dt binding, add -sw suffix - fix description Changes in V2: - add more information about the binding - rename binding and add vendor prefix Documentation/devicetree/bindings/regulator/pfuze100.txt | 9 + 1 file

[PATCH v3 0/2] Re-Enable support to disable switch regulators

2018-07-23 Thread Marco Felsch
Repo: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git Branch: regulator/for-4.19 Regards, Marco [1] https://patchwork.kernel.org/patch/10490381/ [2] https://patchwork.kernel.org/patch/10500333/ Marco Felsch (2): dt-bindings: pfuze100: add optional disable switch-regulators bi

[PATCH 1/2] dt-bindings: pfuze100: add optional pfuze-disable-sw binding

2018-07-12 Thread Marco Felsch
1/ Signed-off-by: Marco Felsch --- Documentation/devicetree/bindings/regulator/pfuze100.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/pfuze100.txt b/Documentation/devicetree/bindings/regulator/pfuze100.txt index 672c939045ff..1f17ab7c7

[PATCH 0/2] Re-Enable support to disable switch regulators

2018-07-12 Thread Marco Felsch
Marks regulator repo, my patches are based on his repo too. Used Kernel: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git Branch: regulator/for-4.19 Regards, Marco [1] https://patchwork.kernel.org/patch/10490381/ [2] https://patchwork.kernel.org/patch/10500333/ Marco

[PATCH 2/2] regulator: pfuze100: add support to en-/disable switch regulators

2018-07-12 Thread Marco Felsch
m on. So it's more like a simulated disable. [1] https://patchwork.kernel.org/patch/10490381/ Signed-off-by: Marco Felsch --- Changes since https://patchwork.kernel.org/patch/10405723/ - Use DT property to keep backward compatibility - Use the default register val 0x8 as enable_val drivers/regul

Re: [PATCH 1/2] dt-bindings: pfuze100: add optional pfuze-disable-sw binding

2018-07-13 Thread Marco Felsch
Hi Fabio, On 18-07-12 12:19, Fabio Estevam wrote: > On Thu, Jul 12, 2018 at 8:02 AM, Marco Felsch wrote: > > > +Optional properties: > > +- pfuze-disable-sw: Disable all unused switch regulators to save power > > + consumption. Attention, some platforms are using the s

Re: [PATCH 1/2] dt-bindings: pfuze100: add optional pfuze-disable-sw binding

2018-07-13 Thread Marco Felsch
Hi Mark, On 18-07-12 16:31, Mark Brown wrote: > On Thu, Jul 12, 2018 at 01:02:39PM +0200, Marco Felsch wrote: > > > +Optional properties: > > +- pfuze-disable-sw: Disable all unused switch regulators to save power > > + consumption. Attention, some platforms are usi

[PATCH v2 2/3] regulator: pfuze100: add support to en-/disable switch regulators

2018-07-13 Thread Marco Felsch
switch""). Disabling the switch regulators will only be done if the user specifies "fsl,pfuze-support-disable" in its device tree to keep backward compatibility with current dtb's [1]. [1] https://patchwork.kernel.org/patch/10490381/ Signed-off-by: Marco Felsch --- Change

[PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-13 Thread Marco Felsch
1/ Signed-off-by: Marco Felsch --- Changes in V2: - add more information about the binding - rename binding and add vendor prefix .../devicetree/bindings/regulator/pfuze100.txt| 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/regulato

[PATCH v2 0/2] Re-Enable support to disable switch regulators

2018-07-13 Thread Marco Felsch
Repo: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git Branch: regulator/for-4.19 Regards, Marco [1] https://patchwork.kernel.org/patch/10490381/ [2] https://patchwork.kernel.org/patch/10500333/ Marco Felsch (3): dt-bindings: pfuze100: add optional disable switch-regul

[PATCH] regulator: core: fix _regulator_do_disable return value

2018-07-13 Thread Marco Felsch
7;t supported by the driver as it is done already by _regulator_do_enable. Signed-off-by: Marco Felsch --- drivers/regulator/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index bb1324f93143..69b4e096b632 100644 --- a/drivers/regulator/

Re: [PATCH] regulator: core: fix _regulator_do_disable return value

2018-07-13 Thread Marco Felsch
Hi Mark, tanks for the feedback. On 18-07-13 14:07, Mark Brown wrote: > On Fri, Jul 13, 2018 at 02:56:24PM +0200, Marco Felsch wrote: > > > Currently _regulator_do_disable returns 0 if either the ena_pin nor the > > ops.disbale() isn't present. This assumes that the call

Re: [PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-16 Thread Marco Felsch
Hi Mark, thanks for the review. On 18-07-13 16:03, Mark Brown wrote: > On Fri, Jul 13, 2018 at 02:50:01PM +0200, Marco Felsch wrote: > > > +Optional properties: > > +- fsl,pfuze-support-disable: Boolean, if present disable all unused switch > > + regulators to save powe

[PATCH] device property: fix fwnode_graph_get_next_endpoint documentation

2018-12-18 Thread Marco Felsch
Sync documentation with code. Fixes: 07bb80d40b0e ("device property: Add support for remote endpoints") Signed-off-by: Marco Felsch --- drivers/base/property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/property.c b/drivers/base/proper

Re: [PATCH] ASoC: max98988: add I2C dependency

2018-10-10 Thread Marco Felsch
rror] > sound/soc/codecs/max98088.c:1780:26: error: 'max98088_i2c_driver' defined but > not used [-Werror=unused-variable] > > Fixes: 24ae67c58250 ("ASoC: max98988: make it selectable") > Signed-off-by: Arnd Bergmann Thanks for covering the issue. Reviewed-by: Marco

Re: [PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-18 Thread Marco Felsch
Hi Rob, thanks for the review. I will integrate it in a v3. Regards, Marco On 18-07-16 11:55, Rob Herring wrote: > On Fri, Jul 13, 2018 at 02:50:01PM +0200, Marco Felsch wrote: > > This binding is used to keep the backward compatibility with the current > > dtb's [1]. The

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Marco Felsch
Hi Iuliana, On 23-09-12, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan > > Add the reserve-memory nodes used by DSP when the rpmsg > feature is enabled. > These can be later used in a dsp node, like: > dsp: dsp@3b6e8000 { > compatible = "fsl,imx8mp-dsp"; > reg = <0x3b6e8000 0x88

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Marco Felsch
On 23-09-12, Iuliana Prodan wrote: > On 9/12/2023 2:30 PM, Marco Felsch wrote: > > Hi Iuliana, > > > > On 23-09-12, Iuliana Prodan (OSS) wrote: > > > From: Iuliana Prodan > > > > > > Add the reserve-memory nodes used by DSP when the rpmsg > &g

Re: [PATCH v4 1/2] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-04-16 Thread Marco Felsch
Hi Agnus, On 19-04-15 16:53, Angus Ainslie (Purism) wrote: > This is the development kit board for the Librem 5. The current level of > support yields a working console and is able to boot userspace from the > Network or eMMC. > > Additional subsystems that are active : > > - Both USB ports > -

Re: [PATCH v4 0/2] Add support for the Purism Librem5 devkit

2019-04-16 Thread Marco Felsch
Hi Agnus, On 19-04-15 16:53, Angus Ainslie (Purism) wrote: > The Librem5 devkit is based on the imx8mq from NXP. This is a default > devicetree to boot the board to a command prompt. You should also provide a patch which adds the devicetree to the yaml file, see: Documentation/devicetree/bindings

Re: [PATCH v4 0/2] Add support for the Purism Librem5 devkit

2019-04-16 Thread Marco Felsch
On 19-04-16 09:38, Angus Ainslie wrote: > On 2019-04-16 00:58, Marco Felsch wrote: > > Hi Agnus, > > > > On 19-04-15 16:53, Angus Ainslie (Purism) wrote: > > > The Librem5 devkit is based on the imx8mq from NXP. This is a default > > > devicetre

Re: [PATCH v4 1/2] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-04-16 Thread Marco Felsch
Hi Angus, On 19-04-16 11:02, Angus Ainslie wrote: > Hi Marco, > > On 2019-04-16 00:54, Marco Felsch wrote: > > Hi Agnus, > > > > Just a nitpick but could you spell my name correctly :) Sorry it was to early that morning and I haven't had my first coffee. >

Re: [PATCH v4 1/2] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-04-16 Thread Marco Felsch
Hi Angus, On 19-04-16 16:36, Angus Ainslie wrote: > Hi Marco, > > On 2019-04-16 15:20, Marco Felsch wrote: > > Hi Angus, > > > > On 19-04-16 11:02, Angus Ainslie wrote: > > > Hi Marco, > > > > > > On 2019-04-16 00:54, Marco Felsch wrote:

Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-02 Thread Marco Felsch
Signed-off-by: Oliver Graute > Cc: Marco Felsch > Cc: Fabio Estevam > --- > > v3: > > - added flags > - added delay Thanks, did you test the changes? I just picked it from the datasheet. Regards, Marco

Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support

2021-01-28 Thread Marco Felsch
Hi Adrien, thanks for the patch. I've made only a few comments inline. On 21-01-18 12:15, Adrien Grassein wrote: > Tested with a basic Build Root configuration booting from sdcard. > > Signed-off-by: Adrien Grassein > Reviewed-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/freescale/Make

Re: [PATCH v2] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-01 Thread Marco Felsch
CAP-GLD-RGB.pdf > > Signed-off-by: Oliver Graute > Cc: Marco Felsch > Cc: Fabio Estevam > --- > > v2: > > - changed bpc to 6 > - set max value of pixelclock > - increased hfront_porch and hback_porch > - dropped connector-type > > adding of bus_f

Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-05 Thread Marco Felsch
On 21-02-04 19:15, Oliver Graute wrote: > On 02/02/21, Marco Felsch wrote: > > Hi Oliver, > > > > On 21-02-02 18:35, Oliver Graute wrote: > > > Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD > > > to panel-simple. > > > >

Re: [PATCH v3 2/3] Input: snvs_pwrkey - enable snvs clock as needed

2020-07-30 Thread Marco Felsch
Hi Dmitry, On 20-07-29 23:04, Dmitry Torokhov wrote: > On Wed, Jul 29, 2020 at 09:33:23AM +0200, Marco Felsch wrote: > > Hi, > > > > On 20-07-23 10:43, Horia Geantă wrote: > > > From: André Draszik > > > > > > At the moment, enabling this drive

Re: [PATCH v3 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events

2020-07-30 Thread Marco Felsch
Hi Dmitry, On 20-07-29 23:06, Dmitry Torokhov wrote: > Hi Marco, > > On Wed, Jul 29, 2020 at 09:55:13AM +0200, Marco Felsch wrote: > > Hi, > > > > On 20-07-23 10:43, Horia Geantă wrote: > > > From: André Draszik > > > > > > The snv

Re: [PATCH v5 3/4] ARM: dts: sun8i-a83t-tbs-a711: Add support for the vibrator motor

2020-07-30 Thread Marco Felsch
Hi Ondrej, On 20-07-30 15:24, Ondrej Jirman wrote: > The board has a vibrator motor. Hook it to the input subsystem. > > According to the PMIC specification, LDO needs to be enabled (value 0b11) > to achieve the specified max driving current of 150mA. We can't drive > the motor with just GPIO mod

Re: [PATCH v7 2/4] SFH: PCIe driver to add support of AMD sensor fusion hub

2020-08-11 Thread Marco Felsch
Hi Sandeep, On 20-08-10 21:30, Sandeep Singh wrote: > From: Sandeep Singh > > AMD SFH uses HID over PCIe bus.SFH fw is part of MP2 processor > (MP2 which is an ARM® Cortex-M4 core based co-processor to x86) and > it runs on MP2 where in driver resides on X86. This part of module > will communica

[PATCH] net: phy: smsc: fix clk error handling

2021-01-11 Thread Marco Felsch
fclk in support") Suggested-by: Jakub Kicinski Signed-off-by: Marco Felsch --- drivers/net/phy/smsc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 0fc39ac5ca88..10722fed666d 100644 --- a/drivers/net/phy/smsc.c +

Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

2021-03-19 Thread Marco Felsch
Hi Alistair, the patch looks quite good only a few notes inline. PS: It would be cool to have a log to previous patch versions. On 21-03-15 22:27, Alistair Francis wrote: ... > +&crypto { > + status = "disabled"; > +}; Why do you disable the crypto subsystem? > +&dma_apbh { > + statu

Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes

2020-12-10 Thread Marco Felsch
>reg_offset_x = EV_REGISTER_OFFSET_X; > reg_addr->reg_offset_y = EV_REGISTER_OFFSET_Y; > reg_addr->reg_num_x = NO_REGISTER; > reg_addr->reg_num_y = NO_REGISTER; > - reg_addr->reg_report_rate = NO_REGISTER; > break; Nit: Unrelated change. However the patch looks good, thanks. Acked-by: Marco Felsch Regards, Marco

Re: [PATCH 2/2] arm64: imx8mp: imx8mp-phycore-som enable spi nor

2021-03-08 Thread Marco Felsch
Hi Teresa, Heiko, On 21-03-08 07:46, Teresa Remmet wrote: > Hello Heiko, > > first thanks for the patch :). > > Am Montag, den 08.03.2021, 07:40 +0100 schrieb Heiko Schocher: > > enable the mt25qu256aba spi nor on the imx8mp-phycore-som. > > > > Signed-off-by: Heiko Schocher > > --- > > > >

Re: [PATCH 1/2] arm64: dts: imx8mp: add flexspi node

2021-03-08 Thread Marco Felsch
Hi Heiko, On 21-03-08 07:40, Heiko Schocher wrote: > add node for the flexspi modul on imx8mp. > > Signed-off-by: Heiko Schocher > > --- > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8

Re: [PATCH 2/2] arm64: imx8mp: imx8mp-phycore-som enable spi nor

2021-03-08 Thread Marco Felsch
On 21-03-08 07:40, Heiko Schocher wrote: > enable the mt25qu256aba spi nor on the imx8mp-phycore-som. > > Signed-off-by: Heiko Schocher > --- > > .../dts/freescale/imx8mp-phycore-som.dtsi | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/free

Re: [PATCH 2/2] arm64: imx8mp: imx8mp-phycore-som enable spi nor

2021-03-08 Thread Marco Felsch
On 21-03-08 08:52, Teresa Remmet wrote: > Hello Marco, > > Am Montag, den 08.03.2021, 09:40 +0100 schrieb Marco Felsch: > > On 21-03-08 07:40, Heiko Schocher wrote: > > > enable the mt25qu256aba spi nor on the imx8mp-phycore-som. > > > &g

Re: [PATCH 1/1] arm64: dts: imx8mm-nitrogen-r2: add espi2 support

2021-03-08 Thread Marco Felsch
Hi Adrien, On 21-03-08 13:39, Adrien Grassein wrote: > Add the description for espi support. > > Signed-off-by: Adrien Grassein > Reviewed-by: Krzysztof Kozlowski > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 22 +++ > 1 file changed, 22 insertions(+) > > diff --git

Re: [PATCH v2 6/6] arch/arm: reMarkable2: Enable wacom_i2c

2021-01-22 Thread Marco Felsch
Hi, thanks for the patch. On 21-01-20 22:56, Alistair Francis wrote: > Enable the wacom_i2c touchscreen for the reMarkable2. > > Signed-off-by: Alistair Francis > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 41 + > arch/arm/configs/imx_v6_v7_defconfig| 1 + Tho

Re: [PATCH v2 1/6] devicetree/bindings: Initial commit of wacom, wacom-i2c

2021-01-22 Thread Marco Felsch
Hi, thnaks for the patch. On 21-01-20 22:56, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > .../input/touchscreen/wacom,wacom-i2c.yaml| 44 +++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + This should be splitted into two patches. Regards, Ma

Re: [PATCH v2 2/6] input/touchscreen: Add device tree support to wacom_i2c

2021-01-22 Thread Marco Felsch
On 21-01-20 22:56, Alistair Francis wrote: > Allow the wacom-i2c device to be exposed via device tree. You did a lot more than exposing. > Signed-off-by: Alistair Francis > --- > .../input/touchscreen/wacom,wacom-i2c.yaml | 4 > drivers/input/touchscreen/wacom_i2c.c| 16

Re: [PATCH v2 3/6] touchscreen/wacom_i2c: Add support for distance and tilt x/y

2021-01-22 Thread Marco Felsch
Hi, thanks for the patch. Please align all your patch-subjects belonging to the driver to: "Input: wacom_i2c - ..." On 21-01-20 22:56, Alistair Francis wrote: > This is based on the out of tree rM2 driver. > > Signed-off-by: Alistair Francis > --- > drivers/input/touchscreen/wacom_i2c.c | 25 +

Re: [PATCH v2 0/6] Add Wacom I2C support to rM2

2021-01-22 Thread Marco Felsch
Hi Alistair, thanks for the patches. Before getting into the series please check all your commit subjects. Also please check that you do only one logical change per patch: e.g. adding DT-Support means: Add the dt-table and not more. I looking forward to your v2 :) Regards, Marco On 21-01-20 2

Re: [PATCH v2 1/1] arm64: dts: imx8mm-nitrogen-r2: add ecspi2 support

2021-03-09 Thread Marco Felsch
+++ > 1 file changed, 20 insertions(+) Reviewed-by: Marco Felsch Regards, Marco

Re: [PATCH v2 0/4] enable flexspi support on imx8mp

2021-03-09 Thread Marco Felsch
Hi Heiko, On 21-03-09 06:31, Heiko Schocher wrote: > > This series enables support for the SPI NOR on the > imx8mp based phyboard-pollux-rdk board. > > Patches new in v2: > "spi: fspi: enable fspi driver for on imx8mp" > which adds own compatible entry for imx8mp > > and seperate in own patch t

Re: [PATCHv5 1/2] ARM: dts: imx6ul: Add Variscite DART-6UL SoM support

2019-08-29 Thread Marco Felsch
Hi Oliver, thanks for the patch. On 19-08-28 18:19, Oliver Graute wrote: > This patch adds support for the i.MX6UL variant of the Variscite DART-6UL > SoM Carrier-Board > > Signed-off-by: Oliver Graute > Cc: Shawn Guo > Cc: Neil Armstrong > --- > .../boot/dts/imx6ul-imx6ull-var-dart-common.d

Re: [PATCHv5 2/2] ARM: dts: Add support for i.MX6 UltraLite DART Variscite Customboard

2019-08-29 Thread Marco Felsch
Hi Oliver, On 19-08-28 18:19, Oliver Graute wrote: > This patch adds DeviceTree Source for the i.MX6 UltraLite DART NAND/WIFI > > Signed-off-by: Oliver Graute > Cc: Shawn Guo > Cc: Neil Armstrong > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx6ul-var-6

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread Marco Felsch
Hi Robin, On 19-08-29 09:24, robin wrote: > Hi Marco, > > On 2019-08-28 11:15, Marco Felsch wrote: > > Hi Robin, > > > > thanks for the patch. > > > > On 19-08-27 14:32, Robin van der Gracht wrote: > > > The first generation i.MX6 proc

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread Marco Felsch
On 19-08-29 09:11, Robin Gong wrote: > > On 2019-08-29 16:17, Marco Felsch wrote: > > > > While reading the rm it seems that > > > > the snvs block has a dedicated version register. IMHO this could be > > > > a better way to apply the change also to

Re: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-03 Thread Marco Felsch
Hi Robin, thanks for the patch it looks quite good, just two minor nitpicks. On 19-09-04 06:23, Robin van der Gracht wrote: > The first generation i.MX6 processors does not send an interrupt when the > power key is pressed. It sends a power down request interrupt if the key is > released before a

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-28 Thread Marco Felsch
Hi Robin, thanks for the patch. On 19-08-27 14:32, Robin van der Gracht wrote: > The first generation i.MX6 processors does not send an interrupt when the > power key is pressed. It sends a power down request interrupt if the key is > released before a hard shutdown (5 second press). This should

Re: [PATCH v2] arm: dts: imx6qdl: add gpio expander pca9535

2019-09-12 Thread Marco Felsch
Hi Gilles, On 19-09-12 06:01, Gilles Doffe wrote: > Hi Marco, > > Thanks for your reply and sorry about the delay. No worries ;) > - Le 22 Juil 19, à 9:53, Marco Felsch m.fel...@pengutronix.de a écrit : > > > Hi Gilles, > > > > can you adapt the patch ti

[PATCH 3/5] regulator: da9062: add voltage selection gpio support

2019-09-17 Thread Marco Felsch
-based voltage switching support. Signed-off-by: Marco Felsch --- drivers/regulator/da9062-regulator.c | 149 +++ 1 file changed, 149 insertions(+) diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-regulator.c index 9b2ca472f70c..9d6eb7625948

[PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-09-17 Thread Marco Felsch
Add the documentation which describe the voltage selection gpio support. This property can be applied to each subnode within the 'regulators' node so each regulator can be configured differently. Signed-off-by: Marco Felsch --- Documentation/devicetree/bindings/mfd/da9062.txt | 9 ++

[PATCH 4/5] dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation

2019-09-17 Thread Marco Felsch
At the gpio-based regulator enable/disable documentation. This property can be applied to each subnode within the 'regulators' node so each regulator can be configured differently. Signed-off-by: Marco Felsch --- Documentation/devicetree/bindings/mfd/da9062.txt | 7 +++ 1 file

[PATCH 0/5] DA9062 PMIC fixes and features

2019-09-17 Thread Marco Felsch
Hi, the main purpose of this serie is to add the voltage selection support upon a given gpio input signal and to dis-/enable a regulator upon a gpio input signal. This series depends on [1]. [1] https://patchwork.ozlabs.org/project/linux-gpio/list/?series=131029 Regards, Marco Marco Felsch

[PATCH 5/5] regulator: da9062: add gpio based regulator dis-/enable support

2019-09-17 Thread Marco Felsch
the support to disable/enable the regulator based on a gpio input signal. Signed-off-by: Marco Felsch --- drivers/regulator/da9062-regulator.c | 84 +++- 1 file changed, 82 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/da9062-regulator.c b/drivers

[PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-17 Thread Marco Felsch
Signed-off-by: Marco Felsch --- drivers/regulator/da9062-regulator.c | 118 +++ 1 file changed, 47 insertions(+), 71 deletions(-) diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-regulator.c index 2ffc64622451..9b2ca472f70c 100644 --- a/drivers

Re: [PATCH 3/5] regulator: da9062: add voltage selection gpio support

2019-09-17 Thread Marco Felsch
ter] > [cannot apply to v5.3 next-20190916] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Marco-Felsch/DA9062-PMIC-fixes-and-features/20190917-205911 > config: x

[PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-09-17 Thread Marco Felsch
turning the rdev device during regulator_register(). Signed-off-by: Marco Felsch --- drivers/regulator/core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index e0c0cf462004..f9444f509440 100644 --- a/drivers/regulat

[PATCH 2/3] regulator: of: fix suspend-min/max-voltage parsing

2019-09-17 Thread Marco Felsch
. I don't know if it isn't tested but it can't work without this fix. Fixes: f7efad10b5c4 ("regulator: add PM suspend and resume hooks") Signed-off-by: Marco Felsch --- drivers/regulator/of_regulator.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 0/3] Regulator core fixes

2019-09-17 Thread Marco Felsch
gards, Marco Marco Felsch (3): regulator: core: fix boot-on regulators use_count usage regulator: of: fix suspend-min/max-voltage parsing regulator: core: make regulator_register() EPROBE_DEFER aware drivers/regulator/core.c | 18 ++ drivers/regulator/of_regulator.c

[PATCH 3/3] regulator: core: make regulator_register() EPROBE_DEFER aware

2019-09-17 Thread Marco Felsch
Sometimes it can happen that the regulator_of_get_init_data() can't retrieve the config due to a not probed device the regulator depends on. Fix that by checking the return value of of_parse_cb() and return EPROBE_DEFER in such cases. Signed-off-by: Marco Felsch --- drivers/regulator/c

Re: [PATCH 3/3] regulator: core: make regulator_register() EPROBE_DEFER aware

2019-09-18 Thread Marco Felsch
On 19-09-17 17:57, Dmitry Torokhov wrote: > On Tue, Sep 17, 2019 at 4:42 PM Marco Felsch wrote: > > > > Sometimes it can happen that the regulator_of_get_init_data() can't > > retrieve the config due to a not probed device the regulator depends on. > > Fix that

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-10-02 Thread Marco Felsch
On 19-09-30 09:53, Adam Thomson wrote: > On 26 September 2019 15:39, Marco Felsch wrote: > > > On 19-09-26 14:04, Adam Thomson wrote: > > > On 26 September 2019 12:44, Marco Felsch wrote: > > > > > > > On 19-09-26 10:17, Adam Thomson wrote: > > >

Re: [PATCH] iio: adc: imx25-gcq: Variable could be uninitialized if regmap_read() fails

2019-09-30 Thread Marco Felsch
Hi Yizhuo, thanks for your patch. On 19-09-27 17:28, Yizhuo wrote: > In function mx25_gcq_irq(), local variable "stats" could > be uninitialized if function regmap_read() returns -EINVAL. > However, this value is used in if statement, which is > potentially unsafe. The same case applied to the va

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-30 Thread Marco Felsch
Hi Anson, Leonard, On 19-09-30 07:42, Anson Huang wrote: > Hi, Leonard > > > On 2019-09-27 4:20 AM, Anson Huang wrote: > > >> On 2019-09-26 1:06 PM, Marco Felsch wrote: > > >>> On 19-09-26 08:03, Anson Huang wrote: > > >>>>> On 19-09-2

Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file

2019-09-30 Thread Marco Felsch
Hi Andreas, On 19-09-27 21:08, Andreas Kemnade wrote: > Hi Marco, > > On Fri, 27 Sep 2019 11:47:21 +0200 > Marco Felsch wrote: > > > Hi Andreas, > > > > thanks for the patch. > > > thanks for the quick review. Most of your comments are clear. &

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-30 Thread Marco Felsch
Hi Anson, On 19-09-30 08:32, Anson Huang wrote: > Hi, Marco > > > On 19-09-30 07:42, Anson Huang wrote: > > > Hi, Leonard > > > > > > > On 2019-09-27 4:20 AM, Anson Huang wrote: > > > > >> On 2019-09-26 1:06 PM, Marco Fe

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-07 Thread Marco Felsch
On 19-10-07 19:29, Mark Brown wrote: > On Mon, Oct 07, 2019 at 11:34:29AM +0200, Marco Felsch wrote: > > > Sorry that won't fix my problem. If I drop the regulator-boot-on state > > the fixed-regulator will disable this regulator but disable/enable this > > regulator

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-08 13:51, Mark Brown wrote: > On Tue, Oct 08, 2019 at 08:03:11AM +0200, Marco Felsch wrote: > > On 19-10-07 19:29, Mark Brown wrote: > > > On Mon, Oct 07, 2019 at 11:34:29AM +0200, Marco Felsch wrote: > > > > > Sorry that won't fix my problem.

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-08 16:42, Mark Brown wrote: > On Tue, Oct 08, 2019 at 04:56:05PM +0200, Marco Felsch wrote: > > On 19-10-08 13:51, Mark Brown wrote: > > > > No, we shouldn't do anything when the regulator probes - we'll only > > > disable unused regulators when

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-08 17:23, Mark Brown wrote: > On Tue, Oct 08, 2019 at 06:16:40PM +0200, Marco Felsch wrote: > > On 19-10-08 16:42, Mark Brown wrote: > > > > If this is a GPIO regulator then the Linux APIs mean you can't read the > > > status back so it's one of th

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
Hi Anson, On 19-10-08 00:48, Anson Huang wrote: > Hi, Marco > > > On 19-10-07 09:15, Anson Huang wrote: > > > The SCU firmware does NOT always have return value stored in message > > > header's function element even the API has response data, those > > > special APIs are defined as void function

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
On 19-10-09 08:28, Anson Huang wrote: > Hi, Marco > > > On 19-10-08 00:48, Anson Huang wrote: > > > Hi, Marco > > > > > > > On 19-10-07 09:15, Anson Huang wrote: > > > > > The SCU firmware does NOT always have return value stored in > > > > > message header's function element even the API has resp

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
Hi Anson, On 19-10-07 09:15, Anson Huang wrote: > The SCU firmware does NOT always have return value stored in message > header's function element even the API has response data, those special > APIs are defined as void function in SCU firmware, so they should be > treated as return success always

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
ine MISC_FUNC_GET_CONTROL 2U /* Index for misc_get_control() RPC call */ > #define MISC_FUNC_SET_MAX_DMA_GROUP 4U /* Index for misc_set_max_dma_group() > RPC call */ Ahh, okay get it. Thanks for the explanation. > > > > > + saved_func = ((struct imx_sc_rpc_msg

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-07 Thread Marco Felsch
Hi Anson, On 19-10-07 09:15, Anson Huang wrote: > The SCU firmware does NOT always have return value stored in message > header's function element even the API has response data, those special > APIs are defined as void function in SCU firmware, so they should be > treated as return success always

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-07 Thread Marco Felsch
On 19-10-07 01:21, Anson Huang wrote: > Hi, Marco > > > On 19-09-30 08:32, Anson Huang wrote: > > > Hi, Marco > > > > > > > On 19-09-30 07:42, Anson Huang wrote: > > > > > Hi, Leonard > > > > > > > > > >

Re: [PATCH 3/5] regulator: da9062: add voltage selection gpio support

2019-10-07 Thread Marco Felsch
On 19-10-04 21:41, Linus Walleij wrote: > On Tue, Sep 17, 2019 at 2:43 PM Marco Felsch wrote: > > > + /* > > +* We only must ensure that the gpio device is probed before the > > +* regulator driver so no need to store the reference global. > >

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-07 Thread Marco Felsch
Hi Doug, Mark, On 19-10-01 12:57, Doug Anderson wrote: > Hi, > > On Fri, Sep 27, 2019 at 1:47 AM Marco Felsch wrote: > > > > > > It should be possible to do a regulator_disable() though I'm not > > > > > > sure anyone actually uses that. The pa

Re: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-18 Thread Marco Felsch
Hi Adam, On 19-09-18 12:41, Adam Thomson wrote: > On 17 September 2019 13:43, Marco Felsch wrote: > > > Currently the suspend reg_field maps to the pmic voltage selection bits > > and is used during suspend_enabe/disable() and during get_mode(). This > > seems to be

Re: [PATCH 3/3] regulator: core: make regulator_register() EPROBE_DEFER aware

2019-09-18 Thread Marco Felsch
On 19-09-18 08:53, Dmitry Torokhov wrote: > On Wed, Sep 18, 2019 at 1:18 AM Marco Felsch wrote: > > > > On 19-09-17 17:57, Dmitry Torokhov wrote: > > > On Tue, Sep 17, 2019 at 4:42 PM Marco Felsch > > > wrote: > > > > > > > > Sometimes

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-09-25 Thread Marco Felsch
Hi Adam, On 19-09-24 09:23, Adam Thomson wrote: > On 17 September 2019 13:43, Marco Felsch wrote: > > > Add the documentation which describe the voltage selection gpio support. > > This property can be applied to each subnode within the 'regulators' > > node s

Re: [PATCH 3/5] regulator: da9062: add voltage selection gpio support

2019-09-25 Thread Marco Felsch
Hi Adam, On 19-09-24 09:48, Adam Thomson wrote: > On 17 September 2019 13:43, Marco Felsch wrote: > > > The DA9062/1 devices can switch their regulator voltages between > > voltage-A (active) and voltage-B (suspend) settings. Switching the > > voltages can be controlle

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-26 Thread Marco Felsch
Hi, On 19-09-25 18:07, Anson Huang wrote: > The SCU firmware does NOT always have return value stored in message > header's function element even the API has response data, those special > APIs are defined as void function in SCU firmware, so they should be > treated as return success always. > >

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-09-26 Thread Marco Felsch
On 19-09-25 16:18, Adam Thomson wrote: > On 25 September 2019 16:52, Marco Felsch wrote: > > > Hi Adam, > > > > On 19-09-24 09:23, Adam Thomson wrote: > > > On 17 September 2019 13:43, Marco Felsch wrote: > > > > > > > Add the documenta

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-26 Thread Marco Felsch
Hi Anson, On 19-09-26 08:03, Anson Huang wrote: > Hi, Marco > > > On 19-09-25 18:07, Anson Huang wrote: > > > The SCU firmware does NOT always have return value stored in message > > > header's function element even the API has response data, those > > > special APIs are defined as void function

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-09-26 Thread Marco Felsch
On 19-09-26 10:17, Adam Thomson wrote: > On 26 September 2019 09:10, Marco Felsch wrote: > > > On 19-09-25 16:18, Adam Thomson wrote: > > > On 25 September 2019 16:52, Marco Felsch wrote: > > > > > > > Hi Adam, > > > > > > > > On

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-09-26 Thread Marco Felsch
On 19-09-26 14:04, Adam Thomson wrote: > On 26 September 2019 12:44, Marco Felsch wrote: > > > On 19-09-26 10:17, Adam Thomson wrote: > > > On 26 September 2019 09:10, Marco Felsch wrote: > > > > > > > On 19-09-25 16:18, Adam Thomson wrote: > > >

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-09-27 Thread Marco Felsch
Hi Doug, Mark, sorry for the delay.. On 19-09-26 12:44, Doug Anderson wrote: > Hi, > > On Tue, Sep 24, 2019 at 11:28 AM Mark Brown wrote: > > On Mon, Sep 23, 2019 at 03:40:09PM -0700, Doug Anderson wrote: > > > On Mon, Sep 23, 2019 at 11:49 AM Mark Brown wrote: > > > > On Mon, Sep 23, 2019 at

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-27 Thread Marco Felsch
Hi Anson, Leonard, On 19-09-27 01:20, Anson Huang wrote: > Hi, Leonard > > > On 2019-09-26 1:06 PM, Marco Felsch wrote: > > > On 19-09-26 08:03, Anson Huang wrote: > > >>> On 19-09-25 18:07, Anson Huang wrote: > > >>>> The SCU firmware does N

Re: [PATCH 2/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD

2019-09-27 Thread Marco Felsch
Hi Andreas, On 19-09-27 08:14, Andreas Kemnade wrote: > This adds a compatible string fro the Kobo Clara HD eBook reader. > > Signed-off-by: Andreas Kemnade > --- Just a nitpick, this should be patch number 1. Regards, Marco > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > 1 file

Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file

2019-09-27 Thread Marco Felsch
Hi Andreas, thanks for the patch. On 19-09-27 08:14, Andreas Kemnade wrote: > The Netronix board E60K02 can be found some several Ebook-Readers, > at least the Kobo Clara HD and the Tolino Shine 3. The board > is equipped with different SoCs. > > For now the following peripherals are included: >

Re: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-23 Thread Marco Felsch
Hi Adam, On 19-09-23 16:03, Adam Thomson wrote: > On 17 September 2019 13:43, Marco Felsch wrote: > > > Currently the suspend reg_field maps to the pmic voltage selection bits > > and is used during suspend_enabe/disable() and during get_mode(). This > > seems to be

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-05-03 Thread Marco Felsch
Hi Robert, On 20-04-30 18:11, Robert Foss wrote: > Hey Marco, > > On Thu, 30 Apr 2020 at 14:07, Marco Felsch wrote: > > > > On 20-04-30 13:20, Sakari Ailus wrote: > > > On Thu, Apr 30, 2020 at 12:11:57PM +0200, Marco Felsch wrote: > > > > On 20-04-

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
Hi Robert, thnakf for the patch but pls keep in mind to do one thing per patch. IMHO this patch do a lot more. Anyway below are my comment :) On 20-04-29 18:24, Robert Foss wrote: > Add match table, enable ov8856_probe() to support > both ACPI and DT modes. You are also adding the support for re

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
Hi Sakari, On 20-04-30 12:45, Sakari Ailus wrote: > Hi Marco, > > On Thu, Apr 30, 2020 at 11:35:24AM +0200, Marco Felsch wrote: > > Hi Robert, > > > > thnakf for the patch but pls keep in mind to do one thing per patch. > > IMHO this patch do a lot

  1   2   >