Re: [PATCH] vme: add missing put_device() after device_register() fails

2013-02-25 Thread Martyn Welch
); > err_devalloc: > list_for_each_entry_safe(vdev, tmp, &drv->devices, drv_list) { > list_del(&vdev->drv_list); > list_del(&vdev->bridge_list); > device_unregister(&vdev->dev); > } >

Re: [PATCH] vme: vme_tsi148.c: use module_pci_driver to simplify the code

2012-11-02 Thread Martyn Welch
something new every day :-) Acked-by: Martyn Welch Thanks, Martyn --- drivers/vme/bridges/vme_tsi148.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c index 5fbd08f..9c1aa4d 100644 --- a

Re: [PATCH] vme: vme_ca91cx42.c: use module_pci_driver to simplify the code

2012-11-02 Thread Martyn Welch
: Martyn Welch --- drivers/vme/bridges/vme_ca91cx42.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c index 1425d22c..64bfea3 100644 --- a/drivers/vme/bridges/vme_ca91cx42.c +++ b/drivers

Re: [PATCH] vme: vme_vmivme7805.c: use module_pci_driver to simplify the code

2012-11-02 Thread Martyn Welch
: Martyn Welch --- drivers/vme/boards/vme_vmivme7805.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/vme/boards/vme_vmivme7805.c b/drivers/vme/boards/vme_vmivme7805.c index 8e05bb4..dd22b50 100644 --- a/drivers/vme/boards/vme_vmivme7805.c +++ b

Re: [PATCH] vme: vme_tsi148.c: fix error return code in tsi148_probe()

2013-07-01 Thread Martyn Welch
On 19/06/13 03:42, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code in the tsi148_crcsr_init() error > handling case instead of 0, as done elsewhere in this function. > Hi Wei, Thanks for your patch looks good. Signed-off-by: Martyn Welch >

Re: [PATCH] staging: vme: fix for a potential NULL pointer dereference

2013-03-26 Thread Martyn Welch
On 25/03/13 05:37, Kumar Amit Mehta wrote: > Audit the return value of cdev_alloc and hence fixes a potential NULL pointer > dereferencing. > > Signed-off-by: Kumar Amit Mehta Looks good to me, thanks. Signed-off-by: Martyn Welch > --- > drivers/staging/vme/devices

Re: [PATCH] staging: vme: fix error return code in vme_user_probe()

2013-05-13 Thread Martyn Welch
ic int vme_user_probe(struct vme_dev *vdev) > if (image[i].resource == NULL) { > dev_warn(&vdev->dev, >"Unable to allocate master resource\n"); > + err = -ENOMEM; >

Re: [PATCH] staging: vme: fix error return code in vme_user_probe()

2013-05-14 Thread Martyn Welch
On 13/05/13 09:51, Dan Carpenter wrote: > On Mon, May 13, 2013 at 09:16:00AM +0100, Martyn Welch wrote: >> On 13/05/13 07:05, Wei Yongjun wrote: >>> From: Wei Yongjun >>> >>> Fix to return -ENOMEM in the resource alloc error handling >>> case ins

Re: [PATCH] staging: vme: fix error return code in vme_user_probe()

2013-05-15 Thread Martyn Welch
On 14/05/13 15:19, Dan Carpenter wrote: > On Tue, May 14, 2013 at 02:56:17PM +0100, Martyn Welch wrote: >> On 13/05/13 09:51, Dan Carpenter wrote: >>> On Mon, May 13, 2013 at 09:16:00AM +0100, Martyn Welch wrote: >>>> On 13/05/13 07:05, Wei Yongjun wrote: >>&g

Re: [PATCH]staging "vme" Fix typos.

2012-08-13 Thread Martyn Welch
gt; + * We are going to alloc a page during init per window for small transfers. Yup - that's OK. Care to fix up the issues above? Martyn > * Small transfers will go user space -> buffer -> VME. Larger (more than a > * page) transfers will lock the user space buffer into memory

Re: [PATCH v2]staging "vme" Fix typos.

2012-08-14 Thread Martyn Welch
buffer -> VME. Larger (more than a > * page) transfers will lock the user space buffer into memory and then > * transfer the data directly from the user space buffers out to VME. > Thanks for updating the patch, that's much better: Acked-by: Martyn Welch -- Martyn Welch (L

Re: [PATCH 05/12] staging: vme_pio2: fix oops on module unloading

2012-12-17 Thread Martyn Welch
On 14/12/12 11:02, Konstantin Khlebnikov wrote: > This patch forbids loading vme_pio2 module without specifing "num_bus" > parameter. > Otherwise on module unloading pio2_exit() calls vme_unregister_driver() for > not > registered pio2_driver. > Acked-by: Ma

alloc_bootmem - Kernel panic

2007-02-07 Thread Martyn Welch
O "Driver removed.\n"); } MODULE_DESCRIPTION("alloc_bootmem_x Test"); MODULE_AUTHOR("Martyn Welch <[EMAIL PROTECTED]>"); MODULE_LICENSE("GPL"); /** Register initilisation function */ module_init(universeII_i

RE: alloc_bootmem - Kernel panic

2007-02-07 Thread Martyn Welch
Hi Asgard, Thank you for your reply. > I don't sure, that linux performs to allocate bootmem after kernel already > booted. > As I know, bootmem allocator "destroyed" when kernel initializes buddy > allocator. > Indeed you can look at arch/i385/mm/init.c, mem_init routine. > kernel pass

Re: [PATCH] vme: fake: mark symbols static where possible

2016-09-23 Thread Martyn Welch
x27;fake_vmewrite32' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xi

Re: [PATCH v3] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-28 Thread Martyn Welch
On 28/07/16 11:37, Enric Balletbo i Serra wrote: This patch adds and entry to the sysfs to start firmware upload process on the specified device with the requested firmware. The uploading of the firmware needs only to happen once per firmware upgrade, as the firmware is stored in persistent st

Re: [PATCH] vme: fake: fix build for 64-bit dma_addr_t

2016-09-08 Thread Martyn Welch
make this clearer while fixing the warning, I'm adding > a set of helper functions for the type conversion. > > Signed-off-by: Arnd Bergmann Acked-by: Martyn Welch > --- > drivers/vme/bridges/vme_fake.c | 26 ++ > 1 file changed, 18 insertions(+),

Re: [GIT PULL] VME Subsystem patches for 4.14-rc4

2017-10-14 Thread Martyn Welch
On Sat, 2017-10-14 at 14:08 +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 13, 2017 at 10:09:19PM +0100, Martyn Welch wrote: > > The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: > > > > Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) > > &

[PATCH v2] ahci: imx: Handle increased read failures for IMX53 temperature sensor in low frequency mode.

2017-11-13 Thread Martyn Welch
Starkov Signed-off-by: Martyn Welch --- v2: - Correct spelling issues in cover letter. drivers/ata/ahci_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c index 787567e..a58bcc0 100644 --- a/drivers/ata/ahci_imx.c +++ b

[PATCH] hwmon: da9052 Increase sample rate when using TSI

2017-10-19 Thread Martyn Welch
-by: Martyn Welch --- drivers/hwmon/da9052-hwmon.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hwmon/da9052-hwmon.c b/drivers/hwmon/da9052-hwmon.c index 97a62f5..a973eb6 100644 --- a/drivers/hwmon/da9052-hwmon.c +++ b/drivers/hwmon/da9052-hwmon.c @@ -477,6 +477,11 @@ static

Re: [PATCH] vme: 8-bit status/id takes 256 values, not 255

2015-10-18 Thread Martyn Welch
On 10 October 2015 at 23:00, Dmitry Kalinkin wrote: > Fixes an off by one array size. > The Status/ID is an 8-bit value (OK, the standard states it can be a 8, 16 or 32-bit value, however both of the chipsets we support at this point in time support an 8-bit value), why do we need a 256th entry i

Re: [PATCHv5] staging: vme_user: provide DMA functionality

2015-10-18 Thread Martyn Welch
On 11/10/15 01:13, Dmitry Kalinkin wrote: This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev ---

Re: [PATCH] vme: 8-bit status/id takes 256 values, not 255

2015-10-18 Thread Martyn Welch
On 18/10/15 18:07, Dmitry Kalinkin wrote: On Sun, Oct 18, 2015 at 9:30 AM, Martyn Welch wrote: On 10 October 2015 at 23:00, Dmitry Kalinkin wrote: Fixes an off by one array size. The Status/ID is an 8-bit value (OK, the standard states it can be a 8, 16 or 32-bit value, however both of

Re: [PATCHv5] staging: vme_user: provide DMA functionality

2015-10-18 Thread Martyn Welch
On 18/10/15 18:53, Dmitry Kalinkin wrote: On Sun, Oct 18, 2015 at 10:31 AM, Martyn Welch wrote: On 11/10/15 01:13, Dmitry Kalinkin wrote: This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by

Re: [PATCH] vme: ca91cx42: remove redundant variable i

2018-07-14 Thread Martyn Welch
et-variable] > > Signed-off-by: Colin Ian King Reviewed-by: Martyn Welch > --- > drivers/vme/bridges/vme_ca91cx42.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vme/bridges/vme_ca91cx42.c > b/drivers/vme/bridges/vme_ca91cx42.c > index 5dd

Re: [PATCH] MAINTAINERS: Update E-mail address

2018-07-10 Thread Martyn Welch
On Tue, 2018-07-10 at 16:47 +0200, Peter Senna Tschudin wrote: > Update my E-mail address on MAINTAINERS file. > > Signed-off-by: Peter Senna Tschudin Acked-by: Martyn Welch > --- >  MAINTAINERS | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > di

[PATCH 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2018-12-11 Thread Martyn Welch
s hardware specifications are: * 512MB DDR3 memory * 512MB NAND flash * Dual 10/100 Ethernet * USB Host and USB OTG * RS232 * MicroSD external storage * Audio, RS232, I2C, SPI, CAN headers * Further I/O options via A/V and Expansion headers Signed-off-by: Martyn Welch --- arch/arm/boot/dt

[PATCH 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2018-12-11 Thread Martyn Welch
Add vendor prefix "catalyst" for Catalyst Semiconductor which is already in use but undocumented. Signed-off-by: Martyn Welch --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefi

Re: [PATCH] mailbox, remoteproc: omap2+: fix compile testing

2024-09-12 Thread Martyn Welch
bcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for > M4F subsystem") > Signed-off-by: Arnd Bergmann > --- >  drivers/mailbox/Kconfig    |  2 +- >  drivers/mailbox/omap-mailbox.c |  2 +- >  drivers/remoteproc/Kconfig | 10 -- >  3 files changed, 6

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-16 Thread Martyn Welch
On 16/06/14 10:56, Dan Carpenter wrote: On Mon, Jun 16, 2014 at 10:47:25AM +0100, Martyn Welch wrote: Nick, Sorry for the delay in responding. I'm staring at the manual for the ca91c142 and the relevant bits in the VSIx_CTL registers definitely need to be set to 0 for A16, likewise wit

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-16 Thread Martyn Welch
A24 (1<<16) #define CA91CX42_LM_CTL_AS_A32(1<<17) -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester,

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Martyn Welch
user and is allocated a window, if vme_user demands 8 windows (and assuming it doesn't deal with some already having been allocated gracefully, which it doesn't at the moment) then it doesn't load. Dynamic allocation would leave "unused" resources available rather than pro

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Martyn Welch
n top of the existing API. Does that seem workable to you? -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.we...@g

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Martyn Welch
sues with filling available PCI address space. Admittedly this is more of a problem on 32-bit systems, but... -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Martyn Welch
re dynamically allocated at the time at which an interrupt came in. Martyn -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E mart

Re: [RFC] Generic VME UIO

2015-07-28 Thread Martyn Welch
l character) */ diff --git a/include/linux/vme.h b/include/linux/vme.h index c013135..71e4a6d 100644 --- a/include/linux/vme.h +++ b/include/linux/vme.h @@ -81,6 +81,9 @@ struct vme_resource { extern struct bus_type vme_bus_type; +/* Number of VME interrupt vectors */ +#define VME_NUM_STATUSID

Re: [PATCH] drivers: staging: vme: Fixed code style issues

2015-11-13 Thread Martyn Welch
bracketing from uses of the address operator * Use preferred null return check style Other than that: Acked-by: Martyn Welch Martyn Signed-off-by: Egor Uleyskiy --- drivers/staging/vme/devices/vme_pio2_cntr.c | 2 +- drivers/staging/vme/devices/vme_pio2_core.c | 20

[PATCH 3/3] ARM: dts: Addition of binding for gpio switches on peach-pi

2015-12-04 Thread Martyn Welch
user space. Signed-off-by: Martyn Welch --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 46 +++ 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 49a4f43..2937372 100644 --- a/arch

[PATCH 1/3] Device tree binding documentation for gpio-switch

2015-12-04 Thread Martyn Welch
: Martyn Welch --- .../devicetree/bindings/misc/gpio-switch.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/gpio-switch.txt diff --git a/Documentation/devicetree/bindings/misc/gpio-switch.txt b/Documentation

[PATCH 2/3] Add support for monitoring gpio switches

2015-12-04 Thread Martyn Welch
read from user space. This functionality has been generalised to provide support for any device with device tree support which needs to identify a gpio as being used for a specific task. Signed-off-by: Martyn Welch --- drivers/misc/Kconfig | 11 drivers/misc/Makefile | 1

Add support for monitoring gpio switches

2015-12-04 Thread Martyn Welch
This driver was written to expose a read only interface to a number of gpios on Chromebooks. These gpios are attached to signals which cause the firmware on Chromebooks to enter alternative modes of operation and/or control other device characteristics (such as write protection on flash devices). I

Re: [PATCH 2/3] Add support for monitoring gpio switches

2015-12-05 Thread Martyn Welch
On 04/12/15 18:57, Greg Kroah-Hartman wrote: On Fri, Dec 04, 2015 at 05:31:14PM +, Martyn Welch wrote: Select Chromebooks have gpio attached to switches used to cause the firmware to enter alternative modes of operation and/or control other device characteristics (such as write protection

Re: [PATCH 1/3] Device tree binding documentation for gpio-switch

2015-12-07 Thread Martyn Welch
On 07/12/15 17:37, Rob Herring wrote: +Linus W On Fri, Dec 04, 2015 at 05:31:13PM +, Martyn Welch wrote: This patch adds documentation for the gpio-switch binding. This binding provides a mechanism to bind named links to gpio, with the primary purpose of enabling standardised access to

Re: [PATCH 2/3] Add support for monitoring gpio switches

2015-12-16 Thread Martyn Welch
On 11/12/15 09:08, Linus Walleij wrote: On Fri, Dec 4, 2015 at 6:31 PM, Martyn Welch wrote: Select Chromebooks have gpio attached to switches used to cause the firmware to enter alternative modes of operation and/or control other device characteristics (such as write protection on flash

[PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-01 Thread Martyn Welch
This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Signed-off-by: Martyn Welch --- .../devicetree/bindings/misc/chromeos-firmware.txt | 27 ++ 1

[PATCH 2/3] Add support for monitoring Chrome OS firmware signals

2015-12-01 Thread Martyn Welch
from user space. Signed-off-by: Martyn Welch --- drivers/platform/chrome/Kconfig | 13 +++ drivers/platform/chrome/Makefile| 1 + drivers/platform/chrome/chromeos_firmware.c | 156 3 files changed, 170 insertions(+) create mode 100644

[PATCH 3/3] Addition of binding for firmware signals on peach-pi

2015-12-01 Thread Martyn Welch
Cc: Kumar Gala Cc: Russell King Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: devicet...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Signed-off-by: Martyn Welch --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 40

Add support for Chrome OS firmware signals

2015-12-01 Thread Martyn Welch
Some Chromebooks have gpio attached to signals used to cause the firmware to enter alternative modes of operation and/or control other device characteristics (such as write protection on flash devices). This patch adds a driver that exposes a read-only interface to allow these signals to be read fr

[PATCH v2] Add support for monitoring Chrome OS firmware signals

2015-12-01 Thread Martyn Welch
from user space. Signed-off-by: Martyn Welch --- v2: - Added missing call to remove sysfs link. drivers/platform/chrome/Kconfig | 13 +++ drivers/platform/chrome/Makefile| 1 + drivers/platform/chrome/chromeos_firmware.c | 166 3 files

Re: [PATCH 3/3] Addition of binding for firmware signals on peach-pi

2015-12-02 Thread Martyn Welch
On 01/12/15 23:51, Krzysztof Kozlowski wrote: On 02.12.2015 04:12, Martyn Welch wrote: The peach pi has a GPIO connected to the firmware write protect, developer mode and recovery mode lines. This patch adds the required nodes to the device tree to configure the pinmuxing and allow these to

Re: [PATCH v2] Add support for monitoring Chrome OS firmware signals

2015-12-02 Thread Martyn Welch
On 02/12/15 06:08, Jeremiah Mahler wrote: Martyn, On Tue, Dec 01, 2015 at 08:19:46PM +, Martyn Welch wrote: Select Chromebooks have gpio attached to signals used to cause the firmware to enter alternative modes of operation and/or control other device [...] + +static int

[PATCH v3] Add support for monitoring Chrome OS firmware signals

2015-12-02 Thread Martyn Welch
from user space. Cc: Jeremiah Mahler Signed-off-by: Martyn Welch --- v2: - Added missing call to remove sysfs link. v3: - Correct malloc sizeof() usage. drivers/platform/chrome/Kconfig | 13 +++ drivers/platform/chrome/Makefile| 1 + drivers/platform/chrome

Re: [PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-02 Thread Martyn Welch
On 02/12/15 15:15, Rob Herring wrote: On Tue, Dec 01, 2015 at 07:12:49PM +, Martyn Welch wrote: This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Signed-off

Re: [PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-02 Thread Martyn Welch
On 02/12/15 18:44, Rob Herring wrote: On Wed, Dec 2, 2015 at 10:49 AM, Martyn Welch wrote: On 02/12/15 15:15, Rob Herring wrote: On Tue, Dec 01, 2015 at 07:12:49PM +, Martyn Welch wrote: This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel

Re: [PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-03 Thread Martyn Welch
On 02/12/15 15:15, Rob Herring wrote: On Tue, Dec 01, 2015 at 07:12:49PM +, Martyn Welch wrote: This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Signed-off

Re: [PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-03 Thread Martyn Welch
On 03/12/15 15:08, Rob Herring wrote: On Thu, Dec 3, 2015 at 4:14 AM, Martyn Welch wrote: On 02/12/15 15:15, Rob Herring wrote: On Tue, Dec 01, 2015 at 07:12:49PM +, Martyn Welch wrote: This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel Moll

Re: Generic VME UIO driver

2015-07-20 Thread Martyn Welch
On 08/07/15 16:02, Dmitry Kalinkin wrote: On 08 Jul 2015, at 16:22, Martyn Welch wrote: On 06/07/15 18:24, Dmitry Kalinkin wrote: Some functionality was dropped as it was not good practice (such as receiving VME interrupts in user space, it's not really doable if the slave ca

[PATCH] Rename "trigger" reset reason "hw watchdog"

2016-02-26 Thread Martyn Welch
;s own hardware watchdog, has been reset because the hardware watchdog has triggered. Renaming to "hw watchdog". Signed-off-by: Martyn Welch --- drivers/watchdog/ziirave_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/wat

Re: [PATCH] staging: vme: fix bare use of 'unsigned'

2016-04-03 Thread Martyn Welch
On 31/03/16 23:53, Clifton Barnes wrote: fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of 'unsigned'' Signed-off-by: Clifton Barnes Acked-by: Martyn Welch Greg: Whilst this patch seems valid and compiles fine, I no longer have access t

[RFC 0/8] Add support for NVIDIA Tegra XUSB

2015-11-02 Thread Martyn Welch
This series is based on commits that can be found in the git tree here: https://github.com/thierryreding/linux/commits/staging/xhci I have included the patches I've used from that tree as patches 1-5. The above patches were submitted for review back in May: https://lkml.org/lkml/2015/5/4/574 T

[RFC 6/8] Adding binding for XUSB to tegra124 dtsi.

2015-11-02 Thread Martyn Welch
From: Martyn Welch Adding the binding for the tegra xHCI controller implementation. In addition to the dtsi entry, adding the defines needed to compile the binding. These bindings are based are in part based on the binding documentation proposed here: https://www.spinics.net/lists/linux-usb

[RFC 2/8] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2015-11-02 Thread Martyn Welch
From: Andrew Bresticker The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single physical channel, messages sent by the controller can be divided into two groups: those intended for the PHY driver and those intende

[RFC 4/8] pinctrl: tegra-xusb: Add USB PHY support

2015-11-02 Thread Martyn Welch
From: Andrew Bresticker In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports. The xHCI controller will also send messages intended for the PHY driv

[RFC 7/8] Start migrating XUSB away from MFD

2015-11-02 Thread Martyn Welch
From: Martyn Welch This is my initial attempt to get xusb working without being a MFD on the latest upstream kernel. It's still a bit hacky in places, but does seem to get the USB2 up and working (USB3 device is recognised as a USB3 device rather than enumberating as a USB2 device). --- dr

[RFC 5/8] pinctrl: tegra-xusb: Support PHY subnodes

2015-11-02 Thread Martyn Welch
From: Thierry Reding Signed-off-by: Thierry Reding --- drivers/pinctrl/pinctrl-tegra-xusb.c | 492 --- include/soc/tegra/xusb.h | 7 + 2 files changed, 296 insertions(+), 203 deletions(-) diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c b/drivers

[RFC 3/8] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver

2015-11-02 Thread Martyn Welch
From: Andrew Bresticker Add support for the on-chip xHCI host controller present on Tegra SoCs. The controller requires external firmware which must be loaded before using the controller. This driver loads the firmware, starts the controller, and is able to service host-specific messages sent by

[RFC 8/8] Registering mailbox from XUSB Child - Work in progress

2015-11-02 Thread Martyn Welch
From: Martyn Welch The mailbox API expects the device node to have a of_node associated with it. Because the child doesn't have it's own node, in the previous patch tegra_xusb_add_device() was assigning the parents of_node to it's children. Unfortunately this results in the pare

[RFC 1/8] mfd: Add driver for NVIDIA Tegra XUSB

2015-11-02 Thread Martyn Welch
From: Andrew Bresticker Add an MFD driver for the XUSB host complex found on NVIDIA Tegra124 and later SoCs. Signed-off-by: Andrew Bresticker Cc: Samuel Ortiz Cc: Lee Jones Signed-off-by: Thierry Reding --- drivers/mfd/Kconfig | 7 + drivers/mfd/Makefile | 1 + drivers/mfd/te

Re: [RFC 7/8] Start migrating XUSB away from MFD

2015-11-02 Thread Martyn Welch
On 02/11/15 12:47, Lee Jones wrote: On Mon, 02 Nov 2015, Martyn Welch wrote: From: Martyn Welch This is my initial attempt to get xusb working without being a MFD on the latest upstream kernel. It's still a bit hacky in places, but does seem to get the USB2 up and working (USB3 devi

Re: [RFC 7/8] Start migrating XUSB away from MFD

2015-11-02 Thread Martyn Welch
On 02/11/15 13:27, Lee Jones wrote: On Mon, 02 Nov 2015, Martyn Welch wrote: On 02/11/15 12:47, Lee Jones wrote: On Mon, 02 Nov 2015, Martyn Welch wrote: Besides, I'm never applying a patch that self confesses to be "hacky in places" into Mainline, ever. As I mentioned befo

Re: [RFC 0/8] Add support for NVIDIA Tegra XUSB

2015-11-02 Thread Martyn Welch
On 02/11/15 17:27, Andrew Bresticker wrote: Hi Martyn, On Mon, Nov 2, 2015 at 3:55 AM, Martyn Welch wrote: This series is based on commits that can be found in the git tree here: https://github.com/thierryreding/linux/commits/staging/xhci I have included the patches I've used from

Re: [PATCH] vme: tsi148: silence uninitialized variable warning

2015-10-10 Thread Martyn Welch
On 5 October 2015 at 04:59, Dmitry Kalinkin wrote: > The warning is a false positive. > That seems very likely. Please could you role this into the original patch (vme: change bus error handling scheme)? Martyn > drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_write': > drivers/vm

[PATCH] ARM: dts: am335x: Add support for Bosch Guardian

2019-02-11 Thread Martyn Welch
The Bosch Guardian is a TI am335x based device. It's hardware specifications are as follows: * 256 MB DDR3 memory * 512 MB NAND Flash * USB OTG * RS232 * MicroSD external storage * LCD Display interface Signed-off-by: Martyn Welch --- arch/arm/boot/dts/Makefile

[PATCH v3 1/2] dt-bindings: Add binding document for NOA1305

2019-07-26 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes: v2: Same as v1. v3: Same as v2. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create

[PATCH v3 2/2] iio: light: noa1305: Add support for NOA1305

2019-07-26 Thread Martyn Welch
+}; +MODULE_DEVICE_TABLE(of, noa1305_of_match); + +static const struct i2c_device_id noa1305_ids[] = { + { "noa1305", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, noa1305_id); + +static struct i2c_driver noa1305_driver = { + .driver = { + .name = NOA1305_DRIVER_NAME, + .of_match_table = noa1305_of_match, + }, + .probe = noa1305_probe, + .remove = noa1305_remove, + .id_table = noa1305_ids, +}; + +module_i2c_driver(noa1305_driver); + +MODULE_AUTHOR("Sergei Miroshnichenko "); +MODULE_AUTHOR("Martyn Welch

[PATCH v2 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2019-01-18 Thread Martyn Welch
Add vendor prefix "catalyst" for Catalyst Semiconductor which is already in use but undocumented. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes in v2: None Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) di

[PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2019-01-18 Thread Martyn Welch
s hardware specifications are: * 512MB DDR3 memory * 512MB NAND flash * Dual 10/100 Ethernet * USB Host and USB OTG * RS232 * MicroSD external storage * Audio, RS232, I2C, SPI, CAN headers * Further I/O options via A/V and Expansion headers Signed-off-by: Martyn Welch --- Changes in v2: - Correct

Re: [PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2019-01-21 Thread Martyn Welch
Hi Fabio, On Fri, 2019-01-18 at 19:18 -0200, Fabio Estevam wrote: > diff --git a/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin- > > full.dts b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts > > new file mode 100644 > > index ..83cdf4fa10c0 > > --- /dev/null > > +++ b/arch/arm

[PATCH v3 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2019-01-21 Thread Martyn Welch
Add vendor prefix "catalyst" for Catalyst Semiconductor which is already in use but undocumented. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes in v3: - Add full stop to denote abbreviation. Changes in v2: None Documentation/devicetree/bindings/vendor-prefix

[PATCH v3 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2019-01-21 Thread Martyn Welch
s hardware specifications are: * 512MB DDR3 memory * 512MB NAND flash * Dual 10/100 Ethernet * USB Host and USB OTG * RS232 * MicroSD external storage * Audio, RS232, I2C, SPI, CAN headers * Further I/O options via A/V and Expansion headers Signed-off-by: Martyn Welch --- Changes in v3: -

[PATCH v4 1/2] dt-bindings: Add binding document for NOA1305

2019-08-02 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes: v2: Same as v1. v3: Same as v2. v4: Same as v3. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44

[PATCH v4 2/2] iio: light: noa1305: Add support for NOA1305

2019-08-02 Thread Martyn Welch
a1305_id); + +static struct i2c_driver noa1305_driver = { + .driver = { + .name = NOA1305_DRIVER_NAME, + .of_match_table = noa1305_of_match, + }, + .probe = noa1305_probe, + .id_table = noa1305_ids, +}; + +module_i2c_driver(noa1305_driver); + +MODULE_AUTHOR("Sergei Miroshnichenko "); +MODULE_AUTHOR("Martyn Welch

[PATCH 1/2] dt-bindings: Add binding document for NOA1305

2019-06-28 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch --- .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/noa1305.yaml

[PATCH 2/2] iio: light: noa1305: Add support for NOA1305

2019-06-28 Thread Martyn Welch
From: Martyn Welch This driver adds the initial support for the ON Semiconductor NOA1305 Ambient Light Sensor. Originally written by Sergei Miroshnichenko. Found here: https://github.com/EmcraftSystems/linux-upstream/commit/196d6cf897e632d2cb82d45484bd7a1bfdd5b6d9 Signed-off-by: Sergei M

[PATCH v2 2/2] iio: light: noa1305: Add support for NOA1305

2019-06-28 Thread Martyn Welch
f_match_table = noa1305_of_match, + }, + .probe = noa1305_probe, + .remove = noa1305_remove, + .id_table = noa1305_ids, +}; + +module_i2c_driver(noa1305_driver); + +MODULE_AUTHOR("Sergei Miroshnichenko "); +MODULE_AUTHOR("Martyn Welch

[PATCH v2 1/2] dt-bindings: Add binding document for NOA1305

2019-06-28 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch --- Changes: v2: Same as v1. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH] ARM: dts: am335x: Add support for Bosch Guardian

2019-02-12 Thread Martyn Welch
On Tue, 2019-02-12 at 10:49 -0800, Tony Lindgren wrote: > Hi, > > * Martyn Welch [190211 04:27]: > > The Bosch Guardian is a TI am335x based device. > > > > It's hardware specifications are as follows: > > > > * 256 MB DDR3 memory > >

Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Martyn Welch
On Thu, 2018-09-06 at 22:04 -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case.  I think "unnecessary" is overly kind, > it does seem to be a

Re: VME: devices not removed after commit 050c3d52cc7

2017-01-18 Thread Martyn Welch
On Fri, Jan 13, 2017 at 05:28:37PM +0100, Stefano Babic wrote: > Hi Paul, > > On 13/01/2017 16:39, Paul Gortmaker wrote: > > [Adding Martyn to Cc] > > > > Sorry, I forgot to run get_maintainer before posting :-) > No worries, and sorry for the delay, this ended up in my spam filter :-/ > > [V

Re: [PATCH 2/2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-18 Thread Martyn Welch
Few comments inline On 17/06/16 11:52, Enric Balletbo i Serra wrote: This patch adds and entry to the sysfs to start firmware upload process on the specified device with the requested firmware. The uploading of the firmware needs only to happen once per firmware upgrade, as the firmware is stor

Re: [PATCH] vme: make core vme support explicitly non-modular

2016-07-07 Thread Martyn Welch
, we don't have any ".suppress_bind_attrs" to be concerned about when we drop the ".remove" code from this file. Since module_init was not in use by this code, the init ordering remains unchanged with this commit. Cc: Martyn Welch Cc: Manohar Vanga Cc: Greg Kroah-Hart

Re: [PATCH v2] [STYLE]staging:vme:vme_user.c Correct spelling mistakes

2016-11-14 Thread Martyn Welch
On Sun, Nov 13, 2016 at 08:28:34PM -0500, Walt Feasel wrote: > Make spelling corrections for 'correctly' and > 'unregister'. > > Signed-off-by: Walt Feasel Acked-by: Martyn Welch > --- > > Removed the previously submitted U.S. spelling for > &#

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-02-28 Thread Martyn Welch
This patch has been sitting on the list for about 2 weeks. Is there anything wrong with this patch? Thanks, Martyn On Tue, Feb 14, 2017 at 02:17:56PM +, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which i

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-03-02 Thread Martyn Welch
On Wed, Mar 01, 2017 at 02:30:31PM +0100, Benjamin Tissoires wrote: > Hi, > > On Feb 28 2017 or thereabouts, Martyn Welch wrote: > > This patch has been sitting on the list for about 2 weeks. Is there > > anything wrong with this patch? > > The only wrong thing with t

[PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-02-14 Thread Martyn Welch
ts in a mouse cursor being displayed in Weston. This patch adds a special driver for the device to correct the capabilities reported. Signed-off-by: Martyn Welch --- drivers/hid/Kconfig | 12 +++ drivers/hid/Makefile| 1 + drivers/hid/

Re: [PATCH] vme: Fix wrong pointer utilization in ca91cx42_slave_get

2017-01-11 Thread Martyn Welch
eger of different size [-Wpointer-to-int-cast] > *pci_base = (dma_addr_t)vme_base + pci_offset; > > Signed-off-by: Augusto Mecking Caringi Acked-By: Martyn Welch > --- > drivers/vme/bridges/vme_ca91cx42.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

[PATCH] vme: Update documentation to match api

2016-06-05 Thread Martyn Welch
The vme_register_driver() api changed in commit 5d6abf379d73 ("staging: vme: make match() driver specific to improve non-VME64x support") but the documentation wasn't updated. Update the documentation to match the API. Signed-off-by: Martyn Welch --- Documentation/vme_api.txt |

Re: [PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

2015-07-06 Thread Martyn Welch
On 25/06/15 13:05, Dmitry Kalinkin wrote: This is why I think this is not a “we broke userspace” situation. The vme_user module is also in the staging tree and (almost) by definition the API shouldn't be considered as stable. Martyn -- Martyn Welch (Lead Software Engineer) | Regis

Re: [PATCH 0/3] VME bus error handling overhaul

2015-07-06 Thread Martyn Welch
files changed, 147 insertions(+), 130 deletions(-) -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.we...@g

Re: [PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

2015-07-06 Thread Martyn Welch
ser_read(struct file *file, char __user *buf, size_t count, -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.we...@ge.c

  1   2   >