Re: [PATCH v3 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

2013-09-15 Thread Milo Kim
Hi Lee, On 09/15/2013 08:17 PM, Thierry Reding wrote: On Thu, Sep 12, 2013 at 04:28:09PM +0100, Lee Jones wrote: * Documentation From Thierry's suggestion, detailed driver description was moved to 'Documentation/lp3943.txt'. Really? Why here? Do we really want 1000's of driver docs in /

Re: [PATCH 0/6] backlight updates for 3.12-rc1

2013-09-04 Thread Milo Kim
Hi Jingoo, On 09/05/2013 11:39 AM, Jingoo Han wrote: Hi Andrew, This is the backlight updates for 3.12-rc1. Please add these patches to mm-tree. Do you have a plan to create a git repository for the backlight subsystem? It would be much better to maintain it and pull request. And mailing-lis

[PATCH v3 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

2013-09-11 Thread Milo Kim
tation/lp3943.txt'. Fix device tree bindings from maintainers' comments. (https://lkml.org/lkml/2013/7/31/226) (https://lkml.org/lkml/2013/8/14/569) Milo Kim (4): mfd: add LP3943 MFD driver gpio: add LP3943 I2C GPIO expander driver pwm: add LP3943 PWM driver Documentation:

[PATCH v3 1/4] mfd: add LP3943 MFD driver

2013-09-11 Thread Milo Kim
ata is PWM related, so parsing the device tree is implemented in the PWM driver. Cc: Lee Jones Cc: Linus Walleij Cc: Samuel Ortiz Cc: Thierry Reding Signed-off-by: Milo Kim --- * Patch v3 Now, output pin number is exactly matched with enum value of ' lp3943_pwm_output'.

[PATCH v3 2/4] gpio: add LP3943 I2C GPIO expander driver

2013-09-11 Thread Milo Kim
It is defined as unsigned long type for atomic bit operation APIs, but only LSB 16bits are used because LP3943 has 16 outputs. Reviewed-by: Linus Walleij Signed-off-by: Milo Kim --- * Patch v3 Use inline function instead of macro(), to_lp3943_gpio(). Add 'lp3943_gpio_set_mode()' an

[PATCH v3 3/4] pwm: add LP3943 PWM driver

2013-09-11 Thread Milo Kim
utputs. Cc: Thierry Reding Signed-off-by: Milo Kim --- * Patch v3 Manual polarity not supported any more. Add encapsulation functions for accessing internal data structure. Use pwm_set_chip_data() and pwm_get_chip_data(). And other code fixes based on Thierry's feedback. driver

[PATCH 4/4] Documentation: add LP3943 DT bindings and document

2013-09-11 Thread Milo Kim
Bindings for LP3943 MFD, GPIO and PWM controller are added. And LP3943 driver document is added also. Cc: devicet...@vger.kernel.org Cc: Lee Jones Cc: Linus Walleij Cc: Samuel Ortiz Cc: Thierry Reding Signed-off-by: Milo Kim --- Documentation/00-INDEX |2

[PATCH v3 4/4] Documentation: add LP3943 DT bindings and document

2013-09-11 Thread Milo Kim
Bindings for LP3943 MFD, GPIO and PWM controller are added. And LP3943 driver document is added also. Cc: devicet...@vger.kernel.org Cc: Lee Jones Cc: Linus Walleij Cc: Samuel Ortiz Cc: Thierry Reding Signed-off-by: Milo Kim --- Documentation/00-INDEX |2

Re: [PATCH 4/4] Documentation: add LP3943 DT bindings and document

2013-09-11 Thread Milo Kim
Hi Everyone, Please ignore this mail. Version information, 'v3' is missing in the subject. Fixed mail has just sent. Please find '[PATCH v3 4/4]' in your mailbox. Sorry for the inconvenience. Best regards, Milo On 09/12/2013 10:34 AM, Milo Kim wrote: Bindings for LP39

Re: [PATCH v3 4/4] Documentation: add LP3943 DT bindings and document

2013-09-22 Thread Milo Kim
Hi Lee, On 09/13/2013 12:24 AM, Lee Jones wrote: On Thu, 12 Sep 2013, Milo Kim wrote: ... new file mode 100644 index 000..576ebd0 --- /dev/null +++ b/Documentation/lp3943.txt @@ -0,0 +1,62 @@ +TI/National Semiconductor LP3943 MFD driver

[PATCH v4 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

2013-09-24 Thread Milo Kim
description from the documentation to the MFD driver file. Milo Kim (4): mfd: add LP3943 MFD driver gpio: add LP3943 I2C GPIO expander driver pwm: add LP3943 PWM driver Documentation: add LP3943 DT bindings and document .../devicetree/bindings/gpio/gpio-lp3943.txt | 37 +++ Documentation

[PATCH v4 1/4] mfd: add LP3943 MFD driver

2013-09-24 Thread Milo Kim
ata is PWM related, so parsing the device tree is implemented in the PWM driver. Signed-off-by: Milo Kim Acked-by: Lee Jones --- * Patch v4 Driver description was moved from the documentation in patch v3. * Patch v3 Now, output pin number is exactly matched with enum value of ' lp

[PATCH v4 3/4] pwm: add LP3943 PWM driver

2013-09-24 Thread Milo Kim
utputs. Cc: Thierry Reding Signed-off-by: Milo Kim --- * Patch v4 No update, same as v3. * Patch v3 Manual polarity not supported any more. Add encapsulation functions for accessing internal data structure. Use pwm_set_chip_data() and pwm_get_chip_data(). And other code fixes based o

[PATCH v4 2/4] gpio: add LP3943 I2C GPIO expander driver

2013-09-24 Thread Milo Kim
It is defined as unsigned long type for atomic bit operation APIs, but only LSB 16bits are used because LP3943 has 16 outputs. Signed-off-by: Milo Kim Reviewed-by: Linus Walleij --- * Patch v4 No update, same as v3 * Patch v3 Use inline function instead of macro(), to_lp3943_gpio(). Add

[PATCH v4 4/4] Documentation: add LP3943 DT bindings and document

2013-09-24 Thread Milo Kim
Bindings for LP3943 MFD, GPIO and PWM controller are added. Cc: devicet...@vger.kernel.org Cc: Lee Jones Cc: Linus Walleij Cc: Samuel Ortiz Cc: Thierry Reding Signed-off-by: Milo Kim --- .../devicetree/bindings/gpio/gpio-lp3943.txt | 37 + Documentation/devicetree

[PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns

2013-08-08 Thread Milo Kim
below This branch is based on 'for-next' of linux-leds. https://github.com/milokim/lp55xx.git resolve-missing-sysfs Milo Kim (10): leds: lp55xx: add common data structure for program leds: lp55xx: add common macros for device attributes leds: lp5521: restore legacy device attribu

[PATCH 06/10] leds: lp5523: LED MUX configuration on initializing

2013-08-08 Thread Milo Kim
ialization, lp5523_post_init_device(). This is a conflict after git commit 632418bf65503405df3f9a6a1616f5a95f91db85 (leds-lp5523: clean up lp5523_configure()). So it should be fixed. Cc: Pali Rohár Signed-off-by: Milo Kim --- drivers/leds/leds-lp5523.c | 70 ++

[PATCH 09/10] Documentation: leds-lp5521,lp5523: update device attribute information

2013-08-08 Thread Milo Kim
Now, all legacy application interfaces are restored. Each driver documentation is updated. Cc: Pali Rohár Signed-off-by: Milo Kim --- Documentation/leds/leds-lp5521.txt | 20 +++- Documentation/leds/leds-lp5523.txt | 21 - 2 files changed, 39 insertions

[PATCH 10/10] leds: lp5562: use LP55xx common macros for device attributes

2013-08-08 Thread Milo Kim
Signed-off-by: Milo Kim --- drivers/leds/leds-lp5562.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c index a2c7398..2585cfd 100644 --- a/drivers/leds/leds-lp5562.c +++ b/drivers/leds/leds-lp5562.c @@ -477,8

[PATCH 02/10] leds: lp55xx: add common macros for device attributes

2013-08-08 Thread Milo Kim
rite-only leds: R/W selftest: Read-only Couple of lines are duplicate, so use these macros for adding device attributes in LP5521 and LP5523 drivers. Signed-off-by: Milo Kim --- drivers/leds/leds-lp55xx-common.h | 47 + 1 file changed, 47 insertions(+) diff

[PATCH 08/10] leds: lp5523: remove unnecessary writing commands

2013-08-08 Thread Milo Kim
x27;s needless to clear whole area. Signed-off-by: Milo Kim --- drivers/leds/leds-lp5523.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 9b8be6f6..fe3bcbb 100644 --- a/drivers/leds/leds-lp5523.c

[PATCH 07/10] leds: lp5523: restore legacy device attributes

2013-08-08 Thread Milo Kim
lication compatibility. Even the driver is changed, we can use the application without re-compiling sources. Reported-by: Pali Rohár Signed-off-by: Milo Kim --- drivers/leds/leds-lp5523.c | 227 +++- 1 file changed, 223 insertions(+), 4 deletions(-) diff

[PATCH 04/10] leds: lp5521: remove unnecessary writing commands

2013-08-08 Thread Milo Kim
x27;s needless to clear whole area. Signed-off-by: Milo Kim --- drivers/leds/leds-lp5521.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c index c00f922..0518835 100644 --- a/drivers/leds/leds-lp5521.c

[PATCH 05/10] leds: lp5523: make separate API for loading engine

2013-08-08 Thread Milo Kim
'load' and select program page number. This is used for programming a LED pattern at a time. So load_engine() is replaced with new API, load_engine_and_select_page() in lp5523_firmware_loaded(). Signed-off-by: Milo Kim --- drivers/leds/leds-lp5523.c | 14 ++ 1 file ch

[PATCH 03/10] leds: lp5521: restore legacy device attributes

2013-08-08 Thread Milo Kim
'led_pattern' attribute is not included : engineN_mode and _load were created for custom user-application. 'led_pattern' is an exception. I added this attribute not for custom application but for simple test. Now it is used only in LP5562 driver, not LP5521. Sig

[PATCH 01/10] leds: lp55xx: add common data structure for program

2013-08-08 Thread Milo Kim
run. Then led_mux is used for showing/storing current output LED selection. This is only for LP5523/55231. Signed-off-by: Milo Kim --- drivers/leds/leds-lp55xx-common.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/leds/leds-lp55xx-common.h b/drivers/leds/

[PATCH v4] ARM: dts: exynos: Enable HDMI for Arndale Octa board

2016-08-30 Thread Milo Kim
#2 is assigned for the HDMI DDC. It enables the EDID access. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Rob Herring Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- arch/arm/boot/dts/exynos5420-arndale

[PATCH v4 1/3] gpu: drm: exynos_hdmi: Move DDC logic into single function

2016-08-30 Thread Milo Kim
Paring DT properties and getting the I2C adapter in one function. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: dri-de...@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c | 46

[PATCH v4 0/3] gpu: drm: exynos_hdmi: Code refactoring on hdmi ddc and phy

2016-08-30 Thread Milo Kim
v4: Only DRM patchset is sent, DTS patch was sent separately. Milo Kim (3): gpu: drm: exynos_hdmi: Move DDC logic into single function gpu: drm: exynos_hdmi: Move PHY logic into single function gpu: drm: exynos_hdmi: Remove duplicate initialization of regulator bulk consumer drivers

[PATCH v4 3/3] gpu: drm: exynos_hdmi: Remove duplicate initialization of regulator bulk consumer

2016-08-30 Thread Milo Kim
The helper, devm_regulator_bulk_get() initializes the consumer as NULL, so this code can be ignored. Reviewed-by: Andrzej Hajda Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: dri-de...@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim

[PATCH v4 2/3] gpu: drm: exynos_hdmi: Move PHY logic into single function

2016-08-30 Thread Milo Kim
Paring DT properties and getting PHY IO (memory mapped or I2C) in one function. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: dri-de...@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c | 63

Re: [PATCH v3 1/5] ARM: dts: exynos: Enable HDMI for Arndale Octa board

2016-08-30 Thread Milo Kim
Hi Krzysztof, On 08/25/2016 04:05 AM, Krzysztof Kozlowski wrote: First of all - it looks like these DTS patches do not depend on DRM part, do they? I just sent the v4 patch for DTS. DRM patch-set was sent separately. Thanks for your advise. Best regards, Milo

[PATCH v2 1/4] ARM: dts: sun8i: Add PWM pin in H3

2016-08-31 Thread Milo Kim
H3 PA5 pin is assigned for single PWM channel. Cc: Rob Herring Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: devicet...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++ 1 file changed

[PATCH v2 4/4] pwm: sunxi: Add H3 support

2016-08-31 Thread Milo Kim
...@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- Documentation/devicetree/bindings/pwm/pwm-sun4i.txt | 1 + drivers/pwm/pwm-sun4i.c | 9 + 2 files changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/pwm-sun4i.txt b

[PATCH v2 2/4] ARM: dts: sun8i: Add PWM controller node in H3

2016-08-31 Thread Milo Kim
Cc: Rob Herring Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: devicet...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v2 3/4] pinctrl: sunxi: Remove unsupported PWM channel pinmux in H3

2016-08-31 Thread Milo Kim
Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c index 26a2ad3..518a92d 100644 --- a/drivers/pinctrl/sunxi

Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl

2016-08-31 Thread Milo Kim
Hi Maxime, On 08/26/2016 04:10 PM, Maxime Ripard wrote: Hi Milo, On Thu, Aug 25, 2016 at 03:44:54PM +0900, Milo Kim wrote: In H3, PA5 can be used as PWM and UART0. If the PWM is used, the console UART should be moved to other port. This patch enables UART1 pinctrl to support this case

[PATCH v2 0/4] Add PWM feature in Allwinner H3

2016-08-31 Thread Milo Kim
"default"; pinctrl-0 = <&uart1_pins_a>; status = "okay"; }; v2: Split v1 patch-set into several patches Milo Kim (4): ARM: dts: sun8i: Add PWM pin in H3 ARM: dts: sun8i: Add PWM controller node in H3 pinctrl: sunxi: Remov

Re: [PATCH v2 1/4] ARM: dts: sun8i: Add PWM pin in H3

2016-09-01 Thread Milo Kim
On 08/31/2016 05:33 PM, Chen-Yu Tsai wrote: + pwm0_pin_a: pwm0@0 { This is the only possible configuration. You can drop the _a suffix from the label, and @0 from the node name. OK, thanks for your review. Best regards, Milo

Re: [PATCH v2 1/4] ARM: dts: sun8i: Add PWM pin in H3

2016-09-01 Thread Milo Kim
On 09/01/2016 01:20 AM, Maxime Ripard wrote: Hi Milo, On Wed, Aug 31, 2016 at 05:25:17PM +0900, Milo Kim wrote: H3 PA5 pin is assigned for single PWM channel. Cc: Rob Herring Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: devicet...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc

[PATCH v2 1/4] ARM: dts: exynos: Enable HDMI for Arndale Octa board

2016-08-23 Thread Milo Kim
: linux-samsung-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Milo Kim --- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch

[PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

2016-08-23 Thread Milo Kim
ux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Milo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/

[PATCH v2 4/4] gpu: drm: exynos_hdmi: Use consolidated function on binding PHY DT property

2016-08-23 Thread Milo Kim
ux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Milo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drive

[PATCH v2 2/4] ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio'

2016-08-23 Thread Milo Kim
: linux-samsung-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Milo Kim --- Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt | 4 ++-- arch/arm/boot/dts/exynos4210-universal_c210.dts | 2

[PATCH v2 0/4] ARM: dts: exynos: Enable HDMI in Arndale Octa board

2016-08-23 Thread Milo Kim
instead of 'hpd-gpio' Milo Kim (4): ARM: dts: exynos: Enable HDMI for Arndale Octa board ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio' gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property gpu: drm: exynos_hdmi: Use consoli

Re: [PATCH 0/4] ARM: dts: exynos: Enable HDMI in Arndale Octa board

2016-08-23 Thread Milo Kim
On 08/24/2016 04:55 AM, Krzysztof Kozlowski wrote: I saw DTS patches on linux-samsung-soc patchwork but still I would appreciate if you send them to appropriate maintainers pointed by get_maintainers.pl script. DTS stuff goes through samsung-soc tree. Thanks for your tip. I've just sent out the

Re: [PATCH v2 1/4] ARM: dts: exynos: Enable HDMI for Arndale Octa board

2016-08-24 Thread Milo Kim
Hi Andrzej, On 08/24/2016 02:28 PM, Andrzej Hajda wrote: Please use ddc property in hdmi node, instead of this legacy binding. See exynos4210-universal_c210.dts or exynos4412-odroid-common.dtsi for reference. Cool! I prefer this simple property. Thanks for the review. Best regards, Milo

Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

2016-08-24 Thread Milo Kim
Hi Andrzej, On 08/24/2016 02:55 PM, Andrzej Hajda wrote: This is mistake introduced by other patch, of_node_put should be called on np, after calling of_find_i2c_adapter_by_node. You can fix it in your patch as well. I think you can move of_find_i2c_adapter_by_node also to this function and ren

[PATCH v3 2/5] ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio'

2016-08-24 Thread Milo Kim
referred property, 'hpd-gpios' instead of 'hpd-gpio'. Acked-by: Rob Herring Reviewed-by: Andrzej Hajda Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: devicet...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-kernel@vger.ke

[PATCH v3 3/5] gpu: drm: exynos_hdmi: Move DDC logic into single function

2016-08-24 Thread Milo Kim
-samsung-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Milo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c | 46 1 file changed, 25 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH v3 1/5] ARM: dts: exynos: Enable HDMI for Arndale Octa board

2016-08-24 Thread Milo Kim
data channel I2C #2 is assigned for the HDMI DDC. It enables the EDID access. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Rob Herring Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- arch/arm/boot/dts

[PATCH v3 5/5] gpu: drm: exynos_hdmi: Remove duplicate initialization of regulator bulk consumer

2016-08-24 Thread Milo Kim
-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Milo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c

[PATCH v3 4/5] gpu: drm: exynos_hdmi: Move PHY logic into single function

2016-08-24 Thread Milo Kim
...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Milo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c | 63 +++- 1 file changed, 33 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v3 0/5] ARM: dts: exynos: Enable HDMI in Arndale Octa board

2016-08-24 Thread Milo Kim
ve duplicate code of regulator consumer initialization. v2: Include DRM and Exynos maintainers and resend the patch-set. Add Rob's ack for the patch, [PATCH 2/4] ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio' Milo Kim (5): ARM: dts: exynos: Enable HDMI f

[PATCH 1/2] pwm: sun4i: Add Allwinner H3 support

2016-08-24 Thread Milo Kim
rl-names = "default"; pinctrl-0 = <&uart1_pins_a>; status = "okay"; }; Cc: Chen-Yu Tsai Cc: Maxime Ripard Cc: Rob Herring Cc: Thierry Reding Signed-off-by: Milo Kim --- Documentation/devicetree/bindings/pwm/pwm-sun4i.txt |

[PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl

2016-08-24 Thread Milo Kim
In H3, PA5 can be used as PWM and UART0. If the PWM is used, the console UART should be moved to other port. This patch enables UART1 pinctrl to support this case. PA5: PWM PG6, PG7: debug console Cc: Chen-Yu Tsai Cc: Maxime Ripard Cc: Rob Herring Signed-off-by: Milo Kim

Re: [PATCH 1/2] pwm: sun4i: Add Allwinner H3 support

2016-08-26 Thread Milo Kim
Hi Maxime, On 08/26/2016 05:51 AM, Maxime Ripard wrote: Remember to use get_maintainers to send your patches, you missed a few mailing lists (linux-arm-kernel, for example), developpers (Alexandre Belloni, the original author of the driver) and maintainers (Linus Walleij for the pinctrl changes)

Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl

2016-08-26 Thread Milo Kim
On 08/26/2016 04:10 PM, Maxime Ripard wrote: + uart1_pins_a: uart1@0 { > + allwinner,pins = "PG6", "PG7"; > + allwinner,function = "uart1"; > + allwinner,drive = ; > + allwinn

[RFC 1/4] of: add of_dev_get_platdata()

2015-08-28 Thread Milo Kim
ant Likely Cc: Greg Kroah-Hartman Cc: Lee Jones Cc: Rob Herring Cc: Samuel Ortiz Cc: Tony Lindgren Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- drivers/of/device.c | 46 ++ include/linux/of_dev

[RFC 2/4] input: touchscree: mms114: use of_dev_get_platdata()

2015-08-28 Thread Milo Kim
Herring Cc: Samuel Ortiz Cc: Tony Lindgren Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim --- drivers/input/touchscreen/mms114.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/drivers/input

[RFC 4/4] usb: musb: use of_dev_get_platdata()

2015-08-28 Thread Milo Kim
'of_dev_get_platdata()' makes if-statements simple. Cc: Dmitry Torokhov Cc: Felipe Balbi Cc: Grant Likely Cc: Greg Kroah-Hartman Cc: Lee Jones Cc: Rob Herring Cc: Samuel Ortiz Cc: Tony Lindgren Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by

[RFC 3/4] mfd: tps65910: use of_dev_get_platdata()

2015-08-28 Thread Milo Kim
ernel.org Signed-off-by: Milo Kim --- drivers/mfd/tps65910.c | 49 - 1 file changed, 16 insertions(+), 33 deletions(-) diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c index 7612d89..2a068d7 100644 --- a/drivers/mfd/tps65910.c +++ b/dr

[RFC 0/4] of: introduce of_dev_get_platdata()

2015-08-28 Thread Milo Kim
rtiz Cc: Tony Lindgren Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Milo Kim (4): of: introduce of_dev_get_platdata() input: touchscree: mms114: use of_dev_get_platdata() mfd: tps65910: use of_dev_get_platdata() usb: musb: use of_dev_get_platdata() drivers/input/

Re: [PATCH 01/10] mfd: Add TI LMU driver

2014-02-18 Thread Milo Kim
Hi Lee, On 02/18/2014 05:21 PM, Lee Jones wrote: + pdata->en_gpio = of_get_named_gpio(node, "ti,enable-gpio", 0); There is a global DT property for this already. I've not found it yet, but I agree it looks like general property. So I'll replace "ti,enable-gpio" with "ti,lmu-en-gpio".

Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns

2013-11-07 Thread Milo Kim
Hi Pali, Sorry for the late reply. On 10/26/2013 03:21 AM, Pali Rohár wrote: On Friday 25 October 2013 19:10:07 Bryan Wu wrote: On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár wrote: On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote: On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim wrote: This

Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns

2013-11-19 Thread Milo Kim
Hi Bryan, On 11/20/2013 04:20 AM, Bryan Wu wrote: On Tue, Nov 19, 2013 at 2:35 AM, Pali Rohár wrote: >Hello, > >now I tested that patch on top of 3.12-rc5 with this led example: > > # Clearing LED-state to be sure > echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode >

[PATCH 1/3] leds: lp5521/5523: Fix multiple engine usage bug

2013-11-20 Thread Milo Kim
should be reset when the driver is unloaded and on initializing the LP5523 driver. So, new functions are used for this handling - lp5521/5523_stop_all_engines(). Cc: Pali Rohár Signed-off-by: Milo Kim --- drivers/leds/leds-lp5521.c | 18 -- drivers/leds/leds-lp5523.c | 20

[PATCH v2] leds: lp5521/5523: Remove duplicate mutex

2013-12-02 Thread Milo Kim
Signed-off-by: Milo Kim --- drivers/leds/leds-lp5521.c | 12 drivers/leds/leds-lp5523.c | 12 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c index 26f89ac..2ec34cf 100644 --- a/drivers/leds/led

Re: [PATCH 2/3] leds: lp5521/5523: Remove duplicate mutex

2013-12-02 Thread Milo Kim
Hi Bryan, On 12/03/2013 04:40 AM, Bryan Wu wrote: On Wed, Nov 20, 2013 at 10:14 PM, Milo Kim wrote: It can be a problem when a pattern is loaded via the firmware interface. LP55xx common driver has already locked the mutex in 'lp55xx_firmware_loaded()'. So it should be deleted.

Re: [PATCH v3 3/4] pwm: add LP3943 PWM driver

2013-12-03 Thread Milo Kim
Hi Thierry, On 12/03/2013 07:24 PM, Thierry Reding wrote: On Thu, Sep 12, 2013 at 10:33:50AM +0900, Milo Kim wrote: This is the other of the LP3943 MFD driver. LP3943 can be used as a PWM generator, up to 2 channels. * Two PWM generators supported * Supported PWM operations request, free

Re: [PATCH v4 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

2013-12-03 Thread Milo Kim
Hello Guys, Could you check this patchset? Driver documentation was moved from 'Documentation' to 'drivers/mfd/lp3943.c'. Thanks, Milo On 09/25/2013 01:22 PM, Milo Kim wrote: LP3943 is an integrated device capable of driving 16 output channels. It can be used for G

Re: [PATCH 09/13] video/backlight: LP8788 needs PWM

2014-04-24 Thread Milo Kim
s per driver based on feedback. Signed-off-by: Arnd Bergmann Signed-off-by: Peter Griffin Thanks! Acked-by: Milo Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH 12/13] video/backlight: LP855X needs PWM

2014-04-24 Thread Milo Kim
On 04/24/2014 09:28 PM, Peter Griffin wrote: From: Arnd Bergmann The LP855X driver cannot be successfully built if we don't enable the PWM subsystem. This patch makes that dependency explicit in Kconfig and prevents broken randconfig builds. Thanks! Acked-by: Milo Kim -- To unsubs

[PATCH 00/10] Support TI Light Management Unit devices

2014-02-13 Thread Milo Kim
: Chip dependent code LM3633 LED: LED subsystem, pattern generation LM3631 regulator : Regulator drivers for the display bias Device tree documentation is also included. Milo Kim (10): mfd: Add TI LMU driver backlight: Add TI LMU backlight common driver backlight: ti-lmu

[PATCH 03/10] backlight: ti-lmu-backlight: Add LM3532 driver

2014-02-13 Thread Milo Kim
LM3532 has 3 backlight strings and 8 bit dimming is supported. PWM brightness control is also supported. Common backlight driver is controlled by TI LMU backlight driver. Only LM3532 specific code is implemented here. Cc: Jingoo Han Cc: Bryan Wu Cc: Lee Jones Signed-off-by: Milo Kim

[PATCH 02/10] backlight: Add TI LMU backlight common driver

2014-02-13 Thread Milo Kim
- Backlight subsystem control - PWM brightness control - Shared device tree node Cc: Jingoo Han Cc: Bryan Wu Cc: Lee Jones Signed-off-by: Milo Kim --- drivers/video/backlight/Kconfig|7 + drivers/video/backlight/Makefile |1 + drivers/video/backlight/ti-lmu

[PATCH 01/10] mfd: Add TI LMU driver

2014-02-13 Thread Milo Kim
- LM3633 has 6 indicator LEDs. Programmable pattern is supported. Regulator - LM3631 has 5 regulators for the display bias. Cc: Samuel Ortiz Cc: Lee Jones Signed-off-by: Milo Kim --- drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile|1 + drivers/

[PATCH 08/10] leds: Add LM3633 driver

2014-02-13 Thread Milo Kim
LM3633 LED driver supports generic LED functions and pattern generation. Pattern is generated by using LMU effect driver APIs. Sysfs documentation is added. Cc: Bryan Wu Signed-off-by: Milo Kim --- Documentation/leds/leds-lm3633.txt | 38 +++ drivers/leds/Kconfig | 10

[PATCH 06/10] backlight: ti-lmu-backlight: Add LM3695 driver

2014-02-13 Thread Milo Kim
LM3695 has 2 backlight strings and 11 bit dimming is supported. Common backlight driver is controlled by TI LMU backlight driver. Only LM3695 specific code is implemented here. Cc: Jingoo Han Cc: Bryan Wu Cc: Lee Jones Signed-off-by: Milo Kim --- drivers/video/backlight/Kconfig |8

[PATCH 05/10] backlight: ti-lmu-backlight: Add LM3633 driver

2014-02-13 Thread Milo Kim
LM3633 has 3 backlight strings and 11 bit dimming is supported. PWM brightness control is also supported. Common backlight driver is controlled by TI LMU backlight driver. Only LM3633 specific code is implemented here. Cc: Jingoo Han Cc: Bryan Wu Cc: Lee Jones Signed-off-by: Milo Kim

[PATCH 07/10] backlight: ti-lmu-backlight: Add LM3697 driver

2014-02-13 Thread Milo Kim
LM3697 has 3 backlight strings and 11 bit dimming is supported. PWM brightness control is also supported. Common backlight driver is controlled by TI LMU backlight driver. Only LM3697 specific code is implemented here. Cc: Jingoo Han Cc: Bryan Wu Cc: Lee Jones Signed-off-by: Milo Kim

[PATCH 04/10] backlight: ti-lmu-backlight: Add LM3631 driver

2014-02-13 Thread Milo Kim
LM3631 has 2 backlight strings and 11 bit dimming is supported. PWM brightness control is also supported. Common backlight driver is controlled by TI LMU backlight driver. Only LM3631 specific code is implemented here. Cc: Jingoo Han Cc: Bryan Wu Cc: Lee Jones Signed-off-by: Milo Kim

[PATCH 09/10] regulator: Add LM3631 driver

2014-02-13 Thread Milo Kim
LM3631 regulator driver has 5 regulators. One boost output and four LDOs are used for the display module. Boost voltage is configurable but always on. Supported operations for LDOs are enabled/disabled and voltage change. Cc: Mark Brown Signed-off-by: Milo Kim --- drivers/regulator/Kconfig

[PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-13 Thread Milo Kim
Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. Cc: devicet...@vger.kernel.org Cc: Bryan Wu Cc: Jingoo Han Cc: Lee Jones Cc: Mark Brown Cc: Samuel Ortiz Signed-off-by: Milo Kim --- .../devicetree/bindings/leds/leds-lm3633.txt | 39 + Documentation

Re: [PATCH 00/10] Support TI Light Management Unit devices

2014-02-16 Thread Milo Kim
Hi Lee, On 02/14/2014 07:14 PM, Lee Jones wrote: Milo Kim (10): mfd: Add TI LMU driver backlight: Add TI LMU backlight common driver backlight: ti-lmu-backlight: Add LM3532 driver backlight: ti-lmu-backlight: Add LM3631 driver backlight: ti-lmu-backlight: Add LM3633 driver

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-16 Thread Milo Kim
Hi Mark, On 02/15/2014 05:50 AM, Mark Brown wrote: On Fri, Feb 14, 2014 at 03:32:44PM +0900, Milo Kim wrote: Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. Ah, sorry - I didn't notice that there were several different binding documents in the patch. @@

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-16 Thread Milo Kim
Hello Mark, Thanks for your detailed comments. I've fixed the structure and description. I'd like to have your feedback before submitting new patch-set. From 33faeeed69fa064cd476b252c5a7326a541e12b3 Mon Sep 17 00:00:00 2001 From: Milo Kim Date: Mon, 17 Feb 2014 14:32:39 +0900 Subje

Re: [PATCH 01/10] mfd: Add TI LMU driver

2014-02-17 Thread Milo Kim
Hi Lee, On 02/17/2014 06:57 PM, Lee Jones wrote: +static const struct resource lm3633_effect_resources[] = { + { + .name = LM3633_EFFECT_BL0_RAMPUP, + .flags = IORESOURCE_REG, + .start = LM3633_EFFECT_REGISTER(BL0_RAMPUP), + }, + { +

Re: [PATCH 06/16] mfd: lp3943: Make mfd_cell array const

2014-05-13 Thread Milo Kim
On 05/13/2014 07:58 PM, Krzysztof Kozlowski wrote: mfd_add_devices() expects array of struct mfd_cell to be const. Signed-off-by: Krzysztof Kozlowski Cc: Milo Kim Acked-by: Milo Kim Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

[PATCH v5 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

2013-12-05 Thread Milo Kim
K for the PWM driver and the DT documentation Milo Kim (4): mfd: add LP3943 MFD driver gpio: add LP3943 I2C GPIO expander driver pwm: add LP3943 PWM driver Documentation: add LP3943 DT bindings and document .../devicetree/bindings/gpio/gpio-lp3943.txt | 37 +++ Documentation/devic

[PATCH v5 1/4] mfd: add LP3943 MFD driver

2013-12-05 Thread Milo Kim
ata is PWM related, so parsing the device tree is implemented in the PWM driver. Signed-off-by: Milo Kim Acked-by: Lee Jones --- * Patch v5 Same as v4 * Patch v4 Driver description was moved from the documentation in patch v3. * Patch v3 Now, output pin number is exactly matched with

[PATCH v5 2/4] gpio: add LP3943 I2C GPIO expander driver

2013-12-05 Thread Milo Kim
It is defined as unsigned long type for atomic bit operation APIs, but only LSB 16bits are used because LP3943 has 16 outputs. Signed-off-by: Milo Kim Reviewed-by: Linus Walleij --- * Patch v5 and v4 No update, same as v3 * Patch v3 Use inline function instead of macro(), to_lp3943_gpio().

[PATCH v5 3/4] pwm: add LP3943 PWM driver

2013-12-05 Thread Milo Kim
outputs. Signed-off-by: Milo Kim Acked-by: Thierry Reding --- * Patch v5 Add Thierry's acknowledgement. * Patch v4 No update, same as v3. * Patch v3 Manual polarity not supported any more. Add encapsulation functions for accessing internal data structure. Use pwm_set_chip_dat

[PATCH v5 4/4] Documentation: add LP3943 DT bindings and document

2013-12-05 Thread Milo Kim
Bindings for LP3943 MFD, GPIO and PWM controller are added. Cc: devicet...@vger.kernel.org Cc: Lee Jones Cc: Linus Walleij Cc: Samuel Ortiz Signed-off-by: Milo Kim Acked-by: Thierry Reding --- .../devicetree/bindings/gpio/gpio-lp3943.txt | 37 + Documentation/devicetree

[PATCH RESEND v5 4/4] Documentation: add LP3943 DT bindings and document

2013-12-05 Thread Milo Kim
Bindings for LP3943 MFD, GPIO and PWM controller are added. Cc: devicet...@vger.kernel.org Cc: Lee Jones Cc: Linus Walleij Cc: Samuel Ortiz Signed-off-by: Milo Kim Acked-by: Thierry Reding --- .../devicetree/bindings/gpio/gpio-lp3943.txt | 37 + Documentation/devicetree

[PATCH RESEND v5 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

2013-12-05 Thread Milo Kim
K for the PWM driver and the DT documentation Milo Kim (4): mfd: add LP3943 MFD driver gpio: add LP3943 I2C GPIO expander driver pwm: add LP3943 PWM driver Documentation: add LP3943 DT bindings and document .../devicetree/bindings/gpio/gpio-lp3943.txt | 37 +++ Documentation/devic

[PATCH RESEND v5 1/4] mfd: add LP3943 MFD driver

2013-12-05 Thread Milo Kim
ata is PWM related, so parsing the device tree is implemented in the PWM driver. Signed-off-by: Milo Kim Acked-by: Lee Jones --- * Patch v5 Same as v4 * Patch v4 Driver description was moved from the documentation in patch v3. * Patch v3 Now, output pin number is exactly matched with

[PATCH RESEND v5 3/4] pwm: add LP3943 PWM driver

2013-12-05 Thread Milo Kim
outputs. Signed-off-by: Milo Kim Acked-by: Thierry Reding --- * Patch v5 Add Thierry's acknowledgement. * Patch v4 No update, same as v3. * Patch v3 Manual polarity not supported any more. Add encapsulation functions for accessing internal data structure. Use pwm_set_chip_dat

[PATCH RESEND v5 2/4] gpio: add LP3943 I2C GPIO expander driver

2013-12-05 Thread Milo Kim
It is defined as unsigned long type for atomic bit operation APIs, but only LSB 16bits are used because LP3943 has 16 outputs. Signed-off-by: Milo Kim Reviewed-by: Linus Walleij --- * Patch v5 and v4 No update, same as v3 * Patch v3 Use inline function instead of macro(), to_lp3943_gpio().

Re: [PATCH v5 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

2013-12-05 Thread Milo Kim
Hello guys, My apologies for too messy messages. Would you please refer to the patch-set with 'PATCH RESEND v5'? Thanks. Milo On 12/06/2013 11:08 AM, Milo Kim wrote: LP3943 is an integrated device capable of driving 16 output channels. It can be used for GPIO expander and PWM

  1   2   3   4   >