[RFC][PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-14 Thread Nicolas Boichat
Boichat From: Nicolas Boichat [EMAIL PROTECTED] --- drivers/hwmon/Kconfig| 24 + drivers/hwmon/Makefile |1 drivers/hwmon/applesmc.c | 964 ++ 3 files changed, 989 insertions(+), 0 deletions(-) diff --git a/drivers/hwmon/Kconfig b/drivers

Re: [RFC][PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-15 Thread Nicolas Boichat
Hello, Cong WANG wrote: 2007/3/14, Cong WANG wrote: I am sorry. I forgot to CC to the list. 2007/3/14, Nicolas Boichat wrote: Hello, snip +static ssize_t applesmc_show_fan_manual(struct device *dev, char *buf, + int

Re: Intel Core Duo/Solo Temperature Monitoring Working On Intel DG965 Motherboard

2007-03-15 Thread Nicolas Boichat
Hello, Justin Piszcz wrote: DISCLAIMER: This patch is still experimental. AUTHOR: Rudolf Marek has written the coretemp module for Intel Core Duo/Solo processors. Without this patch, you cannot monitor your CPU temperature, at least not on a DG965 motherboard. [snip] Commentary: It will

[PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-18 Thread Nicolas Boichat
Hello, Nicolas Boichat wrote: Hello, I developed, a while ago, a driver the Apple System Management Controller, which provides an accelerometer (Apple Sudden Motion Sensor), light sensors, temperature sensors, keyboard backlight control and fan control on Intel-based Apple's computers

Re: [PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-19 Thread Nicolas Boichat
Andrew Morton wrote: On Mon, 19 Mar 2007 13:19:00 +0800 Nicolas Boichat [EMAIL PROTECTED] wrote: This driver provides support for the Apple System Management Controller, which provides an accelerometer (Apple Sudden Motion Sensor), light sensors, temperature sensors, keyboard backlight

Re: [PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-20 Thread Nicolas Boichat
Hello, Andrew Morton wrote: On Mon, 19 Mar 2007 13:19:00 +0800 Nicolas Boichat [EMAIL PROTECTED] wrote: This driver provides support for the Apple System Management Controller, which provides an accelerometer (Apple Sudden Motion Sensor), light sensors, temperature sensors, keyboard

Re: [RFC][PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-20 Thread Nicolas Boichat
Hello, Bob Copeland wrote: On 3/14/07, Nicolas Boichat [EMAIL PROTECTED] wrote: Hello, I developed, a while ago, a driver the Apple System Management Controller, which provides an accelerometer (Apple Sudden Motion Sensor), light sensors, temperature sensors, keyboard backlight control

Re: [lm-sensors] [RFC][PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-22 Thread Nicolas Boichat
side on the laptop (= tilted to the left) - y value gets more negative when you tilt the laptop backwards (simply cat /sys/devices/platform/hdaps/position) Thanks, Best regards, Nicolas Invert x axis on applesmc input device to make it usable as a joystick. Signed-off-by: Nicolas Boichat [EMAIL

[BUG] Patch CPU hotplug: call check_tsc_sync_source() with irqs off breaks some drivers

2007-03-25 Thread Nicolas Boichat
with and without this commit. You can get the raw dmesg outputs, and my .config there: http://www.boichat.ch/nicolas/linux/ Best regards, Nicolas Boichat --- dmesg-2.6.21-rc4-head-notimestamp 2007-03-26 02:19:57.0 +0800 Vanilla git +++ dmesg-2.6.21-rc4-head-without-d04f41-notimestamp

Re: [BUG] Patch CPU hotplug: call check_tsc_sync_source() with irqs off breaks some drivers

2007-03-25 Thread Nicolas Boichat
Nicolas Boichat wrote: Hello, I'm running a Macbook Pro first generation (Core Duo, so x86). I ran accross these two problems while upgrading from 2.6.21-rc3 to the current git HEAD: 1. appletouch cannot initialize the device properly at boot time (the module is automatically loaded

Re: [BUG] Macbook pro timer bug (was: Patch CPU hotplug: call check_tsc_sync_source() with irqs off breaks some drivers)

2007-03-26 Thread Nicolas Boichat
Ingo Molnar wrote: * Nicolas Boichat [EMAIL PROTECTED] wrote: I found out which commit seems to cause these bugs: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d04f41e35343f1d788551fd3f753f51794f4afcf The latest GIT without this commit works fine

[PATCH] Apple SMC driver - fix input device

2007-04-09 Thread Nicolas Boichat
Hi Dmitry, Sorry I did not receive your message originally, someone else pointed it to me recently, and I recovered it from LKML archives. Dmitry Torokhov wrote: Hi Nicolas, On Monday 19 March 2007 01:19, Nicolas Boichat wrote: + /* initialize the input class

Re: [lm-sensors] [RFC][PATCH] Apple SMC driver (hardware monitoring and control)

2007-04-11 Thread Nicolas Boichat
Hi, Thanks for your comments. Jean Delvare wrote: Hi Nicolas, Sorry for the delay. On Wed, 14 Mar 2007 17:29:39 +0800, Nicolas Boichat wrote: I developed, a while ago, a driver the Apple System Management Controller, which provides an accelerometer (Apple Sudden Motion Sensor), light

[PATCH 1/2] Apple SMC driver - standardize and sanitize sysfs tree + minor features addition

2007-04-12 Thread Nicolas Boichat
problem, and when the driver is unloaded. - Add data buffer length sanity checks. - Improvements of SMC keys' comments (add data type reported by the device). - Add temperature sensors to Macbook Pro. - Add support for reading fan physical position (e.g. Left Side) Signed-off-by: Nicolas Boichat

[PATCH 2/2] Apple SMC driver - implement key enumeration

2007-04-13 Thread Nicolas Boichat
Implement key enumeration in applesmc. Signed-off-by: Nicolas Boichat [EMAIL PROTECTED] --- drivers/hwmon/applesmc.c | 263 ++ 1 files changed, 262 insertions(+), 1 deletions(-) diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c index 531bc9a

[PATCH] applesmc - fix crash when activating a led trigger on the keyboard backlight

2007-04-14 Thread Nicolas Boichat
. Reduce wait_status timetout from 100ms to 2ms, as wait_status either takes less than 1.5 ms, or fails. Signed-off-by: Nicolas Boichat [EMAIL PROTECTED] --- drivers/hwmon/applesmc.c | 25 - 1 files changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/hwmon

[PATCH] applesmc - fix crash when activating a led trigger on the keyboard backlight - use a workqueue

2007-04-14 Thread Nicolas Boichat
Hi again, Richard Purdie wrote: Hi, On Sat, 2007-04-14 at 16:05 +0800, Nicolas Boichat wrote: Bradley Hook wrote: Slightly off-topic, but I've been experiencing a minor bug in the keyboard backlight feature. I say it is minor only because the feature serves no real functional

[PATCH] Leadtek Winfast remote controls

2005-04-18 Thread Nicolas Boichat
Winfast remote controls. Signed-off-by: Nicolas Boichat [EMAIL PROTECTED] --- drivers/media/common/ir-common.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff -rpuN drivers/media.old/common/ir-common.c drivers/media/common/ir-common.c --- drivers/media.old/common/ir

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Nicolas Boichat
Hello, On Thu, 2005-04-21 at 01:10 +0200, Alexander Nyberg wrote: The new out of line put_user() assembly on x86_64 changes %rcx without telling GCC about it causing things like: http://bugme.osdl.org/show_bug.cgi?id=4515 Thank you, this patch fixes the message queue problem. Best

Re: x86_64: Bug in new out of line put_user()

2005-04-21 Thread Nicolas Boichat
Hello Alexander, I have other kind of problems with this patch... With 2.6.12-rc2 + your patch, when I run OpenOffice (a 32-bit application), I get this in dmesg : Unable to handle kernel paging request at 2d9280b0 RIP: 801f5d70{__put_user_4+32} PGD 0 Oops: 0002 [1] SMP CPU 0

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-25 Thread Nicolas Boichat
On Thu, Jun 25, 2015 at 11:59 PM, Lars-Peter Clausen l...@metafoo.de wrote: [...] diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 116655d..09aaaf5 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -135,6 +135,12 @@ typedef void (*regmap_unlock)(void *);

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-25 Thread Nicolas Boichat
On Fri, Jun 26, 2015 at 12:08 AM, Mark Brown broo...@kernel.org wrote: [...] As far as I can tell we're likely to end up needing a key per regmap or something similar. Since the number of lockdep classes itself is also limited we should avoid creating extra lockdep classes when we can. I

[RFC PATCH 2/2] ASoC: rt5677: Add lockdep class to silence lockdep warnings

2015-06-25 Thread Nicolas Boichat
/0x18c [2.569609] [ffc0008a4ae8] kernel_init_freeable+0x144/0x1e4 [2.569613] [ffc0005de3a4] kernel_init+0x10/0xd4 Signed-off-by: Nicolas Boichat drink...@chromium.org --- sound/soc/codecs/rt5677.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/soc/codecs/rt5677.c b/sound

[RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-25 Thread Nicolas Boichat
message and regmap.h documentation] Signed-off-by: Nicolas Boichat drink...@chromium.org --- I'm trying to revive Antti's patch [1], as we are hitting similar issue with rt5677 driver. I only updated the commit message and documentation, I kept both Signed-off-by and From lines, with a small note

[PATCH] regmap: Use different lockdep class for each regmap init call

2015-06-30 Thread Nicolas Boichat
identifies the 2 regmaps as separate. Signed-off-by: Nicolas Boichat drink...@chromium.org --- Following up on the discussion here: http://mailman.alsa-project.org/pipermail/alsa-devel/2015-June/094124.html , and Lars-Peter's idea on how to define the macros, this converts all regmap_init calls

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-29 Thread Nicolas Boichat
On Mon, Jun 29, 2015 at 8:59 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 06/29/2015 02:51 PM, Nicolas Boichat wrote: On Fri, Jun 26, 2015 at 11:16 AM, Nicolas Boichat drink...@chromium.org wrote: On Fri, Jun 26, 2015 at 12:08 AM, Mark Brown broo...@kernel.org wrote: [...] As far

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-29 Thread Nicolas Boichat
On Fri, Jun 26, 2015 at 11:16 AM, Nicolas Boichat drink...@chromium.org wrote: On Fri, Jun 26, 2015 at 12:08 AM, Mark Brown broo...@kernel.org wrote: [...] As far as I can tell we're likely to end up needing a key per regmap or something similar. Since the number of lockdep classes

[PATCH v2] spi: bitbang: Replace spinlock by mutex

2015-08-16 Thread Nicolas Boichat
for similar purpose. Signed-off-by: Nicolas Boichat drink...@chromium.org --- Going the safer way and just replacing the spinlock by a mutex. Applies on top of broonie-sound/for-next, and compile-tested on x86-64/arm (allyesconfig) and ppc44x (defconfig+SPI driver), and runtime-tested on an arm

Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

2015-06-29 Thread Nicolas Boichat
identifies the 2 locks as separate. Signed-off-by: Nicolas Boichat drink...@chromium.org --- drivers/base/regmap/regmap-i2c.c | 22 ++ drivers/base/regmap/regmap.c | 31 +- include/linux/regmap.h | 91 ++-- 3 files changed, 113

[PATCH 1/3] spi: bitbang: Replace spinlock by mutex when calling chipselect

2015-08-04 Thread Nicolas Boichat
Replace spinlock + busy variable by a mutex, and get rid of spi_bitbang_prepare_hardware and spi_bitbang_unprepare_hardware, which are not useful anymore. Signed-off-by: Nicolas Boichat drink...@chromium.org --- Actually, I'm not sure if I understand the existing code: why are we not waiting

[PATCH 3/3] spi: s3c24xx: Convert spinlock to mutex

2015-08-04 Thread Nicolas Boichat
bitbang-lock is now a mutex: replace spinlock function calls by mutex functions. Signed-off-by: Nicolas Boichat drink...@chromium.org --- drivers/spi/spi-s3c24xx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c index

[PATCH 2/3] spi: ppc44x: Remove chipselect from setupxfer

2015-08-04 Thread Nicolas Boichat
The chipselect operation is already done in spi_bitbang_transfer_one, or in spi_bitbang_setup, so there is no need to do it in setupxfer as well. Signed-off-by: Nicolas Boichat drink...@chromium.org --- drivers/spi/spi-ppc4xx.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers

Re: [PATCH 1/3] spi: bitbang: Replace spinlock by mutex when calling chipselect

2015-08-05 Thread Nicolas Boichat
On Tue, Aug 4, 2015 at 6:59 PM, Mark Brown broo...@kernel.org wrote: On Tue, Aug 04, 2015 at 02:09:56PM +0800, Nicolas Boichat wrote: [snip] Actually, I'm not sure if I understand the existing code: why are we not waiting for busy to go down to 0, then call chipselect, instead of not calling

[PATCH RESEND] regmap: Move documentation to regmap.h

2015-08-11 Thread Nicolas Boichat
Init functions defined in regmap*.c files are now prefixed with __, take lockdep key and class parameters, and should not be called directly: move the documentation to regmap.h, where the macros are defined. Signed-off-by: Nicolas Boichat drink...@chromium.org --- Resending without modification

Re: [v5,2/3] spi: mediatek: Add spi bus for Mediatek MT8173

2015-08-11 Thread Nicolas Boichat
Hi Leilk, On Fri, Aug 7, 2015 at 3:19 PM, leilk@mediatek.com wrote: This patch adds basic spi bus for MT8173. Signed-off-by: Leilk Liu leilk@mediatek.com --- Change in this patch: 1. change pad-select to mediatek,pad-select. 2. modify clk relevant implement. ---

Re: [PATCH] regmap: Move documentation to regmap.h

2015-08-10 Thread Nicolas Boichat
Hi Mark, On Wed, Jul 8, 2015 at 6:32 PM, Nicolas Boichat drink...@chromium.org wrote: Init functions defined in regmap*.c files are now prefixed with __, take lockdep key and class parameters, and should not be called directly: move the documentation to regmap.h, where the macros are defined

Re: [PATCHv2 0/3] regmap: Use different lockdep class for each regmap init call

2015-07-23 Thread Nicolas Boichat
Hi Mark, On Wed, Jul 8, 2015 at 2:30 PM, Nicolas Boichat drink...@chromium.org wrote: Second version. Small fixup in the regmap patch itself [3/3] (the declaration of __devm_regmap_init_ac97 was missing lock_key/name parameters). Also, there are 2 drivers that are using function pointers

[PATCH] ASoC: rt5645: Remove unused rt5645 variable

2015-07-16 Thread Nicolas Boichat
ASoC: rt5645: Simplify rt5645_enable_push_button_irq removes the test that accessed rt5645-pdata.jd_mode (that test is now done in rt5645_jack_detect only), so we do not need that variable anymore. Signed-off-by: Nicolas Boichat drink...@chromium.org --- Applies on top of topic/rt5645. Sorry

Re: [alsa-devel] [PATCH] ASoC: rt5645: remove unused variable

2015-07-17 Thread Nicolas Boichat
On Fri, Jul 17, 2015 at 3:23 PM, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: We were getting a build warning about unused variable. This variable was a leftover from: a4e3c5fa955c (ASoC: rt5645: Simplify rt5645_enable_push_button_irq) Yes, I already sent a patch to fix it:

[PATCH] mfd: cros ec: Lock the SPI bus while holding chipselect

2015-10-29 Thread Nicolas Boichat
. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- drivers/mfd/cros_ec_spi.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c index 30a296b..659240d 100644 --- a/drive

[PATCH v2] mfd: cros ec: Lock the SPI bus while holding chipselect

2015-11-08 Thread Nicolas Boichat
. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- v2: Move bus_unlock earlier in the functions. Applies on top on linux-next/master (20151109) drivers/mfd/cros_ec_spi.c | 41 + 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/d

[PATCH v2] spi: mediatek: single device does not require cs_gpios

2015-11-08 Thread Nicolas Boichat
This fixes the crash, and re-introduces backward compatibility. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- v2: Use gpio_is_valid() Applies on top of broonie/spi.git/for-next. drivers/spi/spi-mt65xx.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletion

Re: [PATCH] mfd: cros ec: Lock the SPI bus while holding chipselect

2015-11-03 Thread Nicolas Boichat
+gwen...@chromium.org On Thu, Oct 29, 2015 at 4:17 PM, Nicolas Boichat <drink...@chromium.org> wrote: > @@ -482,6 +493,7 @@ static int cros_ec_pkt_xfer_spi(struct cros_ec_device > *ec_dev, > > ret = len; > exit: > + spi_bus_unlock(ec_spi->spi->m

[PATCH] spi: mediatek: single device does not require cs_gpios

2015-11-04 Thread Nicolas Boichat
This fixes the crash, and re-introduces backward compatibility. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- Applies on top of broonie/spi.git topic/mtk. Thanks! drivers/spi/spi-mt65xx.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a

Re: [PATCH] spi: mediatek: single device does not require cs_gpios

2015-11-05 Thread Nicolas Boichat
On Thu, Nov 5, 2015 at 5:16 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Thu, Nov 5, 2015 at 7:50 AM, Nicolas Boichat <drink...@chromium.org> wrote: [...] >> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c >> index 563954a..f694031 1006

[PATCH] regmap: Move documentation to regmap.h

2015-07-08 Thread Nicolas Boichat
Init functions defined in regmap*.c files are now prefixed with __, take lockdep key and class parameters, and should not be called directly: move the documentation to regmap.h, where the macros are defined. Signed-off-by: Nicolas Boichat drink...@chromium.org --- Applies on top of this series

Re: [PATCH] regmap: Use different lockdep class for each regmap init call

2015-07-07 Thread Nicolas Boichat
On Tue, Jul 7, 2015 at 8:13 PM, Mark Brown broo...@kernel.org wrote: On Wed, Jul 01, 2015 at 12:43:59PM +0800, Nicolas Boichat wrote: (this also applies to all other regmap_init functions...). We do not want to document the lock_key/name parameters, so we could either leave it like

[PATCHv2 2/3] thermal: sti: Add parentheses around bridge-ops-regmap_init call

2015-07-08 Thread Nicolas Boichat
regmap_init(...) is a macro since commit regmap: Use different lockdep class for each regmap init call. That same name is used as a function pointer: prevent its expansion by adding parentheses around the function pointer. Signed-off-by: Nicolas Boichat drink...@chromium.org --- drivers/thermal

[PATCHv2 1/3] mfd: vexpress: Add parentheses around bridge-ops-regmap_init call

2015-07-08 Thread Nicolas Boichat
regmap_init(...) is a macro since commit regmap: Use different lockdep class for each regmap init call. That same name is used as a function pointer: prevent its expansion by adding parentheses around the function pointer. Signed-off-by: Nicolas Boichat drink...@chromium.org --- drivers/bus

[PATCHv2 0/3] regmap: Use different lockdep class for each regmap init call

2015-07-08 Thread Nicolas Boichat
to prevent the preprocessor from substituting them. Patches 1+2 should be pushed first to avoid breaking git bissect. Compile tested with allyesconfig on x86_64 and arm. Nicolas Boichat (3): mfd: vexpress: Add parentheses around bridge-ops-regmap_init call thermal: sti: Add parentheses around

[PATCHv2 3/3] regmap: Use different lockdep class for each regmap init call

2015-07-08 Thread Nicolas Boichat
identifies the 2 regmaps as separate. Signed-off-by: Nicolas Boichat drink...@chromium.org --- drivers/base/regmap/regmap-ac97.c | 22 +++-- drivers/base/regmap/regmap-i2c.c | 22 +++-- drivers/base/regmap/regmap-mmio.c | 27 -- drivers/base/regmap/regmap-spi.c | 22 +++-- drivers/base

[PATCH] watchdog: mtk_wdt: Use MODE_KEY when stopping the watchdog

2015-11-17 Thread Nicolas Boichat
WDT_MODE value need to be or-ed with MODE_KEY when setting watchdog mode. Add it to mtk_wdt_stop function, so that the watchdog can be stopped (e.g. during suspend). Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- drivers/watchdog/mtk_wdt.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v2] spi: bitbang: Replace spinlock by mutex

2015-08-31 Thread Nicolas Boichat
Hi Mark, On Mon, Aug 17, 2015 at 11:52 AM, Nicolas Boichat <drink...@chromium.org> wrote: > chipselect (in the case of spi-gpio: spi_gpio_chipselect, which > calls gpiod_set_raw_value_cansleep) can sleep, so we should not > hold a spinlock while calling it from spi_bitbang_setup.

Re: [PATCH v7] arm64: dts: Add spi bus dts

2015-09-08 Thread Nicolas Boichat
k Liu <leilk@mediatek.com> Reviewed-and-Tested-by: Nicolas Boichat <drink...@chromium.org> > --- > Change in this patch: > 1. fix spi clock flow usage error. > --- > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 18 ++ > arch/arm64/boot/dts/mediatek/mt

Re: [PATCHv3 3/3] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2015-09-14 Thread Nicolas Boichat
Hi Enric, Partial review for now, thanks for you work. Best, On Thu, Sep 10, 2015 at 06:35:52PM +0200, Enric Balletbo i Serra wrote: > At the moment it only supports ANX7814. > > The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > designed for portable devices. > > This

[PATCH] modpost: Add flag -f for making section mismatches fatal

2015-10-01 Thread Nicolas Boichat
when using allmodconfig on some architectures, and we do not want to break these builds by default. Signed-off-by: Nicolas Boichat <drink...@chromium.org> Change-Id: Ic346706e3297c9f0d790e3552aa94e5cff9897a6 --- I'm trying to revive this old patch. When it was first submitted [1], Jonath

[PATCH v2] modpost: Add flag -E for making section mismatches fatal

2015-10-02 Thread Nicolas Boichat
when using allmodconfig on some architectures, and we do not want to break these builds by default. Signed-off-by: Nicolas Boichat <drink...@chromium.org> Change-Id: Ic346706e3297c9f0d790e3552aa94e5cff9897a6 --- v2 (Rusty Russell feedback): - Renamed flag from -f to -E (-f means force,

Re: [PATCH v2 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

2015-12-07 Thread Nicolas Boichat
On Thu, Nov 19, 2015 at 6:46 PM, Andrew-CT Chen wrote: > Add Mediatek EFUSE driver to access hardware data like > thermal sensor calibration or HDMI impedance. > > Signed-off-by: Andrew-CT Chen > --- > drivers/nvmem/Kconfig | 11

[PATCH] spi: mediatek: Prevent overflows in FIFO transfers

2015-12-27 Thread Nicolas Boichat
memcpy on the remainder of the bytes. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- drivers/spi/spi-mt65xx.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c index 00a36da..8763eff 100644 -

[PATCH v3] mfd: cros ec: Lock the SPI bus while holding chipselect

2015-11-24 Thread Nicolas Boichat
. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- v2: Move bus_unlock earlier in the functions. v3: Remove comments. Applies on top on linux-next/master (20151124) drivers/mfd/cros_ec_spi.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff

Re: [RFC PATCH 1/2] drm: bridge: anx7688: Add anx7688 bridge driver support.

2016-06-22 Thread Nicolas Boichat
+Philipp On Wed, Jun 22, 2016 at 11:54 AM, Archit Taneja <arch...@codeaurora.org> wrote: > > > On 6/22/2016 8:14 AM, Nicolas Boichat wrote: >> >> Hi Archit, >> >> Thanks for your reply. >> >> On Tue, Jun 21, 2016 at 11:39 PM, Archit T

Re: [RFC PATCH 1/2] drm: bridge: anx7688: Add anx7688 bridge driver support.

2016-06-21 Thread Nicolas Boichat
Hi Archit, Thanks for your reply. On Tue, Jun 21, 2016 at 11:39 PM, Archit Taneja <arch...@codeaurora.org> wrote: > Hi, > > On 6/20/2016 12:44 PM, Nicolas Boichat wrote: >> >> ANX7688 is a HDMI to DP converter (as well as USB-C port controller), >> tha

[RFC PATCH 2/2] devicetree: Add ANX7688 transmitter binding

2016-06-20 Thread Nicolas Boichat
ANX7688 is a transmitter to support DisplayPort over USB-C for smartphone and tablets. This binding only describes the HDMI to DP component of the chip. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- .../devicetree/bindings/video/bridge/anx7688.txt | 32 +++

Re: [RFC PATCH 1/2] drm: bridge: anx7688: Add anx7688 bridge driver support.

2016-06-22 Thread Nicolas Boichat
Hi Philipp, On Wed, Jun 22, 2016 at 4:51 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > Hi Nicolas, > > Am Mittwoch, den 22.06.2016, 14:32 +0800 schrieb Nicolas Boichat: >> >> Actually, experimenting a bit more with the code, I realized that the >>

[RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE

2016-02-16 Thread Nicolas Boichat
system. Correct it here. Signed-off-by: Lisa Du <c...@marvell.com> Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- This patch was first sent upstream here: https://lkml.org/lkml/2015/5/28/747, but was not picked up (probably because it was part of a bigger series that refactore

Re: [PATCH v2 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-08 Thread Nicolas Boichat
@chromium.org> > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> Some minor nits below, otherwise: Tested-by: Nicolas Boichat <drink...@chromium.org> Reviewed-by: Nicolas Boichat <drink...@chromium.org> > --- > > Changes since v1: > - Dan

[PATCH 2/2] mmc: mediatek: Use mmc_regulator_set_vqmmc in start_signal_voltage_switch

2016-03-03 Thread Nicolas Boichat
compatibility. 2. We get rid of a few more warnings when probing unsupported voltages. 3. We get rid of some non-mediatek specific code in mtk-sd. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- Similar to e0848f5d294c703917260a6228cc08b8be46c527 mmc: dw_mm

[PATCH 1/2] mmc: mediatek: Change signal voltage error to dev_dbg()

2016-03-03 Thread Nicolas Boichat
In commit ceae98f20e36 ("mmc: core: Try other signal levels during power up") we can see that there are times when it's valid to try several signal voltages. Don't print an ugly error in the logs when that happens. Signed-off-by: Nicolas Boichat <drink...@chromium.org&

INFO: inconsistent lock state in ecryptfs_calculate_md5

2016-04-14 Thread Nicolas Boichat
Hi, We've run into the following lockdep warning while using a system with ecryptfs, under heavy memory pressure. If I understand the issue correctly, fs/ecryptfs/crypto.c:ecryptfs_calculate_md5: - Locks _stat->cs_hash_tfm_mutex -> Calls crypto_alloc_hash -> Calls crypto_alloc_base ->

[RFC PATCH 3/4] CHROMIUM: drm: bridge: Generic GPIO mux driver

2016-06-27 Thread Nicolas Boichat
This driver supports single input, 2 output display mux (e.g. HDMI mux), that provides its status via a GPIO. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- drivers/gpu/drm/bridge/Kconfig| 11 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/

[RFC PATCH 0/4] drm: bridge: anx7688 and mux drivers

2016-06-27 Thread Nicolas Boichat
e 1 by filtering only when ANX7688 is active. I understand this patch series might not be acceptable as-is, but I hope this sort of setup can be taken into account when better support for connector drivers is introduced. Thanks! Best, Nicolas Nicolas Boichat (4): drm: bridge: anx7688: Add anx7

[RFC PATCHv2 1/4] FROMLIST: drm: bridge: anx7688: Add anx7688 bridge driver support.

2016-06-27 Thread Nicolas Boichat
nalogix,anx7688", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, anx7688_match_table); +#endif + +static struct i2c_driver anx7688_driver = { + .driver = { + .name = "anx7688", + .of_match_table = of_match_ptr(anx7688_match_table), +

[RFC PATCH 4/4] CHROMIUM: devicetree: Add GPIO display mux binding

2016-06-27 Thread Nicolas Boichat
Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- .../devicetree/bindings/drm/bridge/gpio-mux.txt| 59 ++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/drm/bridge/gpio-mux.txt diff --git a/Documentation/devicetree/bi

[RFC PATCH 2/4] devicetree: Add ANX7688 transmitter binding

2016-06-27 Thread Nicolas Boichat
Signed-off-by: Nicolas Boichat <drink...@chromium.org> Change-Id: I618ddf114bb93700daf6572d954191e10b6961c8 --- .../devicetree/bindings/drm/bridge/anx7688.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/drm/

Re: [RFC PATCH 3/4] drm: bridge: Generic GPIO mux driver

2016-07-05 Thread Nicolas Boichat
(whoops, apologies for the CHROMIUM tag in the subject line...) On Tue, Jun 28, 2016 at 4:52 PM, Archit Taneja <arch...@codeaurora.org> wrote: > > > On 06/27/2016 01:18 PM, Nicolas Boichat wrote: >> >> This driver supports single input, 2 output display mux (e.g. >

Re: [RFC PATCH 0/4] drm: bridge: anx7688 and mux drivers

2016-07-05 Thread Nicolas Boichat
Hi Archit, Sorry got swamped by other things and forgot to reply. On Tue, Jun 28, 2016 at 4:28 PM, Archit Taneja <arch...@codeaurora.org> wrote: > > > On 06/27/2016 01:18 PM, Nicolas Boichat wrote: >> >> Hi all, >> >> This is a follow up to the 2 patch

[RFC PATCH 1/2] drm: bridge: anx7688: Add anx7688 bridge driver support.

2016-06-20 Thread Nicolas Boichat
by the bridge via 2 registers on I2C. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- Hi, I tested this driver using the Mediatek HDMI controller (MT8173) upstream of the ANX bridge chip (Phillip sent a PULL request on June 13: git://git.pengutronix.de/git/pza/linux.git tags/mediat

[PATCH 0/3] mfd: cros_ec: Add debugfs directory to capture logs/panicinfo

2016-08-22 Thread Nicolas Boichat
This series makes it possible to capture EC console and panicinfo by reading files in /sys/kernel/debug/cros_ec/*. This is very useful for debugging purpose (e.g. when a user files a feedback on Chrome OS). Eric Caruso (1): mfd: cros_ec: add debugfs, console log file Nicolas Boichat (2): mfd

[PATCH 2/3] mfd: cros_ec: add debugfs, console log file

2016-08-22 Thread Nicolas Boichat
d grab this and write it out to some logs which actually get rotated. Signed-off-by: Eric Caruso <ejcar...@chromium.org> Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- drivers/platform/chrome/Makefile | 3 +- drivers/platform/chrome/cros_

[PATCH 3/3] mfd: cros_ec: Add support for dumping panic information

2016-08-22 Thread Nicolas Boichat
This dumps the EC panic information from the previous reboot. Similar to the information presented by ectool panicinfo, except that we do not bother doing any parsing (we should write a small offline tool for that). Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- drivers/pl

[PATCH 1/3] mfd: cros_ec: Add EC console read structures definitions

2016-08-22 Thread Nicolas Boichat
ec_params_console_read_v1 is used to capture EC logs from kernel, and ec_params_get_cmd_versions_v1 is used to probe whether EC supports that command. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- include/linux/mfd/cros_ec_commands.h | 21 - 1 file chang

Re: [PATCH 1/3] mfd: cros_ec: Add EC console read structures definitions

2016-10-13 Thread Nicolas Boichat
On Thu, Oct 13, 2016 at 11:06 AM, Olof Johansson <o...@lixom.net> wrote: > On Wed, Oct 12, 2016 at 8:24 PM, Nicolas Boichat <drink...@chromium.org> > wrote: >> On Wed, Aug 31, 2016 at 4:45 AM, Lee Jones <lee.jo...@linaro.org> wrote: >>> On

Re: [PATCH 1/3] mfd: cros_ec: Add EC console read structures definitions

2016-10-12 Thread Nicolas Boichat
On Wed, Aug 31, 2016 at 4:45 AM, Lee Jones <lee.jo...@linaro.org> wrote: > On Tue, 23 Aug 2016, Nicolas Boichat wrote: > >> ec_params_console_read_v1 is used to capture EC logs from kernel, >> and ec_params_get_cmd_versions_v1 is used to probe whether EC >> supports

[PATCH] HID: hid-multitouch: forward MSC_TIMESTAMP

2017-08-21 Thread Nicolas Boichat
whenever the time between 2 received events is greater than MAX_TIMESTAMP_INTERVAL (1 second). Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- Inspired from Benjamin Tissoires's patch here: https://patchwork.kernel.org/patch/1742181/, and changing the logic to resynch

[PATCH] usb: hub: Per-port setting to use old enumeration scheme

2018-05-22 Thread Nicolas Boichat
port only. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- There are other "quirks" that we could add to reduce further enumeration time (e.g. reduce USB debounce time, reduce TRSTRCY to 10ms instead of 50ms as used currently), but the logic is quite similar, so it'd be good t

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

2018-05-23 Thread Nicolas Boichat
On Thu, May 24, 2018 at 12:39 AM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Wed, May 23, 2018 at 10:03:55AM -0400, Alan Stern wrote: >> On Wed, 23 May 2018, Nicolas Boichat wrote: >> >> > The "old" enumeration scheme is considerably faster

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

2018-05-24 Thread Nicolas Boichat
On Fri, May 25, 2018 at 12:21 AM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Thu, May 24, 2018 at 07:42:00AM +0800, Nicolas Boichat wrote: >> On Thu, May 24, 2018 at 12:39 AM, Greg Kroah-Hartman >> <gre...@linuxfoundation.org> wrote: >> > On W

[PATCH] HID: google: Add support for whiskers

2018-06-07 Thread Nicolas Boichat
Another device in the hammer class, with USB id 0x5030. Signed-off-by: Nicolas Boichat --- drivers/hid/hid-google-hammer.c | 2 ++ drivers/hid/hid-ids.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c index

[PATCH] usb: hub: Per-port setting to reduce TRSTRCY to 10 ms

2018-05-28 Thread Nicolas Boichat
n to reduce the time to what the USB specification requires: 10 ms. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- Reduces enumeration time by ~40ms in conjunction with previous patch/quirk (or ~80ms on its own). Documentation/ABI/testing/sysfs-bus-usb | 4 drivers/usb/core/

[PATCHv2 1/2] usb: hub: Per-port setting to use old enumeration scheme

2018-05-28 Thread Nicolas Boichat
port only. Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- Changes since v1: - Added documentation in Documentation/ABI - Updated timing in commit message to account for recent improvement in USB core (74072bae88fb3b) Documentation/ABI/testing/sysfs-bus-usb | 18 +++

[PATCH v4] HID: google: add google hammer HID driver

2018-03-13 Thread Nicolas Boichat
ce can bind to the multitouch driver. Signed-off-by: Wei-Ning Huang <wnhu...@google.com> Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- Changes since v3: - Rebase on latest linux-next/master, which moved the quirk list from hid-core.c to hid-quirks.c. Also, completel

Re: [PATCH v4] HID: google: add google hammer HID driver

2018-03-14 Thread Nicolas Boichat
On Thu, Mar 15, 2018 at 2:05 AM, Dmitry Torokhov <d...@chromium.org> wrote: > On Wed, Mar 14, 2018 at 9:16 AM, Benjamin Tissoires > <benjamin.tissoi...@redhat.com> wrote: >> >> Hi Nicolas, >> >> On Wed, Mar 14, 2018 at 6:22 AM, Nicolas Boichat <drink...

[PATCH] HID: google: add google hammer HID driver

2018-03-14 Thread Nicolas Boichat
From: Wei-Ning Huang <wnhu...@chromium.org> Add Google hammer HID driver. This driver allow us to control hammer keyboard backlight and support future features. Signed-off-by: Wei-Ning Huang <wnhu...@google.com> Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- Change

[PATCH] HID: google: Enable PM Full On mode when adjusting backlight

2018-03-28 Thread Nicolas Boichat
t fail to set brightness, and set device back to NORMAL mode once this call returns. Signed-off-by: Haridhar Kalvala <haridhar.kalv...@intel.com> Reviewed-by: Dmitry Torokhov <d...@chromium.org> Signed-off-by: Nicolas Boichat <drink...@chromium.org> --- drivers/hid/hid-google-hammer.

[PATCH] mfd: mt6397: Do not call irq_domain_remove if PMIC unsupported

2018-10-21 Thread Nicolas Boichat
If the PMIC ID is unknown, the current code would call irq_domain_remove and panic, as pmic->irq_domain is only initialized by mt6397_irq_init. Return immediately with an error, if the chip ID is unsupported. Signed-off-by: Nicolas Boichat --- drivers/mfd/mt6397-core.c | 3 +-- 1 file chan

Re: [PATCH v1 01/11] clk: mediatek: add new clkmux register API

2018-11-13 Thread Nicolas Boichat
On Mon, Nov 5, 2018 at 10:42 PM Weiyi Lu wrote: > > From: Owen Chen > > On both MT8183 & MT6765, there add "set/clr" register for > each clkmux setting, and one update register to trigger value change. > It is designed to prevent read-modify-write racing issue. > The sw design need to add a new

Re: [PATCH v1 02/11] clk: mediatek: add new member to mtk_pll_data

2018-11-13 Thread Nicolas Boichat
On Mon, Nov 5, 2018 at 10:43 PM Weiyi Lu wrote: > > From: Owen Chen > > 1. pcwibits: The integer bits of pcw for plls is extend to 8 bits, >add a variable to indicate this change and >backward-compatible. > 2. fmin: The pll freqency lower-bound is vary from 1GMhz to >1.5Ghz, add a

Re: [PATCH v1 08/11] clk: mediatek: Add MT8183 clock support

2018-11-13 Thread Nicolas Boichat
On Mon, Nov 5, 2018 at 10:42 PM Weiyi Lu wrote: > > Add MT8183 clock support, include topckgen, apmixedsys, > infracfg, mcucfg and subsystem clocks. > > Signed-off-by: Weiyi Lu > --- > drivers/clk/mediatek/Kconfig | 75 ++ > drivers/clk/mediatek/Makefile | 12 + >

Re: [PATCH v1 04/11] soc: mediatek: add new flow for mtcmos power.

2018-11-13 Thread Nicolas Boichat
(not a complete review...) On Mon, Nov 5, 2018 at 10:42 PM Weiyi Lu wrote: > > From: Owen Chen > > Both MT8183 & MT6765 add more bus protect node than previous project, > therefore we add two more register for setup bus protect, which reside > at INFRA_CFG & SMI_COMMON. > > With the following

Re: [PATCH v1 11/11] soc: mediatek: Add MT8183 scpsys support

2018-11-13 Thread Nicolas Boichat
On Mon, Nov 5, 2018 at 10:43 PM Weiyi Lu wrote: > > Add scpsys driver for MT8183 > > Signed-off-by: Weiyi Lu > --- > drivers/soc/mediatek/mtk-scpsys.c | 226 ++ > 1 file changed, 226 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-scpsys.c >

  1   2   3   4   5   6   >