Re: [PATCH] dt-bindings: i2c: use correct vendor prefix for atmel's at24 EEPROMs

2018-12-06 Thread Peter Rosin
On 2018-12-06 10:45, Bartosz Golaszewski wrote: > This is a follow-up to Thierry's patch which missed a few occurences. > > Cc: Thierry Reding > Signed-off-by: Bartosz Golaszewski Acked-by: Peter Rosin Wolfram, you can take this one as well, of course. Cheers, Peter > --- &

Re: [PATCH] dt-bindings: i2c: use correct vendor prefix for atmel's at24 EEPROMs

2018-12-06 Thread Peter Rosin
On 2018-12-06 10:45, Bartosz Golaszewski wrote: > This is a follow-up to Thierry's patch which missed a few occurences. > > Cc: Thierry Reding > Signed-off-by: Bartosz Golaszewski Acked-by: Peter Rosin Wolfram, you can take this one as well, of course. Cheers, Peter > --- &

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 15:36, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 02:11:33PM +0000, Peter Rosin wrote: >> Ho hmm. Had another look at this patch, or rather, the context of the >> patch so not really related, but... >> >> On 2018-12-01 11:01, Nicholas Mc Guire wr

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 15:36, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 02:11:33PM +0000, Peter Rosin wrote: >> Ho hmm. Had another look at this patch, or rather, the context of the >> patch so not really related, but... >> >> On 2018-12-01 11:01, Nicholas Mc Guire wr

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 15:25, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 01:49:11PM +0000, Peter Rosin wrote: >> On 2018-12-04 13:13, Nicholas Mc Guire wrote: >>> On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: >>>> Hi! >>>> >>>>

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 15:25, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 01:49:11PM +0000, Peter Rosin wrote: >> On 2018-12-04 13:13, Nicholas Mc Guire wrote: >>> On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote: >>>> Hi! >>>> >>>>

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
Ho hmm. Had another look at this patch, or rather, the context of the patch so not really related, but... On 2018-12-01 11:01, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed. > Thus using name, value is unsafe without being checked. As >

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
Ho hmm. Had another look at this patch, or rather, the context of the patch so not really related, but... On 2018-12-01 11:01, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed. > Thus using name, value is unsafe without being checked. As >

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 13:13, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 11:16:59AM +0000, Peter Rosin wrote: >> Hi! >> >> This patch looks like a good idea. However, a nitpick below. >> >> On 2018-12-01 11:01, Nicholas Mc Guire wrote: >>> devm_kstrdu

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
On 2018-12-04 13:13, Nicholas Mc Guire wrote: > On Tue, Dec 04, 2018 at 11:16:59AM +0000, Peter Rosin wrote: >> Hi! >> >> This patch looks like a good idea. However, a nitpick below. >> >> On 2018-12-01 11:01, Nicholas Mc Guire wrote: >>> devm_kstrdu

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
Hi! This patch looks like a good idea. However, a nitpick below. On 2018-12-01 11:01, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed. > Thus using name, value is unsafe without being checked. As > i2c_demux_pinctrl_probe() can return -ENOMEM in other

Re: [PATCH] i2c: mux: demux-pinctrl: handle failure case of devm_kstrdup()

2018-12-04 Thread Peter Rosin
Hi! This patch looks like a good idea. However, a nitpick below. On 2018-12-01 11:01, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed. > Thus using name, value is unsafe without being checked. As > i2c_demux_pinctrl_probe() can return -ENOMEM in other

Re: [PATCH v3] i2c: mux: remove duplicated i2c_algorithm

2018-11-27 Thread Peter Rosin
On 2018-11-18 12:13, Luca Ceresoli wrote: > Hi Peter, > > On 10/10/18 17:48, Luca Ceresoli wrote: >> Hi Peter, >> >> On 08/10/2018 23:43, Peter Rosin wrote: >>> On 2018-10-03 17:19, Luca Ceresoli wrote: >>>> From: Luca Ceresoli >>>> >

Re: [PATCH v3] i2c: mux: remove duplicated i2c_algorithm

2018-11-27 Thread Peter Rosin
On 2018-11-18 12:13, Luca Ceresoli wrote: > Hi Peter, > > On 10/10/18 17:48, Luca Ceresoli wrote: >> Hi Peter, >> >> On 08/10/2018 23:43, Peter Rosin wrote: >>> On 2018-10-03 17:19, Luca Ceresoli wrote: >>>> From: Luca Ceresoli >>>> >

Re: [PATCH v2] dt-bindings: i2c: Use correct vendor prefix for Atmel

2018-11-27 Thread Peter Rosin
instead. >> >> While at it, remove the at,24c08 compatible string from the list of >> trivial devices because it is already documented in eeprom/at24.txt. >> >> Signed-off-by: Thierry Reding > > Peter, I'd assume you are okay with me applying the patch directly? Absolutely, go ahead. Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH v2] dt-bindings: i2c: Use correct vendor prefix for Atmel

2018-11-27 Thread Peter Rosin
instead. >> >> While at it, remove the at,24c08 compatible string from the list of >> trivial devices because it is already documented in eeprom/at24.txt. >> >> Signed-off-by: Thierry Reding > > Peter, I'd assume you are okay with me applying the patch directly? Absolutely, go ahead. Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH] dt-bindings: i2c: Use correct vendor prefix for Atmel

2018-11-23 Thread Peter Rosin
On 2018-11-23 13:10, Thierry Reding wrote: > From: Thierry Reding > > The "at," prefix was never correct for Atmel, so fix the few occurrences > that got it wrong. Use "atmel," instead. Fully agreed. However, given that atmel,24c08 is documented in .../eeprom/at24.txt I think it would be

Re: [PATCH] dt-bindings: i2c: Use correct vendor prefix for Atmel

2018-11-23 Thread Peter Rosin
On 2018-11-23 13:10, Thierry Reding wrote: > From: Thierry Reding > > The "at," prefix was never correct for Atmel, so fix the few occurrences > that got it wrong. Use "atmel," instead. Fully agreed. However, given that atmel,24c08 is documented in .../eeprom/at24.txt I think it would be

[PATCH] ARM: dts: at91: nattis: initialize the BLON pin as output-low early

2018-11-20 Thread Peter Rosin
. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts index 911d2c7c1500..0f6d335125e2 100644 --- a/arch/arm/boot/dts/at91-nattis

[PATCH] ARM: dts: at91: nattis: initialize the BLON pin as output-low early

2018-11-20 Thread Peter Rosin
. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts index 911d2c7c1500..0f6d335125e2 100644 --- a/arch/arm/boot/dts/at91-nattis

Re: [PATCH v2] i2c: rk3x: fix some typo

2018-11-02 Thread Peter Rosin
On 2018-11-02 13:45, Yangtao Li wrote: > Fix multiple instances of a misspelled "Calculates". Yes, it sure is hard to spell "Calcluated," it's almost impossible to get it completely right and not introduce another typo somewhere... :-) Cheers, Peter > > Signed-off-by: Yangtao Li >

Re: [PATCH v2] i2c: rk3x: fix some typo

2018-11-02 Thread Peter Rosin
On 2018-11-02 13:45, Yangtao Li wrote: > Fix multiple instances of a misspelled "Calculates". Yes, it sure is hard to spell "Calcluated," it's almost impossible to get it completely right and not introduce another typo somewhere... :-) Cheers, Peter > > Signed-off-by: Yangtao Li >

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-17 Thread Peter Rosin
On 2018-10-16 13:01, Gustavo A. R. Silva wrote: > On 10/14/18 7:01 PM, Jonathan Cameron wrote: >> Done the first of the above... > > Thank you, Jonathan. Indeed. I meant to respond earlier, but then forgot... Thank you! Cheers, Peter

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-17 Thread Peter Rosin
On 2018-10-16 13:01, Gustavo A. R. Silva wrote: > On 10/14/18 7:01 PM, Jonathan Cameron wrote: >> Done the first of the above... > > Thank you, Jonathan. Indeed. I meant to respond earlier, but then forgot... Thank you! Cheers, Peter

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-13 Thread Peter Rosin
On 2018-10-13 14:38, Jonathan Cameron wrote: > On Mon, 8 Oct 2018 20:42:41 + > Peter Rosin wrote: > >> On 2018-10-08 19:35, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fa

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-13 Thread Peter Rosin
On 2018-10-13 14:38, Jonathan Cameron wrote: > On Mon, 8 Oct 2018 20:42:41 + > Peter Rosin wrote: > >> On 2018-10-08 19:35, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fa

[PATCH 2/2] MAINTAINERS: use the correct location for dt-bindings includes for mux

2018-10-12 Thread Peter Rosin
Just drop the "linux" part of the path, it was never correct. Reported-by: Joe Perches Fixes: 256ac0375098 ("dt-bindings: document devicetree bindings for mux-controllers and gpio-mux") Signed-off-by: Peter Rosin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+),

[PATCH 2/2] MAINTAINERS: use the correct location for dt-bindings includes for mux

2018-10-12 Thread Peter Rosin
Just drop the "linux" part of the path, it was never correct. Reported-by: Joe Perches Fixes: 256ac0375098 ("dt-bindings: document devicetree bindings for mux-controllers and gpio-mux") Signed-off-by: Peter Rosin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+),

[PATCH 1/2] mux: adgs1408: use the correct MODULE_LICENSE

2018-10-12 Thread Peter Rosin
The file is GPL v2 or later. Acked-by: Mircea Caprioru Signed-off-by: Peter Rosin --- drivers/mux/adgs1408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c index 0f7cf54e3234..89096f10f4c4 100644 --- a/drivers/mux/adgs1408.c

[PATCH 1/2] mux: adgs1408: use the correct MODULE_LICENSE

2018-10-12 Thread Peter Rosin
The file is GPL v2 or later. Acked-by: Mircea Caprioru Signed-off-by: Peter Rosin --- drivers/mux/adgs1408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c index 0f7cf54e3234..89096f10f4c4 100644 --- a/drivers/mux/adgs1408.c

[PATCH 0/2] mux: small fixes for 4.20-rc1

2018-10-12 Thread Peter Rosin
Hi Greg, A couple of tiny fixlets for the mux subsystem. Please pick them up for 4.20. Cheers, Peter Peter Rosin (2): mux: adgs1408: use the correct MODULE_LICENSE MAINTAINERS: use the correct location for dt-bindings includes for mux MAINTAINERS| 2 +- drivers/mux/adgs1408.c

[PATCH 0/2] mux: small fixes for 4.20-rc1

2018-10-12 Thread Peter Rosin
Hi Greg, A couple of tiny fixlets for the mux subsystem. Please pick them up for 4.20. Cheers, Peter Peter Rosin (2): mux: adgs1408: use the correct MODULE_LICENSE MAINTAINERS: use the correct location for dt-bindings includes for mux MAINTAINERS| 2 +- drivers/mux/adgs1408.c

Re: [PATCH v2 1/3] i2c: mux: pca954x: simplify code to reach the adapter

2018-10-08 Thread Peter Rosin
On 2018-10-05 13:43, Wolfram Sang wrote: > On Wed, Oct 03, 2018 at 05:50:22PM +0200, Luca Ceresoli wrote: >> From: Luca Ceresoli >> >> struct i2c_client has a direct pointer to the adapter, no need to dig >> it out of the struct device tree. >> >> Signed-off-by: Luca Ceresoli > > I like such

Re: [PATCH v2 1/3] i2c: mux: pca954x: simplify code to reach the adapter

2018-10-08 Thread Peter Rosin
On 2018-10-05 13:43, Wolfram Sang wrote: > On Wed, Oct 03, 2018 at 05:50:22PM +0200, Luca Ceresoli wrote: >> From: Luca Ceresoli >> >> struct i2c_client has a direct pointer to the adapter, no need to dig >> it out of the struct device tree. >> >> Signed-off-by: Luca Ceresoli > > I like such

Re: [PATCH v3] i2c: mux: remove duplicated i2c_algorithm

2018-10-08 Thread Peter Rosin
h use. So, the patch needs some reworking. Sorry for not noticing this earlier. Cheers, Peter > Cc: Peter Rosin > Signed-off-by: Luca Ceresoli > > --- > > Changes v2 -> v3: > - fix coding style of comment when moving it (Peter Rosin) > - move the 'algo' member betw

Re: [PATCH v3] i2c: mux: remove duplicated i2c_algorithm

2018-10-08 Thread Peter Rosin
h use. So, the patch needs some reworking. Sorry for not noticing this earlier. Cheers, Peter > Cc: Peter Rosin > Signed-off-by: Luca Ceresoli > > --- > > Changes v2 -> v3: > - fix coding style of comment when moving it (Peter Rosin) > - move the 'algo' member betw

Re: [PATCH] MAINTAINERS: use the correct location for dt-bindings includes for mux

2018-10-08 Thread Peter Rosin
On 2018-10-01 13:41, Peter Rosin wrote: > Just drop the "linux" part of the path, it was never correct. > > Reported-by: Joe Perches > Fixes: 256ac0375098 ("dt-bindings: document devicetree bindings for > mux-controllers and gpio-mux") > Signed-off-by:

Re: [PATCH] MAINTAINERS: use the correct location for dt-bindings includes for mux

2018-10-08 Thread Peter Rosin
On 2018-10-01 13:41, Peter Rosin wrote: > Just drop the "linux" part of the path, it was never correct. > > Reported-by: Joe Perches > Fixes: 256ac0375098 ("dt-bindings: document devicetree bindings for > mux-controllers and gpio-mux") > Signed-off-by:

Re: [PATCH] mux: adgs1408: use the correct MODULE_LICENSE

2018-10-08 Thread Peter Rosin
On 2018-08-20 12:11, Peter Rosin wrote: > The file is GPL v2 or later. > > Signed-off-by: Peter Rosin Applied to the for-next branch. Cheers, Peter

Re: [PATCH] mux: adgs1408: use the correct MODULE_LICENSE

2018-10-08 Thread Peter Rosin
On 2018-08-20 12:11, Peter Rosin wrote: > The file is GPL v2 or later. > > Signed-off-by: Peter Rosin Applied to the for-next branch. Cheers, Peter

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-08 Thread Peter Rosin
On 2018-10-08 19:35, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. The way I see it, it is pretty well marked up as is. So, this paragraph is not describing the change. > > Notice that in this

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-08 Thread Peter Rosin
On 2018-10-08 19:35, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. The way I see it, it is pretty well marked up as is. So, this paragraph is not describing the change. > > Notice that in this

Re: [PATCH v2] i2c: mux: remove duplicated i2c_algorithm

2018-10-01 Thread Peter Rosin
On 2018-09-27 15:38, Luca Ceresoli wrote: > From: Luca Ceresoli > > i2c-mux instantiates one i2c_algorithm for each downstream adapter. > However these algorithms are all identical, depending only on the > parent adapter. > > Avoid duplication by hoisting the i2c_algorithm from the adapters to

Re: [PATCH v2] i2c: mux: remove duplicated i2c_algorithm

2018-10-01 Thread Peter Rosin
On 2018-09-27 15:38, Luca Ceresoli wrote: > From: Luca Ceresoli > > i2c-mux instantiates one i2c_algorithm for each downstream adapter. > However these algorithms are all identical, depending only on the > parent adapter. > > Avoid duplication by hoisting the i2c_algorithm from the adapters to

Re: [PATCH RESEND] i2c: mux: pca954x: simplify code to reach the adapter

2018-10-01 Thread Peter Rosin
On 2018-09-26 10:35, Luca Ceresoli wrote: > From: Luca Ceresoli > > struct i2c_client has a direct pointer to the adapter, no need to dig > it out of the struct device tree. Right, looks sane, but can you please also do the same thing for the ltc4306 and mlxcpld drivers which have the same

Re: [PATCH RESEND] i2c: mux: pca954x: simplify code to reach the adapter

2018-10-01 Thread Peter Rosin
On 2018-09-26 10:35, Luca Ceresoli wrote: > From: Luca Ceresoli > > struct i2c_client has a direct pointer to the adapter, no need to dig > it out of the struct device tree. Right, looks sane, but can you please also do the same thing for the ltc4306 and mlxcpld drivers which have the same

[PATCH] MAINTAINERS: use the correct location for dt-bindings includes for mux

2018-10-01 Thread Peter Rosin
Just drop the "linux" part of the path, it was never correct. Reported-by: Joe Perches Fixes: 256ac0375098 ("dt-bindings: document devicetree bindings for mux-controllers and gpio-mux") Signed-off-by: Peter Rosin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+),

[PATCH] MAINTAINERS: use the correct location for dt-bindings includes for mux

2018-10-01 Thread Peter Rosin
Just drop the "linux" part of the path, it was never correct. Reported-by: Joe Perches Fixes: 256ac0375098 ("dt-bindings: document devicetree bindings for mux-controllers and gpio-mux") Signed-off-by: Peter Rosin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs

2018-09-26 Thread Peter Rosin
On 2018-09-26 13:57, Vignesh R wrote: > AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to > handle AM654 SoCs. > > Signed-off-by: Vignesh R > --- > Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs

2018-09-26 Thread Peter Rosin
On 2018-09-26 13:57, Vignesh R wrote: > AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to > handle AM654 SoCs. > > Signed-off-by: Vignesh R > --- > Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [GIT PULL] UBIFS fixes for 4.19-rc4

2018-09-24 Thread Peter Rosin
I fredags, den 21 september 2018, 15:53:42 CEST skrev Greg KH: > On Fri, Sep 21, 2018 at 11:33:15AM +0200, Richard Weinberger wrote: >> Greg, >> >> The following changes since commit ae596de1a0c8c2c924dc99d23c026259372ab234: >> >> Compiler Attributes: naked can be shared (2018-09-20 15:23:58

Re: [GIT PULL] UBIFS fixes for 4.19-rc4

2018-09-24 Thread Peter Rosin
I fredags, den 21 september 2018, 15:53:42 CEST skrev Greg KH: > On Fri, Sep 21, 2018 at 11:33:15AM +0200, Richard Weinberger wrote: >> Greg, >> >> The following changes since commit ae596de1a0c8c2c924dc99d23c026259372ab234: >> >> Compiler Attributes: naked can be shared (2018-09-20 15:23:58

Re: [PATCH -next] iio: potentiometer: mcp4018: merge calls to of_match_device and of_device_get_match_data

2018-09-16 Thread Peter Rosin
On September 16, 2018 11:36:57 AM GMT+02:00, Jonathan Cameron wrote: >On Sat, 15 Sep 2018 13:35:06 +0200 >Peter Rosin wrote: > >> On 2018-09-15 12:52, YueHaibing wrote: >> > Drop call to of_match_device, which is subsumed by the subsequent >> > call to of

Re: [PATCH -next] iio: potentiometer: mcp4018: merge calls to of_match_device and of_device_get_match_data

2018-09-16 Thread Peter Rosin
On September 16, 2018 11:36:57 AM GMT+02:00, Jonathan Cameron wrote: >On Sat, 15 Sep 2018 13:35:06 +0200 >Peter Rosin wrote: > >> On 2018-09-15 12:52, YueHaibing wrote: >> > Drop call to of_match_device, which is subsumed by the subsequent >> > call to of

Re: [PATCH -next] iio: potentiometer: mcp4531: merge calls to of_match_device and of_device_get_match_data

2018-09-15 Thread Peter Rosin
On 2018-09-15 12:54, YueHaibing wrote: > Drop call to of_match_device, which is subsumed by the subsequent > call to of_device_get_match_data. The code becomes simpler, and a > temporary variable can be dropped. > > Found by coccinelle. > > Signed-off-by: YueHaibing

Re: [PATCH -next] iio: potentiometer: mcp4531: merge calls to of_match_device and of_device_get_match_data

2018-09-15 Thread Peter Rosin
On 2018-09-15 12:54, YueHaibing wrote: > Drop call to of_match_device, which is subsumed by the subsequent > call to of_device_get_match_data. The code becomes simpler, and a > temporary variable can be dropped. > > Found by coccinelle. > > Signed-off-by: YueHaibing

Re: [PATCH -next] iio: potentiometer: mcp4018: merge calls to of_match_device and of_device_get_match_data

2018-09-15 Thread Peter Rosin
On 2018-09-15 12:52, YueHaibing wrote: > Drop call to of_match_device, which is subsumed by the subsequent > call to of_device_get_match_data. The code becomes simpler, and a > temporary variable can be dropped. > > Found by coccinelle. > > Signed-off-by: YueHaibing

Re: [PATCH -next] iio: potentiometer: mcp4018: merge calls to of_match_device and of_device_get_match_data

2018-09-15 Thread Peter Rosin
On 2018-09-15 12:52, YueHaibing wrote: > Drop call to of_match_device, which is subsumed by the subsequent > call to of_device_get_match_data. The code becomes simpler, and a > temporary variable can be dropped. > > Found by coccinelle. > > Signed-off-by: YueHaibing

Re: [PATCH v4 1/2] rtmutex: allow specifying a subclass for nested locking

2018-09-10 Thread Peter Rosin
On 2018-09-11 01:27, Steven Rostedt wrote: > > Why this: > > #ifdef CONFIG_DEBUG_LOCK_ALLOC > [..] > #endif > > #ifndef CONFIG_DEBUG_LOCK_ALLOC > [..] > #endif > > ??? > > This should use #else. Yes. Water under the bridge... Cheers, Peter

Re: [PATCH v4 1/2] rtmutex: allow specifying a subclass for nested locking

2018-09-10 Thread Peter Rosin
On 2018-09-11 01:27, Steven Rostedt wrote: > > Why this: > > #ifdef CONFIG_DEBUG_LOCK_ALLOC > [..] > #endif > > #ifndef CONFIG_DEBUG_LOCK_ALLOC > [..] > #endif > > ??? > > This should use #else. Yes. Water under the bridge... Cheers, Peter

[PATCH 2/2] ARM: dts: at91: tse850: drop three indentation levels

2018-08-31 Thread Peter Rosin
Make use of the recently added and labels. This makes the whole file consistent and knowledge of the ahb/apb structure is hidden. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-tse850-3.dts | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff

[PATCH 2/2] ARM: dts: at91: tse850: drop three indentation levels

2018-08-31 Thread Peter Rosin
Make use of the recently added and labels. This makes the whole file consistent and knowledge of the ahb/apb structure is hidden. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-tse850-3.dts | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff

[PATCH 1/2] ARM: dts: at91: nattis: drop three indentation levels

2018-08-31 Thread Peter Rosin
Make use of the recently added and labels. This makes the whole file consistent and knowledge of the ahb/apb structure is hidden. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 72 - 1 file changed, 30 insertions(+), 42 deletions

[PATCH 1/2] ARM: dts: at91: nattis: drop three indentation levels

2018-08-31 Thread Peter Rosin
Make use of the recently added and labels. This makes the whole file consistent and knowledge of the ahb/apb structure is hidden. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 72 - 1 file changed, 30 insertions(+), 42 deletions

[PATCH 0/2] ARM: dts: at91: nattis/tse850: drop 3 indentation levels

2018-08-31 Thread Peter Rosin
Hi! I just noticed that the pinctrl and watchdog nodes in sama5d3.dtsi have gained labels, something which I have had a plan to add myself at some point. But now that they are here, I just have to make use of them... Cheers, Peter Peter Rosin (2): ARM: dts: at91: nattis: drop three

[PATCH 0/2] ARM: dts: at91: nattis/tse850: drop 3 indentation levels

2018-08-31 Thread Peter Rosin
Hi! I just noticed that the pinctrl and watchdog nodes in sama5d3.dtsi have gained labels, something which I have had a plan to add myself at some point. But now that they are here, I just have to make use of them... Cheers, Peter Peter Rosin (2): ARM: dts: at91: nattis: drop three

[PATCH 5/5] ARM: dts: at91: nattis: describe the lvds panel

2018-08-28 Thread Peter Rosin
Make the DT usable with the panel-lvds driver. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2

[PATCH 3/5] ARM: dts: at91: nattis: state the actual lvds-encoder chip

2018-08-28 Thread Peter Rosin
Just to be explicit. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts index 4308a07b792e..fbc796125c56 100644

[PATCH 5/5] ARM: dts: at91: nattis: describe the lvds panel

2018-08-28 Thread Peter Rosin
Make the DT usable with the panel-lvds driver. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2

[PATCH 3/5] ARM: dts: at91: nattis: state the actual lvds-encoder chip

2018-08-28 Thread Peter Rosin
Just to be explicit. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts index 4308a07b792e..fbc796125c56 100644

[PATCH 0/5] ARM: dts: at91: nattis: some cleanup

2018-08-28 Thread Peter Rosin
Hi! Now that some other patches [1][2] have finally landed in -next, I feel that it is time for this cleanup series that I have been hoarding for a while waiting on those (weak) dependencies. Cheers, Peter [1] https://lkml.org/lkml/2018/8/24/187 [2] https://lkml.org/lkml/2018/8/25/64 Peter

[PATCH 1/5] ARM: dts: at91: nattis: set the PRLUD and HIPOW signals low

2018-08-28 Thread Peter Rosin
AT91_PINCTRL_OUTPUT_VAL(0) without AT91_PINCTRL_OUTPUT is a no-op, so make sure the pins really output a zero. Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power") Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 6

[PATCH 2/5] ARM: dts: at91: nattis: make the SD-card slot work

2018-08-28 Thread Peter Rosin
The cd-gpios signal is assumed active-low by the driver, and the cd-inverted property is needed if it is, in fact, active-high. Fix this oversight. Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power") Signed-off-by: Peter Rosin --- arch/ar

[PATCH 0/5] ARM: dts: at91: nattis: some cleanup

2018-08-28 Thread Peter Rosin
Hi! Now that some other patches [1][2] have finally landed in -next, I feel that it is time for this cleanup series that I have been hoarding for a while waiting on those (weak) dependencies. Cheers, Peter [1] https://lkml.org/lkml/2018/8/24/187 [2] https://lkml.org/lkml/2018/8/25/64 Peter

[PATCH 1/5] ARM: dts: at91: nattis: set the PRLUD and HIPOW signals low

2018-08-28 Thread Peter Rosin
AT91_PINCTRL_OUTPUT_VAL(0) without AT91_PINCTRL_OUTPUT is a no-op, so make sure the pins really output a zero. Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power") Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 6

[PATCH 2/5] ARM: dts: at91: nattis: make the SD-card slot work

2018-08-28 Thread Peter Rosin
The cd-gpios signal is assumed active-low by the driver, and the cd-inverted property is needed if it is, in fact, active-high. Fix this oversight. Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power") Signed-off-by: Peter Rosin --- arch/ar

[PATCH 4/5] ARM: dts: at91: nattis: move pinctrls for the lvds chip to the lvds node

2018-08-28 Thread Peter Rosin
The atmel hlcdc controller has nothing to do with these pins, so move them to where they belong. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2

[PATCH 4/5] ARM: dts: at91: nattis: move pinctrls for the lvds chip to the lvds node

2018-08-28 Thread Peter Rosin
The atmel hlcdc controller has nothing to do with these pins, so move them to where they belong. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2

[PATCH v2 1/2] drm/atmel-hlcdc: prefer a higher rate clock as pixel-clock base

2018-08-24 Thread Peter Rosin
as base, the divider instead ends up as 5 yielding a pixel-clock of 52.8Mhz, which is a definite improvement. While at it, clamp the divider so that it does not overflow in case it gets big. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 +++--- 1 file

[PATCH v2 1/2] drm/atmel-hlcdc: prefer a higher rate clock as pixel-clock base

2018-08-24 Thread Peter Rosin
as base, the divider instead ends up as 5 yielding a pixel-clock of 52.8Mhz, which is a definite improvement. While at it, clamp the divider so that it does not overflow in case it gets big. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 +++--- 1 file

[PATCH v2 0/2] drm/atmel-hlcdc: revise selection of pixel-clock frequency divider

2018-08-24 Thread Peter Rosin
r symmetry - reformatted comments a little bit - spelling/grammar fixes Peter Rosin (2): drm/atmel-hlcdc: prefer a higher rate clock as pixel-clock base drm/atmel-hlcdc: allow selecting a higher pixel-clock than requested drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 30 +++

[PATCH v2 0/2] drm/atmel-hlcdc: revise selection of pixel-clock frequency divider

2018-08-24 Thread Peter Rosin
r symmetry - reformatted comments a little bit - spelling/grammar fixes Peter Rosin (2): drm/atmel-hlcdc: prefer a higher rate clock as pixel-clock base drm/atmel-hlcdc: allow selecting a higher pixel-clock than requested drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 30 +++

Re: [RFC RFT PATCH v4 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-08-21 Thread Peter Rosin
On 2018-08-21 01:43, Janusz Krzysztofik wrote: > Most users of get/set array functions iterate consecutive bits of data, > usually a single integer, while or processing array of results obtained > from or building an array of values to be passed to those functions. > Save time wasted on those

Re: [RFC RFT PATCH v4 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

2018-08-21 Thread Peter Rosin
On 2018-08-21 01:43, Janusz Krzysztofik wrote: > Most users of get/set array functions iterate consecutive bits of data, > usually a single integer, while or processing array of results obtained > from or building an array of values to be passed to those functions. > Save time wasted on those

Re: [PATCH] mux: adgs1408: use the correct SPDX license identifier

2018-08-20 Thread Peter Rosin
he bowl... Cheers, Peter > > Regards, > Mircea > > -Original Message- > From: Peter Rosin [mailto:p...@axentia.se] > Sent: Monday, August 20, 2018 1:38 PM > To: linux-kernel@vger.kernel.org > Cc: Peter Rosin ; Caprioru, Mircea > > Subject: [PAT

Re: [PATCH] mux: adgs1408: use the correct SPDX license identifier

2018-08-20 Thread Peter Rosin
he bowl... Cheers, Peter > > Regards, > Mircea > > -Original Message- > From: Peter Rosin [mailto:p...@axentia.se] > Sent: Monday, August 20, 2018 1:38 PM > To: linux-kernel@vger.kernel.org > Cc: Peter Rosin ; Caprioru, Mircea > > Subject: [PAT

[PATCH] mux: adgs1408: use the correct SPDX license identifier

2018-08-20 Thread Peter Rosin
The file is GPL v2 only. Signed-off-by: Peter Rosin --- drivers/mux/adgs1408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) On 2018-08-20 12:16, Caprioru, Mircea wrote: > Peter Rosin wrote: >> I just noticed a discrepancy in the license annotations in your >> driver. T

[PATCH] mux: adgs1408: use the correct SPDX license identifier

2018-08-20 Thread Peter Rosin
The file is GPL v2 only. Signed-off-by: Peter Rosin --- drivers/mux/adgs1408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) On 2018-08-20 12:16, Caprioru, Mircea wrote: > Peter Rosin wrote: >> I just noticed a discrepancy in the license annotations in your >> driver. T

[PATCH] ASoC: atmel: tse850: switch to SPDX license identifier

2018-08-20 Thread Peter Rosin
Convert to // comments in the leading comment, drop the boilerplate license text and use the correct MODULE_LICENSE. Signed-off-by: Peter Rosin --- sound/soc/atmel/tse850-pcm5142.c | 78 +++- 1 file changed, 36 insertions(+), 42 deletions(-) diff --git

[PATCH] ASoC: atmel: tse850: switch to SPDX license identifier

2018-08-20 Thread Peter Rosin
Convert to // comments in the leading comment, drop the boilerplate license text and use the correct MODULE_LICENSE. Signed-off-by: Peter Rosin --- sound/soc/atmel/tse850-pcm5142.c | 78 +++- 1 file changed, 36 insertions(+), 42 deletions(-) diff --git

[PATCH] mux: adgs1408: use the correct MODULE_LICENSE

2018-08-20 Thread Peter Rosin
The file is GPL v2 or later. Signed-off-by: Peter Rosin --- drivers/mux/adgs1408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Hi Mircea! I just noticed a discrepancy in the license annotations in your driver. The SPDX license identifier says GPL-2.0-or-later, and I assume

[PATCH] mux: adgs1408: use the correct MODULE_LICENSE

2018-08-20 Thread Peter Rosin
The file is GPL v2 or later. Signed-off-by: Peter Rosin --- drivers/mux/adgs1408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Hi Mircea! I just noticed a discrepancy in the license annotations in your driver. The SPDX license identifier says GPL-2.0-or-later, and I assume

[PATCH 0/5] License cleanup of "my" IIO files

2018-08-20 Thread Peter Rosin
Hi! I found a couple of discrepancies in the license annotations in some of the files I have added to the drivers/iio/ directory. This cleans up the trivialities that I found. While at it, convert the remaining IIO files that are "mine" to SPDX license identifiers. Cheers, Peter Pete

[PATCH 0/5] License cleanup of "my" IIO files

2018-08-20 Thread Peter Rosin
Hi! I found a couple of discrepancies in the license annotations in some of the files I have added to the drivers/iio/ directory. This cleans up the trivialities that I found. While at it, convert the remaining IIO files that are "mine" to SPDX license identifiers. Cheers, Peter Pete

[PATCH 3/5] iio: envelope-detector: switch to SPDX license identifier

2018-08-20 Thread Peter Rosin
Drop the boilerplate license text. Signed-off-by: Peter Rosin --- drivers/iio/adc/envelope-detector.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/iio/adc/envelope-detector.c b/drivers/iio/adc/envelope-detector.c index 4ebda8ab54fe..2f2b563c1162 100644

[PATCH 3/5] iio: envelope-detector: switch to SPDX license identifier

2018-08-20 Thread Peter Rosin
Drop the boilerplate license text. Signed-off-by: Peter Rosin --- drivers/iio/adc/envelope-detector.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/iio/adc/envelope-detector.c b/drivers/iio/adc/envelope-detector.c index 4ebda8ab54fe..2f2b563c1162 100644

[PATCH 1/5] iio: potentiometer: mcp4018: use the correct MODULE_LICENSE

2018-08-20 Thread Peter Rosin
The file is GPL v2 only. Signed-off-by: Peter Rosin --- drivers/iio/potentiometer/mcp4018.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/potentiometer/mcp4018.c b/drivers/iio/potentiometer/mcp4018.c index 320a7c929777..5ab74a839982 100644 --- a/drivers/iio

[PATCH 1/5] iio: potentiometer: mcp4018: use the correct MODULE_LICENSE

2018-08-20 Thread Peter Rosin
The file is GPL v2 only. Signed-off-by: Peter Rosin --- drivers/iio/potentiometer/mcp4018.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/potentiometer/mcp4018.c b/drivers/iio/potentiometer/mcp4018.c index 320a7c929777..5ab74a839982 100644 --- a/drivers/iio

[PATCH 5/5] iio: multiplexer: switch to SPDX license identifier

2018-08-20 Thread Peter Rosin
Drop the boilerplate license text. Signed-off-by: Peter Rosin --- drivers/iio/multiplexer/iio-mux.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c index e1f44cecdef4..0422ef57914c 100644

[PATCH 4/5] iio: dpot-dac: switch to SPDX license identifier

2018-08-20 Thread Peter Rosin
Drop the boilerplate license text. Signed-off-by: Peter Rosin --- drivers/iio/dac/dpot-dac.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/iio/dac/dpot-dac.c b/drivers/iio/dac/dpot-dac.c index aaa2103d7c2b..a791d0a09d3b 100644 --- a/drivers/iio/dac/dpot-dac.c

<    1   2   3   4   5   6   7   8   9   10   >