[PATCH] [wireless/iwlwifi/iwl-4965.c] add parentheses

'!' has a higher priority than '&': bitanding has no effect. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c index 569347f..2439868 100644 --- a/drivers/net/wireless/iw

[PATCH] [drivers/video/i810/i810_main.c] add parentheses

'!' has a higher priority than '&': bitanding has no effect. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c index 1a7d778..1d13dd0 100644 --- a/drivers/video/i810/i810_main.c +++ b/

[PATCH] [video/sis/sis_main.c] add parentheses

'!' has a higher priority than '&': bitanding has no effect. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c index 93ae747..5b28fa2 100644 --- a/drivers/video/sis/sis_main.c +++ b/drivers/

[PATCH] [drivers/misc/asus-laptop.c] add parentheses

'!' has a higher priority than '&': bitanding has no effect. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c index 7dce318..65c67d1 100644 --- a/drivers/misc/asus-laptop.c +++ b/drivers/misc/

[PATCH] [rivers/media/video/tvaudio.c] add parentheses

'!' has a higher priority than '&': bitanding has no effect. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c index a755605..01ebcec 100644 --- a/drivers/media/video/tvaudio.c +++ b

[drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

in drivers/misc/thinkpad_acpi.c: 4137-4142 it reads: /* safety net should the EC not support AUTO * or FULLSPEED mode bits and just ignore them */ if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 */

[drivers/scsi/NCR53C9x.c] remove duplication for family_code == 0x00

(family_code == 0x00) { if ((version & 7) == 2) esp->erev = fas100a; /* NCR53C9X */ else esp->erev = espunknown; Note the duplication of test 'if(family_code == 0x00)' and lines below Sig

[PATCH][sound/soc/fsl/mpc8610_hpcd.c] duplicate strcasecmp test for "rj-master" in mpc8610_hpcd_probe()

In linus' git tree I found this problem. Is it also in the alsa tree? please confirm it's the right fix. The patch was not yet tested. -- duplicate test for "rj-master" Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/so

[PATCH][drivers/misc/thinkpad_acpi.c] duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'

in drivers/misc/thinkpad_acpi.c, lines 4137-4142 it reads: /* safety net should the EC not support AUTO * or FULLSPEED mode bits and just ignore them */ if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 *

[PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

its that set the fan level. And as thinkpad-acpi was leaving these set to zero, it would stop(!) the fan, which is Not A Good Thing. So, as a safety net, we now make sure to also set the fan level part of the HFSP register to speed 7 for full-speed, and a minimum of speed 4 for auto mode. -- second T

[PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'

oing from the memory to the device DMA_FROM_DEVICE = PCI_DMA_FROMDEVICEdata is coming from the device to the Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c index 662c004..1

Re: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'

[EMAIL PROTECTED] wrote: > Good to know that somebody still uses the Ultrastor 14f board :). > Yes, this typo was introduced by somebody doing massive editing to all > scsi drivers long ago. > Cheers, > --db Actually, I do not own a Ultrastor 14f board. I found this by searching for if (test)

Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

Henrique de Moraes Holschuh wrote: > On Tue, 05 Feb 2008, Roel Kluin wrote: >> Roland Dreier wrote: >>> > /* safety net should the EC not support AUTO >>> > * or FULLSPEED mode bits and just ignore them */ >>> >

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

James Bottomley wrote: > On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: >> duplicate pa11_dma_alloc_consistent; more appropriate appears >> pa11_dma_alloc_noncoherent here. >> >> Not tested, please confirm that this fix is correct > > No, it looks comple

[PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct --- fix noncoherent allocation Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kern

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent

John David Anglin wrote: >> James Bottomley wrote: >>> On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: >>>> duplicate pa11_dma_alloc_consistent; more appropriate appears >>>> pa11_dma_alloc_noncoherent here. >>>> >>>> Not t

[PATCH][fs/cifs/cifsfs.c] Make use of cifs_xquota_get

where else in the kernel. The patch below makes use of the function cifs_xquota_get, As an alternative the entire function cifs_xquota_get could be removed. --- Make use of cifs_xquota_get Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c in

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

Matthew Wilcox wrote: > On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: >> duplicate pa11_dma_alloc_consistent; more appropriate appears >> pa11_dma_alloc_noncoherent here. >> >> Not tested, please confirm that this fix is correct > > I don't thi

[PATCH][drivers/pnp/pnpacpi/core.c] __initdata is not an identifier

st' With the patch below these sparse complaints do not occur --- __initdata is not an identifier Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c index 662b4c2..c283a9a 100644 --- a/drivers/pnp/pnpacpi/core.c +++ b

Re: [PATCH] crypto: be*_add_cpu conversion

[EMAIL PROTECTED] wrote: > From: Marcin Slusarz <[EMAIL PROTECTED]> > > replace all: > big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) + > expression_in_cpu_byteorder); > with: > beX_add_cpu(&big_endian_variable, expression_in_cpu_byteor

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

pression_in_cpu_byteorder); you may also want these: --- [bl]e_add_cpu conversion in return Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/fs/ufs/swab.h b/fs/ufs/swab.h index 1683d2b..a1e3000 100644 --- a/fs/ufs/swab.h +++ b/fs/ufs/swab.h @@ -44,18 +44,22 @@ static __inline u32 f

[drivers/video/sis/init301.c] SiS_Pr->ChipType >= SIS_661 not evaluated twice

Not sure whether this is important, but in drivers/video/sis/init301.c:1557: if((SiS_Pr->ChipType >= SIS_661) || (SiS_Pr->SiS_ROMNew)) { SiS_Pr->SiS_LCDTypeInfo = (SiS_GetReg(SiS_Pr->SiS_P3d4,0x39) & 0x7c) >> 2; } else if((SiS_Pr->ChipType < SIS_315H) || (SiS_Pr->ChipType >= SIS_661)) {

Re: Announce: Linux-next (Or Andrew's dream :-))

Linus Torvalds wrote: > > On Tue, 12 Feb 2008, Greg KH wrote: >>> That's the point. >> Not it isn't. To quote you a number of years ago: >> "Linux is evolution, not intelligent design" > > Umm. Have you read a lot of books on evolution? > > It doesn't sound like you have. > > The fact is,

Re: Announce: Linux-next (Or Andrew's dream :-))

Linus Torvalds wrote: > > On Wed, 13 Feb 2008, Roel Kluin wrote: >> In nature there is a lot of duplication: several copies of genes can exist >> and different copies may have a distinct evolution. > > This is true of very complex animals, but much less so when looking at

Re: Announce: Linux-next (Or Andrew's dream :-))

Alan Cox wrote: >> Evolution in nature and changes in code are different because in code junk >> and bugs are constantly removed. In biology junk is allowed and may provide >> a pool for future development. Linux development is intended and not >> survival. > > I would be interested to see any evi

Re: + bluetooth-fix-warning-in-net-bluetooth-hci_sysfsc.patch added to -mm tree

Andrew Morton wrote: > On Sat, 16 Feb 2008 01:27:41 -0800 (PST) David Miller <[EMAIL PROTECTED]> > wrote: > >> From: [EMAIL PROTECTED] >> Date: Fri, 15 Feb 2008 20:49:33 -0800 >> >>> Subject: bluetooth: fix warning in net/bluetooth/hci_sysfs.c >>> From: Andrew Morton <[EMAIL PROTECTED]> >>> >>> n

[PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

Replace !likely(x) by likely(!x) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/x86/kernel/signal_32.c b/arch/x86/kernel/signal_32.c index caee1f0..335872f 100644 --- a/arch/x86/kernel/signal_32.c +++ b/arch/x86/kernel/signal_32.c @@ -303,7 +303,7 @@ get_sigframe(

[PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/kernel/exit.c b/kernel/exit.c index 506a957..df207fc 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1497,7 +1497,7 @@

[PATCH 1/3] Fix Unlikely(x) == y

The patch below was not yet tested. If it's correct as it is, please comment. --- Fix Unlikely(x) == y Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/powerpc/platforms/ps3/interrupt.c b/arch/powerpc/platforms/ps3/interrupt.c index 3a6db04..a14e5cd 100644 --- a/a

[PATCH 3/3] drivers/s390/block/dcssblk.c: Fix Unlikely(x) != y

The patch below was not yet tested. If it's correct as it is, please comment. --- Fix Unlikely(x) != y Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 3faf053..e6c94db 100644 --- a/drivers/s390/block/dcss

[PATCH 2/3] drivers/media/video/sn9c102/sn9c102_core.c Fix Unlikely(x) == y

The patch below was not yet tested. If it's incorrect, please comment. --- Fix Unlikely(x) == y Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/media/video/sn9c102/sn9c102_core.c b/drivers/media/video/sn9c102/sn9c102_core.c index c40ba3a..66313b1 100644 --- a/dr

[PATCH] kernel/sched.c unlikely(x) || unlikely(y) => unlikely(x || y)

Not yet tested. --- Replace unlikely(x) || unlikely(y) by unlikely(x || y) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/kernel/sched.c b/kernel/sched.c index f28f19e..816c299 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -137,7 +137,7 @@ static inline void sg_inc_cpu

[PATCH] drivers/mtd/onenand/onenand_base.c unlikely(x) || unlikely(y) => unlikely(x || y)

Not yet tested. --- Replace unlikely(x) || unlikely(y) by unlikely(x || y) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 8d7d21b..7334b4a 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/d

Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

Roel Kluin wrote: > Replace !likely(x) by likely(!x) > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/arch/x86/kernel/signal_32.c b/arch/x86/kernel/signal_32.c > index caee1f0..335872f 100644 > --- a/arch/x86/kernel/signal_32.c > +++ b/arch/x86/

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

H. Peter Anvin wrote: > Roel Kluin wrote: >> Not entirely sure who to send this to >> --- >> Replace !likely(x) by likely(!x) > > Whoa... > > Are you sure this is correct? > > !likely(x) is equivalent to unlikely(!x), not the opposite, so this is a >

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

H. Peter Anvin wrote: > Roel Kluin wrote: >> H. Peter Anvin wrote: >>> Roel Kluin wrote: >>>> Not entirely sure who to send this to >>>> --- >>>> Replace !likely(x) by likely(!x) >>> Whoa... >>> >>> Are you sure th

Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

Roel Kluin wrote: > Roel Kluin wrote: >> Replace !likely(x) by likely(!x) > sorry, please ignore this patch The patch below shouldn't change semantics. --- replace !likely(x) by unlikely(!x) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/x86/kernel

[PATCH] fs/ufs/util.h 2nd parameter of fs32_to_cpu is not boolean

ter is not boolean --- Test the return value, rather than passing a boolean Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/fs/ufs/util.h b/fs/ufs/util.h index b26fc4d..23ceed8 100644 --- a/fs/ufs/util.h +++ b/fs/ufs/util.h @@ -58,7 +58,7 @@ ufs_set_fs_state(struct super_block *s

Re: Fix bug in end absolute address in drivers/mtd/devices/slram.c

{ >> devlength = simple_strtoul(szlength, &buffer, 0); >> - devlength = handle_unit(devlength, buffer) - devstart; >> + devlength = handle_unit(devlength, buffer); >> if (devlength < devstart) >> g

[PATCH] arch/sh/drivers/heartbeat.c ioremap is expected to succeed

gned-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/sh/drivers/heartbeat.c b/arch/sh/drivers/heartbeat.c index b76a14f..ab77b0e 100644 --- a/arch/sh/drivers/heartbeat.c +++ b/arch/sh/drivers/heartbeat.c @@ -93,7 +93,7 @@ static int heartbeat_drv_probe(struct plat

Re: [PATCH 1/3] Fix Unlikely(x) == y

David Howells wrote: > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > >> Hence shouldn't we ask the gcc people what's the purpose of >> __builtin_expect(), if it doesn't live up to its promise? > > __builtin_expect() is useful on FRV where you _have_ to give each branch and > conditional branch

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

Andrew Morton wrote: > On Wed, 13 Feb 2008 10:41:44 +0100 Roel Kluin <[EMAIL PROTECTED]> wrote: > >> you may also want these: >> --- >> [bl]e_add_cpu conversion in return > upsets powerpc (at least): > > fs/ufs/swab.h: In function `fs64_add': &

[PATCH] wireless: Convert to list_for_each_entry_rcu()

Please verify, this patch was not yet tested. --- Convert list_for_each_rcu() to list_for_each_entry_rcu() Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/strip.c b/drivers/net/wireless/strip.c index 88efe1b..c5aaab8 100644 --- a/drivers/net/wireless/s

[PATCH] fs/ext4/mballoc.c: Convert to list_for_each_entry_rcu()

Please verify, this patch was not yet tested --- Convert list_for_each_rcu() to list_for_each_entry_rcu() Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index dd0fcfc..0c4dd13 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -

Re: [PATCH] wireless: Convert to list_for_each_entry_rcu()

Roel Kluin wrote: > Please verify, this patch was not yet tested. > --- > Convert list_for_each_rcu() to list_for_each_entry_rcu() > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- Same mistake as in other patch, please ignore the previous patch and consider the

Re: [PATCH] fs/ext4/mballoc.c: Convert to list_for_each_entry_rcu()

Aneesh Kumar K.V wrote: > On Tue, Feb 19, 2008 at 01:31:18AM +0100, Roel Kluin wrote: >> Please verify, this patch was not yet tested >> --- >> Convert list_for_each_rcu() to list_for_each_entry_rcu() >> >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> >

Re: [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds

Roel Kluin wrote: > Kristoffer Ericson wrote: >> Greetings, >> >> Richard I've cleaned up the driver by checking with checkpatch.pl as Russell >> suggested. I would appreciate it if you could >> look through the patch again and give comments since the patch

Re: [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds

Kristoffer Ericson wrote: > Greetings, > > Richard I've cleaned up the driver by checking with checkpatch.pl as Russell > suggested. I would appreciate it if you could > look through the patch again and give comments since the patch looks somewhat > different. > > I can add patch for Kconfig/Ma

Re: [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds

Kristoffer Ericson wrote: > Oki, here is attempt #2 (btw, new mail or just keep thread?) > > Tested to build and checkpatch. > > diff --git a/drivers/video/backlight/jornada720_bllcd.c > b/drivers/video/backlight/jornada720_bllcd.c > +static int jornada_bl_update_status(struct backlight_device

Re: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'

James Bottomley wrote: > On Mon, 2008-02-04 at 23:36 +0100, Roel Kluin wrote: >> Note the duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE' >> - if (SCpnt->sc_data_direction == DMA_FROM_DEVICE) { >> + if (SCpnt->sc_data_direction == DMA_T

Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

Greg KH wrote: > On Tue, Feb 05, 2008 at 09:34:54AM +0100, Roel Kluin wrote: >> Henrique de Moraes Holschuh wrote: >>> On Tue, 05 Feb 2008, Roel Kluin wrote: >>>> Roland Dreier wrote: >>>>> > Note the duplicate test 'if (level & T

[PATCH][drivers/usb/serial/ftdi_sio.c] add missing '|'

add missing '|' Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 90dcc62..2173561 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -394,7 +394,7 @@ static const char

[PATCH] [arch/arm/mach-pnx4008/gpio.c] duplication in if ... else if branches

There is a duplication of code in the following section. Possibly it was copy-pasted and it was forgotten to edit these lines? otherwise consider removing the duplicate lines with the patch below. --- Different if ... else if branches do the same, remove duplication Signed-off-by: Roel Kluin

[PATCH wireless/arlan] Replace logical- by bit-and

Totally untested patch below from linus' git tree. The && is incorrect, right? from drivers/net/wireless/arlan.h:390: #define ARLAN_POWER 0x40 #define ARLAN_ACCESS0x80 Replace logical and by bit-and Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- d

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

function was declared: static const char __func__[] = "function-name"; As is DEBUG() - when active - will produce a syntax error. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/pcmcia/au1000_xxs1500.c b/drivers/pcmcia/au1000_xxs1500.c index ce9d5c4

Re: [PATCH wireless/arlan] Replace logical- by bit-and

Randy Dunlap wrote: > On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > >> diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h >> index 3ed1df7..7b7498f 100644 >> --- a/drivers/net/wireless/arlan.h >> +++ b/drivers/net/wireless/arlan.h

Re: [2.6 patch] atm/idt77105.c: fix section mismatch

/powerpc/kernel/vio.c:309:EXPORT_SYMBOL(vio_unregister_device); __cpu_init arch/x86/kernel/topology.c:60:EXPORT_SYMBOL(arch_register_cpu); -- EXPORT_SYMBOL'ed code mustn't be __*init. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-imx/generic.c b/arch/arm/

[PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

logical/bitand typo Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c index ebf9e21..dcfb459 100644 --- a/arch/powerpc/boot/4xx.c +++ b/arch/powerpc/boot/4xx.c @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

Joe Perches wrote: > On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote: >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> >> --- >> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c >> index ebf9e21..dcfb459 100644 >> --- a/arch/powerpc/boot

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

Greg KH wrote: @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, if (block == NULL) { struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL); + struct nlm_host *host; if (conf == NULL) return nlm_gr

Re: [PATCH v4] IBM power meter driver

Mark M. Hoffman wrote: >> +static void ibmpex_register_bmc(int iface, struct device *dev) >> +{ >> +struct ibmpex_bmc_data *data; >> +int err; >> + >> +data = kzalloc(sizeof(*data), GFP_KERNEL); >> +if (!data) { >> +printk(KERN_ERR DRVNAME ": Insufficient memory for BMC

Re: [PATCH 09/31] IGET: Stop BFS from using iget() and read_inode() [try #3]

It is very well possible that I misunderstand the locking order here, but FWIW: David Howells wrote: > diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c > index f346eb1..76798c9 100644 > --- a/fs/bfs/inode.c > +++ b/fs/bfs/inode.c > @@ -32,25 +32,29 @@ MODULE_LICENSE("GPL"); > > void dump_imap(const

[PATCH] asm-arm/{arch-omap,arch-ixp23xx}: parentheses around NR_IRQS definition

paranoya? anyway, adding parentheses should be safe. -- Add parentheses to prevent operator precedence errors Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/include/asm-arm/arch-ixp23xx/irqs.h b/include/asm-arm/arch-ixp23xx/irqs.h index e696395..27c5808 100644 --- a/include/a

Re: [PATCH] asm-arm/{arch-omap,arch-ixp23xx}: parentheses around NR_IRQS definition

Roel Kluin wrote: > Add parentheses to prevent operator precedence errors > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> For the arch-ixp23xx part I should have added: Acked-by: Lennert Buytenhek <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "un

[PATCH] net/e1000: fix memcpy in e1000_get_strings

) / (ETH_GSTRING_LEN * ETH_GSTRING_LEN) Please confirm that the change is as wanted. -- A lack of parentheses around defines causes unexpected results due to operator precedences. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net

[PATCH] asm-h8300: parentheses around definition CLOCK_TICK_RATE

ator precedence errors Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/include/asm-h8300/timex.h b/include/asm-h8300/timex.h index 2041314..23e6701 100644 --- a/include/asm-h8300/timex.h +++ b/include/asm-h8300/timex.h @@ -6,7 +6,7 @@ #ifndef _ASM_H8300_TIMEX_H #define _ASM_H83

[PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl

bta->sampleshift actually may evaluate to something like: (1792000 / 15 ) >> bta->sampleshift Isn't intended (HWBASE_AD * 4)/(bta->decimation >> bta->sampleshift)? Then consider the patch below. -- Fix operator precedence in return Signed-off-by: Roel Kluin <[EMA

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

Paul Mundt wrote: > On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote: >> On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote: >>> -#define DEBUG(x,args...) printk(__FUNCTION__ ": " x,##args) >>> +#define DEBUG(x, args...) printk("%s:

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

Paul Mundt wrote: > On Fri, Jan 11, 2008 at 10:45:30AM +0100, Roel Kluin wrote: >> Paul Mundt wrote: >>> On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote: >>>> On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote: >>>>> -#define DEBUG

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

Paul Mundt wrote: > On Fri, Jan 11, 2008 at 12:04:14PM +0100, Roel Kluin wrote: >> Paul Mundt wrote: >>> Take a look at how CONFIG_PCMCIA_DEBUG is handled. >> In drivers/pcmcia/Makefile, when CONFIG_PCMCIA_DEBUG=y, it gives >> EXTRA_CFLAGS += -DDEBUG >> which

[PATCH drivers/isdn/hardware/eicon/message.c] fix 'and' typo in eicons' AddInfo()

I have previously sent this to [EMAIL PROTECTED] and its maintainer, but the error is still in linus' tree. -- '!' has a higher priority than '&', so as was the bit test masks a binary. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/isdn/

Re: [PATCH 05/18] MMC: OMAP: Introduce new multislot structure and change driver to use it

Carlos Aguiar wrote: > From: Juha Yrjola <[EMAIL PROTECTED]> > > Introduce new MMC multislot structure and change driver to use it. > diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c It could be that I misunderstand, but... > @@ -897,19 +1037,106 @@ static const struct mmc_host_op

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

>>> On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote: >>>> - if (val && 0x1) >>>> + if (val & 0x1) >> Joe Perches wrote: >>> I think this pattern should be added to checkpatch >>> + if ($line =

[drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy(): if (pause_adv & (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM)) Note that the two are the same and this is therefore equivalent to if (pause_adv & ADVERTISE_1000XPSE_ASYM) This appears to be incorrect, was maybe '| A

[PATCH][drivers/net/fec_mpc52xx.c] duplicate NETIF_MSG_IFDOWN in MPC52xx_MESSAGES_DEFAULT

Untested patch below, please confirm it's the right fix. -- duplicate NETIF_MSG_IFDOWN, 2nd should be NETIF_MSG_IFUP Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c index f91ee70..ca3c3b3 100644 --- a/drivers/net/fe

[PATCH][net/sched/sch_teql.c] duplicate IFF_BROADCAST in FMASK, remove 2nd

Untested patch below, please confirm it's the right fix (should it be some other IFF_*?) -- duplicate IFF_BROADCAST, remove 2nd Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index c0ed06d..a53acf4 100644 --- a/net/sched/sch_t

[PATCH][drivers/pcmcia/ti113x.h] ENE_TEST_C9_PFENABLE duplicate *_F0

Untested patch below, please confirm it's the right fix. -- duplicate ENE_TEST_C9_PFENABLE_F0, 2nd should be *_F1 Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/pcmcia/ti113x.h b/drivers/pcmcia/ti113x.h index d29657b..87a5fd5 100644 --- a/drivers/pcmcia/ti1

[PATCH][drivers/usb/gadget/amd5536udc.c] duplicate use_dma_ppb_du => 2nd use_dma_ppb

Untested patch below, please confirm it's the right fix. -- duplicate use_dma_ppb_du, 2nd should be use_dma_ppb Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c index c72e962..fbc10f9 100644 --- a/drivers

[PATCH][scripts/{genksyms/parse.c,kconfig/zconf.tab)_shipped] duplicate YYSTYPE_IS_TRIVIAL =>1st *_DECLARED

Untested patch, please confirm it's the right fix. -- duplicate YYSTYPE_IS_TRIVIAL, 2nd should be YYSTYPE_IS_DECLARED Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/scripts/genksyms/parse.c_shipped b/scripts/genksyms/parse.c_shipped index 3e6079f..61f7539 100644 --

Re: [rfc-patch 07/11] Text Edit Lock - kprobes architecture independent support

Mathieu Desnoyers wrote: > Use the mutual exclusion provided by the text edit lock in the kprobes code. > It > allows coherent manipulation of the kernel code by other subsystems. > > Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]> > Acked-by: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> >

Re: [PATCH 7/8] UML - add virt_to_pte

Jeff Dike wrote: > Turn um_virt_to_phys into virt_to_pte, cleaning up a horrid interface. > > It's also made non-static and declared in pgtable.h because it'll be > needed when the stubs get a vma. > > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> > --- > arch/um/kernel/skas/uaccess.c | 56 > +

[PATCH] fix 'and' typos in drivers/block/pktcdvd.c

Fix two 'and' typos Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index a8130a4..9cd6ba2 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2202,11 +2202,11 @@ static int pkt_media_speed(struc

[PATCH] fix 'and' typo in drivers/block/paride/pt.c

Fix 'and' typo (PT_WRITE_OK is defined 2) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/block/paride/pt.c b/drivers/block/paride/pt.c index 9f4e67e..b91accf 100644 --- a/drivers/block/paride/pt.c +++ b/drivers/block/paride/pt.c @@ -664,7 +664,7 @@ st

Debugging activated during runtime

Wouldn't it be nice to be able to specify upon loading, or during runtime to modules whether debug messages should be printed? - No kernel recompile needed for debugging. - Less *_DEBUG options required in menuconfig. How I think this could work: Add to the module struct a bool to denote debugging

Re: Debugging activated during runtime

Jan Engelhardt wrote: > On Oct 28 2007 16:15, Roel Kluin wrote: >> Wouldn't it be nice to be able to specify upon loading, or during runtime >> to modules whether debug messages should be printed? > > modprobe ark3116 debug=1 > > Nothing new. Ok, thanks and so

build failure, missing libvdeplug.h?

Building uml with an allyesconfig and a few changes in UML only fails with: ... CC arch/um/drivers/vde_user.o /home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vde_user.c:8:24: error: libvdeplug.h: No such file or directory /home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vd

Re: build failure, missing libvdeplug.h?

Roel Kluin wrote: > the file libvdeplug.h is missing > > There is a reference to http://wiki.virtualsquare.org/index.php/Main_Page in > the Kconfig (also added by this commit). > After reverting this commit the build continues. possibly the header > libvdeplug.h was for

Re: [PATCH 9/16] CRIS architecture: Correct compile errors

Jesper Nilsson wrote: > static int > e100_probe_transceiver(struct net_device* dev) > { > +#if !defined(CONFIG_ETRAX_NO_PHY) > unsigned int phyid_high; > unsigned int phyid_low; > unsigned int oui; > struct transceiver_ops* ops = NULL; > + struct net_local *np = netd

Re: [PATCH] several returns before unlocking in lmc_ioctl

Kristof Provost wrote: > On 2007-10-23 03:47:48 (+0200), Roel Kluin <[EMAIL PROTECTED]> wrote: >> I think we should keep the lmc_tracing. Use this patch instead. >> >> -- >> Several returns before unlocking in lmc_ioctl >> >>

Re: [2.6 patch] fix drivers/net/wan/lmc/ compilation

Adrian Bunk wrote: > Documentation/SubmitChecklist, point 1: > > <-- snip --> > > ... > CC drivers/net/wan/lmc/lmc_main.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In > function ‘lmc_ioctl’: > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wa

Re: [PATCH 9/9] RT: Only dirty a cacheline if the priority is actually changing

Gregory Haskins wrote: > We can avoid dirtying a rq related cacheline with a simple check, so why not. > > Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> > --- > > 0 files changed, 0 insertions(+), 0 deletions(-) I think you wanted a patch here? - To unsubscribe from this list: send the lin

[PATCH] errors with assignments in if

ors with assignments in ifs Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c index d9af436..e6e85b7 100644 --- a/arch/arm/mach-omap2/clock.c +++ b/arch/arm/mach-omap2/clock.c @@ -651,7 +651,7 @@ static u32 omap2_

Re: [PATCH] errors with assignments in if

Roel Kluin wrote: > I am not entirely certain about the third one: > > from fs/udf/udf_sb.h: > > #define UDF_SB_VAT(X) ( UDF_SB(X)->s_vat ) > > if it's the desired behavior then I think this should at least be changed to > > UDF_S

[PATCH] return hidden bug

return hidden bug Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index e1c4707..6a69425 100644 --- a/arch/alpha/kernel/pci_iommu.c +++ b/arch/alpha/kernel/pci_iommu.c @@ -365,8 +365,8 @@ pci_unmap_single(

Re: [PATCH] return hidden bug

Rik van Riel wrote: > On Mon, 22 Oct 2007 03:05:05 +0200 > Roel Kluin <[EMAIL PROTECTED]> wrote: > >> return hidden bug >> >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> >> >> diff --git a/arch/alpha/kernel/pci_iommu.c >&g

[PATCH] unlock before bug returns

I think the unlock should be before bugging? -- unlock before bug returns Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 5a4cc20..c910170 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach

Re: [PATCH] unlock before bug returns

Roel Kluin wrote: > unlock before bug returns > if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) { > printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs); > - BUG(); > spin_unlock(&gpmc_m

Re: [PATCH] unlock before bug returns

ome cases where it was attempted to free after BUG(). should that occur before BUG() as well? -- Unlock before BUG() Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c index 88629a3..679c8b4 100644 --- a/drivers/mtd/ubi

[PATCH retry] return hidden bug and unlock bugs

fore BUG(), but don't change behavior in the case when CONFIG_BUG is disabled Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index e1c4707..6a69425 100644 --- a/arch/alpha/kernel/pci_iommu

Re: [PATCH] return hidden bug

Ray Lee wrote: > I'm sorry, perhaps I poured myself a cup of stupid this morning, but > isn't the above patch effectively introducing a BUG where none could > be reached before? In other words, for the patch to have zero > behavioral change, wouldn't it have to remove the BUG() altogether? True,

  1   2   >