(cc'ing Andrew)
On Wed, Dec 26, 2012 at 06:00:02PM -0800, Kent Overstreet wrote:
> This implements a refcount with similar semantics to
> atomic_get()/atomic_dec_and_test(), that starts out as just an atomic_t
> but dynamically switches to per cpu refcounting when the rate of
> gets/puts becomes t
h, enlarge pa[] arrays by one.
While this plugs the discovered issues, the whole code base is
horrible and in desparate need of rewrite. It's fragile like hell,
difficult to read and maintain, and plain ugly.
Signed-off-by: Tejun Heo
Cc: sta...@vger.kernel.org
---
Andrew, these are furth
and relocate
other MAX_IDR_* constants to lib/idr.c.
Signed-off-by: Tejun Heo
Cc: Jean Delvare
Cc: linux-...@vger.kernel.org
Cc: Roland Dreier
Cc: Sean Hefty
Cc: Hal Rosenstock
Cc: "Marciniszyn, Mike"
Cc: Jack Morgenstein
Cc: Or Gerlitz
Cc: linux-r...@vger.kernel.org
Cc: Al Viro
with bitmap_clear().
This patch doesn't (or at least shouldn't) introduce any behavior
changes.
Signed-off-by: Tejun Heo
---
include/linux/idr.h | 12 +---
lib/idr.c | 34 +-
2 files changed, 18 insertions(+), 28 deletions(-)
---
n the previous 6 on 64bit and 7 on 32bit.
Signed-off-by: Tejun Heo
---
include/linux/idr.h | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
--- a/include/linux/idr.h
+++ b/include/linux/idr.h
@@ -17,14 +17,13 @@
#include
#include
-#if BITS_PER_LONG == 32
-# define IDR_B
Add a field which carries the prefix of ID the idr_layer covers. This
will be used to implement lookup hint.
This patch doesn't make use of the new field and doesn't introduce any
behavior difference.
Signed-off-by: Tejun Heo
---
include/linux/idr.h |1 +
lib/idr.c
which can be inlined.
idr->hint is set to the leaf node on idr_fill_slot() and cleared from
free_layer().
Signed-off-by: Tejun Heo
---
include/linux/idr.h | 25 -
lib/idr.c | 38 --
2 files changed, 40 insertions(+)
Hello,
On Fri, Feb 08, 2013 at 10:09:13PM +, Hefty, Sean wrote:
> > Used to wrap cyclic @start. Can be replaced with max(next, 0).
> > Note that this type of cyclic allocation using idr is buggy. These
> > are prone to spurious -ENOSPC failure after the first wraparound.
>
> The repla
Hello, Hillf.
On Fri, Feb 08, 2013 at 11:39:56AM +0800, Hillf Danton wrote:
> The comment just above cpu_stop_signal_done() says it is uncertain that
> the input @done is valid, and the works enqueued through the function
> stop_one_cpu_nowait() do carry no done, thus we have to check if it is
> v
Hello, again.
On Fri, Feb 08, 2013 at 11:42:43AM +0800, Hillf Danton wrote:
> As checked with BUG_ON in the case of CPU_UP_PREPARE, we have to dequeue
> work first for further actions, then stopper reaches sane and clear state.
When a CPU is finally put down in either CPU_UP_CANCELLED or
CPU_POST
On Mon, Jan 28, 2013 at 12:02:27AM +0300, Stanislav Yakovlev wrote:
> Hello, Tejun,
>
> On 22 December 2012 04:56, Tejun Heo wrote:
> > * Drop unnesssary delayd_work_pending() tests.
> >
> > * Unify scan_event_{now|later} by using mod_delayed_work() w/ 0 del
On Tue, Jan 29, 2013 at 08:53:18PM +0900, Masami Hiramatsu wrote:
> >> Acked-by: Masami Hiramatsu
> >
> > Can I take it through workqueue branch w/ other patches?
>
> Yes, of course. I think it is not a critical bug, so I can
> wait for other patches.
Applied to wq/for-3.9-cleanups.
Thanks!
-
On Fri, Jan 04, 2013 at 03:19:55PM -0600, Dan Williams wrote:
> On Fri, 2012-12-21 at 17:57 -0800, Tejun Heo wrote:
> > i2400m_net_wake_tx() sets ->wake_tx_skb with the given skb if
> > ->wake_tx_ws is not pending; however, i2400m_wake_tx_work() could have
> > just st
Hey, Andrew.
On Mon, Feb 11, 2013 at 03:39:55PM -0800, Andrew Morton wrote:
> This doesn't apply happily to 3.7, so Greg will be needing a redone
> version when the time arrives.
>
> But does it really need backporting? Is anyone likely to hit this in
> practice?
For most cases, probably not.
Hello,
On Tue, Feb 12, 2013 at 07:07:20PM +0200, Imre Deak wrote:
> It's the one implemented by sg_miter_{start,stop} in scatterlist.c. It
> also iterates through a scatterlist a page at a time, but it also kmaps
> these pages. Since in our use case we don't need to map the pages we
> needed a sol
spin_unlock(&dev->object_name_lock);
> + idr_preload_end();
> ret = 0;
Oops, sorry about that.
Acked-by: Tejun Heo
Andrew, the original patch can be found at
http://article.gmane.org/gmane.linux.kernel/1439101/raw
Thanks.
--
tejun
--
To uns
Style cleanups suggested by Wolfram.
* s/res/id/ in i2c_add_numbered_adapter() so that it matches
i2c_add_adapter().
* Add a blank line before return in i2c_add_numbered_adapter().
This patch is purely cosmetic.
Signed-off-by: Tejun Heo
Cc: Wolfram Sang
---
drivers/i2c/i2c-core.c | 13
On Tue, Feb 12, 2013 at 09:34:14AM -0800, Tejun Heo wrote:
> Style cleanups suggested by Wolfram.
>
> * s/res/id/ in i2c_add_numbered_adapter() so that it matches
> i2c_add_adapter().
>
> * Add a blank line before return in i2c_add_numbered_adapter().
>
> This
pdating @done->ret.
>
> Thanks Tejun for sharing commit message.
>
> Signed-off-by: Hillf Danton
> Reviewed-by: Namhyung Kim
Acked-by: Tejun Heo
Andrew, can you please take this?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ke
lls and most, if not all, cpu stop users pin target CPUs.
>
> Fix it by popping each work item off stopper->works.
>
> Thanks Tejun for sharing commit message, again.
>
> Signed-off-by: Hillf Danton
> Reviewed-by: Namhyung Kim
> Cc: sta...@vger.kernel.org
Acked
Hey, Rafael.
On Tue, Feb 12, 2013 at 09:53:08PM +0100, Rafael J. Wysocki wrote:
> This looks fishy, but I wonder if Tejun has any ideas.
>
> Tejun, can you please have a look at the call trace below? It looks like
> the workqueues code is involved heavily.
> >
> > kworker/0:0/4 is trying to acq
it:
> commit 430440fce7da4ad52c2af06a04a5132e5d19faaf
> Author: Tejun Heo
> Date: Thu Feb 7 12:31:37 2013 +1100
>
> drm: convert to idr_alloc()
>
>
> More concretely to the change in drm_gem_flink_ioctl. If I revert solely
> that one, it works again. Maybe I'm blind, but I do not see why
Hello, Jiri.
On Tue, Feb 12, 2013 at 11:08:41PM +0100, Jiri Slaby wrote:
> > Oh my, maybe: return ret < 0 ? ret : 0... Let's try.
>
> Bull's eye.
Aieee
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -459,6 +459,7 @@ drm_gem_flink_ioctl(struct drm_device *dev, void
Hello, Jens.
On Tue, Apr 2, 2013 at 2:53 AM, Jens Axboe wrote:
> Thanks, pulled in for testing. We'll need the debug change in before
> sending this upstream, though. I agree with Jan/Dave that this is
> required functionality, for debugging purposes.
Yeah, sure thing. The debug changes are targ
Hello, Vineet.
On Sat, Mar 30, 2013 at 11:43:11AM +0530, Vineet Gupta wrote:
> Although in line [2], ARC trouble-shooting code prints the task path (rather
> than
> comm). This was done to help identify faulting LTP open posix tests with same
> name
> in different directories: e.g. fork/6-1, sig
Hello,
On Mon, Apr 01, 2013 at 12:11:17PM -0600, Bjorn Helgaas wrote:
> > + dump_stack_set_arch_desc("%s %s%s%s", vendor, product,
> > +board ? "/" : "", board ? board : "");
> > +}
>
> Should this be combined or made consistent with dmi_dump_ids()? They
> l
Hello, Martin.
On Tue, Apr 02, 2013 at 08:48:08AM +0200, Martin Schwidefsky wrote:
> > The couple of extra fields aren't worth an s390 version of dump_stack()
> > that differs from all other architectures.
> > Please drop the s390 version as well. Thanks!
>
> Hmm, we would lose task_thread_info(c
Hello,
Andrew, I think it's about ready and nobody seems to be against the
proposed changes. Can you please take these into -mm?
This v2 of this patchset. Changes from the last posting[1] are,
* CPU is now printed for both dump_stack() and show_regs() which s390
folks tell me should be enoug
tack(NULL, NULL)'s behavior in line with
dump_stack().
Signed-off-by: Tejun Heo
---
arch/x86/kernel/dumpstack.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index c8797d5..dd1a7c3 100644
-
d
@_ksp is NULL. This makes %fp fetching in dump_stack() unnecessary.
Make it use NULL for @_ksp instead.
Only compile tested.
Signed-off-by: Tejun Heo
Acked-by: David S. Miller
---
arch/sparc/kernel/process_32.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --
dump_stack_print_info()
as that will bring in the generic version of dump_stack() too. v1
The v1 patch broke build on blackfin due to this issue. The build
breakage was reported by Fengguang Wu.
Signed-off-by: Tejun Heo
Acked-by: David S. Miller
Acked-by: Vineet Gupta
Acked-by: Je
he same string as the debug message from dmi_present() which
also contains BIOS information. Move hardware name into its own
line as warn_slowpath_common() did. This change was suggested by
Bjorn Helgaas.
Signed-off-by: Tejun Heo
Cc: Bjorn Helgaas
---
arch/ia64/kernel/setup.c
est_init+0x140/0x140
...
v2: Typo fix in x86-32.
v3: CPU number dropped from show_regs_print_info() as
dump_stack_print_info() has been updated to print it. s390
specific implementation dropped as requested by s390 maintainers.
Signed-off-by: Tejun Heo
Acked-by: David S. Miller
Acke
id: 50, comm: crash Not tainted 3.9.0-rc4+ #132 <-- [3]
...
Remove them.
tj: Updated patch desc.
Signed-off-by: Vineet Gupta
Signed-off-by: Tejun Heo
---
arch/arc/kernel/troubleshoot.c | 2 +-
kernel/signal.c| 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
d
dated to format the information into
dmi_ids_string[] using the new function and print it with "DMI:"
prefix. dmi_ids_string[] will be used for another purpose by a future
patch.
Signed-off-by: Tejun Heo
Cc: Bjorn Helgaas
---
drivers/firmware/dmi_scan.c | 44 +++
Hello,
Andrew, this one depends on the debug info unification patch and
should be routed through -mm too. The writeback folks seem to be okay
with the proposed changes although nobody explicitly acked it yet
(please do so). Please route these together with the previous set
through -mm. Thanks.
_stack+0x19/0x1b
[] warn_slowpath_common+0x7f/0xc0
[] warn_slowpath_null+0x1a/0x20
[] bdi_writeback_workfn+0x2a0/0x3b0
...
Signed-off-by: Tejun Heo
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Andrew Morton
Cc: Jan Kara
Cc: Jens Axboe
Cc: Dave Chinner
---
include/linux/workqueue.h | 5 +++
7d08
Call Trace:
[] dump_stack+0x19/0x1b
[] warn_slowpath_common+0x70/0xa0
[] warn_slowpath_null+0x1a/0x20
[] bdi_writeback_workfn+0x2b4/0x3c0
[] process_one_work+0x1d7/0x660
[] worker_thread+0x122/0x380
[] kthread+0xea/0xf0
[] ret_from_fork+0x7c/0xb0
Signed-off-by: Tejun Heo
Cc: Da
-by: Tejun Heo
Cc: Oleg Nesterov
Cc: Andrew Morton
Cc: Jan Kara
---
include/linux/kthread.h | 1 +
kernel/kthread.c| 19 +++
2 files changed, 20 insertions(+)
diff --git a/include/linux/kthread.h b/include/linux/kthread.h
index 8d81664..7dcef33 100644
--- a/include/linux
On Tue, Apr 02, 2013 at 10:26:48AM +0200, Michal Hocko wrote:
> Tejun,
> could you take this one please?
Aye aye, applied to cgroup/for-3.10.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More ma
On Wed, Apr 03, 2013 at 05:11:15PM +0800, Li Zefan wrote:
> (I'll be off from my office soon, and I won't be responsive in the following
> 3 days.)
>
> I'm working on converting memcg to use cgroup->id, and then we can kill
> css_id.
>
> Now memcg has its own refcnt, so when a cgroup is destroye
Hello, Viresh.
Sorry about the delay. Lost this one somehow.
On Mon, Apr 01, 2013 at 12:01:05PM +0530, Viresh Kumar wrote:
> Just wanted to make this clear before writing it:
>
> You want me to do something like (With better names):
>
> int wq_unbound_for_power_save_enabled = 0;
>
> #ifdef CO
Hey,
On Thu, Apr 04, 2013 at 01:37:50PM +0200, Michal Hocko wrote:
> On Wed 03-04-13 17:13:08, Li Zefan wrote:
> > Suppose we rmdir a cgroup and there're still css refs, this cgroup won't
> > be freed. Then we rmdir the parent cgroup, and the parent is freed due
> > to css ref draining to 0. Now i
On Thu, Apr 04, 2013 at 10:01:14PM +0800, Aaron Lu wrote:
> In blk_register_queue, we will end bypass mode for the queue; but in
> blk_unregister_queue, we didn't start bypass mode for it. This would
> cause the WARN_ON_ONCE(q->bypass_depth < 0) to trigger if the queue gets
> registered, unregister
Hello, Lai.
On Thu, Apr 04, 2013 at 10:05:32AM +0800, Lai Jiangshan wrote:
> @@ -4757,25 +4747,16 @@ void thaw_workqueues(void)
> {
> struct workqueue_struct *wq;
> struct pool_workqueue *pwq;
> - struct worker_pool *pool;
> - int pi;
>
> mutex_lock(&wq_pool_mutex);
>
On Thu, Apr 04, 2013 at 10:05:34AM +0800, Lai Jiangshan wrote:
> merge the code of clearing POOL_DISASSOCIATED to rebind_workers(), and
> rename rebind_workers() to associate_cpu_pool().
>
> It merges high related code together and simplify
> workqueue_cpu_up_callback().
>
> Signed-off-by: Lai Ji
Hello,
On Thu, Apr 04, 2013 at 10:16:39PM +0800, Aaron Lu wrote:
> It probably wouldn't happen for normal user, only for some SCSI driver
> developers like me, e.g. the sr_mod will normally load during boot, and
> when I made some changes to the code, I'll unload the driver and reload
> it. This i
On Thu, Apr 04, 2013 at 10:05:36AM +0800, Lai Jiangshan wrote:
> When we fail to allocate the node pwq, we can use the default pwq
> for the node.
>
> Thus we can avoid failure after allocated default pwq, and remove
> some code for failure path.
I don't know about this one. The reason why we fa
Hello,
On Thu, Apr 04, 2013 at 10:05:37AM +0800, Lai Jiangshan wrote:
> calculate the node of the pool earlier, and allocate the pool
> from the node.
>
> Signed-off-by: Lai Jiangshan
> ---
> kernel/workqueue.c | 29 +++--
> 1 files changed, 15 insertions(+), 14 deleti
rote description.
Signed-off-by: Lai Jiangshan
Signed-off-by: Tejun Heo
Reported-by: Fengguang Wu
---
Applied to wq/for-3.10.
Thanks.
kernel/workqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index dd2a4c4..c273376 100
On Thu, Apr 04, 2013 at 05:20:28PM +0200, Michal Hocko wrote:
> > But what harm does an additional reference do?
>
> No harm at all. I just wanted to be sure that this is not yet another
> "for memcg" hack. So if this is useful for other controllers then I have
> no objections of course.
I think
Hey,
On Thu, Apr 04, 2013 at 09:42:09AM +0800, Fengguang Wu wrote:
> > > 4433/* copy worker description */
> > > > 4434probe_kernel_read(&desc_valid, &worker->desc_valid,
> > > > sizeof(desc_valid));
> > > 4435if (desc_valid)
> >
> > I don't know what to m
Hello,
The following happens on my test machine which has an on-board VGA
which is not connected. The failure is expected but, in the failure
path, it calls radeon_irq_kms_fini() which flushes @rdev->*_work when
@rdev seemingly hasn't gone through radeon_irq_kms_init(), ending up
trying to flush
Hello, Valdis.
On Tue, Mar 26, 2013 at 02:06:03PM -0400, Valdis Kletnieks wrote:
> Seen in the dmesg for next-20130325, but looks like it's been doing
> it since at least next-20130218.
>
> [ 50.162584] dell_wmi: Received unknown WMI event (0x11)
> [ 51.167629] INFO: trying to register non-st
Hello,
On Sat, Mar 09, 2013 at 10:44:30PM -0800, Yinghai Lu wrote:
> Now we have arch_pfn_mapped array, and max_low_pfn_mapped should not
> be used anymore.
>
> User should use arch_pfn_mapped or just 1UL<<(32-PAGE_SHIFT) instead.
>
> Only user is ACPI_INITRD_TABLE_OVERRIDE, and it should not us
ually happen?
> Signed-off-by: Yinghai Lu
> Cc: Fenghua Yu
For 01 and 02
Acked-by: Tejun Heo
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ke
eparated patch, also
> rename array name to acpi_initrd_files.
>
> Signed-off-by: Yinghai
> Cc: Rafael J. Wysocki
> Cc: linux-a...@vger.kernel.org
Acked-by: Tejun Heo
> @@ -648,14 +647,14 @@ void __init acpi_initrd_override(void *data, size_t
> size)
>
ONFIG_ACPI. Move the prototypes and dummy
implementations of the newly split functions below CONFIG_ACPI block
in acpi.h so that we can do away with #ifdefs in its user.
Acked-by: Tejun Heo
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe lin
On Sat, Mar 09, 2013 at 10:44:33PM -0800, Yinghai Lu wrote:
> In 32bit we will find table with phys address during 32bit flat mode
> in head_32.S, because at that time we don't need set page table to
> access initrd.
>
> For copying we could use early_ioremap() with phys directly before mem mappin
On Thu, Apr 04, 2013 at 11:27:42AM -0700, Tejun Heo wrote:
> > + /*
> > +* have to use unsigned long, otherwise 32bit spit warning
> > +* and it is ok to unsigned long, as bootloader would not
> > +* load initrd a
Hello,
On Sat, Mar 09, 2013 at 10:44:34PM -0800, Yinghai Lu wrote:
> For finding with 32bit, it would be easy to access initrd in 32bit
> flat mode, as we don't need to set page table.
>
> That is from head_32.S, and microcode updating already use this trick.
>
> Need to change acpi_initrd_overr
ut locking interface anyway. Make it static too.
Signed-off-by: Tejun Heo
---
include/linux/cgroup.h | 5 -
kernel/cgroup.c| 9 +++--
2 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index f8eb01d..63deb70 100644
--- a/inc
ned-off-by: Tejun Heo
---
include/linux/cgroup.h | 13 +
kernel/cgroup.c| 20 ++--
2 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 63deb70..515927e 100644
--- a/include/linux/cgroup.h
+++ b/inc
Now that locking interface is unexported, there's no reason to keep
around these thin wrappers. Kill them and use mutex operations
directly.
Signed-off-by: Tejun Heo
---
kernel/cgroup.c | 41 +++--
1 file changed, 11 insertions(+), 30 deletions(-)
move_member_tasks_to_cpuset() with it.
Signed-off-by: Tejun Heo
Cc: Li Zefan
---
include/linux/cgroup.h | 1 +
kernel/cgroup.c| 28 +++
kernel/cpuset.c| 51 ++
3 files changed, 35 insertions(+), 45 deletions(-)
diff --git
cgroup_lock_live_group() and cgroup_attach_task() are scheduled to be
made static. Relocate the former and cgroup_attach_task_all() so that
we don't need forward declarations.
This patch is pure relocation.
Signed-off-by: Tejun Heo
---
kernel/cgroup.c
Hello,
Most cgroup_mutex abuses outside cgroup core proper have been
eradicated but there's still one use remaining and locking interface
is still exported. This patchset updates the last user and unexports
the locking interface and is composed of the following five patches.
0001-cgroup-cpuset-
On Fri, Apr 5, 2013 at 2:47 AM, Viresh Kumar wrote:
> module_param()?? We can't compile kernel/workqueue.c as a module and
> hence i went with #define + a variable with functions to set/reset it...
module_param works fine for kernel proper.
--
tejun
--
To unsubscribe from this list: send the lin
Hello, guys.
Status-quo
==
It's been about a year since I wrote up a summary on cgroup status quo
and future plans. We're not there yet but much closer than we were
before. At least the locking and object life-time management aren't
crazy anymore and most controllers now support prope
Hello, Sedat.
On Mon, Jan 28, 2013 at 11:06:11PM +0100, Sedat Dilek wrote:
> 1. People should sent their patches concerning especially Linux-Next
> fixes not only to LKML but also to (if
> this is not known, pointing to James).
>
> 2. These patches for Linux-Next should contain a "-next" in thei
Hey, Kent.
On Tue, Jan 29, 2013 at 08:39:42AM -0800, Kent Overstreet wrote:
> Oh, if this is going to be widely used I should probably have a
> different implementation for archs that don't have atomic64_t in
> hardware. Don't suppose you know the CONFIG_ macro to test against? I
> couldn't find i
.
>
> Cc: Tejun Heo
> Cc: Serge Hallyn
> Signed-off-by: Aristeu Rozanski
Acked-by: Tejun Heo
Can you please keep acks across postings? That makes it a bit easier
for reviewers.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
On Tue, Jan 29, 2013 at 02:08:01PM -0500, a...@redhat.com wrote:
> In preparation for the next patch, reorder dev_exception_add() and
> dev_exception_rm().
It would be nice to have something like "this change doesn't introduce
any functional changes".
> Cc: Tejun
in two, one to just move dev_exception_rm() before
> dev_exception_add() while keeping functional changes in this patch as
> requested by Tejun.
>
> Cc: Tejun Heo
> Cc: Serge Hallyn
> Signed-off-by: Aristeu Rozanski
Acked-by: Tejun Heo
Thanks.
--
tejun
--
To unsubscribe
On Tue, Jan 29, 2013 at 02:08:03PM -0500, a...@redhat.com wrote:
> In order to make the next patch more clear, expand may_access() logic.
>
> Cc: Tejun Heo
> Cc: Serge Hallyn
> Signed-off-by: Aristeu Rozanski
Maybe convert the function to return bool while at it?
Acke
owards its cgroup parent,
> which
> might have different behavior.
>
> v2:
> - updated patch description
> - rebased on top of a new patch to expand the may_access() logic to make it
> more clear
> - fixed argument description order in may_access()
>
> Cc: Tejun He
ode is on the hierarchy
or not for config propagation and inheritance. It would be nice if
you explain the synchornization implications.
> Cc: Tejun Heo
> Cc: Serge Hallyn
> Signed-off-by: Aristeu Rozanski
Other than that,
Acked-by: Tejun Heo
--
tejun
--
To unsubscribe from this
On Tue, Jan 29, 2013 at 02:08:06PM -0500, a...@redhat.com wrote:
> This patch is in preparation for hierarchy support
It would be nice to note this is purely organizational and doesn't
make any functional changes.
> Cc: Tejun Heo
> Cc: Serge Hallyn
> Signed-off-by: Aristeu Ro
On Tue, Jan 29, 2013 at 02:08:07PM -0500, a...@redhat.com wrote:
> This patch is in preparation for hierarchy support.
Ditto.
> Cc: Tejun Heo
> Cc: Serge Hallyn
> Signed-off-by: Aristeu Rozanski
Acked-by: Tejun Heo
Thanks.
--
tejun
--
To unsubscribe from this list: s
Hello, Kent.
On Tue, Jan 29, 2013 at 11:51:41AM -0800, Kent Overstreet wrote:
> > What about overflow? Note that we can have systemetic cases where ref
> > is gotten on one cpu and put on another transferring counts in a
> > specific direction.
>
> Heh, this keeps coming up.
>
> It works becaus
;
> + if (is_devcg_online(devcg))
> + list_add_tail(&devcg->propagate_pending, &pending);
> + }
> + rcu_read_unlock();
I think it could be a good idea to factor out the above and document
what's going on and why.
Other than that,
Acked-by: Tejun Heo
Thanks.
--
t
Hey, Kent.
On Tue, Jan 29, 2013 at 01:45:37PM -0800, Kent Overstreet wrote:
> It would definitely be cleaner if the global counter was also 32 bits (I
> probably should've done it that way at first) but it works with it being
> bigger _provided the sum of the percpu counters is sign extended_ when
Hello,
On Wed, Jan 30, 2013 at 12:49 PM, Aristeu Rozanski > that's not
intentional. thanks for catching this
>
> Tejun, you want me to resubmit the whole series or just the next patch
> (where I was supposed to move that chunk)?
If it doesn't affect the next patch, just posting an updated version
Hello, guys.
On Fri, Feb 01, 2013 at 01:17:58AM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
> head: 04c2eee5b9dfcb13f3cd07a5537fb8c785f2751a
> commit: a3201227f803ad7fd43180c5195dbe5a2bf998aa freezer: make freezing()
> test freez
Hello, David.
Sorry about the delay.
On Wed, Jan 30, 2013 at 04:24:18PM -0500, David Teigland wrote:
> > Unfortunately, the list_for_each_entry doesn't seem to be clearing
> > everything. I've seen "warning: recover_list_count 39" at the end of that
> > function.
>
> I don't want to pretend to
Hello, Trond.
On Wed, Jan 30, 2013 at 02:18:06AM +, Myklebust, Trond wrote:
> My worry is more about Tejun's comment that we did actually need a call
> to idr_remove_all() in the original code. Do we need to queue up a fix
> for the 3.8 and existing stable kernels?
IIUC, the only case where i
Hello, David.
On Thu, Jan 31, 2013 at 03:53:20PM -0800, Tejun Heo wrote:
> The function description is misleading. The function does search
> inclusive range and needs explicit cursor increment to make progress.
> Weird that it doesn't work. Looking into it. I'll write when
Hello, Chris.
On Thu, Jan 31, 2013 at 07:46:09PM -0500, Chris Metcalf wrote:
> That seems reasonable to me, but I'm happy to experiment with
> including Kconfig.freezer from the arch/tile/Kconfig if that feels
> like a better solution.
AFAICS, there's nothing arch specific about freezer and cgrou
On Thu, Jan 31, 2013 at 09:23:08PM -0500, Chris Metcalf wrote:
> On 1/31/2013 7:52 PM, Tejun Heo wrote:
> > Hello, Chris.
> >
> > On Thu, Jan 31, 2013 at 07:46:09PM -0500, Chris Metcalf wrote:
> >> That seems reasonable to me, but I'm happy to experiment with
Hello, David.
On Fri, Feb 01, 2013 at 12:44:43PM -0500, David Teigland wrote:
> I already tried my own version of this, but used idr_for_each_entry a
> second time. Unfortunately, the number it found and printed did not match
> recover_list_count.
>
> warning: recover_list_count 566
>
> It prin
On Thu, Jan 24, 2013 at 02:43:28PM +0800, Li Zefan wrote:
> In cgroup_exit() put_css_set_taskexit() is called without any lock,
> which might lead to accessing a freed cgroup:
>
> thread1 thread2
> -
> exit()
> cgroup_exit()
>
On Thu, Jan 24, 2013 at 02:43:51PM +0800, Li Zefan wrote:
> init_task.cgroups is initialized at boot phase, and whenver a ask
> is forked, it's cgroups pointer is inherited from its parent, and
> it's never set to NULL afterwards.
>
> Signed-off-by: Li Zefan
Applied to cgroup/for-3.9.
Thanks.
On Thu, Jan 24, 2013 at 10:19:23AM -0800, Tejun Heo wrote:
> * cgroup_release_agent() seems broken too. It's accessing cgrp after
> removing it from release_list. Can you please fix it too?
Oh, we should be okay as we're holding cgroup_mutex there. Please
forget about th
rks
> unusable for non-GPL modules, because initialization macro now requires
> GPL symbol. For example schedule_delayed_work() available for non-GPL.
>
> Signed-off-by: Konstantin Khlebnikov
> Cc: Tejun Heo
> Cc: sta...@vger.kernel.org # 3.7
Applied to wq/for-3.8-fixes. Thanks
Hey, Joonsoo.
On Thu, Jan 24, 2013 at 06:29:36PM +0900, Joonsoo Kim wrote:
> > -static DEFINE_PER_CPU(struct global_cwq, global_cwq);
> > +static DEFINE_PER_CPU(struct worker_pool [NR_STD_WORKER_POOLS],
> > + cpu_std_worker_pools);
> > static DEFINE_PER_CPU_SHARED_ALIGNED(atomic_t
Hey, Lai.
On Thu, Jan 24, 2013 at 09:36:39PM +0800, Lai Jiangshan wrote:
> For the whole patchset
> Reviewed-by: Lai Jiangshan
Thanks for reviewing it.
> The only concern: get_work_pool() may slow down __queue_work().
Yeap, I'm currently working on to optimize idr so that the fast path
basical
On Wed, Jan 16, 2013 at 05:42:32PM -0800, Tejun Heo wrote:
> Currently, on the backend side, there are two layers of abstraction.
> For each CPU and the special unbound wq-specific CPU, there's one
> global_cwq. gcwq in turn hosts two worker_pools - one for normal
> priori
pool->nr_running
accesses.
Signed-off-by: Tejun Heo
Cc: Joonsoo Kim
---
kernel/workqueue.c | 63 ++---
1 file changed, 22 insertions(+), 41 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 577de10..a49cc88 100644
---
On Thu, Jan 24, 2013 at 11:01:34AM +0100, Ingo Molnar wrote:
> Acked-by: Ingo Molnar
Ingo, if you don't objecdt, I'll take these through cgroup/for-3.9
branch with other cgroup changes. Pleaes holler if you object.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe
On Thu, Jan 24, 2013 at 02:30:22PM +0800, Li Zefan wrote:
> With this change, we're guaranteed that cgroup_path() won't see NULL
> cgrp->dentry, and thus we can remove the NULL check in it.
>
> (Well, it's not true, because dummptop.dentry is always NULL)
>
> Signed-off-by: Li Zefan
Appled 1-6
301 - 400 of 11403 matches
Mail list logo
