Re: make[2]: execvp: /bin/bash: Argument list too long

2013-03-19 Thread Fengguang Wu
On Tue, Mar 19, 2013 at 09:10:25AM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Mar 18, 2013 at 11:50:58PM -0700, Andrew Morton wrote: > > On Tue, 19 Mar 2013 14:31:40 +0800 kbuild test robot > > wrote: > > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next > > > maste

Re: make[2]: execvp: /bin/bash: Argument list too long

2013-03-19 Thread Fengguang Wu
> > Is there a way to print out what the argument list is? > > Good idea! I managed to catch the error command with > > strace -e trace=process -s 4096 -f -o argtoolong make -j1 --debug=j > V=1 ARCH=i386 modules And the output of strace -e trace=process -s 40960 -f -o argtoolon

warning: (LOCKDEP && ..) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL && ..) || ..)

2013-02-02 Thread Fengguang Wu
Hi James, FYI, there are new compile warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm head: ce0da597d603726ed22a4237fcf76ca52bd5a2b5 commit: dcf6a6c6e54007c8cfbe6076f2569f28ac0b2248 Kconfig.debug: add METAG to dependency lists date: 4 days a

Re: [flow_cache_new_hashrnd] WARNING: at kernel/smp.c:328 smp_call_function_single()

2013-02-11 Thread Fengguang Wu
On Mon, Feb 11, 2013 at 10:03:09AM +0100, Ingo Molnar wrote: > > * Fengguang Wu wrote: > > > Greetings, > > > > I got the below oops and the first bad commit is > > It's a one-time warning, not an actual crash, right? Yes, it is. Thanks, Fengguang -- T

Re: [cpufreq] WARNING: at kernel/lockdep.c:2739 lockdep_trace_alloc()

2013-02-11 Thread Fengguang Wu
On Mon, Feb 11, 2013 at 02:40:39PM +0530, Viresh Kumar wrote: > On 11 February 2013 14:22, Fengguang Wu wrote: > > Greetings, > > Hi Fengguang, > > > I got the below oops and the first bad commit is > > > > commit 50f6802f8dccb7bbad29010e57973d46b7e7a07

Re: WARNING: at lib/debugobjects.c:261 debug_print_object()

2013-02-11 Thread Fengguang Wu
On Mon, Feb 11, 2013 at 11:17:14AM +1100, Stephen Rothwell wrote: > Hi Fengguang, > > On Fri, 8 Feb 2013 13:56:05 +0800 Fengguang Wu wrote: > > > > I got the below oops and the first bad commit is > > > > commit 457583af4aef89d5252769ea290a2acc89e2361f >

Re: WARNING: at net/core/neighbour.c:1545 neigh_table_init()

2013-02-11 Thread Fengguang Wu
On Mon, Feb 11, 2013 at 10:26:00AM +0100, Ingo Molnar wrote: > > * Fengguang Wu wrote: > > > Greetings, > > > > I got the below oops in linux-next and the first bad commit is > > > > commit 455e987c0c2eb2c9045dc854559474cf41509965 > > Merg

Re: kernel/workqueue.c:4434:61: sparse: expression using sizeof bool

2013-04-03 Thread Fengguang Wu
CC Christopher and LKML. On Wed, Apr 03, 2013 at 02:57:18PM -0700, Tejun Heo wrote: > Hello, Fengguang. Hi Tejun! > On Sat, Mar 30, 2013 at 08:29:47PM +0800, kbuild test robot wrote: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git > > review-better-dbg > > head: ea44ca7573

[PATCH tip] perf/x86: nhm_events_attrs and snb_events_attrs can be static

2013-01-28 Thread Fengguang Wu
Signed-off-by: Fengguang Wu --- arch/x86/kernel/cpu/perf_event_intel.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next.orig/arch/x86/kernel/cpu/perf_event_intel.c 2013-01-29 07:42:16.238595053 +0800 +++ linux-next/arch/x86/kernel/cpu/perf_event_intel.c 2013

Re: [PATCH] Negative (setpoint-dirty) in bdi_position_ratio()

2013-01-24 Thread Fengguang Wu
On Wed, Jan 23, 2013 at 12:54:38AM +0100, Jan Kara wrote: > On Sun 20-01-13 11:02:10, paul.sz...@sydney.edu.au wrote: > > In bdi_position_ratio(), get difference (setpoint-dirty) right even when > > negative. Both setpoint and dirty are unsigned long, the difference was > > zero-padded thus wrongly

Re: [PATCH] Negative (setpoint-dirty) in bdi_position_ratio()

2013-01-24 Thread Fengguang Wu
Hi Paul, > (This patch does not solve the PAE OOM issue.) You may try the below debug patch. The only way the writeback patches should trigger OOM, I think, is for the number of dirty/writeback pages going out of control. Or more simple, you may show us the OOM dmesg which will contain the numbe

Re: [PATCH] Negative (setpoint-dirty) in bdi_position_ratio()

2013-01-24 Thread Fengguang Wu
On Fri, Jan 25, 2013 at 10:43:45AM +1100, paul.sz...@sydney.edu.au wrote: > Dear Fengguang, > > > Or more simple, you may show us the OOM dmesg which will contain the > > number of dirty pages. ... > > Do you mean kern.log lines like: Yes. > [ 744.754199] bash invoked oom-killer: gfp_mask=0xd0

[GIT PULL] writeback fixes for v3.9-rc1

2013-02-27 Thread Fengguang Wu
Hi Linus, Here are 2 writeback fixes. Please be prepared for a merge conflict in fs/btrfs/extent-tree.c as occured/resolved in linux-next's merge commit 6ae374247bfd8 ("Merge remote-tracking branch 'writeback/writeback-for-next'"). Thanks, Fengguang --- The following changes since commit 9931fa

Re: [PATCH V2] smp: Give WARN()ing when calling smp_call_function_many()/single() in serving irq

2013-02-19 Thread Fengguang Wu
On Tue, Feb 19, 2013 at 03:01:23PM -0800, Andrew Morton wrote: > On Mon, 18 Feb 2013 09:38:52 +0800 > Fengguang Wu wrote: > > > Chuansheng, > > > > It works fine on tip/next. Thanks for the fix! > > > > Tested-by: Fengguang Wu > > How did you

Re: WARNING: at kernel/mutex.c:386 __mutex_lock_common()

2013-02-19 Thread Fengguang Wu
> > [0.00] > > [0.00] [ cut here ] > > [0.00] WARNING: at /c/kernel-tests/src/tip/kernel/mutex.c:386 > > __mutex_lock_common+0x5a9/0x870() > > [0.00] Hardware name: Bochs > > [0.00] Modules linked in: > > [0.00] Pid: 0, comm:

Re: [idr/perf_init_event] BUG: unable to handle kernel NULL pointer dereference at (null)

2013-02-22 Thread Fengguang Wu
On Fri, Feb 22, 2013 at 05:35:54PM -0800, Tejun Heo wrote: > On Fri, Feb 22, 2013 at 05:34:48PM -0800, Tejun Heo wrote: > > Hello, > > > > On Sat, Feb 23, 2013 at 09:30:11AM +0800, Fengguang Wu wrote: > > > Greetings, > > > > > > I

Re: INFO: suspicious RCU usage in rcu_torture_writer()

2012-08-30 Thread Fengguang Wu
On Mon, Aug 27, 2012 at 11:17:51AM -0700, Paul E. McKenney wrote: > On Mon, Aug 27, 2012 at 12:40:52PM +0800, Fengguang Wu wrote: > > On Sat, Aug 25, 2012 at 05:01:49PM -0700, Paul E. McKenney wrote: > > > On Sat, Aug 25, 2012 at 11:36:23AM +0800, Fengguang Wu wrote:

[PATCH] i825xx: fix paging fault on znet_probe()

2012-09-02 Thread Fengguang Wu
;] znet_probe+0x2c/0x26b [3.747493] [<816a134a>] ? dnet_driver_init+0xf/0xf [3.747493] [<816819b5>] do_one_initcall+0x6a/0x110 [3.747493] [<81681b29>] kernel_init+0xce/0x14b

input0: bad kobj_uevent_env content in show_uevent()

2012-09-02 Thread Fengguang Wu
Hi all, After the __devinit* removal series, I can still get kernel panic in show_uevent(). So there are more sources of bug.. Debug patch: @@ -343,8 +343,11 @@ static ssize_t show_uevent(struct device goto out; /* copy keys to file */ - for (i = 0; i < env->envp_i

Re: input0: bad kobj_uevent_env content in show_uevent()

2012-09-02 Thread Fengguang Wu
+0x2b/0x90 [ 32.486234] [] ? sysfs_read_file+0x18a/0x320 [ 32.486234] [] ? __get_free_pages+0x24/0xc0 [ 32.486234] [] sysfs_read_file+0x1cd/0x320 Thanks, Fengguang On Sun, Sep 02, 2012 at 03:59:46PM +0800, Fengguang Wu wrote: > Hi all, > > After the __devinit* removal series, I

Re: input0: bad kobj_uevent_env content in show_uevent()

2012-09-02 Thread Fengguang Wu
On Sun, Sep 02, 2012 at 04:34:02PM +0800, Fengguang Wu wrote: > It's more than the input device that can trigger the panic. > Here is another trace which panics on accessing dmi/id/uevent: > > [ 32.380795] sysfs_read_file: /sys/devices/virtual/dmi/id/uevent > [ 32.39937

Re: input0: bad kobj_uevent_env content in show_uevent()

2012-09-02 Thread Fengguang Wu
On Sun, Sep 02, 2012 at 03:41:34PM +0200, Bjørn Mork wrote: > Fengguang Wu writes: > > > After the __devinit* removal series, I can still get kernel panic in > > show_uevent(). So there are more sources of bug.. > > > > Debug patch: > > > > @@ -343,8 +3

Re: input0: bad kobj_uevent_env content in show_uevent()

2012-09-04 Thread Fengguang Wu
On Tue, Sep 04, 2012 at 01:46:04PM +0200, Jean Delvare wrote: > On Sun, 2 Sep 2012 16:34:02 +0800, Fengguang Wu wrote: > > It's more than the input device that can trigger the panic. > > Here is another trace which panics on accessing dmi/id/uevent: > > > > [

Re: [PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes

2012-09-10 Thread Fengguang Wu
d are those before *work->older_than_this. Correct > > the comment here. > Fengguang Wu would be a more appropriate for this. Added to CC. BTW the > patch is fine so feel free to add: > > Reviewed-by: Jan Kara Applied. Thank you! Fengguang -- To unsubscribe from this list: send th

Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg

2012-09-10 Thread Fengguang Wu
bzip, but I expect those > to be much faster too. > > I'm not willing to wait that long for a small compression > gain. So just change the script to use the defaults. Makes sense to me. Reviewed-by: Fengguang Wu > Signed-off-by: Andi Kleen > --- > scripts/packa

Re: [PATCH 1/2] writeback: add dirty_background_time per bdi variable

2012-09-10 Thread Fengguang Wu
Hi Namjae, On Mon, Aug 27, 2012 at 12:01:14PM -0400, Namjae Jeon wrote: > From: Namjae Jeon > > This patch is based on suggestion by Wu Fengguang: > https://lkml.org/lkml/2011/8/19/19 > > kernel has mechanism to do writeback as per dirty_ratio and dirty_background > ratio. It also maintains per

Re: [PATCH 2/2] Documentation: add description of dirty_background_time

2012-09-10 Thread Fengguang Wu
On Mon, Aug 27, 2012 at 12:01:41PM -0400, Namjae Jeon wrote: > From: Namjae Jeon > > This commit adds dirty_background_time description in bdi sysfs > documentation. > > Signed-off-by: Namjae Jeon > Signed-off-by: Vivek Trivedi > --- > Documentation/ABI/testing/sysfs-class-bdi | 13

Re: [PATCH] Kbuild: use normal compression settings for tar*-pkg

2012-09-10 Thread Fengguang Wu
On Tue, Sep 11, 2012 at 05:01:09AM +0200, Andi Kleen wrote: > > > > -c should be kept because it means --stdout and --keep > > It seems to work without it. Yeah I see: it's used in the pipe anyway: tar cf - . $opts | ${compress} > "${tarball}${file_ext}" Thanks, Fengguang -- To unsubs

Re: [PATCH 1/2] writeback: add dirty_background_time per bdi variable

2012-09-11 Thread Fengguang Wu
On Wed, Sep 12, 2012 at 08:12:40AM +0900, Namjae Jeon wrote: > >> > >> To be frank, no realistic NFS servers will use USB disk as backing > >> storage. So that rational for reducing "initial" delays is weak. > >> Continuous write performance to HDD is much more important. Do you > >> have numbers f

Re: BUG: soft lockup - CPU#1 stuck for 1024s!

2012-09-11 Thread Fengguang Wu
On Mon, Sep 10, 2012 at 10:06:33AM -0700, John Stultz wrote: > On 09/09/2012 12:59 AM, Fengguang Wu wrote: > >Hi John, > > > >The below lockup warning pops up very occasionally in kvm guest > >kernels and it's bisected down to > > > > com

Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()

2012-09-11 Thread Fengguang Wu
On Wed, Sep 12, 2012 at 03:28:42AM +0900, OGAWA Hirofumi wrote: > > If bdi has BDI_CAP_NO_WRITEBACK, bdi_forker_thread() doesn't start > writeback thread. This means there is no consumer of work item made > by bdi_queue_work(). > > This adds to checking of !bdi_cap_writeback_dirty(sb->s_bdi) befo

[3.5.0 BUG] vmx_handle_exit: unexpected, valid vectoring info (0x80000b0e)

2012-09-11 Thread Fengguang Wu
Hi, 3 of my test boxes running v3.5 kernel become unaccessible and I find two of them kept emitting this dmesg: vmx_handle_exit: unexpected, valid vectoring info (0x8b0e) and exit reason is 0x31 The other one has froze and the above lines are the last dmesg. Any ideas? Thanks, Fengguang --

Re: [PATCH 1/2] writeback: add dirty_background_time per bdi variable

2012-09-11 Thread Fengguang Wu
> I will update simple table for this result in changelog in patch. That would be good, thanks a lot for the testing! Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://v

Re: [3.5.0 BUG] vmx_handle_exit: unexpected, valid vectoring info (0x80000b0e)

2012-09-12 Thread Fengguang Wu
On Wed, Sep 12, 2012 at 11:15:40AM +0300, Avi Kivity wrote: > On 09/12/2012 07:40 AM, Fengguang Wu wrote: > > Hi, > > > > 3 of my test boxes running v3.5 kernel become unaccessible and I find > > two of them kept emitting this dmesg: > > > > vmx_handle

Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()

2012-09-12 Thread Fengguang Wu
On Wed, Sep 12, 2012 at 05:00:48PM +0900, OGAWA Hirofumi wrote: > Fengguang Wu writes: > > > On Wed, Sep 12, 2012 at 03:28:42AM +0900, OGAWA Hirofumi wrote: > >> > >> If bdi has BDI_CAP_NO_WRITEBACK, bdi_forker_thread() doesn't start > >> writebac

Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()

2012-09-12 Thread Fengguang Wu
On Thu, Sep 13, 2012 at 02:41:31PM +0900, OGAWA Hirofumi wrote: > Fengguang Wu writes: > > >> If used custom bdi with BDI_CAP_NO_WRITEBACK, wait_for_completion() > >> (e.g. sync_inodes_sb()) will be blocked forever. > > > > The sync(2) block cannot be fixed

Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()

2012-09-12 Thread Fengguang Wu
On Wed, Sep 12, 2012 at 03:28:42AM +0900, OGAWA Hirofumi wrote: > > If bdi has BDI_CAP_NO_WRITEBACK, bdi_forker_thread() doesn't start > writeback thread. This means there is no consumer of work item made > by bdi_queue_work(). > > This adds to checking of !bdi_cap_writeback_dirty(sb->s_bdi) befo

Re: xt_nat_init: BUG: unable to handle kernel NULL pointer dereference at 00000000000000e0

2012-09-13 Thread Fengguang Wu
> Wasnt it already solved ? > > http://1984.lsi.us.es/git/nf-next/commit/?id=00545bec9412d130c77f72a08d6c8b6ad21d4a1 > > Just have to wait that netfilter fixes are pushed upstream OK, sorry. I didn't subscribe many mailing lists and rely on the search results in google and LKML to avoid duplicat

Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()

2012-09-14 Thread Fengguang Wu
> >> @@ -120,6 +120,9 @@ __bdi_start_writeback(struct backing_dev > >> { > >>struct wb_writeback_work *work; > >> > >> + if (!bdi_cap_writeback_dirty(bdi)) > >> + return; > > > > Will someone in the current kernel actually call > > __bdi_start_writeback() on a BDI_CAP_NO_WRITEBACK

Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()

2012-09-14 Thread Fengguang Wu
On Fri, Sep 14, 2012 at 08:13:05PM +0900, OGAWA Hirofumi wrote: > OGAWA Hirofumi writes: > > > Fengguang Wu writes: > > > >> On Wed, Sep 12, 2012 at 03:28:42AM +0900, OGAWA Hirofumi wrote: > >>> > >>> If bdi has BDI_CAP_NO_WRITEBACK, bdi_f

Re: WARNING: at kernel/rcutree.c:1558 rcu_do_batch+0x386/0x3a0(), during CPU hotplug

2012-09-14 Thread Fengguang Wu
On Thu, Sep 13, 2012 at 02:05:17PM +0530, Srivatsa S. Bhat wrote: > On 09/12/2012 06:06 PM, Srivatsa S. Bhat wrote: > > On 07/19/2012 10:45 PM, Paul E. McKenney wrote: > >> On Thu, Jul 19, 2012 at 05:39:30PM +0530, Srivatsa S. Bhat wrote: > >>> Hi Paul, > >>> > >>> While running a CPU hotplug stres

Re: WARNING: at kernel/rcutree.c:1558 rcu_do_batch+0x386/0x3a0(), during CPU hotplug

2012-09-14 Thread Fengguang Wu
On Fri, Sep 14, 2012 at 05:48:20PM +0530, Srivatsa S. Bhat wrote: > On 09/14/2012 05:17 PM, Fengguang Wu wrote: > > On Thu, Sep 13, 2012 at 02:05:17PM +0530, Srivatsa S. Bhat wrote: > >> On 09/12/2012 06:06 PM, Srivatsa S. Bhat wrote: > >>> On 07/19/2012 10:45 PM, Pau

Re: WARNING: at kernel/rcutree.c:1558 rcu_do_batch+0x386/0x3a0(), during CPU hotplug

2012-09-14 Thread Fengguang Wu
On Fri, Sep 14, 2012 at 02:25:19PM +0200, Peter Zijlstra wrote: > On Fri, 2012-09-14 at 17:48 +0530, Srivatsa S. Bhat wrote: > > #! /bin/bash > > CPUPATH="/sys/devices/system/cpu" > > > NUMBER_OF_CPUS=`ls -d /sys/devices/system/cpu/cpu[0-9]* | wc -l` > > apply the above > > > cd /sys/devices/sy

Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()

2012-09-14 Thread Fengguang Wu
On Fri, Sep 14, 2012 at 09:12:02PM +0900, OGAWA Hirofumi wrote: > Fengguang Wu writes: > > >> >> @@ -120,6 +120,9 @@ __bdi_start_writeback(struct backing_dev > >> >> { > >> >> struct wb_writeback_work *work; > &g

Re: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()

2012-09-14 Thread Fengguang Wu
On Fri, Sep 14, 2012 at 10:07:48PM +0900, OGAWA Hirofumi wrote: > Fengguang Wu writes: > > >> The writeback task is always called with sync_mode != WB_SYNC_ALL except > >> sync_inodes_sb(). But FS has sb->s_op->sync_fs() handler for > >> sync_inodes_sb() p

[PATCH] clear PAGECACHE_TAG_DIRTY for truncated pages

2008-02-01 Thread Fengguang Wu
for 1 hour, during which the pdflush will retry the page _at least_ once every 5s. So clear PAGECACHE_TAG_DIRTY to prevent pdflush from retrying on it. Tested-by: Joerg Platte <[EMAIL PROTECTED]> Cc: Peter Zijlstra <[EMAIL PROTECTED]> Cc: Michael Rubin <[EMAIL PROTECTED]> Si

[PATCH] writeback: __sync_single_inode() trivial cleanup

2008-02-02 Thread Fengguang Wu
Make the if-else straight in __sync_single_inode(). No behavior change. Cc: Michael Rubin <[EMAIL PROTECTED]> Cc: Peter Zijlstra <[EMAIL PROTECTED]> Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- fs/fs-writeback.c | 15 +++ 1 files changed, 7 insertio

Re: [CPU hotplug, cpuidle_disable_device] BUG: unable to handle kernel NULL pointer dereference at (null)

2012-10-23 Thread Fengguang Wu
On Tue, Oct 23, 2012 at 03:09:46PM +0200, Daniel Lezcano wrote: > On 10/23/2012 02:48 PM, Fengguang Wu wrote: > > Hi Fengguang, > > I believe this bug has been fixed by https://lkml.org/lkml/2012/10/8/87 Yeah, I just confirmed that linux-next works fine. Thanks, Fengguang --

Re: [PATCH] UAPI: Fix tools/vm/page-types.c

2012-10-23 Thread Fengguang Wu
42: fatal error: > uapi/linux/kernel-page-flags.h: No such file or directory > > Reported-by: Daniel Hazelton > Signed-off-by: David Howells > cc: Fengguang Wu Looks like the right solution. Reviewed-by: Fengguang Wu > --- > > tools/vm/page-types.c |2

Re: [PATCH -next] printk: fix broken 'console' kernel parameter

2012-10-23 Thread Fengguang Wu
On Tue, Oct 23, 2012 at 09:41:18PM +0800, Ming Lei wrote: > If CONFIG_A11Y_BRAILLE_CONSOLE is not enabled, _braille_console_setup() > should return NULL to parse the parameter further in console_setup(). > > This patch fixes the broken 'console' kernel parameter, which makes the > Pandaboard not b

Re: [next:akpm 155/157] drivers/char/random.c:827:3: warning: format '%zd' expects argument of type 'signed size_t', but argument 7 has type 'size_t'

2012-10-23 Thread Fengguang Wu
[add CC to mn10300/cris arch lists] On Wed, Oct 24, 2012 at 08:56:12AM +0800, Fengguang Wu wrote: > On Tue, Oct 23, 2012 at 02:53:58PM -0700, Andrew Morton wrote: > > On Tue, 23 Oct 2012 18:16:58 +0800 > > Fengguang Wu wrote: > > > > > Hi Jiri, > > > &g

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Fengguang Wu
Hi YingHang, > Actually I've talked about it with Fengguang, he advised we should unify the > ra_pages in struct bdi and file_ra_state and leave the issue that > spreading data > across disks as it is. > Fengguang, what's you opinion about this? Yeah the two ra_pages may run out of sync for alrea

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Fengguang Wu
Hi Chen, > But how can bdi related ra_pages reflect different files' readahead > window? Maybe these different files are sequential read, random read > and so on. It's simple: sequential reads will get ra_pages readahead size while random reads will not get readahead at all. Talking about the be

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 11:25:44AM +1100, Dave Chinner wrote: > On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: > > Hi Chen, > > > > > But how can bdi related ra_pages reflect different files' readahead > > > window? Maybe these different

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 11:38:11AM +0800, YingHang Zhu wrote: > On Fri, Oct 26, 2012 at 8:25 AM, Dave Chinner wrote: > > On Thu, Oct 25, 2012 at 10:58:26AM +0800, Fengguang Wu wrote: > >> Hi Chen, > >> > >> > But how can bdi related ra_pages reflect differen

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Fengguang Wu
> static void shrink_readahead_size_eio(struct file *filp, > struct file_ra_state *ra) > { > - ra->ra_pages /= 4; > + spin_lock(&filp->f_lock); > + filp->f_mode |= FMODE_RANDOM; > + spin_unlock(&filp->f_lock); > > As the example in

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: > On 10/26/2012 02:58 PM, Fengguang Wu wrote: > >> static void shrink_readahead_size_eio(struct file *filp, > >> struct file_ra_state *ra) > >> {

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: > On 10/26/2012 03:09 PM, Fengguang Wu wrote: > >On Fri, Oct 26, 2012 at 03:03:12PM +0800, Ni zhan Chen wrote: > >>On 10/26/2012 02:58 PM, Fengguang Wu wrote: > >>>> static void shrink_rea

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-26 Thread Fengguang Wu
On Fri, Oct 26, 2012 at 03:47:19PM +0800, Ni zhan Chen wrote: > On 10/26/2012 03:36 PM, Fengguang Wu wrote: > >On Fri, Oct 26, 2012 at 03:19:57PM +0800, Ni zhan Chen wrote: > >>On 10/26/2012 03:09 PM, Fengguang Wu wrote: > >>>On Fri, Oct 26, 2012 at 03:03:12PM +0800

Re: [PATCH] thermal: solve compilation errors in rcar_thermal

2012-10-31 Thread Fengguang Wu
On Tue, Oct 30, 2012 at 08:21:09PM -0700, Kuninori Morimoto wrote: > > Hi Zhang, Andrew > > This patch is needed on latest linus/master branch. > Please re-check this patch. Rui, it'd be better to send Andrew a finalized patch with your Acked-by or Signed-off-by (because you passed it on), after

[PATCH] vfio: simplify kmalloc+copy_from_user to memdup_user

2012-11-01 Thread Fengguang Wu
Generated by: coccinelle/api/memdup_user.cocci Acked-by: Julia Lawall Reported-by: Fengguang Wu --- drivers/vfio/pci/vfio_pci.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) --- linux.orig/drivers/vfio/pci/vfio_pci.c 2012-10-23 18:21:57.118168335 +0800 +++ linux

[PATCH] h8300: add missing L1_CACHE_SHIFT

2012-11-03 Thread Fengguang Wu
To fix build error lib/atomic64.c: In function 'lock_addr': lib/atomic64.c:40:11: error: 'L1_CACHE_SHIFT' undeclared (first use in this function) lib/atomic64.c:40:11: note: each undeclared identifier is reported only once for each function it appears in Signed-off-by: Fen

Re: [floppy, blk_peek_request] BUG: scheduling while atomic: kworker/u:0/6/0x10000002

2012-11-05 Thread Fengguang Wu
On Mon, Nov 05, 2012 at 02:24:15PM +0100, Jiri Kosina wrote: > On Mon, 5 Nov 2012, Fengguang Wu wrote: > > > Hi Herton, > > > > I got the below oops in Linux 3.7-rc4 and it's bisected down to > > > > commit b54e1f88897bcacc2cd359f48ea3b39eaf55f084 > &

[PATCH] xtensa: select generic atomic64_t support

2012-07-27 Thread Fengguang Wu
This will fix build errors: block/blk-cgroup.c:609:2: error: unknown type name 'atomic64_t' block/blk-cgroup.c:609:2: error: implicit declaration of function 'ATOMIC64_INIT' [-Werror=implicit-function-declaration] Signed-off-by: Fengguang Wu --- arch/xtensa/Kconfig |1

[PATCH] floppy: remove duplicated flag FD_RAW_NEED_DISK

2012-07-28 Thread Fengguang Wu
Fix coccinelle warning (without behavior change): drivers/block/floppy.c:2518:32-48: duplicated argument to & or | Signed-off-by: Fengguang Wu --- diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 553f43a..0fcbe14 100644 --- a/drivers/block/floppy.c +++ b/drivers/b

drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests

2012-07-28 Thread Fengguang Wu
Open Source Technology Centre Fengguang Wu Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] pch_uart: check kzalloc result in dma_handle_tx()

2012-07-28 Thread Fengguang Wu
Reported by coccinelle: drivers/tty/serial/pch_uart.c:979:1-14: alloc with no test, possible model on line 994 Signed-off-by: Fengguang Wu --- drivers/tty/serial/pch_uart.c |4 1 file changed, 4 insertions(+) WARNING: this may be a superficial fix! --- linux.orig/drivers/tty/serial

[PATCH] netfilter: PTR_RET can be used

2012-07-28 Thread Fengguang Wu
-3: WARNING: PTR_RET can be used net/ipv4/netfilter/iptable_raw.c:51:1-3: WARNING: PTR_RET can be used net/ipv4/netfilter/iptable_security.c:70:1-3: WARNING: PTR_RET can be used Signed-off-by: Fengguang Wu --- net/bridge/netfilter/ebtable_filter.c |4 +--- net/bridge/netfilter/ebtable_nat.c

[PATCH] es1688 - freeup resources on init failure

2012-07-29 Thread Fengguang Wu
gusmax_init+0xf/0xf [6.194607] [] ? do_one_initcall+0x7f/0x12b [6.194607] [] ? kernel_init+0x112/0x1a9 [6.194607] [] ? do_early_param+0x77/0x77 [6.194607] [] ? do_one_initcall+0x12b/0x12b [6.194607] [] ? kernel_thread_helper+0x6/0xd [6.210779] es1688: can't grab

Re: [PATCH] netfilter: PTR_RET can be used

2012-07-29 Thread Fengguang Wu
> > --- linux.orig/net/bridge/netfilter/ebtable_filter.c2012-07-29 > > 08:41:09.703759534 +0800 > > +++ linux/net/bridge/netfilter/ebtable_filter.c 2012-07-29 > > 08:41:14.255759643 +0800 > > @@ -100,9 +100,7 @@ static struct nf_hook_ops ebt_ops_filter > > static int __net_init frame

Re: appletalk/cops_probe BUG: soft lockup - CPU#1 stuck for 23s!

2012-07-29 Thread Fengguang Wu
On Sun, Jul 29, 2012 at 02:00:03PM +0100, Alan Cox wrote: > On Sun, 29 Jul 2012 20:40:22 +0800 > Fengguang Wu wrote: > > > Hi, > > > > This is probably a rather old bug, triggered while doing randconfig > > boot tests in kvm: > > I'm not sure test

[GIT PULL] writeback updates for 3.6

2012-07-30 Thread Fengguang Wu
Hi Linus, The following changes since commit f8f5701bdaf9134b1f90e5044a82c66324d2073f: Linux 3.5-rc1 (2012-06-02 18:29:26 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux.git tags/writeback-proportions for you to fetch changes up to 33

Re: [vfs:fsfreeze] umount BUG: sleeping function called from invalid context

2012-07-31 Thread Fengguang Wu
On Tue, Jul 31, 2012 at 09:58:15AM +0100, Al Viro wrote: > On Tue, Jul 31, 2012 at 04:38:39PM +0800, Fengguang Wu wrote: > > Hi Jan, > > > > Here is another warning for the fs freeze series. > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/g

Re: [vfs:fsfreeze] umount BUG: sleeping function called from invalid context

2012-07-31 Thread Fengguang Wu
On Tue, Jul 31, 2012 at 05:13:26PM +0800, Fengguang Wu wrote: > On Tue, Jul 31, 2012 at 09:58:15AM +0100, Al Viro wrote: > > On Tue, Jul 31, 2012 at 04:38:39PM +0800, Fengguang Wu wrote: > > > Hi Jan, > > > > > > Here is another warning for the fs fre

Re: __update_max_tr: rcu_read_lock() used illegally while idle!

2012-07-31 Thread Fengguang Wu
On Mon, Jul 30, 2012 at 11:39:12AM -0400, Steven Rostedt wrote: > On Tue, 2012-07-24 at 17:03 +0800, Fengguang Wu wrote: > > Hi Steven, > > Hi Fengguang, > > Just an FYI, It's best to send email to my rost...@goodmis.org account. > I don't check my redhat

Re: Testing tracer wakeup_rt: .. no entries found ..FAILED!

2012-07-31 Thread Fengguang Wu
[CC kvm developers] On Mon, Jul 30, 2012 at 11:45:05AM -0400, Steven Rostedt wrote: > On Tue, 2012-07-24 at 17:07 +0800, Fengguang Wu wrote: > > On Tue, Jul 24, 2012 at 05:03:30PM +0800, Fengguang Wu wrote: > > > And this warning shows up in one of the dozens of boots, for th

Re: NULL pointer dereference in iio_buffer_register()

2012-07-31 Thread Fengguang Wu
> > The panic happens while trying to dereference the NULL indio_dev->buffer: > > > > 266 int iio_buffer_register(struct iio_dev *indio_dev, > > 267 const struct iio_chan_spec *channels, > > 268 int num_channels) > > 2

Re: NULL pointer dereference in iio_buffer_register()

2012-07-31 Thread Fengguang Wu
On Tue, Jul 31, 2012 at 03:06:11PM +0200, Lars-Peter Clausen wrote: > On 07/31/2012 02:55 PM, Fengguang Wu wrote: > >>> The panic happens while trying to dereference the NULL indio_dev->buffer: > >>> > >>> 266 int iio_buffer_register(st

Re: [ACPI/PCI] possible recursive locking detected

2012-09-22 Thread Fengguang Wu
On Sat, Sep 22, 2012 at 12:04:51AM -0700, Yinghai Lu wrote: > On Fri, Sep 21, 2012 at 9:53 PM, Yinghai Lu wrote: > > On Fri, Sep 21, 2012 at 5:35 PM, Fengguang Wu > > wrote: > >> Hi Taku, > >> > >> The below oops is pretty reproducible, an

Re: Linux 3.6-rc6

2012-09-22 Thread Fengguang Wu
On Sat, Sep 22, 2012 at 11:57:23AM -0700, Linus Torvalds wrote: > On Fri, Sep 21, 2012 at 5:59 PM, Shaun Ruffell wrote: > > > > I posted patches [1,2,3] that resolve the issue for me. Shaohui Xie > > also hit the issue and posted a slightly different patch [4]. The > > patches are currently waitin

[PATCH] edac_mc: fix messy kfree calls in the error path

2012-09-22 Thread Fengguang Wu
gy code was introduced by commit de3910eb ("edac: change the mem allocation scheme to make Documentation/kobject.txt happy") in the 3.6-rc1 merge window. Fix it by freeing up resources in this order: free csrows[i]->channels[j] free csrows[i]->channels free csrows[i] fr

Re: divide error: bdi_dirty_limit+0x5a/0x9e

2012-09-24 Thread Fengguang Wu
On Mon, Sep 24, 2012 at 04:43:11PM +0530, Srivatsa S. Bhat wrote: > On 09/24/2012 04:35 PM, Borislav Petkov wrote: > > On Mon, Sep 24, 2012 at 04:08:33PM +0530, Srivatsa S. Bhat wrote: > >> On 09/24/2012 03:53 PM, Borislav Petkov wrote: > >>> Hi all, > >>> > >>> we're able to trigger the oops below

Re: divide error: bdi_dirty_limit+0x5a/0x9e

2012-09-24 Thread Fengguang Wu
On Mon, Sep 24, 2012 at 02:20:53PM +0200, Borislav Petkov wrote: > On Mon, Sep 24, 2012 at 07:34:47PM +0800, Fengguang Wu wrote: > > Will you test such a line? At least the generic do_div() only uses the > > lower 32bits for division. > > > > WARN_ON(!(den &a

Re: [PATCH] pagemap: fix wrong KPF_THP on slab pages

2012-09-25 Thread Fengguang Wu
On Tue, Sep 25, 2012 at 10:06:08PM -0400, Naoya Horiguchi wrote: > On Tue, Sep 25, 2012 at 05:20:48PM -0700, David Rientjes wrote: > > On Tue, 25 Sep 2012, Naoya Horiguchi wrote: > > > > > KPF_THP can be set on non-huge compound pages like slab pages, because > > > PageTransCompound only sees PG_h

Re: [PATCH] pagemap: fix wrong KPF_THP on slab pages

2012-09-26 Thread Fengguang Wu
On Wed, Sep 26, 2012 at 02:06:08AM -0400, Naoya Horiguchi wrote: > On Wed, Sep 26, 2012 at 12:02:34AM -0400, Naoya Horiguchi wrote: > ... > > > > +* page is a thp, not a non-huge compound page. > > > > +*/ > > > > + else if (PageTransCompound(page) && !PageSlab(page)) > > > >

Re: [PATCH 3/3] fs/fs-writeback.c: remove unneccesary parameter of __writeback_single_inode()

2012-09-26 Thread Fengguang Wu
On Wed, Sep 26, 2012 at 07:38:30PM +0800, Yan Hong wrote: > The parameter 'wb' is never used in this function. Good spot! Acked-by: Fengguang Wu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-26 Thread Fengguang Wu
On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: > On Thu 20-09-12 16:44:22, Wu Fengguang wrote: > > On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: > > > From: Namjae Jeon > > > > > > This patch is based on suggestion by Wu Fengguang: > > > https://lkml.org/lkml/2011/8/19/1

Re: [ 16/85] use clamp_t in UNAME26 fix

2012-10-27 Thread Fengguang Wu
On Sat, Oct 27, 2012 at 05:11:58PM +0100, Ben Hutchings wrote: > On Thu, 2012-10-25 at 17:05 -0700, Greg Kroah-Hartman wrote: > > 3.6-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Kees Cook > > > > commit 31fd84b95eb211d5db460a1

[PATCH] netfilter: use PTR_RET

2012-10-28 Thread Fengguang Wu
Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR Generated by: coccinelle/api/ptr_ret.cocci Reported-by: Fengguang Wu --- net/ipv4/netfilter/iptable_nat.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- linux-next.orig/net/ipv4/netfilter/iptable_nat.c2012-10-23 09:44

[PATCH] netfilter: ipv6: use PTR_RET

2012-10-28 Thread Fengguang Wu
Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR Generated by: coccinelle/api/ptr_ret.cocci Signed-off-by: Fengguang Wu --- net/ipv6/netfilter/ip6table_nat.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- linux-next.orig/net/ipv6/netfilter/ip6table_nat.c 2012-10-23 09:44

Re: [PATCH] netfilter: use PTR_RET

2012-10-29 Thread Fengguang Wu
On Mon, Oct 29, 2012 at 10:03:47AM +0100, Pablo Neira Ayuso wrote: > On Mon, Oct 29, 2012 at 08:40:44AM +0800, Fengguang Wu wrote: > > Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR > > > > Generated by: coccinelle/api/ptr_ret.cocci > > Applied, thanks. > >

Re: [PATCH 1/2] gpio: move those interface depends on GPIOLIB into proper section

2012-10-31 Thread Fengguang Wu
On Wed, Oct 31, 2012 at 03:00:54PM +0800, Yuanhan Liu wrote: > There are 2 issues with current code: > > 1. redefinition of 'gpio_cansleep': > include/linux/gpio.h:60:19: error: redefinition of 'gpio_cansleep' > include/asm-generic/gpio.h:212:19: note: previous definition of > 'gpio_cansleep' was

Re: [tps_init] BUG: unable to handle kernel paging request at 484970c9

2013-08-24 Thread Fengguang Wu
On Sat, Aug 24, 2013 at 09:09:39PM -0700, Greg KH wrote: > On Sun, Aug 25, 2013 at 08:04:21AM +0800, Fengguang Wu wrote: > > Greetings, > > > > It seems the below patch discloses a bug in tps_init(). > > > > commit c817a67ecba7c3c2aaa104796d78f160af60920d &

[PATCH] serial: sccnxp: replace memcpy with struct assignment

2013-10-01 Thread Fengguang Wu
Generated by: coccinelle/misc/memcpy-assign.cocci CC: Alexander Shiyan Signed-off-by: Fengguang Wu --- drivers/tty/serial/sccnxp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/drivers/tty/serial/sccnxp.c 2013-10-01 19:27:55.057537955 +0800 +++ linux-next

Re: linux-next: Tree for Sep 25

2013-10-03 Thread Fengguang Wu
On Wed, Sep 25, 2013 at 05:47:28PM -0700, Joe Perches wrote: > On Wed, 2013-09-25 at 14:43 +1000, Stephen Rothwell wrote: > > Hi all, > > > > Heads up: I will be having a 3 week break leading up to the kernel > > summit. This means that next-20130927 (next Friday) will be the last > > linux-next

Re: [PATCH] serial: sccnxp: replace memcpy with struct assignment

2013-10-03 Thread Fengguang Wu
On Thu, Oct 03, 2013 at 04:09:21PM -0700, Greg KH wrote: > On Tue, Oct 01, 2013 at 07:31:15PM +0800, Fengguang Wu wrote: > > Generated by: coccinelle/misc/memcpy-assign.cocci > > > > CC: Alexander Shiyan > > Signed-off-by: Fengguang Wu > > --- > >

Re: [GIT PULL] x86/asmlinkage changes for v3.12

2013-10-04 Thread Fengguang Wu
On Wed, Sep 04, 2013 at 09:45:29AM -0700, H. Peter Anvin wrote: [snip] > This also exposes an interesting problem with Fengguang's build robot. > > One build: > [tip:x86/asmlinkage] 28596b6a8779b736829ad837f95fdc2e81bdd1ee BUILD DONE > 28596b6a8779b736829ad837f95fdc2e81bdd1ee x86, asmlinkage, vds

Re: [x86] BUG: unable to handle kernel paging request at 08000060

2013-10-06 Thread Fengguang Wu
Hi Mike, On Sun, Oct 06, 2013 at 09:27:41AM +0200, Mike Galbraith wrote: > On Sun, 2013-10-06 at 07:47 +0800, Fengguang Wu wrote: > > Hi Peter, > > > > Here is another bisect on a different kconfig. > > No explosions here, it gives my compiler a terminal tummy ach

Re: [xen] double fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC

2013-10-06 Thread Fengguang Wu
On Sun, Oct 06, 2013 at 10:26:24AM -0700, Linus Torvalds wrote: > On Sun, Oct 6, 2013 at 1:23 AM, Fengguang Wu wrote: > > > > I got the below dmesg and the first bad commit is commit cf39c8e5352b: > > Merge tag 'stable/for-linus-3.12-rc0-tag' of > > git:

Re: [xen] double fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC

2013-10-06 Thread Fengguang Wu
On Mon, Oct 07, 2013 at 10:11:18AM +0800, Fengguang Wu wrote: > On Sun, Oct 06, 2013 at 10:26:24AM -0700, Linus Torvalds wrote: > > On Sun, Oct 6, 2013 at 1:23 AM, Fengguang Wu wrote: > > > > > > I got the below dmesg and the first bad commit is commit cf39c8e5352b:

  1   2   3   4   5   6   7   8   9   10   >