this a thought and get back.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Vincent,
I have addressed your comments and below is the fresh patch. This patch
applies on PATCH 2/3 posted in this thread.
Regards
Preeti U Murthy
sched:Remove un-necessary iterations over sched domains to update/query
nr_busy_cpus
From: Preeti U Murthy pre...@linux.vnet.ibm.com
this just at the SIBLINGS level? Having the hyper
threads busy due to the scenario described in the changelog is bad for
performance.
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
linuxppc-...@lists.ozlabs.org
https://lists.ozlabs.org/listinfo
are
called with preemption disabled.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Xiao Guangrong xiaoguangr...@cn.fujitsu.com
Cc: srivatsa.b...@linux.vnet.ibm.com
Cc: Paul E. McKenney paul...@linux.vnet.ibm.com
Cc
unlocking it.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Xiao Guangrong xiaoguangr...@cn.fujitsu.com
Cc: srivatsa.b...@linux.vnet.ibm.com
Cc: Paul E. McKenney paul...@linux.vnet.ibm.com
Cc: Steven Rostedt rost
This patchset removes possible stale code overlooked by previous
cleanups. It also clarifies ambiguous comments about deadlock scenarios
while calling smp_call_function variants, as they were not obvious at a first
glance.
---
Preeti U Murthy (3):
smp/ipi: Remove redundant cfd-cpumask_ipi
Elaborate on when deadlocks can occur when a call is made to
smp_call_function_single() and its friends. This avoids ambiguity about
when to use these calls.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Xiao
Hi Wang,
On 07/06/2013 08:43 AM, Wang YanQing wrote:
On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote:
cfd-cpumask_ipi is used only in smp_call_function_many().The existing
comment around it says that this additional mask is used because
cfd-cpumask can get overwritten
Hi Wang,
On 07/06/2013 11:42 AM, Wang YanQing wrote:
On Fri, Jul 05, 2013 at 09:57:11PM +0530, Preeti U Murthy wrote:
Elaborate on when deadlocks can occur when a call is made to
smp_call_function_single() and its friends. This avoids ambiguity about
when to use these calls.
+ * 2. wait
On 07/06/2013 11:15 AM, Wang YanQing wrote:
On Fri, Jul 05, 2013 at 09:57:21PM +0530, Preeti U Murthy wrote:
call_single_data is always locked by all callers of
arch_send_call_function_single_ipi() or
arch_send_call_function_ipi_mask() which results in execution
Hi Wang,
On 07/06/2013 07:51 PM, Wang YanQing wrote:
On Sat, Jul 06, 2013 at 01:36:27PM +0530, Preeti U Murthy wrote:
Ideally it should be under a WARN_ON(). csd_unlock() has that WARN_ON().
Unlocking a parameter which is not locked should be seen as a bug, which
the above code is not doing
Thanks for the pointer Thomas :)
Regards
Preeti U murthy
On 07/07/2013 01:18 AM, Thomas Gleixner wrote:
On Sat, 6 Jul 2013, Preeti U Murthy wrote:
Hi Wang,
On 07/06/2013 11:42 AM, Wang YanQing wrote:
On Fri, Jul 05, 2013 at 09:57:11PM +0530, Preeti U Murthy wrote:
Elaborate on when
Hi Wang,
On 07/06/2013 11:33 AM, Wang YanQing wrote:
On Sat, Jul 06, 2013 at 10:59:39AM +0530, Preeti U Murthy wrote:
Hi Wang,
On 07/06/2013 08:43 AM, Wang YanQing wrote:
On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote:
cfd-cpumask_ipi is used only in smp_call_function_many
9.98
16 20.46
Let me know if you want me to profile any of these runs for specific
statistics.
Regards
Preeti U Murthy
On 07/20/2013 12:58 AM, Jason Low wrote:
On Fri, 2013-07-19 at 16:54 +0530, Preeti U Murthy wrote:
Hi Json,
I ran ebizzy
On 05/06/2014 05:09 PM, Peter Zijlstra wrote:
On Tue, May 06, 2014 at 03:24:13PM +0530, Preeti Murthy wrote:
Hi Morten, Peter, Alex,
In a similar context, I noticed that /proc/loadavg makes use of
avenrun[] array which keeps track of the history of the global
load average. This however makes
already do that.
Hence I don't think we should take a drastic measure as to shutdown
the clock device in case of no pending timers,
My suggestion is as pointed above to set the tick device to a KTIME_MAX
equivalent before calling the timer interrupt event handler.
Regards
Preeti U Murthy
On 05/09/2014 04:27 PM, Viresh Kumar wrote:
On 9 May 2014 16:04, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
On 05/09/2014 02:10 PM, Viresh Kumar wrote:
I looked through the code in arm_arch_timer.c and I think the more
fundamental problem lies in the timer handler there. Ideally even
On 05/16/2014 07:47 PM, Peter Zijlstra wrote:
On Fri, May 16, 2014 at 07:27:32PM +0530, Preeti Murthy wrote:
0 isn't strictly the right thing to do here, since the clock can wrap,
but being wrong every ~585 years isn't too big an issue for this.
I don't understand this. Will setting it to 0
not be
mentioned explicitly IMHO.
Cc: Preeti U Murthy pre...@linux.vnet.ibm.com
Cc: Will Deacon will.dea...@arm.com
Acked-by: Mark Rutland mark.rutl...@arm.com
Signed-off-by: Lorenzo Pieralisi lorenzo.pieral...@arm.com
---
arch/arm64/kernel/time.c | 3 +++
1 file changed, 3 insertions
On 05/29/2014 06:09 PM, Mark Rutland wrote:
Hi Preeti,
On Thu, May 29, 2014 at 12:04:36PM +0100, Preeti U Murthy wrote:
Hi Lorenzo,
On 05/29/2014 02:53 PM, Lorenzo Pieralisi wrote:
On platforms implementing CPU power management, the CPUidle subsystem
can allow CPUs to enter idle states
is unconditionally registered, but
has the lowest possible rating such that any broadcast-capable HW clock
event device present will be chosen in preference as the tick broadcast
device.
Cc: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked-by: Will Deacon will.dea...@arm.com
Acked-by: Mark Rutland
a better idea of the utilization of a group fo CPUs thanks to
group_actitvity and deduct how many capacity is still available.
Signed-off-by: Vincent Guittot vincent.guit...@linaro.org
---
Right, so as Preeti already mentioned, this wrecks SMT. It also seems to
loose the aggressive spread
and the busy CPU.
Why do we do active balancing today when there is at-most 1 task on the
busiest cpu? Shouldn't we be skipping load balancing altogether? If we
do active balancing when the number of tasks = 1, it will lead to a ping
pong right?
Regards
Preeti U Murthy
--
To unsubscribe from
Hi Vincent,
Why do we have two interfaces arch_scale_freq_power() and
arch_scale_cpu_power()? Does it make sense to consolidate them now ?
Regards
Preeti U Murthy
On 05/23/2014 09:22 PM, Vincent Guittot wrote:
Use the new arch_scale_cpu_power in order to reflect the original capacity
On 05/26/2014 01:19 PM, Vincent Guittot wrote:
On 25 May 2014 12:33, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
On 05/23/2014 09:22 PM, Vincent Guittot wrote:
The imbalance flag can stay set whereas there is no imbalance.
Let assume that we have 3 tasks that run on a dual
On 05/26/2014 01:55 PM, Vincent Guittot wrote:
On 25 May 2014 15:22, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
Why do we have two interfaces arch_scale_freq_power() and
arch_scale_cpu_power()? Does it make sense to consolidate them now ?
Hi Preeti,
They don't have
12 -29.5070
16 -38.4842
20 -44.5747
24 -51.9792
28 -34.1863
32 -38.4029
38 -22.2490
42 -7.4843
47 -0.69676
Let me profile it and check where the cause of this degradation is.
Regards
Preeti U Murthy
--
To unsubscribe from
On 05/26/2014 09:24 PM, Vincent Guittot wrote:
Hi Preeti,
I have done ebizzy tests on my platforms but doesn't have similar
results than you (my results below). It seems to be linked to SMT. I'm
going to look at that part more deeply and try to find a more suitable
HW for tests.
You
S. Bhat srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/processor.h |4
drivers/cpuidle/cpuidle-powernv.c|7 +++
2 files changed, 7 insertions(+), 4
Fast sleep is a deep idle state on Power8. The support for the state was
added in commit 0d94873011. Today the idle threads in the host can
potentially be put to fast sleep. But when we launch guests using kvm,
the secondary threads are required to be offline and the offline threads
are put to
, add this check in the fastsleep wakeup path as well.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/exceptions-64s.S | 30
srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kvm/book3s_hv_rmhandlers.S | 73 ---
1 file changed, 65 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc
power savings in a KVM scenario as well
when an entire cpu core is idle.
As a precursor, consolidate the code common across all idle states.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre
. Today they go back to nap by default.
Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[ Changelog added by pre...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/exceptions-64s.S | 21 +++--
arch/powerpc/kernel
...@linux.vnet.ibm.com ]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/processor.h |8 +
arch/powerpc/kernel/idle.c | 52 ++
arch/powerpc/platforms/powernv/smp.c | 12 +++-
3 files changed, 71
On 05/12/2014 11:23 AM, Viresh Kumar wrote:
On 10 May 2014 21:47, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
On 05/09/2014 04:27 PM, Viresh Kumar wrote:
On 9 May 2014 16:04, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Ideally, the device should have stopped events as we programmed
Hi Frederic,
On 01/31/2014 10:00 PM, Frederic Weisbecker wrote:
On Wed, Jan 29, 2014 at 10:57:59AM +0530, Preeti Murthy wrote:
Hi,
On Thu, Jan 23, 2014 at 11:22 AM, Viresh Kumar viresh.ku...@linaro.org
wrote:
Hi Guys,
So the first question is why cpufreq needs it and is it really stupid
Hi Daniel,
On 01/31/2014 03:45 PM, Daniel Lezcano wrote:
On 01/31/2014 09:45 AM, Preeti Murthy wrote:
Hi,
On Thu, Jan 30, 2014 at 10:55 PM, Daniel Lezcano
daniel.lezc...@linaro.org wrote:
On 01/30/2014 05:35 PM, Peter Zijlstra wrote:
On Thu, Jan 30, 2014 at 05:27:54PM +0100, Daniel
not even optional.
On x86, it is on by default and on arm looks like its off by default.
Thanks,
Regards
Preeti U Murthy
On 3 February 2014 17:17, Alex Shi alex@linaro.org wrote:
I just run the 3.14-rc1 kernel on panda board. The only domain for it is
'CPU' domain, but this domain
there is no point correcting the prediction either.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Changes from V1:https://lkml.org/lkml/2014/1/14/26
1. Change the return code to success from -EINVAL due to the reason mentioned
in the changelog.
2. Add logic that the patch is addressing
On 02/04/2014 03:31 PM, Thomas Gleixner wrote:
On Fri, 24 Jan 2014, Preeti U Murthy wrote:
-extern void tick_broadcast_oneshot_control(unsigned long reason);
+extern int tick_broadcast_oneshot_control(unsigned long reason);
-static inline void tick_broadcast_oneshot_control(unsigned long
out the next version with the above corrections
including the patch added to this thread where we handle archs setting
the CPUIDLE_FLAG_TIMER_STOP flag?
Hmm?
Thanks,
tglx
Thanks
Regards
Preeti U Murthy
___
Linuxppc-dev mailing list
Hi Arjan,
On 02/04/2014 08:22 PM, Arjan van de Ven wrote:
On 2/4/2014 12:35 AM, Preeti U Murthy wrote:
The cpuidle governors today are not handling scenarios where no idle
state
can be chosen. Such scenarios coud arise if the user has disabled all the
idle states at runtime or the latency
.
---
Preeti U Murthy (5):
cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt
handling routines
powermgt: Add OPAL call to resync timebase on wakeup
time/cpuidle: Support in tick broadcast framework in the absence of
external clock device
cpuidle/powernv: Add
timers to
directly call into __timer_interupt(). One of the use cases of this is the
tick broadcast IPI handling in which the sleeping CPUs need to handle the local
timers that have expired.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/time.c | 81
...@linux.vnet.ibm.com
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2
-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[Functions renamed to tick_broadcast* and Changelog modified by
Preeti U. Murthypre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch
support
for fast sleep, enable it in the cpuidle framework on PowerNV.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/Kconfig |2 ++
arch/powerpc/kernel/time.c|2 +-
drivers/cpuidle/cpuidle-powernv.c | 42
idle state.
Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com
[Changelog modified by Preeti U. Murthy pre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/processor.h |1 +
arch/powerpc/kernel/exceptions-64s.S | 10
methods.
Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/opal.h|2 ++
arch/powerpc/kernel/exceptions-64s.S |2 +-
arch/powerpc/kernel/idle_power7.S
in the broadcast mask. This newly nominated bc_cpu is woken up by
an IPI so as to queue the above mentioned hrtimer on it.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
include/linux/clockchips.h |4 -
kernel/time/clockevents.c|9 +-
kernel/time/tick-broadcast.c | 192
Add deep idle states such as nap and fast sleep to the cpuidle state table
only if they are discovered from the device tree during cpuidle initialization.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle-powernv.c | 81
Hi Thomas,
Thank you very much for the review.
On 01/22/2014 06:57 PM, Thomas Gleixner wrote:
On Wed, 15 Jan 2014, Preeti U Murthy wrote:
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 086ad60..d61404e 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time
Hi Daniel,
Thank you for the review.
On 01/22/2014 01:59 PM, Daniel Lezcano wrote:
On 01/17/2014 05:33 AM, Preeti U Murthy wrote:
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index a55e68f..831b664 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
Hi Thomas,
The below patch works pretty much as is. I tried this out with deep idle
states on our system. Looking through the code and analysing corner
cases also did not bring out any issues to me. I will send out a patch
V2 of this.
Regards
Preeti U Murthy
On 01/22/2014 06:57 PM, Thomas
where the local timers stop can make use of.
Presently we are in need of this support on certain implementations of
PowerPC. This patchset has been used on PowerPC for testing with
---
Preeti U Murthy (1):
time: Change the return type of clockevents_notify() to integer
Thomas Gleixner (1
of
the stand by CPU as well by moving the hrtimer on to the CPU handling the
CPU_DEAD
notification.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
[Added Changelog and code to handle reprogramming of hrtimer]
---
include/linux/clockchips.h |9 +++
kernel/time/Makefile
. For such
a CPU, the BROADCAST_ENTER notification has to fail indicating that its clock
device cannot be shutdown. To make way for this support, change the return
type of tick_broadcast_oneshot_control() and hence clockevents_notify() to
indicate such scenarios.
Signed-off-by: Preeti U Murthy pre
On 01/24/2014 02:38 PM, Daniel Lezcano wrote:
On 01/23/2014 12:15 PM, Preeti U Murthy wrote:
Hi Daniel,
Thank you for the review.
On 01/22/2014 01:59 PM, Daniel Lezcano wrote:
On 01/17/2014 05:33 AM, Preeti U Murthy wrote:
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
to perhaps call into arch here to probe for
additional flags?
Thanks
Regards
Preeti U Murthy
Regards
Vincent
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On 01/07/2014 03:20 PM, Peter Zijlstra wrote:
On Tue, Jan 07, 2014 at 03:10:21PM +0530, Preeti U Murthy wrote:
What if we want to add arch specific flags to the NUMA domain? Currently
with Peter's patch:https://lkml.org/lkml/2013/11/5/239 and this patch,
the arch can modify the sd flags
On 01/07/2014 04:43 PM, Peter Zijlstra wrote:
On Tue, Jan 07, 2014 at 04:09:39PM +0530, Preeti U Murthy wrote:
On 01/07/2014 03:20 PM, Peter Zijlstra wrote:
On Tue, Jan 07, 2014 at 03:10:21PM +0530, Preeti U Murthy wrote:
What if we want to add arch specific flags to the NUMA domain? Currently
On 01/07/2014 06:01 PM, Vincent Guittot wrote:
On 7 January 2014 11:39, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
On 01/07/2014 03:20 PM, Peter Zijlstra wrote:
On Tue, Jan 07, 2014 at 03:10:21PM +0530, Preeti U Murthy wrote:
What if we want to add arch specific flags to the NUMA domain
. Remove the constraint of having to disable tickless idle on the broadcast
CPU by queueing a hrtimer dedicated to do broadcast.
V1 posting: https://lkml.org/lkml/2013/7/25/740.
1. Added the infrastructure to wakeup CPUs in deep idle states in which the
local timers stop.
---
Preeti U Murthy (4
...@linux.vnet.ibm.com
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2
-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[Functions renamed to tick_broadcast* and Changelog modified by
Preeti U. Murthypre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch
timers to
directly call into __timer_interupt(). One of the use cases of this is the
tick broadcast IPI handling in which the sleeping CPUs need to handle the local
timers that have expired.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel/time.c | 73
idle state.
Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com
[Changelog modified by Preeti U. Murthy pre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/processor.h |1 +
arch/powerpc/kernel/exceptions-64s.S | 10
in the broadcast mask. This newly nominated bc_cpu is woken up by
an IPI so as to queue the above mentioned hrtimer on it.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
include/linux/clockchips.h |4 -
kernel/time/clockevents.c|9 +-
kernel/time/tick-broadcast.c | 192
methods.
Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/opal.h|2 ++
arch/powerpc/kernel/exceptions-64s.S |2 +-
arch/powerpc/kernel/idle_power7.S
support
for fast sleep, enable it in the cpuidle framework on PowerNV.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/Kconfig |2 ++
arch/powerpc/kernel/time.c|2 +-
drivers/cpuidle/cpuidle-powernv.c | 39
Add deep idle states such as nap and fast sleep to the cpuidle state table
only if they are discovered from the device tree during cpuidle initialization.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle-powernv.c | 81
Hi Paul,
On 01/15/2014 08:59 PM, Paul Gortmaker wrote:
On 14-01-15 03:07 AM, Preeti U Murthy wrote:
[...]
This patchset is based on mainline commit-id:8ae516aa8b8161254d3, and the
I figured I'd give this a quick sanity build test for a few
configs, but v3.13-rc1-141-g8ae516aa8b81
-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Changes from V1:https://lkml.org/lkml/2014/1/14/26
1. Change the return code to success from -EINVAL due to the reason mentioned
in the changelog.
2. Add logic that the patch is addressing in the ladder governor as well.
3. Added relevant comments and removed
Hi,
The patch had some compile time fixes to be done. It was accidentally mailed
out before doing so. Below is the right patch. Apologies for the same.
Thanks
Regards
Preeti U Murthy
-
time: Support in tick broadcast
-by: Preeti U Murthy pre...@linux.vnet.ibm.com
The consequence of this would be for other Power platforms like PowerNV,
we will need to invoke ppc_runlatch_off() and ppc_runlatch_on() in each
of the idle routines since the idle_loop_prologue() and
idle_loop_epilogue() are not invoked by them, but we
notification too in this case if the
CPU in question is made the stand by CPU.
Thanks
Regards
Preeti U Murthy
-
time/cpuidle:Handle failed call to BROADCAST_ENTER on archs with
CPUIDLE_FLAG_TIMER_STOP set
From: Preeti U
Hi Daniel,
On 01/28/2014 02:16 PM, Daniel Lezcano wrote:
On 01/24/2014 11:21 AM, Preeti U Murthy wrote:
On 01/24/2014 02:38 PM, Daniel Lezcano wrote:
On 01/23/2014 12:15 PM, Preeti U Murthy wrote:
Hi Daniel,
Thank you for the review.
[ ... ]
---
drivers/cpuidle/cpuidle.c
but
are expected to have done so, isn't it?
Thanks
Regards
Preeti U Murthy
allowing for the warning to trig.
Signed-off-by: Nicolas Pitre n...@linaro.org
diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c
index 988573a9a3..14ca43430a 100644
--- a/kernel/cpu/idle.c
+++ b/kernel/cpu/idle.c
Hi Nicolas,
On 01/30/2014 10:58 AM, Nicolas Pitre wrote:
On Thu, 30 Jan 2014, Preeti U Murthy wrote:
Hi Nicolas,
On 01/30/2014 02:01 AM, Nicolas Pitre wrote:
On Wed, 29 Jan 2014, Nicolas Pitre wrote:
In order to integrate cpuidle with the scheduler, we must have a better
proximity
...@linux.vnet.ibm.com
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2
-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[Functions renamed to tick_broadcast* and Changelog modified by
Preeti U. Murthypre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch
From: Preeti U Murthy pre...@linux.vnet.ibm.com
Split timer_interrupt(), which is the local timer interrupt handler on ppc
into routines called during regular interrupt handling and __timer_interrupt(),
which takes care of running local timers and collecting time related stats.
This will enable
broadcast framework to handle wakeup of CPUs from
deep idle states on such implementations is currently under discussion.
https://lkml.org/lkml/2014/1/15/86
https://lkml.org/lkml/2014/1/24/28
Either way this patchset is essential to enable handling the tick broadcast
IPIs.
---
Preeti U Murthy (1
Hi Peter,
On 01/31/2014 02:32 PM, Peter Zijlstra wrote:
On Fri, Jan 31, 2014 at 02:15:47PM +0530, Preeti Murthy wrote:
If the driver does its own random mapping that will break the governor
logic. So yes, the states are ordered, the higher the index is, the more you
save power and the higher
bc_cpu is woken up by
an IPI so as to queue the above mentioned hrtimer on itself.
This patch is compile tested only.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
include/linux/clockchips.h |4 +
kernel/time/clockevents.c|8 +-
kernel/time/tick-broadcast.c | 157
Hi Ben,
On 12/13/2013 10:47 AM, Benjamin Herrenschmidt wrote:
On Fri, 2013-12-13 at 09:49 +0530, Preeti U Murthy wrote:
On some architectures, in certain CPU deep idle states the local timers stop.
An external clock device is used to wakeup these CPUs. The kernel support
for the
wakeup
these assumptions. Hence I am unable to imagine a scenario when the
parent might not include all cpus of its children domain. Do you have
such a scenario in mind which can arise due to this patch ?
Thanks
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux
mode to
periodic.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
include/linux/clockchips.h |4 -
kernel/time/clockevents.c|8 +-
kernel/time/tick-broadcast.c | 180 ++
kernel/time/tick-internal.h |8 +-
4 files changed, 173
to acknowledge the external interrupt and
service it accordingly.
Ideally the interrupt handler of this external interrupt should be that
of the local timer itself since it was meant to act on the behalf of the
local timer interrupt.
Thanks
Regards
Preeti U Murthy
--
To unsubscribe from this list: send
On 03/24/2014 01:51 PM, Hidetoshi Seto wrote:
(2014/03/24 16:45), Preeti Murthy wrote:
Hi Hidetoshi,
The patch looks good to me except the comments around the monotonicity
of the return value of the idle stats observer. I am unable to relate them
to the dependency on nr_iowait_cpu.
I see
to take care of rare occurences such as above. Moreover this is
not a harmful scenario where the cpu is in the mask but its tick device was
shutdown. The WARN_ON will then continue to capture cases where we could
possibly cause a kernel crash.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
On 03/26/2014 04:51 PM, Srivatsa S. Bhat wrote:
On 03/26/2014 09:26 AM, Preeti U Murthy wrote:
Its possible that the tick_broadcast_force_mask contains cpus which are not
in cpu_online_mask when a broadcast tick occurs. This could happen under the
following circumstance assuming CPU1 is among
On 03/26/2014 04:51 PM, Srivatsa S. Bhat wrote:
On 03/26/2014 09:26 AM, Preeti U Murthy wrote:
Its possible that the tick_broadcast_force_mask contains cpus which are not
in cpu_online_mask when a broadcast tick occurs. This could happen under the
following circumstance assuming CPU1 is among
think this will work. Find the modified patch below:
Thanks.
Regards
Preeti U Murthy
tick,broadcast:Clear hotplugged cpu in broadcast masks during CPU_DYING
notification
From: Preeti U Murthy pre...@linux.vnet.ibm.com
Its possible that the tick_broadcast_force_mask contains cpus which
On 04/28/2014 02:54 PM, Peter Zijlstra wrote:
On Sun, Apr 27, 2014 at 02:01:45PM +0530, Preeti Murthy wrote:
Hi Jason, Peter,
The below patch looks good to me except for one point.
In idle_balance() the below code snippet does not look right:
- if (pulled_task || time_after(jiffies
On 04/28/2014 11:34 PM, Jason Low wrote:
On Sun, 2014-04-27 at 14:01 +0530, Preeti Murthy wrote:
Hi Jason, Peter,
The below patch looks good to me except for one point.
In idle_balance() the below code snippet does not look right:
- if (pulled_task || time_after(jiffies, this_rq
On 05/04/2014 05:34 PM, Mike Galbraith wrote:
On Sun, 2014-05-04 at 17:14 +0530, Preeti Murthy wrote:
Hi Rik, Mike
On Fri, May 2, 2014 at 12:00 PM, Rik van Riel r...@redhat.com wrote:
On 05/02/2014 02:13 AM, Mike Galbraith wrote:
On Fri, 2014-05-02 at 00:42 -0400, Rik van Riel wrote
On 05/04/2014 06:11 PM, Rik van Riel wrote:
On 05/04/2014 07:44 AM, Preeti Murthy wrote:
Hi Rik, Mike
On Fri, May 2, 2014 at 12:00 PM, Rik van Riel r...@redhat.com wrote:
On 05/02/2014 02:13 AM, Mike Galbraith wrote:
On Fri, 2014-05-02 at 00:42 -0400, Rik van Riel wrote:
Whether
Commit 32e45ff43eaf5c17f changed the default value of
RECLAIM_DISTANCE to 30. However the comment around arch
specifc definition of RECLAIM_DISTANCE is not updated to
reflect the same. Correct the value mentioned in the comment.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Cc: Anton
301 - 400 of 1331 matches
Mail list logo
