Hi Prashant,
On 16/4/21 20:27, Prashant Malani wrote:
> Update the EC command header to include the new event bit. This bit
> is included in the latest version of the Chrome EC headers[1].
>
> [1]
> https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/include/ec_commands.h
>>
>> Confused, see below.
>>
>>> so we don't need address and
>>> size cells. This makes dtbs_check happy.
>>>
>>> CC: Hsin-Yi Wang
>>> CC: Enric Balletbo i Serra
>>> CC: Nicolas Boichat
>>> Signed-off-by:
devices.
Signed-off-by: Enric Balletbo i Serra
---
This is only a resend rebased on top of mainline to fix some trivial
conflicts.
arch/arm64/configs/defconfig | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 7b4be3807b6d
Enable the option necessary to boot mt8173-based boards to boot from
usb devices, like its phy and the regulators needed to have proper
support.
Signed-off-by: Enric Balletbo i Serra
---
This is only a resend rebased on top of mainline to fix some trivial
conflicts.
arch/arm64/configs
v, dev_fmt(fmt), ##__VA_ARGS__); \
> ~~~ ^~~
>
> [...]
Applied, thanks!
[1/1] platform/chrome: cros_ec_typec: fix clang -Wformat warning
commit: c6e939c63c80c26460b25cf1150ebe8396e8adcf
Best regards,
--
Enric Balletbo i Serra
, thanks!
[1/1] platform/chrome: wilco_ec: convert stream-like files from
nonseekable_open -> stream_open
commit: dbc334fb411f2e87ca0e812dc7ba13464aa89504
Best regards,
--
Enric Balletbo i Serra
rm/chrome: cros_ec_typec: Check for device within remove function
commit: 639ff208cb37c5a3f0198e62d04962b677d25c9c
Best regards,
--
Enric Balletbo i Serra
;
> Signed-off-by: Heikki Krogerus
> Cc: Benson Leung
> Cc: Enric Balletbo i Serra
Acked-by: Enric Balletbo i Serra
> ---
> drivers/platform/chrome/chromeos_laptop.c | 100 +-
> 1 file changed, 60 insertions(+), 40 deletions(-)
>
> diff --git a/dr
Hi,
On 3/2/21 12:07, Enric Balletbo i Serra wrote:
> From: Boris Brezillon
>
> This patch adds the missing MODULE_DEVICE_TABLE definitions on different
> Mediatek drivers which generates correct modalias for automatic loading
> when these drivers are compiled as an external modu
by: Enric Balletbo i Serra
> ---
> This patch is based on series ("soc: mediatek: Prepare MMSYS for DDP routing
> using tables")[1]
> and tested with mt8183 krand and mt8183 juniper device.
> The register value is referenced from [2].
>
> [1]
> https://patchw
On 24/3/21 11:25, Enric Balletbo i Serra wrote:
> Hi Elaine,
>
> On 24/3/21 11:18, elaine.zhang wrote:
>> Hi, Enric
>>
>> 在 2021/3/24 下午5:56, Enric Balletbo i Serra 写道:
>>> Hi Elaine,
>>>
>>> This is not the exact version I sent, and y
Hi Elaine,
On 24/3/21 11:18, elaine.zhang wrote:
> Hi, Enric
>
> 在 2021/3/24 下午5:56, Enric Balletbo i Serra 写道:
>> Hi Elaine,
>>
>> This is not the exact version I sent, and you reintroduced a "problem" that
>> were
>> already solved/discussed
e power bindings directory.
>
> Signed-off-by: Enric Balletbo i Serra
If you do significant is a good practice shortly describe them within [] here.
> Signed-off-by: Elaine Zhang
Note that my last version already had the
Reviewed-by: Rob Herring
Which should be fine for merging
Hi Hsin-Yi,
Thank you for your patch.
On 19/3/21 4:52, Hsin-Yi Wang wrote:
> mt8183-kukui-jacuzzi-juniper board also known as Acer Chromebook Spin 311,
> using mediatek mt8183 SoC.
>
> Signed-off-by: Hsin-Yi Wang
Reviewed-by: Enric Balletbo i Serra
> ---
> Documentation/d
ek: Add mt8173 power domain
> controller")
> Signed-off-by: Chunfeng Yun
Reviewed-by: Enric Balletbo i Serra
> ---
> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-ev
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Use a default table for mt2701, mt2712 and mt8173.
- Remove the mask field from routes struct as is not needed.
drivers/soc/mediatek/mtk-mmsys.c | 273 +++
drivers/soc/mediatek/mtk-mmsys.h | 215
Dear all,
This is the second version of this series intended to prepare the
mtk-mmsys driver to allow different DDP (Data Display Path) routing
tables per SoC. Note that the series has been tested only on MT8173 platform,
for MT2701 and MT2712 based devices we're using a default routing table
From: CK Hu
Apart from the driver data, in order to extend the driver to support more
and more SoCs, we will need to store other configuration data. So, create
a mtk_mmsys struct to encapsulate all that information.
Signed-off-by: CK Hu
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Chun
Hi Hsin-Yi,
Thank you for the patch.
On 15/3/21 12:41, Hsin-Yi Wang wrote:
> Damu is known as ASUS Chromebook Flip CM3.
>
> Signed-off-by: Hsin-Yi Wang
> ---
> v1->v2: fix pp3300_panel regulator property
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
>
Hi Hsin-Yi,
Thank you for the patch.
On 15/3/21 12:41, Hsin-Yi Wang wrote:
> mt8183-kukui-jacuzzi-damu board also known as ASUS Chromebook Flip CM3,
> using mediatek mt8183 SoC.
>
> Signed-off-by: Hsin-Yi Wang
Reviewed-by: Enric Balletbo i Serra
> ---
> Documentation/d
;
> Signed-off-by: Pierre-Louis Bossart
Looks good to me, so
Acked-by: Enric Balletbo i Serra
> ---
> sound/soc/codecs/cros_ec_codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cros_ec_codec.c
> b/sound/soc/codec
: dd65030295e2 ("soc: mediatek: pm-domains: Don't print an error if child
domain is deferred")
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Signed-off-by: Enric Balletbo i Serra
---
drivers/soc/mediatek/mtk-pm-domains.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletion
thus unindenting the block by one level.
>>
>> No other functional change has been done.
>>
>> Signed-off-by: Alexandru Ardelean
> @Gwendal, others This series from Alex has been outstanding for a while
> but may well still apply.
> Ideally looking for an ack.
Add the power domains names for the mt8183 SoC. This removes the debugfs
errors like the following:
debugfs: Directory 'power-domain' with parent 'pm_genpd' already present!
Fixes: eb9fa767fbe1 ("soc: mediatek: pm-domains: Add support for mt8183")
Signed-off-by: Enric Ballet
Add the power domains names for the mt8167 SoC.
Fixes: 207f13b419a6 ("soc: mediatek: pm-domains: Add support for mt8167")
Signed-off-by: Enric Balletbo i Serra
---
drivers/soc/mediatek/mt8167-pm-domains.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/soc/mediatek
Add the power domains names for the mt8192 SoC.
Fixes: a49d5e7a89d6 ("soc: mediatek: pm-domains: Add support for mt8192")
Signed-off-by: Enric Balletbo i Serra
---
drivers/soc/mediatek/mt8192-pm-domains.h | 21 +
1 file changed, 21 insertions(+)
diff --git a/d
-domain' with parent 'pm_genpd'
already present!
[2.257784] debugfs: Directory 'power-domain' with parent 'pm_genpd'
already present!
...
Fixes: 59b644b01cf4 ("soc: mediatek: Add MediaTek SCPSYS power domains")
Signed-off-by: Enric Balletbo i Serra
---
drivers/soc/mediatek
generated ID to avoid possible conflicts.
This change has no functional changes, but seems reasonable to let the
hardware to autogenerate the ID instead of hardcoding in software.
Signed-off-by: Enric Balletbo i Serra
---
drivers/staging/media/hantro/hantro_g1_h264_dec.c | 2 +-
1 file changed, 1
Convert the soc/rockchip/power_domain.txt binding document to json-schema
and move to the power bindings directory.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Rob Herring
---
Changes in v6:
- Add "rockchip," prefix to the qos compatible name. (Johan Jonker)
Changes in v5:
-
Enable the option necessary to boot mt8173-based boards to boot from
usb devices, like its phy and the regulators needed to have proper
support.
Signed-off-by: Enric Balletbo i Serra
---
arch/arm64/configs/defconfig | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/configs
devices.
Signed-off-by: Enric Balletbo i Serra
---
arch/arm64/configs/defconfig | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 30db9b50efaa..7f4d70d24bb5 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs
From: Boris Brezillon
This patch adds the missing MODULE_DEVICE_TABLE definitions on different
Mediatek drivers which generates correct modalias for automatic loading
when these drivers are compiled as an external module.
Signed-off-by: Boris Brezillon
Signed-off-by: Enric Balletbo i Serra
From: Boris Brezillon
This patch adds the missing MODULE_DEVICE_TABLE definitions on different
Mediatek phy drivers which generates correct modalias for automatic loading
when these drivers are compiled as an external module.
Signed-off-by: Boris Brezillon
Signed-off-by: Enric Balletbo i Serra
in the kernel image size but
will make the life a bit easier to the users, anyway you'll need to probably
enable all of them if you want to have proper support for that SoC.
Signed-off-by: Enric Balletbo i Serra
---
drivers/clk/mediatek/Kconfig | 11 +++
1 file changed, 11 insertions
rivers/platform/chrome/cros_ec_typec.c| 269
> +
> include/linux/platform_data/cros_ec_commands.h | 17 ++
> 2 files changed, 243 insertions(+), 43 deletions(-)
>
> Thanks so much!
> Benson
>
FWIW this looks good to me. It'd make more easy if all this goes through Greg's
tree instead of our chrome/platform tree. Not sure if is really needed but:
Acked-by: Enric Balletbo i Serra
Thanks,
Enric
Hi all,
On 1/2/21 15:37, Enric Balletbo i Serra wrote:
> Hi all,
>
> On 29/1/21 7:14, Benson Leung wrote:
>> USB Power Delivery has a 3 entity handshake (port, cable, partner), and as
>> of USB PD R3.0, each entity may independently support either Revision 2 or
&g
Hi all,
On 29/1/21 7:14, Benson Leung wrote:
> USB Power Delivery has a 3 entity handshake (port, cable, partner), and as
> of USB PD R3.0, each entity may independently support either Revision 2 or
> Revision 3 signaling and protocol. In order for userspace and the kernel
> to properly process
gt; source or sink.
>
> Signed-off-by: Benson Leung
Acked-by: Enric Balletbo i Serra
> ---
> drivers/platform/chrome/cros_ec_typec.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c
> b/drivers/platform/chrome/cros_ec_
Hi Benson,
On 29/1/21 7:14, Benson Leung wrote:
> Status provides sop_revision. Process it, and set it using the new
> setter in the typec class.
>
> Signed-off-by: Benson Leung
Acked-by: Enric Balletbo i Serra
> ---
> drivers/platform/chrome/cros_ec_typec.c | 14 ++
>
> Signed-off-by: Benson Leung
Acked-by: Enric Balletbo i Serra
> ---
> drivers/platform/chrome/cros_ec_typec.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c
> b/drivers/platform/chrome/cros_ec_typ
ec: Call interrupt bottom half at probe time
commit: 4daeb395f1754340927d8d58269593e4e3b6afcd
Best regards,
--
Enric Balletbo i Serra
ome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.
commit: 91b9694542179f2f2325a5c4f86c4e7f9be277d3
Best regards,
--
Enric Balletbo i Serra
s,
--
Enric Balletbo i Serra
to put them in read-only memory.
Applied, thanks!
[1/1] platform/chrome: Constify static attribute_group structs
commit: ed07d774c4b2793be4d2bfc62cf69c3e55667f5a
Best regards,
--
Enric Balletbo i Serra
t time EC reboots. Reset I2S RX when probing to
> fix this issue.
>
> Signed-off-by: Yu-Hsuan Hsu
Reviewed-by: Enric Balletbo i Serra
> ---
> Updated the info message.
>
> sound/soc/codecs/cros_ec_codec.c | 12
> 1 file changed, 12 insertions(+)
&
was already
Acked-by: Enric Balletbo i Serra
Mark I'm fine if both patches go through your tree.
> ---
> include/linux/platform_data/cros_ec_commands.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/platform_data/cros_ec_commands.h
> b/include/linux/pl
Hi,
On 14/1/21 7:54, Yu-Hsuan Hsu wrote:
> Add the new command EC_CODEC_I2S_RX_RESET in ec_codec_i2s_rx_subcmd,
> which is used for resetting the EC codec.
>
> Signed-off-by: Yu-Hsuan Hsu
For if Mark wants to take this patch through his tree.
Acked-by: Enric Ball
dev_info(dev,
> + "Command not found. Please update the EC firmware.\n");
Nitpicking a bit. I'd add which command is not found to give more information to
the user that gets into that path. Command not found is too generic for me.
But,
Reviewed-by: Enric Ballet
>
> Reviewed-by: Nicolas Boichat
>
Reviewed-by: Enric Balletbo i Serra
>> ---
>> drivers/soc/mediatek/mt8183-pm-domains.h | 1 +
>> drivers/soc/mediatek/mtk-pm-domains.c| 36 +++-
>> drivers/soc/mediatek/mtk-pm-domains.h| 1 +
>> 3 f
Child domains can be deferred by the core because one of its resources
is not available yet, in such case, it will print an error, but
later it will succeed to probe. Fix that using the dev_err_probe()
function so it only prints an error on a real error.
Signed-off-by: Enric Balletbo i Serra
-by: Enric Balletbo i Serra
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index bda283fa9245..8471c973dfd5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
Hi Hsin-Yi,
Thank you for the patch.
On 7/1/21 11:49, Hsin-Yi Wang wrote:
> Some power domains (eg. mfg) needs to turn on power supply before power
> on.
>
> Signed-off-by: Hsin-Yi Wang
Reviewed-by: Enric Balletbo i Serra
> ---
> .../bindings/power/mediatek,power-controll
Hi Hsin-Yi,
On 13/1/21 12:04, Hsin-Yi Wang wrote:
> Krane-sku0 is similar to krane-sku176 but using a different panel
> source.
>
> Signed-off-by: Hsin-Yi Wang
Reviewed-by: Enric Balletbo i Serra
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 4 +++-
&g
igned-off-by: Hsin-Yi Wang
> Reviewed-by: Nicolas Boichat
Tested on my Lenovo Ideapad Duet. Display is working.
Tested-by: Enric Balletbo i Serra
> ---
> change:
> v4: add backlight and enable mipi_tx0
> ---
> .../mediatek/mt8183-kukui-krane-sku176.dts| 5 +++
> ...
think the binding should be a separate patch? (Rob to confirm). Other than
that.
Reviewed-by: Enric Balletbo i Serra
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
> .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++
> 3 files changed, 27 insertions(+), 1
Hi Hsin-Yi,
Thank you for the patch.
On 13/1/21 7:28, Hsin-Yi Wang wrote:
> Config dsi node for mt8183 kukui. Set panel and ports.
>
> Several kukui boards share the same panel property and only compatible
> is different. So compatible will be set in board dts for comparison
> convenience.
>
>
Hi Yu-Hsun,
Thank you for your patch. Some comments below.
On 13/1/21 9:17, Yu-Hsuan Hsu wrote:
> It is not guaranteed that I2S RX is disabled when the kernel booting.
> For example, if the kernel crashes while it is enabled, it will keep
> enabled until the next time EC reboots. Reset I2S RX
Hi,
On 12/1/21 15:10, Mark Brown wrote:
> On Mon, Jan 11, 2021 at 05:52:31PM -0800, Guenter Roeck wrote:
>> On Mon, Jan 11, 2021 at 4:42 PM Mark Brown wrote:
>
>>> TBH that seems like a big enough change to split out from this and done
>>> as a separate series, I'd be perfectly happy to apply
Hi Yu-Hsuan,
Thank you for the patch.
On 7/1/21 9:59, Yu-Hsuan Hsu wrote:
> It is not guaranteed that I2S RX is disabled when the kernel booting.
> For example, if the kernel crashes while it is enabled, it will keep
> enabled until the next time EC reboots. Reset I2S RX when probing to
> fix
Hi Pi-Hsun,
Thank you for your patch. I don't accept patches with an empty commit
description. Can you add it? (maybe you could just explain more what cold-ap-off
means here. Apart from this, the patch LGTM.
Thanks,
Enric
On 17/12/20 9:14, Pi-Hsun Shih wrote:
> Signed-off-by: Pi-Hsun Shih
>
ndru M Stan
> Signed-off-by: Stephen Boyd
Acked-by: Enric Balletbo i Serra
> ---
> drivers/platform/chrome/cros_ec_spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_spi.c
> b/drivers/platform/chrome/cros_ec_spi.c
> index f9df
spi core
> take care of it.
>
> Fixes: a17d94f0b6e1 ("mfd: Add ChromeOS EC SPI driver")
> Cc: Simon Glass
> Cc: Gwendal Grignou
> Cc: Douglas Anderson
> Cc: Alexandru M Stan
> Signed-off-by: Stephen Boyd
> ---
Acked-by: Enric Balletbo i Serra
> dri
Hi,
On 4/12/20 1:10, Stephen Boyd wrote:
> Quoting Doug Anderson (2020-12-03 12:06:10)
>> On Wed, Dec 2, 2020 at 4:47 PM Stephen Boyd wrote:
>>>
>>> And that is wrong. With even more investigation and Doug's eagle eyes it
>>> seems that the cros-ec driver is overriding the spi::mode to clear out
Because mtk-mmsys uses the 'devm_platform_ioremap_resource' function, it
should depend on HAS_IOMEM.
Fixes: cc6576029aed ("soc: mediatek: mmsys: Use
devm_platform_ioremap_resource()")
Reported-by: kernel test robot
Signed-off-by: Enric Balletbo i Serra
---
drivers/soc/mediatek/K
s: b17bdd0d7a73 ("drm/mediatek: add component OVL_2L0")
Signed-off-by: Enric Balletbo i Serra
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
b/drivers/gpu/drm/mediat
From: Jitao Shi
Add dsi and mipitx nodes to the MT8183.
Signed-off-by: Jitao Shi
Signed-off-by: Enric Balletbo i Serra
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 31
1 file changed, 31 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
b/arch
Add display subsystem device nodes to allow video output.
Signed-off-by: Enric Balletbo i Serra
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 114 +++
1 file changed, 114 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
b/arch/arm64/boot/dts/mediatek
/project/linux-mediatek/list/?series=374013
Enric Balletbo i Serra (2):
arm64: dts: mt8183: Add iommu and larb nodes
arm64: dts: mt8183: Add display nodes for MT8183
Jitao Shi (1):
arm64: dts: mt8183: Add dsi node
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 224 +++
1 file
Add iommu and larb nodes to the MT8183.
Signed-off-by: Enric Balletbo i Serra
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 79
1 file changed, 79 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index
Hi Weiyi,
On 27/11/20 3:24, Weiyi Lu wrote:
> On Fri, 2020-10-30 at 12:36 +0100, Enric Balletbo i Serra wrote:
>> The System Control Processor System (SCPSYS) has several power management
>> related tasks in the system. Add the bindings to define the power
>> domains
ed-by: Enric Balletbo i Serra
> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 28 +++
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 +++
> 2 files changed, 38 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> b/arch/
tive
> cable plug link training value.
>
> Suggested-by: Heikki Krogerus
> Signed-off-by: Utkarsh Patel
Acked-by: Enric Balletbo i Serra
>
> --
> Changes in v2:
> - No change.
> --
> ---
> drivers/platform/chrome/cros_ec_typec.c | 14 --
>
On 13/11/20 21:24, Utkarsh Patel wrote:
> Thunderbolt rounded/non-rounded cable support is two bits value. Correcting
> it as per the Thunderbolt 3 cable discover mode VDO changes done in the
> Thunderbolt 3 alternate mode header.
>
> Signed-off-by: Utkarsh Patel
Acked-by: E
er altmodes
commit: de0f49487db3667f5204dcec6d3482c9bd1a0a30
Best regards,
--
Enric Balletbo i Serra
cause this is duplicated.
Applied, thanks!
[1/1] platform/chrome: Don't treat RTC events as wakeup sources
commit: 853c1a789f5fe8e783586a5c2dcc2ad1b57ac20f
Best regards,
--
Enric Balletbo i Serra
the
regmap phandle is optional.
Suggested-by: Nicolas Boichat
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Matthias Brugger
---
Changes in v2:
- Add Matthias r-b tag.
- Add the explanation from the patch description to the code.
- Return NULL instead of -ENOTSUPP when regmap helpers
i
>
> Reviewed-by: Heikki Krogerus
>
Acked-by: Enric Balletbo i Serra
Heikki, would you like to take these two through your tree? It'd help if you can
create an inmutable branch so I can pick other cros_ec_typec patches on top of
it.
Thanks,
Enric
>> ---
>>
>> C
Hi Matthias,
On 6/10/20 21:33, Enric Balletbo i Serra wrote:
> Dear all,
>
> The following series are intended to prepare the mtk-mmsys driver to
> allow different DDP (Data Display Path) routing tables per SoC. Note
> that the series has been tested only on MT8173 platform
Hi
On 5/10/20 18:22, Enric Balletbo i Serra wrote:
> Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> introduced the following build warning with W=1
>
> drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable
> 'mtk_dpi_encod
@ -123,6 +123,14 @@
> #define MT8173_TOP_AXI_PROT_EN_MFG_M1BIT(22)
> #define MT8173_TOP_AXI_PROT_EN_MFG_SNOOP_OUT BIT(23)
>
> +#define MT8167_TOP_AXI_PROT_EN_MM_EMIBIT(1)
> +#define MT8167_TOP_AXI_PROT_EN_MCU_MFG BIT(2)
> +#define MT8167_TOP_AXI_PROT_EN_CONN_EMI BIT(4)
> +#define MT8167_TOP_AXI_PROT_EN_MFG_EMI BIT(5)
> +#define MT8167_TOP_AXI_PROT_EN_CONN_MCU BIT(8)
> +#define MT8167_TOP_AXI_PROT_EN_MCU_CONN BIT(9)
> +#define MT8167_TOP_AXI_PROT_EN_MCU_MMBIT(11)
> +
> #define MT2701_TOP_AXI_PROT_EN_MM_M0 BIT(1)
> #define MT2701_TOP_AXI_PROT_EN_CONN_MBIT(2)
> #define MT2701_TOP_AXI_PROT_EN_CONN_SBIT(8)
>
Reviewed-by: Enric Balletbo i Serra
Thanks,
Enric
Hi Fabien,
Thank you for the patch and base it on [0]
On 27/10/20 14:11, Fabien Parent wrote:
> Add power domains dt-bindings for MT8167.
>
> Signed-off-by: Fabien Parent
> ---
>
> This patch depends on the SCPSYS PM domains driver [0].
>
> v2:
> * Implement on top of new SCPSYS PM
From: Matthias Brugger
In some cases the hardware does not create an acknowledgment of the
bus protection clearing. Add a flag to the bus protection indicating
that a clear event will be ignored.
Signed-off-by: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4: None
://lore.kernel.org/patchwork/patch/1328096/
[2] https://patchwork.kernel.org/project/linux-mediatek/list/?series=368821
Best regards,
Enric
Enric Balletbo i Serra (5):
dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains
controller
soc: mediatek: Add MediaTek SCPSYS power domains
From: Matthias Brugger
Apart from the infracfg block, the SMI block is used to enable the bus
protection for some power domains. Add support for this block.
Signed-off-by: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4:
- Use the new
The System Control Processor System (SCPSYS) has several power management
related tasks in the system. Add the bindings to define the power
domains for the SCPSYS power controller.
Co-developed-by: Matthias Brugger
Signed-off-by: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
Reviewed
-by: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4:
- Use a boolean for scpsys_domain_is_on().
- Disable the SRAM in the scpsys_power_on() error path.
- Use the regmap_[clear|set]_bits helpers.
- Use the new syscon_regmap_lookup_by_phandle_optional() helper.
- Rename domains
From: Matthias Brugger
Bus protection is not exclusively done by calling the infracfg misc driver.
Make the calls for setting and clearing the bus protection generic so
that we can use other blocks for it as well.
Signed-off-by: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
From: Matthias Brugger
Add power domains controller node for SoC mt8183
Signed-off-by: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 162 +++
1 file
Add power domains dt-bindings for MT8183.
Signed-off-by: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
.../power/mediatek,power-controller.yaml | 2 ++
include/dt-bindings/power/mt8183-power.h | 26
From: Weiyi Lu
Add power domains dt-bindings for MT8192.
Signed-off-by: Weiyi Lu
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
.../power/mediatek,power-controller.yaml | 2 ++
include/dt-bindings/power/mt8192-power.h | 32
-by: Weiyi Lu
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4:
- Check via scpsys_domain_is_on() if a power domain is on when removing.
Changes in v3: None
Changes in v2: None
drivers/soc/mediatek/mtk-pm-domains.c | 25 ++---
drivers/soc/mediatek/mtk-pm-domains.h
From: Weiyi Lu
Add the needed board data to support mt8192 SoC.
Signed-off-by: Weiyi Lu
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4:
- Adapt scpsys_soc_data struct to the changes done in previous patches.
Changes in v3: None
Changes in v2: None
drivers/soc/mediatek/mt8192-pm
From: Matthias Brugger
Add the needed board data to support mt8183 SoC.
Signed-off-by: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4:
- Adapt the scpsys_soc_data struct to the changes done in previous
patches.
Changes in v3:
- Do not remove mmsys from
Add power domain controller node for SoC mt8173.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4: None
Changes in v3: None
Changes in v2:
- Add a scpsys syscon node as parent and a SPM (System Power Manager) as
a child.
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 164
: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
Seires-changes: 4
- Use the regmap_[clear|set]_bits helpers.
---
Changes in v4: None
Changes in v3: None
Changes in v2:
- Nit, split readl(ctl_addr) | pd->data->sram_pdn_bits in two lines.
- Use regmap API
drivers/soc/mediatek/mtk-p
.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
From: Matthias Brugger
Bus protection will need to update more then one register
in infracfg. Add support for several operations.
Signed-off-by: Matthias Brugger
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4:
- Define SPM_MAX_BUS_PROT_DATA to 5 to be compatible with MT8192
Signed-off-by: Enric Balletbo i Serra
---
Changes in v4: None
Changes in v3:
- Prepare the basic clocks before we prepare the subsystem clocks.
Changes in v2:
- Use dev_err_probe if getting clocks fails, so an error is not printed
if is deferred.
drivers/soc/mediatek/mtk-pm-domains.c | 81
Hi Weilyi and Matthias,
On 29/10/20 15:51, Matthias Brugger wrote:
>
>
> On 27/10/2020 12:18, Weiyi Lu wrote:
>> On Tue, 2020-10-27 at 11:53 +0100, Matthias Brugger wrote:
>>>
>>> On 26/10/2020 18:55, Enric Balletbo i Serra wrote:
>>>> From: Weiyi L
Hi Nicolas,
Thank you for your comments.
On 27/10/20 3:44, Nicolas Boichat wrote:
> On Tue, Oct 27, 2020 at 1:55 AM Enric Balletbo i Serra
> wrote:
>>
>> From: Matthias Brugger
>>
>> Apart from the infracfg block, the SMI block is used to enable the bus
>&g
1 - 100 of 2632 matches
Mail list logo
