Re: [PATCH] Input: twl4030_keypad - Fix missing IRQF_ONESHOT as only threaded handler

2021-04-16 Thread Felipe Balbi
zhuguangqin...@gmail.com writes: > From: Guangqing Zhu > > Coccinelle noticed: > drivers/input/keyboard/twl4030_keypad.c:413:9-34: ERROR: Threaded IRQ with > no primary handler requested without IRQF_ONESHOT > > Signed-off-by: Guangqing Zhu Reviewed-by: Felipe Balbi --

Re: [PATCH V3 2/4] soc: qcom: dcc:Add driver support for Data Capture and Compare unit(DCC)

2021-04-15 Thread Felipe Balbi
Hi, Souradeep Chowdhury writes: > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index ad675a6..e7f0ccb 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -1,19 +1,22 @@ > # SPDX-License-Identifier: GPL-2.0 > CFLAGS_rpmh-rsc.o := -I$(src) >

Re: [PATCH] usb: dwc3: gadget: Avoid canceling current request for queuing error

2021-04-15 Thread Felipe Balbi
Wesley Cheng writes: > If an error is received when issuing a start or update transfer > command, the error handler will stop all active requests (including > the current USB request), and call dwc3_gadget_giveback() to notify > function drivers of the requests which have been stopped. Avoid >

Re: [PATCH v2 2/3] arm64: dts: qcom: sm8150: add i2c nodes

2021-04-14 Thread Felipe Balbi
Caleb Connolly writes: > Tested on the OnePlus 7 Pro (including DMA). > > Signed-off-by: Caleb Connolly > Reviewed-by: Vinod Koul > Reviewed-by: Bhupesh Sharma Tested on Microsoft Surface Duo (DTS will be sent after -rc1) Tested-by: Felipe Balbi -- balbi signature.asc D

Re: [PATCH v2] usb: dwc3: core: Add shutdown callback for dwc3

2021-04-14 Thread Felipe Balbi
t; > Signed-off-by: Sandeep Maheswaram Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] regulator: Use IRQF_ONESHOT

2021-03-25 Thread Felipe Balbi
Hi, Krzysztof Kozlowski writes: > On 23/03/2021 13:12, Jian Dong wrote: >> From: Jian Dong >> >> Fixes coccicheck error: >> >> drivers/regulator/mt6360-regulator.c:388:8-33: ERROR: >> drivers/regulator/pca9450-regulator.c:781:7-32: ERROR: >> drivers/regulator/slg51000-regulator.c:480:8-33:

Re: [PATCH] usb: dwc3: add cancelled reason for dwc3 requests

2021-03-25 Thread Felipe Balbi
Hi, Ray Chi writes: > diff --git a/drivers/usb/dwc3/gadget.h b/drivers/usb/dwc3/gadget.h > index 0cd281949970..a23e85bd3933 100644 > --- a/drivers/usb/dwc3/gadget.h > +++ b/drivers/usb/dwc3/gadget.h > @@ -56,6 +56,12 @@ struct dwc3; > > /* Frame/Microframe Number Mask */ > #define

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-24 Thread Felipe Balbi
Hi, Daehwan Jung writes: > Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after > entering suspend. That's why it needs to check whether suspend > > 1. dwc3 sends disconnect uevent and turn off. (suspend) > 2. Platform side causes pullup or set_speed(e.g., adbd closes ffs

Re: [PATCH] usb: gadget: u_serial: Remove old tasklet comments

2021-01-18 Thread Felipe Balbi
Davidlohr Bueso writes: > Update old comments as of 8b4c62aef6f (usb: gadget: u_serial: process RX > in workqueue instead of tasklet). > > Signed-off-by: Davidlohr Bueso Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] USB: gadget: udc: Process disconnect synchronously

2021-01-18 Thread Felipe Balbi
u may have to deal with VBUS valid, but for now this is good: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 1/7] dt-bindings: usb: qcom,dwc3: Add binding for SDX55

2021-01-18 Thread Felipe Balbi
Hi, Manivannan Sadhasivam writes: > Add devicetree binding for SDX55 USB controller based on Qcom designware > IP. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Manivannan Sadhasivam Acked-by: Felipe Balbi --

Re: [PATCH v2 4/4] dt-bindings: usb: qcom,dwc3: Add bindings for SM8150, SM8250, SM8350

2021-01-18 Thread Felipe Balbi
+ - qcom,sm8250-dwc3 > + - qcom,sm8350-dwc3 nicely done! Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-01-18 Thread Felipe Balbi
Hi, Michael Grzeschik writes: > On Tue, Dec 15, 2020 at 12:24:51PM +0530, Manish Narani wrote: >>Add a new driver for supporting Xilinx platforms. This driver is used >>for some sequence of operations required for Xilinx USB controllers. >>This driver is also used to choose between PIPE clock

Re: [PATCH] usb: bdc: Remove the BDC PCI driver

2021-01-18 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: >> Al Cooper writes: >> > The BDC PCI driver was only used for design verification with >> > an PCI/FPGA board. The board no longer exists and is not in use >> > anywhere. All instances of this core now exist as a memory mapped >> > device on the platform bus. >>

Re: [PATCH] usb: bdc: Remove the BDC PCI driver

2021-01-18 Thread Felipe Balbi
Hi, Al Cooper writes: > The BDC PCI driver was only used for design verification with > an PCI/FPGA board. The board no longer exists and is not in use > anywhere. All instances of this core now exist as a memory mapped > device on the platform bus. > > NOTE: This only removes the PCI driver

Re: [PATCH v3 4/4] usb: dwc3: pci: add support for the Intel Alder Lake-P

2021-01-15 Thread Felipe Balbi
Heikki Krogerus writes: > This patch adds the necessary PCI ID for Intel Alder Lake-P > devices. > > Signed-off-by: Heikki Krogerus The only missing my ack: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] drivers/usb/gadget/udc: Assign boolean values to a bool variable

2021-01-14 Thread Felipe Balbi
Jiapeng Zhong writes: > Fix the following coccicheck warnings: > > ./drivers/usb/gadget/udc/udc-xilinx.c:1957:2-18: WARNING: > Assignment of 0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong Acked-by: Felipe Balbi -- balbi signature

Re: [PATCH 07/10] dwc3: document gadget_max_speed

2021-01-14 Thread Felipe Balbi
ff-by: Mauro Carvalho Chehab Thanks, Mauro. Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RESEND v4 11/11] usb: gadget: bdc: fix checkpatch.pl repeated word warning

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > fix the warning: > WARNING:REPEATED_WORD: Possible repeated word: 'and' > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RESEND v4 07/11] usb: gadget: bdc: avoid precedence issues

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > Add () around macro argument to avoid precedence issues > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RESEND v4 10/11] usb: gadget: bdc: fix checkpatch.pl spacing error

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > fix checkpatch.pl error: > ERROR:SPACING: space prohibited before that ',' > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RESEND v4 09/11] usb: gadget: bdc: fix checkpatch.pl tab warning

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements > WARNING:TABSTOP: Statements should start on a tabstop > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Felipe Balbi -- bal

Re: [PATCH RESEND v4 08/11] usb: gadget: bdc: use the BIT macro to define bit filed

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > Prefer using the BIT macro to define bit fileds > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RESEND v4 06/11] usb: gadget: bdc: add identifier name for function declaraion

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > This is used to avoid the warning of function arguments, e.g. > WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' > should also have an identifier name > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainel

Re: [PATCH RESEND v4 05/11] usb: gadget: bdc: fix check warning of block comments alignment

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > fix the warning: > WARNING:BLOCK_COMMENT_STYLE: > Block comments should align the * on each line > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RESEND v4 04/11] usb: gadget: bdc: fix warning of embedded function name

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > Use '"%s...", __func__' to replace embedded function name > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RESEND v4 03/11] usb: gadget: bdc: prefer pointer dereference to pointer type

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > Prefer kzalloc(sizeof(*bd_table)...) over > kzalloc(sizeof(struct bd_table) > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RESEND v4 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > No definition for bdc_ep_set_halt(), so remove it. > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file

2021-01-13 Thread Felipe Balbi
Chunfeng Yun writes: > For C header files Documentation/process/license-rules.rst > mandates C-like comments (opposed to C source files where > C++ style should be used). > > Cc: Florian Fainelli > Signed-off-by: Chunfeng Yun > Acked-by: Florian Fainelli Acked-by: Fel

Re: [PATCH] usb: dwc3: qcom: Add shutdown callback for dwc3

2021-01-13 Thread Felipe Balbi
Hi, Sandeep Maheswaram writes: > This patch adds a shutdown callback to USB DWC QCOM driver to ensure that > it is properly shutdown in reboot/shutdown path. This is required > where SMMU address translation is enabled like on SC7180 > SoC and few others. If the hardware is still accessing

Re: [PATCH v2 0/3] Remove one more platform_device_add_properties() call

2021-01-12 Thread Felipe Balbi
uce device_add_software_node() > usb: dwc3: pci: Register a software node for the dwc3 platform device > usb: dwc3: pci: ID for Tiger Lake CPU Looks good to me. Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb/gadget: f_midi: Replace tasklet with work

2021-01-10 Thread Felipe Balbi
s are ok regarding concurrency - tasklets being serialized > against itself. > > Cc: Takashi Iwai > Signed-off-by: Davidlohr Bueso Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: dwc3: core: Replace devm_reset_control_array_get()

2021-01-08 Thread Felipe Balbi
Yejune Deng writes: > devm_reset_control_array_get_optional_shared() looks more readable > > Signed-off-by: Yejune Deng Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v3 1/2] usb: dwc3: Trigger a GCTL soft reset when switching modes in DRD

2021-01-08 Thread Felipe Balbi
these !COREIDLE lockups seen on HiKey960, this > patch issues GCTL soft reset when switching modes if the > controller is in DRD mode. > > Cc: Felipe Balbi > Cc: Tejas Joglekar > Cc: Yang Fei > Cc: YongQin Liu > Cc: Andrzej Pietrasiewicz > Cc: Thinh Nguyen > Cc:

Re: [PATCH 1/1] usb: gadget: aspeed: fix stop dma register setting.

2021-01-08 Thread Felipe Balbi
e, 1: enable > > Signed-off-by: Ryan Chen I don't have HW, but FWIW: Acked-by: Felipe Balbi -- balbi

Re: [PATCH v2 5/5] usb: gadget: u_audio: clean up locking

2021-01-07 Thread Felipe Balbi
h irqs disabled, so saving and > restoring the irqs is not necessary. > > Signed-off-by: Jerome Brunet This is nice! Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 4/5] usb: gadget: u_audio: remove struct uac_req

2021-01-07 Thread Felipe Balbi
ell, without allocating > extra memory. > > Signed-off-by: Jerome Brunet Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 3/5] usb: gadget: u_audio: factorize ssize to alsa fmt conversion

2021-01-07 Thread Felipe Balbi
Jerome Brunet writes: > Factorize format related code common to the capture and playback path. > > Signed-off-by: Jerome Brunet It's never a good idea to send fixes and cleanups/refactors in the same series as that can confuse the person applying your changes. In any case: Acked-b

Re: [PATCH v2 1/5] usb: gadget: u_audio: Free requests only after callback

2021-01-07 Thread Felipe Balbi
i].req); do you mind adding a comment here stating that this is coping with a possible error during usb_ep_dequeue()? Other than that: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 2/5] usb: gadget: f_uac2: reset wMaxPacketSize

2021-01-07 Thread Felipe Balbi
h time > the audio gadget is instantiated. > > Reset the endpoint maximum packet size and mark wMaxPacketSize as dynamic > to solve the problem. > > Fixes: 913e4a90b6f9 ("usb: gadget: f_uac2: finalize wMaxPacketSize according > to bandwidth") > Signed-off-by: Jerome

Re: [PATCH] Revert "usb: gadget: Quieten gadget config message"

2021-01-07 Thread Felipe Balbi
Hi, Albert Wang writes: > This reverts commit 1cbfb8c4f62d667f6b8b3948949737edb92992cccd. > > The log of USB enumeration result is a useful log and only occupies > one line especially when USB3 enumeration failed and then downgrade > to USB2. > > Signed-off-by: Albert Wang you can use dynamic

Re: [PATCH 2/3] usb: gadget: composite: Split composite reset and disconnect

2021-01-05 Thread Felipe Balbi
Hi, Wesley Cheng writes: > +void composite_reset(struct usb_gadget *gadget) > +{ > + /* > + * Section 1.4.13 Standard Downstream Port of the USB battery charging > + * specification v1.2 states that a device connected on a SDP shall only > + * draw at max 100mA while in a

Re: [PATCH] usb: gadget: select CONFIG_CRC32

2021-01-05 Thread Felipe Balbi
d: > drivers/usb/gadget/function/f_ncm.o:f_ncm.c:(.text+0x1e40): > more undefined references to `crc32_le' follow > > Fixes: 6d3865f9d41f ("usb: gadget: NCM: Add transmit multi-frame.") > Signed-off-by: Arnd Bergmann Acked-by: Felipe Balbi -- balbi

Re: [PATCH v4 1/4] dt-bindings: usb: add rk3328 dwc3 docs

2020-11-06 Thread Felipe Balbi
Hi, Lindsey Stanpoor writes: > On Wed, Sep 2, 2020 at 11:12 AM wrote: >> >> From: Cameron Nemo >> >> Document compatible for dwc3 on the Rockchip rk3328 platform. > > Hi all, > > Wanted to give this patch submission a gentle ping. > > Rob Herring acked the documentation changes, but I have

Re: [PATCH 5.9 000/391] 5.9.4-rc1 review

2020-11-04 Thread Felipe Balbi
Hi, Naresh Kamboju writes: > On Wed, 4 Nov 2020 at 02:07, Greg Kroah-Hartman > wrote: >> >> This is the start of the stable review cycle for the 5.9.4 release. >> There are 391 patches in this series, all will be posted as a response >> to this one. If anyone has any issues with these being

Re: [PATCH v2 4/5] usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE

2020-10-30 Thread Felipe Balbi
o Jiaxing other than that, this looks okay. Since it depends on the definition of DEFINE_SHOW_STORE_ATTRIBUTE: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v3 31/56] usb: dwc3: fix kernel-doc markups

2020-10-28 Thread Felipe Balbi
Greg Kroah-Hartman writes: > On Tue, Oct 27, 2020 at 08:58:47AM +0200, Felipe Balbi wrote: >> >> Hi Mauro, >> >> Mauro Carvalho Chehab writes: >> > There is a common comment marked, instead, with kernel-doc >> > notation. >> > &g

Re: [PATCH v3] usb: dwc3: core: fix a issue about clear connect state

2020-10-28 Thread Felipe Balbi
Hi, Dejin Zheng writes: >> Dejin Zheng writes: >> > According to Synopsys Programming Guide chapter 2.2 Register Resets, >> > it cannot reset the DCTL register by setting DCTL.CSFTRST for core soft >> > reset, if DWC3 controller as a slave device and stay connected with a usb >> > host, then,

Re: [PATCH v2] usb: gadget: configfs: Fix use-after-free issue with udc_name

2020-10-27 Thread Felipe Balbi
Hi, Macpaul Lin writes: > From: Eddie Hung > > There is a use-after-free issue, if access udc_name > in function gadget_dev_desc_UDC_store after another context > free udc_name in function unregister_gadget. > > Context 1: > gadget_dev_desc_UDC_store()->unregister_gadget()-> > free

Re: [PATCH 2/3] usb: dwc3: ulpi: Replace CPU-based busyloop with Protocol-based one

2020-10-27 Thread Felipe Balbi
Hi, Serge Semin writes: > Originally the procedure of the ULPI transaction finish detection has been > developed as a simple busy-loop with just decrementing counter and no > delays. It's wrong since on different systems the loop will take a > different time to complete. So if the system bus

Re: [PATCH 1/3] usb: dwc3: ulpi: Use VStsDone to detect PHY regs access completion

2020-10-27 Thread Felipe Balbi
Hi, Serge Semin writes: > In accordance with [1] the DWC_usb3 core sets the GUSB2PHYACCn.VStsDone > bit when the PHY vendor control access is done and clears it when the > application initiates a new transaction. The doc doesn't say anything > about the GUSB2PHYACCn.VStsBsy flag serving for

Re: [PATCH 0/3] usb: dwc3: ulpi: Fix UPLI registers read/write ops

2020-10-27 Thread Felipe Balbi
Serge Semin writes: > Our Baikal-T1 SoC is equipped with DWC USB3 IP core as a USB2.0 bus > controller. In general the DWC USB3 driver is working well for it except > the ULPI-bus part. We've found out that the DWC USB3 ULPI-bus driver detected > PHY with VID:PID tuple as 0x:0x, which of

Re: [PATCH v1] usb: dwc3: core: fix a issue about clear connect state

2020-10-27 Thread Felipe Balbi
Hi, Dejin Zheng writes: > According to Synopsys Programming Guide chapter 2.2 Register Resets, > it cannot reset the DCTL register by set DCTL.CSFTRST for Core Soft Reset, > if DWC3 controller as a slave device and stay connected with a usb host, > then, reboot linux, it will fail to

Re: [PATCH v3] usb: dwc3: core: fix a issue about clear connect state

2020-10-27 Thread Felipe Balbi
Hi, Dejin Zheng writes: > According to Synopsys Programming Guide chapter 2.2 Register Resets, > it cannot reset the DCTL register by setting DCTL.CSFTRST for core soft > reset, if DWC3 controller as a slave device and stay connected with a usb > host, then, while rebooting linux, it will fail

Re: [PATCH v3 31/56] usb: dwc3: fix kernel-doc markups

2020-10-27 Thread Felipe Balbi
Hi Mauro, Mauro Carvalho Chehab writes: > There is a common comment marked, instead, with kernel-doc > notation. > > Also, some identifiers have different names between their > prototypes and the kernel-doc markup. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/usb/dwc3/core.c

Re: [PATCH v2] usb: dwc3: Trigger a GCTL soft reset when switching modes in DRD

2020-10-23 Thread Felipe Balbi
Hi, John Stultz writes: > On Thu, Oct 22, 2020 at 12:55 AM Felipe Balbi wrote: >> John Stultz writes: >> > From: Yu Chen >> > >> > With the current dwc3 code on the HiKey960 we often see the >> > COREIDLE flag get stuck off in __dwc3_gadget_start

Re: [PATCH v2] usb: dwc3: Trigger a GCTL soft reset when switching modes in DRD

2020-10-22 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > John Stultz wrote: >> static void __dwc3_set_mode(struct work_struct *work) >> { >> struct dwc3 *dwc = work_to_dwc(work); >> unsigned long flags; >> +int hw_mode; >> int ret; >> u32 reg; >> >> @@ -154,6 +168,11 @@ static void

Re: [PATCH v2] usb: dwc3: Trigger a GCTL soft reset when switching modes in DRD

2020-10-22 Thread Felipe Balbi
Hi, John Stultz writes: > From: Yu Chen > > With the current dwc3 code on the HiKey960 we often see the > COREIDLE flag get stuck off in __dwc3_gadget_start(), which > seems to prevent the reset irq and causes the USB gadget to > fail to initialize. > > We had seen occasional initialization

Re: [PATCH 01/29] usb: dwc3: Discard synopsys,dwc3 compatibility string

2020-10-20 Thread Felipe Balbi
Hi, Serge Semin writes: > Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix. > Discard a DW USB3 compatible string with the deprecated prefix seeing > one isn't used by any dts file anymore. > > Signed-off-by: Serge Semin > --- > drivers/usb/dwc3/core.c | 3 --- > 1 file

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-15 Thread Felipe Balbi
Serge Semin writes: > On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: >> >> Hi Serge, >> >> Serge Semin writes: >> > In accordance with the DWC USB3 bindings the corresponding node name is >> > suppose to comply with Gene

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Felipe Balbi
Hi Serge, Serge Semin writes: > In accordance with the DWC USB3 bindings the corresponding node name is > suppose to comply with Generic USB HCD DT schema, which requires the USB DWC3 is not a simple HDC, though. > nodes to have the name acceptable by the regexp: "^usb(@.*)?" . But a lot > of

Re: [PATCH 1/3] ANDROID: usb: gadget: f_accessory: Add Android Accessory function

2020-10-12 Thread Felipe Balbi
Hi, rickyniu writes: > From: Benoit Goby missing Signed-off-by for author > USB accessory mode allows users to connect USB host hardware > specifically designed for Android-powered devices. The accessories > must adhere to the Android accessory protocol outlined in the >

Re: [PATCH 0/3] f_accessory upstream

2020-10-12 Thread Felipe Balbi
Hi, rickyniu writes: > Below commit is to add log and send uevent: > 0003-ANDROID-usb-f_accessory-send-uevent-for-51-52-reques.patch if you're sending something new... > Benoit Goby (1): > ANDROID: usb: gadget: f_accessory: Add Android Accessory function > > Vijayavardhan Vennapusa (1): >

Re: [PATCH v2 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board

2020-09-29 Thread Felipe Balbi
Neil Armstrong writes: > Hi Felipe, > > Is there anything to change in this serie ? I've been waiting for Kishon's review of drivers/phy parts. I can take the rest, but without Kishon's ack, drivers/phy will be left out. -- balbi signature.asc Description: PGP signature

Re: [PATCH 2/2] dt-bindings: document a new quirk for dwc3

2020-09-29 Thread Felipe Balbi
Mauro Carvalho Chehab writes: > Ping. > > Felipe, > > Em Thu, 17 Sep 2020 08:47:48 -0600 > Rob Herring escreveu: > >> On Thu, Sep 17, 2020 at 1:18 AM Mauro Carvalho Chehab >> wrote: >> > > >> > IMO, adding a new quirk is cleaner, and adopts the same solution >> > that it is currently used by

Re: [PATCH] usb: bdc: Remove duplicate error message in bdc_probe()

2020-09-28 Thread Felipe Balbi
Hi, Tang Bin writes: > Hi Greg KH: > > 在 2020/9/27 21:45, Greg KH 写道: >> On Sun, Sep 27, 2020 at 09:42:18PM +0800, Tang Bin wrote: >>> In this function, we don't need dev_err() message because >>> when something goes wrong, devm_platform_ioremap_resource() >>> can print an error message itself,

RE: [PATCH v2 1/2] dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3 Controller

2020-09-25 Thread Felipe Balbi
Hi, Manish Narani writes: > Hi Rob/Felipe, > > Thanks for the review. > >> -Original Message----- >> From: Felipe Balbi >> Sent: Thursday, September 24, 2020 12:47 PM >> To: Rob Herring ; Manish Narani >> Cc: gre...@linuxfoundation.org; Micha

Re: [PATCH v3] usb: dwc3: Stop active transfers before halting the controller

2020-09-25 Thread Felipe Balbi
Hi, Alan Stern writes: >> > Hence, the reason if there was already a pending IRQ triggered, the >> > dwc3_gadget_disable_irq() won't ensure the IRQ is handled. We can do >> > something like: >> > if (!is_on) >> >dwc3_gadget_disable_irq() >> > synchronize_irq() >> > spin_lock_irqsave() >> >

Re: [PATCH] usb: phy: tegra: Use IS_ERR() to check and simplify code

2020-09-24 Thread Felipe Balbi
Thierry Reding writes: > On Thu, Sep 24, 2020 at 10:26:15AM +0300, Felipe Balbi wrote: >> Tang Bin writes: >> >> > Use IS_ERR() and PTR_ERR() instead of PTR_ERR_OR_ZERO() to >> > simplify code, avoid redundant judgements. >> > >> > Signed-

Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root

2020-09-24 Thread Felipe Balbi
Hi, Chunfeng Yun writes: > On Thu, 2020-09-24 at 10:50 +0300, Felipe Balbi wrote: >> Chunfeng Yun writes: >> >> > Fix up the build error caused by undeclared usb_debug_root >> > >> > Cc: stable >> > Fixes: a66ada4f241c("usb: gadget: bc

Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root

2020-09-24 Thread Felipe Balbi
Chunfeng Yun writes: > Fix up the build error caused by undeclared usb_debug_root > > Cc: stable > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under > usb root") > Reported-by: kernel test robot > Signed-off-by: Chunfeng Yun $ patch -p1 --dry-run p.patch

Re: [PATCH v3] usb: dwc3: Stop active transfers before halting the controller

2020-09-24 Thread Felipe Balbi
Hi, Wesley Cheng writes: > On 9/6/2020 11:20 PM, Felipe Balbi wrote: >> >> Hi, >> >> Wesley Cheng writes: >>> diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c >>> index 59f2e8c31bd1..456aa87e8778 100644 >>> --- a/d

Re: [PATCH] usb: phy: tegra: Use IS_ERR() to check and simplify code

2020-09-24 Thread Felipe Balbi
Tang Bin writes: > Use IS_ERR() and PTR_ERR() instead of PTR_ERR_OR_ZERO() to > simplify code, avoid redundant judgements. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied for next merge window. Make sure to get this driver out of drivers/usb/phy and moved into drivers/phy

Re: [PATCH] MAINTAINERS: Add entry for Broadcom BDC driver

2020-09-24 Thread Felipe Balbi
Felipe Balbi writes: > Greg KH writes: > >> On Thu, Sep 17, 2020 at 02:49:54PM +0800, Chunfeng Yun wrote: >>> On Sun, 2020-09-06 at 12:55 -0700, Florian Fainelli wrote: >>> > >>> > On 7/9/2020 8:48 PM, Florian Fainelli wrote: >>> > &

Re: [PATCH] MAINTAINERS: Add entry for Broadcom BDC driver

2020-09-24 Thread Felipe Balbi
Greg KH writes: > On Thu, Sep 17, 2020 at 02:49:54PM +0800, Chunfeng Yun wrote: >> On Sun, 2020-09-06 at 12:55 -0700, Florian Fainelli wrote: >> > >> > On 7/9/2020 8:48 PM, Florian Fainelli wrote: >> > > The Broadcom BDC driver did not have a MAINTAINERS entry which made it >> > > escape review

Re: [PATCH 1/7] usb: mtu3: convert to devm_platform_ioremap_resource_byname

2020-09-24 Thread Felipe Balbi
Chunfeng Yun writes: > Hi Felip, > > > On Mon, 2020-09-07 at 10:42 +0300, Felipe Balbi wrote: >> Hi, >> >> Chunfeng Yun writes: >> > Use devm_platform_ioremap_resource_byname() to simplify code >> > >> > Signed-off-by: Chunfeng Yun

Re: [PATCH v2 1/2] dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3 Controller

2020-09-24 Thread Felipe Balbi
Rob Herring writes: > On Thu, Sep 10, 2020 at 12:33:04AM +0530, Manish Narani wrote: >> Add documentation for Versal DWC3 controller. Add required property >> 'reg' for the same. Also add optional properties for snps,dwc3. >> >> Signed-off-by: Manish Narani >> --- >>

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Felipe Balbi
hy-fsl-usb.c | 2 +- for the drivers above: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

RE: [PATCH 2/2] usb: dwc3: Add driver for Xilinx platforms

2020-09-09 Thread Felipe Balbi
Hi, Manish Narani writes: >> -Original Message- >> From: Felipe Balbi >> Sent: Tuesday, September 1, 2020 5:45 PM >> >> >> > + goto err; >> >> > + } >> >> > + >> >> >

Re: [PATCH v2] dwc3-of-simple: add support for Hikey 970

2020-09-08 Thread Felipe Balbi
Hi, Mauro Carvalho Chehab writes: >> Mauro Carvalho Chehab writes: >> > This binding driver is needed for Hikey 970 to work, >> > as otherwise a Serror is produced: >> >> you mentioned Serror doesn't happen anymore... >> >> > [1.837458] SError Interrupt on CPU0, code 0xbf02 --

Re: [PATCH v2] dwc3-of-simple: add support for Hikey 970

2020-09-08 Thread Felipe Balbi
Hi, Mauro Carvalho Chehab writes: > This binding driver is needed for Hikey 970 to work, > as otherwise a Serror is produced: you mentioned Serror doesn't happen anymore... > [1.837458] SError Interrupt on CPU0, code 0xbf02 -- SError > [1.837462] CPU: 0 PID: 74 Comm:

Re: [PATCH v2 10/11] dwc3-of-simple: add support for Hikey 970

2020-09-08 Thread Felipe Balbi
Mauro Carvalho Chehab writes: > Em Mon, 7 Sep 2020 17:59:34 +0200 > Mauro Carvalho Chehab escreveu: > >> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c >> b/drivers/usb/dwc3/dwc3-of-simple.c >> index 8852fbfdead4..2d497165efe2 100644 >> --- a/drivers/usb/dwc3/dwc3-of-simple.c >> +++

Re: [PATCH v2 1/3] dt-bindings: usb: Convert cdns-usb3.txt to YAML schema

2020-09-08 Thread Felipe Balbi
Hi, Roger Quadros writes: > Converts cdns-usb3.txt to YAML schema cdns,usb3.yaml > > Signed-off-by: Roger Quadros > --- > .../devicetree/bindings/usb/cdns,usb3.yaml| 89 +++ > .../devicetree/bindings/usb/cdns-usb3.txt | 45 -- Rob, should I wait for your Ack

Re: [PATCH v6 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2020-09-08 Thread Felipe Balbi
Hi, Mauro Carvalho Chehab writes: >> > I tested here, together with the Hikey 970 phy RFC patches I sent >> > last week. >> > >> > Without this patch, the USB HID driver receives -EPROTO from >> > submitted URBs, causing it to enter into an endless reset cycle >> > on every 500 ms, at the

Re: [PATCH v2 10/11] dwc3-of-simple: add support for Hikey 970

2020-09-08 Thread Felipe Balbi
Hi, Mauro Carvalho Chehab writes: > This binding driver is needed for Hikey 970 to work, > as otherwise a Serror is produced: > > [1.837458] SError Interrupt on CPU0, code 0xbf02 -- SError > [1.837462] CPU: 0 PID: 74 Comm: kworker/0:1 Not tainted 5.8.0+ #205 > [

Re: [PATCH v6 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2020-09-07 Thread Felipe Balbi
Hi Mauro, Mauro Carvalho Chehab writes: > Hi Felipe/Greg, > > What's the status of this patch? to be frank, I don't think I have this in my inbox anymore. > I tested here, together with the Hikey 970 phy RFC patches I sent > last week. > > Without this patch, the USB HID driver receives

Re: [PATCH v3] usb: dwc3: Add support for VBUS power control

2020-09-07 Thread Felipe Balbi
Hi, Mike Looijmans writes: > Met vriendelijke groet / kind regards, > > Mike Looijmans > System Expert > > > TOPIC Embedded Products B.V. > Materiaalweg 4, 5681 RJ Best > The Netherlands > > T: +31 (0) 499 33 69 69 > E: mike.looijm...@topicproducts.com > W: www.topicproducts.com > > Please

Re: [PATCH 1/7] usb: mtu3: convert to devm_platform_ioremap_resource_byname

2020-09-07 Thread Felipe Balbi
Hi, Chunfeng Yun writes: > Use devm_platform_ioremap_resource_byname() to simplify code > > Signed-off-by: Chunfeng Yun why is it so that your patches always come base64 encoded? They look fine on the email client, but when I try to pipe the message to git am it always gives me a lot of

Re: [PATCH v3] usb: dwc3: Stop active transfers before halting the controller

2020-09-07 Thread Felipe Balbi
Hi, Wesley Cheng writes: > diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c > index 59f2e8c31bd1..456aa87e8778 100644 > --- a/drivers/usb/dwc3/ep0.c > +++ b/drivers/usb/dwc3/ep0.c > @@ -197,7 +197,7 @@ int dwc3_gadget_ep0_queue(struct usb_ep *ep, struct > usb_request *request, >

Re: [PATCH 14/20] usb/phy: mxs-usb: Use pm_ptr() macro

2020-09-07 Thread Felipe Balbi
f the config. If unused, they will > simply be discarded by the compiler. > > Signed-off-by: Paul Cercueil > --- Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

RE: [PATCH 2/2] usb: dwc3: Add driver for Xilinx platforms

2020-09-01 Thread Felipe Balbi
Hi, (remember to break your lines at 80-columns) Manish Narani writes: >> > + goto err; >> > + } >> > + >> > + ret = dwc3_xlnx_rst_assert(priv_data->apbrst); >> > + if (ret < 0) { >> > + dev_err(dev, "%s: %d: Failed to assert reset\n", >> > + __func__,

Re: [PATCH] usb: gadget: aspeed: fixup vhub port irq handling

2020-08-31 Thread Felipe Balbi
Hi, Tao Ren writes: >> > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c >> > b/drivers/usb/gadget/udc/aspeed-vhub/core.c >> > index cdf96911e4b1..be7bb64e3594 100644 >> > --- a/drivers/usb/gadget/udc/aspeed-vhub/core.c >> > +++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c >> > @@

Re: [PATCH] usb: gadget: aspeed: fixup vhub port irq handling

2020-08-31 Thread Felipe Balbi
Hi, Tao Ren writes: > On Mon, Aug 17, 2020 at 04:49:32PM +0300, Felipe Balbi wrote: >> >> Hi, >> >> rentao.b...@gmail.com writes: >> > From: Tao Ren >> > >> > This is a follow-on patch for commit a23be4ed8f48 ("usb: gadget: aspe

Re: [PATCH] usb: gadget: aspeed: fixup vhub port irq handling

2020-08-31 Thread Felipe Balbi
Hi, Tao Ren writes: > On Mon, Aug 17, 2020 at 04:49:32PM +0300, Felipe Balbi wrote: >> >> Hi, >> >> rentao.b...@gmail.com writes: >> > From: Tao Ren >> > >> > This is a follow-on patch for commit a23be4ed8f48 ("usb: gadget: aspe

Re: [PATCH 1/1] USB: PHY: JZ4770: Fix static checker warning.

2020-08-27 Thread Felipe Balbi
周琰杰 (Zhou Yanjie) writes: > The commit 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new > Ingenic SoCs.") introduced the initialization function for different > chips, but left the relevant code involved in the resetting process > in the original function, resulting in uninitialized variable

Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register

2020-08-27 Thread Felipe Balbi
Hi, Paul Cercueil writes: > @@ -246,9 +241,8 @@ static void x1830_usb_phy_init(struct usb_phy > *phy) > USBPCR1_DMPD | USBPCR1_DPPD; > writel(reg, priv->base + REG_USBPCR1_OFFSET); > > - reg = USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT

Re: [PATCH 1/2] docs: process: Add cross-link to security-bugs

2020-08-27 Thread Felipe Balbi
nt to any public lists. See also > +:ref:`Documentation/admin-guide/security-bugs.rst `. > > Patches that fix a severe bug in a released kernel should be directed > toward the stable maintainers by putting a line like this:: > -- > 2.17.1 Reviewed-by: Felipe Balbi -- balbi

Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register

2020-08-27 Thread Felipe Balbi
Hi, Paul Cercueil writes: >>> @@ -172,7 +172,8 @@ static int ingenic_usb_phy_init(struct usb_phy >>> *phy) >>> return err; >>> } >>> >>> - priv->soc_info->usb_phy_init(phy); >>> + reg = priv->soc_info->usb_phy_init(phy); >>> + writel(reg, priv->base +

Re: [PATCH v3] usb: mtu3: fix panic in mtu3_gadget_stop()

2020-08-27 Thread Felipe Balbi
Macpaul Lin writes: > This patch fixes a possible issue when mtu3_gadget_stop() > already assigned NULL to mtu->gadget_driver during mtu_gadget_disconnect(). > > [] notifier_call_chain+0xa4/0x128 > [] __atomic_notifier_call_chain+0x84/0x138 > [] notify_die+0xb0/0x120 > [] die+0x1f8/0x5d0 > []

Re: [PATCH 3/3] usb: cdns3: Enable workaround for USB2.0 PHY Rx compliance test PHY lockup

2020-08-27 Thread Felipe Balbi
Hi, Roger Quadros writes: > From: Pawel Laszczak > > USB2.0 PHY hangs in Rx Compliance test when the incoming packet > amplitude is varied below and above the Squelch Level of Receiver > during the active packet multiple times. > >

  1   2   3   4   5   6   7   8   9   10   >