6 wakeups in 6.0 to only 3 with
this patch.
I can do some more tests.
>
> Cc: sta...@vger.kernel.org
> Fixes: 42fb0a1e84ff ("tracing/ring-buffer: Have polling block on watermark")
> Reported-by: Julia Lawall
> Signed-off-by: Steven Rostedt (Google)
Tested-by: Julia Lawall
ju
On Fri, 29 Sep 2023, Masami Hiramatsu wrote:
> On Thu, 28 Sep 2023 12:43:34 +0200
> Julia Lawall wrote:
>
> > Drop break after return.
> >
>
> Good catch! This looks good to me.
>
> Acked-by: Masami Hiramatsu (Google)
>
> And
>
> Fixes: 7491
Drop break after return.
Signed-off-by: Julia Lawall
---
kernel/trace/trace_eprobe.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
index 72714cbf475c..03c851f57969 100644
--- a/kernel/trace/trace_eprobe.c
Context mode is not supported, so the *s are just confusing to people
who use the rule outside of make coccicheck. So, drop the *s.
Fixes: 6dd9379e8f32 ("coccinelle: also catch kzfree() issues")
Reported-by: Fabio M. De Francesco
Signed-off-by: Julia Lawall
---
scripts/cocci
On Fri, 16 Apr 2021, Sakari Ailus wrote:
> On Fri, Apr 16, 2021 at 10:46:54AM +0200, Julia Lawall wrote:
> > > > If you're running into the 80 character limit, then it's fine to use
> > > > two tabs. I think we have been rejecting patches that push align the
>
> > If you're running into the 80 character limit, then it's fine to use
> > two tabs. I think we have been rejecting patches that push align the
> > parameters but push past the 80 character limit. Using one tab is
> > confusing because it makes the decalarations line up with the code.
>
>
> > > +#define ZR36057_JMC_JPG_EXP_MODE (0 << 29)
> > > +#define ZR36057_JMC_JPG_CMP_MODE BIT(29)
> > > +#define ZR36057_JMC_MJPG_EXP_MODE(2 << 29)
> > > +#define ZR36057_JMC_MJPG_CMP_MODE(3 << 29)
> > Same as above. Please change back
On Wed, 14 Apr 2021, Fabio M. De Francesco wrote:
> Removed useless led_blink_hdl() prototype and definition. In wlancmds[]
> the slot #60 is now set to NULL using the macro GEN_MLME_EXT_HANDLER. This
> change has not unwanted side effects because the code in rtw_cmd.c checks
> if the function
On Wed, 14 Apr 2021, Fabio M. De Francesco wrote:
> Removed struct LedBlink_param. Removed LedBlink entries in
> rtw_cmd_callback[] and in wlancmds[]. Everything related to LedBlink is
> not anymore needed. Removed extra blank lines in the two mentioned
> arrays and changend the numbers set in
On Wed, 14 Apr 2021, Dan Carpenter wrote:
> On Wed, Apr 14, 2021 at 11:06:02AM -0300, Aline Santana Cordeiro wrote:
> > Correct identation in block of conditional statements.
> > The function "v4l2_device_unregister_subdev()" depends on
> > the results of the macro function
On Wed, 14 Apr 2021, Mitali Borkar wrote:
> On Tue, Apr 13, 2021 at 09:17:12PM +0300, Dan Carpenter wrote:
> > On Tue, Apr 13, 2021 at 08:59:34PM +0530, Mitali Borkar wrote:
> > > Removed unnecessary space before tabs to adhere to linux kernel coding
> > > style.
> > > Reported by checkpatch.
On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> On Tuesday, April 13, 2021 8:57:20 PM CEST Julia Lawall wrote:
> > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > > On Tuesday, April 13, 2021 8:20:50 PM CEST Dan Carpenter wrote:
> > > > On Tue, Apr 13, 2
On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> On Tuesday, April 13, 2021 8:20:50 PM CEST Dan Carpenter wrote:
> > On Tue, Apr 13, 2021 at 06:47:06PM +0200, Fabio M. De Francesco wrote:
> > > On Tuesday, April 13, 2021 6:27:17 PM CEST Julia Lawall wrote:
> > > &
On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> On Tuesday, April 13, 2021 6:04:16 PM CEST Julia Lawall wrote:
> > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > > Removed the led_blink_hdl() function (declaration, definition, and
> > > caller code) be
On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> Removed the led_blink_hdl() function (declaration, definition, and
> caller code) because it's useless. It only seems to check whether or not a
> given pointer is NULL. There are other (simpler) means for that purpose.
>
> Signed-off-by:
On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> Removed "ledBlink_param" because it was set to the value of "pbuf" but was
> never reused. This set was made by direct assignment (no helper had been
> called), therefore it had no side effect to the location pointed by "pbuf".
>
>
On Tue, 13 Apr 2021, Fabio Aiuto wrote:
> Hi,
>
> I would like to improve the following coccinelle script:
>
> @@
> expression a, fmt;
> expression list var_args;
> @@
>
> - DBG_871X_LEVEL(a, fmt, var_args);
> + printk(fmt, var_args);
>
> I would replace the DBG_871X_LEVEL macro
On Tue, 13 Apr 2021, Mitali Borkar wrote:
> Declared 32 bit unsigned int as static constant inside a function
> appropriately.
I don't think that the description matches what is done. Perhaps all the
meaning is intended to be in the word "appropriately", but that is not
very clear. The
On Mon, 12 Apr 2021, ascordeiro wrote:
> Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu:
> > Hi Aline,
> >
> > On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote:
> > > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> > > > While testing on a device isn't a
On Mon, 12 Apr 2021, Greg KH wrote:
> On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote:
> > Hi Mitali,
> >
> > On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote:
> > > Added #include and replaced bit shifts by BIT() macro.
> > > This BIT() macro from linux/bitops.h is
nly the changed lines and a few lines before
and after.
> Signed-off-by: tawahpeggy
You need to put your real name when contributing to the Linux kernel.
For example, I would put:
Julia Lawall
julia
>
> ---
> drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
> 1 file changed, 0 insert
On Sun, 11 Apr 2021, Fabio M. De Francesco wrote:
> Remove variable "int ret" which is instantiated but not used.
instantiated -> declared? I thought instantiated could mean initialized,
but that doesn't seem to be the case.
julia
>
> Signed-off-by: Fabio M. De Francesco
> ---
>
On Sun, 11 Apr 2021, Fabio M. De Francesco wrote:
> On Sunday, April 11, 2021 11:51:32 AM CEST Julia Lawall wrote:
> > On Sun, 11 Apr 2021, Fabio M. De Francesco wrote:
> > > On Sunday, April 11, 2021 11:26:41 AM CEST Julia Lawall wrote:
> > > > On Sun, 11 Apr 202
On Sun, 11 Apr 2021, Mitali Borkar wrote:
> Removed unnecessary parentheses around '!xyz' boolean expression as '!' has
> higher
> precedance than '||'
The log message is too wide. It should be at most around 70 characters
wide, because git will indent it a little.
julia
>
>
On Sun, 11 Apr 2021, Fabio M. De Francesco wrote:
> On Sunday, April 11, 2021 11:26:41 AM CEST Julia Lawall wrote:
> > On Sun, 11 Apr 2021, Fabio M. De Francesco wrote:
> > > Change a controlling expression within an 'if' statement: don't compare
> > > with 'tr
On Sun, 11 Apr 2021, Fabio M. De Francesco wrote:
> Change a controlling expression within an 'if' statement: don't compare
> with 'true'.
>
> Signed-off-by: Fabio M. De Francesco
> ---
>
> Changes from v2: Rewrite subject in patch 0/4; remove a patch from the
> series because it had alreay
On Sat, 10 Apr 2021, Mitali Borkar wrote:
> Fixed pointer error by adding '*' to the function.
> Reported by Julia.
Actually, there is a proper tag for reported by, like Signed-off-by. Look
through the git history to see what to do.
julia
>
> Signed-off-by: Mitali Borkar
> ---
> Changes
On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> On Saturday, April 10, 2021 3:24:43 PM CEST Julia Lawall wrote:
> > On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> > > On Saturday, April 10, 2021 2:12:28 PM CEST Julia Lawall wrote:
> > > > On Sat, 10 A
> Mam, my new patch is ready but I am not sure how to send, the v1/2 is
> not on top, I have not made changes in it because it was not required. Now,
> how to
> send these two mails as a patchset, since in between these two git
> commits, I have another commits too.
Suppose you have
relevant
On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> On Saturday, April 10, 2021 2:12:28 PM CEST Julia Lawall wrote:
> > On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> > > On Saturday, April 10, 2021 1:37:30 PM CEST Julia Lawall wrote:
> > > > &g
On Sat, 10 Apr 2021, Mitali Borkar wrote:
> Fixed Comparison to NULL can be written as '!...' by replacing it with
> simpler form i.e. boolean expression. This makes code more readable
> alternative.
> Reported by checkpatch.
>
> Signed-off-by: Mitali Borkar
> ---
> Changes from v1:- added
On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> On Saturday, April 10, 2021 1:37:30 PM CEST Julia Lawall wrote:
> > > That variable has global scope and is assigned at least in:
> > What do you mean by global scope? None of the following look like
> > refere
On Sat, 10 Apr 2021, Mitali Borkar wrote:
> Fixed Comparison to NULL can be written as '!...' by replacing it with
> simpler form i.e boolean expression. This makes code more readable
> alternative.
> Reported by checkpatch.
>
> Signed-off-by: Mitali Borkar
> ---
>
On Sat, 10 Apr 2021, Mitali Borkar wrote:
> On Fri, Apr 09, 2021 at 10:12:12PM +0200, Julia Lawall wrote:
> >
> >
> > On Sat, 10 Apr 2021, Mitali Borkar wrote:
> >
> > > Removed comments from the same line and added them to new line above the
> > >
> That variable has global scope and is assigned at least in:
What do you mean by global scope? None of the following look like
references to global variables.
julia
>
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:368:
> pwrpriv->fw_current_in_ps_mode = false;
>
>
On Sat, 10 Apr 2021, Julia Lawall wrote:
>
>
> On Sat, 10 Apr 2021, Greg KH wrote:
>
> > On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote:
> > > Change the type of fw_current_in_ps_mode from u8 to bool, because
> > > it is used e
On Sat, 10 Apr 2021, Greg KH wrote:
> On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote:
> > Change the type of fw_current_in_ps_mode from u8 to bool, because
> > it is used everywhere as a bool and, accordingly, it should be
> > declared as a bool. Shorten the controlling
On Sat, 10 Apr 2021, Greg KH wrote:
> On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote:
> > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > > > This patch series removes camelcases,
On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > > This patch series removes camelcases, changes the type and use of a
> > > variable, and correct
On Sat, 10 Apr 2021, Mitali Borkar wrote:
> Replaced comparison to NULL by boolean expressions
> (here used boolean negations). This improves readability of code.
> Reported by checkpatch.
>
> Signed-off-by: Mitali Borkar
> ---
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +-
> 1
On Sat, 10 Apr 2021, Mitali Borkar wrote:
> No changes required in this patch.
> In v1:- Added spaces around '<<' operator to improve readability and meet
> linux kernel coding
> style
The text above would go in the git history. "No changes required in this
patch." doesn't make sense in
On Sat, 10 Apr 2021, Mitali Borkar wrote:
> Removed comments from the same line and added them to new line above the
> blocks, aligned everything properly by using tabs to make code neater
> and improve readability.
>
> Signed-off-by: Mitali Borkar
> ---
>
On Thu, 8 Apr 2021, Ezequiel Garcia wrote:
> Ola Aline,
>
> Welcome to the kernel community. Hope you enjoy some of this
> Outreachy adventures.
>
> Normally, when you submit a v2, we want to know what changed
> between the first submission and v2.
>
> If you are subscribed to linux-media, you
On Fri, 9 Apr 2021, Mitali Borkar wrote:
> On Fri, Apr 09, 2021 at 09:23:22AM +0200, Hans Verkuil wrote:
> > Hi Mitali,
> >
> > On 08/04/2021 22:38, Mitali Borkar wrote:
> > > Added spaces around '<<' operator to improve readability and meet linux
> > > kernel coding style.
> > > Reported by
On Fri, 9 Apr 2021, ascordeiro wrote:
> Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu:
> > Hi Aline,
>
> Hi Ezequiel,
> >
> > On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro wrote:
> > > Rewrite macros resembling functions #define HANTRO_PP_REG_WRITE
> > > and #define
On Fri, 9 Apr 2021, Fabio M. De Francesco wrote:
> On Friday, April 9, 2021 4:12:37 PM CEST Greg KH wrote:
> > On Thu, Apr 08, 2021 at 01:19:42PM +0200, Fabio M. De Francesco wrote:
> > > Change the type of fw_current_in_ps_mode from u8 to bool, because
> > > it is used everywhere as a bool
On Fri, 9 Apr 2021, Mitali Borkar wrote:
> On Fri, Apr 09, 2021 at 09:23:22AM +0200, Hans Verkuil wrote:
> > Hi Mitali,
> >
> > On 08/04/2021 22:38, Mitali Borkar wrote:
> > > Added spaces around '<<' operator to improve readability and meet linux
> > > kernel coding style.
> > > Reported by
On Fri, 9 Apr 2021, Fabio M. De Francesco wrote:
> Remove camelcase in bFwCurrentInPSMode, a variable used by code
> of several subdirectories/files of the driver. Issue detected by
> checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from
> the beginning of the name.
I'm
On Fri, 9 Apr 2021, Fabio M. De Francesco wrote:
> Remove camelcase in bFwCurrentInPSMode, a variable used by code
> of several subdirectories/files of the driver. Issue detected by
> checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from
> the beginning of the name.
Isn't
On Fri, 9 Apr 2021, Mitali Borkar wrote:
> On Fri, Apr 09, 2021 at 12:10:06AM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 9 Apr 2021, Mitali Borkar wrote:
> >
> > > On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote:
> > > >
> &g
On Fri, 9 Apr 2021, Mitali Borkar wrote:
> On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 9 Apr 2021, Mitali Borkar wrote:
> >
> > > Added #include and replaced bit shifts by BIT() macro.
> > > This BIT(
On Fri, 9 Apr 2021, Mitali Borkar wrote:
> Added spaces around '<<' operator to improve readability and meet linux
> kernel coding style.
> Reported by checkpatch
>
> Signed-off-by: Mitali Borkar
> ---
> drivers/staging/media/zoran/zr36057.h | 14 +++---
> 1 file changed, 7
On Fri, 9 Apr 2021, Mitali Borkar wrote:
> Added #include and replaced bit shifts by BIT() macro.
> This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_*
> bitmasks.
> Use of macro is better and neater. It maintains consistency.
> Reported by checkpatch.
>
> Signed-off-by:
On Thu, 8 Apr 2021, Fabio M. De Francesco wrote:
> Remove camelcase in bFwCurrentInPSMode, a variable used by code
> of several subdirectories/files of the driver. Issue detected by
> checkpatch.pl.
It could be reasonable to mention the removal of b in the log message.
julia
>
>
On Thu, 8 Apr 2021, Fabio M. De Francesco wrote:
> On Thursday, April 8, 2021 10:36:32 AM CEST Greg KH wrote:
> > On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote:
> > > Remove camelcase in a symbol that is used by several files.
> >
> > What symbol?
> >
>
> I'm not sure I
On Thu, 8 Apr 2021, Fabio M. De Francesco wrote:
> Remove camelcase in a symbol that is used by several files.
In addition to Greg's suggestion about dropping the b, there are some more
things you can do to improve the usage of this field.
First, I noticed that the type is u8. It can be
The subject line should be in the imperative, so "add" instead of "added".
On Thu, 8 Apr 2021, Mitali Borkar wrote:
> Clean up Check:spaces preferred around that '+' (ctx:VxV)
> Reported by checkpatch
Please try to rephrase to explain what you did and why. "Clean up" kind
of states what the
From: kernel test robot
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Liam Beguin
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
url:
https://github.com/0day-ci/linux/commits/Liam-Beguin/add
From: kernel test robot
For_each_child_of_node should have of_node_put() before goto.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Liam Beguin
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
url:
https://github.com
On Wed, 7 Apr 2021, Jan Kara wrote:
> On Tue 06-04-21 22:49:26, Julia Lawall wrote:
> > From: kernel test robot
> >
> > Opportunity for min().
> >
> > Generated by: scripts/coccinelle/misc/minmax.cocci
> >
> > Fixes: 8636e3295ce3 ("coccinell
On Wed, 7 Apr 2021, Beatriz Martins de Carvalho wrote:
>
> Em 01/04/21 16:28, Matthew Wilcox escreveu:
> > On Thu, Apr 01, 2021 at 04:07:38PM +0100, Beatriz Martins de Carvalho wrote:
> > > diff --git a/drivers/staging/media/omap4iss/iss.c
> > > b/drivers/staging/media/omap4iss/iss.c
> > >
From: kernel test robot
Opportunity for min().
Generated by: scripts/coccinelle/misc/minmax.cocci
Fixes: 8636e3295ce3 ("coccinelle: misc: add minmax script")
CC: Denis Efremov
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
tre
On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> Added spaces around operators in file HalBtc8723b2Ant.c. Issue detected
> by checkpatch.pl. Spaces are preferred to improve readibility.
You don't usually need the file name in the subject line or the commit
message. One can easily see the
On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:
> Added spaces around operators in file HalBtc8723b1Ant.h. Issue detected
> by checkpatch.pl. Spaces are preferred to improve readibility.
>
> Signed-off-by: Fabio M. De Francesco
> ---
> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h | 2 +-
On Tue, 6 Apr 2021, FMDF wrote:
> On Tue, Apr 6, 2021 at 4:11 PM Greg KH wrote:
> >
> > On Tue, Apr 06, 2021 at 03:05:56PM +0200, Fabio M. De Francesco wrote:
> > > Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols
> > > are not used anywhere else, therefore this patch
On Tue, 6 Apr 2021, Zhansaya Bagdauletkyzy wrote:
> Replace NULL comparisons with boolean negation.
This summarizes concisely what you did, which is helpful, but you could
also say why. For example, to make the code more concise or to improve
readability or for consistency with the rest of
On Mon, 5 Apr 2021, Beatriz Martins de Carvalho wrote:
> Cleans up checks of "Alignment should match open parenthesis"
> in file rtw_ap.c
>
> Signed-off-by: Beatriz Martins de Carvalho
>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 16
> 1 file changed, 8
On Mon, 5 Apr 2021, Beatriz Martins de Carvalho wrote:
>
> Em 01/04/21 22:16, Julia Lawall escreveu:
> >
> > On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote:
> >
> > > Cleans up check of "Lines should not end with a '('"
> > > w
There is a clear use after free on line 213.
julia
-- Forwarded message --
Date: Sat, 3 Apr 2021 04:42:45 +0800
From: kernel test robot
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall
Subject: Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver
CC: kbuild
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
hack/m1-pcie
head: 1fd2c9634dd24fba323baba52200de18e4d3f4ee
commit: ce67d3b3ef3734925631ec65deb1cf8078d826cf [14/15] iommu: dart: Add DART
io
On Sun, 28 Mar 2021, Denis Efremov wrote:
> Ping?
Applied. Thanks.
>
> On 3/5/21 1:09 PM, Denis Efremov wrote:
> > Check for opencoded swap() implementation.
> >
> > Signed-off-by: Denis Efremov
> > ---
> > Changes in v2:
> > - additional patch rule to drop excessive {}
> > - fix
On Sat, 3 Apr 2021, Deborah Brouwer wrote:
> On Sat, Apr 03, 2021 at 11:16:16PM +0200, Julia Lawall wrote:
> >
> >
> > On Sat, 3 Apr 2021, Deborah Brouwer wrote:
> >
> > > Add a comma to separate repeated words in a comment. The comma preserves
> &g
On Sat, 3 Apr 2021, Deborah Brouwer wrote:
> To conform with Linux kernel coding style, replace goto statement that
> does no cleanup with a direct return. To preserve meaning, copy comments
> from the original goto statement to the return statement. Identified by
> the checkpatch warning:
On Sat, 3 Apr 2021, Deborah Brouwer wrote:
> Add a comma to separate repeated words in a comment. The comma preserves
> the meaning of the comment while also stopping the checkpatch warning:
> WARNING: Possible repeated word: 'very'.
Thanks. That is more understandable. Isn't this a v2? If
From: kernel test robot
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 37439a51ff17 ("drm/amdgpu: Add mode2 reset support for aldebaran")
CC: Lijo Lazar
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Ju
On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote:
> Cleans up check of "Lines should not end with a '('"
> with argument present in next line in file emxx_udc.c
The coding style documentation encourages remaining within 80 characters.
I'm not sure that the ( warning is worth increading
On Wed, 31 Mar 2021, Beatriz Martins de Carvalho wrote:
> Fix checkpatch check "CHECK: Lines should not end with a '('"
> in arche-platform.c:80 and arche-platform.c:184.
Please try to express what you have done and why, without using the word
Fix. "Fix" doesn't explain what you have done.
On Wed, 31 Mar 2021, Deborah Brouwer wrote:
> Fix checkpatch warning:
> WARNING: Possible repeated word: 'very'
This is a simple but clear example of how "Fix" doesn't help one
understand the patch. In reading the log message, one would probably
assume that you removed the repetition, but
On Wed, 31 Mar 2021, Deborah Brouwer wrote:
> Fix checkpatch warning:
> WARNING: Block comments use * on subsequent lines
Try to find some way to express what you are doing without using Fix.
It's pretty obvious that a patch fixes something, so the work Fix is not
very useful. What is your
On Wed, 31 Mar 2021, Deborah Brouwer wrote:
> Remove empty comment instead of fixing the checkpatch warning that it was
> generating.
Maybe it woudl be better to focus on the purpose of what you are doing.
Something like:
Remove empty comment, which provides no information.
julia
>
>
Signed-off-by: Julia Lawall
---
cygnus-ssp.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/sound/soc/bcm/cygnus-ssp.c
+++ b/sound/soc/bcm/cygnus-ssp.c
@@ -1348,8 +1348,10 @@ static int cygnus_ssp_probe(struct platf
_ssp_dai[active_
From: kernel test robot
Opportunity for min()
Generated by: scripts/coccinelle/misc/minmax.cocci
CC: Denis Efremov
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
sit.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
On Mon, 8 Mar 2021, Denis Efremov wrote:
> Remove the documentation link from the warning message because commit
> 3942ea7a10c9 ("deprecated.rst: Remove now removed uninitialized_var")
> removed the section from documentation. Update the rule documentation
> accordingly.
>
> Signed-off-by:
On Mon, 8 Mar 2021, Denis Efremov wrote:
> Skip patches generation for structs/unions with a single field.
> Changing a zero-length array to a flexible array member in a struct
> with no named members breaks the compilation. However, reporting
> such cases is still valuable, e.g. commit
rted-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 812da4d39463a060738008a46cfc9f775e4bfcf6
commit: 82c2d81361ecd142a54e84a9da1e287113314a4f coccinelle: iterators: Add
On Tue, 9 Mar 2021, Denis Efremov wrote:
> Check for opencoded min(), max() implementations.
>
> Signed-off-by: Denis Efremov
Applied, thanks.
julia
> ---
> Changes in v2:
> - <... ...> instead of ... when any
> - org mode reports fixed
> - patch rule to drop excessive ()
> Changes in
On Fri, 19 Mar 2021, Evan Benn wrote:
> Hello,
>
> I am attempting to create a coccinelle script that will detect possibly buggy
> usage of the bitwise operators where integer promotion may result in bugs,
> usually due to sign extension.
>
> I know this script needs a lot more work, but I am
From: kernel test robot
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
CC: Denis Efremov
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux/kernel
CC: Denis Efremov
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
v2: reference the correct commit for Fixes
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 144c79ef33536b4ecb4951e07dbc1f2b7fa99
On Tue, 9 Mar 2021, Greg Kroah-Hartman wrote:
> On Mon, Mar 08, 2021 at 06:47:19PM +0100, Julia Lawall wrote:
> > From: kernel test robot
> >
> > Zero-length and one-element arrays are deprecated, see
> > Documentation/process/deprecated.rst
> > Flexible-arr
> +@pmaxif depends on patch@
> +identifier func;
> +expression x, y;
> +expression max_val;
> +binary operator cmp = {>=, >};
> +@@
> +
> +func(...)
> +{
> + <...
> +-if ((x) cmp (y)) {
> +-max_val = (x);
> +-} else {
> +-max_val = (y);
> +-}
> ++max_val
cript")
CC: Denis Efremov
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 144c79ef33536b4ecb4951e07dbc1f2b7fa99
On Sun, 7 Mar 2021, Joe Perches wrote:
> On Sun, 2021-03-07 at 20:14 +0100, Julia Lawall wrote:
> >
> > On Wed, 3 Mar 2021, Joe Perches wrote:
> >
> > > On Wed, 2021-03-03 at 10:41 +0100, Rasmus Villemoes wrote:
> > > > On 02/03/2021 18.42, Joe P
On Wed, 3 Mar 2021, Joe Perches wrote:
> On Wed, 2021-03-03 at 10:41 +0100, Rasmus Villemoes wrote:
> > On 02/03/2021 18.42, Joe Perches wrote:
> > > Here is a possible opportunity to reduce data usage in the kernel.
> > >
> > > $ git grep -P -n
On Fri, 19 Feb 2021, Denis Efremov wrote:
> Check for opencoded min(), max() implementations.
>
> Signed-off-by: Denis Efremov
> ---
>
> Changes in v2:
> - <... ...> instead of ... when any
> - org mode reports fixed
> - patch rule to drop excessive ()
>
>
No need for a return after a break;
Signed-off-by: Julia Lawall
---
drivers/media/usb/b2c2/flexcop-usb.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/b2c2/flexcop-usb.c
b/drivers/media/usb/b2c2/flexcop-usb.c
index e731243267e4..01d22834f4ac 100644
--- a/drivers
On Fri, 19 Feb 2021, Denis Efremov wrote:
> Check for opencoded swap() implementation.
>
> Signed-off-by: Denis Efremov
> ---
> Changes in v2:
> - additional patch rule to drop excessive {}
> - fix indentation in patch mode by anchoring ;
>
> scripts/coccinelle/misc/swap.cocci | 101
On Tue, 2 Mar 2021, Bernd Petrovitsch wrote:
> Hi all!
>
> On 02/03/2021 18:42, Joe Perches wrote:
> [...]
> > - For instance: (head -10 of the git grep for file statics)
> >
> > drivers/accessibility/speakup/keyhelp.c:18:static u_short masks[] = { 32,
> > 16, 8, 4, 2, 1 };
> >
On Tue, 2 Mar 2021, Joe Perches wrote:
> Here is a possible opportunity to reduce data usage in the kernel.
Does it actually reduce data usage?
julia
>
> $ git grep -P -n '^static\s+(?!const|struct)(?:\w+\s+){1,3}\w+\s*\[\s*\]'
> drivers/ | \
> grep -v __initdata | \
> wc -l
> 3250
>
>
, Julia Lawall
Subject: [PATCH] PM / devfreq: fix odd_ptr_err.cocci warnings
CC: kbuild-...@lists.01.org
TO: Saravana Kannan
CC: Chanwoo Choi
CC: Sibi Sankar
CC: MyungJoo Ham
CC: Kyungmin Park
CC: linux...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
From: kernel test robot
drivers/devfreq
1 - 100 of 7749 matches
Mail list logo
