Hi Christophe,
On 31.01.2024 21:07, Christophe Leroy wrote:
> Le 31/01/2024 à 16:17, Marek Szyprowski a écrit :
>> [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com.
>> Découvrez pourquoi ceci est important à
>> https://aka.ms/LearnAbou
Hi Christophe,
On 31.01.2024 12:58, Christophe Leroy wrote:
> Le 30/01/2024 à 18:48, Marek Szyprowski a écrit :
>> [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com.
>> Découvrez pourquoi ceci est important à
>> https://aka.ms/LearnAbou
__arm64_sys_finit_module+0x64/0xa0
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0xc0/0xe0
do_el0_svc+0x1c/0x28
el0_svc+0x4c/0xe4
el0t_64_sync_handler+0xc0/0xc4
el0t_64_sync+0x190/0x194
Code: 9116e003 f942dc01 a93e8c41 c89ffc73 (f9000433)
---[ end trace ]---
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
>si_pid;
> to->si_uid = from->si_uid;
> @@ -3421,6 +3427,10 @@ static int
> post_copy_siginfo_from_user32(kernel_siginfo_t *to,
> #endif
> to->si_pkey = from->si_pkey;
> break;
> + case SIL_PERF_EVENT:
> + to->si_addr = compat_ptr(from->si_addr);
> + to->si_perf = from->si_perf;
> + break;
> case SIL_CHLD:
> to->si_pid= from->si_pid;
> to->si_uid= from->si_uid;
> @@ -4601,6 +4611,7 @@ static inline void siginfo_buildtime_checks(void)
> CHECK_OFFSET(si_lower);
> CHECK_OFFSET(si_upper);
> CHECK_OFFSET(si_pkey);
> + CHECK_OFFSET(si_perf);
>
> /* sigpoll */
> CHECK_OFFSET(si_band);
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
On 20.04.2021 09:03, Krzysztof Kozlowski wrote:
> On 20/04/2021 07:25, Marek Szyprowski wrote:
>> On 19.04.2021 10:17, Krzysztof Kozlowski wrote:
>>> Use of_device_get_match_data() to make the code slightly smaller.
>>>
>>> Signed-off-by: Krzysztof Kozlowski
&
Does it make any sense to keep the #ifdef CONFIG_OF after this change? I
would also skip (i2c->dev.of_node) check, because
of_device_get_match_data() already does that (although indirectly).
> return id->driver_data;
> }
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
On 08.04.2021 22:16, Krzysztof Kozlowski wrote:
> The initialization of 'fault_addr' local variable is not needed as it is
> shortly after overwritten.
>
> Addresses-Coverity: Unused value
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Marek Szyprowski
> ---
> drivers
gt; https://lore.kernel.org/linux-iio/CA+U=DsrsvGgXEF30-vXuXS_k=-mjsjibweezwkb1hjvn1p9...@mail.gmail.com/T/#u
>
> Fixes: 15097c7a1adc ("iio: buffer: wrap all buffer attributes into
> iio_dev_attr")
> Reported-by: Marek Szyprowski
> Signed-off-by: Alexandru Ardelean
> ---
>
&
attr_list(>scan_el_dev_attr_list);
> + iio_free_chan_devattr_list(>buffer_attr_list);
>
> return ret;
> }
> @@ -1443,7 +1467,7 @@ static void __iio_buffer_free_sysfs_and_mask(struct
> iio_buffer *buffer)
> bitmap_free(buffer->scan_mask);
> kfree(buffer->buffer_group.name);
> kfree(buffer->buffer_group.attrs);
> - iio_free_chan_devattr_list(>scan_el_dev_attr_list);
> + iio_free_chan_devattr_list(>buffer_attr_list);
> }
>
> void iio_buffer_free_sysfs_and_mask(struct iio_dev *indio_dev)
> diff --git a/include/linux/iio/buffer_impl.h b/include/linux/iio/buffer_impl.h
> index 3e555e58475b..41044320e581 100644
> --- a/include/linux/iio/buffer_impl.h
> +++ b/include/linux/iio/buffer_impl.h
> @@ -97,8 +97,8 @@ struct iio_buffer {
> /* @scan_timestamp: Does the scan mode include a timestamp. */
> bool scan_timestamp;
>
> - /* @scan_el_dev_attr_list: List of scan element related attributes. */
> - struct list_head scan_el_dev_attr_list;
> + /* @buffer_attr_list: List of buffer attributes. */
> + struct list_head buffer_attr_list;
>
> /*
>* @buffer_group: Attributes of the new buffer group.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
On 26.03.2021 18:05, Marek Szyprowski wrote:
> On 25.03.2021 21:19, Bjorn Helgaas wrote:
>> On Thu, Mar 25, 2021 at 10:24:28AM +0100, Marek Szyprowski wrote:
>>> On 25.01.2021 05:48, Zhiqiang Hou wrote:
>>>> From: Hou Zhiqiang
>>>>
>>>> In
On 25.03.2021 21:19, Bjorn Helgaas wrote:
> On Thu, Mar 25, 2021 at 10:24:28AM +0100, Marek Szyprowski wrote:
>> On 25.01.2021 05:48, Zhiqiang Hou wrote:
>>> From: Hou Zhiqiang
>>>
>>> In the dw_pcie_ep_init(), it depends on the detected iATU region
>>&g
it(). Additionally, checking of
> priv->dma_cap.fpesel is added before calling stmmac_fpe_link_state_handle()
> as only FPE supported SoC is allowed to call the function.
>
> Below is the kernel panic dump reported by Marek Szyprowski
> :
>
> meson8b-dwmac ff3f.ethernet eth0: PHY [0.
4f1b6b97e ("clk: bcm: rpi: Add DT provider for the clocks")
> Reported-by: Marek Szyprowski
> Signed-off-by: Nicolas Saenz Julienne
Tested-by: Marek Szyprowski
> ---
> drivers/clk/bcm/clk-raspberrypi.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
iv->plat->est,
> priv->plat->clk_ptp_rate);
> @@ -845,12 +853,29 @@ static int tc_setup_taprio(struct stmmac_priv *priv,
> }
>
> netdev_info(priv->dev, "configured EST\n");
> +
> + if (fpe) {
> + stmmac_fpe_handshake(priv, true);
> + netdev_info(priv->dev, "start FPE handshake\n");
> + }
> +
> return 0;
>
> disable:
> priv->plat->est->enable = false;
> stmmac_est_configure(priv, priv->ioaddr, priv->plat->est,
>priv->plat->clk_ptp_rate);
> +
> + priv->plat->fpe_cfg->enable = false;
> + stmmac_fpe_configure(priv, priv->ioaddr,
> + priv->plat->tx_queues_to_use,
> + priv->plat->rx_queues_to_use,
> + false);
> + netdev_info(priv->dev, "disabled FPE\n");
> +
> + stmmac_fpe_handshake(priv, false);
> + netdev_info(priv->dev, "stop FPE handshake\n");
> +
> return ret;
> }
>
> diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> index 10abc80b601e..072f269b1618 100644
> --- a/include/linux/stmmac.h
> +++ b/include/linux/stmmac.h
> @@ -144,6 +144,32 @@ struct stmmac_txq_cfg {
> int tbs_en;
> };
>
> +/* FPE link state */
> +enum stmmac_fpe_state {
> + FPE_STATE_OFF = 0,
> + FPE_STATE_CAPABLE = 1,
> + FPE_STATE_ENTERING_ON = 2,
> + FPE_STATE_ON = 3,
> +};
> +
> +/* FPE link-partner hand-shaking mPacket type */
> +enum stmmac_mpacket_type {
> + MPACKET_VERIFY = 0,
> + MPACKET_RESPONSE = 1,
> +};
> +
> +enum stmmac_fpe_task_state_t {
> + __FPE_REMOVING,
> + __FPE_TASK_SCHED,
> +};
> +
> +struct stmmac_fpe_cfg {
> + bool enable;/* FPE enable */
> + bool hs_enable; /* FPE handshake enable */
> + enum stmmac_fpe_state lp_fpe_state; /* Link Partner FPE state */
> + enum stmmac_fpe_state lo_fpe_state; /* Local station FPE state */
> +};
> +
> struct plat_stmmacenet_data {
> int bus_id;
> int phy_addr;
> @@ -155,6 +181,7 @@ struct plat_stmmacenet_data {
> struct device_node *mdio_node;
> struct stmmac_dma_cfg *dma_cfg;
> struct stmmac_est *est;
> + struct stmmac_fpe_cfg *fpe_cfg;
> int clk_csr;
> int has_gmac;
> int enh_desc;
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
uct device_node *np,
> if (ret < 0)
> of_clk_del_provider(np);
>
> + fwnode_dev_initialized(>fwnode, true);
> +
> return ret;
> }
> EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
int dw_pcie_prog_inbound_atu(struct dw_pcie *pci, u8
> func_no, int index,
> void dw_pcie_disable_atu(struct dw_pcie *pci, int index,
>enum dw_pcie_region_type type);
> void dw_pcie_setup(struct dw_pcie *pci);
> +void dw_pcie_iatu_detect(struct dw_pcie *pci);
>
> static inline void dw_pcie_writel_dbi(struct dw_pcie *pci, u32 reg, u32 val)
> {
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
events/dwc3/dwc3_complete_trb/enable
>>> echo 1 >
>>> /sys/kernel/debug/tracing/instances/usb/events/dwc3/dwc3_ctrl_req/enable
>>> echo 1 >
>>> /sys/kernel/debug/tracing/instances/usb/events/dwc3/dwc3_ep_dequeue/enable
>>> echo 1 >
>>>
Hi Saravana,
On 05.03.2021 19:02, Saravana Kannan wrote:
> On Fri, Mar 5, 2021 at 3:45 AM Marek Szyprowski
> wrote:
>> On 04.03.2021 20:51, Saravana Kannan wrote:
>>> The uevents generated for an amba device need PID and CID information
>>> that's available only w
son
> Cc: John Stultz
> Cc: Saravana Kannan
> Cc: Linus Walleij
> Cc: Sudeep Holla
> Cc: Nicolas Saenz Julienne
> Cc: Geert Uytterhoeven
> Cc: Marek Szyprowski
> Cc: Russell King
> Signed-off-by: Saravana Kannan
> ---
>
> v1 -> v2:
> - Dropped RFC
p_table: opp-table5 {
> compatible = "operating-points-v2";
> + opp-shared;
>
> opp-1 {
> opp-hz = /bits/ 64 <1>;
> @@ -544,6 +549,7 @@
>
> bus_peri_opp_table: opp-table6 {
> compatible = "operating-points-v2";
> + opp-shared;
>
> opp-5000 {
> opp-hz = /bits/ 64 <5000>;
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
> clocks:
> description:
> Phandle to ADC bus clock. For Exynos3250 additional clock is needed.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
ek
Right, I'm really sorry for this regression.
Acked-by: Marek Szyprowski
> ---
> drivers/misc/fastrpc.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index 70eb5ed942d0..f12e909034ac 100644
>
through 8 update different frameworks to use the new API.
This patchset fixes probing issue observed on various Exynos based
boards even with commit c09a3e6c97f0 ("soc: samsung: pm_domains: Convert
to regular platform driver") reverted. Thanks!
Tested-by: Marek Szyprowski
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
, 2021 at 2:20 AM Geert Uytterhoeven
>>>> wrote:
>>>>> On Fri, Feb 5, 2021 at 11:06 AM Saravana Kannan
>>>>> wrote:
>>>>>> On Fri, Feb 5, 2021 at 12:06 AM Geert Uytterhoeven
>>>>>> wrote:
>>>>>>> On
Hi Saravana,
On 04.02.2021 22:31, Saravana Kannan wrote:
> On Thu, Feb 4, 2021 at 3:52 AM Marek Szyprowski
> wrote:
>> On 21.01.2021 23:57, Saravana Kannan wrote:
>>> This allows fw_devlink to create device links between consumers of an
>>> interrupt and the supplie
(the mmci@5 device
defined in arch/arm64/boot/dts/arm/juno-motherboard.dtsi). I didn't
check further what's wrong there as without MMC mounting rootfs fails in
my test system.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Hi Saravana,
On 01.02.2021 10:02, Saravana Kannan wrote:
> On Mon, Feb 1, 2021 at 12:05 AM Marek Szyprowski
> wrote:
>> On 30.01.2021 05:08, Saravana Kannan wrote:
>>> On Fri, Jan 29, 2021 at 8:03 PM Saravana Kannan
>>> wrote:
>>>> This patch series
the issue for a modular kernel,
> that'd be good too.
I've checked those patches on top of linux next-20210129 with
c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform
driver") commit reverted. Sadly it doesn't help. All devices that belong
to the Exynos power domains are never probed and stay endlessly on the
deferred devices list. I've used static kernel build - the one from
exynos_defconfig.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
t | 2 +-
> MAINTAINERS | 2 +-
> 19 files changed, 225 insertions(+), 108 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/pci/designware,pcie.yaml
> delete mode 100644 Documentation/devicetree/bindings/pci/designware-pcie.txt
> ...
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Hi Mark,
On 21.01.2021 16:44, Mark Brown wrote:
> On Thu, Jan 21, 2021 at 10:41:59AM +0100, Marek Szyprowski wrote:
>> On 18.01.2021 21:49, Mark Brown wrote:
>>> Does this help (completely untested):
>> Sadly nope. I get same warning:
> Try this instead:
>
> diff
g you in the "To" because this patch won't
> work for your issues.
>
> Cc: Marek Szyprowski
> Cc: Geert Uytterhoeven
> Cc: Marc Zyngier
> Signed-off-by: Saravana Kannan
> ---
> drivers/base/base.h | 3 ++
> drivers/base/core.c | 117 ++
Hi Mark,
On 18.01.2021 21:49, Mark Brown wrote:
> On Tue, Jan 12, 2021 at 10:34:19PM +0100, Marek Szyprowski wrote:
>> ==
>> WARNING: possible circular locking dependency detected
>> 5.11.0-rc1-8-geaa7995c52
Hi Saravana,
On 13.01.2021 21:27, Saravana Kannan wrote:
> On Wed, Jan 13, 2021 at 3:03 AM Marek Szyprowski
> wrote:
>> When Exynos power domain driver was introduced, the only way to ensure
>> that power domains will be instantiated before the devices which belongs
>> t
Hi Saravana,
On 13.01.2021 20:23, Saravana Kannan wrote:
> On Tue, Jan 12, 2021 at 11:04 PM Marek Szyprowski
> wrote:
>> On 12.01.2021 21:51, Saravana Kannan wrote:
>>> On Mon, Jan 11, 2021 at 11:11 PM Marek Szyprowski
>>> wrote:
>>>> On 11.01.2021
to convert Exynos
power domain driver to regular platform driver.
This is also required by the mentioned commit to enable probing any
device which belongs to the Exynos power domains, as otherwise the core
won't notice that the power domains are in fact available.
Signed-off-by: Marek Szyprowski
---
Hi Saravana,
On 12.01.2021 21:51, Saravana Kannan wrote:
> On Mon, Jan 11, 2021 at 11:11 PM Marek Szyprowski
> wrote:
>> On 11.01.2021 22:47, Saravana Kannan wrote:
>>> On Mon, Jan 11, 2021 at 6:18 AM Marek Szyprowski
>>> wrote:
>>>> O
ret = set_supply(rdev, r);
> if (ret < 0) {
> put_device(>dev);
> - return ret;
> + goto out;
> }
>
> /*
> @@ -1886,11 +1901,13 @@ static int regulator_resolve_supply(struct
> regulator_dev *rdev)
> if (ret < 0) {
> _regulator_put(rdev->supply);
> rdev->supply = NULL;
> - return ret;
> + goto out;
> }
> }
>
> - return 0;
> +out:
> + regulator_unlock(rdev);
> + return ret;
> }
>
> /* Internal regulator request function */
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
On 11.01.2021 22:47, Saravana Kannan wrote:
> On Mon, Jan 11, 2021 at 6:18 AM Marek Szyprowski
> wrote:
>> On 11.01.2021 12:12, Marek Szyprowski wrote:
>>> On 18.12.2020 04:17, Saravana Kannan wrote:
>>>> Cyclic dependencies in some firmware was one of the last
On 11.01.2021 12:12, Marek Szyprowski wrote:
> On 18.12.2020 04:17, Saravana Kannan wrote:
>> Cyclic dependencies in some firmware was one of the last remaining
>> reasons fw_devlink=on couldn't be set by default. Now that cyclic
>> dependencies don't block probing, set fw_
(FW_DEVLINK_FLAGS_ON | \
>DL_FLAG_PM_RUNTIME)
>
> -static u32 fw_devlink_flags = FW_DEVLINK_FLAGS_PERMISSIVE;
> +static u32 fw_devlink_flags = FW_DEVLINK_FLAGS_ON;
> static int __init fw_devlink_setup(char *arg)
> {
> if (!arg)
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
0 (CS3 space),
> i.e. not at a multiple of 128 MiB.
>
> Suggested-by: Nicolas Pitre
> Suggested-by: Ard Biesheuvel
> Signed-off-by: Geert Uytterhoeven
> Reviewed-by: Ard Biesheuvel
> Acked-by: Nicolas Pitre
I've checked all of my arm 32bit test systems and they still boot fine
wi
On 21.12.2020 08:55, Krzysztof Kozlowski wrote:
> On Mon, Dec 21, 2020 at 08:36:02AM +0100, Marek Szyprowski wrote:
>> On 18.12.2020 15:22, Krzysztof Kozlowski wrote:
>>> On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote:
>>>> On 10.12.2020 22
Hi Krzysztof,
On 18.12.2020 15:22, Krzysztof Kozlowski wrote:
> On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote:
>> On 10.12.2020 22:29, Krzysztof Kozlowski wrote:
>>> Interrupt line can be configured on different hardware in different way,
>>> even
On 18.12.2020 16:03, Jon Hunter wrote:
> On 18/12/2020 10:05, Marek Szyprowski wrote:
>> On 18.12.2020 10:43, Masahiro Yamada wrote:
>>> On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski
>>> wrote:
>>>> On 03.12.2020 13:57, Masahiro Yamada wrote:
>
ng PMIC drivers are used only on Devicetree boards.
>
> Additionally, the PMIC datasheets describe the interrupt line as active
> low with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
>
> Signed-off-by: Krzysztof Kozlowski
Teste
rily working for this hardware.
>
> Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based
> TM2 board")
> Signed-off-by: Krzysztof Kozlowski
Tested-by: Marek Szyprowski
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
>
On 18.12.2020 10:43, Masahiro Yamada wrote:
> On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski
> wrote:
>> On 03.12.2020 13:57, Masahiro Yamada wrote:
>>> Linus pointed out a third of the time in the Kconfig parse stage comes
>>> from the single invocation of cc1pl
file:1190: recipe for target 'scripts' failed
make: *** [scripts] Error 2
Compilation works if I use the cross-gcc provided by
gcc-7-arm-linux-gnueabi/gcc-arm-linux-gnueabi Ubuntu packages, which is:
$ arm-linux-gnueabi-gcc --version
arm-linux-gnueabi-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
406000)
[] (platform_shutdown) from []
(device_shutdown+0x18c/0x25c)
[] (device_shutdown) from [] (kernel_restart+0xc/0x68)
[] (kernel_restart) from []
(__do_sys_reboot+0x154/0x1f0)
[] (__do_sys_reboot) from [] (ret_fast_syscall+0x0/0x58)
Exception stack(0xc3405fa8 to 0xc3405ff0)
...
---[ end trace f39e94d5d6fd45bf ]---
> +
> +
> int platform_dma_configure(struct device *dev)
> {
> enum dev_dma_attr attr;
> @@ -1375,6 +1370,9 @@ struct bus_type platform_bus_type = {
> .dev_groups = platform_dev_groups,
> .match = platform_match,
> .uevent = platform_uevent,
> + .probe = platform_probe,
> + .remove = platform_remove,
> + .shutdown = platform_shutdown,
> .dma_configure = platform_dma_configure,
> .pm = _dev_pm_ops,
> };
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
pinctrl for s2mps11-irq on
> exynos5420-arndale-octa")
> Signed-off-by: Krzysztof Kozlowski
> ---
> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +-
Tested-by: Marek Szyprowski
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/
rily working for this hardware.
>
> Fixes: faaf348ef468 ("ARM: dts: Add board dts file for exynos3250-rinato")
> Signed-off-by: Krzysztof Kozlowski
> ---
> arch/arm/boot/dts/exynos3250-rinato.dts | 2 +-
Tested-by: Marek Szyprowski
> 1 file changed, 1 insertion(+),
roidxu3: Enable wake alarm of S2MPS11 RTC")
> Signed-off-by: Krzysztof Kozlowski
> ---
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +-
Tested-by: Marek Szyprowski
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroid-
rily working for this hardware.
>
> Fixes: b004a34bd0ff ("ARM: dts: exynos: Add exynos3250-artik5 dtsi file for
> ARTIK5 module")
> Signed-off-by: Krzysztof Kozlowski
> ---
> arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +-
Tested-by: Marek Szyprowski
> 1 file chan
; be dropped by the input core.
>
> Note that there are more places in cyapa driver that call
> input_device_enabled() without holding input->mutex, those are left
> unfixed for now.
>
> Reported-by: Marek Szyprowski
> Signed-off-by: Dmitry Torokhov
> ---
>
> Marek, could
Add proper modalias structures to let this driver load automatically if
compiled as module, because max14577 MFD driver creates MFD cells with
such compatible strings.
Signed-off-by: Marek Szyprowski
---
drivers/regulator/max14577-regulator.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
ce")
Signed-off-by: Marek Szyprowski
---
drivers/extcon/extcon-max77693.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index 4a410fd2ea9a..92af97e00828 100644
--- a/drivers/extcon/extcon-max77693.c
Hi Andrzej,
On 07.12.2020 16:50, Andrzej Pietrasiewicz wrote:
> Hi Marek,
>
> W dniu 07.12.2020 o 14:32, Marek Szyprowski pisze:
>> Hi Andrzej,
>>
>> On 08.06.2020 13:22, Andrzej Pietrasiewicz wrote:
>>> Use the newly added helper in relevant input dri
ce 6687a21e6b7e94ac ]---
Let me know how I can help debugging this issue.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
top of linux
next-20201204 fixed booting of my ARM32bit test systems.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Hi
On 03.12.2020 16:46, Marek Szyprowski wrote:
> On 25.11.2020 03:32, Matthew Wilcox wrote:
>> On Tue, Nov 17, 2020 at 11:43:02PM +, Matthew Wilcox wrote:
>>> On Tue, Nov 17, 2020 at 07:15:13PM +, Matthew Wilcox wrote:
>>>> I find both of these functions
p6): mounted filesystem with ordered data mode. Opts: (null)
VFS: Mounted root (ext4 filesystem) readonly on device 179:6.
Trying to move old root to /initrd ...
I suppose this issue can be also reproduced with qemu.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
phy-exynos-usb2.ko] undefined!
Fix this by removing PHY_EXYNOS5420_USB2 symbol and using
PHY_EXYNOS5250_USB2 also for Exynos5420 SoCs.
Reported-by: Markus Reichl
Fixes: 81b534f7e9b2 ("phy: samsung: Add support for the Exynos5420 variant of
the USB2 PHY")
Signed-off-by: Marek Szyprowski
phy-exynos-usb2.ko] undefined!
Fix this by removing PHY_EXYNOS5420_USB2 symbol and using
PHY_EXYNOS5250_USB2 also for Exynos5420 SoCs.
Reported-by: Markus Reichl
Fixes: 81b534f7e9b2 ("phy: samsung: Add support for the Exynos5420 variant of
the USB2 PHY")
Signed-off-by: Marek S
quashed in the original commit - we should probably rework
> the DWC driver dependencies on PCI_MSI_IRQ_DOMAIN to really fix it, for
> the time being this should do.
Thanks! I wasn't aware of that hidden dependency.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
;buffer) {
> + if (!uvc_alloc_urb_buffer(stream, uvc_urb, gfp_flags)) {
> uvc_free_urb_buffers(stream);
> break;
> }
> diff --git a/drivers/media/usb/uvc/uvcvideo.h
> b/drivers/media/usb/uvc/uvcvideo.h
> index a3dfacf069c4..3e6618a2ac82 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -532,6 +532,8 @@ struct uvc_urb {
>
> char *buffer;
> dma_addr_t dma;
> + struct page **pages;
> + struct sg_table sgt;
>
> unsigned int async_operations;
> struct uvc_copy_op copy_operations[UVC_MAX_PACKETS];
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
9a9f1021 (f9400c21)
---[ end trace 266c07205a2d632e ]---
Fixes: 9db34ee64ce4 ("spi: Use bus_type functions for probe, remove and
shutdown)"
Signed-off-by: Marek Szyprowski
---
drivers/spi/spi.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi.c b/d
ruct
> spi_driver *sdrv)
> {
> sdrv->driver.owner = owner;
> sdrv->driver.bus = _bus_type;
> - sdrv->driver.probe = spi_drv_probe;
> - sdrv->driver.remove = spi_drv_remove;
> - if (sdrv->shutdown)
> - sdrv->driver.shutdown = spi_drv_shutdown;
> return driver_register(>driver);
> }
> EXPORT_SYMBOL_GPL(__spi_register_driver);
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Hi Krzysztof,
On 20.11.2020 12:05, Krzysztof Kozlowski wrote:
> On Fri, Nov 20, 2020 at 09:56:37AM +0100, Marek Szyprowski wrote:
>> USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the
>> recently introduced dedicated compatible for Exynos5420.
>>
&g
Exynos5433 variant, rebased
onto current kernel code, rewrote commit message]
Signed-off-by: Marek Szyprowski
Acked-by: Krzysztof Kozlowski
Reviewed-by: Jingoo Han
---
Resend reason: rebased onto current -next branch
---
drivers/phy/samsung/phy-exynos-pcie.c | 301 ++--
Hi Vinod,
On 20.11.2020 10:41, Vinod Koul wrote:
> On 13-11-20, 18:01, Marek Szyprowski wrote:
>> From: Jaehoon Chung
>>
>> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM:
>> dts: exynos: Remove Exynos5440"). Rework this driver
-by: Marek Szyprowski
---
.../devicetree/bindings/phy/samsung-phy.txt | 1 +
drivers/phy/samsung/Kconfig | 7 ++-
drivers/phy/samsung/phy-exynos5250-usb2.c | 48 +--
drivers/phy/samsung/phy-samsung-usb2.c| 6 +++
drivers/phy/samsung/phy-samsung
USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the
recently introduced dedicated compatible for Exynos5420.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos54xx.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts
about the Exynos5420 variant.
Best regards,
Marek Szyprowski
Patch summary:
Marek Szyprowski (2):
phy: samsung: add support for the Exynos5420 variant of the USB2 PHY
ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible
.../devicetree/bindings/phy/samsung-phy.txt | 1 +
arch
trashing when CONFIG_OF_DYNAMIC is enabled (for example
arm/multi_v7_defconfig).
Fixes: b1d681d8d324 ("interconnect: Add sync state support")
Signed-off-by: Marek Szyprowski
---
drivers/interconnect/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/interconnect/core.c
ECM mode for RTL8153")
> Reported-by: Marek Szyprowski
> Signed-off-by: Hayes Wang
Yes, this looks like a proper fix.
Tested-by: Marek Szyprowski
> ---
> v2:
> Use a separate Kconfig entry for r8153_ecm with proper dependencies.
>
> drivers/net/usb/Kconfig | 9 ++
On 09.11.2020 18:35, Stanimir Varbanov wrote:
> Use the standard display_delay and display_delay_enable controls,
> the legacy private MFC controls are kept for backward compatibility.
>
> Signed-off-by: Stanimir Varbanov
Acked-by: Marek Szyprowski
> ---
> drivers/medi
ECM mode for RTL8153")
> Reported-by: Marek Szyprowski
> Signed-off-by: Hayes Wang
Yes, this fixes this issue, although I would prefer a separate Kconfig
entry for r8153_ecm with proper dependencies instead of this ifdefs in
Makefile.
Tested-by: Marek Szyprowski
> ---
Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM:
dts: exynos: Remove Exynos5440"). Drop the obsolete bindings for
exynos5440-pcie.
Signed-off-by: Marek Szyprowski
Reviewed-by: Rob Herring
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Jingoo Han
---
.../bi
Exynos5433 variant, rebased
onto current kernel code, rewrote commit message]
Signed-off-by: Marek Szyprowski
Acked-by: Krzysztof Kozlowski
Reviewed-by: Jingoo Han
---
drivers/phy/samsung/phy-exynos-pcie.c | 304 ++
1 file changed, 112 insertions(+), 192 deletion
Add dt-bindings for the Samsung Exynos PCIe controller (Exynos5433
variant). Based on the text dt-binding posted by Jaehoon Chung.
Signed-off-by: Marek Szyprowski
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Rob Herring
---
.../bindings/pci/samsung,exynos-pcie.yaml | 119
Add dt-bindings for the Samsung Exynos PCIe PHY controller (Exynos5433
variant). Based on the text dt-binding posted by Jaehoon Chung.
Signed-off-by: Marek Szyprowski
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Rob Herring
---
.../bindings/phy/samsung,exynos-pcie-phy.yaml | 51
SI related code, rewrote commit message, added help]
Signed-off-by: Marek Szyprowski
Acked-by: Krzysztof Kozlowski
Acked-by: Jingoo Han
Reviewed-by: Rob Herring
---
drivers/pci/controller/dwc/Kconfig | 10 +-
drivers/pci/controller/dwc/pci-exynos.c | 353 ++--
drivers/pc
on the commit b90c53b06597 ("PCI: dwc: Detect
number of iATU windows") available on the following branch:
git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
pci-more-dwc-cleanup
Best regards,
Marek Szyprowski
Changelog:
v4:
- fixed topics to better match the common style o
sb/r8152.c | 30 +--
> drivers/net/usb/r8153_ecm.c | 162
> include/linux/usb/r8152.h | 37
> 4 files changed, 204 insertions(+), 27 deletions(-)
> create mode 100644 drivers/net/usb/r8153_ecm.c
> create mode 100644 include/linux/usb/r8152.h
>
> > ...
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
as first)
> the dts and drm/exynos patches are applied.
>
> Hmm, maybe it's better to hold on with the drm patch, INTERCONNECT
> is disabled in arch/arm/configs/{multi_v7_defconfig, exynos_defconfig}
> but it is enabled in arch/arm64/configs/defconfig.
I don't think we need to delay DRM patch. Exynos DRM mixer is not
available on ARM64 SoCs, so this won't be an issue.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
ed here:
https://lore.kernel.org/dri-devel/c07bae0c-68dd-2693-948f-00e8a50f3...@samsung.com/
Thanks!
Tested-by: Marek Szyprowski
> ---
> mm/highmem.c | 19 +--
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
>
d at (1282): [] __do_softirq+0x528/0x674
softirqs last disabled at (1269): [] irq_exit+0x1dc/0x1e8
---[ end trace 6f32a2fb4294655f ]---
I can do more tests to help fixing this issue. Just let me know what to do.
...
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Hi Viresh,
On 10.11.2020 07:00, Viresh Kumar wrote:
> On 09-11-20, 13:42, Marek Szyprowski wrote:
>> This patch landed in linux next-20201109 as commit e8f7703f8fe5
>> ("cpufreq: dt: Don't (ab)use dev_pm_opp_get_opp_table() to create OPP
>> table"). Sadly it ca
_opp_put_regulators() accepts NULL argument"), which depends on
it, fixes the panic on current linux-next.
> ---
> drivers/cpufreq/cpufreq-dt.c | 158 +++----
> 1 file changed, 68 insertions(+), 90 deletions(-)
>
> ...
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
dev_warn(>dev,
> + "failed to update devfreq using passive governor\n");
> +
> nb->notifier_call = devfreq_passive_notifier_call;
> ret = devfreq_register_notifier(parent, nb,
> DEVFREQ_TRANSITION_NOTIFIER);
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
t;mmc: core: Allow setting slot index via device tree alias").
Suggested-by: Markus Reichl
Signed-off-by: Marek Szyprowski
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 ++
arch/arm64/boot/dts/exynos/exynos7.dtsi| 3 +++
2 files changed, 9 insertions(+)
diff --git a/arch/arm6
t;mmc: core: Allow setting slot index via device tree alias").
Suggested-by: Markus Reichl
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos3250.dtsi | 3 +++
arch/arm/boot/dts/exynos4.dtsi| 2 ++
arch/arm/boot/dts/exynos4210.dtsi | 1 +
arch/arm/boot/dts/exynos4412.dtsi | 1 +
Hi Rob,
On 04.11.2020 22:35, Rob Herring wrote:
> On Thu, Oct 29, 2020 at 02:40:13PM +0100, Marek Szyprowski wrote:
>> Add dt-bindings for the Samsung Exynos PCIe controller (Exynos5433
>> variant). Based on the text dt-binding posted by Jaehoon Chung.
>>
>> Sign
Hi Anand,
On 05.11.2020 09:06, Anand Moon wrote:
> On Mon, 2 Nov 2020 at 21:53, Marek Szyprowski
> wrote:
>> On 01.11.2020 15:07, Anand Moon wrote:
>>> On Thu, 1 Oct 2020 at 19:25, Łukasz Stelmach wrote:
>>>> Add a placeholder for a MAC address. A bootloade
On 04.11.2020 14:13, Marek Szyprowski wrote:
> On 04.11.2020 14:06, Markus Reichl wrote:
>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>>> On 04.11.2020 11:25, Markus Reichl wrote:
>>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>
Hi Markus,
On 04.11.2020 14:06, Markus Reichl wrote:
> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>> On 04.11.2020 11:25, Markus Reichl wrote:
>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>> Pin them to fixed values to ease booting
Hi Markus,
On 04.11.2020 13:42, Markus Reichl wrote:
> Am 04.11.20 um 13:24 schrieb Marek Szyprowski:
>> On 04.11.2020 11:08, Markus Reichl wrote:
>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>> Pin them to fixed values to ease booting
/ {
> + aliases {
> + mmc0 = _2;
> + mmc1 = _0;
Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0)
and 2 for the SD-card (sdhci_2).
> + };
> +
> chosen {
> stdout-path = _1;
> };
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
2 for the SD-card. This would be
much more natural. On the other hand, I would agree to do it differently
only on Odroid HC1/HD2/MC1, which don't have build-in eMMC - just use 0
there for the SD-card.
> + };
> +
> gpio-keys {
> compatible = "gpio-key
ally, this will work with
the current patch:
# setexp.b u0 *0x1014; setexp.b u1 *0x1015; setexp.b u2
*0x10000016; setexp.b u3 *0x1017; fdt addr ${fdtaddr}; fdt set
/soc/usb@1211/hub@1/usbether@1 local-mac-address [ 0 0 ${u0} ${u1}
${u2} ${u3} ]
> also can you update this patch for exynos5422-odroidxu3-lite.dts and
> exynos4412-odroidu3.dts.
Also odroid-x2 and odroid-xu. Lukasz will take care of them.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
1 - 100 of 2716 matches
Mail list logo
