Re: USB deadlock after resume

2007-11-21 Thread Felipe Balbi
: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Best Regards, Felipe Balbi http://felipebalbi.com [EMAIL PROTECTED] - To unsubscribe from

Re: USB deadlock after resume

2007-11-21 Thread Felipe Balbi
://www.tux.org/lkml/ -- Best Regards, Felipe Balbi http://felipebalbi.com [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: USB deadlock after resume

2007-11-21 Thread Felipe Balbi
USB_QUIRK_RESET_RESUME Markus - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Best Regards, Felipe Balbi

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-02 Thread Felipe Balbi
format such patches when I'm done with twl4030 and isp1301 development, something around 3 ~ 4 weeks from now. Even though, embedded hosts should have the same behavior. Best Regards, Felipe Balbi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH 0/2] ISP1301 updates

2008-01-03 Thread Felipe Balbi
.git;a=commit;h=d24c8950a363044016679cdf76435abdace2f56d BR, Felipe Balbi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH 1/2] I2C: ISP1301_OMAP: New-style i2c driver updates, part 1

2008-01-03 Thread Felipe Balbi
Based on David Brownell's patch for tps65010, this patch starts converting isp1301_omap.c to new-style i2c driver. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- drivers/i2c/chips/isp1301_omap.c | 60 +++-- 1 files changed, 31 insertions(+), 29 deletions

[PATCH 2/2] I2C: ISP1301_OMAP: New-style i2c driver updates, part 2

2008-01-03 Thread Felipe Balbi
Based on David Brownell's patch for tps65010, this patch finish conversting isp1301_omap.c to new-style i2c driver. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- arch/arm/mach-omap1/board-h2.c |6 ++- arch/arm/mach-omap1/board-h3.c |6 ++- arch/arm/mach-omap2/board-h4.c | 12

[PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread Felipe Balbi
-by: Felipe Balbi [EMAIL PROTECTED] --- drivers/usb/core/hub.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 68fc521..963cf9b 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1315,7 +1315,7 @@ static int

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread Felipe Balbi
On Tue, Feb 12, 2008 at 05:02:47AM -0800, David Brownell wrote: On Tuesday 12 February 2008, Felipe Balbi wrote: On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote: On Tuesday 12 February 2008, Felipe Balbi wrote: Some devices claim to be b_host even though they have

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread Felipe Balbi
On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote: On Tuesday 12 February 2008, Felipe Balbi wrote: Some devices claim to be b_host even though they have an a_connector attached to it. Why not just fix that bug? Remember that's Linux code. The device claiming to be b_host

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-13 Thread Felipe Balbi
On Wed, Feb 13, 2008 at 01:36:00PM -0800, David Brownell wrote: On Wednesday 13 February 2008, Felipe Balbi wrote: On Tue, Feb 12, 2008 at 12:32:34PM -0800, David Brownell wrote: Your proposal is to strike the is_b_host check. In terms of the OTG (1.3) state machine, that removes

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 11:24:10AM +, Mark Brown wrote: This is why I think hiding things from drivers makes no sense. Also consider the situations Linus W exposed on another subthread. If you change ordering of certain calls, you will really break the functionality of the IP.

Re: [PATCH 2/3] dma: move dw_dmac driver to an own directory

2012-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 02:32:11PM +0200, Andy Shevchenko wrote: The dw_dmac driver contains multiple files. To make a management of them more convenient move it to an own directory. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Felipe Balbi ba...@ti.com

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 02:07:15PM +, Mark Brown wrote: On Tue, Oct 30, 2012 at 01:49:49PM +0200, Felipe Balbi wrote: On Tue, Oct 30, 2012 at 11:24:10AM +, Mark Brown wrote: We need some place to put the SoC integration; power domains seem like the obvious place to me

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 03:58:21PM +, Mark Brown wrote: and this is one of the issues we're all trying to solve today so we have single zImage approach for the ARM port. I don't see the relevance of single zImage here; device tree is supposed to solve that one. DT is

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 11:20:07AM -0700, Dmitry Torokhov wrote: On Tue, Oct 30, 2012 at 07:25:13PM +0200, Felipe Balbi wrote: On Tue, Oct 30, 2012 at 03:58:21PM +, Mark Brown wrote: But then this comes round to the mindless code that ought to be factored out :) Only

Re: [PATCH] i2c: pinctrl-ify i2c-omap.c

2012-10-30 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 05:55:30PM +0200, Pantelis Antoniou wrote: Enable pinctrl for i2c-omap. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/i2c/busses/i2c-omap.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 24, 2012 at 08:47:04PM +0200, Michal Nazarewicz wrote: On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: At first it looks strange as FSG does not use composite, but yeah: On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote: Yeah. However, it should be

Re: [PATCH] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Felipe Balbi
the latest linux-next tree. When doing so, you can add my Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 01:55:03PM +0100, Michal Nazarewicz wrote: On Wed, Oct 31 2012, Felipe Balbi ba...@ti.com wrote: nevertheless, I should be receiving a patch right about now removing that file. Alan, care to send a patch for that ? I have some other stuff to remove as well, so

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Felipe Balbi
to be shared by every licensee of the chipidea core ? Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Li Yang le...@freescale.com Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org --- drivers

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Felipe Balbi
hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch instead calculates offsets into the

Re: [PATCH] usb:musb: Dequeue urbs on device unplug

2012-10-31 Thread Felipe Balbi
hi, On Mon, Oct 22, 2012 at 06:51:39AM +0200, Virupax SADASHIVPETIMATH wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Monday, October 15, 2012 5:49 PM To: Virupax SADASHIVPETIMATH Cc: ba...@ti.com; st...@rowland.harvard.edu; linux-...@vger.kernel.org

Re: [PATCH] usb:musb: Dequeue urbs on device unplug

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 10:06:03AM +0530, Virupax Sadashivpetimath wrote: Flush queued urbs on receiving device disconnect interrupt. This is required for successful disconnect and successive enumeration of the device. In a failure case khubd hangs on usb-storage thread for completion.

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
On Sun, Oct 28, 2012 at 06:48:29PM +0100, Sebastian Andrzej Siewior wrote: On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote: I was trying to keep 2 tabs but checkpatch didn't accept long line that's why I killed extra tab. Then move them to the code section instead to

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com ---

Re: [PATCH v3 1/3] drivers: bus: ocp2scp: add pdata support

2012-10-31 Thread Felipe Balbi
of this information to create the devices that is attached to ocp2scp. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com just one small comment below. Other than that: Acked-by: Felipe Balbi ba...@ti.com --- drivers/bus/omap-ocp2scp.c | 67 ++-- include

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 10:35:37PM +0800, Li Yang wrote: On Wed, Oct 31, 2012 at 9:26 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote: If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished

Re: [PATCH/Ver2] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 12:03:51AM +0900, Masanari Iida wrote: Correct spelling typo in debug messages within drivers/usb. Signed-off-by: Masanari Iida standby2...@gmail.com Acked-by: Felipe Balbi ba...@ti.com Greg, since now this only touches the stuff I handle, I can apply this myself

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 11:07:44AM -0400, Alan Stern wrote: On Wed, 31 Oct 2012, Michal Nazarewicz wrote: On Wed, Oct 31 2012, Felipe Balbi ba...@ti.com wrote: nevertheless, I should be receiving a patch right about now removing that file. Alan, care to send a patch

Re: [PATCH v2 1/4] i2c: introduce i2c-cbus driver

2012-10-31 Thread Felipe Balbi
for Nokia Internet Tablets. + * + * Copyright (C) 2004-2010 Nokia Corporation + * + * Based on code written by Juha Yrjölä, David Weinehall, Mikko Ylinen and + * Felipe Balbi. Converted to I2C driver by Aaro Koskinen. + * + * This file is subject to the terms and conditions of the GNU General

Re: [PATCH v2 2/4] mfd: introduce retu-mfd driver

2012-10-31 Thread Felipe Balbi
handling and power off functions. Cc: sa...@linux.intel.com Acked-by: Felipe Balbi ba...@ti.com Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mfd/Kconfig |9 ++ drivers/mfd/Makefile |1 + drivers/mfd/retu-mfd.c

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 11:36:25PM +0200, Pantelis Antoniou wrote: * Pantelis Antoniou pa...@antoniou-consulting.com [121031 13:14]: On Oct 31, 2012, at 9:55 PM, Benoit Cousson wrote: Yeah, I do agree. I'm confused as well. Only OMAP IPs under PRCM control could have an hwmod and

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-11-01 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 11:33:20AM -0400, Behan Webster wrote: On 12-10-31 09:28 AM, Felipe Balbi wrote: hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-11-01 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 12:39:30PM +0200, Pantelis Antoniou wrote: lcd@0 { compatible = adafruit,tft-lcd-1.8-red, sitronix,st7735; spi-max-frequency = 800; reg = 0;

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-11-01 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 01:26:10PM +0200, Pantelis Antoniou wrote: Hi On Nov 1, 2012, at 1:04 PM, Felipe Balbi wrote: Hi, On Thu, Nov 01, 2012 at 12:39:30PM +0200, Pantelis Antoniou wrote: lcd@0 { compatible = adafruit,tft-lcd-1.8-red

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-11-01 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 01:00:21PM +0100, Koen Kooi wrote: tl;dr: please suggest an actual solution that allows plugplay when plugging in multiple capes and applying power after that. Preferably one that doesn't pass the buck to u-boot. I can think of a few ways: 1) ship your

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-11-01 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 02:57:26PM +0200, Pantelis Antoniou wrote: Each cape will have their own DTS and based on some board id you will fix the DT dynamically. My point is that the issue you are facing is a real limitation of DT, so you should fix the DT core and not workaround it

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-11-01 Thread Felipe Balbi
HI, On Thu, Nov 01, 2012 at 03:59:50PM +0200, Pantelis Antoniou wrote: Hi Alan, On Nov 1, 2012, at 3:51 PM, Alan Cox wrote: What they want, and what every user wants, is I plug this board in, and the driver make sure everything is loaded and ready. No, the end users don't want to see

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-11-02 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 04:49:23PM -0700, Russ Dill wrote: On Thu, Nov 1, 2012 at 3:05 PM, Felipe Balbi ba...@ti.com wrote: HI, On Thu, Nov 01, 2012 at 03:59:50PM +0200, Pantelis Antoniou wrote: Hi Alan, On Nov 1, 2012, at 3:51 PM, Alan Cox wrote: What they want, and what

Re: linux-next: build warning after merge of the usb tree

2012-11-02 Thread Felipe Balbi
Hi, On Fri, Nov 02, 2012 at 03:08:28PM +1100, Stephen Rothwell wrote: Hi Greg, After merging the usb tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in

Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2

2012-11-02 Thread Felipe Balbi
Hi, On Fri, Nov 02, 2012 at 02:42:51AM -0700, Russ Dill wrote: browse through various detect functions, yes, some of them key off an ID, but a lot of them just check various registers to see if certain bits are zero, or certain bits are one. A lot of I²C devices I've dealt with have no

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-09-25 Thread Felipe Balbi
On Tue, Sep 25, 2012 at 09:30:29AM +0100, Russell King - ARM Linux wrote: On Tue, Sep 25, 2012 at 01:52:03PM +0530, Poddar, Sourav wrote: Hi Greg, Ping on this? On Tue, Sep 18, 2012 at 6:10 PM, Sourav Poddar sourav.pod...@ti.com wrote: Greg's tty-next is not booting on 2420 based

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-09-25 Thread Felipe Balbi
On Tue, Sep 25, 2012 at 10:12:28AM +0100, Russell King - ARM Linux wrote: On Tue, Sep 25, 2012 at 11:31:20AM +0300, Felipe Balbi wrote: On Tue, Sep 25, 2012 at 09:30:29AM +0100, Russell King - ARM Linux wrote: How is this happening? I think that needs proper investigation - or if it's

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-09-25 Thread Felipe Balbi
Hi, On Tue, Sep 25, 2012 at 10:21:18AM +0100, Russell King - ARM Linux wrote: On Tue, Sep 25, 2012 at 12:11:14PM +0300, Felipe Balbi wrote: On Tue, Sep 25, 2012 at 10:12:28AM +0100, Russell King - ARM Linux wrote: On Tue, Sep 25, 2012 at 11:31:20AM +0300, Felipe Balbi wrote: On Tue, Sep

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-09-25 Thread Felipe Balbi
On Tue, Sep 25, 2012 at 11:29:58AM +0100, Russell King - ARM Linux wrote: On Tue, Sep 25, 2012 at 12:48:16PM +0300, Felipe Balbi wrote: Hi, On Tue, Sep 25, 2012 at 10:21:18AM +0100, Russell King - ARM Linux wrote: On Tue, Sep 25, 2012 at 12:11:14PM +0300, Felipe Balbi wrote: On Tue

Re: [PATCHv2 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Felipe Balbi
On Tue, Sep 25, 2012 at 04:03:38PM +0530, Shubhrajyoti D wrote: Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com

Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended.

2012-09-25 Thread Felipe Balbi
Hi, On Tue, Sep 25, 2012 at 12:07:03PM +0100, Russell King - ARM Linux wrote: On Tue, Sep 25, 2012 at 01:37:03PM +0300, Felipe Balbi wrote: On Tue, Sep 25, 2012 at 11:29:58AM +0100, Russell King - ARM Linux wrote: Because you are accusing me of potentially breaking your beagleboard

Re: [PATCHv3 0/7] rtc: convert to c99 format

2012-09-25 Thread Felipe Balbi
to C99 format rtc: Convert struct i2c_msg initialization to C99 format FWIW: Reviewed-by: Felipe Balbi ba...@ti.com complete series look fine. -- balbi signature.asc Description: Digital signature

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-26 Thread Felipe Balbi
Hi, On Wed, Sep 26, 2012 at 11:10:48AM +0530, ABRAHAM, KISHON VIJAY wrote: Hi, On Wed, Sep 19, 2012 at 5:26 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote: usb_otg_ss_refclk960m is needed by usb2 phy present in omap5

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-26 Thread Felipe Balbi
On Thu, Sep 27, 2012 at 10:43:06AM +0530, ABRAHAM, KISHON VIJAY wrote: Hi, On Wed, Sep 26, 2012 at 11:57 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Sep 26, 2012 at 11:10:48AM +0530, ABRAHAM, KISHON VIJAY wrote: Hi, On Wed, Sep 19, 2012 at 5:26 PM, Felipe Balbi ba...@ti.com

Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-09-27 Thread Felipe Balbi
On Thu, Sep 27, 2012 at 10:31:55AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com commit log would be great. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com ---

Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency

2012-09-27 Thread Felipe Balbi
Hi, On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver could be used on different platforms. Thus, the HAVE_CLK dependency is dropped away. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com

Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

2012-09-27 Thread Felipe Balbi
On Thu, Sep 27, 2012 at 10:31:59AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com This is the PCI part of the DesignWare DMAC driver. The controller is usually used in the Intel hardware such as Medfield. Signed-off-by: Heikki Krogerus

Re: [PATCHv3 6/7] dma: move dw_dmac driver to an own directory

2012-09-27 Thread Felipe Balbi
On Thu, Sep 27, 2012 at 10:32:00AM +0300, Andy Shevchenko wrote: The dw_dmac driver contains multiple files. To make a managment of them more typo: 'management' convenient move it to an own directory. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com ---

Re: [PATCHv3 7/7] MAINTAINERS: add recently created files to dw_dmac section

2012-09-27 Thread Felipe Balbi
On Thu, Sep 27, 2012 at 10:32:01AM +0300, Andy Shevchenko wrote: Append myself to the mail entry of the section as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS

Re: [PATCHv3 4/7] dmaengine: dw_dmac: amend description and indentation

2012-09-27 Thread Felipe Balbi
On Thu, Sep 27, 2012 at 10:31:58AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com The driver will be used as a core part for various implementations of the DesignWare DMA device. The patch adjusts description on the top and corrects paragraph indentation

Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency

2012-09-27 Thread Felipe Balbi
Hi, On Thu, Sep 27, 2012 at 11:04:54AM +0300, Andy Shevchenko wrote: On Thu, Sep 27, 2012 at 10:42 AM, Felipe Balbi ba...@ti.com wrote: - depends on HAVE_CLK as is, this will break compilation of any arch which doesn't set HAVE_CLK. As Viresh suggested and I checked it's not. He

Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

2012-09-27 Thread Felipe Balbi
Hi, On Thu, Sep 27, 2012 at 11:08:12AM +0300, Andy Shevchenko wrote: + .is_private = 1, + .chan_allocation_order = CHAN_ALLOCATION_ASCENDING, + .chan_priority = CHAN_PRIORITY_ASCENDING, +}; This is the same for all of the PCI IDs listed below, looks like it's best to

Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-09-27 Thread Felipe Balbi
On Thu, Sep 27, 2012 at 01:46:17PM +0530, viresh kumar wrote: On Thu, Sep 27, 2012 at 1:10 PM, Felipe Balbi ba...@ti.com wrote: diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c @@ -1700,6 +1700,7 @@ MODULE_DEVICE_TABLE(of, dw_dma_id_table); #endif static struct

Re: [PATCHv3 2/7] dmaengine: dw_dmac: add module alias

2012-09-27 Thread Felipe Balbi
/dw_dmac.c +++ b/drivers/dma/dw_dmac.c @@ -1712,6 +1712,7 @@ static struct platform_driver dw_driver = { module_platform_driver(dw_driver); +MODULE_ALIAS(platform:dw_dmac); Acked-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Felipe Balbi ba...@ti.com -- balbi

Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency

2012-09-27 Thread Felipe Balbi
On Thu, Sep 27, 2012 at 01:47:58PM +0530, viresh kumar wrote: On Thu, Sep 27, 2012 at 1:12 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver could be used

Re: [PATCHv3 6/7] dma: move dw_dmac driver to an own directory

2012-09-27 Thread Felipe Balbi
:) Acked-by: Viresh Kumar viresh.ku...@linaro.org (After fixing Felipe's comment) And here's mine (after fixing the typo): Reviewed-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-08 Thread Felipe Balbi
On Fri, Oct 05, 2012 at 01:58:21AM +0300, Dmytro Milinevskyy wrote: Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com missing commit log. NAK. Just resend with a proper commit log and I can apply. -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-06 Thread Felipe Balbi
On Sun, Nov 04, 2012 at 03:30:21PM +0100, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com doesn't apply: $ patch -p1

Re: [PATCH v4 6/7] usb: dwc3-omap: Minor fixes to get dt working

2012-11-06 Thread Felipe Balbi
Hi, On Thu, Oct 25, 2012 at 08:24:09PM +0530, kishon wrote: Hi Benoit, On Thursday 25 October 2012 07:11 PM, Benoit Cousson wrote: Hi Kishon, On 10/15/2012 03:27 PM, Kishon Vijay Abraham I wrote: Includes few minor fixes in dwc3-omap like populating the compatible string in a correct

Re: [PATCH v4 0/7] usb: dwc3-omap: add dt support

2012-11-06 Thread Felipe Balbi
impressive (:P) but dirver's core can handle it, we can remove it and make our code a little smaller. Cc: Anton Tikhomirov av.tikhomi...@samsung.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Signed-off-by: Felipe Balbi ba...@ti.com diff --git a/drivers

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-08 Thread Felipe Balbi
Hi, (please, never top-post) On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: Unfortunately I have some issues with git send-email. I've attached the patch itself .. I'll apply it like that this time, but try to figure out how to send patches properly. We have some very

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-08 Thread Felipe Balbi
Hi, On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy wrote: On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: Unfortunately I have some issues with git send-email. I've attached the patch itself .. I'll apply it like that this time, but try to figure out

Re: [PATCH v3 resend] USB: PHY: Re-organize Tegra USB PHY driver

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 04:03:26PM +0530, Venu Byravarasu wrote: NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc. In order to support USB PHY drivers on these SoCs, existing PHY driver is split into SoC agnostic common USB PHY driver and Tegra20-specific USB phy driver. This

Re: [PATCH v3 resend] USB: PHY: Re-organize Tegra USB PHY driver

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 04:08:05PM +0530, Venu Byravarasu wrote: NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc. In order to support USB PHY drivers on these SoCs, existing PHY driver is split into SoC agnostic common USB PHY driver and Tegra20-specific USB phy driver. This

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote: Some gadget drivers may attempt to dequeue requests for an endpoint that has already been disabled. For example, in the UVC gadget driver, uvc_function_set_alt() will call usb_ep_disable() when alt setting 0 is selected. When

Re: [PATCH] i2c: omap: adopt pinctrl support

2012-10-22 Thread Felipe Balbi
-guir...@ti.com looks good to me also, should go in v3.8 merge window: Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index db31eae

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-22 Thread Felipe Balbi
On Mon, Oct 22, 2012 at 03:33:19AM +, Li Yang-R58472 wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Saturday, October 20, 2012 1:37 AM To: Simon Haggett Cc: Li Yang-R58472; Felipe Balbi; Greg Kroah-Hartman; linux- u...@vger.kernel.org; linuxppc

Re: [PATCH v3 resend] USB: PHY: Re-organize Tegra USB PHY driver

2012-10-22 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 10:29:35AM -0600, Stephen Warren wrote: On 10/19/2012 09:35 AM, Felipe Balbi wrote: Hi, On Fri, Oct 19, 2012 at 04:08:05PM +0530, Venu Byravarasu wrote: NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc. In order to support USB PHY drivers

Re: [PATCH v3 resend] USB: PHY: Re-organize Tegra USB PHY driver

2012-10-22 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 02:00:00PM +0530, Venu Byravarasu wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, October 19, 2012 9:06 PM To: Venu Byravarasu Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; ba...@ti.com; linux

Re: [PATCH v3 resend] USB: PHY: Re-organize Tegra USB PHY driver

2012-10-22 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 03:47:02PM +0530, Venu Byravarasu wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Monday, October 22, 2012 3:33 PM To: Venu Byravarasu Cc: ba...@ti.com; st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-22 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote: Hi, On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote: On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote: On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote: Some gadget drivers may attempt

[PATCH] arm: sched: stop sched_clock() during suspend

2012-10-22 Thread Felipe Balbi
(OMAP3630) and pandaboard rev A3 (OMAP4430). Suspend to RAM is now working after this patch. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/include/asm/sched_clock.h | 2 -- arch/arm/kernel/sched_clock.c | 18 -- 2 files changed, 4 insertions(+), 16 deletions(-) diff

Re: [PATCH] arm: sched: stop sched_clock() during suspend

2012-10-22 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 02:54:37PM +0300, Felipe Balbi wrote: The scheduler imposes a requirement to sched_clock() which is to stop the clock during suspend, if we don't do that IRQ threads will be rescheduled in the future which might cause transfers to timeout depending on how driver

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 12:04:01PM +0200, Linus Walleij wrote: On Tue, Oct 23, 2012 at 11:35 AM, Benoit Cousson b-cous...@ti.com wrote: On 10/23/2012 11:13 AM, Linus Walleij wrote: So Sourav, please tell us a bit about your plans for this and other drivers! Yeah, this idea is to

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 12:29:28PM +0200, Linus Walleij wrote: On Tue, Oct 23, 2012 at 12:23 PM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: On Tue, 23 Oct 2012 13:03:33 +0300, Felipe Balbi wrote: But it appears that shmobile prefer to get all resources using bus

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 12:45:33PM +0200, Linus Walleij wrote: On Tue, Oct 23, 2012 at 12:29 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Oct 23, 2012 at 12:29:28PM +0200, Linus Walleij wrote: So the biggest implementation of the notifier approach to resource handling is the SH clock

Re: [PATCH v3 resend] USB: PHY: Re-organize Tegra USB PHY driver

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 04:23:19PM +0530, Venu Byravarasu wrote: -Original Message- From: Venu Byravarasu Sent: Monday, October 22, 2012 4:04 PM To: 'ba...@ti.com' Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux- u...@vger.kernel.org;

Re: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc

2012-10-23 Thread Felipe Balbi
to them. The patch has been tested on DM644x and DM365 in both host and gadget mode (I will add this information to commit text while committing). Without this patch .mode seems to be defaulting to MUSB_UNDEFINED which I think is definitely wrong. sorry for the delay, this looks ok: Acked-by: Felipe

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
HI, On Tue, Oct 23, 2012 at 07:02:09AM -1000, Mitch Bradley wrote: On 10/23/2012 12:03 AM, Felipe Balbi wrote: Hi, I much prefer having drivers explicitly manage all their resources, which would mean that pinctrl calls need to be done on probe() and, if necessary, during suspend

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
Hi, (please don't top-post) On Tue, Oct 23, 2012 at 07:51:22AM -1000, Mitch Bradley wrote: Perhaps I misunderstood what you were suggesting. I thought that, when you said explicitly manage all their resources, you meant that the driver should know the platform-specific details about clocks

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 01:02:49PM -0700, Dmitry Torokhov wrote: On Tue, Oct 23, 2012 at 11:18:12AM +0200, Benoit Cousson wrote: Hi Dimitry, On 10/22/2012 05:50 PM, Dmitry Torokhov wrote: Hi Sourav, On Mon, Oct 22, 2012 at 06:43:00PM +0530, Sourav Poddar wrote: Adapt

Re: [PATCH] Revert serial: omap: fix software flow control

2012-10-24 Thread Felipe Balbi
Hi Greg, On Tue, Oct 16, 2012 at 08:13:59AM -0700, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [121016 07:16]: This reverts commit 957ee7270d632245b43f6feb0e70d9a5e9ea6cf6 (serial: omap: fix software flow control). As Russell has pointed out, that commit isn't fixing Software

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Felipe Balbi
Hi, On Wed, Oct 24, 2012 at 09:14:29AM -0700, Dmitry Torokhov wrote: snip No, I guess we ihave different understanding of what directly use means. This particular driver does directly use interrupts: it requests it and performs some actions when interrupt arrives. Same goes for IO

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Felipe Balbi
Hi, On Wed, Oct 24, 2012 at 09:18:01AM -0700, Dmitry Torokhov wrote: On Wed, Oct 24, 2012 at 02:54:23PM +0200, Linus Walleij wrote: On Tue, Oct 23, 2012 at 10:02 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: I have seen just in a few days 3 or 4 drivers having exactly the same

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Felipe Balbi
On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 04:42:00PM +0300, Felipe Balbi wrote: On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 12

Re: [PATCH] Revert serial: omap: fix software flow control

2012-10-24 Thread Felipe Balbi
On Wed, Oct 24, 2012 at 11:57:42AM -0700, Greg KH wrote: On Wed, Oct 24, 2012 at 01:02:55PM +0300, Felipe Balbi wrote: Hi Greg, On Tue, Oct 16, 2012 at 08:13:59AM -0700, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [121016 07:16]: This reverts commit

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Felipe Balbi
Hi, On Wed, Oct 24, 2012 at 10:28:46AM -0700, Dmitry Torokhov wrote: for more complex pinctrl use cases. These are my dogfood drivers ... Most of these will request more than one state and switch the driver between these different states at runtime, in these examples for power saving

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Felipe Balbi
Hi, On Wed, Oct 24, 2012 at 10:58:53AM -0700, Dmitry Torokhov wrote: On Wednesday, October 24, 2012 07:57:49 PM Felipe Balbi wrote: Hi, On Wed, Oct 24, 2012 at 09:18:01AM -0700, Dmitry Torokhov wrote: On Wed, Oct 24, 2012 at 02:54:23PM +0200, Linus Walleij wrote: On Tue, Oct 23

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-24 Thread Felipe Balbi
Hi, On Wed, Oct 24, 2012 at 12:38:44PM -0700, Dmitry Torokhov wrote: On Wednesday, October 24, 2012 10:10:42 PM Felipe Balbi wrote: That is a valid concern and we'll need to find a compromise here. As I said, WHAT ?? Silicon erratas are not a valid concern ? Power waste isn't

Re: [PATCH v2 1/3] drivers: bus: ocp2scp: add pdata support

2012-10-25 Thread Felipe Balbi
Hi, On Wed, Oct 24, 2012 at 05:48:07PM -0700, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [121016 09:53]: * Kishon Vijay Abraham I kis...@ti.com [121007 23:01]: ocp2scp was not having pdata support which makes *musb* fail for non-dt boot in OMAP platform. The pdata will have

Re: [PATCH v6] Enable USB peripheral mode on dm365 EVM

2012-10-25 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 02:33:32PM +0200, Constantine Shulyupin wrote: From: Constantine Shulyupin co...@makelinux.com Sets USB PHY clock source to 24 MHz clock and call USB configuration from board initialization. Tested with OTG configuration, usb gadget g_zero on DM365 EVM

  1   2   3   4   5   6   7   8   9   10   >