kselftest/next kselftest-seccomp: 5 runs, 5 regressions (v6.10-rc1-2-g64f5bc57b24e)

2024-06-14 Thread kernelci.org bot
kselftest/next kselftest-seccomp: 5 runs, 5 regressions (v6.10-rc1-2-g64f5bc57b24e) Regressions Summary --- platform | arch | lab | compiler | defconfig | regressions -+---+---+

kselftest/next kselftest-lkdtm: 5 runs, 1 regressions (v6.10-rc1-2-g64f5bc57b24e)

2024-06-14 Thread kernelci.org bot
kselftest/next kselftest-lkdtm: 5 runs, 1 regressions (v6.10-rc1-2-g64f5bc57b24e) Regressions Summary --- platform | arch | lab | compiler | defconfig | regressions ---+---+---+--+---

kselftest/next kselftest-livepatch: 2 runs, 1 regressions (v6.10-rc1-2-g64f5bc57b24e)

2024-06-14 Thread kernelci.org bot
kselftest/next kselftest-livepatch: 2 runs, 1 regressions (v6.10-rc1-2-g64f5bc57b24e) Regressions Summary --- platform| arch | lab | compiler | defconfig | regressions +--+---+--+---

kselftest/next kselftest-cpufreq: 5 runs, 2 regressions (v6.10-rc1-2-g64f5bc57b24e)

2024-06-14 Thread kernelci.org bot
kselftest/next kselftest-cpufreq: 5 runs, 2 regressions (v6.10-rc1-2-g64f5bc57b24e) Regressions Summary --- platform | arch | lab | compiler | defconfig | regressions -+---+---+

Re: [PATCH v2 3/6] ALSA: control: Apply sanity check of input values for user elements

2024-06-14 Thread Takashi Sakamoto
Hi, On Fri, Jun 14, 2024 at 05:37:12PM +0200, Takashi Iwai wrote: > Although we have already a mechanism for sanity checks of input values > for control writes, it's not applied unless the kconfig > CONFIG_SND_CTL_INPUT_VALIDATION is set due to the performance reason. > Nevertheless, it still make

kselftest/fixes kselftest-livepatch: 2 runs, 1 regressions (linux_kselftest-fixes-6.10-rc3-4-ged3994ac847e)

2024-06-14 Thread kernelci.org bot
kselftest/fixes kselftest-livepatch: 2 runs, 1 regressions (linux_kselftest-fixes-6.10-rc3-4-ged3994ac847e) Regressions Summary --- platform| arch | lab | compiler | defconfig | regressions +--+---+--+-

kselftest/fixes kselftest-lib: 4 runs, 2 regressions (linux_kselftest-fixes-6.10-rc3-4-ged3994ac847e)

2024-06-14 Thread kernelci.org bot
kselftest/fixes kselftest-lib: 4 runs, 2 regressions (linux_kselftest-fixes-6.10-rc3-4-ged3994ac847e) Regressions Summary --- platform | arch | lab | compiler | defconfig | regressions -+---+---

kselftest/fixes kselftest-cpufreq: 10 runs, 1 regressions (linux_kselftest-fixes-6.10-rc3-4-ged3994ac847e)

2024-06-14 Thread kernelci.org bot
kselftest/fixes kselftest-cpufreq: 10 runs, 1 regressions (linux_kselftest-fixes-6.10-rc3-4-ged3994ac847e) Regressions Summary --- platform | arch | lab | compiler | defconfig | regressions -+---+--

kselftest/next build: 8 builds: 0 failed, 8 passed, 1 warning (v6.10-rc1-2-g64f5bc57b24e)

2024-06-14 Thread kernelci.org bot
kselftest/next build: 8 builds: 0 failed, 8 passed, 1 warning (v6.10-rc1-2-g64f5bc57b24e) Full Build Summary: https://kernelci.org/build/kselftest/branch/next/kernel/v6.10-rc1-2-g64f5bc57b24e/ Tree: kselftest Branch: next Git Describe: v6.10-rc1-2-g64f5bc57b24e Git Commit: 64f5bc57b24e8c7935d51

kselftest/fixes build: 8 builds: 0 failed, 8 passed, 1 warning (linux_kselftest-fixes-6.10-rc3-4-ged3994ac847e)

2024-06-14 Thread kernelci.org bot
kselftest/fixes build: 8 builds: 0 failed, 8 passed, 1 warning (linux_kselftest-fixes-6.10-rc3-4-ged3994ac847e) Full Build Summary: https://kernelci.org/build/kselftest/branch/fixes/kernel/linux_kselftest-fixes-6.10-rc3-4-ged3994ac847e/ Tree: kselftest Branch: fixes Git Describe: linux_kselftes

Re: [PATCH v17 5/5] x86: vdso: Wire up getrandom() vDSO implementation

2024-06-14 Thread John Hubbard
On 6/14/24 12:06 PM, Jason A. Donenfeld wrote: Hook up the generic vDSO implementation to the x86 vDSO data page. Since the existing vDSO infrastructure is heavily based on the timekeeping functionality, which works over arrays of bases, a new macro is introduced for vvars that are not arrays. T

Re: [PATCH v3] sefltests: net: Add on/off checks for network interface non fixed features

2024-06-14 Thread Jakub Kicinski
On Fri, 14 Jun 2024 11:32:40 + Abhinav Jain wrote: > This patch addresses the TODO (add non fixed feature on/off check). > I have tested it manually on my system after making changes as suggested > in v1 and v2 linked below for reference. > Patch now restores the features being tested to their

Re: [PATCH v2 5/6] selftests/mm: kvm, mdwe fixes to avoid requiring "make headers"

2024-06-14 Thread John Hubbard
On 6/14/24 5:31 AM, David Hildenbrand wrote: On 14.06.24 04:30, John Hubbard wrote: ... +#ifndef PR_SET_MEMORY_MERGE +#define PR_SET_MEMORY_MERGE    67 +#endif + +#ifndef PR_GET_MEMORY_MERGE +#define PR_GET_MEMORY_MERGE    68 +#endif + +#ifndef PR_SET_MDWE +#define PR_SET_MDWE  

Re: [PATCH v3 1/3] selftests/vDSO: fix clang build errors and warnings

2024-06-14 Thread John Hubbard
Also Cc'ing Thomas Gleixner on this one, sorry for the omission. On 6/14/24 4:31 PM, John Hubbard wrote: When building with clang, via: make LLVM=1 -C tools/testing/selftests ...there are several warnings, and an error. This fixes all of those and allows these tests to run and pass. 1. F

Re: [PATCH v3 0/3] selftests/vDSO: fix clang build errors, and Makefile cleanup

2024-06-14 Thread John Hubbard
On 6/14/24 4:31 PM, John Hubbard wrote: Hi, Jason A. Donenfeld, I've added you because I ended up looking through your latest "implement getrandom() in vDSO" series [1], which also touches this Makefile, so just a heads up about upcoming (minor) merge conflicts. Belatedly adding Carlos Llamas

[PATCH v3 1/3] selftests/vDSO: fix clang build errors and warnings

2024-06-14 Thread John Hubbard
When building with clang, via: make LLVM=1 -C tools/testing/selftests ...there are several warnings, and an error. This fixes all of those and allows these tests to run and pass. 1. Fix linker error (undefined reference to memcpy) by providing a local version of memcpy. 2. clang complain

[PATCH v3 0/3] selftests/vDSO: fix clang build errors, and Makefile cleanup

2024-06-14 Thread John Hubbard
Hi, Jason A. Donenfeld, I've added you because I ended up looking through your latest "implement getrandom() in vDSO" series [1], which also touches this Makefile, so just a heads up about upcoming (minor) merge conflicts. Changes since v2: 1. Added two patches, both of which apply solely to the

[PATCH v3 2/3] selftests/mm: remove partially duplicated "all:" target in Makefile

2024-06-14 Thread John Hubbard
There were a couple of errors here: 1. TEST_GEN_PROGS was incorrectly prepending $(OUTPUT) to each program to be built. However, lib.mk already does that because it assumes "bare" program names are passed in, so this ended up creating $(OUTPUT)/$(OUTPUT)/file.c, which of course won't work as inten

[PATCH v3 3/3] selftests/vDSO: remove duplicate compiler invocations from Makefile

2024-06-14 Thread John Hubbard
The Makefile open-codes compiler invocations that ../lib.mk already provides. Avoid this by using a Make feature that allows setting per-target variables, which in this case are: CFLAGS and LDFLAGS. This approach generates the exact same compiler invocations as before, but removes all of the code

Re: [PATCH v2 3/3] docs: mm: add enable_soft_offline sysctl

2024-06-14 Thread Jiaqi Yan
Thanks for your questions, David! On Tue, Jun 11, 2024 at 5:25 PM David Rientjes wrote: > > On Tue, 11 Jun 2024, Jiaqi Yan wrote: > > > @@ -267,6 +268,20 @@ used:: > > These are informational only. They do not mean that anything is wrong > > with your system. To disable them, echo 4 (bit 2) i

Re: [PATCH v2] selftests/vDSO: fix clang build errors and warnings

2024-06-14 Thread Carlos Llamas
On Fri, Jun 14, 2024 at 03:56:01PM -0700, John Hubbard wrote: > On 6/14/24 3:51 PM, John Hubbard wrote: > > On 6/11/24 11:30 AM, Carlos Llamas wrote: > > > On Mon, May 27, 2024 at 02:16:22PM -0700, John Hubbard wrote: > ... > > > Reviewed-by: Carlos Llamas > > > > Thanks for the review! I have no

Re: [PATCH v2] selftests/vDSO: fix clang build errors and warnings

2024-06-14 Thread John Hubbard
On 6/14/24 3:51 PM, John Hubbard wrote: On 6/11/24 11:30 AM, Carlos Llamas wrote: On Mon, May 27, 2024 at 02:16:22PM -0700, John Hubbard wrote: ... Reviewed-by: Carlos Llamas Thanks for the review! I have no earthly idea what will happen next. I'd like to hear at least something from the ma

Re: [PATCH v2] selftests/vDSO: fix clang build errors and warnings

2024-06-14 Thread John Hubbard
On 6/11/24 11:30 AM, Carlos Llamas wrote: On Mon, May 27, 2024 at 02:16:22PM -0700, John Hubbard wrote: When building with clang, via: make LLVM=1 -C tools/testing/selftests ...there are several warnings, and an error. This fixes all of those and allows these tests to run and pass. It m

Re: [PATCH v2 2/3] selftest/mm: test enable_soft_offline behaviors

2024-06-14 Thread Jiaqi Yan
On Thu, Jun 13, 2024 at 8:50 PM Miaohe Lin wrote: > > On 2024/6/12 5:55, Jiaqi Yan wrote: > > Add regression and new tests when hugepage has correctable memory > > errors, and how userspace wants to deal with it: > > * if enable_soft_offline=0, mapped hugepage is soft offlined > > * if enable_soft

Re: [PATCH v3 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD

2024-06-14 Thread Reinette Chatre
Hi Babu, On 6/5/24 3:45 PM, Babu Moger wrote: Enable MBA/MBM tests if UMC (Unified Memory Controller) support is available on the system. Tests will be skipped otherwise. Could you please point out where the test is skipped if UMC is not available? Reinette

Re: [PATCH v3 3/4] selftests/resctrl: Add support for MBM and MBA tests on AMD

2024-06-14 Thread Reinette Chatre
Hi Babu, On 6/5/24 3:45 PM, Babu Moger wrote: Add support to read UMC (Unified Memory Controller) perf events to compare the numbers with QoS monitor for AMD. Signed-off-by: Babu Moger --- v3: Made read_from_mc_dir function generic to both AMD and Intel. Rest are mostly related to rebase.

Re: [PATCH v3 2/4] selftests/resctrl: Pass sysfs controller name of the vendor

2024-06-14 Thread Reinette Chatre
Hi Babu, Subject and changelog mentions how controller name is "passed" but the patch does not seem to "pass" anything new. On 6/5/24 3:45 PM, Babu Moger wrote: The test detects number of memory controllers by looking at the sysfs file system. Detect the vendor to pass the controller name appro

Re: [PATCH v3 1/4] selftests/resctrl: Rename variables and functions to generic names

2024-06-14 Thread Reinette Chatre
Hi Babu, On 6/5/24 3:45 PM, Babu Moger wrote: In an effort to support MBM and MBA tests for AMD, renaming for variable and functions to generic names. For Intel, the memory controller is called Changelog usually starts with some context and then problem to be solved. What the patch does follow

Re: [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal

2024-06-14 Thread John Hubbard
On 6/14/24 5:41 AM, David Hildenbrand wrote: On 14.06.24 14:28, David Hildenbrand wrote: On 14.06.24 04:30, John Hubbard wrote: The selftests/mm build isn't exactly "broken", according to the current documentation, which still claims that one must run "make headers", before building the kselfte

[PATCH net] selftests: mptcp: userspace_pm: fixed subtest names

2024-06-14 Thread Matthieu Baerts (NGI0)
_dport}" -le "${app6_port}" ]; then + e_dport_txt=":${e_dport}" + fi + + info="${e_saddr} (${e_from}) => ${e_daddr}${e_dport_txt} (${e_to})" if [ "$e_type" = "$SUB_ESTABLISHED" ] then @@ -766,7 +775,7 @@ test_subflows_v4_v6_mix() :>"$client_evts" ip netns exec "$ns1" ./pm_nl_ctl ann 10.0.2.1 token "$server6_token" id\ $server_addr_id dev ns1eth2 - print_test "ADD_ADDR4 id:${server_addr_id} 10.0.2.1 (ns1) => ns2, reuse port" + print_test "ADD_ADDR4 id:server 10.0.2.1 (ns1) => ns2, reuse port" sleep 0.5 verify_announce_event "$client_evts" "$ANNOUNCED" "$client6_token" "10.0.2.1"\ "$server_addr_id" "$app6_port" @@ -861,7 +870,7 @@ test_listener() local listener_pid=$! sleep 0.5 - print_test "CREATE_LISTENER 10.0.2.2:$client4_port" + print_test "CREATE_LISTENER 10.0.2.2 (client port)" verify_listener_events $client_evts $LISTENER_CREATED $AF_INET 10.0.2.2 $client4_port # ADD_ADDR from client to server machine reusing the subflow port @@ -878,13 +887,14 @@ test_listener() mptcp_lib_kill_wait $listener_pid sleep 0.5 - print_test "CLOSE_LISTENER 10.0.2.2:$client4_port" + print_test "CLOSE_LISTENER 10.0.2.2 (client port)" verify_listener_events $client_evts $LISTENER_CLOSED $AF_INET 10.0.2.2 $client4_port } print_title "Make connections" make_connection make_connection "v6" +print_title "Will be using address IDs ${client_addr_id} (client) and ${server_addr_id} (server)" test_announce test_remove --- base-commit: 89aa3619d141d6cfb6040a561aebb6d99d3e2285 change-id: 20240614-upstream-net-20240614-selftests-mptcp-uspace-pm-fixed-test-names-368e312afd0b Best regards, -- Matthieu Baerts (NGI0)

Re: [PATCH net-next v2 9/9] selftests: openvswitch: add emit_sample test

2024-06-14 Thread Aaron Conole
Adrian Moreno writes: > Add a test to verify sampling packets via psample works. > > In order to do that, create a subcommand in ovs-dpctl.py to listen to > on the psample multicast group and print samples. > > In order to also test simultaneous sFlow and psample actions and > packet truncation,

Re: [PATCH] selftests/ftrace: Fix test to handle both old and new kernels

2024-06-14 Thread Steven Rostedt
Shuah, Can you take this through your tree? Thanks, -- Steve On Wed, 15 May 2024 01:36:20 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > The function "scheduler_tick" was renamed to "sched_tick" and a selftest > that used that function for testing function trace filter

Re: [PATCH] tracing/selftests: Run the ownership test twice

2024-06-14 Thread Steven Rostedt
Shuah, Can you take this through your tree? -- Steve On Thu, 23 May 2024 12:45:41 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > A regression happened where running the ownership test passes on the first > iteration but fails running it a second time. This was caught an

[PATCH] kselftest/alsa: Fix validation of writes to volatile controls

2024-06-14 Thread Mark Brown
;, + ctl->name); + show_values(ctl, initial_val, read_val); + ctl->event_spurious++; } } --- base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 change-id: 20240614-alsa-selftest-volatile-d6f3e8e28c08 Best regards, -- Mark Brown

Re: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-14 Thread Jiaqi Yan
On Thu, Jun 13, 2024 at 8:28 PM Miaohe Lin wrote: > > On 2024/6/12 5:55, Jiaqi Yan wrote: > > Correctable memory errors are very common on servers with large > > amount of memory, and are corrected by ECC. Soft offline is kernel's > > additional recovery handling for memory pages having (excessive

Re: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-14 Thread Jiaqi Yan
On Fri, Jun 14, 2024 at 1:35 AM Lance Yang wrote: > > Hi Jiaqi, > > On Wed, Jun 12, 2024 at 5:56 AM Jiaqi Yan wrote: > > > > Correctable memory errors are very common on servers with large > > amount of memory, and are corrected by ECC. Soft offline is kernel's > > additional recovery handling fo

Re: [PATCH v2 4/6] kselftest/alsa: mixer-test: Skip write verification for volatile controls

2024-06-14 Thread Mark Brown
On Fri, Jun 14, 2024 at 06:08:12PM +0200, Takashi Iwai wrote: > Mark Brown wrote: > +++ b/tools/testing/selftests/alsa/mixer-test.c > @@ -668,6 +668,10 @@ static int write_and_verify(struct ctl_data *ctl, > ksft_print_msg("%s read and written values differ\n", >

Re: [PATCH v2 4/6] kselftest/alsa: mixer-test: Skip write verification for volatile controls

2024-06-14 Thread Takashi Iwai
On Fri, 14 Jun 2024 17:57:37 +0200, Mark Brown wrote: > > On Fri, Jun 14, 2024 at 05:37:13PM +0200, Takashi Iwai wrote: > > > @@ -616,6 +616,10 @@ static int write_and_verify(struct ctl_data *ctl, > > if (!snd_ctl_elem_info_is_readable(ctl->info)) > > return err; > > > > + /*

Re: [PATCH v2 4/6] kselftest/alsa: mixer-test: Skip write verification for volatile controls

2024-06-14 Thread Mark Brown
On Fri, Jun 14, 2024 at 05:37:13PM +0200, Takashi Iwai wrote: > @@ -616,6 +616,10 @@ static int write_and_verify(struct ctl_data *ctl, > if (!snd_ctl_elem_info_is_readable(ctl->info)) > return err; > > + /* Skip the verification for volatile controls, too */ > + if (s

Re: [PATCH v2 4/6] kselftest/alsa: mixer-test: Skip write verification for volatile controls

2024-06-14 Thread Jaroslav Kysela
On 14. 06. 24 17:37, Takashi Iwai wrote: The control elements with volatile flag don't guarantee that the written values are actually saved for the next reads, hence we can't verify the written values reliably. Skip the verification after write tests for those volatile controls for avoiding conf

Re: [PATCH net-next 2/2] selftests: openvswitch: set value to nla flags

2024-06-14 Thread Aaron Conole
Adrián Moreno writes: > On Mon, Jun 03, 2024 at 03:02:46PM GMT, Aaron Conole wrote: >> Adrian Moreno writes: >> >> > Netlink flags, although they don't have payload at the netlink level, >> > are represented as having a "True" value in pyroute2. >> > >> > Without it, trying to add a flow with a

Re: [RFC net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests.

2024-06-14 Thread Aaron Conole
Hi Stefano, Thanks for the review! Stefano Brivio writes: > On Thu, 13 Jun 2024 14:13:32 -0400 > Aaron Conole wrote: > >> The current pmtu test infrastucture requires an installed copy of the >> ovs-vswitchd userspace. This means that any automated or constrained >> environments may not have

Re: [PATCH v3 2/2] usercopy: Convert test_user_copy to KUnit test

2024-06-14 Thread Shuah Khan
On 6/12/24 13:59, Kees Cook wrote: Convert the runtime tests of hardened usercopy to standard KUnit tests. Additionally disable usercopy_test_invalid() for systems with separate address spaces (or no MMU) since it's not sensible to test for address confusion there (e.g. m68k). Co-developed-by:

Re: [PATCH v2 6/6] ALSA: hda: Add input value sanity checks to HDMI channel map controls

2024-06-14 Thread Jaroslav Kysela
On 14. 06. 24 17:37, Takashi Iwai wrote: Add a simple sanity check to HD-audio HDMI Channel Map controls. Although the value might not be accepted for the actual connection, we can filter out some bogus values beforehand, and that should be enough for making kselftest happier. Signed-off-by: Tak

[PATCH v2 5/6] ALSA: chmap: Mark Channel Map controls as volatile

2024-06-14 Thread Takashi Iwai
The values returned from Playback Channel Map and Capture Channel Map controls may vary dynamically depending on the corresponding PCM stream. Mark those as volatile to indicate the values are unstable and not suitable for testing. Note that we may change the driver to return -EINVAL, but this wo

[PATCH v2 4/6] kselftest/alsa: mixer-test: Skip write verification for volatile controls

2024-06-14 Thread Takashi Iwai
The control elements with volatile flag don't guarantee that the written values are actually saved for the next reads, hence we can't verify the written values reliably. Skip the verification after write tests for those volatile controls for avoiding confusion. Reported-by: Paul Menzel Closes:

[PATCH v2 2/6] ALSA: hda: Return -EINVAL for invalid volume/switch inputs

2024-06-14 Thread Takashi Iwai
So far the HD-audio driver has been tolerant about the input values and accepts any values by correcting the amp volume and switch values internally. But now our own selftest starts complaining about this behavior, so let's be picky and change the behavior to return -EINVAL for invalid input value

[PATCH v2 6/6] ALSA: hda: Add input value sanity checks to HDMI channel map controls

2024-06-14 Thread Takashi Iwai
Add a simple sanity check to HD-audio HDMI Channel Map controls. Although the value might not be accepted for the actual connection, we can filter out some bogus values beforehand, and that should be enough for making kselftest happier. Signed-off-by: Takashi Iwai --- sound/hda/hdmi_chmap.c | 18

[PATCH v2 3/6] ALSA: control: Apply sanity check of input values for user elements

2024-06-14 Thread Takashi Iwai
Although we have already a mechanism for sanity checks of input values for control writes, it's not applied unless the kconfig CONFIG_SND_CTL_INPUT_VALIDATION is set due to the performance reason. Nevertheless, it still makes sense to apply the check for user elements despite of its cost, as that's

[PATCH v2 0/6] ALSA: some driver fixes for control input validations

2024-06-14 Thread Takashi Iwai
Hi, this is a revised patch set as a follow up of the thread about the errors reported by kselftest mixer-test. It changes HD-audio and vmaster control behavior to return -EINVAL for invalid input values. There is a change in kselftest itself to skip the verification after write tests for volati

[PATCH v2 1/6] ALSA: vmaster: Return error for invalid input values

2024-06-14 Thread Takashi Iwai
So far the vmaster code has been tolerant about the input values and accepts any values by correcting internally. But now our own selftest starts complaining about this behavior, so let's be picky and change the behavior to return -EINVAL for invalid input values instead. Reported-by: Paul Menzel

Re: selftests: arm64: fp-stress: KERNEL-1-0/3-0/4-0/6-0 - gcc-13 - Failed - clang-pass

2024-06-14 Thread Mark Brown
On Thu, Jun 13, 2024 at 07:21:15PM +0530, Naresh Kamboju wrote: > The following selftests: arm64 tests failed on FVP-aemva test and kernel > built with gcc-13 but pass with clang. > > arm64_fp-stress_KERNEL-1-0/3-0/4-0/6-0 - gcc-13 - Failed > arm64_fp-stress_KERNEL-1-0/3-0/4-0/6-0 - clang-18 - Pas

Re: [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items

2024-06-14 Thread Jeff Xu
On Fri, Jun 14, 2024 at 5:28 AM David Hildenbrand wrote: > > On 14.06.24 04:30, John Hubbard wrote: > > Clean up and move some copy-pasted items into a new mseal_helpers.h. > > > > 1. The test macros can be made safer and simpler, by observing that they > > are invariably called when about to retu

Re: [PATCH net-next 2/6] selftests: net: lib: remove ns from list after clean-up

2024-06-14 Thread Matthieu Baerts
Hi Simon, Thank you for your reply! On 14/06/2024 12:40, Simon Horman wrote: > On Fri, Jun 07, 2024 at 06:31:03PM +0200, Matthieu Baerts (NGI0) wrote: >> Instead of only appending items to the list, removing them when the >> netns has been deleted. >> >> By doing that, we can make sure 'cleanup_a

Re: [PATCH 4/5] kselftest/alsa: mixer-test: Skip write tests for volatile controls

2024-06-14 Thread Takashi Iwai
On Fri, 14 Jun 2024 16:29:03 +0200, Mark Brown wrote: > > On Fri, Jun 14, 2024 at 02:47:26PM +0200, Takashi Iwai wrote: > > > The control elements with volatile flag don't guarantee that the > > written values are actually saved for the next reads, hence they > > aren't suitable for the standard

Re: [PATCH 4/5] kselftest/alsa: mixer-test: Skip write tests for volatile controls

2024-06-14 Thread Mark Brown
On Fri, Jun 14, 2024 at 02:47:26PM +0200, Takashi Iwai wrote: > The control elements with volatile flag don't guarantee that the > written values are actually saved for the next reads, hence they > aren't suitable for the standard mixer tests. Skip the write tests > for those volatile controls fo

Re: [PATCH 3/5] ALSA: control: Apply sanity check of input values for user elements

2024-06-14 Thread Mark Brown
On Fri, Jun 14, 2024 at 02:47:25PM +0200, Takashi Iwai wrote: > Although we have already a mechanism for sanity checks of input values > for control writes, it's not applied unless the kconfig > CONFIG_SND_CTL_INPUT_VALIDATION is set due to the performance reason. > Nevertheless, it still makes sen

Re: [PATCH 3/5] ALSA: control: Apply sanity check of input values for user elements

2024-06-14 Thread Jaroslav Kysela
On 14. 06. 24 14:47, Takashi Iwai wrote: Although we have already a mechanism for sanity checks of input values for control writes, it's not applied unless the kconfig CONFIG_SND_CTL_INPUT_VALIDATION is set due to the performance reason. Nevertheless, it still makes sense to apply the check for u

Re: [PATCH 0/5] ALSA: some driver fixes for control input validations

2024-06-14 Thread Jaroslav Kysela
On 14. 06. 24 14:47, Takashi Iwai wrote: Hi, this is a patch set as a follow up of the thread about the errors reported by kselftest mixer-test. It changes HD-audio and vmaster control behavior to return -EINVAL for invalid input values. There is a change in kselftest itself to skip the write

Re: [PATCH] selftests/livepatch: define max test-syscall processes

2024-06-14 Thread Petr Mladek
On Thu 2024-06-06 09:53:48, Ryan Sullivan wrote: > Define a maximum allowable number of pids that can be livepatched in > test-syscall.sh as with extremely large machines the output from a > large number of processes overflows the dev/kmsg "expect" buffer in > the "check_result" function and causes

[PATCH 4/5] kselftest/alsa: mixer-test: Skip write tests for volatile controls

2024-06-14 Thread Takashi Iwai
The control elements with volatile flag don't guarantee that the written values are actually saved for the next reads, hence they aren't suitable for the standard mixer tests. Skip the write tests for those volatile controls for avoiding confusion. Reported-by: Paul Menzel Closes: https://lore.

[PATCH 3/5] ALSA: control: Apply sanity check of input values for user elements

2024-06-14 Thread Takashi Iwai
Although we have already a mechanism for sanity checks of input values for control writes, it's not applied unless the kconfig CONFIG_SND_CTL_INPUT_VALIDATION is set due to the performance reason. Nevertheless, it still makes sense to apply the check for user elements despite of its cost, as that's

[PATCH 1/5] ALSA: vmaster: Return error for invalid input values

2024-06-14 Thread Takashi Iwai
So far the vmaster code has been tolerant about the input values and accepts any values by correcting internally. But now our own selftest starts complaining about this behavior, so let's be picky and change the behavior to return -EINVAL for invalid input values instead. Reported-by: Paul Menzel

[PATCH 0/5] ALSA: some driver fixes for control input validations

2024-06-14 Thread Takashi Iwai
Hi, this is a patch set as a follow up of the thread about the errors reported by kselftest mixer-test. It changes HD-audio and vmaster control behavior to return -EINVAL for invalid input values. There is a change in kselftest itself to skip the write tests for volatile controls, too. It's for

[PATCH 5/5] ALSA: chmap: Mark Channel Map controls as volatile

2024-06-14 Thread Takashi Iwai
The values returned from Playback Channel Map and Capture Channel Map controls may vary dynamically depending on the corresponding PCM stream. Mark those as volatile to indicate the values are unstable and not suitable for testing. Note that we may change the driver to return -EINVAL, but this wo

[PATCH 2/5] ALSA: hda: Return -EINVAL for invalid volume/switch inputs

2024-06-14 Thread Takashi Iwai
So far the HD-audio driver has been tolerant about the input values and accepts any values by correcting the amp volume and switch values internally. But now our own selftest starts complaining about this behavior, so let's be picky and change the behavior to return -EINVAL for invalid input value

Re: [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal

2024-06-14 Thread David Hildenbrand
On 14.06.24 14:28, David Hildenbrand wrote: On 14.06.24 04:30, John Hubbard wrote: The selftests/mm build isn't exactly "broken", according to the current documentation, which still claims that one must run "make headers", before building the kselftests. However, according to the new plan to get

Re: testing/selftests/alsa/mixer-test: 10 failures on Dell XPS 13 9360

2024-06-14 Thread Takashi Iwai
On Fri, 14 Jun 2024 13:42:05 +0200, Jaroslav Kysela wrote: > > On 14. 06. 24 13:33, Takashi Iwai wrote: > > On Mon, 03 Jun 2024 13:38:18 +0200, > > Mark Brown wrote: > >> > >> On Fri, May 31, 2024 at 08:06:14PM +0200, Takashi Iwai wrote: > >>> Mark Brown wrote: > On Fri, May 31, 2024 at 05:1

Re: [PATCH v2 6/6] selftests/mm: remove local __NR_* definitions

2024-06-14 Thread David Hildenbrand
On 14.06.24 04:30, John Hubbard wrote: This continues the work on getting the selftests to build without requiring people to first run "make headers" [1]. Now that the system call numbers are in the correct, checked-in locations in the kernel tree (./tools/include/uapi/asm/unistd*.h), make sure

Re: [PATCH v2 5/6] selftests/mm: kvm, mdwe fixes to avoid requiring "make headers"

2024-06-14 Thread David Hildenbrand
On 14.06.24 04:30, John Hubbard wrote: On Ubuntu 23.04, the kvm and mdwe selftests/mm build fails due to missing a few items that are found in prctl.h. Here is an excerpt of the build failures: ksm_tests.c:252:13: error: use of undeclared identifier 'PR_SET_MEMORY_MERGE' ... mdwe_test.c:26:18: e

Re: [PATCH v2 4/6] selftests/mm: fix vm_util.c build failures: add snapshot of fs.h

2024-06-14 Thread David Hildenbrand
On 14.06.24 04:30, John Hubbard wrote: On Ubuntu 23.04, on a clean git tree, the selftests/mm build fails due 10 or 20 missing items, all of which are found in fs.h, which is created via "make headers". However, as per [1], the idea is to stop requiring "make headers", and instead, take a snapsho

Re: [PATCH v2 3/6] selftests/mm: mseal, self_elf: rename TEST_END_CHECK to REPORT_TEST_PASS

2024-06-14 Thread David Hildenbrand
On 14.06.24 04:30, John Hubbard wrote: Now that the test macros are factored out into their final location, and simplified, it's time to rename TEST_END_CHECK to something that represents its new functionality: REPORT_TEST_PASS. Cc: David Hildenbrand Reviewed-by: Jeff Xu Tested-by: Jeff Xu Si

Re: [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items

2024-06-14 Thread David Hildenbrand
On 14.06.24 04:30, John Hubbard wrote: Clean up and move some copy-pasted items into a new mseal_helpers.h. 1. The test macros can be made safer and simpler, by observing that they are invariably called when about to return. This means that the macros do not need an intrusive label to goto; they

Re: [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal

2024-06-14 Thread David Hildenbrand
On 14.06.24 04:30, John Hubbard wrote: The selftests/mm build isn't exactly "broken", according to the current documentation, which still claims that one must run "make headers", before building the kselftests. However, according to the new plan to get rid of that requirement [1], they are future

Re: selftests: ftrace: WARNING: at arch/arm64/kernel/stacktrace.c:112 arch_stack_walk

2024-06-14 Thread Puranjay Mohan
Hi Naresh, Thanks for finding this. On Thu, Jun 13, 2024 at 3:16 PM Naresh Kamboju wrote: > > The following kernel warning noticed on arm64 qemu-arm64 and rk3399-rock-pi-4 > device while running selftests ftrace tests on Linux next-20240613. > > This is always reproducible on qemu-arm64 and rock

Re: [PATCH 0/5] cleanups, fixes, and progress towards avoiding "make headers"

2024-06-14 Thread David Hildenbrand
On 13.06.24 23:27, John Hubbard wrote: On 6/12/24 7:11 PM, John Hubbard wrote: On 6/12/24 1:24 AM, David Hildenbrand wrote: On 11.06.24 22:54, John Hubbard wrote: On 6/11/24 2:36 AM, David Hildenbrand wrote: On 08.06.24 04:10, John Hubbard wrote: ... You remembered correctly, but the situat

Re: testing/selftests/alsa/mixer-test: 10 failures on Dell XPS 13 9360

2024-06-14 Thread Jaroslav Kysela
On 14. 06. 24 13:33, Takashi Iwai wrote: On Mon, 03 Jun 2024 13:38:18 +0200, Mark Brown wrote: On Fri, May 31, 2024 at 08:06:14PM +0200, Takashi Iwai wrote: Mark Brown wrote: On Fri, May 31, 2024 at 05:17:43PM +0200, Takashi Iwai wrote: On Fri, 31 May 2024 07:50:33 +0200, I would say thes

Re: [PATCH v2] sefltests: net: Add on/off checks for network interface non fixed features

2024-06-14 Thread Abhinav Jain
On Thu, 13 Jun 2024 18:49:38 -0700, Jakub Kicinski wrote: > You do off then on, so you assume the feature was on to begin with. > Not all features will be on. You gotta change the order based on > the initial state so that the feature goes back to what it was. Thanks for sharing feedback, I have s

Re: testing/selftests/alsa/mixer-test: 10 failures on Dell XPS 13 9360

2024-06-14 Thread Takashi Iwai
On Mon, 03 Jun 2024 13:38:18 +0200, Mark Brown wrote: > > On Fri, May 31, 2024 at 08:06:14PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > On Fri, May 31, 2024 at 05:17:43PM +0200, Takashi Iwai wrote: > > > > On Fri, 31 May 2024 07:50:33 +0200, > > > > I would say these are all bugs, the

[PATCH v3] sefltests: net: Add on/off checks for network interface non fixed features

2024-06-14 Thread Abhinav Jain
This patch addresses the TODO (add non fixed feature on/off check). I have tested it manually on my system after making changes as suggested in v1 and v2 linked below for reference. Patch now restores the features being tested to their initial state. Signed-off-by: Abhinav Jain --- PATCH v2: http

Re: [PATCH net-next 2/6] selftests: net: lib: remove ns from list after clean-up

2024-06-14 Thread Simon Horman
On Fri, Jun 07, 2024 at 06:31:03PM +0200, Matthieu Baerts (NGI0) wrote: > Instead of only appending items to the list, removing them when the > netns has been deleted. > > By doing that, we can make sure 'cleanup_all_ns()' is not trying to > remove already deleted netns. > > Reviewed-by: Geliang

Re: [PATCH HID v3 00/16] HID: convert HID-BPF into using bpf_struct_ops

2024-06-14 Thread Benjamin Tissoires
On Sat, 08 Jun 2024 11:01:12 +0200, Benjamin Tissoires wrote: > The purpose of this series is to rethink how HID-BPF is invoked. > Currently it implies a jmp table, a prog fd bpf_map, a preloaded tracing > bpf program and a lot of manual work for handling the bpf program > lifetime and addition/rem

Re: [PATCH HID v3 03/16] HID: bpf: implement HID-BPF through bpf_struct_ops

2024-06-14 Thread Benjamin Tissoires
On Jun 10 2024, Alexei Starovoitov wrote: > On Sat, Jun 8, 2024 at 2:01 AM Benjamin Tissoires wrote: > > > > + > > +static int hid_bpf_ops_init_member(const struct btf_type *t, > > +const struct btf_member *member, > > +void *kdata, c

Re: [PATCH net-next v12 03/13] netdev: support binding dma-buf to netdevice

2024-06-14 Thread Markus Elfring
… > +++ b/net/core/netdev-genl.c … > int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info) > { … > + rtnl_lock(); > + > + netdev = __dev_get_by_index(genl_info_net(info), ifindex); … > +err_unlock: > + rtnl_unlock(); > + return err; > } … Would you become inter

Re: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-14 Thread Lance Yang
Hi Jiaqi, On Wed, Jun 12, 2024 at 5:56 AM Jiaqi Yan wrote: > > Correctable memory errors are very common on servers with large > amount of memory, and are corrected by ECC. Soft offline is kernel's > additional recovery handling for memory pages having (excessive) > corrected memory errors. Impac