Re: [PATCH v4 00/14] m68k: Drop arch_gettimeoffset and adopt clocksource API

2019-03-05 Thread Linus Walleij
users will report it as is custom and the author will be expected to work with them to fix them then, we do this all the time. Those users who want everything tested before it gets merged should provide resources or time for testing. Just my €0.01 Linus Walleij

Re: [RFC PATCH v2 10/14] m68k: mac: Convert to clocksource API

2018-11-20 Thread Linus Walleij
hink so, yes. > Then, wouldn't all relevant platforms have to support > GENERIC_CLOCKEVENTS=y, if a single binary was to support all of those > platforms? Good point. I wonder of there is a path forward where we could have peaceful GENERIC_CLOCKEVENTS and !GENERIC_CLOCKEVENTS co-existence. Yours, Linus Walleij

Re: [RFC PATCH v2 07/14] m68k: atari: Convert to clocksource API

2018-11-20 Thread Linus Walleij
On Tue, Nov 20, 2018 at 10:30 AM Finn Thain wrote: > On Tue, 20 Nov 2018, Linus Walleij wrote: > > As with the Amiga, this chip also has an RTC clock that should go to the > > RTC subsystem, naturally. > > I think some Atari's have an MC146818, which is drivers/rt

Re: [RFC PATCH v2 10/14] m68k: mac: Convert to clocksource API

2018-11-20 Thread Linus Walleij
On Mon, Nov 19, 2018 at 2:22 AM Finn Thain wrote: > Add a platform clocksource by adapting the existing arch_gettimeoffset > implementation. > > Signed-off-by: Finn Thain > Acked-by: Linus Walleij > Tested-by: Stan Johnson As noted for the Amiga CIA (which is pretty much

Re: [RFC PATCH v2 07/14] m68k: atari: Convert to clocksource API

2018-11-20 Thread Linus Walleij
s clock accuracy; the result > is not much better than the jiffies clocksource. Also, clock error is > no longer uniformly distributed. > > Signed-off-by: Finn Thain > Acked-by: Linus Walleij > --- > TODO: find a spare counter for the clocksource, rather than hanging > it

Re: [RFC PATCH v2 06/14] m68k: amiga: Convert to clocksource API

2018-11-20 Thread Linus Walleij
On Mon, Nov 19, 2018 at 2:22 AM Finn Thain wrote: > Add a platform clocksource by adapting the existing arch_gettimeoffset > implementation. > > Signed-off-by: Finn Thain > Acked-by: Linus Walleij > --- > Changed since v1: > - Moved clk_total access to within the irq

Re: m68k using deprecated internal APIs?

2018-11-16 Thread Linus Walleij
On Fri, Nov 16, 2018 at 8:44 PM Geert Uytterhoeven wrote: > On Fri, Nov 16, 2018 at 12:13 PM Linus Walleij > wrote: > > I mean that whole thing should go away by abstracting those LEDs > > (for the systems that have them) using the struct led_classdev, > > populating

Re: m68k using deprecated internal APIs?

2018-11-16 Thread Linus Walleij
On Fri, Nov 16, 2018 at 1:31 AM Finn Thain wrote: > On Wed, 14 Nov 2018, Linus Walleij wrote: > > Apart from this (which is the most important step!) I think the custom > > LED heartbeat code in kernel/time.c needs to be replaced with a standard > > drivers/leds driver f

Re: m68k using deprecated internal APIs?

2018-11-14 Thread Linus Walleij
moval of "select ARCH_USES_GETTIMEOFFSET" (and satisfy > > Documentation/features/time/modern-timekeeping) without loss of timer > > accuracy. If you ask me: forge ahead. > > Alternatively, we could defer the clocksource API conversion, leaving it > > up to the platform m

Re: [PATCH] microblaze: Remove architecture heart beat code

2018-06-11 Thread Linus Walleij
On Mon, Jun 11, 2018 at 8:09 AM, Michal Simek wrote: > There is no reason to keep this gpio based code in architecture. Use > ledtrig-heartbeat.c instead which is much more flexible then this > ancient code. > > Signed-off-by: Michal Simek Reviewed-by: Linus Walleij

Re: [PATCH] [RFC] clocksource: improve GENERIC_CLOCKEVENTS dependency

2017-09-12 Thread Linus Walleij
On Tue, Sep 12, 2017 at 11:10 AM, Russell King - ARM Linux wrote: > On Tue, Sep 12, 2017 at 10:09:51AM +0200, Linus Walleij wrote: >> For ARM we now have two subarchs not using generic clockevents: >> RISC PC and EBSA110. >> >> I think Russell stated these two can

Re: [PATCH] [RFC] clocksource: improve GENERIC_CLOCKEVENTS dependency

2017-09-12 Thread Linus Walleij
so we can simply replace the dependency > with the stricter one. While in theory one could have a clocksource > driver without the clockevent infrastructure, this seems unlikely > to be relevant in the future any more. As far as I can see this works and makes sense. Reviewed-by: Linus

Re: [PATCH 09/23] m68k: do away with ARCH_REQUIRE_GPIOLIB

2016-04-26 Thread Linus Walleij
On Thu, Apr 21, 2016 at 3:12 AM, Greg Ungerer wrote: > On 20/04/16 18:58, Linus Walleij wrote: >> Replace "select ARCH_REQUIRE_GPIOLIB" with "select GPIOLIB" >> as this can now be selected directly. >> >> Cc: Michael Büsch >> Cc: Geert

[PATCH 09/23] m68k: do away with ARCH_REQUIRE_GPIOLIB

2016-04-20 Thread Linus Walleij
Replace "select ARCH_REQUIRE_GPIOLIB" with "select GPIOLIB" as this can now be selected directly. Cc: Michael Büsch Cc: Geert Uytterhoeven Cc: linux-m...@lists.linux-m68k.org Signed-off-by: Linus Walleij --- Various arch maintainers: either ACK this and I will merge it in

Re: [PATCH] m68k/gpio: remove arch specific sysfs bus device

2016-04-05 Thread Linus Walleij
populated. > > Remove the old ColdFire sysfs gpio registration. > > Signed-off-by: Greg Ungerer Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: m68k build regression

2013-04-08 Thread Linus Walleij
equest_one() function. Code largely borrowed from > blackfin's local gpio_request_one() function. > > Signed-off-by: Greg Ungerer Acked-by: Linus Walleij Greg, are you pushing this patch then? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-m

Re: m68k build regression

2013-04-05 Thread Linus Walleij
us fails. Did some driver you're using start to use devm_gpio_request_one() recently? I vaguely remember Alexandre looking into things like this so adding him... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to major