Re: [RFCv1 PATCH 0/7] gspca: allow use of control framework and other fixes

2012-05-05 Thread Hans de Goede
Hi, On 05/01/2012 12:28 PM, Jean-Francois Moine wrote: On Mon, 30 Apr 2012 13:13:59 +0200 Hans de Goedehdego...@redhat.com wrote: I'll review this and add these to my tree. Jean-Francois, is it ok for these changes to go upstream through my tree? The reason I'm asking is that I plan to

Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

2012-05-05 Thread Antonio Ospite
On Mon, 30 Apr 2012 15:51:01 +0200 Antonio Ospite osp...@studenti.unina.it wrote: On Mon, 23 Apr 2012 14:16:25 -0600 Jonathan Corbet cor...@lwn.net wrote: On Mon, 23 Apr 2012 15:21:04 +0200 Antonio Ospite osp...@studenti.unina.it wrote: Jonathan, maybe fixp_sin() and fixp_cos() can

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans Verkuil
On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks and testing). Thanks for that! One note: I initialized the controls in sd_init. That's wrong, it should be sd_config. sd_init is also called on resume,

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans Verkuil
On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks and testing). More comments inline... On 04/28/2012 05:09 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Make the necessary

[PATCH 1/1] v4l2: use __u32 rather than enums in ioctl() structs

2012-05-05 Thread Sakari Ailus
From: Rémi Denis-Courmont r...@remlab.net V4L2 uses the enum type in IOCTL arguments in IOCTLs that were defined until the use of enum was considered less than ideal. Recently Rémi Denis-Courmont brought up the issue by proposing a patch to convert the enums to unsigned:

Re: [PATCH 1/1] v4l2: use __u32 rather than enums in ioctl() structs

2012-05-05 Thread Hans Verkuil
On Sat May 5 2012 12:25:45 Sakari Ailus wrote: From: Rémi Denis-Courmont r...@remlab.net V4L2 uses the enum type in IOCTL arguments in IOCTLs that were defined until the use of enum was considered less than ideal. Recently Rémi Denis-Courmont brought up the issue by proposing a patch to

Re: [PATCH 1/1] v4l2: use __u32 rather than enums in ioctl() structs

2012-05-05 Thread Sakari Ailus
Hi Hans, On Sat, May 05, 2012 at 12:55:01PM +0200, Hans Verkuil wrote: On Sat May 5 2012 12:25:45 Sakari Ailus wrote: From: Rémi Denis-Courmont r...@remlab.net V4L2 uses the enum type in IOCTL arguments in IOCTLs that were defined until the use of enum was considered less than ideal.

Re: [PATCH 1/1] v4l2: use __u32 rather than enums in ioctl() structs

2012-05-05 Thread Hans Verkuil
On Sat May 5 2012 13:14:10 Sakari Ailus wrote: Hi Hans, On Sat, May 05, 2012 at 12:55:01PM +0200, Hans Verkuil wrote: On Sat May 5 2012 12:25:45 Sakari Ailus wrote: From: Rémi Denis-Courmont r...@remlab.net V4L2 uses the enum type in IOCTL arguments in IOCTLs that were defined

Re: [media-ctl PATCH 1/3] Support selections API for crop

2012-05-05 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Friday 04 May 2012 11:24:41 Sakari Ailus wrote: Support the new selections API for crop. Fall back to use the old crop API in case the selection API isn't available. Thanks for the patch. A few minor comments below. There's no need to resubmit, I've fixed

Re: [RFC PATCH 1/4] si470x: Clean up, introduce the control framework.

2012-05-05 Thread Tobias Lorenz
Hello Hans, thanks for the improvements. Looks good to me. Acked-by: Tobias Lorenz tobias.lor...@gmx.net Bye, Toby Am Freitag, 4. Mai 2012, 15:30:29 schrieb Hans Verkuil: From: Hans Verkuil hans.verk...@cisco.com This cleans up the code and si470x now uses the proper v4l2 frameworks and

Re: [RFC PATCH 2/4] si470x: add control event support and more v4l2 compliancy fixes.

2012-05-05 Thread Tobias Lorenz
Hello Hans, thanks for the improvements. Looks good to me. Acked-by: Tobias Lorenz tobias.lor...@gmx.net Bye, Toby Am Freitag, 4. Mai 2012, 15:30:30 schrieb Hans Verkuil: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

Re: [RFC PATCH 3/4] radio-si470x-common.c: remove unnecessary kernel log spam.

2012-05-05 Thread Tobias Lorenz
Hello Hans, thanks for the improvements. Looks good to me. Acked-by: Tobias Lorenz tobias.lor...@gmx.net Bye, Toby Am Freitag, 4. Mai 2012, 15:30:31 schrieb Hans Verkuil: From: Hans Verkuil hans.verk...@cisco.com There is no need to report an error in the log, you are already returning

Re: [RFC PATCH 4/4] radio-si470x-usb: remove autosuspend, implement suspend/resume.

2012-05-05 Thread Tobias Lorenz
Hello Hans, thanks for the improvements. Looks good to me. Acked-by: Tobias Lorenz tobias.lor...@gmx.net Bye, Toby Am Freitag, 4. Mai 2012, 15:30:32 schrieb Hans Verkuil: From: Hans Verkuil hans.verk...@cisco.com The radio-si470x-usb driver supported both autosuspend and it stopped the

Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-05 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Friday 04 May 2012 11:24:42 Sakari Ailus wrote: More flexible and extensible syntax for media-ctl which allows better usage of the selection API. [snip] diff --git a/src/options.c b/src/options.c index 60cf6d5..4d9d48f 100644 --- a/src/options.c +++

PCTV 520e - DVB-C not working

2012-05-05 Thread Per Wetterberg
Hi, I have problem getting the PCTV 520e to work with DVB-C on Linux. The video output stream is full of defects. drxk: SCU_RESULT_INVPAR while sending cmd 0x0203 with params is printed to the dmesg log when scanning and watching DVB-C channels. I have no problems scanning and watching DVB-T.

[RFC] V4L: Rename V4L2_SEL_TGT_*_ACTIVE to V4L2_SEL_TGT_*_ACTUAL

2012-05-05 Thread Sylwester Nawrocki
After introduction of the selection API on subdevs we have following sets of selection targets: /dev/v4l-subdev? | /dev/video? - V4L2_SUBDEV_SEL_TGT_CROP_ACTUAL| V4L2_SEL_TGT_CROP_ACTIVE

Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-05 Thread Sakari Ailus
Hi Laurent, On Sat, May 05, 2012 at 02:22:26PM +0200, Laurent Pinchart wrote: Hi Sakari, Thanks for the patch. Thanks for the review! On Friday 04 May 2012 11:24:42 Sakari Ailus wrote: More flexible and extensible syntax for media-ctl which allows better usage of the selection API.

Re: [RFC] V4L: Rename V4L2_SEL_TGT_*_ACTIVE to V4L2_SEL_TGT_*_ACTUAL

2012-05-05 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: After introduction of the selection API on subdevs we have following sets of selection targets: /dev/v4l-subdev? | /dev/video? - V4L2_SUBDEV_SEL_TGT_CROP_ACTUAL

Re: [RFC] V4L: Rename V4L2_SEL_TGT_*_ACTIVE to V4L2_SEL_TGT_*_ACTUAL

2012-05-05 Thread Sylwester Nawrocki
Hi Sakari, On 05/05/2012 03:15 PM, Sakari Ailus wrote: Sylwester Nawrocki wrote: After introduction of the selection API on subdevs we have following sets of selection targets: /dev/v4l-subdev? | /dev/video? -

Re: [RFCv1 PATCH 2/7] zc3xx: convert to the control framework.

2012-05-05 Thread Hans de Goede
Hi, Reviewing and testing this one was, erm, interesting. See comments inline. On 04/28/2012 05:09 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Signed-off-by: Hans Verkuilhans.verk...@cisco.com --- drivers/media/video/gspca/zc3xx.c | 451

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 11:14 AM, Hans Verkuil wrote: On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks and testing). More comments inline... On 04/28/2012 05:09 PM, Hans Verkuil wrote: From: Hans

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 10:34 AM, Hans Verkuil wrote: On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks and testing). Thanks for that! One note: I initialized the controls in sd_init. That's wrong, it

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans Verkuil
On Sat May 5 2012 16:46:32 Hans de Goede wrote: Hi, On 05/05/2012 10:34 AM, Hans Verkuil wrote: On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks and testing). Thanks for that! One note:

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 04:50 PM, Hans Verkuil wrote: On Sat May 5 2012 16:46:32 Hans de Goede wrote: Hi, On 05/05/2012 10:34 AM, Hans Verkuil wrote: On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks and

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans Verkuil
On Sat May 5 2012 16:44:34 Hans de Goede wrote: Hi, On 05/05/2012 11:14 AM, Hans Verkuil wrote: On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks and testing). More comments inline... On

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 04:44 PM, Hans de Goede wrote: Hi, On 05/05/2012 11:14 AM, Hans Verkuil wrote: So you get: vidioc_foo() lock(mylock) v4l2_ctrl_s_ctrl(ctrl, val) s_ctrl(ctrl, val) lock(mylock) Easy solution here, remove the first lock(mylock), since we are not using v4l2-dev's locking,

Re: [PATCH] v4l: soc-camera: Add support for enum_frameintervals ioctl

2012-05-05 Thread Guennadi Liakhovetski
On Fri, 4 May 2012, Aguirre, Sergio wrote: Hi Guennadi, No problem. On Fri, May 4, 2012 at 10:05 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Sergio Sorry about the delay. On Wed, 18 Apr 2012, Aguirre, Sergio wrote: From: Sergio Aguirre saagui...@ti.com

Problems with Gadmei UTV380New [id=1f71:3301]

2012-05-05 Thread rizal . m . nur
Model = Gadmei UTV380New Vendor/ProductID = 1f71:3301 Test = - I follow instruction on link http://www.linuxtv.org/wiki/index.php?title=Gadmei_USB_TVBox_UTV380 - I change SB_DEVICE(0xeb1a, 0x50a3) with SB_DEVICE(0x1f71, 0x3301) - after i compile (make distsclean, make menuconfig, make, and make

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, Oops, forgot the attachment it is here now... Regards, Hans On 05/05/2012 05:05 PM, Hans de Goede wrote: Hi, On 05/05/2012 04:44 PM, Hans de Goede wrote: Hi, On 05/05/2012 11:14 AM, Hans Verkuil wrote: So you get: vidioc_foo() lock(mylock) v4l2_ctrl_s_ctrl(ctrl, val) s_ctrl(ctrl,

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 05:02 PM, Hans Verkuil wrote: BTW, this is getting messy: both of us producing patches for the same driver :-) For those reading along on the mailinglist, we've got together on irc and coordinated how we are going to handle this there. Regards, Hans -- To unsubscribe from

Re: [PATCH v2] add support for DeLOCK-USB-2.0-DVB-T-Receiver-61744

2012-05-05 Thread Thomas Mair
I am currently finishing up the work at the demod driver and will probably send a new version to the list tomorrow. As I don't own a device with a different tuner than the fc0012 I will include an error message about the unsupported tuner and print its type. So It is easier to get the information

[PATCH] em28xx: Remove unused wait_queue's

2012-05-05 Thread Ezequiel Garcia
Nobody ever waits on any of these wait_queue's, so this patch removes them completely. Tested by compilation only. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-cards.c |7 --- drivers/media/video/em28xx/em28xx-video.c |1 -

Re: GENIUS TV-GO A12 tv analog card

2012-05-05 Thread Ezequiel Garcia
Hola Sebastián, :) On Fri, May 4, 2012 at 12:13 PM, Sebastián Misuraca smisur...@3way.com.ar wrote: Hi, I add a tv card support for saa7134 driver, the card name is Genius TV Go A12 and i test the RF capture with pal-nc and I test the composite input too. I want to known if I would make a

Re: [PATCH v2] add support for DeLOCK-USB-2.0-DVB-T-Receiver-61744

2012-05-05 Thread Hans-Frieder Vogt
Am Samstag, 5. Mai 2012 schrieben Sie: I am currently finishing up the work at the demod driver and will probably send a new version to the list tomorrow. As I don't own a device with a different tuner than the fc0012 I will include an error message about the unsupported tuner and print its

Re: [PATCH v2] add support for DeLOCK-USB-2.0-DVB-T-Receiver-61744

2012-05-05 Thread Antti Palosaari
la 5.5.2012 19:01 Thomas Mair kirjoitti: I am currently finishing up the work at the demod driver and will probably send a new version to the list tomorrow. Nice! I will try to review it on Monday... I looked quickly your old patch last week and tuner driver was done by Hans-Frieder Vogt. I

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Jean-Francois Moine
On Sat, 05 May 2012 16:59:30 +0200 Hans de Goede hdego...@redhat.com wrote: Unless there is another good reason for doing the probing in sd_init I prefer to move it to sd_config. Sensor probing does more then just sensor probing, it also configures things like the i2c clockrate, and

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Jean-Francois Moine
On Sat, 05 May 2012 17:05:28 +0200 Hans de Goede hdego...@redhat.com wrote: Now I see that we are doing exactly that in for example vidioc_g_jpegcomp in gspca.c, so we should stop doing that. We can make vidioc_g/s_jpegcomp only do the usb locking if gspca_dev-vdev.ctrl_handler ==

cron job: media_tree daily build: WARNINGS

2012-05-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sat May 5 19:00:16 CEST 2012 git hash:a1ac5dc28d2b4ca78e183229f7c595ffd725241c gcc version: i686-linux-gcc

gspca zc3xx - JPEG quality / frame overflow

2012-05-05 Thread Jean-Francois Moine
Hi Hans, I quickly looked at your patches about the changes for the JPEG quality, and I have some remarks. Indeed, as I don't have any zc3xx webcam nor a lot of documentation about the zc3xx bridge, my information come only from USB trace analysis, and I am not sure there are fully valid. - the

Initial scan file update for fi-sonera

2012-05-05 Thread Mikko Autio
Update for fi-sonera. Modulation for all channels were changed to QAM256 in April 2012. Source: http://www5.sonera.fi/ohjeet/Kaapeli-TV-taajuudet Mikko -- diff -r 4030c51d6e7b util/scan/dvb-c/fi-sonera --- a/util/scan/dvb-c/fi-sonera Tue Apr 10 16:44:06 2012 +0200 +++

Re: [media-ctl PATCH 2/3] New, more flexible syntax for media-ctl

2012-05-05 Thread Laurent Pinchart
Hi Sakari, On Saturday 05 May 2012 16:09:33 Sakari Ailus wrote: On Sat, May 05, 2012 at 02:22:26PM +0200, Laurent Pinchart wrote: On Friday 04 May 2012 11:24:42 Sakari Ailus wrote: More flexible and extensible syntax for media-ctl which allows better usage of the selection API.

error - cx18 driver

2012-05-05 Thread Hector Catre
Note: I’m a relatively n00b trying to set up mythtv and having issues installing the hauppage hvr-1600 tuner/capture card. When I run dmesg, I get the following: [ 117.013178] a1ac5dc28d2b4ca78e183229f7c595ffd725241c [media] gspca - sn9c20x: Change the exposure setting of Omnivision sensors [

RE: error - cx18 driver

2012-05-05 Thread Hector Catre
Thanks Andy. Again I'm a n00b, thus, can you point me to a page or resource where I can find and install i2c_algo_bit? Thanks again, H -Original Message- From: Andy Walls [mailto:awa...@md.metrocast.net] Sent: May-05-12 8:43 PM To: Hector Catre; linux-media@vger.kernel.org Subject: Re:

Re: error - cx18 driver

2012-05-05 Thread poma
On 05/06/2012 03:41 AM, Hector Catre wrote: Thanks Andy. Again I'm a n00b, thus, can you point me to a page or resource where I can find and install i2c_algo_bit? Thanks again, H Please paste output of: grep -w 'CONFIG_I2C\|CONFIG_I2C_HELPER_AUTO\|CONFIG_I2C_ALGOBIT' /boot/config-`uname -r`

[PATCH] staging/media/as102: removed else statements

2012-05-05 Thread joseph daniel
The else statement is actually not required, as we can assign AS10X_CMD_ERROR to the error variable directly. Signed-off-by: joseph daniel josephdanielwal...@gmail.com --- drivers/staging/media/as102/as10x_cmd.c | 28 +++- 1 file changed, 7 insertions(+), 21