It does seem like the error handling for mantis_dma_init() is insane..
Linus
On Sun, Aug 9, 2015 at 5:12 PM, RUC_Soft_Sec zy900...@163.com wrote:
Summary:
there exists a wrong return value of function mantis_dma_init().It's a
theoretical problem. we use static analysis
Hi All,
The following PRELIMINARY patch adds DT support to the OMAP4 ISS. It
also fixes some problems a have found along the way. It is tightly
modelled after the omap3-isp media platform driver. This patch is a
work in progress as I would like feedback. It contains debugging
messages that need
Current code assigns 0 to variable 'err', which makes mantis_dma_init()
to return success even if mantis_alloc_buffers() fails.
Fix it by checking the return value from mantis_alloc_buffers() and
propagating it in the case of error.
Reported-by: RUC_Soft_Sec zy900...@163.com
Signed-off-by:
Hi, thanks for your reviews
On Mon, Aug 10, 2015 at 10:11 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi Helen!
On 08/08/2015 03:55 AM, Helen Fornazier wrote:
Hi!
I've made a first sketch about the API of the vimc driver (virtual
media controller) to configure the topology through user
[ cut here ]
WARNING: CPU: 1 PID: 813 at kernel/module.c:291
module_assert_mutex_or_preempt+0x49/0x90()
Modules linked in: mxl5007t af9013 ... dvb_usb_af9015(+) ... dvb_usb_v2
dvb_core rc_core ...
CPU: 1 PID: 813 Comm: systemd-udevd Not tainted
On 31.07.2015 17:55, Olli Salonen wrote:
Hi Poma,
Might I suggest reading points 9, 10 and 11 from the following document:
https://www.kernel.org/doc/Documentation/SubmittingPatches
Especially point 11 needs to be taken care of in order for your patch to be
merged.
Cheers,
-olli
This is a patch to the dm365_ipipe.c that fixes over 80 characters warning
detected.
Signed-off-by: Junsu Shin jjun...@gmail.com
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
On 08/11/2015 12:46 AM, poma wrote:
Furthermore, to fix this issue - AF9015 DVB-T USB2.0 stick brokenness - is the
responsibility of developers.
I am here only proven tester.
I hope we understand each other, and this problem will be resolved in good
faith.
Your patches are implemented
Hi Hans,
On 08/10/2015 05:22 PM, Hans Verkuil wrote:
On 07/31/2015 10:44 AM, Junghak Sung wrote:
Define enum vb2_buf_type and enum vb2_memory for videobuf2-core. This
change requires translation functions that could covert v4l2-core stuffs
to videobuf2-core stuffs in videobuf2-v4l2.c file.
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Aug 11 04:00:25 CEST 2015
git branch: test
git hash: 4dc102b2f53d63207fa12a6ad49c7b6448bc3301
gcc
On 08/10/2015 12:41 PM, Hans Verkuil wrote:
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
It is VIDIOC_G_FREQUENCY which does not use type to identify tuner,
not VIDIOC_S_FREQUENCY. VIDIOC_S_FREQUENCY uses both tuner and type
fields. One of these V4L API weirdness...
Actually, that's not
Hi, Hans and Mauro.
First of all, thank you for your reviews.
On 08/10/2015 08:44 PM, Hans Verkuil wrote:
On 08/10/2015 12:49 PM, Mauro Carvalho Chehab wrote:
Em Mon, 10 Aug 2015 12:11:39 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 08/10/2015 11:32 AM, Mauro Carvalho Chehab wrote:
Hi Mauro,
On 08/08/2015 01:33 PM, Mauro Carvalho Chehab wrote:
During the discussions at the Media Workshop, we came with some dot files that
would describe a hybrid PC-consumer TV stick with radio, analog video, analog
TV and digital TV on it.
I consolidated all the dot files we've worked
Em Mon, 10 Aug 2015 14:07:21 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Junghak,
I'm reviewing the header changes since I think there are several improvements
that can be done that will make things more logical and will simplify the
code.
My comments below are a mix of
Em Mon, 10 Aug 2015 14:43:50 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Mauro,
Thanks for the review!
On 08/08/2015 01:33 PM, Mauro Carvalho Chehab wrote:
During the discussions at the Media Workshop, we came with some dot files
that
would describe a hybrid PC-consumer TV
Hi Jungsak,
On 07/31/2015 10:44 AM, Junghak Sung wrote:
Hello everybody,
This is the 2nd round for refactoring Videobuf2(a.k.a VB2).
The purpose of this patch series is to separate existing VB2 framework
into core part and V4L2 specific part. So that not only V4L2 but also other
frameworks
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
Add new RF tuner gain control named RF Gain. That is aimed for first
amplifier chip right after antenna connector.
There is existing LNA Gain control, which is quite same, but it is
aimed for cases amplifier is integrated to tuner chip. Some
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
Add brief description for tuner RF gain control.
Cc: Hans Verkuil hverk...@xs4all.nl
Acked-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Antti Palosaari cr...@iki.fi
---
Documentation/DocBook/media/v4l/compat.xml | 4
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
Add type field to that struct like it counterpart v4l2_tuner
already has. We need type field to distinguish different tuner
types from each others for transmitter too.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
It is VIDIOC_G_FREQUENCY which does not use type to identify tuner,
not VIDIOC_S_FREQUENCY. VIDIOC_S_FREQUENCY uses both tuner and type
fields. One of these V4L API weirdness...
Actually, that's not what this is about. It's about whether
On 07/31/2015 10:44 AM, Junghak Sung wrote:
Define enum vb2_buf_type and enum vb2_memory for videobuf2-core. This
change requires translation functions that could covert v4l2-core stuffs
to videobuf2-core stuffs in videobuf2-v4l2.c file.
The v4l2-specific member variables(e.g. type, memory)
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
There is Avago MGA-81563 amplifier just right after antenna connector.
It could be turned on/off and its gain is around 12dB.
Signed-off-by: Antti Palosaari cr...@iki.fi
Acked-by: Hans Verkuil hans.verk...@cisco.com
---
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
Add new modulator type field to documentation.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
---
Documentation/DocBook/media/v4l/vidioc-g-modulator.xml | 8 +++-
1 file changed, 7 insertions(+), 1
Some comments below:
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
HackRF SDR device has both receiver and transmitter. There is limitation
that receiver and transmitter cannot be used at the same time
(half-duplex operation). That patch implements transmitter support to
existing receiver
Em Mon, 10 Aug 2015 10:31:03 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Jungsak,
On 07/31/2015 10:44 AM, Junghak Sung wrote:
Hello everybody,
This is the 2nd round for refactoring Videobuf2(a.k.a VB2).
The purpose of this patch series is to separate existing VB2 framework
Hi Junghak,
On 07/31/2015 10:44 AM, Junghak Sung wrote:
Rename file name - from videobuf2-core.[ch] to videobuf2-v4l2.[ch]
This renaming patch should be accompanied by the modifications for all device
drivers that include this header file. It can be done with just running this
shell script.
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
Implement single funtion, hackrf_set_params(), which handles all
needed settings. Controls and other IOCTLs are just wrappers to that
function. That way we can get easily better control what we could do
on different device states - sleeping,
On 07/31/2015 04:10 AM, Antti Palosaari wrote:
Add V4L2_TUNER_SDR and V4L2_TUNER_RF to supported tuner types to
table.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
---
Documentation/DocBook/media/v4l/vidioc-g-tuner.xml | 10 ++
1 file changed,
On 08/10/2015 11:32 AM, Mauro Carvalho Chehab wrote:
Em Mon, 10 Aug 2015 10:31:03 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Jungsak,
On 07/31/2015 10:44 AM, Junghak Sung wrote:
Hello everybody,
This is the 2nd round for refactoring Videobuf2(a.k.a VB2).
The purpose of this
Em Mon, 10 Aug 2015 12:11:39 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 08/10/2015 11:32 AM, Mauro Carvalho Chehab wrote:
Em Mon, 10 Aug 2015 10:31:03 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Jungsak,
On 07/31/2015 10:44 AM, Junghak Sung wrote:
Hello everybody,
Hi Helen!
On 08/08/2015 03:55 AM, Helen Fornazier wrote:
Hi!
I've made a first sketch about the API of the vimc driver (virtual
media controller) to configure the topology through user space.
As first suggested by Laurent Pinchart, it is based on configfs.
I would like to know you
Em Mon, 10 Aug 2015 10:05:24 -0300
Mauro Carvalho Chehab mche...@osg.samsung.com escreveu:
Em Mon, 10 Aug 2015 14:43:50 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Mauro,
Thanks for the review!
On 08/08/2015 01:33 PM, Mauro Carvalho Chehab wrote:
During the discussions
On 08/10/2015 02:55 PM, Mauro Carvalho Chehab wrote:
Em Mon, 10 Aug 2015 14:07:21 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Junghak,
I'm reviewing the header changes since I think there are several improvements
that can be done that will make things more logical and will simplify
On 08/10/2015 03:19 PM, Mauro Carvalho Chehab wrote:
Em Mon, 10 Aug 2015 10:05:24 -0300
Mauro Carvalho Chehab mche...@osg.samsung.com escreveu:
Em Mon, 10 Aug 2015 14:43:50 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Mauro,
Thanks for the review!
On 08/08/2015 01:33 PM, Mauro
On 08/10/2015 12:49 PM, Mauro Carvalho Chehab wrote:
Em Mon, 10 Aug 2015 12:11:39 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 08/10/2015 11:32 AM, Mauro Carvalho Chehab wrote:
Em Mon, 10 Aug 2015 10:31:03 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Jungsak,
On 07/31/2015
Hi Junghak,
I'm reviewing the header changes since I think there are several improvements
that can be done that will make things more logical and will simplify the code.
My comments below are a mix of suggestions for improvement and brainstorming.
Feel free to ask for clarification if something
Hello Hans, Sakari and Laurent:
I am back from holidays :). Shall I prepare a new patchset with the
suggestion from Hans?
Thanks!
On Mon, Jul 20, 2015 at 4:31 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On 07/20/2015 03:52 PM, Ricardo Ribalda Delgado wrote:
Hello
I have no preference over
On 07/14/2015 04:32 PM, Laurent Pinchart wrote:
Hi Hans,
On Tuesday 14 July 2015 16:19:50 Hans Verkuil wrote:
On 07/13/15 10:03, Sakari Ailus wrote:
Helen Fornazier wrote:
On Tue, Jun 30, 2015 at 4:26 PM, Helen Fornazier wrote:
On Tue, Jun 30, 2015 at 6:19 AM, Sakari Ailus wrote:
Laurent
38 matches
Mail list logo
