Hi Hans,
On Wed, Nov 15, 2017 at 7:12 PM, Hans Verkuil wrote:
> Hi Alexandre,
>
> On 15/11/17 10:38, Alexandre Courbot wrote:
>> Hi Hans!
>>
>> Thanks for the patchset! It looks quite good at first sight, a few comments
>> and
>> questions follow though.
>>
>> On Monday, November 13, 2017 11:34:
On 16/11/17 09:48, Alexandre Courbot wrote:
> Hi Hans,
>
> On Wed, Nov 15, 2017 at 7:12 PM, Hans Verkuil wrote:
>> Hi Alexandre,
>>
>> On 15/11/17 10:38, Alexandre Courbot wrote:
>>> Hi Hans!
>>>
>>> Thanks for the patchset! It looks quite good at first sight, a few comments
>>> and
>>> question
Hi Jacopo,
Thanks for the patch. I think you could add this to v2 of your related set;
that way it'll be easy to get the dependencies right. I don't think this is
urgent either...
On Wed, Nov 15, 2017 at 06:59:12PM +0100, Jacopo Mondi wrote:
> videobuf2 core reports an error when not all buffers
With gcc-4.1.2:
drivers/media/dvb-core/dvb_frontend.c: In function
‘dvb_frontend_handle_ioctl’:
drivers/media/dvb-core/dvb_frontend.c:2110: warning: ‘err’ may be used
uninitialized in this function
Indeed, there are 13 cases where err is used initialized if one of the
dvb_frontend_ops i
Hi,
I'm not sure why there's so many recipients (Russell, Rob or Mark have
a limited interest in this I assume), and why you're also missing some
key ones (like the v4l2 list).
On Thu, Nov 16, 2017 at 11:37:30AM +0100, Giulio Benetti wrote:
> Il 16/11/2017 11:31, Andreas Baierl ha scritto:
> > Am
Em Wed, 15 Nov 2017 12:33:35 +0100
Rafaël Carré escreveu:
At v4l-utils, we're using about the same submission rules as with the Linux
Kernel. So, I would be expecting a patch description and, most importantly,
a Signed-off-by.
> ---
> lib/include/libdvbv5/dvb-dev.h | 3 ++-
> lib/include/libd
Em Wed, 15 Nov 2017 12:33:36 +0100
Rafaël Carré escreveu:
> ---
> utils/dvb/dvbv5-daemon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/dvb/dvbv5-daemon.c b/utils/dvb/dvbv5-daemon.c
> index 58485ac6..711694e0 100644
> --- a/utils/dvb/dvbv5-daemon.c
> +++ b/util
Em Wed, 15 Nov 2017 11:47:11 +0100
Rafaël Carré escreveu:
> This makes it possible to poll a local device.
> Getting the fd is preferrable to adding a dvb_dev_poll() function,
> because we can poll several fds together in an event-based program.
>
> This is not implemented for remote devices, as
Em Wed, 15 Nov 2017 15:25:39 +0100
Rafaël Carré escreveu:
> This makes it possible to poll a local device.
> Getting the fd is preferrable to adding a dvb_dev_poll() function,
> because we can poll several fds together in an event-based program.
>
> This is not implemented for remote devices, as
Em Tue, 14 Nov 2017 12:15:26 +0100
Rafaël Carré escreveu:
> Issue spotted by valgrind:
>
> ==5290== Invalid free() / delete / delete[] / realloc()
> ==5290==at 0x4C30D3B: free (in
> /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==5290==by 0x4E54401: free_dvb_dev (dvb-dev.c:49)
On 16/11/2017 12:25, Mauro Carvalho Chehab wrote:
> Em Wed, 15 Nov 2017 12:33:36 +0100
> Rafaël Carré escreveu:
>
>> ---
>> utils/dvb/dvbv5-daemon.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/utils/dvb/dvbv5-daemon.c b/utils/dvb/dvbv5-daemon.c
>> index 58485ac6..
On Thu, Nov 16, 2017 at 11:51 AM, Geert Uytterhoeven
wrote:
> With gcc-4.1.2:
>
> drivers/media/dvb-core/dvb_frontend.c: In function
> ‘dvb_frontend_handle_ioctl’:
> drivers/media/dvb-core/dvb_frontend.c:2110: warning: ‘err’ may be used
> uninitialized in this function
>
> Indeed, there
On 15/11/2017 15:25, Rafaël Carré wrote:
> This makes it possible to poll a local device.
> Getting the fd is preferrable to adding a dvb_dev_poll() function,
> because we can poll several fds together in an event-based program.
>
> This is not implemented for remote devices, as polling a remote f
Em Thu, 16 Nov 2017 12:36:24 +0100
Rafaël Carré escreveu:
> On 16/11/2017 12:25, Mauro Carvalho Chehab wrote:
> > Em Wed, 15 Nov 2017 12:33:36 +0100
> > Rafaël Carré escreveu:
> >
> >> ---
> >> utils/dvb/dvbv5-daemon.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff
Hello,
this series documents VIN related dt-bindings for r8a774[35], and adds VIN[012]
nodes to the r8a7743 SoC dtsi.
Best regards,
Fabrizio Castro (2):
dt-bindings: media: rcar_vin: add device tree support for r8a774[35]
ARM: dts: r8a7743: add VIN dt support
.../devicetree/bindings/media/
Add compatible strings for r8a7743 and r8a7745. No driver change
change is needed as "renesas,rcar-gen2-vin" will activate the right
code. However, it is good practice to document compatible strings
for the specific SoC as this allows SoC specific changes to the
driver if needed, in addition to doc
Hi Laurent,
Thank you for the initiative to bring up and address the matter!
On Thu, Nov 16, 2017 at 02:33:48AM +0200, Laurent Pinchart wrote:
> Device unplug being asynchronous, it naturally races with operations
> performed by userspace through ioctls or other file operations on video
> device
On Thu, Nov 16, 2017 at 02:33:49AM +0200, Laurent Pinchart wrote:
> To avoid races between device access and unplug, call the
> video_device_unplug() function in the platform driver remove handler.
> This will unsure that all device access completes before the remove
> handler proceeds to free reso
Hi,
Il 16/11/2017 12:02, Maxime Ripard ha scritto:
Hi,
I'm not sure why there's so many recipients (Russell, Rob or Mark have
a limited interest in this I assume), and why you're also missing some
key ones (like the v4l2 list).
added in cc linux-media mailing list that appears to be the right
On Thu, Nov 16, 2017 at 01:30:52PM +0100, Giulio Benetti wrote:
> > On Thu, Nov 16, 2017 at 11:37:30AM +0100, Giulio Benetti wrote:
> > > Il 16/11/2017 11:31, Andreas Baierl ha scritto:
> > > > Am 16.11.2017 um 11:13 schrieb Giulio Benetti:
> > > > > Hello,
> > > > >
> > > > Hello,
> > > > > I'm w
Il 16/11/2017 13:53, Maxime Ripard ha scritto:
On Thu, Nov 16, 2017 at 01:30:52PM +0100, Giulio Benetti wrote:
On Thu, Nov 16, 2017 at 11:37:30AM +0100, Giulio Benetti wrote:
Il 16/11/2017 11:31, Andreas Baierl ha scritto:
Am 16.11.2017 um 11:13 schrieb Giulio Benetti:
Hello,
Hello,
I'm wo
On 16/11/17 13:57, Giulio Benetti wrote:
> Il 16/11/2017 13:53, Maxime Ripard ha scritto:
>> On Thu, Nov 16, 2017 at 01:30:52PM +0100, Giulio Benetti wrote:
On Thu, Nov 16, 2017 at 11:37:30AM +0100, Giulio Benetti wrote:
> Il 16/11/2017 11:31, Andreas Baierl ha scritto:
>> Am 16.11.201
Hi Hans,
Il 16/11/2017 14:12, Hans Verkuil ha scritto:
On 16/11/17 13:57, Giulio Benetti wrote:
Il 16/11/2017 13:53, Maxime Ripard ha scritto:
On Thu, Nov 16, 2017 at 01:30:52PM +0100, Giulio Benetti wrote:
On Thu, Nov 16, 2017 at 11:37:30AM +0100, Giulio Benetti wrote:
Il 16/11/2017 11:31,
On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro
wrote:
> Add compatible strings for r8a7743 and r8a7745. No driver change
> change is needed as "renesas,rcar-gen2-vin" will activate the right
double "change"
> code. However, it is good practice to document compatible strings
> for the specific
On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro
wrote:
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -14,7 +14,10 @@ channel which can be either RGB, YUYV or BT656.
> - "renesas,vin-r8a7790" for the R8A7790 devic
On Thu, Nov 16, 2017 at 02:17:08PM +0100, Giulio Benetti wrote:
> Hi Hans,
>
> Il 16/11/2017 14:12, Hans Verkuil ha scritto:
> > On 16/11/17 13:57, Giulio Benetti wrote:
> > > Il 16/11/2017 13:53, Maxime Ripard ha scritto:
> > > > On Thu, Nov 16, 2017 at 01:30:52PM +0100, Giulio Benetti wrote:
> >
Hello Geert,
thank you for your comment!
> > Add compatible strings for r8a7743 and r8a7745. No driver change
> > change is needed as "renesas,rcar-gen2-vin" will activate the right
>
> double "change"
ps, do you think a v2 is in order?
Thanks,
Fab
Renesas Electronics Europe Ltd, Dukes M
On 16/11/17 14:17, Giulio Benetti wrote:
> Hi Hans,
>
> Il 16/11/2017 14:12, Hans Verkuil ha scritto:
>> On 16/11/17 13:57, Giulio Benetti wrote:
>>> Il 16/11/2017 13:53, Maxime Ripard ha scritto:
On Thu, Nov 16, 2017 at 01:30:52PM +0100, Giulio Benetti wrote:
>> On Thu, Nov 16, 2017 at 1
Add RGB565 (LE & BE) and YUV422 YUYV format in addition
to existing YUV422 UYVY format.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 79 +-
1 file changed, 71 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/dr
Enhance OV5640 CSI driver to support also DVP parallel interface.
Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing
YUV422 UYVY format.
Some other improvements on chip identifier check and removal
of warnings in powering phase around gpio handling.
Hugues Fruchet (4):
media: ov
Add support of DVP parallel mode in addition of
existing MIPI CSI mode. The choice between two modes
and configuration is made through device tree.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 112 +
1 file changed, 94 insertions(+),
Switch gpiod_set_value to gpiod_set_value_cansleep to avoid
warnings when powering sensor.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index c89ed6
Hi,
Il 16/11/2017 14:39, Maxime Ripard ha scritto:
On Thu, Nov 16, 2017 at 02:17:08PM +0100, Giulio Benetti wrote:
Hi Hans,
Il 16/11/2017 14:12, Hans Verkuil ha scritto:
On 16/11/17 13:57, Giulio Benetti wrote:
Il 16/11/2017 13:53, Maxime Ripard ha scritto:
On Thu, Nov 16, 2017 at 01:30:52P
Verify that chip identifier is correct before starting streaming
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 61071f5..
Hello Geert,
thank you for your comment!
> Subject: Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree
> support for r8a774[35]
>
> On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro
> wrote:
> > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> > +++ b/Documentation/devicet
Hi Fabrizio,
On Thu, Nov 16, 2017 at 2:45 PM, Fabrizio Castro
wrote:
>> Subject: Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree
>> support for r8a774[35]
>>
>> On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro
>> wrote:
>> > --- a/Documentation/devicetree/bindings/media/rcar_vin.t
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
HDMI 2.0 Appendix F suggest that we should keep sending the infoframe
when switching from 3D to 2D mode, even if the infoframe isn't strictly
necessary (ie. not needed to transmit the VIC or stereo information)
Hi Laurent,
On 16/11/17 12:32, Sakari Ailus wrote:
> Hi Laurent,
>
> Thank you for the initiative to bring up and address the matter!
I concur - this looks like a good start towards managing the issue.
One potential thing spotted on top of Sakari's review inline below, of course I
suspect this
Avoid using line continations in formats as that causes unexpected
output.
Joe Perches (4):
rk3399_dmc: Fix line continuation format
drm: amd: Fix line continuation formats
[media] dibx000_common: Fix line continuation format
ima: Fix line continuation format
drivers/devfreq/rk3399_dmc.c
Line continuations with excess spacing causes unexpected output.
Signed-off-by: Joe Perches
---
drivers/media/dvb-frontends/dibx000_common.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb-frontends/dibx000_common.c
b/drivers/media/dvb-frontends/dib
The following commit introduced a regression
commit d57ea877af38057b0ef31758cf3b99765dc33695
Author: Sean Young
Date: Wed Aug 9 13:19:16 2017 -0400
media: rc: per-protocol repeat period
CEC needs a keypress timeout of 550ms, which is too high for the IR
protocols. Also fill in kno
Hi Sakari,
On 2017-11-16 14:36:24 +0200, Sakari Ailus wrote:
> On Thu, Nov 16, 2017 at 02:33:49AM +0200, Laurent Pinchart wrote:
> > To avoid races between device access and unplug, call the
> > video_device_unplug() function in the platform driver remove handler.
> > This will unsure that all dev
On Thu, Nov 16, 2017 at 08:06:18PM +0530, Sharma, Shashank wrote:
> Regards
>
> Shashank
>
>
> On 11/13/2017 10:34 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > HDMI 2.0 Appendix F suggest that we should keep sending the infoframe
> > when switching from 3D to 2D mode, even if the in
This is useful if an application is using 2 different devices,
and want logging to be split by device, or if application logging
needs some private context.
Care has been taken to not break the API/ABI and only add new functions,
or only modify private structures.
A drawback is that when dvb_fe_o
On Thu, Nov 16, 2017 at 04:27:01PM +0100, Matthias Reichl wrote:
> The following commit introduced a regression
>
> commit d57ea877af38057b0ef31758cf3b99765dc33695
> Author: Sean Young
> Date: Wed Aug 9 13:19:16 2017 -0400
>
> media: rc: per-protocol repeat period
>
> CEC needs a keyp
On Thu, 2017-11-16 at 07:27 -0800, Joe Perches wrote:
> Avoid using line continations in formats as that causes unexpected
> output.
Is having lines greater than 80 characters the preferred method?
Could you add quotes before the backlash and before the first word on
the next line instead?
Mimi
On Thu, 2017-11-16 at 12:11 -0500, Mimi Zohar wrote:
> On Thu, 2017-11-16 at 07:27 -0800, Joe Perches wrote:
> > Avoid using line continations in formats as that causes unexpected
> > output.
>
> Is having lines greater than 80 characters the preferred method?
yes.
> Could you add quotes before
Hi Laurent,
Thankyou for the review, and your patience on the long awaited response on these
remaining patches.
On 17/08/17 19:10, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Monday 14 Aug 2017 16:13:30 Kieran Bingham wrote:
>> We are now able to configure a pipelin
Hi Geert,
> >>
> >> Please keep the list sorted by SoC part number.
> >
> > It is sorted, just in descending order. Do you want me to re-order the full
> > list in ascending order?
>
> That may be a good idea, given the current order is non-standard and
> counter-intuitive.
sure, dropping this s
Hello,
this series documents VIN related dt-bindings for r8a774[35], adds VIN[012]
nodes to the r8a7743 SoC dtsi and adds VIN[01] nodes to the r8a7745 SoC dtsi.
Best regards,
Fabrizio Castro (4):
dt-bindings: media: rcar_vin: Reverse SoC part number list
dt-bindings: media: rcar_vin: add dev
Add compatible strings for r8a7743 and r8a7745. No driver change
is needed as "renesas,rcar-gen2-vin" will activate the right code.
However, it is good practice to document compatible strings for the
specific SoC as this allows SoC specific changes to the driver if
needed, in addition to document S
Change the sorting of the part numbers from descending to ascending to
match with other documentation.
Signed-off-by: Fabrizio Castro
Reviewed-by: Biju Das
---
v1->v2:
* new patch triggered by Geert's comment, see the below link for details:
https://www.mail-archive.com/linux-media@vger.kernel
On Thu, 2017-11-16 at 09:17 -0800, Joe Perches wrote:
> On Thu, 2017-11-16 at 12:11 -0500, Mimi Zohar wrote:
> > On Thu, 2017-11-16 at 07:27 -0800, Joe Perches wrote:
> > > Avoid using line continations in formats as that causes unexpected
> > > output.
> >
> > Is having lines greater than 80 char
Le jeudi 16 novembre 2017 à 12:02 +0100, Maxime Ripard a écrit :
> Assuming that the request API is in, we'd need to:
> - Finish the MPEG4 support
> - Work on more useful codecs (H264 comes to my mind)
For which we will have to review the tables and make sure they match
the spec (the easy part
Since commit d57ea877af38 ("media: rc: per-protocol repeat period"),
double keypresses are reported on the ite-cir driver. This is due
two factors: that commit reduced the timeout used for some protocols
(it became protocol dependant) and the high default IR timeout used
by the ite-cir driver.
Som
From: Dan Gopstein
Two definitions of the ABS (absolute value) macro fail to parenthesize their
parameter properly. This can lead to a bad expansion for low-precedence
expression arguments. Add parens to protect against troublesome arguments.
Signed-off-by: Dan Gopstein
---
See an example bad u
Hi Jacopo,
On Wed, Nov 15, 2017 at 03:25:11PM +0100, jacopo mondi wrote:
> Hi Sakari,
>thanks for review!
You're welcome!
> On Wed, Nov 15, 2017 at 02:45:51PM +0200, Sakari Ailus wrote:
> > Hi Jacopo,
> >
> > Could you remove the original driver and send the patch using git
> > send-email -C
Hi Jacopo,
On Wed, Nov 15, 2017 at 11:56:01AM +0100, Jacopo Mondi wrote:
> Remove soc_camera framework dependencies from ov772x sensor driver.
> - Handle clock directly
> - Register async subdevice
> - Add platform specific enable/disable functions
> - Adjust build system
>
> This commit does not
Hi Sakari and all,
> -Original Message-
> From: Zhi, Yong
> Sent: Tuesday, October 17, 2017 8:47 PM
> To: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com
> Cc: Zheng, Jian Xu ; Mani, Rajmohan
> ; Toivonen, Tuukka
> ; Hu, Jerry W ;
> a...@arndb.de; h...@lst.de; robin.mur...@arm.co
Regards
Shashank
On 11/16/2017 9:46 PM, Ville Syrjälä wrote:
On Thu, Nov 16, 2017 at 08:06:18PM +0530, Sharma, Shashank wrote:
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
HDMI 2.0 Appendix F suggest that we should keep sending the infoframe
when swi
On Thu, Nov 16, 2017 at 6:13 PM, Hans Verkuil wrote:
> On 16/11/17 09:48, Alexandre Courbot wrote:
>> Hi Hans,
>>
>> On Wed, Nov 15, 2017 at 7:12 PM, Hans Verkuil wrote:
>>> Hi Alexandre,
>>>
>>> On 15/11/17 10:38, Alexandre Courbot wrote:
Hi Hans!
Thanks for the patchset! It looks
Hi Dan,
On Thu, Nov 16, 2017 at 06:09:20PM -0500, Dan Gopstein wrote:
> From: Dan Gopstein
>
> Two definitions of the ABS (absolute value) macro fail to parenthesize their
> parameter properly. This can lead to a bad expansion for low-precedence
> expression arguments. Add parens to protect agai
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Nov 17 05:00:25 CET 2017
media-tree git hash:30b4e122d71cbec2944a5f8b558b88936ee42f10
media_build git
On Thursday, November 16, 2017 2:10:49 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan
We use ordered_in_driver property to optimize for the case where
the driver can deliver the buffers in an ordered fashion. When it
is ordered we can use the same fence context for all fences, but
when it
Hi Gustavo,
I am coming a bit late in this series' review, so apologies if some of my
comments have already have been discussed in an earlier revision.
On Thursday, November 16, 2017 2:10:53 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan
Receive in-fence from userspace and add support f
On Thursday, November 16, 2017 2:10:54 AM JST, Gustavo Padovan wrote:
From: Javier Martinez Canillas
Add a videobuf2-fence.h header file that contains different helpers
for DMA buffer sharing explicit fence support in videobuf2.
v2: - use fence context provided by the caller in vb2_fence_a
On Friday, November 17, 2017 4:02:56 PM JST, Alexandre Courbot wrote:
On Thursday, November 16, 2017 2:10:54 AM JST, Gustavo Padovan wrote:
From: Javier Martinez Canillas
Add a videobuf2-fence.h header file that contains different helpers
for DMA buffer sharing explicit fence support in videob
On Thursday, November 16, 2017 2:10:55 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan
Add vb2_setup_out_fence() and the needed members to struct vb2_buffer.
v3:
- Do not hold yet another ref to the out_fence (Brian Starkey)
v2: - change it to reflect fd_install at DQEVENT
On Friday, November 17, 2017 4:19:00 PM JST, Alexandre Courbot wrote:
On Thursday, November 16, 2017 2:10:55 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan
Add vb2_setup_out_fence() and the needed members to struct vb2_buffer.
v3:
- Do not hold yet another ref to the out_fence (
On Thursday, November 16, 2017 2:10:56 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan
If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create
an out_fence and send its fd to userspace on the fence_fd field as a
return arg for the QBUF call.
The fence is signaled on buffer_d
70 matches
Mail list logo