On Tue, Feb 20, 2018 at 5:44 AM, Alexandre Courbot
wrote:
> Add a v4l2 request entity data structure that takes care of storing the
> request-related state of a V4L2 device ; in this case, its controls.
>
> Signed-off-by: Alexandre Courbot
> --- /dev/null
> +++ b/drivers/media/v4l2-core/v4l2-r
Fix a coding style problem.
Signed-off-by: Quytelda Kahja
---
This is the patch without the unnecessary fixes for line length.
drivers/staging/media/bcm2048/radio-bcm2048.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/bcm2048
Good day dear, i hope this mail meets you well? my name is Jack, from the U.S.
I know this may seem inappropriate so i ask for your forgiveness but i wish to
get to know you better, if I may be so bold. I consider myself an easy-going
man, adventurous, honest and fun loving person but I am curre
Fixes: 42b7d5be5f1f ("media: i2c: ov772x: Support frame interval handling")
Signed-off-by: Fengguang Wu
---
ov772x.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
index eba71d97..0d8ce2a 100644
--- a/drivers/media/i
Hi Jacopo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16-rc2 next-20180220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
(resending with correct word-wrap - sorry for the inconvenience)
Hi everyone,
And thanks for all the feedback on the previous version! I have tried to address
as much as possible, which results in (another) almost rewrite. But I think the
behavior and structure are converging to something satisfy
From: Hans Verkuil
Add a 'bool from_other_dev' argument: set to true if the two
handlers refer to different devices (e.g. it is true when
inheriting controls from a subdev into a main v4l2 bridge
driver).
This will be used later when implementing support for the
request API since we need to skip
Hi everyone,
And thanks for all the feedback on the previous version! I have tried to
address as much as possible, which results in (another) almost rewrite. But I
think the behavior and structure are converging to something satisfying and
usable.
Besides the buffer queuing behavior that has b
From: Hans Verkuil
Add a refcount and is_request bool to struct v4l2_ctrl_handler:
this is used to refcount a handler that represents a request.
Add a p_req field to struct v4l2_ctrl_ref that will store the
request value.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
---
drive
From: Hans Verkuil
Add the four core request functions:
v4l2_ctrl_request_init() initializes a new (empty) request.
v4l2_ctrl_request_clone() resets a request based on another request
(or clears it if that request is NULL).
v4l2_ctrl_request_get(): increase refcount
v4l2_ctrl_request_put(): decr
From: Hans Verkuil
The v4l2_g/s_ext_ctrls functions now support control handlers that
represent requests.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ctrls.c | 37 +---
1 file changed, 33 insertions(+), 4 deletions(-)
From: Hans Verkuil
Add a helper function that can set controls from a request.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ctrls.c | 71
include/media/v4l2-ctrls.h | 2 +
2 files changed, 73 insertions(+
From: Hans Verkuil
The next patch needs the reference to a control instead of the
control itself, so change struct v4l2_ctrl_helper accordingly.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ctrls.c | 18 +-
1 file changed, 9 ins
Only standard controls can be successfully cloned: handler_new_ref, used
by v4l2_ctrl_request_clone(), forcibly calls v4l2_ctrl_new_std() which
fails to find custom controls names, and we eventually hit the condition
that name == NULL in v4l2_ctrl_new().
This prevents us from using non-standard co
From: Hans Verkuil
When queuing buffers allow for passing the request that should
be associated with this buffer.
Signed-off-by: Hans Verkuil
[acour...@chromium.org: make request ID 32-bit]
Signed-off-by: Alexandre Courbot
---
drivers/media/common/videobuf2/videobuf2-v4l2.c | 2 +-
drivers/me
Allow drivers to assign a request entity to v4l2_fh. This will be useful
for request-aware ioctls to find out which request entity to use.
Signed-off-by: Alexandre Courbot
---
include/media/v4l2-fh.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/media/v4l2-fh.h b/include/media/v
Add a v4l2 request entity data structure that takes care of storing the
request-related state of a V4L2 device ; in this case, its controls.
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/Makefile | 1 +
drivers/media/v4l2-core/v4l2-request.c | 178 +
Make vb2 core aware of requests. Drivers can specify whether a given
queue accepts requests or not.
Signed-off-by: Alexandre Courbot
---
drivers/media/common/videobuf2/videobuf2-core.c | 3 +++
include/media/videobuf2-core.h | 4
2 files changed, 7 insertions(+)
diff --git
Add generic support for requests to the mem2mem framework. This just
requires calling vb2_qbuf_request() instead of vb2_qbuf() in
v4l2_m2m_qbuf().
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dri
Add a new vb2_qbuf_request() (a request-aware version of vb2_qbuf())
that request-aware drivers can call to queue a buffer into a request
instead of directly into the vb2 queue if relevent.
This function expects that drivers invoking it are using instances of
v4l2_request_entity and v4l2_request_e
Allow to specify a request to be used with the S_EXT_CTRLS and
G_EXT_CTRLS operations.
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
include/uapi/linux/videodev2.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2
Read and use the request_fd field of struct v4l2_ext_controls to apply
VIDIOC_G_EXT_CTRLS or VIDIOC_S_EXT_CTRLS to a request when asked by
userspace.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/omap3isp/ispvideo.c | 2 +-
drivers/media/v4l2-core/v4l2-ctrls.c | 98 +
Add a new VIDIOC_NEW_REQUEST ioctl, which allows to instanciate requests
on devices that support the request API. Requests created that way can
only control the device they originate from, making them suitable for
simple devices, but not complex pipelines.
Signed-off-by: Alexandre Courbot
---
Do
Allow to use requests with the video capture device.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/vivid/Kconfig | 1 +
drivers/media/platform/vivid/vivid-core.c | 63 ++-
drivers/media/platform/vivid/vivid-core.h | 3 +
.../media/platform/vivid/v
Document the request API for V4L2 devices, and amend the documentation
of system calls influenced by it.
Signed-off-by: Alexandre Courbot
---
Documentation/media/uapi/v4l/buffer.rst | 9 +-
Documentation/media/uapi/v4l/common.rst | 1 +
Documentation/media/uapi/v4l/request-api.rs
Add a new MEDIA_IOC_NEW_REQUEST ioctl, which can be used to instantiate
a request suitable to control the media device topology as well as the
parameters and buffer flow of its entities.
This is still very early work, and mainly here to demonstrate that it is
still possible to bind requests to med
Set the necessary ops for supporting requests in vim2m.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/Kconfig | 1 +
drivers/media/platform/vim2m.c | 75 ++
2 files changed, 76 insertions(+)
diff --git a/drivers/media/platform/Kconfig b/drivers/med
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Feb 20 05:00:11 CET 2018
media-tree git hash:29422737017b866d4a51014cc7522fa3a99e8852
media_build git
The request API provides a way to group buffers and device parameters
into units of work to be queued and executed. This patch introduces the
UAPI and core framework.
This patch is based on the previous work by Laurent Pinchart. The core
has changed considerably, but the UAPI is mostly untouched.
Hi Jacopo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16-rc2 next-20180220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
Hi Jacopo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.16-rc2 next-20180220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
Hi Maciej,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16-rc2 next-20180219]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
Hi Maciej,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.16-rc2 next-20180219]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
Hi Maciej,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.16-rc2 next-20180219]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
Hi Maciej,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16-rc2 next-20180219]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
Hi Hans,
Thanks for your feedback.
[snip]
> > >>> Can you then fix v4l2-compliance to stop testing colorspace
> > >>> against 0xff
> > >>> ?
> > >>
> > >> For now I can simply relax this test for subdevs with sources and sinks.
> > >
> > > You also need to relax it for video nodes with MC dri
Hi Jacopo,
On Fri, Feb 16, 2018 at 11:05:00AM +0100, jacopo mondi wrote:
...
> > + /* Update the power count. */
> > + ov7251->power_count += on ? 1 : -1;
> > + WARN_ON(ov7251->power_count < 0);
>
> Is this 'reference counting' necessary? If you receive three
> s_power(1) you would need thr
Hi Mauro,
Here's the first pile of sensor and lens driver patches for 4.17.
The most noteworthy parts are perhaps
- moving unmaintained imx074 and mt9t031 SoC camera drivers to staging in
hope someone would start looking after them,
- add DT bindings and driver upport for the bindings for ov9
On Wed, Jan 24, 2018 at 10:30:50AM +0100, Jacopo Mondi wrote:
> ov7670 driver supports two optional properties supplied through platform
> data, but currently does not support any standard video interface
> property.
>
> Add support through OF parsing for 2 generic properties (vsync and hsync
> po
Dear all,
I am using a Libre Computer Le Potato SBC (see here:
https://libre.computer/products/boards/aml-s905x-cc/) with LibreELEC 8
Leia from adamg (community build). Included there is a driver for em28xx
based DVB cards, which in the log refers to the email address I am
sending this to - s
Hi Hans,
Thank you for the patch.
On Monday, 19 February 2018 15:12:05 EET Hans Verkuil wrote:
> The v4l2_subdev core s_power op was used to two different things: power
> on/off sensors or video decoders/encoders and to put a tuner in standby
> (and only the tuner). There is no 'tuner wakeup' op,
Hi Jacopo,
Thank you for the patch.
On Monday, 19 February 2018 18:59:44 EET Jacopo Mondi wrote:
> The sensor driver sets mbus format colorspace information and sizes,
> but not ycbcr encoding, quantization and xfer function. When supplied
> with an badly initialized mbus frame format structure,
Hi Alexandre-Xavier,
On Monday, 19 February 2018 19:29:24 EET Alexandre-Xavier Labonté-Lamoureux
wrote:
> Hi Kieran,
>
> This is how I built the drivers:
>
> $ git clone --depth=1 git://linuxtv.org/media_build.git
> $ cd media_build
> $ ./build --main-git
>
> I then installed the newly built k
ested N9 and capture appears to be working from the CSI-2 receiver
> (media tree master, i.e. v4.15-rc3 now).
>
> Which pipeline did you use?
I tested next-20180219 and camera does not work there. It leads to
nasty oops. I tried to capture the oops with dmesg > file, and that
one oopse
Em Mon, 19 Feb 2018 17:27:52 +0300
Dan Carpenter escreveu:
> [ This is obviously ancient code. It's probably fine. I've just been
> going through all array overflow warnings recently. - dan ]
>
> Hello Mauro Carvalho Chehab,
>
> The patch 12db56071b47: "V4L/DVB (3420): Added iocls to confi
Hello Markus,
On Monday, 19 February 2018 20:11:56 EET SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 19 Feb 2018 18:50:40 +0100
>
> Adjust jump targets so that a bit of exception handling can be better
> reused at the end of these functions.
>
> This issue was partly detected by
HI Maciej,
Just sharing a couple of fly-by ideas - please don't read too much into them.
On 19 February 2018 at 15:43, Maciej Purski wrote:
> When a driver is going to use clk_bulk_get() function, it has to
> initialize an array of clk_bulk_data, by filling its id fields.
>
> Add a new function
On 02/16/2018 07:03 PM, Steve Longerbeam wrote:
> On 02/14/2018 07:44 AM, Fabio Estevam wrote:
> > [Adding Steve and Philipp in case they could provide some suggestions]
> >
> > On Wed, Feb 14, 2018 at 1:21 PM, Matthew Starr
> wrote:
> >> I have successfully modified device tree files in the mainl
From: Markus Elfring
Date: Mon, 19 Feb 2018 18:50:40 +0100
Adjust jump targets so that a bit of exception handling can be better
reused at the end of these functions.
This issue was partly detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
v2:
Hans Verkuil insisted o
Hi Kieran,
This is how I built the drivers:
$ git clone --depth=1 git://linuxtv.org/media_build.git
$ cd media_build
$ ./build --main-git
I then installed the newly built kernel modules:
$ sudo make install
Once the modules were updated, I restarted my computer to make sure
every module got re
Hi Jacopo,
On 16.02.2018 12:05, jacopo mondi wrote:
> Hi Todor,
> thanks for the patch.
>
> Is the datsheet for this sensor public? I failed to find any reference
> to it online, am I wrong?
Thank you for the review!
The datasheet is not public.
>
> On Thu, Feb 08, 2018 at 10:53:38AM +0200
Hello,
finally I addressed Laurent's comment on ov772x frame rate handling, which
I almost forgot about :)
Also, Sergei reported that the ceu node name should be generic, so I changed it
to "ceu: camera@e821".
All patches but the trivial [11/11] one are now reviewed/acked. Hope this is
las
Add renesas-ceu header file.
Do not remove the existing sh_mobile_ceu.h one as long as the original
driver does not go away.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
include/media/drv-intf/renesas-ceu.h | 26 ++
1 file change
Add bindings documentation for Renesas Capture Engine Unit (CEU).
Signed-off-by: Jacopo Mondi
Reviewed-by: Rob Herring
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
.../devicetree/bindings/media/renesas,ceu.txt | 81 ++
1 file changed, 81 insertions(+)
cre
Add driver for Renesas Capture Engine Unit (CEU).
The CEU interface supports capturing 'data' (YUV422) and 'images'
(NV[12|21|16|61]).
This driver aims to replace the soc_camera-based sh_mobile_ceu one.
Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ
platform GR-Peach.
T
Add Capture Engine Unit (CEU) node to device tree.
Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/arm/boot/dts/r7s72100.dtsi | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/arm
Remove soc_camera framework dependencies from ov772x sensor driver.
- Handle clock and gpios
- Register async subdevice
- Remove soc_camera specific g/s_mbus_config operations
- Change image format colorspace from JPEG to SRGB as the two use the
same colorspace information but JPEG makes assumpti
Add support to ov772x driver for frame intervals handling and enumeration.
Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for
10, 15 and 30 frame per second rates.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/ov772x.c | 212 +++
Remove soc_camera framework dependencies from tw9910 sensor driver.
- Handle clock and gpios
- Register async subdevice
- Remove soc_camera specific g/s_mbus_config operations
- Add kernel doc to driver interface header file
- Adjust build system
This commit does not remove the original soc_camera
Migo-R platform uses sh_mobile_ceu camera driver, which is now being
replaced by a proper V4L2 camera driver named 'renesas-ceu'.
Move Migo-R platform to use the v4l2 renesas-ceu camera driver
interface and get rid of soc_camera defined components used to register
sensor drivers and of platform sp
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent Pin
The sensor driver sets mbus format colorspace information and sizes,
but not ycbcr encoding, quantization and xfer function. When supplied
with an badly initialized mbus frame format structure, those fields
need to be set explicitly not to leave them uninitialized. This is
tested by v4l2-compliance
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Acked-by: Laurent Pin
Hi Philipp,
On 02/19/2018 08:23 AM, Philipp Zabel wrote:
Hi Gustavo,
On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote:
Hi all,
I was just wondering about the status of this patch.
It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix
inconsistent IS_ERR and PTR_ER
Since commit
commit 2e564ee56978874ddd4a8d061d37be088f130fd9
Author: Hans Verkuil
vidioc-g-parm.rst: also allow _MPLANE buffer types
V4L2 allows _MPLANE buffer types for capture/output on s/g_parm
operations.
Relax v4l2-compliance check to comply with this.
Signed-off-by: Jacopo Mondi
Hi Maciej,
On 19/02/18 15:43, Maciej Purski wrote:
When a driver is going to use clk_bulk_get() function, it has to
initialize an array of clk_bulk_data, by filling its id fields.
Add a new function to the core, which dynamically allocates
clk_bulk_data array and fills its id fields. Add clk_bu
Hello,
On Monday, 19 February 2018 15:58:40 EET Guennadi Liakhovetski wrote:
> On Mon, 19 Feb 2018, Kieran Bingham wrote:
> > On 17/02/18 20:47, Alexandre-Xavier Labonté-Lamoureux wrote:
> >> Hi,
> >>
> >> I'm running Linux 4.9.0-5-amd64 on Debian. I built the drivers from
> >> the latest git and
From: Alan Chiang
Hi Sakari and Tomasz,
The two patches are the DT binding and driver for DW9807 VCM controller.
Alan Chiang (2):
media: dw9807: Add dw9807 vcm driver
media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
.../bindings/media/i2c/dongwoon,dw9807.txt | 9 +
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk
functions instead of iterating over an array of clks.
Signed-off-by: Maciej Purski
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 50 ---
1 file changed, 15 insertions(+), 35 deletions(-)
diff
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk
functions instead of iterating over an array of clks.
In order to achieve consistency with other drivers, define clock names
in driver's variants structures.
Signed-off-by: Maciej Purski
---
drivers/gpu/drm/exynos/exynos_d
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk
functions instead of iterating over an array of clks.
Signed-off-by: Maciej Purski
---
drivers/gpu/drm/exynos/exynos_drm_mic.c | 41 +++--
1 file changed, 14 insertions(+), 27 deletions(-)
diff
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk
functions instead of iterating over an array of clks.
Signed-off-by: Maciej Purski
---
drivers/media/platform/exynos-gsc/gsc-core.c | 55 ++--
drivers/media/platform/exynos-gsc/gsc-core.h | 2 +-
2
Hi all,
the main goal of this patchset is to simplify clk management code in
exynos5433 drivers by using clk bulk API. In order to achieve that,
patch #1 adds a new function to clk core, which dynamically allocates
clk_bulk_data array and fills its id fields.
Best regards,
Maciej Purski
Maciej
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk
functions instead of iterating over an array of clks.
Signed-off-by: Maciej Purski
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 97 ++--
1 file changed, 27 insertions(+), 70 deletions(-)
diff
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk
functions instead of iterating over an array of clks.
Signed-off-by: Maciej Purski
---
drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 6 ++--
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 41 +---
Using bulk clk functions simplifies the driver's code. Use devm_clk_bulk
functions instead of iterating over an array of clks.
Signed-off-by: Maciej Purski
---
drivers/media/platform/s5p-jpeg/jpeg-core.c | 45 -
drivers/media/platform/s5p-jpeg/jpeg-core.h | 2 +-
2 f
When a driver is going to use clk_bulk_get() function, it has to
initialize an array of clk_bulk_data, by filling its id fields.
Add a new function to the core, which dynamically allocates
clk_bulk_data array and fills its id fields. Add clk_bulk_free()
function, which frees the array allocated by
My Sincere Greetings,
I am (Mrs.Louisa Benicio) I have decided to donate ($5.5million
Dollars) to you / Motherless babies/ less privileged/ Churches/ Widows
from what I have inherited from my late Husband because I am
diagnosing of throat Cancer and hospitalize for 2 years and some
months now.
I
[ This is obviously ancient code. It's probably fine. I've just been
going through all array overflow warnings recently. - dan ]
Hello Mauro Carvalho Chehab,
The patch 12db56071b47: "V4L/DVB (3420): Added iocls to configure VBI
on tvp5150" from Jan 23, 2006, leads to the following static che
Hi Gustavo,
On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote:
> Hi all,
>
> I was just wondering about the status of this patch.
It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix
inconsistent IS_ERR and PTR_ERR") in Hans' for-v4.17a branch:
git://linuxtv.org/hver
From: Sakari Ailus
Remove sensor driver's interface for setting the use case specific mode
list as well as the mode lists that are related to other than
CI_MODE_PREVIEW. This removes s_parm abuse in using driver specific values
in v4l2_streamparm.capture.capturemode. The drivers already support
[
From: Sakari Ailus
These drivers already support g_frame_interval. Therefore just dropping
g_parm is enough.
Signed-off-by: Sakari Ailus
Signed-off-by: Hans Verkuil
---
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 27 --
drivers/staging/media/atomisp/i2c/atomisp-gc
From: Hans Verkuil
Convert all g/s_parm calls to g/s_frame_interval. This allows us
to remove the g/s_parm ops since those are a duplicate of
g/s_frame_interval.
Signed-off-by: Hans Verkuil
Acked-by: Sakari Ailus
---
drivers/media/i2c/mt9v011.c | 29 ++-
dr
From: Sakari Ailus
The s_parm callback in mt9m114 driver did nothing, remove it.
Signed-off-by: Sakari Ailus
Signed-off-by: Hans Verkuil
---
drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-m
From: Hans Verkuil
The specification mentions that type can be V4L2_BUF_TYPE_VIDEO_CAPTURE,
but the v4l2 core implementation also allows the _MPLANE variant.
Document this.
Signed-off-by: Hans Verkuil
Acked-by: Sakari Ailus
---
Documentation/media/uapi/v4l/vidioc-g-parm.rst | 7 ---
1 fi
From: Sakari Ailus
The s_parm and g_parm did nothing. Remove them.
Signed-off-by: Sakari Ailus
Signed-off-by: Hans Verkuil
---
.../staging/media/atomisp/pci/atomisp2/atomisp_file.c| 16
drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 14 --
2 files
Clear the reserved fields for these ioctls according to the specification:
VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL
VIDIOC_SUBDEV_ENUM_FRAME_SIZE
VIDIOC_SUBDEV_ENUM_MBUS_CODE
VIDIOC_SUBDEV_G_CROP, VIDIOC_SUBDEV_S_CROP
VIDIOC_SUBDEV_G_FMT, VIDIOC_SUBDEV_S_FMT
VIDIOC_SUBDEV_G_FRAME_INTERVAL, VIDIOC_SUBDEV_
From: Hans Verkuil
Signed-off-by: Hans Verkuil
Acked-by: Sakari Ailus
---
include/media/v4l2-subdev.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 980a86c08fce..457917e9237f 100644
--- a/include/media/v4l2-subdev.h
+++
From: Hans Verkuil
There are currently two subdev ops variants to get/set the frame interval:
g/s_parm and g/s_frame_interval.
This patch series replaces all g/s_parm calls by g/s_frame_interval.
The first patch clears the reserved fields in v4l2-subdev.c. It's taken
from the "Media Controller
From: Sakari Ailus
These sensor drivers have use case specific mode lists. This is currently
not used nor there is a standard API for selecting the mode list. Disable
configurations for non-preview modes until configuration selection is
improved so that all the configurations are always usable.
From: Hans Verkuil
Create helpers to handle VIDIOC_G/S_PARM by querying the
g/s_frame_interval v4l2_subdev ops.
Signed-off-by: Hans Verkuil
Acked-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-common.c | 48 +++
include/media/v4l2-common.h | 26 +++
On Mon, Feb 19, 2018 at 02:58:45PM +0100, Hans Verkuil wrote:
> On 02/19/2018 02:48 PM, Sakari Ailus wrote:
> > Hi Hans,
> >
> > On Mon, Feb 19, 2018 at 02:30:18PM +0100, Hans Verkuil wrote:
> >> On 02/19/2018 02:27 PM, Sakari Ailus wrote:
> >>> These sensor drivers have use case specific mode lis
On 02/19/2018 02:48 PM, Sakari Ailus wrote:
> Hi Hans,
>
> On Mon, Feb 19, 2018 at 02:30:18PM +0100, Hans Verkuil wrote:
>> On 02/19/2018 02:27 PM, Sakari Ailus wrote:
>>> These sensor drivers have use case specific mode lists. There's no need
>>> for this nor there is a standard API for selecting
Hi Kieran,
On Mon, 19 Feb 2018, Kieran Bingham wrote:
> Hi Alexandre,
>
> Thankyou for your bug report,
>
> On 17/02/18 20:47, Alexandre-Xavier Labonté-Lamoureux wrote:
> > Hi,
> >
> > I'm running Linux 4.9.0-5-amd64 on Debian. I built the drivers from
> > the latest git and installed the modu
Hi Alexandre,
Thankyou for your bug report,
On 17/02/18 20:47, Alexandre-Xavier Labonté-Lamoureux wrote:
> Hi,
>
> I'm running Linux 4.9.0-5-amd64 on Debian. I built the drivers from
> the latest git and installed the modules.
Could you please be specific here?
Are you referring to linux-media
On Fri, 2018-02-16 at 17:54 -0800, Steve Longerbeam wrote:
> Fix a few formatting errors.
>
> Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
regards
Philipp
Hi Hans,
On Mon, Feb 19, 2018 at 02:30:18PM +0100, Hans Verkuil wrote:
> On 02/19/2018 02:27 PM, Sakari Ailus wrote:
> > These sensor drivers have use case specific mode lists. There's no need
> > for this nor there is a standard API for selecting the mode list. Disable
> > configurations for non-
On 02/19/2018 02:27 PM, Sakari Ailus wrote:
> These sensor drivers have use case specific mode lists. There's no need
> for this nor there is a standard API for selecting the mode list. Disable
> configurations for non-preview modes until configuration selection is
> improved so that all the config
These sensor drivers have use case specific mode lists. There's no need
for this nor there is a standard API for selecting the mode list. Disable
configurations for non-preview modes until configuration selection is
improved so that all the configurations are always usable.
Signed-off-by: Sakari A
The v4l2_subdev core s_power op was used to two different things: power on/off
sensors or video decoders/encoders and to put a tuner in standby (and only the
tuner). There is no 'tuner wakeup' op, that's done automatically when the tuner
is accessed.
The danger with calling (s_power, 0) to put a t
1 - 100 of 121 matches
Mail list logo
