Re: unsubscribe linux-media

2019-01-08 Thread Matt Ranostay
You should direct this message to majord...@vger.kernel.org :) On Tue, Jan 8, 2019 at 4:36 PM Bhanu Murthy V wrote: > > unsubscribe linux-media > --- > This email message is for the sole use of the intended recipient

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Mikhail Gavrilov
I upgraded kernel to 5.0 rc1 and the error message "Unknown pixelformat 0x" are disappeared. Instead I see not obvious message "uvcvideo: Non-zero status (-71) in video completion handler." Maybe in this case better to write "Video format XXX not supported" ? It would help quickly underst

Re: epoll and vb2_poll: can't wake_up

2019-01-08 Thread Yi Qingliang
the first patch can work on freescale's 4.1.2 kernel ! My case maybe can't cover other changes. in file drivers/media/v4l2-core/videobuf-core.c, the function 'videobuf_poll_stream' may return POLLERR without calling 'poll_wait', it looks like different with 'vb2_poll''s process, maybe need further

RE: unsubscribe linux-media

2019-01-08 Thread Bhanu Murthy V
unsubscribe linux-media --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If yo

[PATCH v6 06/12] media: imx-csi: Double crop height for alternate fields at sink

2019-01-08 Thread Steve Longerbeam
If the incoming sink field type is alternate, the reset crop height and crop height bounds must be set to twice the incoming height, because in alternate field mode, upstream will report only the lines for a single field, and the CSI captures the whole frame. Signed-off-by: Steve Longerbeam Revie

[PATCH v6 03/12] gpu: ipu-v3: Add planar support to interlaced scan

2019-01-08 Thread Steve Longerbeam
To support interlaced scan with planar formats, cpmem SLUV must be programmed with the correct chroma line stride. For full and partial planar 4:2:2 (YUV422P, NV16), chroma line stride must be doubled. For full and partial planar 4:2:0 (YUV420, YVU420, NV12), chroma line stride must _not_ be double

[PATCH v6 02/12] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-08 Thread Steve Longerbeam
The function ipu_csi_init_interface() was inverting the F-bit for NTSC case, in the CCIR_CODE_1/2 registers. The result being that for NTSC bottom-top field order, the CSI would swap fields and capture in top-bottom order. Instead, base field swap on the field order of the input to the CSI, and th

[PATCH v6 05/12] media: imx-csi: Input connections to CSI should be optional

2019-01-08 Thread Steve Longerbeam
Some imx platforms do not have fwnode connections to all CSI input ports, and should not be treated as an error. This includes the imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode endpoint parsing will not treat a

[PATCH v6 01/12] media: videodev2.h: Add more field helper macros

2019-01-08 Thread Steve Longerbeam
Adds two helper macros: V4L2_FIELD_IS_SEQUENTIAL: returns true if the given field type is 'sequential', that is a full frame is transmitted, or exists in memory, as all top field lines followed by all bottom field lines, or vice-versa. V4L2_FIELD_IS_INTERLACED: returns true if the given field typ

[PATCH v6 07/12] media: imx: interweave and odd-chroma-row skip are incompatible

2019-01-08 Thread Steve Longerbeam
If IDMAC interweaving is enabled in a write channel, the channel must write the odd chroma rows for 4:2:0 formats. Skipping writing the odd chroma rows produces corrupted captured 4:2:0 images when interweave is enabled. Reported-by: Krzysztof Hałasa Signed-off-by: Steve Longerbeam Reviewed-by:

[PATCH v6 11/12] media: imx: Allow interweave with top/bottom lines swapped

2019-01-08 Thread Steve Longerbeam
Allow sequential->interlaced interweaving but with top/bottom lines swapped to the output buffer. This can be accomplished by adding one line length to IDMAC output channel address, with a negative line length for the interlace offset. This is to allow the seq-bt -> interlaced-bt transformation,

[PATCH v6 00/12] imx-media: Fixes for interlaced capture

2019-01-08 Thread Steve Longerbeam
From: Steve Longerbeam A set of patches that fixes some bugs with capturing from an interlaced source, and incompatibilites between IDMAC interlace interweaving and 4:2:0 data write reduction. History: v6: - Changes to patch "gpu: ipu-csi: Swap fields according to input/output field types" sug

[PATCH v6 08/12] media: imx-csi: Allow skipping odd chroma rows for YVU420

2019-01-08 Thread Steve Longerbeam
Skip writing U/V components to odd rows for YVU420 in addition to YUV420 and NV12. Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel --- drivers/staging/media/imx/imx-media-csi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/st

[PATCH v6 09/12] media: imx: vdic: rely on VDIC for correct field order

2019-01-08 Thread Steve Longerbeam
prepare_vdi_in_buffers() was setting up the dma pointers as if the VDIC is always programmed to receive the fields in bottom-top order, i.e. as if ipu_vdi_set_field_order() only programs BT order in the VDIC. But that's not true, ipu_vdi_set_field_order() is working correctly. So fix prepare_vdi_i

[PATCH v6 12/12] media: imx.rst: Update doc to reflect fixes to interlaced capture

2019-01-08 Thread Steve Longerbeam
Also add an example pipeline for unconverted capture with interweave on SabreAuto. Cleanup some language in various places in the process. Signed-off-by: Steve Longerbeam --- Changes since v4: - Make clear that it is IDMAC channel that does pixel reordering and interweave, not the CSI. Caught

[PATCH v6 04/12] media: imx: Fix field negotiation

2019-01-08 Thread Steve Longerbeam
IDMAC interlaced scan, a.k.a. interweave, should be enabled in the IDMAC output channels only if the IDMAC output pad field type is 'seq-bt' or 'seq-tb', and field type at the capture interface is 'interlaced*'. V4L2_FIELD_HAS_BOTH() macro should not be used on the input to determine enabling inte

[PATCH v6 10/12] media: imx-csi: Move crop/compose reset after filling default mbus fields

2019-01-08 Thread Steve Longerbeam
If caller passes un-initialized field type V4L2_FIELD_ANY to CSI sink pad, the reset CSI crop window would not be correct, because the crop window depends on a valid input field type. To fix move the reset of crop and compose windows to after the call to imx_media_fill_default_mbus_fields(). Signe

Re: [PATCH v2 6/6] media: adv748x: Implement TX link_setup callback

2019-01-08 Thread Laurent Pinchart
Hello, On Monday, 7 January 2019 14:36:28 EET Kieran Bingham wrote: > On 06/01/2019 15:54, Jacopo Mondi wrote: > > When the adv748x driver is informed about a link being created from HDMI > > or AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make > > sure to implement proper rou

Re: [PATCH v2 3/6] media: adv748x: csi2: Link AFE with TXA and TXB

2019-01-08 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Sunday, 6 January 2019 17:54:10 EET Jacopo Mondi wrote: > The ADV748x chip supports routing AFE output to either TXA or TXB. > In order to support run-time configuration of video stream path, create an > additional (not enabled) "AFE:8->TXA:0" link, and remo

Re: [PATCH v2 1/6] media: adv748x: Add is_txb()

2019-01-08 Thread Laurent Pinchart
Hello, On Monday, 7 January 2019 12:38:39 EET Kieran Bingham wrote: > On 07/01/2019 10:05, Jacopo Mondi wrote: > > Hi Kieran, > > > > >>> diff --git a/drivers/media/i2c/adv748x/adv748x.h > >>> b/drivers/media/i2c/adv748x/adv748x.h index b482c7fe6957..bc2da1b5ce29 > >>> 100644 > >>> --- a/driver

Re: [PATCH v6] gpu: ipu-csi: Swap fields according to input/output field types

2019-01-08 Thread Steve Longerbeam
Please disregard. This patch can't be submitted stand-alone, I will re-submit as part of a v6 of "imx-media: Fixes for interlaced capture" patchset. Steve On 12/14/18 3:46 PM, Steve Longerbeam wrote: The function ipu_csi_init_interface() was inverting the F-bit for NTSC case, in the CCIR_COD

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2019-01-08 Thread Laurent Pinchart
Hi Raj, (CC'ing Jacopo Mondi) On Saturday, 5 January 2019 04:26:16 EET Mani, Rajmohan wrote: > >> On Tuesday, 11 December 2018 15:43:53 EET Laurent Pinchart wrote: > >>> On Tuesday, 11 December 2018 15:34:49 EET Laurent Pinchart wrote: > On Wednesday, 5 December 2018 02:30:46 EET Mani, Rajmo

[RFC 4/4] media: ds90ub954: new driver for TI DS90UB954-Q1 video deserializer

2019-01-08 Thread Luca Ceresoli
LIMITATIONS / TODO: * Only I2C forwarding is quite complete. Most other features are only stubbed or not implemented at all. Remote GPIOs have a very naive implementation, where devicetree contains the values to write into registers. V4L2 callbacks are almost empty. * Testing is equally

[RFC 2/4] i2c: mux: notify client attach/detach, add ATR

2019-01-08 Thread Luca Ceresoli
From: Luca Ceresoli Note! This patch is not 100% complete - see NOTES/TODO below Add the "address translator" feature (ATR for short) to i2c-mux. An ATR is a device that looks similar to an i2c-mux: it has an I2C slave "upstream" port and N master "downstream" ports, and forwards tran

[RFC 0/4] TI camera serdes - I2C address translation draft

2019-01-08 Thread Luca Ceresoli
Hi, there has been some discussion on linux-media about video serializer/deserializer chipsets with remote I2C capabilities from TI [0] and Maxim [1]. I took part discussing how the remote I2C feature of such chips could be best implemented in Linux while I was implementing a driver for the Texas

[RFC 1/4] i2c: core: let adapters be notified of client attach/detach

2019-01-08 Thread Luca Ceresoli
From: Luca Ceresoli An adapter might need to know when a new device is about to be added. This will soon bee needed to implement an "I2C address translator" (ATR for short), a device that propagates I2C transactions with a different slave address (an "alias" address). An ATR driver needs to know

[RFC 3/4] media: dt-bindings: add DS90UB954-Q1 video deserializer

2019-01-08 Thread Luca Ceresoli
This is a first, tentative DT layout to describe a 2-input video deserializer with I2C Address Translator and remote GPIOs. NOTES / TODO: * This GPIOs representation is not realistic, it has been used only to test that thing work. It shall be rewritten properly. Signed-off-by: Luca Ceresoli

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Laurent Pinchart
Hi Mauro, On Tuesday, 8 January 2019 20:49:16 EET Mauro Carvalho Chehab wrote: > Em Tue, 8 Jan 2019 21:11:41 +0500 Mikhail Gavrilov escreveu: > > On Tue, 8 Jan 2019 at 20:57, Laurent Pinchart wrote: > >> Thank you. > >> > >> Your device exposes five formats: YUY2 (YUYV), YV12 (YVU420), NV12, P010

Astrometa swap frontend0 and frontend1

2019-01-08 Thread CIJOML CIJOMLovic
Hello, I have an Astrometa DVB-T2 dual USB card: [41802.362830] usb 3-3: new high-speed USB device number 4 using xhci_hcd [41802.520747] usb 3-3: New USB device found, idVendor=15f4, idProduct=0131, bcdDevice= 1.00 [41802.520751] usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=0

[PATCH AUTOSEL 4.20 046/117] media: uvcvideo: Refactor teardown of uvc on USB disconnect

2019-01-08 Thread Sasha Levin
From: Daniel Axtens [ Upstream commit 10e1fdb95809ed21406f53b5b4f064673a1b9ceb ] Currently, disconnecting a USB webcam while it is in use prints out a number of warnings, such as: WARNING: CPU: 2 PID: 3118 at /build/linux-ezBi1T/linux-4.8.0/fs/sysfs/group.c:237 sysfs_remove_group+0x8b/0x90 sy

[PATCH AUTOSEL 4.20 054/117] media: venus: core: Set dma maximum segment size

2019-01-08 Thread Sasha Levin
From: Vivek Gautam [ Upstream commit de2563bce7a157f5296bab94f3843d7d64fb14b4 ] Turning on CONFIG_DMA_API_DEBUG_SG results in the following error: [ 460.308650] [ cut here ] [ 460.313490] qcom-venus aa0.video-codec: DMA-API: mapping sg segment longer than device c

[PATCH AUTOSEL 4.20 056/117] media: cedrus: don't initialize pointers with zero

2019-01-08 Thread Sasha Levin
From: Mauro Carvalho Chehab [ Upstream commit e4d7b113fdccde1acf8638c5879f2a450d492303 ] A common mistake is to assume that initializing a var with: struct foo f = { 0 }; Would initialize a zeroed struct. Actually, what this does is to initialize the first element of the struct to zero.

[PATCH AUTOSEL 4.20 050/117] media: firewire: Fix app_info parameter type in avc_ca{,_app}_info

2019-01-08 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit b2e9a4eda11fd2cb1e6714e9ad3f455c402568ff ] Clang warns: drivers/media/firewire/firedtv-avc.c:999:45: warning: implicit conversion from 'int' to 'char' changes value from 159 to -97 [-Wconstant-conversion] app_info[0] = (EN50221_TAG_APP_INFO >> 1

[PATCH AUTOSEL 4.19 40/97] media: firewire: Fix app_info parameter type in avc_ca{,_app}_info

2019-01-08 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit b2e9a4eda11fd2cb1e6714e9ad3f455c402568ff ] Clang warns: drivers/media/firewire/firedtv-avc.c:999:45: warning: implicit conversion from 'int' to 'char' changes value from 159 to -97 [-Wconstant-conversion] app_info[0] = (EN50221_TAG_APP_INFO >> 1

[PATCH AUTOSEL 4.19 36/97] media: uvcvideo: Refactor teardown of uvc on USB disconnect

2019-01-08 Thread Sasha Levin
From: Daniel Axtens [ Upstream commit 10e1fdb95809ed21406f53b5b4f064673a1b9ceb ] Currently, disconnecting a USB webcam while it is in use prints out a number of warnings, such as: WARNING: CPU: 2 PID: 3118 at /build/linux-ezBi1T/linux-4.8.0/fs/sysfs/group.c:237 sysfs_remove_group+0x8b/0x90 sy

[PATCH AUTOSEL 4.19 43/97] media: venus: core: Set dma maximum segment size

2019-01-08 Thread Sasha Levin
From: Vivek Gautam [ Upstream commit de2563bce7a157f5296bab94f3843d7d64fb14b4 ] Turning on CONFIG_DMA_API_DEBUG_SG results in the following error: [ 460.308650] [ cut here ] [ 460.313490] qcom-venus aa0.video-codec: DMA-API: mapping sg segment longer than device c

[PATCH AUTOSEL 4.14 23/53] media: venus: core: Set dma maximum segment size

2019-01-08 Thread Sasha Levin
From: Vivek Gautam [ Upstream commit de2563bce7a157f5296bab94f3843d7d64fb14b4 ] Turning on CONFIG_DMA_API_DEBUG_SG results in the following error: [ 460.308650] [ cut here ] [ 460.313490] qcom-venus aa0.video-codec: DMA-API: mapping sg segment longer than device c

[PATCH AUTOSEL 4.14 21/53] media: firewire: Fix app_info parameter type in avc_ca{,_app}_info

2019-01-08 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit b2e9a4eda11fd2cb1e6714e9ad3f455c402568ff ] Clang warns: drivers/media/firewire/firedtv-avc.c:999:45: warning: implicit conversion from 'int' to 'char' changes value from 159 to -97 [-Wconstant-conversion] app_info[0] = (EN50221_TAG_APP_INFO >> 1

[PATCH AUTOSEL 4.4 11/28] media: firewire: Fix app_info parameter type in avc_ca{,_app}_info

2019-01-08 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit b2e9a4eda11fd2cb1e6714e9ad3f455c402568ff ] Clang warns: drivers/media/firewire/firedtv-avc.c:999:45: warning: implicit conversion from 'int' to 'char' changes value from 159 to -97 [-Wconstant-conversion] app_info[0] = (EN50221_TAG_APP_INFO >> 1

[PATCH AUTOSEL 3.18 06/19] media: firewire: Fix app_info parameter type in avc_ca{,_app}_info

2019-01-08 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit b2e9a4eda11fd2cb1e6714e9ad3f455c402568ff ] Clang warns: drivers/media/firewire/firedtv-avc.c:999:45: warning: implicit conversion from 'int' to 'char' changes value from 159 to -97 [-Wconstant-conversion] app_info[0] = (EN50221_TAG_APP_INFO >> 1

[PATCH AUTOSEL 4.9 16/36] media: firewire: Fix app_info parameter type in avc_ca{,_app}_info

2019-01-08 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit b2e9a4eda11fd2cb1e6714e9ad3f455c402568ff ] Clang warns: drivers/media/firewire/firedtv-avc.c:999:45: warning: implicit conversion from 'int' to 'char' changes value from 159 to -97 [-Wconstant-conversion] app_info[0] = (EN50221_TAG_APP_INFO >> 1

Re: [PATCH] media: imx: queue subdev events to reachable video devices

2019-01-08 Thread Steve Longerbeam
Hi Hans, On 1/8/19 5:26 AM, Hans Verkuil wrote: On 12/09/18 20:57, Steve Longerbeam wrote: From: Steve Longerbeam Forward events from a sub-device to its list of reachable video devices. Note this will queue the event to a video device even if there is no actual _enabled_ media path from the

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 16:49:16 -0200 Mauro Carvalho Chehab escreveu: > Em Tue, 8 Jan 2019 21:11:41 +0500 > Mikhail Gavrilov escreveu: > > > On Tue, 8 Jan 2019 at 20:57, Laurent Pinchart > > wrote: > > > > > > Thank you. > > > > > > Your device exposes five formats: YUY2 (YUYV), YV12 (YVU420), N

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 21:11:41 +0500 Mikhail Gavrilov escreveu: > On Tue, 8 Jan 2019 at 20:57, Laurent Pinchart > wrote: > > > > Thank you. > > > > Your device exposes five formats: YUY2 (YUYV), YV12 (YVU420), NV12, P010 and > > BGR3 (BGR24). They are all supported by V4L2 and the uvcvideo driver e

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Nicolas Dufresne
Le mardi 08 janvier 2019 à 16:30 +0100, Philipp Zabel a écrit : > Hi Nicolas, > > On Mon, 2019-01-07 at 17:36 -0500, Nicolas Dufresne wrote: > > Le lundi 03 décembre 2018 à 12:48 +0100, Philipp Zabel a écrit : > > > Add a single imx-media mem2mem video device that uses the IPU IC PP > > > (image c

[PATCH] media: coda: fix decoder capture buffer payload

2019-01-08 Thread Philipp Zabel
It is not correct to calculate decoder capture payload dynamically from the decoded frame width and height reported by the firmware. These tell us what the decoder wrote into the internal framebuffers. The rotator or VDOA always write the full sizeimage when copying the previously decoded frame fro

[PATCH] media: coda: use macroblock tiling on CODA960 only

2019-01-08 Thread Philipp Zabel
Coda7541 and earlier do not support macroblock tiling. They do support the NV12 format, though. Enable macroblock tiling for NV12 only on CODA960. This fixes crashes when trying to use NV12 support on CodaHx4. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 2 +- 1

[PATCH 2/4] media: v4l2-ctrl: Add control for h.264 chroma qp offset

2019-01-08 Thread Philipp Zabel
Allow to add fixed quantization parameter offset between luma and chroma quantization parameters. This control directly corresponds to the chroma_qp_index_offset field of the h.264 picture parameter set. Signed-off-by: Philipp Zabel --- Documentation/media/uapi/v4l/extended-controls.rst | 5

[PATCH 1/4] media: v4l2-ctrl: Add control to enable h.264 constrained intra prediction

2019-01-08 Thread Philipp Zabel
Allow to enable h.264 constrained intra prediction (macroblocks using intra prediction modes are not allowed to use residual data and decoded samples of neighboring macroblocks coded using inter prediction modes). This control directly corresponds to the constrained_intra_pred_flag field in the h.2

[PATCH 3/4] media: coda: Add control for h.264 constrained intra prediction

2019-01-08 Thread Philipp Zabel
Allow to enable constrained intra prediction in the h.264 encoder. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-bit.c| 4 +++- drivers/media/platform/coda/coda-common.c | 6 ++ drivers/media/platform/coda/coda.h| 1 + 3 files changed, 10 insertions(+), 1 dele

[PATCH 4/4] media: coda: Add control for h.264 chroma qp index offset

2019-01-08 Thread Philipp Zabel
Allow to set a fixed quantization parameter offset between luma and chroma in the h.264 encoder. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-bit.c| 4 +++- drivers/media/platform/coda/coda-common.c | 5 + drivers/media/platform/coda/coda.h| 1 + 3 files chan

Re: [PATCH v2 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-01-08 Thread ayaka
On 1/8/19 5:52 PM, Randy 'ayaka' Li wrote: On Thu, Nov 15, 2018 at 03:56:49PM +0100, Maxime Ripard wrote: From: Pawel Osciak Stateless video codecs will require both the H264 metadata and slices in order to be able to decode frames. This introduces the definitions for a new pixel format for

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Mikhail Gavrilov
On Tue, 8 Jan 2019 at 20:57, Laurent Pinchart wrote: > > Thank you. > > Your device exposes five formats: YUY2 (YUYV), YV12 (YVU420), NV12, P010 and > BGR3 (BGR24). They are all supported by V4L2 and the uvcvideo driver except > for the P010 format. This would be easy to fix in the uvcvideo driver

Re: [PATCH v2 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2019-01-08 Thread Laurent Pinchart
On Tuesday, 8 January 2019 16:30:22 EET Mauro Carvalho Chehab wrote: > Em Tue, 8 Jan 2019 15:40:47 +0200 > > Sakari Ailus escreveu: > > On Tue, Jan 08, 2019 at 10:59:55AM -0200, Mauro Carvalho Chehab wrote: > > > Em Tue, 8 Jan 2019 10:52:12 -0200 > > > > > > Mauro Carvalho Chehab escreveu: > >

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Philipp Zabel
Hi Hans, On Wed, 2018-12-05 at 19:50 +0100, Hans Verkuil wrote: > On 12/05/2018 02:20 AM, Steve Longerbeam wrote: > > Hi Hans, Philipp, > > > > One comment on my side... > > > > On 12/3/18 7:21 AM, Hans Verkuil wrote: > > > > > > > +void imx_media_mem2mem_device_unregister(struct imx_media_vide

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Philipp Zabel
Hi Steve, On Tue, 2018-12-04 at 17:20 -0800, Steve Longerbeam wrote: > Hi Hans, Philipp, > > One comment on my side... > > On 12/3/18 7:21 AM, Hans Verkuil wrote: > > > > > +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev > > > *vdev) > > > +{ > > > + struct mem2mem_priv *p

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Philipp Zabel
Hi Hans, thank you for your comments! On Mon, 2018-12-03 at 16:21 +0100, Hans Verkuil wrote: > On 12/03/2018 12:48 PM, Philipp Zabel wrote: > > Add a single imx-media mem2mem video device that uses the IPU IC PP > > (image converter post processing) task for scaling and colorspace > > conversion.

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Laurent Pinchart
Hi Mikhail, On Tuesday, 8 January 2019 17:18:15 EET Mikhail Gavrilov wrote: > On Tue, 8 Jan 2019 at 19:53, Laurent Pinchart > > wrote: > > Mikhail, could you please post the output of > > > > lsusb -v -d 07ca:0553 > > > > if possible running as root ? > > yes, attached here. Thank you. Your

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Laurent Pinchart
On Tuesday, 8 January 2019 17:16:21 EET Mauro Carvalho Chehab wrote: > Em Tue, 08 Jan 2019 16:54:41 +0200 Laurent Pinchart escreveu: > > On Tuesday, 8 January 2019 16:45:37 EET Mauro Carvalho Chehab wrote: > >> Em Sun, 6 Jan 2019 01:05:16 +0500 Mikhail Gavrilov escreveu: > >>> Hi folks! > >>> Every

[GIT PULL FOR v5.1] Various fixes

2019-01-08 Thread Hans Verkuil
The following changes since commit 1e0d0a5fd38192f23304ea2fc2b531fea7c74247: media: s5p-mfc: fix incorrect bus assignment in virtual child device (2019-01-07 14:39:36 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.1b2 for you to fetch ch

Re: [PATCH v2 08/13] media: mt9m001: remove remaining soc_camera specific code

2019-01-08 Thread Akinobu Mita
2019年1月8日(火) 23:52 Akinobu Mita : > > Remove remaining soc_camera specific code and drop soc_camera dependency > from this driver. > > Cc: Guennadi Liakhovetski > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita > --- > * No changes from v1 > > drivers/media/i2c/Kconf

[PATCH v6] media: imx: add mem2mem device

2019-01-08 Thread Philipp Zabel
Add a single imx-media mem2mem video device that uses the IPU IC PP (image converter post processing) task for scaling and colorspace conversion. On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. The hardware only supports writing to destination buffers up to 1024x1024 pixels i

Re: [PATCH v5] media: imx: add mem2mem device

2019-01-08 Thread Philipp Zabel
Hi Nicolas, On Mon, 2019-01-07 at 17:36 -0500, Nicolas Dufresne wrote: > Le lundi 03 décembre 2018 à 12:48 +0100, Philipp Zabel a écrit : > > Add a single imx-media mem2mem video device that uses the IPU IC PP > > (image converter post processing) task for scaling and colorspace > > conversion. >

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Mikhail Gavrilov
On Tue, 8 Jan 2019 at 19:53, Laurent Pinchart wrote: > > Mikhail, could you please post the output of > > lsusb -v -d 07ca:0553 > > if possible running as root ? yes, attached here. -- Best Regards, Mike Gavrilov. [root@localhost ~]# lsusb -v -d 07ca:0553 Bus 004 Device 003: ID 07ca:0553 AVerMe

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 08 Jan 2019 16:54:41 +0200 Laurent Pinchart escreveu: > Hello, > > On Tuesday, 8 January 2019 16:45:37 EET Mauro Carvalho Chehab wrote: > > Em Sun, 6 Jan 2019 01:05:16 +0500 Mikhail Gavrilov escreveu: > > > Hi folks! > > > Every time when I start capture video from external capture car

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Laurent Pinchart
Hello, On Tuesday, 8 January 2019 16:45:37 EET Mauro Carvalho Chehab wrote: > Em Sun, 6 Jan 2019 01:05:16 +0500 Mikhail Gavrilov escreveu: > > Hi folks! > > Every time when I start capture video from external capture card > > Avermedia Live Gamer ULTRA GC553 > > (https://www.avermedia.com/gaming/p

[PATCH v2 09/13] media: mt9m001: add media controller support

2019-01-08 Thread Akinobu Mita
Create a source pad and set the media controller type to the sensor. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * No changes from v1 drivers/media/i2c/Kconfig | 2 ++ drivers/media/i2c/mt9m001.c | 9 + 2 files changed, 11 in

[PATCH v2 08/13] media: mt9m001: remove remaining soc_camera specific code

2019-01-08 Thread Akinobu Mita
Remove remaining soc_camera specific code and drop soc_camera dependency from this driver. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * No changes from v1 drivers/media/i2c/Kconfig | 2 +- drivers/media/i2c/mt9m001.c | 84 -

[PATCH v2 12/13] media: mt9m001: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY

2019-01-08 Thread Akinobu Mita
The VIDIOC_SUBDEV_G_FMT ioctl for this driver doesn't recognize V4L2_SUBDEV_FORMAT_TRY and always works as if V4L2_SUBDEV_FORMAT_ACTIVE is specified. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * v2 - Set initial try format with default

[PATCH v2 13/13] media: mt9m001: set all mbus format field when G_FMT and S_FMT ioctls

2019-01-08 Thread Akinobu Mita
This driver doesn't set all members of mbus format field when the VIDIOC_SUBDEV_{S,G}_FMT ioctls are called. This is detected by v4l2-compliance. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * No changes from v1 drivers/media/i2c/mt9m0

[PATCH v2 01/13] media: i2c: mt9m001: copy mt9m001 soc_camera sensor driver

2019-01-08 Thread Akinobu Mita
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * No changes from v1 drivers/media/i2c/Kconfig | 7 + dri

[PATCH v2 05/13] media: mt9m001: add of_match_table

2019-01-08 Thread Akinobu Mita
Add of_match_table for the MT9M001 CMOS image sensor. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * No changes from v1 drivers/media/i2c/mt9m001.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/mt9m001.c b

[PATCH v2 02/13] media: i2c: mt9m001: dt: add binding for mt9m001

2019-01-08 Thread Akinobu Mita
Add device tree binding documentation for the MT9M001 CMOS image sensor. Cc: Rob Herring Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * v2 - Update binding doc suggested by Rob Herring. .../devicetree/bindings/media/i2c/mt9m001.txt

[PATCH v2 06/13] media: mt9m001: introduce multi_reg_write()

2019-01-08 Thread Akinobu Mita
Introduce multi_reg_write() to write multiple registers to the device and use it where possible. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * No changes from v1 drivers/media/i2c/mt9m001.c | 88 +---

[PATCH v2 07/13] media: mt9m001: switch s_power callback to runtime PM

2019-01-08 Thread Akinobu Mita
Switch s_power() callback to runtime PM framework. This also removes soc_camera specific power management code and introduces reset and standby gpios instead. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * v2 - Add new label for error ha

[PATCH v2 04/13] media: mt9m001: sort headers alphabetically

2019-01-08 Thread Akinobu Mita
Sort header block alphabetically for easy maintenance. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * New patch from v2 drivers/media/i2c/mt9m001.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/medi

[PATCH v2 03/13] media: mt9m001: convert to SPDX license identifer

2019-01-08 Thread Akinobu Mita
Replace GPL license statements with SPDX license identifiers (GPL-2.0). This also fixes MODULE_LICENSE() ident to match the actual license text. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * v2 - Fix MODULE_LICENSE() masmatch. drivers

[PATCH v2 00/13] media: mt9m001: switch soc_mt9m001 to a standard subdev sensor driver

2019-01-08 Thread Akinobu Mita
This patchset converts soc_camera mt9m001 driver to a standard subdev sensor driver. * v2 - Update binding doc suggested by Rob Herring. - Fix MODULE_LICENSE() masmatch. - Sort headers alphabetically. - Add new label for error handling in s_stream() callback. - Replace pm_runtime_get_noresume() +

[PATCH v2 10/13] media: mt9m001: register to V4L2 asynchronous subdevice framework

2019-01-08 Thread Akinobu Mita
Register a sub-device to the asynchronous subdevice framework, and also create subdevice device node. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * v2 - Remove redundant Kconfig dependency - Preserve subdev flags set by v4l2_i2c_subdev_i

[PATCH v2 11/13] media: mt9m001: support log_status ioctl and event interface

2019-01-08 Thread Akinobu Mita
This adds log_status ioctl and event interface for mt9m001's v4l2 controls. Cc: Guennadi Liakhovetski Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * No changes from v1 drivers/media/i2c/mt9m001.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: Kernel error "Unknown pixelformat 0x00000000" occurs when I start capture video

2019-01-08 Thread Mauro Carvalho Chehab
Hi Mike, Em Sun, 6 Jan 2019 01:05:16 +0500 Mikhail Gavrilov escreveu: > Hi folks! > Every time when I start capture video from external capture card > Avermedia Live Gamer ULTRA GC553 > (https://www.avermedia.com/gaming/product/game_capture/live_gamer_ultra_gc553) What's the driver used by this

Re: [PATCH v2 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 15:40:47 +0200 Sakari Ailus escreveu: > On Tue, Jan 08, 2019 at 10:59:55AM -0200, Mauro Carvalho Chehab wrote: > > Em Tue, 8 Jan 2019 10:52:12 -0200 > > Mauro Carvalho Chehab escreveu: > > > > > Em Tue, 8 Jan 2019 10:58:34 +0200 > > > Sakari Ailus escreveu: > > > > > >

Re: [PATCH v2 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 15:38:32 +0200 Sakari Ailus escreveu: > Hi Mauro, > > Thanks for the review. > > On Tue, Jan 08, 2019 at 10:59:55AM -0200, Mauro Carvalho Chehab wrote: > > Em Tue, 8 Jan 2019 10:52:12 -0200 > > Mauro Carvalho Chehab escreveu: > > > > > Em Tue, 8 Jan 2019 10:58:34 +0200 >

Re: [PATCH v2 2/3] videobuf2-dma-sg: Prevent size from overflowing

2019-01-08 Thread Sakari Ailus
On Tue, Jan 08, 2019 at 11:44:01AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 8 Jan 2019 15:29:26 +0200 > Sakari Ailus escreveu: > > > On Tue, Jan 08, 2019 at 11:09:42AM -0200, Mauro Carvalho Chehab wrote: > > > Em Tue, 8 Jan 2019 10:58:35 +0200 > > > Sakari Ailus escreveu: > > > > > > >

Re: [PATCH v1 2/2] media: atmel-isc: Update device tree binding documentation

2019-01-08 Thread Hans Verkuil
On 01/08/19 14:44, Hans Verkuil wrote: > On 12/28/18 17:59, Ken Sloat wrote: >> From: Ken Sloat >> >> Update device tree binding documentation specifying how to >> enable BT656 with CRC decoding. >> >> Signed-off-by: Ken Sloat >> --- >> Documentation/devicetree/bindings/media/atmel-isc.txt | 3 +

Re: [PATCH v1 2/2] media: atmel-isc: Update device tree binding documentation

2019-01-08 Thread Hans Verkuil
On 12/28/18 17:59, Ken Sloat wrote: > From: Ken Sloat > > Update device tree binding documentation specifying how to > enable BT656 with CRC decoding. > > Signed-off-by: Ken Sloat > --- > Documentation/devicetree/bindings/media/atmel-isc.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [PATCH v2 2/3] videobuf2-dma-sg: Prevent size from overflowing

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 15:29:26 +0200 Sakari Ailus escreveu: > On Tue, Jan 08, 2019 at 11:09:42AM -0200, Mauro Carvalho Chehab wrote: > > Em Tue, 8 Jan 2019 10:58:35 +0200 > > Sakari Ailus escreveu: > > > > > buf->size is an unsigned long; casting that to int will lead to an > > > overflow if bu

Re: [PATCH v2 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2019-01-08 Thread Sakari Ailus
On Tue, Jan 08, 2019 at 10:59:55AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 8 Jan 2019 10:52:12 -0200 > Mauro Carvalho Chehab escreveu: > > > Em Tue, 8 Jan 2019 10:58:34 +0200 > > Sakari Ailus escreveu: > > > > > PAGE_ALIGN() may wrap the buffer size around to 0. Prevent this by > > > che

Re: [PATCH v2 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2019-01-08 Thread Sakari Ailus
Hi Mauro, Thanks for the review. On Tue, Jan 08, 2019 at 10:59:55AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 8 Jan 2019 10:52:12 -0200 > Mauro Carvalho Chehab escreveu: > > > Em Tue, 8 Jan 2019 10:58:34 +0200 > > Sakari Ailus escreveu: > > > > > PAGE_ALIGN() may wrap the buffer size aro

Re: [PATCH v2 2/3] videobuf2-dma-sg: Prevent size from overflowing

2019-01-08 Thread Sakari Ailus
On Tue, Jan 08, 2019 at 11:09:42AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 8 Jan 2019 10:58:35 +0200 > Sakari Ailus escreveu: > > > buf->size is an unsigned long; casting that to int will lead to an > > overflow if buf->size exceeds INT_MAX. > > > > Fix this by changing the type to unsign

Re: [PATCH] media: imx: queue subdev events to reachable video devices

2019-01-08 Thread Hans Verkuil
On 12/09/18 20:57, Steve Longerbeam wrote: > From: Steve Longerbeam > > Forward events from a sub-device to its list of reachable video > devices. > > Note this will queue the event to a video device even if there is > no actual _enabled_ media path from the sub-device to the video device. > So

Re: [PATCH v2 2/3] videobuf2-dma-sg: Prevent size from overflowing

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 10:58:35 +0200 Sakari Ailus escreveu: > buf->size is an unsigned long; casting that to int will lead to an > overflow if buf->size exceeds INT_MAX. > > Fix this by changing the type to unsigned long instead. This is possible > as the buf->size is always aligned to PAGE_SIZE,

Re: [PATCH 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-01-08 Thread Sakari Ailus
Hi Vishal, The patchset hard escaped me somehow earlier and your reply to Rob made me notice it again. Thanks. :-) On Wed, May 30, 2018 at 12:24:43AM +0530, Vishal Sagar wrote: > Add bindings documentation for Xilinx MIPI CSI-2 Rx Subsystem. > > The Xilinx MIPI CSI-2 Rx Subsystem consists of a D

Re: [PATCH v2 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 10:59:55 -0200 Mauro Carvalho Chehab escreveu: > Em Tue, 8 Jan 2019 10:52:12 -0200 > Mauro Carvalho Chehab escreveu: > > > Em Tue, 8 Jan 2019 10:58:34 +0200 > > Sakari Ailus escreveu: > > > > > PAGE_ALIGN() may wrap the buffer size around to 0. Prevent this by > > > checki

Re: [PATCH v2 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 10:52:12 -0200 Mauro Carvalho Chehab escreveu: > Em Tue, 8 Jan 2019 10:58:34 +0200 > Sakari Ailus escreveu: > > > PAGE_ALIGN() may wrap the buffer size around to 0. Prevent this by > > checking that the aligned value is not smaller than the unaligned one. > > > > Note on ba

Re: [PATCH v2 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 10:58:34 +0200 Sakari Ailus escreveu: > PAGE_ALIGN() may wrap the buffer size around to 0. Prevent this by > checking that the aligned value is not smaller than the unaligned one. > > Note on backporting to stable: the file used to be under > drivers/media/v4l2-core, it was m

Re: [GIT PULL v4 for 4.21] META_OUTPUT buffer type and the ipu3 staging driver

2019-01-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Jan 2019 00:51:25 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Jan 07, 2019 at 04:11:34PM -0200, Mauro Carvalho Chehab wrote: > > Em Mon, 7 Jan 2019 16:01:07 -0200 > > Mauro Carvalho Chehab escreveu: > > > > > Hi Sakari/Bingbu, > > > > > > Em Thu, 13 Dec 2018 14:03:40 +020

[GIT PULL FOR v5.1] pwc: Don't use coherent DMA buffers for ISO transfer

2019-01-08 Thread Hans Verkuil
This pull requests supersedes the previous pull request for v4.21, which didn't make it. It's unchanged from the previous pull request, just rebased on top of v5.0-rc1. The "dma-direct: provide a generic implementation of DMA_ATTR_NON_CONSISTENT" discussion is about future work to help with cases

RE: [PATCH 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-01-08 Thread Vishal Sagar
Hi Rob, Thanks for the review. > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Wednesday, June 13, 2018 1:34 AM > To: Vishal Sagar > Cc: Hyun Kwon ; laurent.pinch...@ideasonboard.com; > michal.si...@xilinx.com; linux-media@vger.kernel.org; > devicet...@vger.kern

Re: [PATCH 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver

2019-01-08 Thread Vishal Sagar
Hi Hyun Thanks for the review. > -Original Message- > From: Hyun Kwon > Sent: Thursday, June 01, 2018 6:46 AM > To: Vishal Sagar > Cc: Hyun Kwon ; laurent.pinch...@ideasonboard.com; > michal.si...@xilinx.com; linux-media@vger.kernel.org; > devicet...@vger.kernel.org; mark.rutl...@arm.c

  1   2   >