[RFT PATCH v3 6/6] uvcvideo: Move decode processing to process context

'. This can result in data rates of up to 2 gigabits per second being processed. To improve efficiency, and maximise throughput, handle the URB decode processing through a work queue to move it from interrupt context, and allow multiple processors to work on URBs in parallel. Signed-off-by: Kieran

[RFT PATCH v3 1/6] uvcvideo: Refactor URB descriptors

for consistency. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- v2: - Re-describe URB context structure - Re-name uvc_urb->{urb_buffer,urb_dma}{buffer,dma} --- drivers/media/usb/uvc/u

[RFT PATCH v3 4/6] uvcvideo: queue: Simplify spin-lock usage

Both uvc_start_streaming(), and uvc_stop_streaming() are called from userspace context. As such, they do not need to save the IRQ state, and can use spin_lock_irq() and spin_unlock_irq() respectively. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- drivers/media/u

[RFT PATCH v3 5/6] uvcvideo: queue: Support asynchronous buffer handling

() such that a reference count tracks the active use of the buffer, returning the buffer to the VB2 stack at completion. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- drivers/media/usb/uvc/uvc_queue.c | 61 ++-- drivers/media/usb/uvc/uvcvideo.h | 4 ++- 2

[RFT PATCH v3 0/6] Asynchronous UVC

work if required (encode/isight do not queue work) - Refactor/Rename variables for clarity Kieran Bingham (6): uvcvideo: Refactor URB descriptors uvcvideo: Convert decode functions to use new context structure uvcvideo: Protect queue internals with helper uvcvideo: queue: Simplify spin-lock

Re: [RFT PATCH v2 6/6] uvcvideo: Move decode processing to process context

Hi Kieran ! Thanking you for the patch might be rather self serving here :D On 09/01/18 13:09, Kieran Bingham wrote: > Newer high definition cameras, and cameras with multiple lenses such as > the range of stereo-vision cameras now available have ever increasing > data rates. > >

[RFT PATCH v2 1/6] uvcvideo: Refactor URB descriptors

for consistency. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- v2: - Re-describe URB context structure - Re-name uvc_urb->{urb_buffer,urb_dma}{buffer,dma} drivers/media/usb/uvc/u

[RFT PATCH v2 5/6] uvcvideo: queue: Support asynchronous buffer handling

() such that a reference count tracks the active use of the buffer, returning the buffer to the VB2 stack at completion. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- drivers/media/usb/uvc/uvc_queue.c | 61 ++-- drivers/media/usb/uvc/uvcvideo.h | 4 ++- 2

[RFT PATCH v2 6/6] uvcvideo: Move decode processing to process context

'. This can result in data rates of up to 2 gigabits per second being processed. To improve efficiency, and maximise throughput, handle the URB decode processing through a work queue to move it from interrupt context, and allow multiple processors to work on URBs in parallel. Signed-off-by: Kieran

[RFT PATCH v2 2/6] uvcvideo: Convert decode functions to use new context structure

The URB completion handlers currently reference the stream context. Now that each URB has its own context structure, convert the decode (and one encode) functions to utilise this context for URB management. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> Reviewed-by: L

[RFT PATCH v2 4/6] uvcvideo: queue: Simplify spin-lock usage

Both uvc_start_streaming(), and uvc_stop_streaming() are called from userspace context. As such, they do not need to save the IRQ state, and can use spin_lock_irq() and spin_unlock_irq() respectively. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- drivers/media/u

[RFT PATCH v2 3/6] uvcvideo: Protect queue internals with helper

-by: Kieran Bingham <kieran.bing...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- v2: - Fix coding style of conditional statements drivers/media/usb/uvc/uvc_queue.c | 33 +++- drivers/media/usb/uvc/uvc_

[RFT PATCH v2 0/6] Asynchronous UVC

cameras. v2: - Fix up comments and issues raised by Guennadi Kieran Bingham (6): uvcvideo: Refactor URB descriptors uvcvideo: Convert decode functions to use new context structure uvcvideo: Protect queue internals with helper uvcvideo: queue: Simplify spin-lock usage uvcvideo: queue

[PATCH v2] media: i2c: adv748x: fix HDMI field heights

. Adjust the mbus height to correctly describe the image height of the fields when processing interlaced video for HDMI pipelines. Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver") Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Signed-off-by

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

Thanks for your patch. >> >> On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: >>> Hi Kieran, >>> >>> On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: >>>> The v4l2_mbus_fmt width and height corresponds directly with the >

Re: [PATCH] media: i2c: adv748x: fix HDMI field heights

Hi Niklas, On 08/01/18 17:56, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your patch. > > On 2018-01-08 17:39:30 +, Kieran Bingham wrote: >> The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field >> types. The correct specification

[PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

, and by matching the terminology of 'image height' rather than the misleading 'frame height'. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v2: - Duplicated explicit text from v4l2_pix_format rather than referencing it. Documentation/media/uapi/v4l/

[PATCH] media: i2c: adv748x: fix HDMI field heights

. Adjust the mbus height to correctly describe the image height of the fields when processing interlaced video for HDMI pipelines. Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver") Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/m

[PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

the terminology of 'image height' rather than the misleading 'frame height'. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- Documentation/media/uapi/v4l/subdev-formats.rst | 6 -- include/uapi/linux/v4l2-mediabus.h | 4 ++-- 2 files changed, 6 insertions

Re: [RFC/RFT PATCH 3/6] uvcvideo: Protect queue internals with helper

Hi Guennadi, On 04/01/18 18:25, Guennadi Liakhovetski wrote: > Hi Kieran, > > On Wed, 3 Jan 2018, Kieran Bingham wrote: > >> From: Kieran Bingham <kieran.bing...@ideasonboard.com> >> >> The URB completion operation obtains the current buffer by reading

Re: [RFC/RFT PATCH 1/6] uvcvideo: Refactor URB descriptors

Hi Guennadi, Thanks for your review, On 04/01/18 18:24, Guennadi Liakhovetski wrote: > Hi Kieran, > > Just minor suggestions below: > > On Wed, 3 Jan 2018, Kieran Bingham wrote: > >> From: Kieran Bingham <kieran.bing...@ideasonboard.com> >> >> We curr

Re: [RFC/RFT PATCH 6/6] uvcvideo: Move decode processing to process context

Hi Guennadi, Thank you for taking the time to review this series, On 04/01/18 18:54, Guennadi Liakhovetski wrote: > On Wed, 3 Jan 2018, Kieran Bingham wrote: > >> From: Kieran Bingham <kieran.bing...@ideasonboard.com> >> >> Newer high definition cameras, an

Re: [RFC/RFT PATCH 0/6] Asynchronous UVC

Hi Troy, On 03/01/18 21:13, Troy Kisky wrote: > On 1/3/2018 12:32 PM, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bing...@ideasonboard.com> >> >> The Linux UVC driver has long provided adequate performance capabilities for >> web-cams and low data

[RFC/RFT PATCH 1/6] uvcvideo: Refactor URB descriptors

From: Kieran Bingham <kieran.bing...@ideasonboard.com> We currently store three separate arrays for each URB reference we hold. Objectify the data needed to track URBs into a single uvc_urb structure, allowing better object management and tracking of the URB. All accesses to the data po

[RFC/RFT PATCH 2/6] uvcvideo: Convert decode functions to use new context structure

From: Kieran Bingham <kieran.bing...@ideasonboard.com> The URB completion handlers currently reference the stream context. Now that each URB has its own context structure, convert the decode (and one encode) functions to utilise this context for URB management. Signed-off-by: Kieran B

[RFC/RFT PATCH 4/6] uvcvideo: queue: Simplify spin-lock usage

From: Kieran Bingham <kieran.bing...@ideasonboard.com> Both uvc_start_streaming(), and uvc_stop_streaming() are called from userspace context. As such, they do not need to save the IRQ state, and can use spin_lock_irq() and spin_unlock_irq() respectively. Signed-off-by: Kieran B

[RFC/RFT PATCH 3/6] uvcvideo: Protect queue internals with helper

From: Kieran Bingham <kieran.bing...@ideasonboard.com> The URB completion operation obtains the current buffer by reading directly into the queue internal interface. Protect this queue abstraction by providing a helper uvc_queue_get_current_buffer() which can be used by both the decod

[RFC/RFT PATCH 5/6] uvcvideo: queue: Support asynchronous buffer handling

From: Kieran Bingham <kieran.bing...@ideasonboard.com> The buffer queue interface currently operates sequentially, processing buffers after they have fully completed. In preparation for supporting parallel tasks operating on the buffers, we will need to support buffers being pro

[RFC/RFT PATCH 6/6] uvcvideo: Move decode processing to process context

From: Kieran Bingham <kieran.bing...@ideasonboard.com> Newer high definition cameras, and cameras with multiple lenses such as the range of stereovision cameras now available have ever increasing data rates. The inclusion of a variable length packet header in URB packets mean that we must

[RFC/RFT PATCH 0/6] Asynchronous UVC

From: Kieran Bingham <kieran.bing...@ideasonboard.com> The Linux UVC driver has long provided adequate performance capabilities for web-cams and low data rate video devices in Linux while resolutions were low. Modern USB cameras are now capable of high data rates thanks to USB3 with

Re: [PATCH 4/5] v4l2: async: Postpone subdev_notifier registration

On 17/12/17 13:10, Kieran Bingham wrote: > Hi Jacopo, > > Thank you for the patch, > > This seems like a good thing to do at a glance here, but I'll leave contextual > judgement like that to Sakari. Oh - I hit send and *then* my mail client wakes up and tells me Sakari rev

Re: [PATCH 4/5] v4l2: async: Postpone subdev_notifier registration

Hi Jacopo, Thank you for the patch, This seems like a good thing to do at a glance here, but I'll leave contextual judgement like that to Sakari. A few minor grammatical nits here and a question on locking. On 13/12/17 18:26, Jacopo Mondi wrote: > Currently, subdevice notifiers are tested

Re: [PATCH 2/9] v4l: vsp1: Print the correct blending unit name in debug messages

before the rest of the CRC series is reviewed. > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_drm.c | 12 +++- > 1 fi

Re: [PATCH 1/9] v4l: vsp1: Fix display stalls when requesting too many inputs

e...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_drm.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/media/platform/vsp1/vsp1_drm.c > b/drivers/media/platform/vs

Re: [PATCH/RFC v2 14/15] adv748x: csi2: add get_routing support

Hi Niklas, On 14/12/17 19:08, Niklas Söderlund wrote: > To support multiplexed streams the internal routing between the > adv748x sink pad and its source pad needs to be described. The adv748x has quite a few sink and source pads... I presume here you mean the adv748x csi2 sink and source pad :D

Re: [PATCH/RFC v2 13/15] adv748x: csi2: only allow formats on sink pads

Hi Niklas, On 14/12/17 19:08, Niklas Söderlund wrote: > The driver is now pad and stream aware, only allow to get/set format on > sink pads. Ok - I can see the patch is doing this ... > Also record a different format for each sink pad since it's > no longer true that they are all the same But

Re: [PATCH/RFC v2 12/15] adv748x: csi2: switch to pad and stream aware s_stream

g and stopping individual streams on a multiplexed pad." > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Otherwise, Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/i2c/adv748x/adv748x-csi2.c | 16 +

Re: [PATCH/RFC v2 15/15] adv748x: afe: add routing support

One more ... On 14/12/17 22:56, Kieran Bingham wrote: > Hi Niklas, > > On 14/12/17 19:08, Niklas Söderlund wrote: >> The adv748x afe have eight analog sink pads, currently one of them is > > s/have/has/ > >> chosen to be the active route based on device tree c

Re: [PATCH/RFC v2 15/15] adv748x: afe: add routing support

the eight sink > pads are routed to the source pad. > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Aha, I had been wondering how we would handle this... Other than the minor nits, this is otherwise looking good Reviewed-by: Kieran Bingham <kieran.bingham+

Re: [PATCH/RFC v2 10/15] adv748x: csi2: add translation from pixelcode to CSI-2 datatype

Hi Niklas, On 14/12/17 19:08, Niklas Söderlund wrote: > This will be needed to fill out the frame descriptor information > correctly. > > Signed-off-by: Niklas Söderlund > --- > drivers/media/i2c/adv748x/adv748x-csi2.c | 22 ++ > 1

Re: [PATCH/RFC v2 09/15] adv748x: csi2: add module param for virtual channel

r); > > +module_param(txavc, uint, 0644); > +MODULE_PARM_DESC(txavc, "Virtual Channel for TXA"); > +module_param(txbvc, uint, 0644); > +MODULE_PARM_DESC(txbvc, "Virtual Channel for TXB"); > + > MODULE_AUTHOR("Kieran Bingham <kieran.bing...@ideason

Re: [PATCH v5] v4l2-async: Match parent devices

Hi Sakari, On 07/12/17 07:41, Sakari Ailus wrote: > On Wed, Dec 06, 2017 at 02:58:39PM +0000, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> Devices supporting multiple endpoints on a single device node must se

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

Hi Niklas, On 06/12/17 15:57, Niklas Söderlund wrote: > CC Jacopo, Kieran > > Hi Sakari, > > Thanks for your patch. > > On 2017-12-04 23:03:02 +0200, Sakari Ailus wrote: >> V4L2 async framework can use both device's fwnode and endpoints's fwnode >> for matching the async sub-device with the

Re: [PATCH v5] v4l2-async: Match parent devices

Hi Jacopo, On 06/12/17 15:33, jacopo mondi wrote: > Hi Kieran, > > On Wed, Dec 06, 2017 at 02:58:39PM +0000, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> Devices supporting multiple endpoints on a single device

[PATCH v5] v4l2-async: Match parent devices

From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Devices supporting multiple endpoints on a single device node must set their subdevice fwnode to the endpoint to allow distinct comparisons. Adapt the match_fwnode call to compare against the provided fwnodes first, but t

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

Hi Sakari, Thanks for the patch. On 04/12/17 21:03, Sakari Ailus wrote: > V4L2 async framework can use both device's fwnode and endpoints's fwnode > for matching the async sub-device with the sub-device. In order to proceed > moving towards endpoint matching assign the endpoint to the async >

[PATCH v3] media: vsp1: Prevent suspending and resuming DRM pipelines

. Ensure that the VSP suspend and resume handlers do not affect DRM-based pipelines. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- v3: - Fixed up with punctuation from Laurent. d

Re: [PATCH v8 28/28] rcar-vin: enable support for r8a77970

he cursory chip, width, and height all look correct ... but as this has helped me capture video this evening this patch can at least have: Tested-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > .../devicetree/bindings/media/rcar_vin.txt | 1 + > driver

Re: [PATCH v8 03/28] rcar-vin: unregister video device on driver removal

inting an/ > uninitialized video device node name by adding a checking in /checking/check/ > rvin_v4l2_unregister() by checking that the video device is registered. /by checking/to identify/ > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Kieran Bingham

Re: [PATCH v8 02/28] rcar-vin: rename poorly named initialize and cleanup functions

ice > where poorly named from the start. Rename them to better describe there s/describe there/describe their/ > intended function. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Other than the spelling above, the rename looks good to me. Review

Re: [PATCH 16/22] media: vsp1: add a missing kernel-doc parameter

gt; Ah yes, I missed that... Thanks for fixing. Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_dl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/vsp1/vsp1_dl.c > b/

Re: [PATCH 19/22] media: drivers: remove "/**" from non-kernel-doc comments

'priv' > drivers/media/usb/gspca/ov519.c:36: warning: No description found for > parameter 'fmt' > drivers/media/usb/dvb-usb/dib0700_devices.c:3367: warning: No description > found for parameter 'adap' > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.co

Re: [PATCH] media: i2c: adv748x: Restore full DT paths in kernel messages

11 > > Fixes: a7e4cfb0a7ca4773 ("of/fdt: only store the device node basename in > full_name") > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/i2c/a

Re: [PATCH] v4l: vsp1: Fix function declaration/definition mismatch

parameter names of certain vsp1 > functions don't match between declaration and definition. Fix this. > No functional change is confirmed by the empty delta between the > disassembled object files before and after the change. > > Signed-off-by: Eugeniu Rosca <ero...@de.adit-jv.

Re: [PATCH] media: ov7670: use v4l2_async_unregister_subdev()

truct v4l2_subdev *sd = i2c_get_clientdata(client); > struct ov7670_info *info = to_state(sd); > > - v4l2_device_unregister_subdev(sd); > + v4l2_async_unregister_subdev(sd); Good spot. Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>

[PATCH v4 9/9] v4l: vsp1: Reduce display list body size

frame, for both DRM and Video API pipelines thus a rounded 64 entries provides a suitable allocation. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_dl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v4 8/9] v4l: vsp1: Move video configuration to a cached dlb

set - our cached configuration will be re-attached to the next committed DL. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v3: - 's/fragment/body/', 's/fragments/bodies/' - video dlb cache allocation increased from 2 to 3 dlbs Our video DL usage now looks like t

[PATCH v4 5/9] v4l: vsp1: Use reference counting for bodies

Extend the display list body with a reference count, allowing bodies to be kept as long as a reference is maintained. This provides the ability to keep a cached copy of bodies which will not change, so that they can be re-applied to multiple display lists. Signed-off-by: Kieran Bingham

[PATCH v4 3/9] v4l: vsp1: Provide a body pool

multiple display list bodies in a single allocation, and providing these to the display list through a 'body pool'. A pool can be allocated by the display list manager or entities which require their own body allocations. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>

[PATCH v4 7/9] v4l: vsp1: Adapt entities to configure into a body

, vsp1_dl_list_get_body0() is provided to access the internal body0 from the display list. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v4: - Rename vsp1_dl_list_get_body() to vsp1_dl_list_get_body0() The similarities between vsp1_dl_list_ge

[PATCH v4 6/9] v4l: vsp1: Refactor display list configure operations

is handled by passing the partition number to the configure call, and processing any runtime stage actions on the first partition only. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_bru.c| 12 +- drivers/media/platform/vsp1/vsp1

[PATCH v4 2/9] v4l: vsp1: Protect bodies against overflow

buffer overflows. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- v3: - adapt for new 'body' terminology - simplify WARN_ON macro usage --- drivers/media/platform/vsp1/vsp1_dl.c | 7 +++

[PATCH v4 4/9] v4l: vsp1: Convert display lists to use new body pool

ore the hardware has committed a previous set of tables. Bodies are no longer 'freed' in interrupt context, but instead released back to their respective pools. This allows us to remove the garbage collector in the DLM. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>

[PATCH v4 1/9] v4l: vsp1: Reword uses of 'fragment' as 'body'

. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_clu.c | 10 +- drivers/media/platform/vsp1/vsp1_dl.c | 107 -- drivers/media/platform/vsp1/vsp1_dl.h | 14 +-- drivers/media/platform/vsp1/vsp1_lut.c

[PATCH v4 0/9] vsp1: TLB optimisation and DL caching

histogram HGT with hue areas 0,10,50,60,100,110,150,160,200,210,250,255: pass Testing histogram HGT with hue areas 10,20,50,60,100,110,150,160,200,210,230,240: pass Testing histogram HGT with hue areas 240,20,60,80,100,120,140,160,180,200,210,220: pass Kieran Bingham (9): v4l: vsp1: Reword u

Re: [PATCH v2 5/8] v4l: vsp1: Refactor display list configure operations

Hi Laurent, Just a query on your bikeshedding here. Choose your colours wisely :) -- Kieran On 12/09/17 20:19, Laurent Pinchart wrote: > Hi Kieran, > > On Tuesday, 12 September 2017 00:16:50 EEST Kieran Bingham wrote: >> On 17/08/17 19:13, Laurent Pinchart wrote: >>>

Re: [PATCH v2 6/8] v4l: vsp1: Adapt entities to configure into a body

Hi Laurent, On 12/09/17 20:18, Laurent Pinchart wrote: > Hi Kieran, > > On Tuesday, 12 September 2017 00:42:09 EEST Kieran Bingham wrote: >> On 17/08/17 18:58, Laurent Pinchart wrote: >>> On Monday 14 Aug 2017 16:13:29 Kieran Bingham wrote: >>>> Currently the

Re: [PATCH v2 7/8] v4l: vsp1: Move video configuration to a cached dlb

Hi Laurent, Thankyou for the review, and your patience on the long awaited response on these remaining patches. On 17/08/17 19:10, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:30 Kieran Bingham wrote: >> We are

Re: [PATCH/RFC 1/2] v4l: v4l2-dev: Add infrastructure to protect device unplug race

Hi Laurent, On 16/11/17 12:32, Sakari Ailus wrote: > Hi Laurent, > > Thank you for the initiative to bring up and address the matter! I concur - this looks like a good start towards managing the issue. One potential thing spotted on top of Sakari's review inline below, of course I suspect this

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

ties (e.g. auto-gain), > the values of other properties (e.g. gain) can change in the camera. > Examining the flags ensures that the driver is aware of such properties. > > Signed-off-by: Edgar Thier <i...@edgarthier.net> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideas

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

Hi Edgar, On 15/11/17 08:11, Edgar Thier wrote: > Hi, > > I was wondering if there are any problems with my latest patch or if it > simply slipped through. Slipped though in high mail volumes :) I think it's easier to see updated patches if they are posted as a new thread, with an increased

Re: [PATCH v1 01/10] dt-bindings: media: Add Renesas CEU bindings

Hi Jacopo, A couple of minor language fixups inline. On 15/11/17 10:55, Jacopo Mondi wrote: > Add bindings documentation for Renesas Capture Engine Unit (CEU). > > Signed-off-by: Jacopo Mondi > --- > .../devicetree/bindings/media/renesas,ceu.txt | 87 >

Re: [PATCH v2] media: vsp1: Prevent suspending and resuming DRM pipelines

Hi Laurent, On 12/11/17 04:28, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Wednesday, 20 September 2017 12:16:54 EET Kieran Bingham wrote: >> When used as part of a display pipeline, the VSP is stopped and >> restarted explicitly

Re: [PATCH v2] media: vsp1: Prevent suspending and resuming DRM pipelines

Ping ... This patch appears to have got lost in the post. Could someone pick it up please? -- Regards Kieran On 20/09/17 10:16, Kieran Bingham wrote: > When used as part of a display pipeline, the VSP is stopped and > restarted explicitly by the DU from its suspend and resume ha

Re: [PATCH v1 15/15] media: i2c: adv748x: Remove duplicate NULL check

Hi Andy, Thankyou for the patch. On 31/10/17 14:21, Andy Shevchenko wrote: > Since i2c_unregister_device() became NULL-aware we may remove duplicate > NULL check. > > Cc: Kieran Bingham <kieran.bing...@ideasonboard.com> > Cc: Mauro Carvalho Chehab <mche...@kerne

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

Hi Edgar, Sorry for not replying to you yesterday on IRC, but by the time I got to reply to the message you weren't online.. On 11/10/17 12:56, Edgar Thier wrote: > > Use flags the device exposes for UVC controls. > This allows the device to define which property flags are set. > > Since some

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

Hi Edgar, Thank you for the patch respin. I'm still a bit concerned about that -ENOMEM though: On 06/10/17 11:34, Edgar Thier wrote: > > Use flags the device exposes for UVC controls. > This allows the device to define which property flags are set. > > Since some cameras offer

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

Hi Edgar, On 05/10/17 10:43, Kieran Bingham wrote: > Hi Edgar, > > On 18/08/17 11:12, Edgar Thier wrote: >> >> Use flags the device exposes for UVC controls. >> This allows the device to define which property flags are set. >> >> Since some cameras off

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

Hi Edgar, On 18/08/17 11:12, Edgar Thier wrote: > > Use flags the device exposes for UVC controls. > This allows the device to define which property flags are set. > > Since some cameras offer auto-adjustments for properties (e.g. auto-gain), > the values of other properties (e.g. gain) can

Re: [PATCH] v4l: vsp1: Start and stop DRM pipeline independently of planes

Salvator-X ES1.0 using the KMS Test suite, including suspend/resume, in combination with the "[PATCH 0/3] R-Car DU: Clip planes to screen boundaries" series. Tested-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pi

[PATCH v2] media: vsp1: Prevent suspending and resuming DRM pipelines

. Ensure that the VSP suspend and resume handlers do not affect DRM based pipelines. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH v1 1/3] media: vsp1: Prevent resuming DRM pipelines

Hi Laurent, On 15/09/17 17:58, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 15 September 2017 19:42:05 EEST Kieran Bingham wrote: >> DRM pipelines utilising the VSP must stop all frame processing as part >> of the suspend opera

Re: [PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers

Hi Laurent, Thanks for your speedy review! On 15/09/17 18:02, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 15 September 2017 19:42:06 EEST Kieran Bingham wrote: >> The pipeline needs to ensure that the hardware is idle for suspend and

[PATCH v1 3/3] drm: rcar-du: Remove unused CRTC suspend/resume functions

An early implementation of suspend-resume helpers are available in the CRTC module, however they are unused and no longer needed. With suspend and resume handled by the core DRM atomic helpers, we can remove the unused functions. CC: dri-de...@lists.freedesktop.org Signed-off-by: Kieran Bingham

[PATCH v1 0/3] drm/media: Implement DU Suspend and Resume on VSP pipelines

a merge of both the current linux-media master branch and the DRM drm-next tree. Kieran Bingham (3): media: vsp1: Prevent resuming DRM pipelines drm: rcar-du: Add suspend resume helpers drm: rcar-du: Remove unused CRTC suspend/resume functions drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 35

[PATCH v1 1/3] media: vsp1: Prevent resuming DRM pipelines

() call is not needed for DRM pipelines, and we can disable it in this instance. CC: linux-media@vger.kernel.org Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

[PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers

The pipeline needs to ensure that the hardware is idle for suspend and resume operations. Implement suspend and resume functions using the DRM atomic helper functions. CC: dri-de...@lists.freedesktop.org Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drive

[PATCH v3 7/9] v4l: vsp1: Adapt entities to configure into a body

, vsp1_dl_list_get_body() is provided to access the internal body0 from the display list. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- I don't like the fact this adds vsp1_dl_list_get_body() on top of vsp1_dl_body_get(); which are a bit too similar. Perhaps we

[PATCH v3 5/9] v4l: vsp1: Use reference counting for bodies

Extend the display list body with a reference count, allowing bodies to be kept as long as a reference is maintained. This provides the ability to keep a cached copy of bodies which will not change, so that they can be re-applied to multiple display lists. Signed-off-by: Kieran Bingham

[PATCH v3 6/9] v4l: vsp1: Refactor display list configure operations

is handled by passing the partition number to the configure call, and processing any runtime stage actions on the first partition only. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_bru.c| 12 +- drivers/media/platform/vsp1/vsp1

[PATCH v3 3/9] v4l: vsp1: Provide a body pool

multiple display list bodies in a single allocation, and providing these to the display list through a 'body pool'. A pool can be allocated by the display list manager or entities which require their own body allocations. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>

[PATCH v3 9/9] v4l: vsp1: Reduce display list body size

frame, for both DRM and Video API pipelines thus a rounded 64 entries provides a suitable allocation. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_dl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 8/9] v4l: vsp1: Move video configuration to a cached dlb

is reset - our cached configuration will be re-attached to the next committed DL. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v3: - 's/fragment/body/', 's/fragments/bodies/' - video dlb cache allocation increased from 2 to 3 dlbs Our video DL usage

[PATCH v3 2/9] v4l: vsp1: Protect bodies against overflow

buffer overflows. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- v3: - adapt for new 'body' terminology - simplify WARN_ON macro usage --- drivers/media/platform/vsp1/vsp1_dl.c | 7 +++

[PATCH v3 1/9] v4l: vsp1: Reword uses of 'fragment' as 'body'

. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_clu.c | 10 +- drivers/media/platform/vsp1/vsp1_dl.c | 107 -- drivers/media/platform/vsp1/vsp1_dl.h | 14 +-- drivers/media/platform/vsp1/vsp1_lut.c

[PATCH v3 4/9] v4l: vsp1: Convert display lists to use new body pool

ore the hardware has committed a previous set of tables. Bodies are no longer 'freed' in interrupt context, but instead released back to their respective pools. This allows us to remove the garbage collector in the DLM. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>

[PATCH v3 0/9] vsp1: TLB optimisation and DL caching

in this series can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git tags/vsp1/tlb-optimise/v3 Kieran Bingham (9): v4l: vsp1: Reword uses of 'fragment' as 'body' v4l: vsp1: Protect bodies against overflow v4l: vsp1: Provide a body pool v4l: vsp1: Convert display

[PATCH] media: i2c: adv748x: Map v4l2_std_id to the internal reg value

f-by: Simon Yuan <simon.y...@navico.com> [Kieran: Obtain the std from the afe->curr_norm] Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- Simon, I've added your implicit Signed-off-by tag as part of resubmitting this patch. Please confirm your agreeme

Re: [PATCH v2 6/8] v4l: vsp1: Adapt entities to configure into a body

Hi Laurent, On 17/08/17 18:58, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:29 Kieran Bingham wrote: >> Currently the entities store their configurations into a display list. >> Adapt this such that the code ca

Re: [PATCH v2 5/8] v4l: vsp1: Refactor display list configure operations

Hi Laurent, On 17/08/17 19:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:28 Kieran Bingham wrote: >> The entities provide a single .configure operation which configures the >> object into the

<    1   2   3   4   5   6   7   8   >