Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

2018-10-12 Thread Lee Jones
On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > Hi Lee, > > On 10/12/2018 02:34 PM, Lee Jones wrote: > > On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > >> On 10/12/2018 12:20 PM, Kieran Bingham wrote: > >>> Hi Vladimir, > >>> On 12/10/18 09

Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

2018-10-12 Thread Lee Jones
On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > On 10/12/2018 11:39 AM, Lee Jones wrote: > > On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > >> On 10/12/2018 09:03 AM, Lee Jones wrote: > >>> On Tue, 09 Oct 2018, Vladimir Zapolskiy wrote: > >>> > >

Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

2018-10-12 Thread Lee Jones
On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > On 10/12/2018 12:20 PM, Kieran Bingham wrote: > > Hi Vladimir, > > On 12/10/18 09:39, Lee Jones wrote: > >> On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > >>> On 10/12/2018 09:03 AM, Lee Jones wrote: > >&

Re: [PATCH 5/7] mfd: ds90ux9xx: add I2C bridge/alias and link connection driver

2018-10-12 Thread Lee Jones
On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > On 10/12/2018 09:04 AM, Lee Jones wrote: > > On Tue, 09 Oct 2018, Vladimir Zapolskiy wrote: > > > >> From: Vladimir Zapolskiy > >> > >> The change adds TI DS90Ux9xx I2C bridge/alias subdevice driver and &

Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

2018-10-12 Thread Lee Jones
On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote: > On 10/12/2018 09:03 AM, Lee Jones wrote: > > On Tue, 09 Oct 2018, Vladimir Zapolskiy wrote: > > > >> From: Vladimir Zapolskiy > >> > >> The change adds I2C device driver for TI DS90Ux9xx de-/serializers

Re: [PATCH 5/7] mfd: ds90ux9xx: add I2C bridge/alias and link connection driver

2018-10-11 Thread Lee Jones
vers/mfd/ds90ux9xx-i2c-bridge.c | 764 + > 3 files changed, 773 insertions(+) > create mode 100644 drivers/mfd/ds90ux9xx-i2c-bridge.c Shouldn't this live in drivers/i2c? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

2018-10-11 Thread Lee Jones
ing up the de-/serializer > + chips. Additional functionalities like connection handling to > + remote de-/serializers, I2C bridging, pin multiplexing, GPIO > + controller and so on are provided by separate drivers and should > + enabled individually. This is not an MFD dri

Re: [PATCH v7 0/6] Add ChromeOS EC CEC Support

2018-06-10 Thread Lee Jones
think patches 1+2 can just go to the i915 tree. The i915 driver changes > often, > so going through that tree makes sense. The cec-notifier code is unlikely to > change, > and I am fine with that patch going through i915. > > > for media to merge the mfd branch + patch 7 ? >

Re: [PATCH 1/7] i2c: i2c-gpio: move header to platform_data

2018-04-20 Thread Lee Jones
ertions(+), 10 deletions(-) > rename include/linux/{ => platform_data}/i2c-gpio.h (100%) Acked-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

[PATCH 1/2] [media] rc-core: Add inlined stubs for core rc_* functions

2017-04-05 Thread Lee Jones
doing things within the Linux kernel. Signed-off-by: Lee Jones --- include/media/rc-core.h | 42 ++ 1 file changed, 42 insertions(+) diff --git a/include/media/rc-core.h b/include/media/rc-core.h index 73ddd721..45ba739 100644 --- a/include/media/rc-core.h

[PATCH 2/2] [media] cec: Handle RC capability more elegantly

2017-04-05 Thread Lee Jones
e for other RC-only calls. This is preferable to having ugly #ifery scattered throughout C code. Most of the functions are actually safe to call, since they sensibly check for a NULL RC pointer before they attempt to deference it. Signed-off-by: Lee Jones --- drivers/media/cec/cec-core.c

Re: [PATCH 2/2] [media] cec: Handle RC capability more elegantly

2017-04-05 Thread Lee Jones
On Tue, 04 Apr 2017, Russell King - ARM Linux wrote: > On Tue, Apr 04, 2017 at 05:10:05PM +0100, Lee Jones wrote: > > @@ -237,7 +241,6 @@ struct cec_adapter *cec_allocate_adapter(const struct > > cec_adap_ops *ops, > > if (!(caps & CEC_CAP_RC)) > >

Re: [PATCH] [media] cec: Handle RC capability more elegantly

2017-04-05 Thread Lee Jones
On Tue, 04 Apr 2017, Russell King - ARM Linux wrote: > On Tue, Apr 04, 2017 at 04:19:39PM +0100, Lee Jones wrote: > > On Tue, 04 Apr 2017, Hans Verkuil wrote: > > > > > On 04/04/2017 04:43 PM, Lee Jones wrote: > > > > If a user specifies the use of RC as a ca

Re: [PATCH] [media] cec: Handle RC capability more elegantly

2017-04-05 Thread Lee Jones
On Tue, 04 Apr 2017, Hans Verkuil wrote: > On 04/04/2017 05:36 PM, Russell King - ARM Linux wrote: > > On Tue, Apr 04, 2017 at 04:19:39PM +0100, Lee Jones wrote: > >> On Tue, 04 Apr 2017, Hans Verkuil wrote: > >> > >>> On 04/04/2017 04:43 PM, Lee Jones wrote

[PATCH 1/2] [media] rc-core: Add inlined stubs for core rc_* functions

2017-04-04 Thread Lee Jones
doing things within the Linux kernel. Signed-off-by: Lee Jones --- include/media/rc-core.h | 42 ++ 1 file changed, 42 insertions(+) diff --git a/include/media/rc-core.h b/include/media/rc-core.h index 73ddd721..1f2043d 100644 --- a/include/media/rc-core.h

[PATCH 2/2] [media] cec: Handle RC capability more elegantly

2017-04-04 Thread Lee Jones
e for other RC-only calls. This is preferable to having ugly #ifery scattered throughout C code. Most of the functions are actually safe to call, since they sensibly check for a NULL RC pointer before they attempt to deference it. Signed-off-by: Lee Jones --- drivers/media/cec/cec-core.c

Re: [PATCH] [media] cec: Handle RC capability more elegantly

2017-04-04 Thread Lee Jones
On Tue, 04 Apr 2017, Hans Verkuil wrote: > On 04/04/2017 04:43 PM, Lee Jones wrote: > > If a user specifies the use of RC as a capability, they should > > really be enabling RC Core code. If they do not we WARN() them > > of this and disable the capability for them. > >

[PATCH] [media] cec: Handle RC capability more elegantly

2017-04-04 Thread Lee Jones
e for other RC-only calls. This is preferable to having ugly #ifery scattered throughout C code. Most of the functions are actually safe to call, since they sensibly check for a NULL RC pointer before they attempt to deference it. Signed-off-by: Lee Jones --- drivers/media/cec/cec-core.c

Re: [PATCH 1/2] [media] cec: Move capability check inside #if

2017-04-04 Thread Lee Jones
On Tue, 04 Apr 2017, Hans Verkuil wrote: > On 04/04/2017 03:01 PM, Lee Jones wrote: > > On Tue, 04 Apr 2017, Lee Jones wrote: > > > >> On Tue, 04 Apr 2017, Hans Verkuil wrote: > >> > >>> On 04/04/2017 02:32 PM, Lee Jones wrote: > >>>&g

Re: [PATCH 1/2] [media] cec: Move capability check inside #if

2017-04-04 Thread Lee Jones
On Tue, 04 Apr 2017, Lee Jones wrote: > On Tue, 04 Apr 2017, Hans Verkuil wrote: > > > On 04/04/2017 02:32 PM, Lee Jones wrote: > > > If CONFIG_RC_CORE is not enabled then none of the RC code will be > > > executed anyway, so we're placing the capability check

Re: [PATCH 2/2] [media] cec: Fix runtime BUG when (CONFIG_RC_CORE && !CEC_CAP_RC)

2017-04-04 Thread Lee Jones
On Tue, 04 Apr 2017, Hans Verkuil wrote: > On 04/04/2017 02:32 PM, Lee Jones wrote: > > Currently when the RC Core is enabled (reachable) core code located > > in cec_register_adapter() attempts to populate the RC structure with > > a pointer to the 'paren

Re: [PATCH 1/2] [media] cec: Move capability check inside #if

2017-04-04 Thread Lee Jones
On Tue, 04 Apr 2017, Hans Verkuil wrote: > On 04/04/2017 02:32 PM, Lee Jones wrote: > > If CONFIG_RC_CORE is not enabled then none of the RC code will be > > executed anyway, so we're placing the capability check inside the > > > > Signed-off-by: Lee Jones &g

[PATCH 2/2] [media] cec: Fix runtime BUG when (CONFIG_RC_CORE && !CEC_CAP_RC)

2017-04-04 Thread Lee Jones
then there will be no RC structure to populate. This causes a "NULL pointer dereference" error. Fixes: f51e80804f0 ("[media] cec: pass parent device in register(), not allocate()") Signed-off-by: Lee Jones --- drivers/media/cec/cec-core.c | 2 +- 1 file changed, 1 insertion(+

[PATCH 1/2] [media] cec: Move capability check inside #if

2017-04-04 Thread Lee Jones
If CONFIG_RC_CORE is not enabled then none of the RC code will be executed anyway, so we're placing the capability check inside the Signed-off-by: Lee Jones --- drivers/media/cec/cec-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/cec/cec-cor

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

2015-11-16 Thread Lee Jones
_drv.c | 2 +- > drivers/media/platform/soc_camera/omap1_camera.c | 2 +- > drivers/media/platform/soc_camera/soc_camera_platform.c | 2 +- > drivers/media/platform/timblogiw.c| 2 +- > drivers/media/radio/radio-timb.c

Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios

2015-09-01 Thread Lee Jones
On Tue, 01 Sep 2015, Peter Griffin wrote: > On Tue, 01 Sep 2015, Javier Martinez Canillas wrote: > > On Tue, Sep 1, 2015 at 11:09 AM, Lee Jones wrote: > > > On Tue, 01 Sep 2015, Javier Martinez Canillas wrote: > > >> On Fri, Aug 28, 2015 at 7:52 PM, Peter Griffin &g

Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios

2015-09-01 Thread Lee Jones
On Tue, 01 Sep 2015, Javier Martinez Canillas wrote: > Hello Lee, > > On Tue, Sep 1, 2015 at 11:09 AM, Lee Jones wrote: > > On Tue, 01 Sep 2015, Javier Martinez Canillas wrote: > >> On Fri, Aug 28, 2015 at 7:52 PM, Peter Griffin > >> wrote: > >>

Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios

2015-09-01 Thread Lee Jones
; > This change has been done as one atomic commit. > > > > Signed-off-by: Peter Griffin > > Acked-by: Lee Jones > > --- > > Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt | 6 +++--- > > arch/arm/boot/dts/stihxxx-b2120.dtsi

Re: [PATCH v3 2/6] ARM: DT: STi: STiH407: Add c8sectpfe LinuxDVB DT node.

2015-09-01 Thread Lee Jones
ihxxx-b2120.dtsi | 35 +++ > 1 file changed, 35 insertions(+) Acked-by: Lee Jones > diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi > b/arch/arm/boot/dts/stihxxx-b2120.dtsi > index 62994ae..f9fca10 100644 > --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi > +++

Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios

2015-09-01 Thread Lee Jones
intainers whether or not this breakage is acceptable. This driver is new. The 'original' bindings are in next. So this binding is not even close to being ABI. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Li

Re: [PATCH v2 2/5] ARM: DT: STi: STiH407: Add c8sectpfe LinuxDVB DT node.

2015-08-28 Thread Lee Jones
ome *after* the ones they reference. > + /* tsin0 is TSA on NIMA */ > + tsin0: port@0 { > + tsin-num= <0>; > + serial-not-parallel; > + i2c-bus

Re: [PATCH v2 1/5] ARM: DT: STi: stihxxx-b2120: Add pulse-width properties to ssc2 & ssc3

2015-08-28 Thread Lee Jones
> 1 file changed, 8 insertions(+), 2 deletions(-) Acked-by: Lee Jones > diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi > b/arch/arm/boot/dts/stihxxx-b2120.dtsi > index f589fe4..62994ae 100644 > --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi > +++ b/arch/arm/boot/dts/s

Re: [PATCH v2 3/5] [media] c8sectpfe: Remove select on undefined LIBELF_32

2015-08-27 Thread Lee Jones
ey should be in chronological order. > --- > drivers/media/platform/sti/c8sectpfe/Kconfig | 1 - > 1 file changed, 1 deletion(-) Acked-by: Lee Jones > diff --git a/drivers/media/platform/sti/c8sectpfe/Kconfig > b/drivers/media/platform/sti/c8sectpfe/Kconfig > index d1bfd4c..b9ec667 1006

Re: [PATCH v2 4/5] [media] c8sectpfe: Update binding to reset-gpios

2015-08-27 Thread Lee Jones
t; --- > Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt | 6 +++--- > arch/arm/boot/dts/stihxxx-b2120.dtsi | 4 ++-- > drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) Acke

Re: [PATCH v2 5/5] [media] c8sectpfe: Update DT binding doc with some minor fixes

2015-08-27 Thread Lee Jones
= <0>; > @@ -78,7 +77,6 @@ Example: > reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; > dvb-card= ; > }; > - My personal preference is to have a '\n' between no

Re: [PATCH v5 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-29 Thread Lee Jones
On Wed, 29 Apr 2015, Jacek Anaszewski wrote: > On 04/29/2015 02:34 PM, Lee Jones wrote: > >LED Ack please Bryan. > > You've already applied v6 with Bryan's ack today :) Ah, this is the same patch? Jolly good! -- Lee Jones Linaro STMicroelectronics Landing Team Lead

Re: [PATCH v5 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-29 Thread Lee Jones
LED Ack please Bryan. > This patch adds device tree binding documentation for > the flash cell of the Maxim max77693 multifunctional device. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Lee Jones > Cc: Chanwoo Ch

Re: [PATCH v6 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-29 Thread Lee Jones
gt;; > + > + camera_flash: flash-led { > + label = "max77693-flash"; > + led-sources = <0>, <1>; > + led-max-microamp = <50>; > +

Re: [PATCH v6 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-28 Thread Lee Jones
kari Ailus > Cc: Lee Jones > Cc: Chanwoo Choi > Cc: Bryan Wu > Cc: Richard Purdie > Cc: devicet...@vger.kernel.org > --- > Documentation/devicetree/bindings/mfd/max77693.txt | 67 > > 1 file changed, 67 insertions(+) Requires a LED Ack. --

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-04-02 Thread Lee Jones
On Thu, 02 Apr 2015, Pavel Machek wrote: > On Mon 2015-03-23 15:59:37, Lee Jones wrote: > > On Mon, 23 Mar 2015, Pavel Machek wrote: > > > > > On Mon 2015-03-23 15:02:13, Lee Jones wrote: > > > > On Mon, 23 Mar 2015, Pavel Machek wrote: > > > &g

Re: [PATCH v1 02/11] DT: Add documentation for the mfd Maxim max77693

2015-03-26 Thread Lee Jones
On Fri, 20 Mar 2015, Jacek Anaszewski wrote: > This patch adds device tree binding documentation for > the flash cell of the Maxim max77693 multifunctional device. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Lee Jone

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Lee Jones
On Mon, 23 Mar 2015, Pavel Machek wrote: > On Mon 2015-03-23 15:02:13, Lee Jones wrote: > > On Mon, 23 Mar 2015, Pavel Machek wrote: > > > On Mon 2015-03-23 12:07:43, Lee Jones wrote: > > > > This patch requires a DT Ack. > > > > > > No, it require

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Lee Jones
On Mon, 23 Mar 2015, Pavel Machek wrote: > On Mon 2015-03-23 12:07:43, Lee Jones wrote: > > This patch requires a DT Ack. > > No, it requires DT people to be notified -- and they were, few times > by now. > > They clearly don't care. Well fortunately for the Kernel

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Lee Jones
This patch requires a DT Ack. > This patch adds device tree binding documentation for > the flash cell of the Maxim max77693 multifunctional device. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Lee Jones > Cc: Chan

Re: [PATCH/RFC v13 03/13] leds: Add support for max77693 mfd flash cell

2015-03-23 Thread Lee Jones
n flash and torch mode. The leds can be triggered > > externally or by software. > > > > Signed-off-by: Jacek Anaszewski > > Signed-off-by: Andrzej Hajda > > Acked-by: Kyungmin Park > > Cc: Bryan Wu > > Cc: Richard Purdie > > Cc: Lee Jo

Re: [PATCH/RFC v13 03/13] leds: Add support for max77693 mfd flash cell

2015-03-23 Thread Lee Jones
xternally or by software. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: Lee Jones > Cc: Chanwoo Choi > --- > drivers/leds/Kconfig | 10 + > drivers/leds/Makefile

Re: [PATCH/RFC v12 05/19] mfd: max77693: Modify flash cell name identifiers

2015-03-09 Thread Lee Jones
On Wed, 04 Mar 2015, Jacek Anaszewski wrote: > Change flash cell identifiers from max77693-flash to max77693-led > to avoid confusion with NOR/NAND Flash. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Acked-by: Lee Jones > --- > drivers/mfd/max77693

Re: [PATCH/RFC v12 07/19] mfd: max77693: add TORCH_IOUT_MASK macro

2015-03-09 Thread Lee Jones
-by: Kyungmin Park > Cc: Chanwoo Choi > Cc: Lee Jones > --- > include/linux/mfd/max77693-private.h |1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/include/linux/mfd/max77693-private.h > b/include/linux/mfd/max77693-private.h > index 955dd99

Re: [PATCH/RFC v12 08/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-03-09 Thread Lee Jones
ions of leds-max77693.c driver, which was > not merged. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Chanwoo Choi > Cc: Lee Jones > --- > include/linux/mfd/max77693-private.h |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied

Re: [PATCH/RFC v12 06/19] mfd: max77693: Remove struct max77693_led_platform_data

2015-03-09 Thread Lee Jones
zewski > Acked-by: Kyungmin Park > Cc: Chanwoo Choi > Cc: Lee Jones > --- > include/linux/mfd/max77693.h | 13 - > 1 file changed, 13 deletions(-) Applied, thanks. > diff --git a/include/linux/mfd/max77693.h b/include/linux/mfd/max77693.h > index f0b6585..c

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Pavel Machek wrote: > On Tue 2015-01-20 15:40:29, Lee Jones wrote: > > On Tue, 20 Jan 2015, Jacek Anaszewski wrote: > > > > > On 01/20/2015 02:01 PM, Jacek Anaszewski wrote: > > > >On 01/20/2015 12:17 PM, Lee Jones wrote: > > >

Re: [PATCH/RFC v10 05/19] mfd: max77693: Modify flash cell name identifiers

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Jacek Anaszewski wrote: > On 01/20/2015 12:13 PM, Lee Jones wrote: > >On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > > > >>Change flash cell identifiers from max77693-flash to max77693-led > >>to avoid confusion with NOR/NAND Flash. > >

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Jacek Anaszewski wrote: > On 01/20/2015 02:01 PM, Jacek Anaszewski wrote: > >On 01/20/2015 12:17 PM, Lee Jones wrote: > >>On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > >> > >>>Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

Re: [PATCH/RFC v10 09/19] DT: Add documentation for the mfd Maxim max77693

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Jacek Anaszewski wrote: > On 01/20/2015 12:21 PM, Lee Jones wrote: > >On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > > > >>This patch adds device tree binding documentation for > >>the flash cell of the Maxim max77693 multifunctional devi

Re: [PATCH/RFC v10 09/19] DT: Add documentation for the mfd Maxim max77693

2015-01-20 Thread Lee Jones
On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > This patch adds device tree binding documentation for > the flash cell of the Maxim max77693 multifunctional device. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Lee Jone

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Lee Jones
Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Chanwoo Choi > Cc: Lee Jones > --- > include/linux/mfd/max77693-private.h |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mfd/max77693-private.h > b/include/linux/mfd

Re: [PATCH/RFC v10 06/19] mfd: max77693: modifications around max77693_led_platform_data

2015-01-20 Thread Lee Jones
ooks fine, and I'm sure you've tested this thoroughly. I'm slightly concerned about current users though. Are there any? Is this patch-set fully bisectable? > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Chanwoo Choi > Cc: Lee Jones > --- &g

Re: [PATCH/RFC v10 05/19] mfd: max77693: Modify flash cell name identifiers

2015-01-20 Thread Lee Jones
;, > + .name = "max77693-led", > + .of_compatible = "maxim,max77693-led", > }, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Bl

Re: [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros

2015-01-20 Thread Lee Jones
On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > Add macros for max77693 led part related binding. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Lee Jones > Cc: Chanwoo Choi > --- > include/dt-bindings/mfd/max77693.h | 21 +++

Re: [PATCH v2 07/13] mfd: sun6i-prcm: Add support for the ir-clk

2014-12-18 Thread Lee Jones
On Thu, 18 Dec 2014, Hans de Goede wrote: > Hi, > > On 18-12-14 09:41, Lee Jones wrote: > >On Wed, 17 Dec 2014, Hans de Goede wrote: > > > >>Add support for the ir-clk which is part of the sun6i SoC prcm module. > >> > >>Signed-off-by: Hans de Go

Re: [PATCH v2 07/13] mfd: sun6i-prcm: Add support for the ir-clk

2014-12-18 Thread Lee Jones
n6i-a31-apb0-clock-reset", > .of_compatible = "allwinner,sun6i-a31-clock-reset", > .num_resources = ARRAY_SIZE(sun6i_a31_apb0_rstc_res), This is all pretty standard stuff: For my own reference: Acked-by: Lee Jones Do you do you expect this patch to be handled? --

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Lee Jones
On Tue, 09 Dec 2014, Jacek Anaszewski wrote: > On 12/09/2014 02:50 PM, Lee Jones wrote: > >On Tue, 09 Dec 2014, Jacek Anaszewski wrote: > > > >>On 12/09/2014 11:04 AM, Lee Jones wrote: > >>>On Tue, 09 Dec 2014, Jacek Anaszewski wrote: > >>> > >

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Lee Jones
On Tue, 09 Dec 2014, Jacek Anaszewski wrote: > On 12/09/2014 11:04 AM, Lee Jones wrote: > >On Tue, 09 Dec 2014, Jacek Anaszewski wrote: > > > >>On 12/09/2014 09:50 AM, Lee Jones wrote: > >>>On Wed, 03 Dec 2014, Jacek Anaszewski wrote: > >>> > >

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Lee Jones
On Tue, 09 Dec 2014, Jacek Anaszewski wrote: > On 12/09/2014 09:50 AM, Lee Jones wrote: > >On Wed, 03 Dec 2014, Jacek Anaszewski wrote: > > > >>Add "label" array for Device Tree strings with the name of a LED device > >>and make flash_timeout a

Re: [PATCH/RFC v9 03/19] mfd: max77693: Modify flash cell name identifiers

2014-12-09 Thread Lee Jones
On Tue, 09 Dec 2014, Jacek Anaszewski wrote: > On 12/09/2014 09:52 AM, Lee Jones wrote: > >On Wed, 03 Dec 2014, Jacek Anaszewski wrote: > > > >>Change flash cell identifiers from max77693-flash to max77693-led > >>to avoid confusion with NOR/NAND Flash. > &g

Re: [PATCH/RFC v9 03/19] mfd: max77693: Modify flash cell name identifiers

2014-12-09 Thread Lee Jones
On Wed, 03 Dec 2014, Jacek Anaszewski wrote: > Change flash cell identifiers from max77693-flash to max77693-led > to avoid confusion with NOR/NAND Flash. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Chanwoo Choi > Cc: Lee Jones > --- > dr

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Lee Jones
nodes representing sub-leds. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Chanwoo Choi > Cc: Lee Jones > --- > include/linux/mfd/max77693.h |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mfd/max77

Re: [PATCH/RFC v8 09/14] mfd: max77693: adjust max77693_led_platform_data

2014-12-01 Thread Lee Jones
On Mon, 01 Dec 2014, Jacek Anaszewski wrote: > On 12/01/2014 12:34 PM, Lee Jones wrote: > >On Fri, 28 Nov 2014, Jacek Anaszewski wrote: > > > >I'm guessing this will effect the other patches in the set? > > > > max77692 flash driver depends on it and it ha

Re: [PATCH/RFC v8 09/14] mfd: max77693: adjust max77693_led_platform_data

2014-12-01 Thread Lee Jones
related flash timeout. <-> Please use all of the 75 char buffer. > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Lee Jones > Cc: SangYoung Son > Cc: Samuel Ortiz > --- > include/linux/mfd/max77693.h |3 ++- > 1

Re: [PATCH/RFC v8 11/14] DT: Add documentation for the mfd Maxim max77693

2014-12-01 Thread Lee Jones
On Fri, 28 Nov 2014, Jacek Anaszewski wrote: > This patch adds device tree binding documentation for > the flash cell of the Maxim max77693 multifunctional device. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Lee Jones

Re: [PATCH v2 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-27 Thread Lee Jones
On Wed, 26 Nov 2014, Hans de Goede wrote: > Hi, > > On 11/25/2014 05:57 PM, Lee Jones wrote: > >On Sun, 23 Nov 2014, Hans de Goede wrote: > > > >>Add a driver for mod0 clocks found in the prcm. Currently there is only > >>one mod0 clocks in the prcm, the ir

Re: [PATCH v2 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-25 Thread Lee Jones
I'm well aware that I SoB'ed the patch which started them off). It's not a show stopper, although I'd prefer if they were fixed with a subsequent patch. Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for A

Re: [PATCH/RFC v5 1/3] mfd: max77693: Fix register enum name

2014-08-21 Thread Lee Jones
On Wed, 20 Aug 2014, Jacek Anaszewski wrote: > According to the MAX77693 documentation the name of > the register is FLASH_STATUS. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Lee Jones > Cc: SangYoung Son > Cc: Samuel Ortiz > --- &g

Re: [PATCH/RFC v5 2/3] leds: Add support for max77693 mfd flash cell

2014-08-21 Thread Lee Jones
pports up to > two leds which can work in flash and torch mode. Leds can > be triggered externally or by software. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Lee Jones > Cc: Bryan Wu > Cc: Richard Purdie

Re: [PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-16 Thread Lee Jones
and torch mode. Leds can > be triggered externally or by software. > > Signed-off-by: Andrzej Hajda > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: SangYoung Son > Cc: Samuel Ortiz > Cc: Lee Jones

Re: [PATCH/RFC v2 4/8] leds: Add support for max77693 mfd flash cell

2014-03-31 Thread Lee Jones
up to > two leds which can work in flash and torch mode. Leds can > be triggered externally or by software. > > Signed-off-by: Andrzej Hajda > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: SangYoung S

Re: [PATCH/RFC 6/8] leds: Add support for max77693 mfd flash cell

2014-03-21 Thread Lee Jones
>>two leds which can work in flash and torch mode. Leds can > >>be triggered externally or by software. > >> > >>Signed-off-by: Andrzej Hajda > >>Signed-off-by: Jacek Anaszewski > >>Acked-by: Kyungmin Park > >>Cc: Bryan Wu > >>Cc

Re: [PATCH/RFC 6/8] leds: Add support for max77693 mfd flash cell

2014-03-20 Thread Lee Jones
up to > two leds which can work in flash and torch mode. Leds can > be triggered externally or by software. > > Signed-off-by: Andrzej Hajda > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: SangYoung S

Re: [PATCH RFC v2 1/2] max77693: added device tree support

2013-08-14 Thread Lee Jones
> I have no response from Samuel regarding this patch. > Could you take care of it, I can rebase it again if necessary. Yes, please rebase onto v3.11-rc5 and resubmit. Thanks. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow