Re: [PATCH 2/2] media: i2c: isl7998x: Add driver for Intersil ISL7998x

2019-08-06 Thread Marek Vasut
otherwise. */ >> + ret = of_property_read_u32(dev->of_node, "isil,num-inputs", >> + &isl7998x->nr_inputs); >> +if (ret) >> +isl7998x->nr_inputs = 4; >> + >> +if (isl7998x->nr_inputs != 1 && isl7998x->nr_inputs != 2 && >> +isl7998x->nr_inputs != 4) { >> +dev_err(dev, "Invalid number of inputs selected in DT\n"); >> +return -EINVAL; >> +} >> + >> +isl7998x->pd_gpio = devm_gpiod_get_optional(dev, "pd", GPIOD_OUT_HIGH); >> +if (IS_ERR(isl7998x->pd_gpio)) { >> +dev_err(dev, "Failed to retrieve/request PD GPIO: %ld\n", >> +PTR_ERR(isl7998x->pd_gpio)); >> +return PTR_ERR(isl7998x->pd_gpio); >> +} >> + >> +isl7998x->regmap = devm_regmap_init_i2c(client, &isl7998x_regmap); >> +if (IS_ERR(isl7998x->regmap)) { >> +ret = PTR_ERR(isl7998x->regmap); >> +dev_err(dev, "Failed to allocate register map: %d\n", ret); >> +return ret; >> +} >> + >> +ep = of_graph_get_next_endpoint(dev->of_node, NULL); >> +if (!ep) { >> +dev_err(dev, "Missing endpoint node\n"); >> +return -EINVAL; >> +} >> + >> +ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &endpoint); >> +of_node_put(ep); >> +if (ret) { >> +dev_err(dev, "Failed to parse endpoint\n"); >> +return ret; >> +} >> + >> +if (endpoint.bus_type != V4L2_MBUS_CSI2_DPHY || >> +endpoint.bus.mipi_csi2.num_data_lanes == 0 || >> +endpoint.bus.mipi_csi2.num_data_lanes > 2) { >> +dev_err(dev, "Invalid bus type or number of MIPI lanes\n"); >> +return -EINVAL; >> +} >> + >> +isl7998x->nr_mipi_lanes = endpoint.bus.mipi_csi2.num_data_lanes; >> + >> +v4l2_i2c_subdev_init(&isl7998x->subdev, client, &isl7998x_subdev_ops); >> +isl7998x->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; >> + >> +#ifdef CONFIG_MEDIA_CONTROLLER >> +isl7998x->pad.flags = MEDIA_PAD_FL_SOURCE; >> +isl7998x->subdev.entity.ops = &isl7998x_entity_ops; >> +isl7998x->subdev.entity.function = MEDIA_ENT_F_CAM_SENSOR; > > This is definitely not a camera sensor. > > MEDIA_ENT_F_VID_IF_BRIDGE perhaps? > > How does the driver work without MC? MC ? > E.g. how are the formats on the inputs set up? They are auto-detected by the chip. [...] -- Best regards, Marek Vasut

Re: [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings

2019-08-06 Thread Marek Vasut
On 7/1/19 10:04 AM, Sakari Ailus wrote: > Hi Marek, > > On Mon, May 20, 2019 at 10:18:11PM +0200, Marek Vasut wrote: >> Add bindings for the Intersil ISL7998x BT656-to-MIPI-CSI2 decoder. >> >> Signed-off-by: Marek Vasut >> Cc: Sakari Ailus >> Cc: Mauro Car

Re: [PATCH 2/2] media: i2c: isl7998x: Add driver for Intersil ISL7998x

2019-08-06 Thread Marek Vasut
On 7/1/19 9:58 AM, Jacopo Mondi wrote: [...] >> +#define ISL7998x_REG_P5_H_LINE_CNT_1ISL7998x_REG(5, 0x3a) >> +#define ISL7998x_REG_P5_H_LINE_CNT_2ISL7998x_REG(5, 0x3b) >> +#define ISL7998x_REG_P5_HIST_LINE_CNT_1 ISL7998x_REG(5, 0x3c) >> +#define ISL799

Re: [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings

2019-08-06 Thread Marek Vasut
On 5/29/19 1:15 PM, Ian Arkver wrote: > Hi Marek, > > On 29/05/2019 12:09, Marek Vasut wrote: >> On 5/29/19 1:04 PM, Ian Arkver wrote: >>> Hi, >>> >>> On 29/05/2019 11:41, Marek Vasut wrote: >>>> On 5/29/19 8:28 AM, Jacopo Mondi wro

Re: [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings

2019-08-06 Thread Marek Vasut
On 5/29/19 3:43 PM, Jacopo Mondi wrote: > HI Marek, Hi, > On Wed, May 29, 2019 at 01:09:47PM +0200, Marek Vasut wrote: >> On 5/29/19 1:04 PM, Ian Arkver wrote: >>> Hi, >>> >>> On 29/05/2019 11:41, Marek Vasut wrote: >>>> On 5/29/19 8:28 AM, Ja

Re: [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings

2019-05-29 Thread Marek Vasut
On 5/29/19 1:04 PM, Ian Arkver wrote: > Hi, > > On 29/05/2019 11:41, Marek Vasut wrote: >> On 5/29/19 8:28 AM, Jacopo Mondi wrote: >> >> [...] >> >>>>>>> [1] >>>>>>> https://www.renesas.com/eu/en/produ

Re: [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings

2019-05-29 Thread Marek Vasut
ting binding >> makes sense. >> >> However unlike the adv7482, the isl79987 does not support remapping the >> physical inputs to ADCs in the chip. It does support some remapping of >> physical inputs to MIPI CSI2 channels, but that's probably not very useful. >> > > I understand, but I will now use against you the argument you have > correctly pointed out here below that DT should describe hardware, and > the hardware has indeed 4 input ports.. My question here is whether it makes sense to describe the ports even if they cannot be muxed to different ADC. Does it ? [...] -- Best regards, Marek Vasut

Re: [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings

2019-05-28 Thread Marek Vasut
ight want to provide 2 output ports, one CSI-2 and one > BT565 and parse the right one depending on the compatible string. The chip only has one physical output port (either CSI2 or parallel) and DT should model the hardware, so I would expect there to be one output port per chip ? > I would als

Re: [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings

2019-05-28 Thread Marek Vasut
On 5/28/19 1:47 PM, Jacopo Mondi wrote: > Hi Marek, >thanks for the patch Hi, > On Mon, May 20, 2019 at 10:18:11PM +0200, Marek Vasut wrote: >> Add bindings for the Intersil ISL7998x BT656-to-MIPI-CSI2 decoder. >> >> Signed-off-by: Marek Vasut >> Cc: Sa

[PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings

2019-05-20 Thread Marek Vasut
Add bindings for the Intersil ISL7998x BT656-to-MIPI-CSI2 decoder. Signed-off-by: Marek Vasut Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Cc: Rob Herring Cc: devicet...@vger.kernel.org To: linux-media@vger.kernel.org --- .../bindings/media/i2c/isl7998x.txt | 37

[PATCH 2/2] media: i2c: isl7998x: Add driver for Intersil ISL7998x

2019-05-20 Thread Marek Vasut
use the same resolution and standard. The only supported pixel format is now YUYV/YUV422. The chip should support RGB565 on the CSI2 as well, but this is currently unsupported. Signed-off-by: Marek Vasut Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Cc: Rob Herring To: linux-media@vger.kernel.org

[PATCH] media: imx: Parse MIPI CSI2 link frequency correctly

2019-05-20 Thread Marek Vasut
The current code did not extract the CSI2 link frequency from the menu items correctly. Fix this. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: Philipp Zabel Cc: Steve Longerbeam To: linux-media@vger.kernel.org --- drivers/staging/media/imx

[PATCH] media: imx: Handle VIDIOC_ENUMINPUT

2019-05-20 Thread Marek Vasut
Add basic handling for VIDIOC_ENUMINPUT, where the imx capture devices report they are cameras to userspace. Code like e.g. Qt5 qcamera uses this information when enumerating camera devices and this fixes it's operation on iMX6, where it previously didn't detect any cameras. Signed-off

Re: [PATCH 1/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx ICs

2018-10-09 Thread Marek Vasut
On 10/09/2018 10:55 PM, Vladimir Zapolskiy wrote: > On 10/09/2018 02:11 PM, Vladimir Zapolskiy wrote: >> Hi Marek, >> >> On 10/09/2018 03:13 AM, Marek Vasut wrote: >>> On 10/08/2018 11:11 PM, Vladimir Zapolskiy wrote: >>>> From: Sandeep Jain >

Re: [PATCH 1/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx ICs

2018-10-08 Thread Marek Vasut
t; + found, then SSCG will be disabled. > + > +TI DS90Ux9xx serializers and deserializer device nodes may contain a number > +of children device nodes to describe and enable particular subcomponents > +found on ICs. > + > +Example: > + > +serializer: serializer@c { > + compatible = "ti,ds90ub927q", "ti,ds90ux9xx"; > + reg = <0xc>; > + power-gpios = <&gpio5 12 GPIO_ACTIVE_HIGH>; > + ti,backward-compatible-mode = <0>; > + ti,low-frequency-mode = <0>; > + ti,pixel-clock-edge = <0>; > + ... > +} > + > +deserializer: deserializer@3c { > + compatible = "ti,ds90ub940q", "ti,ds90ux9xx"; > + reg = <0x3c>; > + power-gpios = <&gpio6 31 GPIO_ACTIVE_HIGH>; > + ... > +} > + > -- Best regards, Marek Vasut

Re: [PATCH] gpu: ipu-v3: Fix BT1120 interlaced CCIR codes

2018-05-23 Thread Marek Vasut
On 05/22/2018 01:07 PM, Philipp Zabel wrote: > Hi Marek, > > On Fri, 2018-05-18 at 18:21 +0200, Marek Vasut wrote: >> On 05/18/2018 05:51 PM, Philipp Zabel wrote: >>> Hi Marek, >>> >>> On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote: >>>

Re: [PATCH] gpu: ipu-v3: Fix BT1120 interlaced CCIR codes

2018-05-18 Thread Marek Vasut
On 05/18/2018 05:51 PM, Philipp Zabel wrote: > Hi Marek, > > On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote: >> The BT1120 interlaced CCIR codes are the same as BT656 ones >> and different than BT656 progressive CCIR codes, fix this. > > thank you for the pat

Re: [PATCH] media: imx: Skip every second frame in VDIC DIRECT mode

2018-04-21 Thread Marek Vasut
On 04/21/2018 11:29 PM, Steve Longerbeam wrote: > > > On 04/12/2018 03:04 AM, Philipp Zabel wrote: >> On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote: >>> In VDIC direct mode, the VDIC applies combing filter during and >>> doubles the framerate, that is

Re: [PATCH] media: imx: Skip every second frame in VDIC DIRECT mode

2018-04-12 Thread Marek Vasut
On 04/12/2018 12:04 PM, Philipp Zabel wrote: > On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote: >> In VDIC direct mode, the VDIC applies combing filter during and >> doubles the framerate, that is, after the first two half-frames >> are received and the first frame i

[PATCH] media: staging/imx: Handle CSI->VDIC->PRPVF pipeline

2018-04-07 Thread Marek Vasut
ted to the VDIC. Make the PRPVF driver configure the CSI mux only in case it's connected directly to CSI and not in case it is connected to VDIC. Signed-off-by: Marek Vasut Cc: Philipp Zabel Cc: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prp.c | 6 ++ drivers/staging

[PATCH] gpu: ipu-v3: Fix BT1120 interlaced CCIR codes

2018-04-07 Thread Marek Vasut
The BT1120 interlaced CCIR codes are the same as BT656 ones and different than BT656 progressive CCIR codes, fix this. Signed-off-by: Marek Vasut Cc: Steve Longerbeam Cc: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-csi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a

[PATCH] media: imx: Skip every second frame in VDIC DIRECT mode

2018-04-07 Thread Marek Vasut
full frames is as follows 12 32 34 54 etc. Drop every second frame to trim the framerate back to the original one of the signal and skip the odd patched frames. Signed-off-by: Marek Vasut Cc: Steve Longerbeam Cc: Philipp Zabel --- drivers/staging/media/imx/imx-media-vdic.c | 3 +++ 1 file

Re: [PATCH v5] media: video-i2c: add video-i2c driver

2017-01-08 Thread Marek Vasut
att > >> On Dec 23, 2016, at 19:04, Matt Ranostay wrote: >> >> There are several thermal sensors that only have a low-speed bus >> interface but output valid video data. This patchset enables support >> for the AMG88xx "Grid-Eye" sensor family. >>

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2016-12-30 Thread Marek Vasut
and a new version will be posted when he is back from > holidays. IMO Philipp's patches are better integrated and well structured, so I'd rather like to see his work in at some point. -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [RFC] v4l2 support for thermopile devices

2016-10-28 Thread Marek Vasut
or a new > one needs to be defined), and then in software you can figure out how > to colorize it. All true, I also did my share of poking into SEEK Thermal USB and it is an excellent candidate for a V4L2 driver, that one. But I think this device here is producing much smaller images, s

Re: [PATCH v2 08/21] [media] imx: Add i.MX IPUv3 capture driver

2016-10-19 Thread Marek Vasut
lags 0 > pad0: Source > > > > > root@imx6:~# media-ctl -v --links '"ar01351-0010":0->"mipi_ipu1_mux":0[1]' > > Opening media device /dev/media0 > Enumerating entities > Found 11 entities > Enumerating pads and links > No link between "ar0135 1-0010":0 and "mipi_ipu1_mux":0 > media_parse_setup_link: Unable to parse link > > "ar0135 1-0010":0->"mipi_ipu1_mux":0[1] > ^ > Unable to parse link: Invalid argument (22) > > If you have something in the works with a camera example then just tell > me to be patient and I'll wait for a v3 ;) Check whether you have something along these lines in your camera driver in the probe() function: priv->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; priv->subdev.dev = &client->dev; priv->pad.flags = MEDIA_PAD_FL_SOURCE; ret = media_entity_init(&priv->subdev.entity, 1, &priv->pad, 0); if (ret < 0) { v4l2_clk_put(priv->clk); return ret; } ret = v4l2_async_register_subdev(&priv->subdev); if (ret < 0) { v4l2_clk_put(priv->clk); return ret; } -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 08/21] [media] imx: Add i.MX IPUv3 capture driver

2016-10-17 Thread Marek Vasut
ther note > below: Which sensor do you use ? [...] -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 18/22] [media] imx-ipuv3-csi: support downsizing

2016-10-16 Thread Marek Vasut
On 10/14/2016 05:48 PM, Philipp Zabel wrote: > Am Freitag, den 07.10.2016, 21:01 +0200 schrieb Marek Vasut: >> On 10/07/2016 06:01 PM, Philipp Zabel wrote: >>> Add support for the CSI internal horizontal and vertical downsizing. >>> >>> Signed-off-by: Phili

Re: [PATCH 18/22] [media] imx-ipuv3-csi: support downsizing

2016-10-07 Thread Marek Vasut
ipu_csi_set_mipi_datatype(ipucsi->csi, /*VC*/ 0, > - &fmt[0]); > + ipu_csi_set_mipi_datatype(ipucsi->csi, /*VC*/ 0, &fmt[0]); This probably needs fixing , so that the correct VC is passed in ? > ret = ip

Re: [PATCH 12/22] [media] tc358743: put lanes in STOP state before starting streaming

2016-10-07 Thread Marek Vasut
> @@ -1637,6 +1645,7 @@ static const struct v4l2_subdev_video_ops > tc358743_video_ops = { > .g_dv_timings = tc358743_g_dv_timings, > .query_dv_timings = tc358743_query_dv_timings, > .g_mbus_config = tc358743_g_mbus_config, > + .prepare_stream = tc358743_prepare_stre

Re: [PATCH 03/22] [media] v4l: of: add v4l2_of_subdev_registered

2016-10-07 Thread Marek Vasut
+128,13 @@ static inline void v4l2_of_put_link(struct v4l2_of_link > *link) > { > } > > +#define v4l2_of_subdev_registered NULL > + > +struct v4l2_subdev *v4l2_find_subdev_by_node(struct v4l2_device *v4l2_dev, > + struct device_n

Re: [PATCH 01/22] [media] v4l2-async: move code out of v4l2_async_notifier_register into v4l2_async_test_nofity_all

2016-10-07 Thread Marek Vasut
return ret; > - } > - } Shouldn't you call ret = v4l2_async_test_notify_all() here now instead ? > mutex_unlock(&list_lock); > > - return 0; > + return ret; > } > EXPORT_SYMBOL(v4l2_async_notifier_register); > > -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-10 Thread Marek Vasut
On Wednesday, July 09, 2014 at 11:21:08 PM, Joe Perches wrote: > On Wed, 2014-07-09 at 22:39 +0200, Marek Vasut wrote: > > The above function looks like almost verbatim copy of print_hex_dump(). > > The only difference I can spot is that it's calling seq_printf() instead >

Re: [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-09 Thread Marek Vasut
On Wednesday, July 09, 2014 at 05:24:26 PM, Andy Shevchenko wrote: > The new seq_hex_dump() is a complete analogue of print_hex_dump(). > > We have few users of this functionality already. It allows to reduce their > codebase. > > Signed-off-by: Andy Shevchenko > --- > fs/seq_file.c

Re: [PATCHv5][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2013-12-05 Thread Marek Vasut
On Thursday, December 05, 2013 at 07:28:07 PM, Denis Carikli wrote: [...] Can you please explain the correction here ? Why is it needed ? What was the problem ? Thanks! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of

Re: [PATCHv16 0/7] of: add display helper

2013-01-09 Thread Marek Vasut
EVM, AM335x EVM, EVM-SK > > I don't know what Laurent Pinchart, Marek Vasut and Leela Krishna Amudala > are using. MX53QSB and another custom MX53 board. > Those are the people I know from the top of my head, that use > or at least did use the patches in one of its iterations.

Re: [PATCHv16 0/7] of: add display helper

2013-01-09 Thread Marek Vasut
Dear Steffen Trumtrar, > Hi! > > On Wed, Jan 09, 2013 at 08:12:01PM +0100, Marek Vasut wrote: > > Dear Steffen Trumtrar, > > > > I tested this on 3.8-rc1 (next 20130103) with the imx drm driver. After > > adding the following piece of code (quick hack),

Re: [PATCHv16 0/7] of: add display helper

2013-01-09 Thread Marek Vasut
rm_mode_copy(mode, &imxpd->mode); + mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, + drm_mode_probed_add(connector, mode); + num_modes++; + } + return num_modes; } Best regards, Marek Vasut -- To unsubscribe from th

Re: Terratec Cinergy S2 USB HD

2011-12-30 Thread Marek Vasut
> Hi Linux Media Team > > Is there a way to get running my Cinergy S2 USB HD under Ubuntu 11.10? > Or should i give it back and buy a supported card? > > Greetz > > franco Does it bind with any driver if you connect it? M -- To unsubscribe from this list: send the line "unsubscribe linux-media

Re: [PATCH v3] v4l: Add driver for Micron MT9M032 camera sensor

2011-12-13 Thread Marek Vasut
Dear Martin Hostettler, > The MT9M032 is a parallel 1.6MP sensor from Micron controlled through I2C. > > The driver creates a V4L2 subdevice. It currently supports cropping, gain, > exposure and v/h flipping controls in monochrome mode with an > external pixel clock. > > Signed-off-by: Martin Ho

Re: Problems cloning the git repostories

2011-10-30 Thread Marek Vasut
> On Sun, Sep 25, 2011 at 8:33 AM, Patrick Dickey wrote: > > Hello there, > > > > I tried to follow the steps for cloning both the "media_tree.git" and > > "media_build.git" repositories, and received errors for both. The > > media_tree repository failed on the first line > > > >> git clone > >

Re: femon patch for dB

2011-10-28 Thread Marek Vasut
> I added a switch to femon so it displays signal and snr in dB. > > The cx23885 driver for my Hauppauge WinTV-HVR1250 reports signal and snr > in dB. > > http://lockie.ca/test/femon.patch.bz2 Use git send-email to submit patches to mailing lists, thanks -- To unsubscribe from this list: send th

Re: [RFC PATCH 05/12] ov9640: convert to the control framework.

2011-01-11 Thread Marek Vasut
On Wednesday 12 January 2011 00:06:05 Hans Verkuil wrote: > Signed-off-by: Hans Verkuil Hey, I can do a test-run on this one eventually ;-) Cheers > --- > drivers/media/video/ov9640.c | 124 > ++ drivers/media/video/ov9640.h | > 4 +- > 2 files changed

Re: [RFC] [PATCH 3/6] SoC Camera: add driver for OV6650 sensor

2010-08-22 Thread Marek Vasut
Dne Ne 22. srpna 2010 22:30:10 Guennadi Liakhovetski napsal(a): > On Sun, 22 Aug 2010, Janusz Krzysztofik wrote: > > Hi Guennadi, > > Thanks for your review time. > > > > Sunday 22 August 2010 18:40:13 Guennadi Liakhovetski wrote: > > > On Sun, 18 Jul 2010, Janusz Krzysztofik wrote: > > > > This p

Re: V4L2: Add a v4l2-subdev (soc-camera) driver for OmniVision OV9640 sensor

2009-09-15 Thread Marek Vasut
Dne Út 15. září 2009 21:55:32 Guennadi Liakhovetski napsal(a): > On Tue, 15 Sep 2009, Marek Vasut wrote: > > Just briefly skimmed over it. Ok then, that diff seems fine. I assume the > > imagebus will fix the rgb issues anyway. > > Sorry, have to ask to make quite sure -

Re: V4L2: Add a v4l2-subdev (soc-camera) driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Po 14. září 2009 23:21:33 Guennadi Liakhovetski napsal(a): > On Mon, 14 Sep 2009, Marek Vasut wrote: > > Dne Po 14. září 2009 22:30:41 Guennadi Liakhovetski napsal(a): > > > On Mon, 14 Sep 2009, Marek Vasut wrote: > > > > Dne Po 14. září 2009 21:29:26

Re: V4L2: Add a v4l2-subdev (soc-camera) driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Po 14. září 2009 22:30:41 Guennadi Liakhovetski napsal(a): > On Mon, 14 Sep 2009, Marek Vasut wrote: > > Dne Po 14. září 2009 21:29:26 Guennadi Liakhovetski napsal(a): > > > From: Marek Vasut > > > > > > Signed-off-by: Marek Vasut > &

Re: V4L2: Add a v4l2-subdev (soc-camera) driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Po 14. září 2009 21:29:26 Guennadi Liakhovetski napsal(a): > From: Marek Vasut > > Signed-off-by: Marek Vasut > Signed-off-by: Guennadi Liakhovetski > --- > > Marek, please confirm, that this version is ok. I'll push it upstream for > 2.6.32 then. No, it&

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Po 14. září 2009 16:45:50 Guennadi Liakhovetski napsal(a): > Ok, you were faster than I:-) If you agree, I can just remove those two > RGB formats myself, changing your comment to a TODO, We can #ifdef them so others dont have to re-add them by hand if they want to try fixing those. > and mo

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Po 14. září 2009 16:35:24 Marek Vasut napsal(a): > Dne Ne 13. září 2009 21:13:32 Guennadi Liakhovetski napsal(a): > > On Sun, 13 Sep 2009, Marek Vasut wrote: > > > Dne Pá 11. září 2009 23:51:44 Guennadi Liakhovetski napsal(a): > > > > Ok, a couple more

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Ne 13. září 2009 21:13:32 Guennadi Liakhovetski napsal(a): > On Sun, 13 Sep 2009, Marek Vasut wrote: > > Dne Pá 11. září 2009 23:51:44 Guennadi Liakhovetski napsal(a): > > > Ok, a couple more simple questions / remarks, In principle, there's > > > just one p

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Pá 11. září 2009 23:51:44 Guennadi Liakhovetski napsal(a): > On Fri, 4 Sep 2009, Marek Vasut wrote: > > Dne Po 24. srpna 2009 20:06:29 Guennadi Liakhovetski napsal(a): > > > Hi Marek > > > > > > On Sat, 22 Aug 2009, Marek Vasut wrote: > > > > F

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-13 Thread Marek Vasut
Dne Pá 11. září 2009 23:51:44 Guennadi Liakhovetski napsal(a): > On Fri, 4 Sep 2009, Marek Vasut wrote: > > Dne Po 24. srpna 2009 20:06:29 Guennadi Liakhovetski napsal(a): > > > Hi Marek > > > > > > On Sat, 22 Aug 2009, Marek Vasut wrote: > > > > F

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-07 Thread Marek Vasut
Dne Po 7. září 2009 12:21:50 Robert Jarzmik napsal(a): > Marek Vasut writes: > > How's it supposed to get BGR555 if the pxa-camera doesnt support that ? > > Will the v4l2 layer convert it or something ? > > In pxa_camera.c, function pxa_camera_get_forma

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-07 Thread Marek Vasut
Dne Po 7. září 2009 08:22:22 Guennadi Liakhovetski napsal(a): > On Mon, 7 Sep 2009, Marek Vasut wrote: > > Dne Ne 6. září 2009 20:15:17 Guennadi Liakhovetski napsal(a): > > > On Sun, 6 Sep 2009, Marek Vasut wrote: > > > > Dne Ne 6. září 2009 18:52:55

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-06 Thread Marek Vasut
Dne Ne 6. září 2009 20:15:17 Guennadi Liakhovetski napsal(a): > On Sun, 6 Sep 2009, Marek Vasut wrote: > > Dne Ne 6. září 2009 18:52:55 Guennadi Liakhovetski napsal(a): > > > On Sun, 6 Sep 2009, Marek Vasut wrote: > > > > Ah damn, I see what you mean. What t

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-06 Thread Marek Vasut
Dne Ne 6. září 2009 18:52:55 Guennadi Liakhovetski napsal(a): > On Sun, 6 Sep 2009, Marek Vasut wrote: > > Ah damn, I see what you mean. What the camera does is it swaps the RED > > and BLUE channel: > > 15 14 13 12 11 10 09 08 07 06 05 04 03 02 01 00 > >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Marek Vasut
Dne Ne 6. září 2009 00:05:14 Guennadi Liakhovetski napsal(a): > On Sat, 5 Sep 2009, Marek Vasut wrote: > > Dne So 5. září 2009 22:19:42 Guennadi Liakhovetski napsal(a): > > > On Sat, 5 Sep 2009, Marek Vasut wrote: > > > > Dne So 5. září 2009 10:55:55

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Marek Vasut
Dne So 5. září 2009 22:19:42 Guennadi Liakhovetski napsal(a): > On Sat, 5 Sep 2009, Marek Vasut wrote: > > Dne So 5. září 2009 10:55:55 Guennadi Liakhovetski napsal(a): > > > On Sat, 5 Sep 2009, Marek Vasut wrote: > > > > > > > drivers/media/video/pxa_came

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Marek Vasut
Dne So 5. září 2009 10:55:55 Guennadi Liakhovetski napsal(a): > On Sat, 5 Sep 2009, Marek Vasut wrote: > > > > > drivers/media/video/pxa_camera.c |4 > > > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > > > >

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-09-05 Thread Marek Vasut
Dne Po 3. srpna 2009 14:31:12 Guennadi Liakhovetski napsal(a): > On Mon, 3 Aug 2009, Eric Miao wrote: > > Marek Vasut wrote: > > > Hi! > > > > > > Eric, would you mind applying ? > > > > > > From 4dcbff010e996f4c6e5761b3c19f5d863ab51b39 Mon Se

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-04 Thread Marek Vasut
Dne Po 24. srpna 2009 20:06:29 Guennadi Liakhovetski napsal(a): > Hi Marek > > On Sat, 22 Aug 2009, Marek Vasut wrote: > > From 479aafc9a6540efec8a691a84aff166eb0218a72 Mon Sep 17 00:00:00 2001 > > From: Marek Vasut > > Date: Sat, 22 Aug 2009 05:14:23 +0200 > > Su

[PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-08-21 Thread Marek Vasut
>From 479aafc9a6540efec8a691a84aff166eb0218a72 Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Sat, 22 Aug 2009 05:14:23 +0200 Subject: [PATCH 2/3] Add driver for OmniVision OV9640 sensor Signed-off-by: Marek Vasut --- drivers/media/video/Kconfig |6 + drivers/media/video/Makef

[PATCH 1/3] Add RGB555X and RGB565X formats to pxa-camera

2009-08-21 Thread Marek Vasut
>From 287b146839e3f96b34336f40e1ab7b154cd58a64 Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Sat, 22 Aug 2009 05:13:22 +0200 Subject: [PATCH 1/3] Add RGB555X and RGB565X formats to pxa-camera Those formats are requiered on widely used OmniVision OV96xx cameras. Those formats are nothing m

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

2009-08-03 Thread Marek Vasut
Dne Po 3. srpna 2009 14:31:12 Guennadi Liakhovetski napsal(a): > On Mon, 3 Aug 2009, Eric Miao wrote: > > Marek Vasut wrote: > > > Hi! > > > > > > Eric, would you mind applying ? > > > > > > From 4dcbff010e996f4c6e5761b3c19f5d863ab51b39 Mon Se