[PATCH] media: fix build issues with vb2-trace

reference to `__tracepoint_vb2_qbuf' drivers/media/common/videobuf2/videobuf2-core.o:(__jump_table+0x58): undefined reference to `__tracepoint_vb2_dqbuf' Reported-by: kbuild test robot <fengguang...@intel.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- d

[PATCH] ov13858: fix endiannes warnings

ferent base types): => 1071:27 Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/ov13858.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c index 1f260d346a29..d415

[PATCH] tda1997x: get rid of an unused var

1 warning regressions: + drivers/media/i2c/tda1997x.c: warning: variable 'last_irq_status' set but not used [-Wunused-but-set-variable]: => 1421:17 Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/tda1997x.c | 4 ++-- 1 file changed, 2 inserti

Re: [bug report] V4L/DVB (3420): Added iocls to configure VBI on tvp5150

Em Mon, 19 Feb 2018 17:27:52 +0300 Dan Carpenter <dan.carpen...@oracle.com> escreveu: > [ This is obviously ancient code. It's probably fine. I've just been > going through all array overflow warnings recently. - dan ] > > Hello Mauro Carvalho Chehab, > > The patc

Re: [PATCH v4 16/18] scripts: kernel-doc: improve nested logic to handle multiple identifiers

Em Wed, 14 Feb 2018 20:20:21 +0200 Jani Nikula <jani.nik...@linux.intel.com> escreveu: > On Wed, 14 Feb 2018, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > > There is a simple fix, though. Make inline comments to accept a dot: > > > > diff --git a/sc

Re: [PATCHv2 4/9] staging: atomisp: i2c: Disable non-preview configurations

Em Fri, 16 Feb 2018 12:12:20 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Wed, Feb 14, 2018 at 02:20:50PM -0200, Mauro Carvalho Chehab wrote: > > Em Mon, 22 Jan 2018 13:31:20 +0100 > > Hans Verkuil <hverk...@xs4all.nl> escreveu: > >

Re: [PATCHv2 3/9] staging: atomisp: Kill subdev s_parm abuse

Em Fri, 16 Feb 2018 11:04:36 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > On Wed, Feb 14, 2018 at 02:14:30PM -0200, Mauro Carvalho Chehab wrote: > > Sakari, > > > > Em Mon, 22 Jan 2018 13:31:19 +0100 > > Hans Verkuil <hverk...@xs4all.nl> es

Re: [GIT PULL FOR v4.17] rc changes

Em Wed, 14 Feb 2018 21:32:07 + Sean Young <s...@mess.org> escreveu: > Hi Mauro, > > On Wed, Feb 14, 2018 at 04:44:48PM -0200, Mauro Carvalho Chehab wrote: > > Hi Sean, > > > > Em Mon, 12 Feb 2018 20:03:18 + > > Sean Young <s...

Re: [GIT PULL FOR v4.17] rc changes

+ > Subject: media: rc: unnecessary use of do_div > Cc: Linux Media Mailing List <linux-media@vger.kernel.org>, > Mauro Carvalho Chehab <mche...@infradead.org> > > No need to use do_div() when the remainder is thrown away. That's not true at all! We need do_div()

Re: [GIT PULL FOR v4.17] rc changes

Hi Sean, Em Mon, 12 Feb 2018 20:03:18 + Sean Young escreveu: > Hi Mauro, > > Just very minor changes this time (other stuff is not ready yet). I would > really appreciate if you could cast an extra critical eye on the commit > "no need to check for transitions", just to be

Re: [PATCH 2/7] include/(uapi/)media: add SPDX license info

Em Wed, 7 Feb 2018 15:39:34 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > Replace the old license information with the corresponding SPDX > license for those headers that I authored. > > Signed-off-by: Hans Verkuil ...

Re: [PATCH v4 16/18] scripts: kernel-doc: improve nested logic to handle multiple identifiers

Em Wed, 14 Feb 2018 18:07:03 +0200 Jani Nikula <jani.nik...@linux.intel.com> escreveu: > On Mon, 18 Dec 2017, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > > It is possible to use nested structs like: > > > > struct { > > struct { > &g

Re: [PATCHv2 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

Em Wed, 14 Feb 2018 18:16:55 +0100 Hans Verkuil <hverk...@xs4all.nl> escreveu: > On 14/02/18 18:02, Mauro Carvalho Chehab wrote: > > Em Wed, 14 Feb 2018 17:34:17 +0100 > > Hans Verkuil <hverk...@xs4all.nl> escreveu: > > > >> On 14/02/18 17:03, Mauro

Re: [PATCHv2 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

Em Wed, 14 Feb 2018 17:34:17 +0100 Hans Verkuil <hverk...@xs4all.nl> escreveu: > On 14/02/18 17:03, Mauro Carvalho Chehab wrote: > > Em Mon, 22 Jan 2018 13:31:18 +0100 > > Hans Verkuil <hverk...@xs4all.nl> escreveu: > > > >> From: Hans Verkuil <ha

Re: [PATCHv2 1/9] v4l2-common: create v4l2_g/s_parm_cap helpers

Em Wed, 14 Feb 2018 17:23:51 +0100 Hans Verkuil <hverk...@xs4all.nl> escreveu: > On 14/02/18 16:50, Mauro Carvalho Chehab wrote: > > Em Mon, 22 Jan 2018 13:31:17 +0100 > > Hans Verkuil <hverk...@xs4all.nl> escreveu: > > > >> From: Hans Verkuil <han

Re: [PATCHv2 4/9] staging: atomisp: i2c: Disable non-preview configurations

Em Mon, 22 Jan 2018 13:31:20 +0100 Hans Verkuil escreveu: > From: Sakari Ailus > > Disable configurations for non-preview modes until configuration selection > is improved. Again, a poor description. It just repeats the subject. A good

Re: [PATCHv2 3/9] staging: atomisp: Kill subdev s_parm abuse

Sakari, Em Mon, 22 Jan 2018 13:31:19 +0100 Hans Verkuil escreveu: > From: Sakari Ailus > > Remove sensor driver's interface that made use of use case specific > knowledge of platform capabilities. Could you better describe it? What s_param

Re: [PATCHv2 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

Em Mon, 22 Jan 2018 13:31:18 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > Convert all g/s_parm calls to g/s_frame_interval. This allows us > to remove the g/s_parm ops since those are a duplicate of > g/s_frame_interval. > > Signed-off-by:

Re: [PATCHv2 1/9] v4l2-common: create v4l2_g/s_parm_cap helpers

Em Mon, 22 Jan 2018 13:31:17 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > Create helpers to handle VIDIOC_G/S_PARM by querying the > g/s_frame_interval v4l2_subdev ops. > > Signed-off-by: Hans Verkuil > --- >

[PATCH] media: ov7740: return error code at ov7740_get_register

If v4l2_subdev_core_ops.g_register fails, it should be returning an error code to userspace, instead of zero. Fixes: drivers/media/i2c/ov7740.c: warning: variable 'ret' set but not used [-Wunused-but-set-variable]: => 276:6 Signed-off-by: Mauro Carvalho Chehab <mch

[PATCH v2 4/4] media: dvb: update buffer mmaped flags and frame counter

Now that we have support for a buffer counter and for error flags, update them at DMX_DQBUF. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-core/dmxdev.c| 24 +--- drivers/media/dvb-core/dvb_demux.c

[PATCH v2 0/4] Improve DVB memory mapped API

org/mchehab/experimental-v4l-utils.git/log/?h=dvb-mmap-v2 Please notice that the API is experimental, and may still change until we release the final version of Kernel 4.16. Have fun, Mauro Mauro Carvalho Chehab (4): media: dmxdev: fix error code for invalid ioctls media: dmxdev: Fix the lo

[PATCH v2 2/4] media: dmxdev: Fix the logic that enables DMA mmap support

Some conditions required for DVB mmap support to work are reversed. Also, the logic is not too clear. So, improve the logic, making it easier to be handled. PS.: I'm pretty sure that I fixed it while testing, but, somehow, the change got lost. Signed-off-by: Mauro Carvalho Chehab <mche..

[PATCH v2 1/4] media: dmxdev: fix error code for invalid ioctls

Returning -EINVAL when an ioctl is not implemented is a very bad idea, as it is hard to distinguish from other error contitions that an ioctl could lead. Replace it by its right error code: -ENOTTY. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dv

[PATCH v2 3/4] media: dvb: add continuity error indicators for memory mapped buffers

While userspace can detect discontinuity errors, it is useful to also let Kernelspace reporting discontinuity, as it can help to identify if the data loss happened either at Kernel or userspace side. Update documentation accordingly. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.

[PATCH] media: m88ds3103: don't call a non-initalized function

while testing DVB MMAP patches on Raspberry Pi 3 with DVBSky S960CI. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/m88ds3103.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/d

[PATCH 1/3] media: dvb: add continuity error indicators for memory mapped buffers

While userspace can detect discontinuity errors, it is useful to also let Kernelspace reporting discontinuity, as it can help to identify if the data loss happened either at Kernel or userspace side. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- include/uapi/linux/dvb

[PATCH 3/3] media: dmxdev: Fix the logic that enables DMA mmap support

Some conditions required for DVB mmap support to work are reversed. Also, the logic is not too clear. So, improve the logic, making it easier to be handled. PS.: I'm pretty sure that I fixed it while testing, but, somehow, the change got lost. Signed-off-by: Mauro Carvalho Chehab <mche..

[PATCH 2/3] media: dvb: update buffer mmaped flags and frame counter

Now that we have support for a buffer counter and for error flags, update them at DMX_DQBUF. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-core/dmxdev.c| 11 +++-- drivers/media/dvb-core/dvb_demux.c | 95 -- d

[GIT PULL for v4.16-rc1] media updates

after assignment instead of comma media: cx23885: Use semicolon after assignment instead of comma media: MAINTAINERS: add si2165 driver Mauro Carvalho Chehab (105): media: rc: add SPDX identifiers to the code I wrote media: tuners: add SPDX identifiers to the code I wrote

Re: media_device.c question: can this workaround be removed?

Em Mon, 5 Feb 2018 23:48:38 +0200 Sakari Ailus escreveu: > Hi Mauro and Hans, > > Adding pad index to new API is trivial, as your RFC patch pointed. > > > > Changing media-ctl to fully use the new ioctl is not trivial, as it > > was written on a non-portable way, very

Re: Please help test the new v4l-subdev support in v4l2-compliance

Em Mon, 5 Feb 2018 18:01:34 +0100 Hans Verkuil <hverk...@xs4all.nl> escreveu: > On 02/05/2018 05:59 PM, Hans Verkuil wrote: > > On 02/05/2018 05:55 PM, Mauro Carvalho Chehab wrote: > >> Em Mon, 5 Feb 2018 14:37:29 -0200 > >> Mauro Carvalho Chehab <mche...@k

Re: Please help test the new v4l-subdev support in v4l2-compliance

Em Mon, 5 Feb 2018 14:37:29 -0200 Mauro Carvalho Chehab <mche...@kernel.org> escreveu: > Em Mon, 5 Feb 2018 08:21:54 -0800 > Tim Harvey <thar...@gateworks.com> escreveu: > > > Hans, > > > > I'm failing compile (of master 4ee9911) with: > > > >

Re: Please help test the new v4l-subdev support in v4l2-compliance

Em Mon, 5 Feb 2018 08:21:54 -0800 Tim Harvey escreveu: > Hans, > > I'm failing compile (of master 4ee9911) with: > > CXX v4l2_compliance-media-info.o > media-info.cpp: In function ‘media_type media_detect_type(const char*)’: > media-info.cpp:79:39: error: no

Re: media_device.c question: can this workaround be removed?

Em Mon, 5 Feb 2018 16:19:28 +0100 Hans Verkuil escreveu: > On 02/05/2018 03:30 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote: > >> On 02/05/2018 12:59 PM, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> On Mon,

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Em Mon, 5 Feb 2018 14:47:51 +0100 Hans Verkuil <hverk...@xs4all.nl> escreveu: > On 02/05/2018 02:17 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 5 Feb 2018 12:55:21 +0100 > > Hans Verkuil <hverk...@xs4all.nl> escreveu: > > > >> On 02/05/2018 12:15 P

Re: [RFC PATCH] media-device: add index field to media_v2_pad

Em Mon, 5 Feb 2018 13:42:48 +0100 Hans Verkuil <hverk...@xs4all.nl> escreveu: > On 02/05/2018 01:39 PM, Mauro Carvalho Chehab wrote: > > Em Sun, 4 Feb 2018 14:53:31 +0100 > > Hans Verkuil <hverk...@xs4all.nl> escreveu: > > > >> Userspace has no w

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Em Mon, 5 Feb 2018 12:38:29 +0100 Hans Verkuil <hverk...@xs4all.nl> escreveu: > On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote: > > Hi Hans, > > > > Em Sun, 4 Feb 2018 14:06:42 +0100 > > Hans Verkuil <hverk...@xs4all.nl> escreveu: > > > >

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Em Mon, 5 Feb 2018 12:55:21 +0100 Hans Verkuil <hverk...@xs4all.nl> escreveu: > On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote: > > Hi Hans, > > > > Em Sun, 4 Feb 2018 14:06:42 +0100 > > Hans Verkuil <hverk...@xs4all.nl> escreveu: > > > >

Re: [RFC PATCH] media-device: add index field to media_v2_pad

Em Sun, 4 Feb 2018 14:53:31 +0100 Hans Verkuil escreveu: > Userspace has no way of knowing the pad index for the entity that > owns the pad with the MEDIA_IOC_G_TOPOLOGY ioctl. However, various > v4l-subdev ioctls need to pass this as an argument. While I'm OK on adding a

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Em Sun, 04 Feb 2018 15:20:55 +0200 Laurent Pinchart escreveu: > Hi Hans, > > On Sunday, 4 February 2018 15:16:26 EET Hans Verkuil wrote: > > On 02/04/2018 02:13 PM, Laurent Pinchart wrote: > > > On Sunday, 4 February 2018 15:06:42 EET Hans Verkuil wrote: >

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

Hi Hans, Em Sun, 4 Feb 2018 14:06:42 +0100 Hans Verkuil escreveu: > Hi Mauro, > > I'm working on adding proper compliance tests for the MC but I think something > is missing in the G_TOPOLOGY ioctl w.r.t. pads. > > In several v4l-subdev ioctls you need to pass the pad.

Re: [PATCH 2/9] em28xx: Bulk transfer implementation fix

Em Thu, 4 Jan 2018 18:04:12 -0600 Brad Love escreveu: > Set appropriate bulk/ISOC transfer multiplier on capture start. > This sets ISOC transfer to 940 bytes (188 * 5) > This sets bulk transfer to 48128 bytes (188 * 256) > > The above values are maximum allowed

Re: [PATCH 12/12] v4l2-compat-ioctl32.c: refactor, fix security bug in compat ioctl32

Em Fri, 26 Jan 2018 13:43:27 +0100 Hans Verkuil escreveu: > From: Daniel Mentz > > The 32-bit compat v4l2 ioctl is implemented based on its 64-bit > equivalent. It converts 32-bit data structures into its 64-bit > equivalents and needs to provide the

Re: [PATCH 09/12] v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32

Em Mon, 29 Jan 2018 11:47:42 +0200 Sakari Ailus escreveu: > > + compat_caddr_t p; > > + > > if (copy_to_user(>w, >w, sizeof(kp->w)) || > > put_user(kp->field, >field) || > > put_user(kp->chromakey, >chromakey) || > > put_user(kp->clipcount,

Re: [PATCH 08/12] v4l2-compat-ioctl32.c: fix ctrl_is_pointer

Em Sun, 28 Jan 2018 01:18:57 +0200 Sakari Ailus escreveu: > Hi Hans, > ... > > + > > + if (ops->vidioc_query_ext_ctrl) > > + ret = ops->vidioc_query_ext_ctrl(file, fh, ); > > Is there a need for this? > > The only driver implementing vidioc_query_ext_ctrl

Re: dvb usb issues since kernel 4.9

Em Fri, 26 Jan 2018 17:37:39 -0200 Mauro Carvalho Chehab <mche...@s-opensource.com> escreveu: > Em Fri, 26 Jan 2018 12:17:37 -0200 > Mauro Carvalho Chehab <mche...@s-opensource.com> escreveu: > > > Hi Alan, > > > > Em Mon, 8 Jan 2018

[PATCH 2/2] media: dvb_demux: improve debug messages

From: Mauro Carvalho Chehab <mche...@osg.samsung.com> Do some cleanup of debug messages, making them cleaner and easier to be used to analyze what's going on. Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s

[PATCH 1/2] media: dvb_demux: Better handle discontinuity errors

From: Mauro Carvalho Chehab <mche...@osg.samsung.com> When a packet discontinuity happens, it is not just the payload that was lost. The headers are lost too. So, the max size is not 184 but, instead 188. Also, while printing warnings, make a distinction between MPEG-TS indicated discont

Re: dvb usb issues since kernel 4.9

Em Fri, 26 Jan 2018 12:17:37 -0200 Mauro Carvalho Chehab <mche...@s-opensource.com> escreveu: > Hi Alan, > > Em Mon, 8 Jan 2018 14:15:35 -0500 (EST) > Alan Stern <st...@rowland.harvard.edu> escreveu: > > > On Mon, 8 Jan 2018, Linus Torvalds wrote: > >

Re: dvb usb issues since kernel 4.9

Hi Alan, Em Mon, 8 Jan 2018 14:15:35 -0500 (EST) Alan Stern escreveu: > On Mon, 8 Jan 2018, Linus Torvalds wrote: > > > Can somebody tell which softirq it is that dvb/usb cares about? > > I don't know about the DVB part. The USB part is a little difficult to >

Re: [PATCH] v4l2-dev.h: fix symbol collision in media_entity_to_video_device()

Hi Niklas, Em Thu, 25 Jan 2018 01:34:30 +0100 Niklas Söderlund escreveu: > A recent change to the media_entity_to_video_device() macro breaks some > use-cases for the macro due to a symbol collision. Before the change > this worked: > > vdev =

[PATCH] media: cxusb, dib0700: ignore XC2028_I2C_FLUSH

Mauro Carvalho Chehab <mche...@osg.samsung.com> --- drivers/media/usb/dvb-usb/cxusb.c | 2 ++ drivers/media/usb/dvb-usb/dib0700_devices.c | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c index 37dea0adc695..

Re: [GIT PULL for 4.16] CIO2 compiler warning fix

Em Tue, 23 Jan 2018 14:56:01 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > On Tue, Jan 23, 2018 at 10:40:13AM -0200, Mauro Carvalho Chehab wrote: > > Em Wed, 10 Jan 2018 00:35:18 +0200 > > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > > > >

[PATCH] media: dw9714: annotate a __be16 integer value

As warned: drivers/media/i2c/dw9714.c: warning: incorrect type in initializer (different base types): => 64:19 Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/dw9714.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [GIT PULL for 4.16] CIO2 compiler warning fix

Em Wed, 10 Jan 2018 00:35:18 +0200 Sakari Ailus escreveu: > Hi Mauro, > > Here's compile warning fix for the Intel IPU3 CIO2 driver from Arnd. > > Please pull. > > > The following changes since commit e3ee691dbf24096ea51b3200946b11d68ce75361: > > media: ov5640: add

Re: dvb usb issues since kernel 4.9

Em Sat, 13 Jan 2018 07:09:20 -0200 Mauro Carvalho Chehab <mche...@s-opensource.com> escreveu: > Em Fri, 12 Jan 2018 13:48:46 -0800 > Eric Dumazet <eric.duma...@gmail.com> escreveu: > > > On Fri, 2018-01-12 at 19:13 -0200, Mauro Carvalho Chehab wrote: > > >

Re: dvb usb issues since kernel 4.9

Em Fri, 12 Jan 2018 13:48:46 -0800 Eric Dumazet <eric.duma...@gmail.com> escreveu: > On Fri, 2018-01-12 at 19:13 -0200, Mauro Carvalho Chehab wrote: > > > > > > The .config file used to build the Kernel is at: > > https://pastebin.com/wpZghann > > &g

Re: dvb usb issues since kernel 4.9

Em Tue, 9 Jan 2018 09:48:47 -0800 Linus Torvalds escreveu: > On Tue, Jan 9, 2018 at 9:27 AM, Eric Dumazet wrote: > > > > So yes, commit 4cd13c21b207 ("softirq: Let ksoftirqd do its job") has > > shown up multiple times in various 'regressions'

[PATCH] media: ts2020: avoid integer overflows on 32 bit machines

Before this patch, when compiled for arm32, the signal strength were reported as: Lock (0x1f) Signal= 4294908.66dBm C/N= 12.79dB Because of a 32 bit integer overflow. After it, it is properly reported as: Lock (0x1f) Signal= -58.64dBm C/N= 12.79dB Signed-off-by: Mauro Carvalho

Re: dvb usb issues since kernel 4.9

Em Mon, 8 Jan 2018 11:51:04 -0800 Linus Torvalds escreveu: > On Mon, Jan 8, 2018 at 11:15 AM, Alan Stern wrote: > > > > Both dwc2_hsotg and ehci-hcd use the tasklets embedded in the > > giveback_urb_bh member of struct usb_hcd. See

Re: [ANN] Meeting notes on naming meeting 2017-10-11/13

Em Mon, 8 Jan 2018 15:47:21 +0200 Sakari Ailus escreveu: > Hi folks, > > Here are the meeting notes on the IRC meeting that took place 11th and 13th > last October. The brief summary is below, the full log can be found here: > >

Re: [PATCH 02/11] media: videobuf2: Add new uAPI for DVB streaming I/O

Em Mon, 8 Jan 2018 15:26:50 +0100 Hans Verkuil escreveu: > A quick follow-up: > > On 01/08/2018 02:54 PM, Hans Verkuil wrote: > >> +/* > >> + * Videobuf operations > >> + */ > >> +int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int > >> nonblocking) > >> +{ > >>

Re: [PATCH 02/11] media: videobuf2: Add new uAPI for DVB streaming I/O

ut the '[PATCH v3] media: videobuf2-core: don't go > out > of the buffer range' patch). > > On 12/21/2017 05:18 PM, Mauro Carvalho Chehab wrote: > > From: Satendra Singh Thakur <satendr...@samsung.com> > > > > Adds a new uAPI for DVB to use streaming I/O which i

Re: [PATCH v3] media: videobuf2-core: don't go out of the buffer range

Em Mon, 8 Jan 2018 12:34:15 +0100 Hans Verkuil <hverk...@xs4all.nl> escreveu: > Hi Mauro, > > On 12/28/2017 03:16 PM, Mauro Carvalho Chehab wrote: > > Currently, there's no check if an invalid buffer range > > is passed. However, while testing DVB me

Re: dvb usb issues since kernel 4.9

Em Mon, 8 Jan 2018 12:59:10 +0100 Jesper Dangaard Brouer <jbro...@redhat.com> escreveu: > On Mon, 8 Jan 2018 08:02:00 -0200 > Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > > > Hi Linus, > > > > Em Sun, 7 Jan 2018 13:23:39 -0800 > >

Re: dvb usb issues since kernel 4.9

Hi Linus, Em Sun, 7 Jan 2018 13:23:39 -0800 Linus Torvalds <torva...@linux-foundation.org> escreveu: > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > <mche...@s-opensource.com> wrote: > > > > Em Sat, 6 Jan 2018 16:04:16 +0100 > > "Josef Griebic

Re: dvb usb issues since kernel 4.9

Em Sun, 7 Jan 2018 10:41:37 -0500 (EST) Alan Stern <st...@rowland.harvard.edu> escreveu: > On Sun, 7 Jan 2018, Mauro Carvalho Chehab wrote: > > > > > It seems that the original patch were designed to solve some IRQ issues > > > > with network cards wit

Re: dvb usb issues since kernel 4.9

Em Sat, 6 Jan 2018 16:44:20 -0500 (EST) Alan Stern <st...@rowland.harvard.edu> escreveu: > On Sat, 6 Jan 2018, Mauro Carvalho Chehab wrote: > > > Hi Josef, > > > > Em Sat, 6 Jan 2018 16:04:16 +0100 > > "Josef Griebichler" <gr

Re: dvb usb issues since kernel 4.9

/Greg/Eric/David: Any ideas about how to fix it without causing regressions to network? Regards, Mauro > Gesendet: Sonntag, 17. Dezember 2017 um 14:27 Uhr > Von: "Mauro Carvalho Chehab" <mche...@s-opensource.com> > An: "Sean Young" <s...@mess.org> > Cc

[PATCH 1/2] media: staging: use tabs instead of spaces at Kconfig and davinci

Even on text and Kconfigs, what we do on media is to use tabs for indentation. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/staging/media/Kconfig | 14 +++--- drivers/staging/media/davinci_vpfe/TODO | 10 +- 2 files changed, 12 inse

Re: [PATCH] media: don't use whitespaces for indentation

Em Thu, 4 Jan 2018 15:08:52 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Thu, Jan 04, 2018 at 07:27:48AM -0500, Mauro Carvalho Chehab wrote: > > On several places, whitespaces are being used for indentation, > > or even at the end of

[PATCH 1/2] media: fix usage of whitespaces and on indentation

On several places, whitespaces are being used for indentation, or even at the end of the line. Fix them. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/Kconfig| 8 ++--- drivers/media/dvb-core/Makefile

[PATCH 0/2] Cleanup bad whitespaces along media tree

lt;\t\t>g || s<\t {1,7}\t> <\t\t>g ) {} } $_ = "+$_" if ($diffmode); print OUT $_; $changed = 1 if ($prev ne $_); } close IN; close OUT; rename "$file.new", $file;

[PATCH] media: don't use whitespaces for indentation

On several places, whitespaces are being used for indentation, or even at the end of the line. Fix them, by running a script that fix it inside drivers/media and include/media. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/K

Re: [PATCH] media: don't drop front-end reference count for ->detach

Em Tue, 2 Jan 2018 10:48:54 +0100 Arnd Bergmann escreveu: > A bugfix introduce a link failure in configurations without CONFIG_MODULES: > > In file included from drivers/media/usb/dvb-usb/pctv452e.c:20:0: > drivers/media/usb/dvb-usb/pctv452e.c: In function

Re: [PATCH v3 01/34] clk_ops: change round_rate() to return unsigned long

mplementations > that do not return an error code of < 0 will be left as-is. > > drivers/media/platform/omap3isp/isp.c | 4 ++-- Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH 0/2] A few IPU3 CIO2 fixes

Em Fri, 29 Dec 2017 14:59:12 +0200 Sakari Ailus escreveu: > Hi Yong and Mauro, > > The two patches are addressing a few matters Mauro pointed out whilst > handling the CIO2 driver pull request. > > Yong: could you review especially the latter patch? I'm applying

[PATCH 4/4] media: dmx.h documentation: fix a warning

/devel/v4l/patchwork/Documentation/output/dmx.h.rst:6: WARNING: undefined label: dmx_dqbuf (if the link has no caption the label must precede a section header) This is defined together with DMX_QBUF. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- Documentation

[PATCH 2/4] media: dvb_vb2: get rid of DVB_BUF_TYPE_OUTPUT

This is currently unused. So, get rid of it. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- include/media/dvb_vb2.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/media/dvb_vb2.h b/include/media/dvb_vb2.h index 7a529844c5e1..ef4a802f7435 100644 --- a/i

[PATCH 1/4] media: dvb_vb2: use strlcpy instead of strncpy

Instead of using strncpy(), use strlcpy(), in order to ensure that a \0 char will be added at the end of the string. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-core/dvb_vb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 3/4] media: dvb kAPI docs: document dvb_vb2.h

Document the data structures and functions inside this kAPI header. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- Documentation/media/kapi/dtv-common.rst | 5 + include/media/dmxdev.h | 2 + include/media/dvb_vb2.h

[PATCH 0/4] Some patches for DVB VB2 kAPI documentation

Document the new dvb-vb2 kAPI bits, in order to keep it in sync with implementation, and shut up two new documentation warnings. Mauro Carvalho Chehab (4): media: dvb_vb2: use strlcpy instead of strncpy media: dvb_vb2: get rid of DVB_BUF_TYPE_OUTPUT media: dvb kAPI docs: document dvb_vb2.h

[PATCH 2/2] media: don't include drivers/media/i2c at cflags

Most of the I2C headers got moved a long time ago to include/media/i2c. Stop including them at the patch. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/cx25840/Makefile| 2 -- drivers/media/pci/bt8xx/Makefile | 1 - drivers

[PATCH 4/5] media: vb2: add pr_fmt() macro

Simplify the pr_foo() macros by adding a pr_fmt() macro. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/videobuf/videobuf2-core.c | 30 ++ 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/media/

[PATCH 5/5] media: vb2: add a new warning about pending buffers

with debug instrumentation inside the drivers can make easier to identify where the problem is. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/videobuf/videobuf2-core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/

[PATCH 2/5] media: vb2: Fix a bug about unnecessary calls to queue cancel and free

>memory to zero at vb2_core_queue_init] Signed-off-by: Satendra Singh Thakur <satendr...@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/videobuf/videobuf2-core.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/m

[PATCH 1/5] media: vb2: don't go out of the buffer range

CR2: 888b773c0890 So, add a sanity check in order to prevent going past array. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/videobuf/videobuf2-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/common/videobuf/videobuf2-core.

[PATCH 0/5] some VB2 bug fixes and improvements

happening when VB2 prints a stack dump. Mauro Carvalho Chehab (3): media: vb2: don't go out of the buffer range media: vb2: add pr_fmt() macro media: vb2: add a new warning about pending buffers Sakari Ailus (1): media: vb2: Enforce VB2_MAX_FRAME in vb2_core_reqbufs better Satendra Singh

[PATCH 3/5] media: vb2: Enforce VB2_MAX_FRAME in vb2_core_reqbufs better

E here. Also add a warning of the condition. Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/videobuf/videobuf2-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) di

[PATCH] media: dvb-core: make DVB mmap API optional

This API is still experimental. Make it optional, allowing to compile the code without it. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/Kconfig| 12 drivers/media/dvb-core/Makefile | 3 +- drivers/media/dvb-core/dmxdev.c

[PATCH v3] media: videobuf2-core: don't go out of the buffer range

CR2: 888b773c0890 So, add a sanity check in order to prevent going past array. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/videobuf/videobuf2-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/common/videobuf/videobuf2-core.

[PATCH 1/2] media: videobuf2-core: don't go out of the buffer range

CR2: 888b773c0890 So, add a sanity check in order to prevent going past array. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/videobuf/videobuf2-core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/common/videobuf/videobu

[PATCH 2/2] media: dvb_vb2: limit reqbufs size to a sane value

It is not a good idea to let users to request a very high buffer size. So, add an upper limit. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-core/dvb_vb2.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/dvb-core/dvb_v

Re: [PATCH] videobuf2-core: don't go out of the buffer range

Em Thu, 28 Dec 2017 14:19:56 +0200 Sakari Ailus <sakari.ai...@linux.intel.com> escreveu: > Hi Mauro, > > Thanks for the patch. > > On Thu, Dec 28, 2017 at 10:02:33AM -0200, Mauro Carvalho Chehab wrote: > > Currently, there's no check if an invalid buffer range &g

[PATCH] videobuf2-core: don't go out of the buffer range

CR2: 888b773c0890 So, add a sanity check in order to prevent going past array. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/videobuf/videobuf2-core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/common/videobuf/videobu

Re: [PATCH] [media] dvb-frontends: remove self assignments

Detected with Coccinelle. Signed-off-by: Colin Ian King <colin.k...@canonical.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > --- > drivers/media/dvb-frontends/drxd_hard.c| 3 --- > drivers/media/dvb-frontends/tda18271c2dd.c

Re: [PATCH 05/11] media: dvb_vb2: fix a warning about streamoff logic

Em Thu, 21 Dec 2017 14:18:04 -0200 Mauro Carvalho Chehab <mche...@s-opensource.com> escreveu: > The streamoff logic is causing those warnings: > > WARNING: CPU: 3 PID: 3382 at drivers/media/v4l2-core/videobuf2-core.c:1652 > __vb2_queue_cancel+0x177/0x250 [videobuf2_core]

Re: [PATCH v4 00/18] kernel-doc: add supported to document nested structs

Em Thu, 21 Dec 2017 14:08:43 -0700 Jonathan Corbet <cor...@lwn.net> escreveu: > On Mon, 18 Dec 2017 10:30:01 -0200 > Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > > > This is a rebased version of my patch series that add support for > > nested structs

Re: [PATCH v6 0/6] V4L2 Explicit Synchronization

Em Thu, 21 Dec 2017 16:49:31 -0200 Mauro Carvalho Chehab <mche...@osg.samsung.com> escreveu: > Em Mon, 11 Dec 2017 16:27:35 -0200 > Gustavo Padovan <gust...@padovan.org> escreveu: > > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > Hi

<    5   6   7   8   9   10   11   12   13   14   >