17/2018 02:00 AM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
History:
v5:
- Added a regression fix to allow empty endpoints to CSI (fix for imx6q
Hi Hans,
On 12/6/18 4:32 AM, Hans Verkuil wrote:
On 12/06/18 00:13, Steve Longerbeam wrote:
On 12/5/18 10:50 AM, Hans Verkuil wrote:
On 12/05/2018 02:20 AM, Steve Longerbeam wrote:
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void
On 12/5/18 10:50 AM, Hans Verkuil wrote:
On 12/05/2018 02:20 AM, Steve Longerbeam wrote:
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev)
+{
+ struct mem2mem_priv *priv
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev)
+{
+ struct mem2mem_priv *priv = to_mem2mem_priv(vdev);
+ struct video_device *vfd = priv->vdev.vfd;
+
+
Reviewed-by: Steve Longerbeam
On 11/23/18 4:50 AM, Fabio Estevam wrote:
On a imx6q-wandboard the following warnings are observed:
[4.327794] video-mux 20e.iomuxc-gpr:ipu1_csi0_mux: bad remote port
parent
[4.336118] video-mux 20e.iomuxc-gpr:ipu2_csi1_mux: bad remote port
Hi Fabio,
On 11/22/18 11:17 AM, Fabio Estevam wrote:
Hi Philipp,
On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel wrote:
There are empty endpoint nodes (without remote-endpoint property)
labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device trees
for board DT implementers'
On 11/9/18 6:50 AM, Philipp Zabel wrote:
On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote:
On 11/5/18 7:20 AM, Philipp Zabel wrote:
The CSI subdevice shouldn't have to care about IDMAC line start
address alignment. With compose rectangle support in the capture
driver, it doesn't
On 11/5/18 7:20 AM, Philipp Zabel wrote:
The CSI subdevice shouldn't have to care about IDMAC line start
address alignment. With compose rectangle support in the capture
driver, it doesn't have to anymore.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-capture.c | 9
Hi Philipp,
On 11/5/18 7:20 AM, Philipp Zabel wrote:
Prepare for mbus format being smaller than the written rectangle
due to burst size.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-capture.c | 55 +--
1 file changed, 38 insertions(+), 17
Hi Philipp,
On 11/5/18 7:20 AM, Philipp Zabel wrote:
Allowing to compose captured images into larger memory buffers
will let us lift alignment restrictions on CSI crop width.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 3 +-
Hi Philipp,
Thanks, I've been meaning this too. Comments below.
On 11/5/18 7:03 AM, Philipp Zabel wrote:
While subdevice and video device are in the same pipeline, pass
subdevice events on to userspace via the video device node.
Signed-off-by: Philipp Zabel
---
This would allow to see
Hi Jean-Michel,
We've done some work with another FPD-Link de-serializer (ds90ux940) and
IIRC we had some trouble figuring out how to coax the lanes into LP-11
state. But on the ds90ux940 it can be done by setting bit 7 in the CSI
Enable Port registers (offsets 0x13 and 0x14). But the
(resending as plain text)
On 10/21/18 10:43 AM, Philipp Zabel wrote:
On Fri, Oct 19, 2018 at 01:19:10PM -0700, Steve Longerbeam wrote:
On 10/19/18 2:53 AM, Philipp Zabel wrote:
Hi Tim,
On Thu, 2018-10-18 at 15:53 -0700, Tim Harvey wrote:
[...]
Philipp,
Thanks for submitting this!
I'm
On 10/19/18 2:53 AM, Philipp Zabel wrote:
Hi Tim,
On Thu, 2018-10-18 at 15:53 -0700, Tim Harvey wrote:
[...]
Philipp,
Thanks for submitting this!
I'm hoping this lets us use non-IMX capture devices along with the IMX
media controller entities to so we can use hardware
On 10/18/18 10:56 AM, Tim Harvey wrote:
On Wed, Oct 17, 2018 at 4:37 PM Steve Longerbeam wrote:
On 10/17/18 4:05 PM, Tim Harvey wrote:
On Wed, Oct 17, 2018 at 2:33 PM Steve Longerbeam wrote:
Hi Tim,
On 10/17/18 1:38 PM, Tim Harvey wrote:
On Mon, Jun 4, 2018 at 1:58 AM Krzysztof Hałasa
Awesome, thanks Philipp.
For the whole series:
Acked-by: Steve Longerbeam
Tested-by: Steve Longerbeam
on i.MX6q SabreSD.
On 10/19/18 5:15 AM, Philipp Zabel wrote:
Hi,
this is the fourth version of the i.MX mem2mem scaler series.
An alignment issue with 24-bit RGB formats has been
Hi Philipp,
On 10/12/18 5:29 PM, Steve Longerbeam wrote:
But one last thing. Conversions to and from YV12 are producing images
with wrong colors, it looks like the .uv_swapped boolean needs to be
checked
additionally somewhere. Any ideas?
Sorry, this was my fault. I fixed this in
&quo
On 10/17/18 4:10 AM, Philipp Zabel wrote:
On Fri, 2018-10-12 at 17:33 -0700, Steve Longerbeam wrote:
On 09/18/2018 02:34 AM, Philipp Zabel wrote:
+/*
+ * Tile left edges are required to be aligned to multiples of 8 bytes
+ * by the IDMAC.
+ */
+static inline u32 tile_left_align(const
On 10/17/18 4:05 PM, Tim Harvey wrote:
On Wed, Oct 17, 2018 at 2:33 PM Steve Longerbeam wrote:
Hi Tim,
On 10/17/18 1:38 PM, Tim Harvey wrote:
On Mon, Jun 4, 2018 at 1:58 AM Krzysztof Hałasa wrote:
I've just tested the PAL setup: in currect situation (v4.17 + Steve's
fix-csi-interlaced.2
alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro
Suggested-by: Nicolas Dufresne .
- add macro V4L2_FIELD_IS_INTERLACED().
Steve Longerbeam (12):
media: videodev2.h: Add more field helper macros
gpu: ipu-csi: Swap fields according to input/output field types
gpu: ipu-v3: Add planar
type is
'interlaced', that is a full frame is transmitted, or exists in
memory, as top field lines interlaced with bottom field lines.
Signed-off-by: Steve Longerbeam
---
Changes since v3:
- none
Changes since v2:
- none
Changes since v1:
- add the complement macro V4L2_FIELD_IS_INTERLACED
- remove
On 09/18/2018 02:34 AM, Philipp Zabel wrote:
+/*
+ * Tile left edges are required to be aligned to multiples of 8 bytes
+ * by the IDMAC.
+ */
+static inline u32 tile_left_align(const struct ipu_image_pixfmt *fmt)
+{
+ return fmt->planar ? 8 * fmt->uv_width_dec : 64 / fmt->bpp;
+}
osition
gpu: ipu-v3: image-convert: disable double buffering if necessary
gpu: ipu-v3: image-convert: allow three rows or columns
Steve Longerbeam (1):
gpu: ipu-cpmem: add WARN_ON_ONCE() for unaligned dma buffers
drivers/gpu/ipu-v3/ipu-cpmem.c| 6 +
drivers/gpu/
On 10/04/2018 12:34 PM, Hans Verkuil wrote:
On 10/04/2018 08:53 PM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
History:
v4:
- rebased
.
- fix bug with resetting crop/compose rectangles.
- add a patch that fixes a field order bug in VDIC indirect mode.
- remove alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro
Suggested-by: Nicolas Dufresne .
- add macro V4L2_FIELD_IS_INTERLACED().
Steve Longerbeam (11):
media: videodev2
On 10/04/2018 06:41 AM, Hans Verkuil wrote:
On 10/04/18 01:21, Steve Longerbeam wrote:
Hi Hans,
On 10/01/2018 03:07 AM, Hans Verkuil wrote:
Hi Steve,
On 08/01/2018 09:12 PM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source
Hi Hans,
On 10/01/2018 03:07 AM, Hans Verkuil wrote:
Hi Steve,
On 08/01/2018 09:12 PM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
I reviewed
, or keeping an internal master asd_list, since this is
moved to the notifier's asd_list.
Signed-off-by: Steve Longerbeam
---
Changes since v6:
- none
Changes since v5:
- remove reference to notifier.num_subdevs and call
v4l2_async_notifier_init(). Suggested by Sakari Ailus.
---
drivers/staging
stripped from v4l2-async and v4l2-subdev
docs are updated to reflect the new method of adding asd's to notifiers.
Signed-off-by: Steve Longerbeam
Patches 07-14 (video-mux and the imx patches) are
Reviewed-by: Philipp Zabel
Patches 01-14 are
Tested-by: Philipp Zabel
on i.MX6 with Toshiba
and return 0.
__v4l2_async_notifier_parse_fwnode_endpoints() will then continue
parsing the remaining port endpoints of the device.
Signed-off-by: Steve Longerbeam
Acked-by: Hans Verkuil
---
Changes since v6:
- none
Changes since v5:
- none
Changes since v4:
- none
Changes since v3:
- none
Changes
stripped from v4l2-async and v4l2-subdev
docs are updated to reflect the new method of adding asd's to notifiers.
Signed-off-by: Steve Longerbeam
Patches 07-14 (video-mux and the imx patches) are
Reviewed-by: Philipp Zabel
Patches 01-14 are
Tested-by: Philipp Zabel
on i.MX6 with Toshiba
.
Signed-off-by: Marek Vasut
Cc: Steve Longerbeam
Cc: Philipp Zabel
Steve, Philipp,
I saw there was a discussion about this patch, but no clear answer whether
or not this patch is OK. If it is, then please Ack this patch.
Marking this patch as Obsoleted since I have no seen any activity for a long
Vasut
Cc: Philipp Zabel
Cc: Steve Longerbeam
Same here, I cannot merge with out Acks since I don't know the details
of the imx hardware.
I'm marking this patch as Obsoleted since there has been no activity for a long
time.
Hi Hans, yes that's fine. IIRC this issue has been fixed a different w
-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-utils.c
b/drivers/staging/media/imx/imx-media-utils.c
index 8aa13403b09d..0eaa353d5cb3 100644
--- a/drivers/staging/media
Hi Hughes,
The whole series,
Acked-by: Steve Longerbeam
and
Tested-by: Steve Longerbeam
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
On 09/11/2018 06:48 AM, Hugues Fruchet wrote:
This patch serie fixes some problems around exposure & gain in OV5640 driver.
The 4th patch a
the static register value table
has been sent to the sensor in the ov5640_load_regs() function.
Fixes: 476dec012f4c ("media: ov5640: Add horizontal and vertical totals")
Tested-by: Steve Longerbeam
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
Acked-by: Steve Longerbeam
Tes
MIPI capture often failed and returned all-purple frames.
fixes: f22996db44e2 ("media: ov5640: add support of DVP parallel interface")
Tested-by: Steve Longerbeam
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
Acked-by: Steve Longerbeam
Tested-by: Loic Poulain
on Dragonboard-410c
Hi Sakari,
On 08/27/2018 02:29 AM, Sakari Ailus wrote:
Hello everyone,
I've long thought the V4L2 fwnode framework requires some work (it's buggy
and it does not adequately serve common needs). This set should address in
particular these matters:
- Most devices support a particular media bus
On 08/14/2018 10:38 AM, jacopo mondi wrote:
Hi Steve,
On Tue, Aug 14, 2018 at 09:51:04AM -0700, Steve Longerbeam wrote:
Hi Jacopo,
On 08/14/2018 08:35 AM, jacopo mondi wrote:
Hi Steve,
sorry for resurecting this.
I'm sorry I'm not sur I'm following. Does this mean
Hi Jacopo,
On 08/14/2018 08:35 AM, jacopo mondi wrote:
Hi Steve,
sorry for resurecting this.
I'm sorry I'm not sur I'm following. Does this mean that with that bug
you are referring to up here fixed by my last patch you have capture
working?
No, capture still not working for me on
indirect mode.
- remove alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro
Suggested-by: Nicolas Dufresne .
- add macro V4L2_FIELD_IS_INTERLACED().
Philipp Zabel (1):
gpu: ipu-v3: Allow negative offsets for interlaced scanning
Steve Longerbeam (13):
media: videodev2.h: Add more field
ads and reloads correctly
with no memory leaking of asd objects.
Suggested-by: Sakari Ailus
Signed-off-by: Steve Longerbeam
---
Changes since v5:
- remove reference to notifier.num_subdevs, and call
v4l2_async_notifier_init(). Suggested by Sakari Ailus.
- removed "OF" qualifier when passing fw
On 07/23/2018 12:31 AM, Philipp Zabel wrote:
ipu_image_convert_adjust tries to adjust both input and output image at
the same time, here we just have the format of either input or output
image. Do you suggest to split this function into an input and an output
version?
See b4362162c0
On 07/22/2018 11:30 AM, Steve Longerbeam wrote:
Hi Philipp,
On 07/19/2018 08:30 AM, Philipp Zabel wrote:
Hi,
this is the second version of the i.MX mem2mem scaler series.
Patches 8 and 16 have been modified.
Changes since v1:
- Fix inverted allow_overshoot logic
- Correctly switch
Hi Philipp,
On 07/19/2018 08:30 AM, Philipp Zabel wrote:
Hi,
this is the second version of the i.MX mem2mem scaler series.
Patches 8 and 16 have been modified.
Changes since v1:
- Fix inverted allow_overshoot logic
- Correctly switch horizontal / vertical tile alignment when
On 07/16/2018 07:12 AM, Philipp Zabel wrote:
Hi Steve,
On Thu, 2018-07-05 at 15:09 -0700, Steve Longerbeam wrote:
[...]
[...]
+ halign = 0;
+ break;
+ }
+ if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) {
+ /*
+* The IC bu
On 07/16/2018 01:29 AM, jacopo mondi wrote:
Hi Steve,
thanks for keep testing it
On Sat, Jul 14, 2018 at 01:02:32PM -0700, Steve Longerbeam wrote:
On 07/14/2018 12:41 PM, Steve Longerbeam wrote:
Hi Jacopo,
On 07/14/2018 11:57 AM, Steve Longerbeam wrote:
Hi Jacopo,
Pardon the late
On 07/14/2018 12:41 PM, Steve Longerbeam wrote:
Hi Jacopo,
On 07/14/2018 11:57 AM, Steve Longerbeam wrote:
Hi Jacopo,
Pardon the late reply, see below.
On 07/11/2018 12:21 AM, jacopo mondi wrote:
Hi Steve,
On Tue, Jul 10, 2018 at 02:10:54PM -0700, Steve Longerbeam wrote:
Hi Jacopo
Hi Jacopo,
On 07/14/2018 11:57 AM, Steve Longerbeam wrote:
Hi Jacopo,
Pardon the late reply, see below.
On 07/11/2018 12:21 AM, jacopo mondi wrote:
Hi Steve,
On Tue, Jul 10, 2018 at 02:10:54PM -0700, Steve Longerbeam wrote:
Hi Jacopo,
Sorry to report my testing on SabreSD has same result
Hi Jacopo,
Pardon the late reply, see below.
On 07/11/2018 12:21 AM, jacopo mondi wrote:
Hi Steve,
On Tue, Jul 10, 2018 at 02:10:54PM -0700, Steve Longerbeam wrote:
Hi Jacopo,
Sorry to report my testing on SabreSD has same result
as last time. This series fixes the LP-11 timeout at stream
Hi Jacopo,
Sorry to report my testing on SabreSD has same result
as last time. This series fixes the LP-11 timeout at stream
on but captured images are still blank. I tried the 640x480
mode with UYVY2X8. Here is the pad config:
# media-ctl --get-v4l2 "'ov5640 1-003c':0"
09:33:31AM +0200, jacopo mondi wrote:
Hi Steve,
thanks for testing!
On Mon, Jul 09, 2018 at 02:52:09PM -0700, Steve Longerbeam wrote:
Hi Jacopo,
I tested this patch on the i.MX6Q SabreSD with the OV5640 module.
It fixes the LP-11 timeout at stream on, but the captured images
are completely b
stripped from v4l2-async and v4l2-subdev
docs are updated to reflect the new method of adding asd's to notifiers.
Signed-off-by: Steve Longerbeam
Patches 07-14 (video-mux and the imx patches) are
Reviewed-by: Philipp Zabel
Patches 01-14 are
Tested-by: Philipp Zabel
on i.MX6 with Toshiba
Hi Jacopo,
I tested this patch on the i.MX6Q SabreSD with the OV5640 module.
It fixes the LP-11 timeout at stream on, but the captured images
are completely blank/black.
Steve
On 07/06/2018 04:00 AM, Jacopo Mondi wrote:
From: Jacopo Mondi
Rework the MIPI interface startup sequence with the
Hi Philipp,
On 06/22/2018 08:52 AM, Philipp Zabel wrote:
Add a single imx-media mem2mem video device that uses the IPU IC PP
(image converter post processing) task for scaling and colorspace
conversion.
On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used.
The hardware only
Hi Philipp,
Thanks for this great patchset! Finally we have improved seams
with tiled conversions, and relaxed width alignment requirements.
Unfortunately this patchset isn't working correctly yet. It breaks tiled
conversions with rotation.
Trying the following conversion:
input: 720x480,
x
CID base the next available range at 0x10b0.
Signed-off-by: Steve Longerbeam
---
include/uapi/linux/v4l2-controls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/v4l2-controls.h
b/include/uapi/linux/v4l2-controls.h
index 8d473c9..8a75ad7 100644
--- a/include/
Hello Helmut,
On 06/22/2018 12:51 AM, Helmut Grohne wrote:
Hi,
I found it strange that the macros V4L2_CID_USER_MAX217X_BASE and
V4L2_CID_USER_IMX_BASE have equal value even though each of them state
that they reserved a range. Those reservations look conflicting to me.
Yes, they conflict.
On 06/26/2018 12:45 AM, Sakari Ailus wrote:
On Tue, May 08, 2018 at 08:55:04PM -0700, Steve Longerbeam wrote:
On 05/08/2018 03:28 AM, Sakari Ailus wrote:
Hi Steve,
Again, sorry about the delay. This thread got buried in my inbox. :-(
Please see my reply below.
On Mon, Apr 23, 2018 at 11
On 06/26/2018 12:12 AM, Sakari Ailus wrote:
On Wed, May 09, 2018 at 04:06:32PM -0700, Steve Longerbeam wrote:
On 05/08/2018 03:12 AM, Sakari Ailus wrote:
On Fri, Apr 20, 2018 at 10:12:33AM -0700, Steve Longerbeam wrote:
Hi Sakari,
On 04/20/2018 05:24 AM, Sakari Ailus wrote:
Hi Steve
On 06/20/2018 01:54 AM, Philipp Zabel wrote:
Hi Steve,
On Tue, 2018-06-19 at 18:30 -0700, Steve Longerbeam wrote:
I've found some time to diagnose the behavior of interweave with B/T line
swapping (to support interlaced-bt) with planar formats.
There are a couple problems (one known
Hi Philipp, Krzysztof,
On 06/15/2018 01:33 AM, Krzysztof Hałasa wrote:
Steve Longerbeam writes:
Right, the selection of interweave is moved to the capture devices,
so the following will enable interweave:
v4l2-ctl -dN --set-fmt-video=field=interlaced_tb
and
So the patch to adv7180 needs
Hi Krzysztof,
On 06/14/2018 02:39 AM, Krzysztof Hałasa wrote:
Reporting from the field :-)
The fix-csi-interlaced.3 branch is still a bit off the track I guess:
Yes, it's still a WIP. A couple things are remaining:
- fix interweave with negative offsets for planar pixel formats.
- update
Hi Javier, thanks for the confirmations. I'm working on a
fix for imx-media.
Steve
On 06/12/2018 10:27 AM, Javier Martinez Canillas wrote:
Hi Steve,
On 06/11/2018 11:06 PM, Steve Longerbeam wrote:
[snip]
I've been made aware [1] that recently V4L2_FIELD_ALTERNATE has been
clarified [2
On 06/11/2018 02:19 AM, Philipp Zabel wrote:
Hi Steve,
On Sun, 2018-06-10 at 17:08 -0700, Steve Longerbeam wrote:
Hi Philipp,
On 06/01/2018 06:13 AM, Philipp Zabel wrote:
The IPU also supports interlaced buffers that start with the bottom field.
To achieve this, the the base address EBA
Hi Philipp,
On 06/01/2018 06:13 AM, Philipp Zabel wrote:
The IPU also supports interlaced buffers that start with the bottom field.
To achieve this, the the base address EBA has to be increased by a stride
length and the interlace offset ILO has to be set to the negative stride.
The ADV748x CSI-2 subdevices are HDMI/AFE to MIPI CSI-2 bridges.
Signed-off-by: Steve Longerbeam
Acked-by: Kieran Bingham
---
Changes since v1:
- fix typo in commit message.
---
drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On 06/08/2018 02:39 PM, Kieran Bingham wrote:
Hi Steve,
On 08/06/18 18:43, Steve Longerbeam wrote:
The ADV748x CSI-2 subdevices are HMDI/AFE to MIPI CSI-2 bridges.
Just spotted this :D
s/HMDI/HDMI/
Sigh, sending v2.
Steve
Signed-off-by: Steve Longerbeam
---
drivers/media/i2c
On 06/08/2018 02:37 PM, Kieran Bingham wrote:
Hi Steve,
On 08/06/18 22:34, Steve Longerbeam wrote:
Hi Kieran,
On 06/08/2018 02:29 PM, Kieran Bingham wrote:
Hi Steve,
Thankyou for the patch.
On 08/06/18 18:43, Steve Longerbeam wrote:
The ADV748x CSI-2 subdevices are HMDI/AFE to MIPI
Hi Kieran,
On 06/08/2018 02:29 PM, Kieran Bingham wrote:
Hi Steve,
Thankyou for the patch.
On 08/06/18 18:43, Steve Longerbeam wrote:
The ADV748x CSI-2 subdevices are HMDI/AFE to MIPI CSI-2 bridges.
Reading the documentation for MEDIA_ENT_F_VID_IF_BRIDGE, this seems reasonable.
Out
The ADV748x CSI-2 subdevices are HMDI/AFE to MIPI CSI-2 bridges.
Signed-off-by: Steve Longerbeam
---
drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c
b/drivers/media/i2c/adv748x/adv748x-csi2.c
...
On 06/06/2018 02:05 AM, Philipp Zabel wrote:
Hi Steve,
On Tue, 2018-06-05 at 12:00 -0700, Steve Longerbeam wrote:
I'm probably misunderstanding you, so at the risk of overexplaining:
There is no way we can ever produce a correct interlaced-tb frame in
memory from a seq-bt frame output by the CSI
Hi Philipp,
On 06/05/2018 01:07 AM, Philipp Zabel wrote:
Hi Steve,
On Mon, 2018-06-04 at 17:56 -0700, Steve Longerbeam wrote:
On 06/04/2018 01:27 AM, Philipp Zabel wrote:
On Mon, 2018-06-04 at 07:35 +0200, Krzysztof Hałasa wrote:
Philipp Zabel writes:
This is ok in this patch, but we
On 06/04/2018 01:27 AM, Philipp Zabel wrote:
On Mon, 2018-06-04 at 07:35 +0200, Krzysztof Hałasa wrote:
Philipp Zabel writes:
This is ok in this patch, but we can't use this check in the following
TRY_FMT patch as there is no way to interweave
SEQ_TB -> INTERLACED_BT (because in SEQ_TB
On 06/03/2018 10:25 PM, Krzysztof Hałasa wrote:
Steve Longerbeam writes:
I think we should return to enforcing field order to userspace that
matches field order from the source, which is what I had implemented
previously. I agree with you that we should put off allowing inverting
field
On 06/01/2018 06:44 AM, Philipp Zabel wrote:
On Thu, 2018-05-31 at 17:30 -0700, Steve Longerbeam wrote:
+
+.. code-block:: none
+
+ # Setup links
+ media-ctl -l "'adv7180 3-0021':0 -> 'ipu1_csi0_mux':1[1]"
+ media-ctl -l "'ipu1_csi0_mux':2 -> 'ipu1_csi0':0
On 06/01/2018 06:44 AM, Philipp Zabel wrote:
On Thu, 2018-05-31 at 17:30 -0700, Steve Longerbeam wrote:
Also add an example pipeline for unconverted capture with interweave
on SabreAuto.
Signed-off-by: Steve Longerbeam
---
Documentation/media/v4l-drivers/imx.rst | 51
On 06/01/2018 06:13 AM, Philipp Zabel wrote:
Hi Krzysztof,
On Fri, 2018-06-01 at 12:02 +0200, Krzysztof Hałasa wrote:
Steve Longerbeam writes:
I tend to agree, I've found conflicting info out there regarding
PAL vs. NTSC field order. And I've never liked having to guess
at input analog
On 05/30/2018 11:29 PM, Philipp Zabel wrote:
On Wed, May 30, 2018 at 01:56:34PM -0700, Steve Longerbeam wrote:
On 05/30/2018 11:46 AM, Krzysztof Hałasa wrote:
Steve Longerbeam writes:
but it should be possible for the user to explicitly request the field
order on CSI output (I can make
On 06/01/2018 06:34 AM, Philipp Zabel wrote:
On Thu, 2018-05-31 at 17:30 -0700, Steve Longerbeam wrote:
The logic for setting field type in try_fmt at CSI and PRPENCVF
entities wasn't quite right. The behavior should be:
- No restrictions on field type at sink pads (except ANY, which
On 06/01/2018 06:33 AM, Philipp Zabel wrote:
Hi Steve,
On Thu, 2018-05-31 at 17:30 -0700, Steve Longerbeam wrote:
IDMAC interlaced scan, a.k.a. interweave, should be enabled at the
IDMAC output pads only if the input field type is 'seq-bt' or 'seq-tb',
and the IDMAC output pad field type
On 06/01/2018 06:22 AM, Philipp Zabel wrote:
On Thu, 2018-05-31 at 17:30 -0700, Steve Longerbeam wrote:
The output pad's field type was being passed to ipu_csi_init_interface(),
in order to deal with field type 'alternate' at the sink pad, which
is not understood by ipu_csi_init_interface
When the CSI is receiving from a bt.656 bus, include a check for
field type 'alternate' when determining whether to set CSI clock
mode to CCIR656_INTERLACED or CCIR656_PROGRESSIVE.
Signed-off-by: Steve Longerbeam
---
drivers/gpu/ipu-v3/ipu-csi.c | 3 ++-
1 file changed, 2 insertions(+), 1
translation was backwards, SD NTSC is BT
order, SD PAL is TB.
Move this logic to new functions csi_try_field() and prp_try_field().
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 22 +++--
drivers/staging/media/imx/imx-media-csi.c | 50
If IDMAC interweaving is enabled in a write channel, the channel must
write the odd chroma rows for 4:2:0 formats. Skipping writing the odd
chroma rows produces corrupted captured 4:2:0 images when interweave
is enabled.
Reported-by: Krzysztof Hałasa
Signed-off-by: Steve Longerbeam
---
drivers
Skip writing U/V components to odd rows for YVU420 in addition to
YUV420 and NV12.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-csi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers/staging/media/imx/imx-media
prepare_vdi_in_buffers() to give the VDIC the fields in whatever
order they were received by the video source, and rely on the VDIC to
sort out which is top and which is bottom.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-vdic.c | 12 ++--
1 file changed, 2 insertions
Also add an example pipeline for unconverted capture with interweave
on SabreAuto.
Signed-off-by: Steve Longerbeam
---
Documentation/media/v4l-drivers/imx.rst | 51 -
1 file changed, 37 insertions(+), 14 deletions(-)
diff --git a/Documentation/media/v4l-drivers
().
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-csi.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers/staging/media/imx/imx-media-csi.c
index c878a00..471130a 100644
enables interweave at the IDMAC output pad
for alternate input field type.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 22 ++
drivers/staging/media/imx/imx-media-csi.c | 22 ++
2 files changed, 36 insertions(+), 8 deletions
',
that is a full frame is transmitted, or exists in memory, as top field
lines interlaced with bottom field lines.
Signed-off-by: Steve Longerbeam
---
Changes since v1:
- add the complement macro V4L2_FIELD_IS_INTERLACED
- remove V4L2_FIELD_ALTERNATE from V4L2_FIELD_IS_SEQUENTIAL macro.
- moved
to explicity deal with field type 'alternate'
when setting up the CSI interface for BT.656 busses.
Reported-by: Krzysztof Hałasa
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-csi.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers
Dufresne .
- add macro V4L2_FIELD_IS_INTERLACED().
Steve Longerbeam (10):
media: imx-csi: Pass sink pad field to ipu_csi_init_interface
gpu: ipu-csi: Check for field type alternate
media: videodev2.h: Add macros V4L2_FIELD_IS_{INTERLACED|SEQUENTIAL}
media: imx: interweave only for sequential
On 05/30/2018 11:46 AM, Krzysztof Hałasa wrote:
Steve Longerbeam writes:
but it should be possible for the user to explicitly request the field
order on CSI output (I can make a patch I guess).
If you think that is the correct behavior, I will remove the override
code. I suppose it makes
Hi Krzysztof,
On 05/30/2018 01:53 AM, Krzysztof Hałasa wrote:
Steve Longerbeam writes:
Yes, you'll need to patch adv7180.c to select either
'seq-bt/tb' or 'alternate'. The current version will override
any attempt to set field to anything other than 'interlaced'.
This is in anticipation
Hi Krzysztof,
On 05/29/2018 12:26 AM, Krzysztof Hałasa wrote:
Hi Steve,
Steve Longerbeam writes:
Krzysztof, in the meantime the patches are available in my
media-tree fork, for testing on the Ventana GW5300:
g...@github.com:slongerbeam/mediatree.git, branch 'fix-csi-interlaced'
I assume
On 05/28/2018 12:59 AM, Ian Arkver wrote:
On 28/05/18 08:00, Philipp Zabel wrote:
On Fri, 2018-05-25 at 16:53 -0700, Steve Longerbeam wrote:
Interlaced scan, a.k.a. interweave, should be enabled at the CSI IDMAC
output pad if the input field type is 'alternate' (in addition to field
types
Hi Nicolas,
On 05/25/2018 06:21 PM, Nicolas Dufresne wrote:
Le vendredi 25 mai 2018 à 21:14 -0400, Nicolas Dufresne a écrit :
Le vendredi 25 mai 2018 à 17:19 -0700, Steve Longerbeam a écrit :
On 05/25/2018 05:10 PM, Nicolas Dufresne wrote:
(in text this time, sorry)
Le vendredi 25 mai 2018
On 05/25/2018 05:10 PM, Nicolas Dufresne wrote:
(in text this time, sorry)
Le vendredi 25 mai 2018 à 16:53 -0700, Steve Longerbeam a écrit :
Add a macro that returns true if the given field type is
'sequential',
that is, the data is transmitted, or exists in memory, as all top
field
lines
Add a macro that returns true if the given field type is 'sequential',
that is, the data is transmitted, or exists in memory, as all top field
lines followed by all bottom field lines, or vice-versa.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
include/uapi/linux/video
1 - 100 of 958 matches
Mail list logo
