Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2017-05-30 Thread Shuah Khan
Hi Sailus/Mauro, On 01/26/2017 02:10 AM, Mauro Carvalho Chehab wrote: > Em Wed, 25 Jan 2017 13:02:31 +0200 > Sakari Ailus escreveu: > >> Hi Mauro, >> >> On Tue, Jan 24, 2017 at 08:49:02AM -0200, Mauro Carvalho Chehab wrote: >>> Hi Sakari, >>> >>> Just returned this week

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2017-01-26 Thread Mauro Carvalho Chehab
Em Wed, 25 Jan 2017 13:02:31 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Jan 24, 2017 at 08:49:02AM -0200, Mauro Carvalho Chehab wrote: > > Hi Sakari, > > > > Just returned this week from vacations. I'm reading my long e-mail backlog, > > starting from my main

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2017-01-25 Thread Sakari Ailus
Hi Mauro, On Tue, Jan 24, 2017 at 08:49:02AM -0200, Mauro Carvalho Chehab wrote: > Hi Sakari, > > Just returned this week from vacations. I'm reading my long e-mail backlog, > starting from my main inbox... > > Em Mon, 2 Jan 2017 09:53:49 +0200 > Sakari Ailus escreveu: >

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2017-01-24 Thread Mauro Carvalho Chehab
Hi Sakari, Just returned this week from vacations. I'm reading my long e-mail backlog, starting from my main inbox... Em Mon, 2 Jan 2017 09:53:49 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Dec 19, 2016 at 07:46:55AM -0200, Mauro Carvalho Chehab wrote: > > Em

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2017-01-01 Thread Sakari Ailus
Hi Mauro, On Mon, Dec 19, 2016 at 07:46:55AM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 16 Dec 2016 17:07:23 +0200 > Sakari Ailus escreveu: > > > Hi Hans, > > > > chrdev_open in fs/char_dev.c increases the refcount on open() and > > > decreases it > > > on release().

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-23 Thread Laurent Pinchart
Hi Shuah, On Thursday 15 Dec 2016 09:06:41 Shuah Khan wrote: > On 12/15/2016 08:26 AM, Hans Verkuil wrote: > > On 15/12/16 15:45, Shuah Khan wrote: > >> On 12/15/2016 07:03 AM, Hans Verkuil wrote: > >>> On 15/12/16 13:56, Laurent Pinchart wrote: > On Thursday 15 Dec 2016 13:30:41 Sakari

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-23 Thread Laurent Pinchart
Hi Mauro, On Thursday 15 Dec 2016 15:08:26 Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 16:26:19 +0100 Hans Verkuil escreveu: > >> Should all the entities stick around until all references to media > >> device are gone? If an application has /dev/media open, does that > >> mean all entities

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-23 Thread Laurent Pinchart
Hi Hans, On Thursday 15 Dec 2016 16:26:19 Hans Verkuil wrote: > On 15/12/16 15:45, Shuah Khan wrote: > > On 12/15/2016 07:03 AM, Hans Verkuil wrote: [snip] > >> In my view the main problem is that the media core is bound to a struct > >> device set by the driver that creates the MC. But since

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-23 Thread Laurent Pinchart
Hi Shuah, On Thursday 15 Dec 2016 07:45:29 Shuah Khan wrote: > On 12/15/2016 07:03 AM, Hans Verkuil wrote: > > On 15/12/16 13:56, Laurent Pinchart wrote: > >> On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: > >>> On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho Chehab wrote: >

Re: Media summit in Feb? - Was: Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-22 Thread Mauro Carvalho Chehab
Em Thu, 22 Dec 2016 19:47:15 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Tuesday 20 Dec 2016 23:31:42 Mauro Carvalho Chehab wrote: > > Em Mon, 19 Dec 2016 07:28:29 -0200 Mauro Carvalho Chehab escreveu: > > > Em Fri, 16 Dec 2016 15:45:10 +0100 Hans

Re: Media summit in Feb? - Was: Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-22 Thread Laurent Pinchart
Hi Mauro, On Tuesday 20 Dec 2016 23:31:42 Mauro Carvalho Chehab wrote: > Em Mon, 19 Dec 2016 07:28:29 -0200 Mauro Carvalho Chehab escreveu: > > Em Fri, 16 Dec 2016 15:45:10 +0100 Hans Verkuil escreveu: > >> We really need a whiteboard for this :-( > > > > Well, we could schedule a media summit

Re: Media summit in Feb? - Was: Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-21 Thread Shuah Khan
On Tue, Dec 20, 2016 at 6:31 PM, Mauro Carvalho Chehab wrote: > Em Mon, 19 Dec 2016 07:28:29 -0200 > Mauro Carvalho Chehab escreveu: > >> Em Fri, 16 Dec 2016 15:45:10 +0100 >> Hans Verkuil escreveu: >> >> > We really need a

Re: Media summit in Feb? - Was: Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-20 Thread Mauro Carvalho Chehab
Em Mon, 19 Dec 2016 07:28:29 -0200 Mauro Carvalho Chehab escreveu: > Em Fri, 16 Dec 2016 15:45:10 +0100 > Hans Verkuil escreveu: > > > We really need a whiteboard for this :-( > > Well, we could schedule a media summit together with ELC NA. > >

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-19 Thread Mauro Carvalho Chehab
Em Fri, 16 Dec 2016 17:07:23 +0200 Sakari Ailus escreveu: > Hi Hans, > > chrdev_open in fs/char_dev.c increases the refcount on open() and decreases > > it > > on release(). Thus ensuring that the cdev can never be removed while in an > > ioctl. > > It does, but it does

Media summit in Feb? - Was: Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-19 Thread Mauro Carvalho Chehab
Em Fri, 16 Dec 2016 15:45:10 +0100 Hans Verkuil escreveu: > We really need a whiteboard for this :-( Well, we could schedule a media summit together with ELC NA. ELC will be in Feb, 21-23 in Portland. Comments? Mauro -- To unsubscribe from this list: send the line

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Laurent Pinchart
Hi Shuah, On Thursday 15 Dec 2016 07:56:55 Shuah Khan wrote: > On 12/15/2016 03:39 AM, Laurent Pinchart wrote: > > On Tuesday 13 Dec 2016 15:23:53 Shuah Khan wrote: [snip] > >> Please don't pursue this RFC series that makes mc-core changes until > >> ompa3 driver problems are addressed. There

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Laurent Pinchart
Hi Mauro, On Thursday 15 Dec 2016 12:32:07 Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 15:03:36 +0100 Hans Verkuil escreveu: > > On 15/12/16 13:56, Laurent Pinchart wrote: > >> On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: > >>> On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Laurent Pinchart
On Thursday 15 Dec 2016 13:45:52 Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 15:45:22 +0100 > > Hans Verkuil escreveu: > > On 15/12/16 15:32, Mauro Carvalho Chehab wrote: > > > Em Thu, 15 Dec 2016 15:03:36 +0100 > > > > > > Hans Verkuil escreveu:

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Laurent Pinchart
Hi Hans, On Friday 16 Dec 2016 17:07:23 Sakari Ailus wrote: > On Thu, Dec 15, 2016 at 03:03:36PM +0100, Hans Verkuil wrote: > > On 15/12/16 13:56, Laurent Pinchart wrote: > >> On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: > >>> On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Sakari Ailus
Hi Hans, On Thu, Dec 15, 2016 at 03:03:36PM +0100, Hans Verkuil wrote: > On 15/12/16 13:56, Laurent Pinchart wrote: > >Hi Sakari, > > > >On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: > >>On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho Chehab wrote: > >>>Em Tue, 13 Dec 2016

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Hans Verkuil
On 16/12/16 13:00, Mauro Carvalho Chehab wrote: Em escreveu: On 16/12/16 11:57, Mauro Carvalho Chehab wrote: Em Fri, 16 Dec 2016 11:11:25 +0100 Hans Verkuil escreveu: Would it make sense to enforce that dependency. Can we tie /dev/media usecount to /dev/video etc.

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Mauro Carvalho Chehab
Em escreveu: > On 16/12/16 11:57, Mauro Carvalho Chehab wrote: > > Em Fri, 16 Dec 2016 11:11:25 +0100 > > Hans Verkuil escreveu: > > > >>> Would it make sense to enforce that dependency. Can we tie /dev/media > >>> usecount > >>> to /dev/video etc. usecount? In other

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Hans Verkuil
On 16/12/16 11:57, Mauro Carvalho Chehab wrote: Em Fri, 16 Dec 2016 11:11:25 +0100 Hans Verkuil escreveu: Would it make sense to enforce that dependency. Can we tie /dev/media usecount to /dev/video etc. usecount? In other words: /dev/video is opened, then open

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Mauro Carvalho Chehab
Em Fri, 16 Dec 2016 11:11:25 +0100 Hans Verkuil escreveu: > > Would it make sense to enforce that dependency. Can we tie /dev/media > > usecount > > to /dev/video etc. usecount? In other words: > > > > /dev/video is opened, then open /dev/media. > > When a device node is

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Mauro Carvalho Chehab
Em Fri, 16 Dec 2016 11:03:09 +0100 Hans Verkuil escreveu: > So: > > 1) subdev drivers should disallow unbind > 2) interface entities should call media_device_unregister_entity() when they > are unregistered (if that doesn't already happen) Sounds like a plan to me.

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Hans Verkuil
On 15/12/16 18:51, Shuah Khan wrote: On 12/15/2016 10:25 AM, Mauro Carvalho Chehab wrote: Em Thu, 15 Dec 2016 10:09:53 -0700 Shuah Khan escreveu: On 12/15/2016 09:28 AM, Hans Verkuil wrote: On 15/12/16 17:06, Shuah Khan wrote: I think this will work for

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-16 Thread Hans Verkuil
On 15/12/16 18:09, Shuah Khan wrote: On 12/15/2016 09:28 AM, Hans Verkuil wrote: On 15/12/16 17:06, Shuah Khan wrote: On 12/15/2016 08:26 AM, Hans Verkuil wrote: On 15/12/16 15:45, Shuah Khan wrote: On 12/15/2016 07:03 AM, Hans Verkuil wrote: On 15/12/16 13:56, Laurent Pinchart wrote: Hi

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Shuah Khan
On 12/15/2016 10:25 AM, Mauro Carvalho Chehab wrote: > Em Thu, 15 Dec 2016 10:09:53 -0700 > Shuah Khan escreveu: > >> On 12/15/2016 09:28 AM, Hans Verkuil wrote: >>> On 15/12/16 17:06, Shuah Khan wrote: > >>> >>> I think this will work for interface entities, but for

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Mauro Carvalho Chehab
Em Thu, 15 Dec 2016 10:09:53 -0700 Shuah Khan escreveu: > On 12/15/2016 09:28 AM, Hans Verkuil wrote: > > On 15/12/16 17:06, Shuah Khan wrote: > > > > I think this will work for interface entities, but for subdev entities this > > certainly won't work. Unbinding

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Shuah Khan
On 12/15/2016 09:28 AM, Hans Verkuil wrote: > On 15/12/16 17:06, Shuah Khan wrote: >> On 12/15/2016 08:26 AM, Hans Verkuil wrote: >>> On 15/12/16 15:45, Shuah Khan wrote: On 12/15/2016 07:03 AM, Hans Verkuil wrote: > On 15/12/16 13:56, Laurent Pinchart wrote: >> Hi Sakari, >>

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Mauro Carvalho Chehab
Em Thu, 15 Dec 2016 16:26:19 +0100 Hans Verkuil escreveu: > > Should all the entities stick around until all references to media > > device are gone? If an application has /dev/media open, does that > > mean all entities should not be free'd until this app. exits? What > >

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Hans Verkuil
On 15/12/16 17:06, Shuah Khan wrote: On 12/15/2016 08:26 AM, Hans Verkuil wrote: On 15/12/16 15:45, Shuah Khan wrote: On 12/15/2016 07:03 AM, Hans Verkuil wrote: On 15/12/16 13:56, Laurent Pinchart wrote: Hi Sakari, On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: On Tue, Dec 13, 2016

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Hans Verkuil
On 15/12/16 16:45, Mauro Carvalho Chehab wrote: Em Thu, 15 Dec 2016 15:45:22 +0100 Hans Verkuil escreveu: On 15/12/16 15:32, Mauro Carvalho Chehab wrote: Em Thu, 15 Dec 2016 15:03:36 +0100 Hans Verkuil escreveu: On 15/12/16 13:56, Laurent Pinchart

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Shuah Khan
On 12/15/2016 08:26 AM, Hans Verkuil wrote: > On 15/12/16 15:45, Shuah Khan wrote: >> On 12/15/2016 07:03 AM, Hans Verkuil wrote: >>> On 15/12/16 13:56, Laurent Pinchart wrote: Hi Sakari, On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: > On Tue, Dec 13, 2016 at 10:24:47AM

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Mauro Carvalho Chehab
Em Thu, 15 Dec 2016 15:45:22 +0100 Hans Verkuil escreveu: > On 15/12/16 15:32, Mauro Carvalho Chehab wrote: > > Em Thu, 15 Dec 2016 15:03:36 +0100 > > Hans Verkuil escreveu: > > > >> On 15/12/16 13:56, Laurent Pinchart wrote: > >>> Hi Sakari, > >>> >

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Hans Verkuil
On 15/12/16 15:45, Shuah Khan wrote: On 12/15/2016 07:03 AM, Hans Verkuil wrote: On 15/12/16 13:56, Laurent Pinchart wrote: Hi Sakari, On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho Chehab wrote: Em Tue, 13 Dec 2016 12:53:05

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Shuah Khan
On 12/15/2016 03:39 AM, Laurent Pinchart wrote: > Hello, > > On Tuesday 13 Dec 2016 15:23:53 Shuah Khan wrote: >> On 12/13/2016 05:24 AM, Mauro Carvalho Chehab wrote: >>> Em Tue, 13 Dec 2016 12:53:05 +0200 Sakari Ailus escreveu: On Tue, Nov 29, 2016 at 09:13:05AM -0200, Mauro Carvalho Chehab

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Shuah Khan
On 12/15/2016 07:03 AM, Hans Verkuil wrote: > On 15/12/16 13:56, Laurent Pinchart wrote: >> Hi Sakari, >> >> On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: >>> On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho Chehab wrote: Em Tue, 13 Dec 2016 12:53:05 +0200 Sakari Ailus

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Hans Verkuil
On 15/12/16 15:32, Mauro Carvalho Chehab wrote: Em Thu, 15 Dec 2016 15:03:36 +0100 Hans Verkuil escreveu: On 15/12/16 13:56, Laurent Pinchart wrote: Hi Sakari, On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Mauro Carvalho Chehab
Em Thu, 15 Dec 2016 15:03:36 +0100 Hans Verkuil escreveu: > On 15/12/16 13:56, Laurent Pinchart wrote: > > Hi Sakari, > > > > On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: > >> On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho Chehab wrote: > >>> Em Tue, 13

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Hans Verkuil
On 15/12/16 13:56, Laurent Pinchart wrote: Hi Sakari, On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho Chehab wrote: Em Tue, 13 Dec 2016 12:53:05 +0200 Sakari Ailus escreveu: On Tue, Nov 29, 2016 at 09:13:05AM -0200, Mauro Carvalho

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Laurent Pinchart
Hi Sakari, On Thursday 15 Dec 2016 13:30:41 Sakari Ailus wrote: > On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho Chehab wrote: > > Em Tue, 13 Dec 2016 12:53:05 +0200 Sakari Ailus escreveu: > >> On Tue, Nov 29, 2016 at 09:13:05AM -0200, Mauro Carvalho Chehab wrote: > >>> Hi Sakari, > >>>

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Sakari Ailus
Hi Mauro, On Tue, Dec 13, 2016 at 10:24:47AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 13 Dec 2016 12:53:05 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Tue, Nov 29, 2016 at 09:13:05AM -0200, Mauro Carvalho Chehab wrote: > > > Hi Sakari, > > > > > > I

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-15 Thread Laurent Pinchart
Hello, On Tuesday 13 Dec 2016 15:23:53 Shuah Khan wrote: > On 12/13/2016 05:24 AM, Mauro Carvalho Chehab wrote: > > Em Tue, 13 Dec 2016 12:53:05 +0200 Sakari Ailus escreveu: > >> On Tue, Nov 29, 2016 at 09:13:05AM -0200, Mauro Carvalho Chehab wrote: > >>> Hi Sakari, > >>> > >>> I answered you

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-13 Thread Shuah Khan
Hi Sakari and Mauro, On 12/13/2016 05:24 AM, Mauro Carvalho Chehab wrote: > Em Tue, 13 Dec 2016 12:53:05 +0200 > Sakari Ailus escreveu: > >> Hi Mauro, >> >> On Tue, Nov 29, 2016 at 09:13:05AM -0200, Mauro Carvalho Chehab wrote: >>> Hi Sakari, >>> >>> I answered you point

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-13 Thread Mauro Carvalho Chehab
Em Tue, 13 Dec 2016 12:53:05 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Nov 29, 2016 at 09:13:05AM -0200, Mauro Carvalho Chehab wrote: > > Hi Sakari, > > > > I answered you point to point below, but I suspect that you missed how the > > current approach works.

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-12-13 Thread Sakari Ailus
Hi Mauro, On Tue, Nov 29, 2016 at 09:13:05AM -0200, Mauro Carvalho Chehab wrote: > Hi Sakari, > > I answered you point to point below, but I suspect that you missed how the > current approach works. So, I decided to write a quick summary here. > > The character devices /dev/media? are created

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-29 Thread Mauro Carvalho Chehab
Hi Sakari, I answered you point to point below, but I suspect that you missed how the current approach works. So, I decided to write a quick summary here. The character devices /dev/media? are created via cdev, with relies on a kobject per device, with has an embedded struct kref inside.

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-28 Thread Sakari Ailus
Hi Mauro, On Tue, Nov 22, 2016 at 03:44:29PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 14 Nov 2016 15:27:22 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > I'm replying below but let me first summarise the remaining problem area > > that this patchset addresses.

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-22 Thread Shuah Khan
On 11/22/2016 10:44 AM, Mauro Carvalho Chehab wrote: > Em Mon, 14 Nov 2016 15:27:22 +0200 > Sakari Ailus escreveu: > >> Hi Mauro, >> >> I'm replying below but let me first summarise the remaining problem area >> that this patchset addresses. > > Sorry for answering too

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-22 Thread Shuah Khan
On 11/22/2016 11:13 AM, Hans Verkuil wrote: > On 22/11/16 18:44, Mauro Carvalho Chehab wrote: >>> * media: fix use-after-free in cdev_put() when app exits after driver unbind >>> 5b28dde51d0c >>> >>> The patch avoids the problem of deleting a character device (cdev_del()) >>> after its memory

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-22 Thread Hans Verkuil
On 22/11/16 18:44, Mauro Carvalho Chehab wrote: * media: fix use-after-free in cdev_put() when app exits after driver unbind 5b28dde51d0c The patch avoids the problem of deleting a character device (cdev_del()) after its memory has been released. The change is sound as such but the problem is

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-22 Thread Mauro Carvalho Chehab
Em Mon, 14 Nov 2016 15:27:22 +0200 Sakari Ailus escreveu: > Hi Mauro, > > I'm replying below but let me first summarise the remaining problem area > that this patchset addresses. Sorry for answering too late. Somehow, I missed this email in the cloud. > The problems you

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-14 Thread Sakari Ailus
Hi Mauro, I'm replying below but let me first summarise the remaining problem area that this patchset addresses. The problems you and Shuah have seen and partially addressed are related to a larger picture which is the lifetime of (mostly) memory resources related to various objects used by as

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-09 Thread Mauro Carvalho Chehab
Em Wed, 9 Nov 2016 10:00:58 -0700 Shuah Khan escreveu: > > Maybe we can get the Media Device Allocator API work in and then we can > > get your RFC series in after that. Here is what I propose: > > > > - Keep the fixes in 4.9 Fixes should always be kept. Reverting a

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-09 Thread Shuah Khan
On 11/09/2016 09:49 AM, Shuah Khan wrote: > On 11/08/2016 01:19 AM, Sakari Ailus wrote: >> Hi Shuah, >> >> On Mon, Nov 07, 2016 at 01:16:45PM -0700, Shuah Khan wrote: >>> Hi Sakari, >>> >>> On 08/26/2016 05:43 PM, Sakari Ailus wrote: Hi folks, This is the third version of the RFC

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-09 Thread Shuah Khan
On 11/08/2016 01:19 AM, Sakari Ailus wrote: > Hi Shuah, > > On Mon, Nov 07, 2016 at 01:16:45PM -0700, Shuah Khan wrote: >> Hi Sakari, >> >> On 08/26/2016 05:43 PM, Sakari Ailus wrote: >>> Hi folks, >>> >>> This is the third version of the RFC set to fix referencing in media >>> devices. >>> >>>

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-08 Thread Sakari Ailus
Hi Shuah, On Mon, Nov 07, 2016 at 01:16:45PM -0700, Shuah Khan wrote: > Hi Sakari, > > On 08/26/2016 05:43 PM, Sakari Ailus wrote: > > Hi folks, > > > > This is the third version of the RFC set to fix referencing in media > > devices. > > > > The lifetime of the media device (and media

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

2016-11-07 Thread Shuah Khan
Hi Sakari, On 08/26/2016 05:43 PM, Sakari Ailus wrote: > Hi folks, > > This is the third version of the RFC set to fix referencing in media > devices. > > The lifetime of the media device (and media devnode) is now bound to that > of struct device embedded in it and its memory is only released