Reported by kmemleak.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Devin Heitmueller dheitmuel...@kernellabs.com
---
I am not familiar with the usb API, are we also supposed to call
usb_kill_urb() in the error case maybe?
drivers/media/dvb
.
In practice I get 67% with my antenna fully amplified and 51% with
no amplification. This is close enough to what I get on my other
DVB-T adapter with the same antenna.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Steven Toth st...@kernellabs.com
---
This was written without a datasheet so
Hi Mauro,
Thanks for your reply.
On Thu, 08 Mar 2012 08:21:20 -0300, Mauro Carvalho Chehab wrote:
Em 12-02-2012 08:19, Jean Delvare escreveu:
Reported by kmemleak.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Devin Heitmueller
On Mon, 12 Mar 2012 07:28:02 -0300, Mauro Carvalho Chehab wrote:
Em 12-03-2012 07:04, Jean Delvare escreveu:
!d can't actually happen, so it doesn't matter. d is passed by
dib0700_rc_setup() when calling usb_fill_bulk_urb(), and
dib0700_rc_setup() starts with dereferencing d, if it was NULL
would crash right away.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Devin Heitmueller dheitmuel...@kernellabs.com
---
Devin, am I missing something?
drivers/media/dvb/dvb-usb/dib0700_core.c |3 ---
1 file changed, 3 deletions(-)
--- linux
Reported by kmemleak.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Devin Heitmueller dheitmuel...@kernellabs.com
---
Changes since v1:
* Don't free the URB when it is still in use.
* Fix a second leak (transfer_buffer).
drivers/media/dvb/dvb
Hi Mauro,
On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote:
On Tue, Mar 13, 2012 at 1:50 PM, Jean Delvare kh...@linux-fr.org wrote:
--- linux-3.3-rc7.orig/drivers/media/dvb/dvb-usb/dib0700_core.c
2012-03-13 11:09:13.0 +0100
+++ linux-3.3-rc7/drivers/media/dvb
Hi Mauro,
On Tue, 20 Mar 2012 09:17:54 -0300, Mauro Carvalho Chehab wrote:
Em 20-03-2012 04:20, Jean Delvare escreveu:
On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote:
Yet, I'd be more happy if Jean's patch could check first if the status is
below 0, in order to prevent
.
OTOH the initialization of ret in m920x_init is needless, the function
returns with an error as soon as an error happens, so the last return
can only be a success and we can hard-code 0 there.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Antonio
.
OTOH the initialization of ret in m920x_init is needless, the function
returns with an error as soon as an error happens, so the last return
can only be a success and we can hard-code 0 there.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Antonio
Module parameter descriptions need not be terminated with a newline.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/i2c/sony-btf-mpx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
Improvements to dvb-apps/femon:
* femon: Share common code
* femon: Display SNR in dB
* femon: Handle -EOPNOTSUPP
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
);
} else {
printf (signal %04x | snr %04x | ber %08x | unc %08x |
,
fe_info.signal_strength,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
| );
}
if (fe_info.lock)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
i2c_transfer(), not at its boundaries. I'm looking
into this now.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
messages are logged. We don't want to log messages while
holding a rt_mutex.
* No check is done on the existence of adap-algo-master_xfer. It
is thus the caller's responsibility to ensure that the function is
OK to call.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche
Hi Antti,
The driver's .probe() after i2c_new_device() is simply not supposed to
fail. You should only use i2c_new_device() if you are 100% sure that
there is a device of the given type at the given address. Checking
i2c_get_clientdata() is an ugly trick that you should no longer need to
use.
probe?
Oh, i2c_new_probed_device() probes the device, what a surprise! :D
Try, I don't know, i2c_new_device() maybe if you don't want the
probe? ;)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
to
i2c_new_probed_device(). That probe function can read whatever chip ID
register exists to decide if the probe should be successful or not.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
Hi Manu,
On Sun, 24 Nov 2013 22:51:33 +0530, Manu Abraham wrote:
Sorry, that I came upon this patch quite late.
No problem, better late than never! :)
On Mon, Jun 3, 2013 at 8:51 PM, Jean Delvare kh...@linux-fr.org wrote:
SNR is supposed to be reported by the frontend drivers in dB, so
subsystem
maintainer, so I will not handle this. If you think this is important,
you'll have to resubmit and Wolfram will decide what he wants to do
about it.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
or the like.
So let's simply get rid of the broken and useless code.
I'm also adding I2C_FUNC_I2C, as the driver and hardware support plain
I2C messaging.
[1] http://marc.info/?l=linux-i2cm=117499415208244w=2
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
drivers/media/video/usbvision
.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
messages in the first place.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
drivers, to avoid any confusion. This
is the best way to ensure that the comments won't go out of sync
again. Anyone interested in the implementation details would rather
look at the code itself.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
drivers/media/video/au0828/au0828-i2c.c |2
on me to drive it, I am afraid it will take months, given
my current workload and various tasks with a much higher priority than
this. I will however be happy to help with code review.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
On Wed, 09 Nov 2011 10:02:08 -0200, Mauro Carvalho Chehab wrote:
Em 09-11-2011 08:37, Jean Delvare escreveu:
Speaking of struct i2c_client, I seem to remember that the dvb
subsystem doesn't use it much at the moment. This might be an issue if
you intend to get the generic code into i2c-core
Hi Antti,
As an additional note, it just occurred to me that what you are working
on is somewhat related to Mark Brown's regmap. Look in
drivers/base/regmap and see if maybe you can reuse and/or extend Mark's
approach.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe
it through
your tree, or please ack' it so Jiri can pull it through the trivial
tree.
Patch against linux-next-tree, 22. Dez 08:38:18 CET 2009
but also present in linus tree.
Signed-off-by: Peter Huewe peterhu...@gmx.de
Acked-by: Jean Delvare kh...@linux-fr.org
---
drivers/media/dvb/bt8xx/bt878
with no known IR setup. It doesn't imply your board has any I2C device
at address 0x7a. So chances are that the message is harmless and you
can simply ignore it.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
it.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 06 Jan 2010 20:10:30 +0100, Daro wrote:
W dniu 06.01.2010 19:40, Jean Delvare pisze:
On Wed, 06 Jan 2010 18:58:58 +0100, Daro wrote:
It is not the error message itself that bothers me but the fact that IR
remote control device is not detected and I cannot use it (I checked
On Sat, 09 Jan 2010 13:08:36 +0100, Daro wrote:
W dniu 06.01.2010 21:21, Jean Delvare pisze:
On Wed, 06 Jan 2010 18:58:58 +0100, Daro wrote:
It is not the error message itself that bothers me but the fact that IR
remote control device is not detected and I cannot use it (I checked
On Sun, 10 Jan 2010 00:18:46 +0100, hermann pitton wrote:
Hi,
Am Samstag, den 09.01.2010, 17:14 +0100 schrieb Jean Delvare:
On Sat, 09 Jan 2010 13:08:36 +0100, Daro wrote:
W dniu 06.01.2010 21:21, Jean Delvare pisze:
On Wed, 06 Jan 2010 18:58:58 +0100, Daro wrote
of i2c_transfer() won't
please you. Either it sleeps, or it returns -EAGAIN, which you'll have
to handle. If you retry forever without sleeping, it might take long
before you can proceed, and performance will suffer.
Hope that helps,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe
Hi Mauro, Hermann,
On Sat, 30 Jan 2010 01:47:41 +0100, hermann pitton wrote:
Am Freitag, den 29.01.2010, 13:40 -0200 schrieb Mauro Carvalho Chehab:
Jean Delvare wrote:
From: Jean Delvare kh...@linux-fr.org
Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants
Some
had to fake anything? What I'd like to know is
simply if my first patch had any negative effect on other cards.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Hi Hermann,
On Tue, 02 Feb 2010 02:47:53 +0100, hermann pitton wrote:
Hi Jean,
Am Montag, den 01.02.2010, 10:56 +0100 schrieb Jean Delvare:
Hi Hermann,
On Mon, 01 Feb 2010 02:16:35 +0100, hermann pitton wrote:
For now, I only faked a P7131 Dual with a broken IR receiver on a 2.6.29
VIDEO_ADV7180 is listed twice in v4l/versions.txt: once in [2.6.31]
and once in [2.6.26]. As I have tested that it builds fine in 2.6.26,
drop the former entry.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
v4l/versions.txt |1 -
1 file changed, 1 deletion(-)
--- v4l-dvb.orig/v4l
it would be good to make sure it fixes your problem before
actually applying it.
Thanks!
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro,
On Tue, 02 Feb 2010 17:09:05 -0200, Mauro Carvalho Chehab wrote:
From: Jean Delvare kh...@linux-fr.org
Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants
Some variants of the ASUS TV-FM 7135 are handled as the ASUSTeK P7131
Analog (card=146). However
. If you don't like it and
prefer the second proposal even though I think it's more of a
workaround than a proper fix, it's really up to you. You're maintaining
the subsystem and I am not, so you're the one deciding.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line
On Wed, 10 Feb 2010 16:40:03 -0200, Mauro Carvalho Chehab wrote:
Jean Delvare wrote:
Under the assumption that saa7134_hwinit1() only touches GPIOs
connected to IR receivers (and it certainly looks like this to me) I
fail to see how these pins not being initialized could have any effect
.
This fixes bug #15184:
http://bugzilla.kernel.org/show_bug.cgi?id=15184
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
As this fixes a regression, I suggest pushing to Linus quickly. This is
a candidate for 2.6.32-stable too.
linux/drivers/media/video/bt8xx/bttv-driver.c |1 +
linux
On Wed, 24 Feb 2010 10:10:16 -0300, Mauro Carvalho Chehab wrote:
Hi Jean,
Jean Delvare wrote:
I have 3 patches pending which aren't in your list. I can see them in
patchwork:
http://patchwork.kernel.org/patch/79755/
http://patchwork.kernel.org/patch/79754/
http
for different LNA stuff after the
Hauppauge/Pinnacle merge until now.
If you claim to know it better, please share with us.
I'm not claiming anything, and to be honest, I have no idea what you're
talking about.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux
function
Signed-off-by: Márton Németh nm...@freemail.hu
Good catch.
Acked-by: Jean Delvare kh...@linux-fr.org
Douglas, please apply quickly.
---
diff -r 41c5482f2dac linux/drivers/media/video/bt8xx/bttv-i2c.c
--- a/linux/drivers/media/video/bt8xx/bttv-i2c.c Thu Mar 04 02:49:46
2010 -0300
) on it. The getkey function will need to
return the full code as well.
Sorry for the late reply. Is the problem solved by now, or is my help
still needed?
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo
, so I admit I don't quite understand how I
my i2c changes could be responsible for the regression.
Anyway, glad that you managed to fix it.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo
upstream without it, and if it takes too long,
I'll probably just discard the patch and move to other tasks.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
parameter to the driver.
If you ever need to remove the patch, use:
$ cd ~/src/linux-2.6.32
$ patch -p2 -R
~/download/saa7134-Fix-IR-support-of-some-ASUS-TV-FM-7135-variants.patch
I hope my instructions are clear enough, if you have any problem, just
ask.
Thanks,
--
Jean Delvare
On Sun, 14 Mar 2010 20:34:34 +0100, Daro wrote:
W dniu 14.03.2010 09:26, Jean Delvare pisze:
It will be easier with the kernel you compiled yourself. First of all,
download the patch from:
http://patchwork.kernel.org/patch/75883/raw/
Then, move to the source directory of your 2.6.32.2
On Tue, 16 Mar 2010 12:05:02 +0100, Jean Delvare wrote:
Executive summary (as I understand it): the card that no longer works
is a DViCO FusionHDTV7 Dual Express
(CX23885_BOARD_DVICO_FUSIONHDTV_7_DUAL_EXP), bridge driver cx23885. It
has 2 xc5000 chips at I2C address 0x64 (on 2 different I2C
but not in
saa7115.c, which has exactly the same construct? For that matter, I think
almost all v4l i2c drivers do this.
That I can't say, sorry.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo
Replying to myself...
On Sun, 21 Mar 2010 14:46:55 +0100, Jean Delvare wrote:
I get the feeling that this would be a job for managed resources as
some drivers already do for I/O ports and IRQs. Managed resources don't
care about symmetry of allocation and freeing, by design (so it can
violate
.
This is sufficient in most cases in my experience. If not, these tools
can certainly get extended, at least to cover all of SMBus.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Can the fix below please be picked quickly? This is a regression, the
fix should go upstream ASAP. Thanks.
On Fri, 19 Mar 2010 14:42:50 +0100, Jean Delvare wrote:
IR support on FusionHDTV cards is broken since kernel 2.6.31. One side
effect of the switch to the standard binding model for IR I2C
From: Andrzej Hajda andrzej.ha...@wp.pl
Patch solves problem of missed keystrokes on some remote controls,
as reported on http://bugzilla.kernel.org/show_bug.cgi?id=9637 .
Signed-off-by: Andrzej Hajda andrzej.ha...@wp.pl
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
Resending because last
On Thu, 2 Jul 2009 16:50:35 +0200, Jean Delvare wrote:
From: Andrzej Hajda andrzej.ha...@wp.pl
Patch solves problem of missed keystrokes on some remote controls,
as reported on http://bugzilla.kernel.org/show_bug.cgi?id=9637 .
Signed-off-by: Andrzej Hajda andrzej.ha...@wp.pl
Signed-off
Patch solves problem of missed keystrokes on some remote controls,
as reported on http://bugzilla.kernel.org/show_bug.cgi?id=9637 .
Signed-off-by: Andrzej Hajda andrzej.ha...@wp.pl
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
Changes:
* Driver no longer builds on kernels 2.6.22, so add
Hi Trent,
On Sun, 5 Jul 2009 01:13:14 -0700 (PDT), Trent Piepho wrote:
On Fri, 3 Jul 2009, Jean Delvare wrote:
Kernels 2.6.22 to 2.6.24 (inclusive) need some compatibility quirks
for the hrtimer API. For older kernels, some required functions were
not exported so there's nothing we can do
On Thu, 9 Jul 2009 11:44:46 -0400, Jarod Wilson wrote:
On Tuesday 07 April 2009 08:36:17 Jean Delvare wrote:
So, let's just forget the workarounds and go straight to the point: focus
on
merging lirc-i2c drivers.
Will this happen next week? I fear not. Which is why I can't wait
regression.
This is bad. If there a bugzilla entry? If not, where can I read more
details / get in touch with an affected user?
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
)(struct IR_i2c*, u32*, u32*);
+ enum ir_kbd_get_key_fn internal_get_key_func;
};
#endif
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
*/
sd = v4l2_i2c_new_subdev(cx-v4l2_dev, adap, mod, type, hw_addrs[idx]);
if (sd != NULL)
sd-grp_id = hw;
The rest looks OK.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
On Sun, 19 Jul 2009 09:17:30 -0400, Mark Lord wrote:
Mark Lord wrote:
Jean Delvare wrote:
Hi Mark,
On Sun, 19 Jul 2009 08:52:09 -0400, Mark Lord wrote:
While you folks are looking into ir-kbd-i2c,
perhaps one of you will fix the regressions
introduced in 2.6.31-* ?
The drive
they first try 2.6.31 after release ?
Where does lsinput get the string from?
What exactly was it before, and what is it exactly in 2.6.31?
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
entry for any IR receiver */
{ ir_video, 0 },
- /* IR device specific entries could be added here */
+ /* IR device specific entries should be added here */
+ { ir_rx_z8f0811_haup, 0 },
{ }
};
Yes, looks good.
--
Jean Delvare
--
To unsubscribe from this list: send
On Sun, 19 Jul 2009 15:20:50 -0400, Mark Lord wrote:
Mark Lord wrote:
(resending.. somebody trimmed linux-kernel from the CC: earlier)
FWIW I don't think it was there in the first place.
Jean Delvare wrote:
On Sun, 19 Jul 2009 10:38:37 -0400, Mark Lord wrote:
I'm debugging various other
On Mon, 20 Jul 2009 20:09:44 -0400, Andy Walls wrote:
On Sun, 2009-07-19 at 14:59 +0200, Jean Delvare wrote:
Functions which are referenced by their address can't be inlined by
definition.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Jean,
Looks godd to me, but you forgot to add
Hi Andy,
On Mon, 20 Jul 2009 20:07:50 -0400, Andy Walls wrote:
On Sun, 2009-07-19 at 14:47 +0200, Jean Delvare wrote:
Hi Andy,
On Fri, 17 Jul 2009 16:35:37 -0400, Andy Walls wrote:
This patch augments the init data passed by bridge drivers to ir-kbd-i2c
so that the ir_type can
kernel for me.
Thanks go to Brian Rogers for pointing out the solution in the context
of submitting a patch for a few other drivers.
Good catch.
Acked-by: Jean Delvare kh...@linux-fr.org
As far as I can see, the em28xx and saa7134 drivers have the exact same
problem. Is there anyone working
On Sun, 06 Sep 2009 12:31:24 -0400, Andy Walls wrote:
On Sat, 2009-09-05 at 20:46 +0200, Jean Delvare wrote:
Hi Andy,
On Sat, 05 Sep 2009 10:13:41 -0400, Andy Walls wrote:
Mauro,
Please pull from http://linuxtv.org/hg/~awalls/v4l-dvb
for the following changeset:
01
2.6.31 would be affected, 2.6.30
wouldn't be.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The adv7180 driver is a new-style i2c driver, unconditionally using
struct i2c_device_id. As such, it can't be built on kernels older than
2.6.26.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
v4l/versions.txt |1 +
1 file changed, 1 insertion(+)
--- v4l-dvb.orig/v4l/versions.txt
Hi Pawel,
I am removing the linux-i2c list from Cc, because it seems clear that
your problem is related to specific media drivers and not the i2c
subsystem.
On Wed, 30 Sep 2009 10:16:15 +0200, Paweł Sikora wrote:
On Tuesday 29 September 2009 16:16:29 Jean Delvare wrote:
On Wed, 16 Sep 2009 10
On Wed, 30 Sep 2009 13:52:27 +0200, Paweł Sikora wrote:
On Wednesday 30 September 2009 12:57:37 Jean Delvare wrote:
Are you running distribution kernels or self-compiled ones?
Any local patches applied?
Would you be able to apply debug patches and rebuild your kernel?
yes, i'm using
Hi Andy,
On Wed, 30 Sep 2009 19:42:46 -0400, Andy Walls wrote:
On Wed, 2009-09-30 at 12:57 +0200, Jean Delvare wrote:
Not sure why you look at address 0x83e? The stack trace says +0x64. As
function ir_input_init() starts at 0x800, the oops address would be
0x864, which is:
864
On Thu, 01 Oct 2009 12:17:20 +0200, Paweł Sikora wrote:
Dnia 01-10-2009 o 12:06:09 Jean Delvare kh...@linux-fr.org napisał(a):
I'm not sure if it is the problem here, but it may be prudent to check
that there's no mismatch between the module and the structure
definitions being pulled
ts;
struct saa7134_dmaqueuets_q;
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
saa7134_dev {
/* I2C keyboard data */
#if LINUX_VERSION_CODE = KERNEL_VERSION(2, 6, 30)
- struct i2c_board_info info;
struct IR_i2c_init_datainit_data;
#endif
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
Which is why I have always preferred sizeof(struct foo) over
sizeof(var).
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/dvb/dvb-usb/ce6230.c|2 +-
linux/drivers/media/video/saa7164/saa7164-cmd.c |2 +-
2 files changed, 2 insertions(+), 2 deletions
should
be limited to the hardware in question.
If we only have to care about the Upmost Purple TV, then the following
patch should solve the problem:
* * * * *
From: Jean Delvare kh...@linux-fr.org
Subject: saa7134: Fix IR support for Purple TV
The i2c core prevents us from probing I2C address
Hi Pawel,
On Sat, 3 Oct 2009 12:08:36 +0200, Paweł Sikora wrote:
On Thursday 01 October 2009 13:43:43 Jean Delvare wrote:
Pawel, please give a try to the following patch. Please keep the debug
patches apply too, in case we need additional info.
the second patch helps. here's a dmesg log
these messages?
--
Jean Delvare
http://khali.linux-fr.org/wishlist.html
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
this in the details reply I'm writing right now.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
adapters then it makes some sense to move the definitions into
ir-kbd-i2c. But if devices are heavily adapter-dependent, and moving
the definitions into ir-kbd-i2c doesn't allow for any code refactoring,
then I don't quite see the point.
--
Jean Delvare
--
To unsubscribe from this list: send the line
results.
How would I debug this further?
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, what antenna are you using? The
Terratec-provided one, or another one?
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
I would like to see these statistics improved. I am willing to help,
however the drxk driver is rather complex (at least to my eyes) and I
do not have a datasheet so I wouldn't know where to start. Is there
anyone who can work on this and/or provide some guidance?
Thanks,
--
Jean Delvare
Hi Oliver,
On Wed, 06 Mar 2013 19:07:01 +0100, Oliver Schinagl wrote:
On 03/06/13 16:03, Jean Delvare wrote:
It turns out that my problem is the antenna. I was using the antenna I
have been using with my previous card, which is an internal DVB-T
antenna with amplification (external power
Last parameter of function GetLockStatus() isn't used so drop it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/dvb-frontends/drxk_hard.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- linux-3.8.orig/drivers
DIV_ROUND_CLOSEST is faster if the compiler knows it will only be
dealing with unsigned dividends.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Andrew Morton a...@linux-foundation.org
Cc: Guenter Roeck li...@roeck-us.net
Cc: Mauro Carvalho Chehab mche...@infradead.org
---
drivers/media/rc
The Terratec Cinergy T PCIe Dual is based on the CX23885, and uses
MT2063, DRX-3913k and DRX-3916k chips, so select the relevant drivers.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Stefan Ringel linu...@stefanringel.de
Cc: Mauro Carvalho Chehab mche...@infradead.org
---
drivers/media
Hi Mauro,
On Tue, 18 Sep 2012 12:49:53 -0300, Mauro Carvalho Chehab wrote:
Em 01-09-2012 15:53, Jean Delvare escreveu:
DIV_ROUND_CLOSEST is faster if the compiler knows it will only be
dealing with unsigned dividends.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Andrew Morton
that.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
can't, not in the general case at least. sizeof(*val) will
return the size of the _first_ element of the destination buffer, which
has nothing to do with the length of that buffer (which in turn might
be rightfully longer than the read length for this specific message.)
--
Jean Delvare
not opposed to the idea of i2c_msg initialization helper macros,
but please don't mix that with actual code changes which could have bad
side effects.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
priority list. And
I see the extra work for the pre-processor, so we need a good reason
for doing that.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
of debugging or
experimentation.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
201 - 300 of 309 matches
Mail list logo
