Re: [PATCH] mmc:sdhci:add support to request/free pins for controllers sharing hardware bus

2011-04-26 Thread Wolfram Sang
* Where is the patch that implements the get_shared_pins() hook in  your driver? We send the common level patch ahead to get the upstream agreement so that we can maintain our bottom level sdhci codes better. We will send the special driver patch after some time. Hmm, why should be there a

Re: [PATCH] mmc:sdhci:add support to request/free pins for controllers sharing hardware bus

2011-04-26 Thread Barry Song
Hi Wolfram, 2011/4/26 Wolfram Sang w.s...@pengutronix.de: * Where is the patch that implements the get_shared_pins() hook in  your driver? We send the common level patch ahead to get the upstream agreement so that we can maintain our bottom level sdhci codes better. We will send the

Re: [PATCH] mmc: sdhci: add support for pre_req and post_req

2011-04-26 Thread Per Forlin
On 26 April 2011 04:47, Shawn Guo shawn@freescale.com wrote: On Tue, Apr 26, 2011 at 10:26:01AM +0900, Jaehoon Chung wrote: Hi Shawn I tested using ADMA with your patch...(benchmark : IOzone) But I didn't get improvement of performance with ADMA.. (i can see improvement of performance

Re: [linux-pm] [PATCH/RFC] MMC: remove unbalanced pm_runtime_suspend()

2011-04-26 Thread Guennadi Liakhovetski
Hi On Mon, 25 Apr 2011, Rafael J. Wysocki wrote: On Saturday, April 23, 2011, Rafael J. Wysocki wrote: On Friday, April 22, 2011, Alan Stern wrote: On Fri, 22 Apr 2011, Rafael J. Wysocki wrote: The barrier would not prevent the race between the notifier and runtie PM

Re: [linux-pm] [PATCH/RFC] MMC: remove unbalanced pm_runtime_suspend()

2011-04-26 Thread Rafael J. Wysocki
On Tuesday, April 26, 2011, Guennadi Liakhovetski wrote: Hi Hi, On Mon, 25 Apr 2011, Rafael J. Wysocki wrote: On Saturday, April 23, 2011, Rafael J. Wysocki wrote: On Friday, April 22, 2011, Alan Stern wrote: On Fri, 22 Apr 2011, Rafael J. Wysocki wrote: The barrier would

Re: [PATCH v3 00/12] add support for host controller v3.00

2011-04-26 Thread Chris Ball
Hi Arindam, On Tue, Apr 26 2011, Nath, Arindam wrote: Just a follow up on what you said. Is there any plan to merge the patches with your tree? Yes, sounds good -- linux-mmc@ folks, would anyone like to give a Tested- or Reviewed-by: on these patches? Thanks! - Chris. -- Chris Ball

Re: [PATCH] mmc:sdhci:add support to request/free pins for controllers sharing hardware bus

2011-04-26 Thread Chris Ball
Hi Barry, On Tue, Apr 26 2011, Barry Song wrote: Just because Our SoCs are still on the way to opensource and mainline. Even our arch/arm/mach-xxx hasn't been merged yet. Our target is syncing our codes with mainline. So as a modification to sdhci common level, we just get upstream's opinion

Re: [PATCH v3 00/12] add support for host controller v3.00

2011-04-26 Thread Wolfram Sang
On Tue, Apr 26, 2011 at 08:50:31AM -0400, Chris Ball wrote: Hi Arindam, On Tue, Apr 26 2011, Nath, Arindam wrote: Just a follow up on what you said. Is there any plan to merge the patches with your tree? Yes, sounds good -- linux-mmc@ folks, would anyone like to give a Tested- or

Re: [PATCH v3 00/12] add support for host controller v3.00

2011-04-26 Thread Chris Ball
Hi Wolfram, On Tue, Apr 26 2011, Wolfram Sang wrote: On Tue, Apr 26, 2011 at 08:50:31AM -0400, Chris Ball wrote: Hi Arindam, On Tue, Apr 26 2011, Nath, Arindam wrote: Yes, sounds good -- linux-mmc@ folks, would anyone like to give a Tested- or Reviewed-by: on these patches? Considering

Re: [PATCH 1/6] mmc: block: Resume multi-block reads after transient read errors.

2011-04-26 Thread Arnd Bergmann
On Saturday 23 April 2011, John Stultz wrote: From: David Ding david.j.d...@motorola.com CC: Chris Ball c...@laptop.org CC: Arnd Bergmann a...@arndb.de CC: Dima Zavin d...@android.com Signed-off-by: Bentao Zou bz...@motorola.com Signed-off-by: David Ding david.j.d...@motorola.com

Re: [PATCH 0/5] consolidate sdhci pltfm OF drivers and get them self registered

2011-04-26 Thread Wolfram Sang
Hi Shawn, The approach seems sensible, so have a look at my (mostly minor) comments inside the patches. However, there is one bigger piece missing. You converted all the drivers which had a seperate source-file and hooked into sdhci-pltfm.c. However, those are only those users which

Re: [PATCH 2/6] mmc_block: Allow more than 8 partitions per card

2011-04-26 Thread Arnd Bergmann
On Saturday 23 April 2011, John Stultz wrote: From: Colin Cross ccr...@android.com Set the GENHD_FL_EXT_DEVT flag, which will allocate minor numbers in major 259 for partitions past disk-minors. Also remove the use of disk_devt to determine devidx from md-disk. md-disk-first_minor is

Re: [PATCH v2 01/12] mmc: add none blocking mmc request function

2011-04-26 Thread David Vrabel
On 20/04/11 08:17, Per Forlin wrote: Using a MMC request queue has other benefits -- it allows multiple users without having to claim/release the host. This would be useful for (especially multi-function) SDIO. You mean claim and release would be done only within the mmc core. The timed

Re: [PATCH 4/6] mmc: sd: Add new CONFIG_MMC_PARANOID_SD_INIT for enabling retries during SD detection

2011-04-26 Thread Arnd Bergmann
On Saturday 23 April 2011, John Stultz wrote: @@ -482,7 +485,26 @@ int mmc_sd_setup_card(struct mmc_host *host, struct mmc_card *card, /* * Fetch switch information from card. */ +#ifdef CONFIG_MMC_PARANOID_SD_INIT + for (retries = 1;

Re: [PATCH 5/6] mmc: sd: When resuming, try a little harder to init the card

2011-04-26 Thread Arnd Bergmann
On Saturday 23 April 2011, John Stultz wrote: From: San Mehat s...@android.com CC: Chris Ball c...@laptop.org CC: Arnd Bergmann a...@arndb.de CC: Dima Zavin d...@android.com Signed-off-by: San Mehat s...@android.com Signed-off-by: John Stultz john.stu...@linaro.org ---

Re: [PATCH 6/6] mmc: sd: Add retries in re-detection

2011-04-26 Thread Arnd Bergmann
On Saturday 23 April 2011, John Stultz wrote: From: San Mehat s...@android.com Signed-off-by: San Mehat s...@android.com Same comments apply as in the previous patch. Maybe San Mehat can comment on the intentions of this patch. Is there a specific hardware that is causing this trouble. mmc:

Re: [PATCH v7] mmc: Add mmc CMD+ACMD passthrough ioctl

2011-04-26 Thread Arnd Bergmann
On Friday 22 April 2011, John Calixto wrote: Allows appropriately-privileged applications to send CMD (normal) and ACMD (application-specific; preceded with CMD55) commands to cards/devices on the mmc bus. This is primarily useful for enabling the security functionality built in to every SD

Re: [PATCH v2 01/12] mmc: add none blocking mmc request function

2011-04-26 Thread Per Forlin
On 26 April 2011 15:29, David Vrabel david.vra...@csr.com wrote: On 20/04/11 08:17, Per Forlin wrote: Using a MMC request queue has other benefits -- it allows multiple users without having to claim/release the host.  This would be useful for (especially multi-function) SDIO. You mean claim

Re: [PATCH] sdhci-pxa: add platform specific code for UHS signaling

2011-04-26 Thread Philip Rakity
On Apr 25, 2011, at 11:36 PM, Nath, Arindam wrote: Hi Philip, -Original Message- From: Philip Rakity [mailto:prak...@marvell.com] Sent: Saturday, April 23, 2011 1:56 AM To: linux-mmc@vger.kernel.org Cc: Nath, Arindam Subject: [PATCH] sdhci-pxa: add platform specific code for

Re: [PATCH] mmc: eMMC signal voltage does not use CMD11

2011-04-26 Thread Philip Rakity
Hi Arindam, On Apr 25, 2011, at 11:45 PM, Nath, Arindam wrote: Hi Philip, -Original Message- From: Philip Rakity [mailto:prak...@marvell.com] Sent: Saturday, April 23, 2011 1:56 AM To: linux-mmc@vger.kernel.org Cc: Nath, Arindam Subject: [PATCH] mmc: eMMC signal voltage does

Re: [PATCH] mmc:sdhci:add support to request/free pins for controllers sharing hardware bus

2011-04-26 Thread Philip Rakity
Barry, How are interrupts from SDIO devices handled ? SDIO devices use one of the pins to signal a interrupt to the host when data is availabe. Philip On Apr 26, 2011, at 12:27 AM, Barry Song wrote: Hi Wolfram, 2011/4/26 Wolfram Sang w.s...@pengutronix.de: * Where is the patch that

Re: [PATCH v3 00/12] add support for host controller v3.00

2011-04-26 Thread Philip Rakity
Chris, What is the format for this -- Can I add reviewed by as a note to all the patches or is this done one-by-one ? I am using the code and have successfully run eMMC (DDR50) and SDIO (SDR50). Patches for SDR50 will take me a while to finish but the code does work and is based on Arindam

Re: [PATCH v3 00/12] add support for host controller v3.00

2011-04-26 Thread Chris Ball
Hi, On Tue, Apr 26 2011, Philip Rakity wrote: Chris, What is the format for this -- Can I add reviewed by as a note to all the patches or is this done one-by-one ? Whichever you think is appropriate -- you can ask me to add your Reviewed-by: to each patch and I'll do that, or you can reply

Re: [PATCH 2/6] mmc_block: Allow more than 8 partitions per card

2011-04-26 Thread Colin Cross
On Tue, Apr 26, 2011 at 6:22 AM, Arnd Bergmann a...@arndb.de wrote: On Saturday 23 April 2011, John Stultz wrote: From: Colin Cross ccr...@android.com Set the GENHD_FL_EXT_DEVT flag, which will allocate minor numbers in major 259 for partitions past disk-minors. Also remove the use of

Re: [PATCH 2/6] mmc_block: Allow more than 8 partitions per card

2011-04-26 Thread Arnd Bergmann
On Tuesday 26 April 2011, Colin Cross wrote: On Tue, Apr 26, 2011 at 6:22 AM, Arnd Bergmann a...@arndb.de wrote: On Saturday 23 April 2011, John Stultz wrote: From: Colin Cross ccr...@android.com Set the GENHD_FL_EXT_DEVT flag, which will allocate minor numbers in major 259 for

RE: [PATCH] mmc: eMMC signal voltage does not use CMD11

2011-04-26 Thread Nath, Arindam
Hi Philip, [...] - if (signal_voltage == MMC_SIGNAL_VOLTAGE_180) { + if (signal_voltage != MMC_SIGNAL_VOLTAGE_330 cmd11) { Since we are going to send CMD11 only to change to 1.8V signaling, and when cmd11 is set, isn't it better to have if ((signal_voltage ==

Re: [RESEND PATCH 4/4] mmc_spi.c: add support for the regulator framework

2011-04-26 Thread Daniel Ribeiro
Em Qui, 2011-04-21 às 14:49 +0200, Antonio Ospite escreveu: On Thu, 21 Apr 2011 13:40:41 +0100 Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Apr 21, 2011 at 02:27:53PM +0200, Antonio Ospite wrote: +#ifdef CONFIG_REGULATOR + host-vcc = regulator_get(mmc_dev(host-mmc),

Re: [PATCH v7] mmc: Add mmc CMD+ACMD passthrough ioctl

2011-04-26 Thread John Calixto
On Tue, 26 Apr 2011, Arnd Bergmann wrote: On Friday 22 April 2011, John Calixto wrote: Allows appropriately-privileged applications to send CMD (normal) and ACMD (application-specific; preceded with CMD55) commands to cards/devices on the mmc bus. This is primarily useful for enabling the

Re: [PATCH v7] mmc: Add mmc CMD+ACMD passthrough ioctl

2011-04-26 Thread Chris Ball
Hi John, On Tue, Apr 26 2011, John Calixto wrote: Arnd - Thanks a lot for the review and your help getting the implementation right! Chris - What do you think? How should I proceed here? I think I'll merge it, since I'm not going to work on abstracting the security feature either. I'll

Re: [PATCH v7] mmc: Add mmc CMD+ACMD passthrough ioctl

2011-04-26 Thread John Calixto
On Tue, 26 Apr 2011, Chris Ball wrote: Hi John, On Tue, Apr 26 2011, John Calixto wrote: Arnd - Thanks a lot for the review and your help getting the implementation right! Chris - What do you think? How should I proceed here? I think I'll merge it, since I'm not going to work on

Re: CMD23 plumbing and support patchset.

2011-04-26 Thread Andrei Warkentin
On Fri, Apr 22, 2011 at 9:51 PM, Chris Ball c...@laptop.org wrote: Hi, On Thu, Apr 21 2011, Andrei Warkentin wrote: Can you give me the manufacturing date? This is pretty interesting. You can see an improvement even if you do something like time block writes (O_DIRECT | O_SYNC, of course).

Re: [PATCH] mmc: sdhci: add support for pre_req and post_req

2011-04-26 Thread Andrei Warkentin
Hi, On Fri, Apr 22, 2011 at 6:01 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi Andrei.. Did you test this patch with ADMA? I wonder that be increased performance or others.. FWIW... ADMA With changes adb shell echo 0 /sys/module/sdhci/parameters/no_prepost time adb shell iozone -a

CMD23 plumbing patchset.

2011-04-26 Thread Andrei Warkentin
This is the fourth version of the CMD23 plumbing and host driver support. Changes: 1) Changes MMC white list to a black list. 2) Fixes two stupid bugs in tentative AutoCMD23 patch (sorry Arindam) ToC: [[v4] 1/5] MMC: Add/remove quirks conditional support. [[v4] 2/5] MMC: Use CMD23 for multiblock

[[v4] 1/5] MMC: Add/remove quirks conditional support.

2011-04-26 Thread Andrei Warkentin
Conditional add/remove quirks for MMC and SD. Cc: c...@laptop.org Signed-off-by: Andrei Warkentin andr...@motorola.com --- include/linux/mmc/card.h | 40 1 files changed, 36 insertions(+), 4 deletions(-) diff --git a/include/linux/mmc/card.h

[[v4] 2/5] MMC: Use CMD23 for multiblock transfers when we can.

2011-04-26 Thread Andrei Warkentin
CMD23-prefixed instead of open-ended multiblock transfers have a performance advantage on some MMC cards. Cc: arindam.n...@amd.com Cc: c...@laptop.org Cc: a...@arndb.de Signed-off-by: Andrei Warkentin andr...@motorola.com --- drivers/mmc/card/block.c | 109

[[v4] 3/5] MMC: Implement MMC_CAP_CMD23 for SDHCI.

2011-04-26 Thread Andrei Warkentin
Implements support for multiblock transfers bounded by SET_BLOCK_COUNT (CMD23). Cc: arindam.n...@amd.com Cc: c...@laptop.org Cc: a...@arndb.de Signed-off-by: Andrei Warkentin andr...@motorola.com --- drivers/mmc/host/sdhci.c | 70 ++---

[[v4] 4/5] MMC: Block CMD23 support for UHS104/SDXC cards.

2011-04-26 Thread Andrei Warkentin
SD cards operating at UHS104 or better support SET_BLOCK_COUNT. Cc: arindam.n...@amd.com Cc: c...@laptop.org Cc: a...@arndb.de Signed-off-by: Andrei Warkentin andr...@motorola.com --- drivers/mmc/card/block.c |9 ++--- drivers/mmc/core/sd.c|7 +++ include/linux/mmc/card.h |

[[v4] 5/5] MMC: SDHCI AutoCMD23 support.

2011-04-26 Thread Andrei Warkentin
Enables Auto-CMD23 support where available (SDHCI 3.0 controllers) Cc: arindam.n...@amd.com Cc: c...@laptop.org Cc: a...@arndb.de Cc: subha...@codeaurora.org Signed-off-by: Andrei Warkentin andr...@motorola.com --- drivers/mmc/host/sdhci.c | 17 - drivers/mmc/host/sdhci.h |

SD Patches

2011-04-26 Thread Philip Rakity
Chris, It is important that the patches are put into the linux code for testing. I have tested and reviewed the code but NOT extensively. It works for me doing eMMC (DDR) and SDIO (SDR50). I certainly have no issue with saying I have reviewed the code and tested it -- but again only in the

RE: [[v4] 5/5] MMC: SDHCI AutoCMD23 support.

2011-04-26 Thread Nath, Arindam
Hi Andrei, Is there any more change to your V4 than the ones we discussed yesterday? I did the mod we discussed, but seems like the driver only sends CMD23 now, not Auto CMD23. Thanks, Arindam -Original Message- From: Andrei Warkentin [mailto:andr...@motorola.com] Sent: Wednesday,