Regarding SD card

2012-12-14 Thread Neeraj Jakhar
Hi, I have with me a bunch of "raw" Micro SD Cards (which I got from a friend of my friend). Their capacity as reported by Linux/Windows is around 30 MB. Further, most of the fields in their CID and CSD register are empty. For example, the following values are set, Manufacturer ID: 0x00 ; OEM/App

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2012-12-14 Thread Linus Walleij
On Fri, Dec 14, 2012 at 6:11 PM, Russell King - ARM Linux wrote: > On Fri, Dec 14, 2012 at 03:38:46PM +, Pawel Moll wrote: >> The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 >> and v116/216) contains a modified version of the PL180 MMCI, with >> PeriphID Configuration va

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2012-12-14 Thread Linus Walleij
On Fri, Dec 14, 2012 at 4:38 PM, Pawel Moll wrote: > The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 > and v116/216) contains a modified version of the PL180 MMCI, with > PeriphID Configuration value changed to 0x2. > > This version adds an optional "hardware flow control"

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2012-12-14 Thread Pawel Moll
On Fri, 2012-12-14 at 17:11 +, Russell King - ARM Linux wrote: > On Fri, Dec 14, 2012 at 03:38:46PM +, Pawel Moll wrote: > > The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 > > and v116/216) contains a modified version of the PL180 MMCI, with > > PeriphID Configuratio

Re: [PATCH] mmc: mmci: Add new VE MMCI variant

2012-12-14 Thread Russell King - ARM Linux
On Fri, Dec 14, 2012 at 03:38:46PM +, Pawel Moll wrote: > The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 > and v116/216) contains a modified version of the PL180 MMCI, with > PeriphID Configuration value changed to 0x2. > > This version adds an optional "hardware flow c

Re: [PATCH 1/3] mmc: core: enhance the code for signal voltage setting

2012-12-14 Thread Kevin Liu
2012/12/14 Kevin Liu : > 2012/12/14 Ulf Hansson : >> On 14 December 2012 11:53, Kevin Liu wrote: >>> 1. if host does NOT implement signal voltage setting function, >>> should return error. >>> 2. add the check for data signal before voltage change according >>> to the spec. If host does NOT detect

Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2012-12-14 Thread Lee Jones
On Fri, 14 Dec 2012, Russell King - ARM Linux wrote: > On Fri, Dec 14, 2012 at 03:30:29PM +0100, Ulf Hansson wrote: > > From: Lee Jones > > > > There are currently two instances of the ios_handler being used. > > Both of which mearly toy with some regulator settings. Now there > > is a GPIO regu

Re: [PATCH] mmc: dw_mmc: add support for use_hold_reg

2012-12-14 Thread Dinh Nguyen
On Fri, 2012-12-14 at 08:33 +0900, Jaehoon Chung wrote: > Hi Dinh, > > According to DesignWare Spec, we need to check which bus-mode use. > You can refer to "https://patchwork.kernel.org/patch/1379521/";. > I know that hold_reg didn't use always, although hold_reg is set. Hi Jaehoon, Thanks for

[PATCH] mmc: mmci: Add new VE MMCI variant

2012-12-14 Thread Pawel Moll
The Versatile Express IOFPGA as shipped on VECD 5.0 (bitfiles v108/208 and v116/216) contains a modified version of the PL180 MMCI, with PeriphID Configuration value changed to 0x2. This version adds an optional "hardware flow control" feature. When enabled MMC card clock will be automatically dis

Re: [PATCH 0/3] mmc: Signal voltage switch procedure for UHS mode (sdhci)

2012-12-14 Thread Kevin Liu
2012/12/14 Johan Rudholm : > Hi Kevin and Ulf, > > 2012/12/14 Kevin Liu : >> 2012/12/14 Ulf Hansson : >>> Hi Kevin, >>> >>> Thanks for looking into this for SDHCI. >>> >>> On 14 December 2012 11:53, Kevin Liu wrote: This patchset is based on Johan's below patch series submitted recently:

Re: [PATCH 3/3] mmc: sdhci: update signal voltage switch code

2012-12-14 Thread Kevin Liu
2012/12/14 Johan Rudholm : > Hi Kevin, > > 2012/12/14 Kevin Liu : >> The protocal related code is moved to core stack. So update the host >> driver accordingly. >> >> Signed-off-by: Kevin Liu >> --- >> drivers/mmc/host/sdhci.c | 188 >> +++--- >> 1 files

Re: [PATCH 1/3] mmc: core: enhance the code for signal voltage setting

2012-12-14 Thread Kevin Liu
2012/12/14 Ulf Hansson : > On 14 December 2012 11:53, Kevin Liu wrote: >> 1. if host does NOT implement signal voltage setting function, >> should return error. >> 2. add the check for data signal before voltage change according >> to the spec. If host does NOT detect a low signal level, the host

Re: [PATCH 0/3] mmc: Signal voltage switch procedure for UHS mode (sdhci)

2012-12-14 Thread Johan Rudholm
Hi Kevin and Ulf, 2012/12/14 Kevin Liu : > 2012/12/14 Ulf Hansson : >> Hi Kevin, >> >> Thanks for looking into this for SDHCI. >> >> On 14 December 2012 11:53, Kevin Liu wrote: >>> >>> This patchset is based on Johan's below patch series submitted recently: >>> mmc: core: Add mmc_power_cycle >>

Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2012-12-14 Thread Russell King - ARM Linux
On Fri, Dec 14, 2012 at 03:30:29PM +0100, Ulf Hansson wrote: > From: Lee Jones > > There are currently two instances of the ios_handler being used. > Both of which mearly toy with some regulator settings. Now there > is a GPIO regulator API, we can use that instead, and lessen the > per platform

Re: [PATCH 0/3] mmc: Signal voltage switch procedure for UHS mode (sdhci)

2012-12-14 Thread Kevin Liu
2012/12/14 Ulf Hansson : > Hi Kevin, > > Thanks for looking into this for SDHCI. > > On 14 December 2012 11:53, Kevin Liu wrote: >> >> This patchset is based on Johan's below patch series submitted recently: >> mmc: core: Add mmc_power_cycle >> mmc: core: Add card_busy to host_ops >> mmc: co

Re: [PATCH 3/3] mmc: sdhci: update signal voltage switch code

2012-12-14 Thread Johan Rudholm
Hi Kevin, 2012/12/14 Kevin Liu : > The protocal related code is moved to core stack. So update the host > driver accordingly. > > Signed-off-by: Kevin Liu > --- > drivers/mmc/host/sdhci.c | 188 > +++--- > 1 files changed, 77 insertions(+), 111 deletions

[PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2012-12-14 Thread Ulf Hansson
From: Lee Jones There are currently two instances of the ios_handler being used. Both of which mearly toy with some regulator settings. Now there is a GPIO regulator API, we can use that instead, and lessen the per platform burden. By doing this, we also become more Device Tree compatible. Cc: C

[PATCH 1/2] mmc: mmci: Convert to use mmc_regulator_get_supply

2012-12-14 Thread Ulf Hansson
From: Ulf Hansson By using the mmc_regulator_get_supply API we are able to do some cleanups of the regulator code. Additionally let the regulator API handle the error printing. Cc: Chris Ball Cc: Russell King Signed-off-by: Ulf Hansson --- drivers/mmc/host/mmci.c | 54 ++---

[PATCH 0/2] mmc: mmci: Update regulator support

2012-12-14 Thread Ulf Hansson
From: Ulf Hansson In this patchset the mmci driver is converted to use the new mmc_regulator_get_supply API for handling regulators and OCR mask. On top of that we are taking the first step of moving away from using the platform callback, ios_handler, to be more DT compliant. Lee Jones (1): m

Re: [PATCH 1/3] mmc: core: enhance the code for signal voltage setting

2012-12-14 Thread Ulf Hansson
On 14 December 2012 14:40, Ulf Hansson wrote: > On 14 December 2012 11:53, Kevin Liu wrote: >> 1. if host does NOT implement signal voltage setting function, >> should return error. >> 2. add the check for data signal before voltage change according >> to the spec. If host does NOT detect a low s

Re: [PATCH 2/3] mmc: core: cycle power the card in voltage switch rather than mmc_sd_get_cid

2012-12-14 Thread Ulf Hansson
On 14 December 2012 11:53, Kevin Liu wrote: > Cycle power the card is a MUST step when voltage switch sequence failed. > So move this operation to function mmc_set_signal_voltage. > > Signed-off-by: Kevin Liu > --- > drivers/mmc/core/sd.c | 16 +--- > 1 files changed, 5 insertions(

Re: [PATCH 1/3] mmc: core: enhance the code for signal voltage setting

2012-12-14 Thread Ulf Hansson
On 14 December 2012 11:53, Kevin Liu wrote: > 1. if host does NOT implement signal voltage setting function, > should return error. > 2. add the check for data signal before voltage change according > to the spec. If host does NOT detect a low signal level, the host > should abort the voltage swit

Re: [PATCH 0/3] mmc: Signal voltage switch procedure for UHS mode (sdhci)

2012-12-14 Thread Ulf Hansson
Hi Kevin, Thanks for looking into this for SDHCI. On 14 December 2012 11:53, Kevin Liu wrote: > > This patchset is based on Johan's below patch series submitted recently: > mmc: core: Add mmc_power_cycle > mmc: core: Add card_busy to host_ops > mmc: core: Fixup signal voltage switch > > Th

Re: [PATCH 3/3] mmc: core: Fixup signal voltage switch

2012-12-14 Thread Johan Rudholm
Hi Kevin, 2012/12/14 Kevin Liu : > > Just sent a patchset for sdhci based on your patch. Please help to review. > Tested with both UHS and non-UHS sd card on sdhci-pxav3 platform. Great! I'll get on it right away. Kind regards, Johan -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH 3/3] mmc: core: Fixup signal voltage switch

2012-12-14 Thread Kevin Liu
2012/12/14 Johan Rudholm : > Hi Subhash, > > 2012/12/11 Subhash Jadavani : >> On 12/10/2012 1:51 PM, Johan Rudholm wrote: >>> >>> 2012/12/8 Subhash Jadavani : On 12/7/2012 9:49 PM, Johan Rudholm wrote: > > When switching SD and SDIO cards from 3.3V to 1.8V signal levels, the >

[PATCH 3/3] mmc: sdhci: update signal voltage switch code

2012-12-14 Thread Kevin Liu
The protocal related code is moved to core stack. So update the host driver accordingly. Signed-off-by: Kevin Liu --- drivers/mmc/host/sdhci.c | 188 +++--- 1 files changed, 77 insertions(+), 111 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drive

[PATCH 2/3] mmc: core: cycle power the card in voltage switch rather than mmc_sd_get_cid

2012-12-14 Thread Kevin Liu
Cycle power the card is a MUST step when voltage switch sequence failed. So move this operation to function mmc_set_signal_voltage. Signed-off-by: Kevin Liu --- drivers/mmc/core/sd.c | 16 +--- 1 files changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/core/sd.c b/

[PATCH 0/3] mmc: Signal voltage switch procedure for UHS mode (sdhci)

2012-12-14 Thread Kevin Liu
This patchset is based on Johan's below patch series submitted recently: mmc: core: Add mmc_power_cycle mmc: core: Add card_busy to host_ops mmc: core: Fixup signal voltage switch This patchset mainly update sdhci.c to co-work with Johan's above patches. The first two patches are some updat

[PATCH 1/3] mmc: core: enhance the code for signal voltage setting

2012-12-14 Thread Kevin Liu
1. if host does NOT implement signal voltage setting function, should return error. 2. add the check for data signal before voltage change according to the spec. If host does NOT detect a low signal level, the host should abort the voltage switch sequence. (phisical layer spec 4.2.4.2(4)) 3. if vol

Re: [PATCH 3/3] mmc: core: Fixup signal voltage switch

2012-12-14 Thread Johan Rudholm
Hi Subhash, 2012/12/11 Subhash Jadavani : > On 12/10/2012 1:51 PM, Johan Rudholm wrote: >> >> 2012/12/8 Subhash Jadavani : >>> >>> On 12/7/2012 9:49 PM, Johan Rudholm wrote: When switching SD and SDIO cards from 3.3V to 1.8V signal levels, the clock should be gated for 5 ms during t

Re: [PATCH 0/3] Signal voltage switch procedure for UHS mode

2012-12-14 Thread Johan Rudholm
Hi Jackey, no, the cw1200 chip is a SDIO < 2.0 device. Kind regards, Johan 2012/12/14 Shen, Jackey : > Hi Johan, > > Is the SDIO WLAN chip (cw1200), you mentioned, SDIO 3.0 device with SDIO > interface? > > Thanks, > Jackey > > -Original Message- > From: linux-mmc-ow...@vger.kernel.org

RE: [PATCH 0/3] Signal voltage switch procedure for UHS mode

2012-12-14 Thread Shen, Jackey
Hi Johan, Is the SDIO WLAN chip (cw1200), you mentioned, SDIO 3.0 device with SDIO interface? Thanks, Jackey -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Johan Rudholm Sent: Saturday, December 08, 2012 12:20 AM To: linu