Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-24 Thread Ulf Hansson
Hi Zoran, On 23 September 2013 23:14, Zoran Markovic zoran.marko...@linaro.org wrote: Hi Ulf, I like the fact that wakeups are now quite simplified. A couple of comments below: By signaling the wakeup event for a time of 5 s for devices configured as wakeup capable, we likely will be

[PATCH 2/5] mmc:sdhc: Calculate timeout_clk from actual sd clock

2013-09-24 Thread Haijun Zhang
At 50 Mhz SD_CLK period, the max timeout value = 2^27 * SD_CLK period ~= 2.69 sec. When we has quirk SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK, the timeout_clk should be calculate according to the real clock run by card. Which is less than 50 MHz. So update the timeout clock when the clock was actually

[PATCH 1/5] mmc:core: Add restrictions for data transfer and card ease

2013-09-24 Thread Haijun Zhang
At 50 Mhz SD_CLK period, the max timeout value = 2^27 * SD_CLK period ~= 2.69 sec. If max_discard_to was not designed, for mmc card preferred erase size should be used, for sd card just return UINT_MAX. Also add limit for data transfer, Use max_discard_to as max data timeout value to avoid

[PATCH 5/5] mmc:esdhc: Avoid writting to power register

2013-09-24 Thread Haijun Zhang
eSDHC host don't have a standand power control register. Also eSDHC host which support spec 1.0 and spec 2.0 don't support voltage switch. So add this change avoid writing other bit of this register by mistake. Signed-off-by: Haijun Zhang haijun.zh...@freescale.com ---

[PATCH 3/5] mmc:esdhc: Update timeout clock according to actual clock

2013-09-24 Thread Haijun Zhang
At 50 Mhz SD_CLK period, the max timeout value = 2^27 * SD_CLK period ~= 2.69 sec. When we has quirk SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK, the timeout_clk should be calculate according to the real clock run by card. Which is less than 50 MHz. So update the timeout clock when the clock was actually

[PATCH 4/5] mmc:esdhc: Workaround about clock glitch issue on eSDHC host

2013-09-24 Thread Haijun Zhang
A-003980: SDHC: Glitch is generated on the card clock with software reset or clock divider change Description: A glitch may occur on the SDHC card clock when the software sets the RSTA bit (software reset) in the system control register. It can also be generated by setting the clock divider value.

Re: [PATCH V3] mmc:core: Avoid useless detecting task when card is busy

2013-09-24 Thread Ulf Hansson
Hi Haijun, On 24 September 2013 05:42, Zhang Haijun b42...@freescale.com wrote: Hi, Ulf I had update the patch according to your suggestion. I test on my platform during last night. About 200G random continuous data was written to 32G SDHC Card. No call trace was encountered. I think it

Re: [PATCH V3] mmc:core: Avoid useless detecting task when card is busy

2013-09-24 Thread Zhang Haijun
Hi, Ulf Kindly refer to my inline comment. 于 2013/9/24 16:41, Ulf Hansson 写道: Hi Haijun, On 24 September 2013 05:42, Zhang Haijun b42...@freescale.com wrote: Hi, Ulf I had update the patch according to your suggestion. I test on my platform during last night. About 200G random continuous

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-24 Thread Ulf Hansson
On 20 September 2013 11:48, Ulf Hansson ulf.hans...@linaro.org wrote: We want to give user space provision to fully consume a card insert/remove event, when the event was caused by a wakeup irq. By signaling the wakeup event for a time of 5 s for devices configured as wakeup capable, we

Re: [PATCH 1/3] mmc: mvsdio: Convert to devm_ioremap_resource

2013-09-24 Thread Sachin Kamat
On 12 September 2013 12:16, Sachin Kamat sachin.ka...@linaro.org wrote: devm_request_and_ioremap() is deprecated. Use devm_ioremap_resource() instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Gentle ping on this series Chris. -- With warm regards, Sachin -- To unsubscribe from

Re: [PATCH V3] mmc:core: Avoid useless detecting task when card is busy

2013-09-24 Thread Ulf Hansson
On 24 September 2013 11:57, Zhang Haijun b42...@freescale.com wrote: Hi, Ulf Kindly refer to my inline comment. 于 2013/9/24 16:41, Ulf Hansson 写道: Hi Haijun, On 24 September 2013 05:42, Zhang Haijun b42...@freescale.com wrote: Hi, Ulf I had update the patch according to your

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-24 Thread John Stultz
On 09/24/2013 12:55 AM, Ulf Hansson wrote: Hi Zoran, On 23 September 2013 23:14, Zoran Markovic zoran.marko...@linaro.org wrote: Hi Ulf, I like the fact that wakeups are now quite simplified. A couple of comments below: By signaling the wakeup event for a time of 5 s for devices configured

Re: [PATCH V3] mmc:core: Avoid useless detecting task when card is busy

2013-09-24 Thread Zhang Haijun
于 2013/9/24 20:55, Ulf Hansson 写道: On 24 September 2013 11:57, Zhang Haijun b42...@freescale.com wrote: Hi, Ulf Kindly refer to my inline comment. 于 2013/9/24 16:41, Ulf Hansson 写道: Hi Haijun, On 24 September 2013 05:42, Zhang Haijun b42...@freescale.com wrote: Hi, Ulf I had update

Re: [PATCH 2/3] mmc: dw_mmc-socfpga: Remove redundant of_match_ptr

2013-09-24 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 09/12/2013 03:46 PM, Sachin Kamat wrote: 'dw_mci_socfpga_match' is always compiled in. Hence of_match_ptr is not necessary. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/dw_mmc-socfpga.c |2 +- 1 file

Re: [PATCH 3/3] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe

2013-09-24 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 09/12/2013 03:46 PM, Sachin Kamat wrote: 'dw_mci_socfpga_probe' is used only in this file. Make it static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/dw_mmc-socfpga.c |2 +- 1 file changed, 1 insertion(+),

[PATCH v4] mmc:core: Avoid useless detecting task when card is busy

2013-09-24 Thread Haijun Zhang
When card is in cpu polling mode to detect card present. Card detecting task will be scheduled about once every second. When card is busy in large file transfer, detecting task will be hang and call trace will be prompt. When handling the request, CMD13 is always followed by every command when it

Re: [PATCH 1/2] mmc:sdhci-pci:Add O2Micor/BayHubTect PCI SD Host

2013-09-24 Thread reg Kroah-Hartman
On Wed, Sep 25, 2013 at 03:20:07AM +, Peter Guo wrote: --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -1700,6 +1700,11 @@ #define PCI_DEVICE_ID_O2_82210x8221 #define PCI_DEVICE_ID_O2_83200x8320 #define PCI_DEVICE_ID_O2_8321

[PATCH 1/2] mmc:sdhci-pci:Add O2Micor/BayHubTect PCI SD Host

2013-09-24 Thread Peter Guo
From: peter.guo peter@bayhubtech.com Add O2Micor/BayHubTect SD Host Controller PCI Devices IDs in pci_ids.h. Apply SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 for some SD Host Controller. Apply SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC for some SD Host Controller. Add O2Micro/BayHubTech SD Host Controller

[PATCH 2/2] mmc: sdhci: Fix CMD12 and Tuning issues

2013-09-24 Thread Peter Guo
From: peter.guo peter@bayhubtech.com - Change tuning_loop_counter check from not zero to less than zero in function sdhci_execute_tuning; Becasue some host may need 40 times tuning, but orginal code only think tuning times = 39 is successfull. - When Host Capability Reg (0x40) bit[43:40]

[PATCH 1/2] mmc:sdhci-pci:Add O2Micor/BayHubTect PCI SD Host

2013-09-24 Thread Peter Guo
From: peter.guo peter@bayhubtech.com Apply SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 for some SD Host Controller. Apply SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC for some SD Host Controller. Add O2Micro/BayHubTech SD Host Controller specified Init. Signed-off-by: peter.guo peter@bayhubtech.com ---