Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response

2014-08-14 Thread Roger Tseng
On Wed, 2014-08-13 at 17:09 +0200, Ulf Hansson wrote: On 11 August 2014 10:32, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com Current code erroneously fill the last byte of R2 response with an undefined value. In addition, it is impossible to obtain the real values

mmc-utils boot enable conflict with mmc_blk_part_switch

2014-08-14 Thread Matthieu CASTET
Hi, Boot enable setting is enable with writting PARTITION_CONFIG ext csd. But the kernel also write it in mmc_blk_part_switch. This lead to weird result : ~ # mmc_utils extcsd read /dev/mmcblk0 | grep PARTITION_CONFIG Boot configuration bytes [PARTITION_CONFIG: 0x00] ## no boot partition

Re: [PATCH v3] mmc: implement Driver Stage Register handling

2014-08-14 Thread Ulf Hansson
On 13 August 2014 17:44, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: From: Sascha Hauer s.ha...@pengutronix.de Some (e)MMC and SD cards implement a DSR register that allows to tune raise/fall times and drive strength of the CMD and DATA outputs. The values to use depend on the card

Re: [PATCH v3] mmc: implement Driver Stage Register handling

2014-08-14 Thread Uwe Kleine-König
Hello Ulf, On Thu, Aug 14, 2014 at 11:26:28AM +0200, Ulf Hansson wrote: On 13 August 2014 17:44, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: From: Sascha Hauer s.ha...@pengutronix.de Some (e)MMC and SD cards implement a DSR register that allows to tune raise/fall times and

[PATCH V2] mmc: core: try 1.8v signaling in ddr mode if host and device

2014-08-14 Thread Chuanxiao Dong
Even (e)MMC card can support 3.3v to 1.2v vccq in DDR, but not all host controller can support this, like some of the SDHCI host which connect to an eMMC device. Some of these host controller still needs to use 1.8v vccq for supporting DDR mode. So the sequence will be: if (host and device can

[PATCH] mmc: sdhci: check 1.2v IO capability for SDHC host

2014-08-14 Thread Chuanxiao Dong
Right now enable 1.2v IO voltage for SDHC is by using vqmmc. Thus for the host which doesn't have vqmmc, or its vqmmc does not support 1.2v, directly use MMC_CAP2_HS200 may cause HS200 failure. So needs to check if vqmmc is able to support 1.2v. If it does not support, disable 1.2v IO for HS200.

[PATCH] mmc: core: resolve divded by zero panic

2014-08-14 Thread Yunpeng Gao
From: Chuanxiao Dong chuanxiao.d...@intel.com With one special SD card, below divide by zero error observed: ... [2.144300] divide error: [#1] PREEMPT SMP [2.148860] Modules linked in: [2.151898] [2.152685] Set up 4031 stolen pages starting at 0x0001f000, GTT offset 0K [

Re: [PATCH v3] mmc: implement Driver Stage Register handling

2014-08-14 Thread Ulf Hansson
On 14 August 2014 11:49, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: Hello Ulf, On Thu, Aug 14, 2014 at 11:26:28AM +0200, Ulf Hansson wrote: On 13 August 2014 17:44, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: From: Sascha Hauer s.ha...@pengutronix.de Some (e)MMC

Re: [PATCH] mmc: check EXT_CSD_PARTITION_SETTING_COMPLETED before creating partitions

2014-08-14 Thread Ulf Hansson
On 13 August 2014 11:20, Grégory Soutadé gsout...@neotion.com wrote: Le 13/08/2014 10:36, Ulf Hansson a écrit : On 17 July 2014 16:57, Grégory Soutadé gsout...@neotion.com wrote: Create MMC general purpose partitions only if EXT_CSD_PARTITION_SETTING_COMPLETED bit is set. Some tools may set

Re: [PATCH V2] mmc: core: try 1.8v signaling in ddr mode if host and device

2014-08-14 Thread Ulf Hansson
On 14 August 2014 11:54, Chuanxiao Dong chuanxiao.d...@intel.com wrote: Even (e)MMC card can support 3.3v to 1.2v vccq in DDR, but not all host controller can support this, like some of the SDHCI host which connect to an eMMC device. Some of these host controller still needs to use 1.8v vccq

Re: [PATCH] mmc: dw_mmc: move rockchip related code to a separate file

2014-08-14 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday, August 14, 2014 04:01:33 PM Addy Ke wrote: To support HS200 and UHS-1, we need add a big hunk of code, as shown in the following patches. So a separate file for rockchip SOCs is suitable. Signed-off-by: Addy Ke addy...@rock-chips.com --- drivers/mmc/host/Kconfig

RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-14 Thread Alex Lemberg
Hi Ulf, -Original Message- From: Ulf Hansson [mailto:ulf.hans...@linaro.org] Sent: Wednesday, August 13, 2014 3:47 PM To: Avi Shchislowski; Grant Grundler; Alex Lemberg Cc: linux-mmc@vger.kernel.org; c...@laptop.org Subject: Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0 On

[PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-14 Thread Javier Martinez Canillas
The operation conditions register (OCR) stores the voltage profile of the card, however the list of possible voltages is restricted by the voltage range supported by the supply used as VCC/VDD. So in mmc_vddrange_to_ocrmask() a OCR mask is obtained to filter the not supported voltages, from the

Re: [PATCH] mmc: check EXT_CSD_PARTITION_SETTING_COMPLETED before creating partitions

2014-08-14 Thread Grégory Soutadé
Le 14/08/2014 13:46, Ulf Hansson a écrit : On 13 August 2014 11:20, Grégory Soutadé gsout...@neotion.com wrote: Le 13/08/2014 10:36, Ulf Hansson a écrit : On 17 July 2014 16:57, Grégory Soutadé gsout...@neotion.com wrote: Create MMC general purpose partitions only if

[PATCH 1/2] sdhci : handle busy timeout irq

2014-08-14 Thread Matthieu CASTET
When we wait for busy after sending a command, if there is a timeout, we got SDHCI_INT_DATA_TIMEOUT flags. Before this commit we got the message : Got data interrupt 0x0010 even though no data operation was in progress. and we need to wait 10s that sdhci_timeout_timer expires. Signed-off-by:

Re: [PATCH 2/4] mmc: slot-gpio: add gpiod variant to get wp GPIO

2014-08-14 Thread Alexandre Courbot
On Tue, Aug 12, 2014 at 10:25 AM, Linus Walleij linus.wall...@linaro.org wrote: This makes it possible to get the write protect (read only) GPIO line from a GPIO descriptor. Written to exactly mirror the card detect function. Acked-by: Alexandre Courbot acour...@nvidia.com -- To unsubscribe

Re: [PATCH 3/4] mmc: host: switch OF parser to use gpio descriptors

2014-08-14 Thread Alexandre Courbot
On Tue, Aug 12, 2014 at 10:25 AM, Linus Walleij linus.wall...@linaro.org wrote: This switches the central MMC OF parser to use gpio descriptors instead of grabbing GPIOs explicitly from the device tree. This strips out an unecessary use of the integer-based GPIO API that we want to get rid of,

Re: [PATCH 4/4] mmc: mmci: augment driver to handle gpio descriptors

2014-08-14 Thread Alexandre Courbot
On Tue, Aug 12, 2014 at 10:25 AM, Linus Walleij linus.wall...@linaro.org wrote: - /* If DT, cd/wp gpios must be supplied through it. */ - if (!np gpio_is_valid(plat-gpio_cd)) { - ret = mmc_gpio_request_cd(mmc, plat-gpio_cd, 0); - if (ret) -

Re: ARM: shmobile: Koelsch fails to resume due to sh_mobile_sdhi or regulator-fixed

2014-08-14 Thread Geert Uytterhoeven
On Tue, Aug 12, 2014 at 11:47 PM, Mark Brown broo...@kernel.org wrote: On Tue, Aug 12, 2014 at 04:28:39PM +0200, Geert Uytterhoeven wrote: r8a7791/Koelsch fails to resume from s2ram with CONFIG_REGULATOR_FIXED_VOLTAGE=y CONFIG_REGULATOR_GPIO=y CONFIG_MMC_SDHI=y Disabling

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-14 Thread Mark Brown
On Thu, Aug 14, 2014 at 07:13:00AM -0700, Tim Kryger wrote: On Thu, Aug 14, 2014 at 5:39 AM, Javier Martinez Canillas Without this patch, the following warning is reported when a FET is used as a vmmc-supply: dwmmc_exynos 1222.mmc: Failed getting OCR mask: -22 Signed-off-by: Javier

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-14 Thread Javier Martinez Canillas
Hello Tim, Thanks for your feedback. On 08/14/2014 04:13 PM, Tim Kryger wrote: https://lkml.org/lkml/2014/8/12/377 Perhaps I misunderstood the discussion in that thread but couldn't this failure also be addressed by adding proper constraints for each FET in individual DTS files to

[PATCH v2 1/2] mmc: dw_mmc: Add dependency on DMA

2014-08-14 Thread Andrew Bresticker
The dw_mmc drivers rely on the DMA API, so update the Kconfig entry to depend on HAS_DMA. Since the drivers should build on any platform with DMA, allow the driver to compile tested on non-ARC/ARM platforms. Signed-off-by: Andrew Bresticker abres...@chromium.org --- drivers/mmc/host/Kconfig | 3

[PATCH v2 2/2] mmc: dw_mmc: Add support for MIPS

2014-08-14 Thread Andrew Bresticker
There are upcoming MIPS SoCs with dw_mmc hosts. Signed-off-by: Andrew Bresticker abres...@chromium.org --- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 385674b..6acc2ab 100644 ---

[PATCH v3] mmc: core: try 1.8v signling in ddr mode if host and device

2014-08-14 Thread Chuanxiao Dong
Even (e)MMC card can support 3.3v to 1.2v vccq in DDR, but not all host controller can support this, like some of the SDHCI host which connect to an eMMC device. Some of these host controller still needs to use 1.8v vccq for supporting DDR mode. So the sequence will be: if (host and device can

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-14 Thread Tim Kryger
On Thu, Aug 14, 2014 at 8:19 AM, Mark Brown broo...@kernel.org wrote: Right, there's two things going on here. One is that as you describe we shouldn't be putting constraints in .dtsi files if we don't know they're OK for a given board. The other thing is that on this particular board it