Re: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread T Krishnamoorthy, Balaji
On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: HSMMC IP on AM33xx need a special setting to handle High-speed cards. Other platforms like TI81xx, OMAP4 may need this as-well. This depends on the HSMMC IP timing closure done for the high speed cards. From AM335x

Re: [PATCH 2/2] mmc: omap_hsmmc: cleanup the bitmap definitions of Interrupt Register

2012-08-29 Thread T Krishnamoorthy, Balaji
On Tue, Aug 28, 2012 at 6:49 PM, Venkatraman S svenk...@ti.com wrote: Define the most frequently used bitmasks of the Interrupt Enable / Interrupt Status register with consistent naming ( with _EN suffix). Use meaningful concatenation of bitfields for INT_EN_MASK, which shows which interrupts

Re: [PATCH 07/10] mmc: omap_hsmmc: consolidate flush posted writes for HSMMC IRQs

2012-08-21 Thread T Krishnamoorthy, Balaji
On Sat, Aug 18, 2012 at 12:22 AM, Venkatraman S svenk...@ti.com wrote: Flushing spurious IRQs from HSMMC IP is done twice in omap_hsmmc_irq and omap_hsmmc_do_irq. spurious IRQ is flushed in start of omap_hsmmc_do_irq and irq acked at the end of omap_hsmmc_do_irq Consolidate them to one

Re: [RFC PATCH] Revert mmc: omap_hsmmc: Enable Auto CMD12

2012-06-26 Thread T Krishnamoorthy, Balaji
On Fri, Jun 22, 2012 at 9:05 PM, Ming Lei ming@canonical.com wrote: On Fri, Jun 22, 2012 at 11:13 PM, T Krishnamoorthy, Balaji balaj...@ti.com wrote: I tested autocmd12 to be working on OMAP2,3,4 SDP. With beagle board data corruption is observed with some cards, so it is going

Re: [RFC PATCH] Revert mmc: omap_hsmmc: Enable Auto CMD12

2012-06-26 Thread T Krishnamoorthy, Balaji
On Fri, Jun 22, 2012 at 9:09 PM, Chris Ball c...@laptop.org wrote: Hi, On Fri, Jun 22 2012, T Krishnamoorthy, Balaji wrote: After bisecting, this commit dba3c29 is found to ruin micro-SD card data (writing incorrect file, or fs is corrupt after several times mount) on the beagle-xm revB

Re: [RFC PATCH] Revert mmc: omap_hsmmc: Enable Auto CMD12

2012-06-22 Thread T Krishnamoorthy, Balaji
On Fri, Jun 22, 2012 at 4:19 PM, Ming Lei ming@canonical.com wrote: This patch reverts the commit dba3c29ea4a1d5d544. After bisecting, this commit dba3c29 is found to ruin micro-SD card data (writing incorrect file, or fs is corrupt after several times mount) on the beagle-xm revB, and

Re: MMC: commit dba3c29 ruins mmc card data on beagle-xm revB

2012-06-22 Thread T Krishnamoorthy, Balaji
On Fri, Jun 22, 2012 at 5:21 PM, Paolo Pisati p.pis...@gmail.com wrote: On 06/20/2012 09:23 AM, T Krishnamoorthy, Balaji wrote: i just want to say that i'm affected by this too, and i can reproduce it 100%. Is it with SD or MMC card Can you provide Beagle board rev info? kingston 4g

Re: MMC: commit dba3c29 ruins mmc card data on beagle-xm revB

2012-06-20 Thread T Krishnamoorthy, Balaji
On Tue, Jun 19, 2012 at 10:23 PM, Paolo Pisati p.pis...@gmail.com wrote: On 06/13/2012 05:28 PM, T Krishnamoorthy, Balaji wrote: On Mon, Jun 11, 2012 at 12:50 PM, Ming Lei ming@canonical.com wrote: On Mon, Jun 11, 2012 at 2:21 PM, T Krishnamoorthy, Balaji balaj...@ti.com wrote: Hi Ming

Re: [RFC 00/12] OMAP DMA engine conversion

2012-05-09 Thread T Krishnamoorthy, Balaji
On Mon, Apr 23, 2012 at 9:34 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: For the full text, please see http://lists.arm.linux.org.uk/lurker/message/20120418.100954.7fa7acf8.en.html This version contains updates for some of the comments received from the previous round, and

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread T Krishnamoorthy, Balaji
On Wed, Apr 18, 2012 at 3:42 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: DMAengine uses the DMA engine device structure when mapping/unmapping memory for DMA, so the MMC devices do not need their DMA masks initialized (this reflects hardware: the MMC device is not the device doing

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread T Krishnamoorthy, Balaji
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: Hi, drivers/mmc/host/omap.c is also using dma_mask should that also be removed Does this driver make use of this platform data

Re: [PATCH] mmc: omap_hsmmc: Fix check for mmc dt node

2012-04-17 Thread T Krishnamoorthy, Balaji
On Tue, Apr 17, 2012 at 3:24 PM, Jassi Brar jaswinder.si...@linaro.org wrote: Proper check should be if the hsmmc driver got its platform_data via devicetree, and not if the devicetree is populated for the platform. Signed-off-by: Jassi Brar jaswinder.si...@linaro.org Hi, Similar patch by

Re: [PATCH v2] mmc: core: eMMC in Sleep mode before suspend

2012-04-12 Thread T Krishnamoorthy, Balaji
On Thu, Apr 12, 2012 at 9:54 AM, Chris Ball c...@laptop.org wrote: Hi, On Thu, Sep 08 2011, Balaji T K wrote: Put MMC to sleep if it supports SLEEP/AWAKE (CMD5) in the mmc suspend so that Vcc (NAND core) can be cut to minimize power consumption. eMMC put into SLEEP can respond to CMD0 or

Re: [PATCH] mmc: omap_hsmmc: Get rid of of_have_populated_dt() usage

2012-04-11 Thread T Krishnamoorthy, Balaji
On Wed, Apr 11, 2012 at 3:33 PM, Rajendra Nayak rna...@ti.com wrote: of_have_populated_dt() is not expected to be used in drivers but instead only in early platform init code. Drivers on the other hand should rely on dev-of_node or of_match_device(). Besides usage of of_have_populated_dt()

Re: [PATCH RESEND 4/8] mmc: omap: context save after enabling runtime pm

2012-03-16 Thread T Krishnamoorthy, Balaji
On Thu, Mar 15, 2012 at 8:42 PM, Shubhrajyoti shubhrajy...@ti.com wrote: On Thursday 15 March 2012 08:03 PM, Venkatraman S wrote: From: Balaji T K balaj...@ti.com call context save api after enabling runtime pm to make sure register access in context save api If I am not mistaken  the api  

Re: [PATCH v2 0/4] omap hsmmc device tree support

2012-03-13 Thread T Krishnamoorthy, Balaji
On Mon, Mar 12, 2012 at 8:32 PM, Rajendra Nayak rna...@ti.com wrote: The series adds device tree support for OMAP hsmmc driver. Changes in V2: -1- Minor fixes based on comments from Grant. -2- Added a seperate compatible for omap3. -3- Added a new binding ti,needs-special-reset to handle

Re: [PATCH 4/4] mmc: omap_hsmmc: Simplify init for twl6030 MMC card detect

2012-03-08 Thread T Krishnamoorthy, Balaji
On Wed, Mar 7, 2012 at 9:12 PM, Chris Ball c...@laptop.org wrote: Hi Balaji, On Wed, Mar 07 2012, T Krishnamoorthy, Balaji wrote: OMAP4 and OMAP3 HSMMC IP registers differ by 0x100 offset. Addng the offset to platform_device resource structure increments the start address for every insmod

Re: [PATCH 4/4] mmc: omap_hsmmc: Simplify init for twl6030 MMC card detect

2012-03-07 Thread T Krishnamoorthy, Balaji
On Mon, Mar 5, 2012 at 3:55 PM, T Krishnamoorthy, Balaji balaj...@ti.com wrote: On Mon, Mar 5, 2012 at 2:46 PM, Rajendra Nayak rna...@ti.com wrote: On Friday 02 March 2012 10:52 PM, Tony Lindgren wrote: BTW, with -rc5, looks like re-inserting omap_hsmmc on omap4 fails to detect any cards

Re: [PATCH 4/4] mmc: omap_hsmmc: Simplify init for twl6030 MMC card detect

2012-03-05 Thread T Krishnamoorthy, Balaji
On Mon, Mar 5, 2012 at 2:46 PM, Rajendra Nayak rna...@ti.com wrote: On Friday 02 March 2012 10:52 PM, Tony Lindgren wrote: BTW, with -rc5, looks like re-inserting omap_hsmmc on omap4 fails to detect any cards, and then fails to unload. This works on omap3 just fine. Any ideas why that would

Re: [PATCH v2 3/4] arm/dts: OMAP4: Add mmc controller nodes and board data

2012-02-24 Thread T Krishnamoorthy, Balaji
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 29f4589..9204f60 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot/dts/omap4.dtsi @@ -25,6 +25,11 @@                serial1 = uart2;                serial2 = uart3;                serial3 = uart4; +

Re: [PATCH v2 3/4] arm/dts: OMAP4: Add mmc controller nodes and board data

2012-02-24 Thread T Krishnamoorthy, Balaji
On Fri, Feb 24, 2012 at 3:56 PM, Rajendra Nayak rna...@ti.com wrote: On Friday 24 February 2012 03:46 PM, T Krishnamoorthy, Balaji wrote: diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 29f4589..9204f60 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm

Re: [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree

2012-02-24 Thread T Krishnamoorthy, Balaji
On Thu, Feb 23, 2012 at 5:31 PM, Rajendra Nayak rna...@ti.com wrote: Define dt bindings for the ti-omap-hsmmc, and adapt the driver to extract data (which was earlier passed as platform_data) from device tree. Signed-off-by: Rajendra Nayak rna...@ti.com ---  

Re: [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev-id

2012-02-10 Thread T Krishnamoorthy, Balaji
On Tue, Feb 7, 2012 at 3:32 PM, S, Venkatraman svenk...@ti.com wrote: On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak rna...@ti.com wrote: This series mainly cleans up all instances of hardcoding's in the driver based on pdev-id. This is cleanup leading to the DT adaptation of omap_hsmmc

Re: omap_hsmmc noisy/broken for suspend resume

2011-11-04 Thread T Krishnamoorthy, Balaji
On Fri, Nov 4, 2011 at 2:54 AM, Kevin Hilman khil...@ti.com wrote: Hello, Using Linus' master branch, I was testing PM functionality on OMAP3/4 and noticed that the MMC driver is now rather noisy during suspend on OMAP3[1], but seems to work. On OMAP4, MMC seems to prevent suspend/resume

Re: [PATCH 1/2] arm: omap4: hsmmc: Fix Pbias configuration on regulator OFF

2011-09-30 Thread T Krishnamoorthy, Balaji
On Thu, Sep 29, 2011 at 9:50 PM, Tony Lindgren t...@atomide.com wrote: * Balaji T K balaj...@ti.com [110929 07:11]: MMC1 data line IO's are powered down in before set regulator function. IO's should not be powered ON when regulator is OFF. Keep the IO's in power pown mode after regulator OFF.

Re: [PATCH V2 11/16] mmc: omap_hsmmc: ensure pbias configuration is always done

2011-09-29 Thread T Krishnamoorthy, Balaji
On Fri, May 6, 2011 at 2:44 PM, Adrian Hunter adrian.hun...@nokia.com wrote: Go through the driver's set_power() functions rather than calling regulator_enable/disable() directly because otherwise pbias configuration for MMC1 is not done. Hi Chris, Are you OK to queue this patch as bug fix.

Re: [PATCH 0/2] arm: omap4: hsmmc: pbias fixes

2011-09-29 Thread T Krishnamoorthy, Balaji
From: Balaji T K balaj...@ti.com Will resend this series as my email id is garbled. MMC1 pbias and speed control fix for SDMMC1 extended I/O cell Balaji T K (2):  arm: omap4: hsmmc: Fix Pbias configuration on regulator OFF  arm: omap4: hsmmc: configure SDMMC1_DR0 properly  

Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1

2011-09-28 Thread T Krishnamoorthy, Balaji
Hi Tony, Can you queue this patch ? On Fri, Sep 9, 2011 at 7:34 PM, T Krishnamoorthy, Balaji balaj...@ti.com wrote: On Fri, Aug 12, 2011 at 8:43 PM, Buckley, Bryan bryan.buck...@ti.com wrote: On Fri, Jul 22, 2011 at 7:30 AM, Kishore Kadiyala kishorek.kadiy...@gmail.com wrote: On Fri, Jul 22

Re: [RFC/RFT] MMC: CORE: eMMC in Sleep mode before suspend

2011-09-08 Thread T Krishnamoorthy, Balaji
On Fri, Jul 22, 2011 at 1:42 AM, Adrian Hunter adrian.hun...@intel.com wrote: On 19/07/2011 7:48 p.m., Chris Ball wrote: Hi, On Tue, Jul 19 2011, S, Venkatraman wrote: On Wed, Jul 13, 2011 at 8:06 PM, Balaji T Kbalaj...@ti.com  wrote: Put MMC to sleep if it supports SLEEP/AWAKE (CMD5) in

Re: [PATCHv3 0/3] OMAP: HSMMC: cleanup and runtime pm

2011-07-01 Thread T Krishnamoorthy, Balaji
On Fri, Jul 1, 2011 at 1:06 AM, Cousson, Benoit b-cous...@ti.com wrote: Hi Balaji, On 6/30/2011 9:04 PM, Krishnamoorthy, Balaji T wrote: Removing the custom state machine - lazy disable framework in omap_hsmmc to make way for runtime pm to handle host controller power states. This allows

Re: [PATCHv3 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-07-01 Thread T Krishnamoorthy, Balaji
On Fri, Jul 1, 2011 at 4:53 AM, Kevin Hilman khil...@ti.com wrote: Balaji T K balaj...@ti.com writes: +static int omap_hsmmc_runtime_resume(struct device *dev) +{ +     struct omap_hsmmc_host *host; + +     host = platform_get_drvdata(to_platform_device(dev)); +    

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 12:11 AM, Paul Walmsley p...@pwsan.com wrote: On Tue, 28 Jun 2011, T Krishnamoorthy, Balaji wrote: On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 22 Jun 2011, Balaji T K wrote: Use runtime autosuspend APIs to enable auto suspend

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 8:12 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: On Wed, Jun 29, 2011 at 12:11 AM, Paul Walmsley p...@pwsan.com wrote: On Tue, 28 Jun 2011, T Krishnamoorthy, Balaji wrote: On Tue, Jun 28, 2011 at 10:52 PM, Paul

Re: [PATCHv2 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 11:26 PM, Kevin Hilman khil...@ti.com wrote: T Krishnamoorthy, Balaji balaj...@ti.com writes: On Wed, Jun 29, 2011 at 5:02 AM, Kevin Hilman khil...@ti.com wrote: +Rajendra Balaji T K balaj...@ti.com writes: add runtime pm support to HSMMC host controller Use

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-28 Thread T Krishnamoorthy, Balaji
On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley p...@pwsan.com wrote: (cc'ing Adrian also) Hi Balaji On Wed, 22 Jun 2011, Balaji T K wrote: Use runtime autosuspend APIs to enable auto suspend delay Does this really need to use runtime autosuspend?  Seems to me that since PM runtime is

Re: [PATCH 3/3] MMC: OMAP: HSMMC: Remove unused iclk

2011-06-27 Thread T Krishnamoorthy, Balaji
On Wed, Jun 22, 2011 at 9:57 PM, Cousson, Benoit b-cous...@ti.com wrote: On 6/22/2011 4:18 PM, Krishnamoorthy, Balaji T wrote: After runtime conversion to handle clk, iclk node is not used However fclk node is still used to get clock rate. Signed-off-by: Balaji T Kbalaj...@ti.com ---  

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-23 Thread T Krishnamoorthy, Balaji
On Thu, Jun 23, 2011 at 12:08 AM, Kevin Hilman khil...@ti.com wrote: Balaji T K balaj...@ti.com writes: @@ -1880,18 +1873,12 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)       mmc-caps |= MMC_CAP_DISABLE; -     if (clk_enable(host-iclk) != 0) { -            

Re: [PATCH 1/3] MMC: OMAP: HSMMC: Remove lazy_disable

2011-06-23 Thread T Krishnamoorthy, Balaji
On Wed, Jun 22, 2011 at 11:56 PM, Kevin Hilman khil...@ti.com wrote: Balaji T K balaj...@ti.com writes: lazy_disable framework in OMAP HSMMC manages multiple low power states and Card is powered off after inactivity time of 8 seconds. Based on previous discussion on the list Card

Re: [PATCH] omap: hsmmc: fix ocr mask usage

2011-05-26 Thread T Krishnamoorthy, Balaji
On Mon, Feb 21, 2011 at 9:40 PM, Kishore Kadiyala kishorek.kadiy...@gmail.com wrote: On Mon, Feb 21, 2011 at 11:37 AM, Anand Gadiyar gadi...@ti.com wrote: The OMAP HSMMC driver uses an ocr_mask to determine the list of voltages supported by the card. It populates this mask based on the list of