On Tuesday 15 September 2015 05:58 PM, Ulf Hansson wrote:
On 7 September 2015 at 13:31, Vaibhav Hiremath
wrote:
Trivial patch-series, which fixes the tabbing issue in the driver,
uses the BIT macro for bit fields and prints notice on -EPROBE_DEFER
in sdhci_add_host() function on regulator
On Monday 14 September 2015 06:19 PM, Russell King - ARM Linux wrote:
On Mon, Sep 14, 2015 at 06:03:40PM +0530, Vaibhav Hiremath wrote:
On Monday 14 September 2015 04:20 PM, Russell King - ARM Linux wrote:
On Mon, Sep 14, 2015 at 03:45:43PM +0530, Vaibhav Hiremath wrote:
Came across below
On Monday 14 September 2015 06:11 PM, Vaibhav Hiremath wrote:
On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote:
On 14 September 2015 at 11:42, Vaibhav Hiremath
wrote:
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote:
[...]
Could this be implemented by regulator API
On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote:
On 14 September 2015 at 11:42, Vaibhav Hiremath
wrote:
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote:
[...]
Could this be implemented by regulator API? From patch set 3/3, the
pxa1928
voltage_switch hook is to operate
On Monday 14 September 2015 04:20 PM, Russell King - ARM Linux wrote:
On Mon, Sep 14, 2015 at 03:45:43PM +0530, Vaibhav Hiremath wrote:
Came across below lines in the datasheet,
= Copy-n-paste from datasheet
All SDH interfaces share the same clock which is enabled when
On Monday 14 September 2015 02:49 PM, Vaibhav Hiremath wrote:
On Monday 14 September 2015 01:48 PM, Jisheng Zhang wrote:
On Mon, 14 Sep 2015 13:43:32 +0530
Vaibhav Hiremath wrote:
On Monday 14 September 2015 11:58 AM, Jisheng Zhang wrote:
On Mon, 14 Sep 2015 11:55:56 +0530
Vaibhav
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote:
[...]
Could this be implemented by regulator API? From patch set 3/3, the
pxa1928
voltage_switch hook is to operate the IO pad registers, this seems not
belong
to the SDHC IP core.
Not quite sure whether regulator would be right fit
On Monday 14 September 2015 01:48 PM, Jisheng Zhang wrote:
On Mon, 14 Sep 2015 13:43:32 +0530
Vaibhav Hiremath wrote:
On Monday 14 September 2015 11:58 AM, Jisheng Zhang wrote:
On Mon, 14 Sep 2015 11:55:56 +0530
Vaibhav Hiremath wrote:
On Thursday 10 September 2015 01:34 PM, Jisheng
On Monday 14 September 2015 11:58 AM, Jisheng Zhang wrote:
On Mon, 14 Sep 2015 11:55:56 +0530
Vaibhav Hiremath wrote:
On Thursday 10 September 2015 01:34 PM, Jisheng Zhang wrote:
Hi Russell,
On Thu, 10 Sep 2015 09:02:33 +0100
Russell King - ARM Linux wrote:
On Thu, Sep 10, 2015 at 03
On Thursday 10 September 2015 01:34 PM, Jisheng Zhang wrote:
Hi Russell,
On Thu, 10 Sep 2015 09:02:33 +0100
Russell King - ARM Linux wrote:
On Thu, Sep 10, 2015 at 03:31:29PM +0800, Jisheng Zhang wrote:
Hi Vaibhav,
On Thu, 10 Sep 2015 12:40:48 +0530
Vaibhav Hiremath wrote:
Hi,
During
On Thursday 10 September 2015 01:01 PM, Jisheng Zhang wrote:
Hi Vaibhav,
On Thu, 10 Sep 2015 12:40:48 +0530
Vaibhav Hiremath wrote:
Hi,
During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928
based platform, I observed that runtime PM suspend/resume is having
issues with
Hi,
During my testing of SDHCI-PXAV3 driver on Marvell's pxa1928
based platform, I observed that runtime PM suspend/resume is having
issues with card insertion and removal.
Let me try to explain it using execution sequence -
During boot:
MMC SD card gets detected as expected.
[2.431012] m
On Wednesday 09 September 2015 05:19 AM, Rob Herring wrote:
On 09/07/2015 06:18 AM, Vaibhav Hiremath wrote:
With support for pxa1928 family of devices , this patch
updates the binding document with compatible property
of "marvell,pxav3-1928-sdhci".
Signed-off-by: Vaibha
On Tuesday 08 September 2015 08:12 PM, Linus Walleij wrote:
On Mon, Sep 7, 2015 at 1:18 PM, Vaibhav Hiremath
wrote:
Different bus clock may need different pin setting.
For example, fast bus clock like 208Mhz need pin drive fast
while slow bus clock prefer pin drive slow to guarantee
signal
On Tuesday 08 September 2015 03:34 PM, Jisheng Zhang wrote:
On Tue, 8 Sep 2015 15:32:34 +0530
Vaibhav Hiremath wrote:
On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote:
On Tue, 8 Sep 2015 15:04:41 +0530
Vaibhav Hiremath wrote:
static const struct sdhci_ops
On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote:
On Tue, 8 Sep 2015 15:04:41 +0530
Vaibhav Hiremath wrote:
On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:38 +0530
Vaibhav Hiremath wrote:
Different bus clock may need different pin
On Tuesday 08 September 2015 12:24 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:38 +0530
Vaibhav Hiremath wrote:
Different bus clock may need different pin setting.
For example, fast bus clock like 208Mhz need pin drive fast
while slow bus clock prefer pin drive slow to guarantee
On Tuesday 08 September 2015 12:23 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:39 +0530
Vaibhav Hiremath wrote:
From: Kevin Liu
IN case of MMC HS200 mode, current code does not enable
SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations.
So this patch updates the a
On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:38 +0530
Vaibhav Hiremath wrote:
Different bus clock may need different pin setting.
For example, fast bus clock like 208Mhz need pin drive fast
while slow bus clock prefer pin drive slow to guarantee
On Monday 07 September 2015 05:26 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 17:01:09 +0530
Vaibhav Hiremath wrote:
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc...
This patch fixes all such occurrences in the code.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 46
This patch adds kernel notice/message to sdhci_host_add() fn on
-EPROBE_DEFER.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 1dbe932..37a5cd5 100644
Instead of using shift operation use BIT macro for bit field
definitions.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 7a07177
age patch into new one.
- changed error to kernel notice for EPROBE_DEFER in sdhci_add_host()
Note: This patch-series should get merged before another series -
[PATCH-v2 0/7] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller
Vaibhav Hiremath (3):
mmc: sdhci-pxav3: Fix tabbing is
With support for pxa1928 family of devices , this patch
updates the binding document with compatible property
of "marvell,pxav3-1928-sdhci".
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings/mmc/sdhci-pxa.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
more differences, which would be added
as and when respective feature gets added to the driver.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 62 ++
1 file changed, 51 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci
controller/platform
specific clock configuration needs to be executed.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 46 +-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdh
speed.
And selection of pin state is done based on timing mode.
Signed-off-by: Vaibhav Hiremath
Signed-off-by: Kevin Liu
---
drivers/mmc/host/sdhci-pxav3.c | 45 +-
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3
quirk (SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER),
which make sure that ->set_power() sets these fields.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pltfm.c | 3 +++
drivers/mmc/host/sdhci.c | 3 ++-
drivers/mmc/host/sdhci.h | 2 ++
3 files changed, 7 insertions(+), 1 deletion(
Card power is dependent on bus power, without that card
wouldn't respond (No CARD_INT). So this patch enables the
quirk SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pltfm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
From: Kevin Liu
IN case of MMC HS200 mode, current code does not enable
SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations.
So this patch updates the above bit fields correctly.
Signed-off-by: Tim Wang
Signed-off-by: Kevin Liu
Signed-off-by: Vaibhav Hiremath
---
ix HS200 mode support
Vaibhav Hiremath (6):
mmc: sdhci-pxav3: Enable pxa1928 device support
mmc: sdhci-pxav3: binding: Add pxa1928 compatible support
mmc: sdhci-pxav3: Add platform specific set_clock ops
mmc: sdhci-pxav3: Add pinctl setting according to bus clock
mmc: sdhci: add new quir
On Friday 04 September 2015 09:02 PM, Vaibhav Hiremath wrote:
PXA1928 SDHCI controller has few differences, for example,
PXAxxxPXA1928
=====
SDCLK_DELAY field 0x10A
more differences, which would be added
as and when respective feature gets added to the driver.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 62 ++
1 file changed, 51 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci
From: Kevin Liu
IN case of MMC HS200 mode, current code does not enable
SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations.
So this patch updates the above bit fields correctly.
Signed-off-by: Tim Wang
Signed-off-by: Kevin Liu
Signed-off-by: Vaibhav Hiremath
---
controller/platform
specific clock configuration needs to be executed.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 46 +-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdh
speed.
And selection of pin state is done based on timing mode.
Signed-off-by: Vaibhav Hiremath
Signed-off-by: Kevin Liu
---
drivers/mmc/host/sdhci-pxav3.c | 45 +-
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3
quirk (SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER),
which make sure that ->set_power() sets these fields.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pltfm.c | 3 +++
drivers/mmc/host/sdhci.c | 3 ++-
drivers/mmc/host/sdhci.h | 2 ++
3 files changed, 7 insertions(+), 1 deletion(
(1):
mmc: sdhci-pxav3: Fix HS200 mode support
Vaibhav Hiremath (4):
mmc: sdhci-pxav3: Enable pxa1928 device support
mmc: sdhci-pxav3: Add platform specific set_clock ops
mmc: sdhci-pxav3: Add pinctl setting according to bus clock
mmc: sdhci: add new quirk for setting BUS_POWER &
On Wednesday 02 September 2015 07:21 PM, Shawn Lin wrote:
On 2015/9/2 3:32, Vaibhav Hiremath wrote:
In case PXA1928 family of devices, there is device/controller specific
configuration to control voltage/power on the IO pins.
This patch implements and enables the sdhci_ops->voltage_swi
On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote:
On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote:
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
Return value would give clear information about the
On Wednesday 02 September 2015 07:21 PM, Shawn Lin wrote:
On 2015/9/2 3:32, Vaibhav Hiremath wrote:
In case PXA1928 family of devices, there is device/controller specific
configuration to control voltage/power on the IO pins.
This patch implements and enables the sdhci_ops->voltage_swi
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
Return value would give clear information about the actual root-cause
of the failure.
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
@@ -455,7
On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote:
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc
On Wednesday 02 September 2015 01:56 PM, Jisheng Zhang wrote:
On Wed, 2 Sep 2015 13:49:53 +0530
Vaibhav Hiremath wrote:
On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote:
On Wed, 2 Sep 2015 01:02:17 +0530
Vaibhav Hiremath wrote:
Currently, the
On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote:
On Wed, 2 Sep 2015 01:02:17 +0530
Vaibhav Hiremath wrote:
Currently, the sdhci_do_start_signal_voltage_switch() function invokes
controller specific voltage switch configuration only for 1.8v usecase;
but it is required for
On Wednesday 02 September 2015 12:24 PM, Jisheng Zhang wrote:
On Wed, 2 Sep 2015 00:54:13 +0530
Vaibhav Hiremath wrote:
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
Return value would give clear information about the actual root-cause
of the failure.
I'm not sure why that is as nearly every error path in
sdhci_add_host emits a me
On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote:
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc
support (I/O domain power
control register).
Signed-off-by: Vaibhav Hiremath
---
Note:
Currently ->voltage_switch() callback is only supported
in f_sdh30 driver. And I am not sure on the dependency of execution
sequence for that device. I could have moved ->voltage_switch() call
at one common
<0xd401e81c 4>,
<0xd4015068 8>;
...
};
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 59 ++
1 file changed, 59 insertions(+)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci
l
at one common place (above/below), but was not quite sure about it.
So, replicated/duplicated the call for other voltages.
Vaibhav Hiremath (3):
mmc: sdhci: pass signal_voltage as an argument to voltage_switch
callback
mmc: sdhci: add host_ops->voltage_switch callback for all other
In order to do particular voltage specific configuration in
sdhci_ops->voltage_switch() callback function, we need to
pass respective voltage value as well.
So this patch adds an extra argument for signal voltage to the
callback function.
Signed-off-by: Vaibhav Hiremath
Signed-off-by: Kevin
Trivial patch-series, which fixes the tabbing issue in the driver
and second patch prints the return value from sdhci_add_host() function
Vaibhav Hiremath (2):
mmc: sdhci-pxav3: Fix tabbing issue
mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn
drivers/mmc/host/sdhci
Return value would give clear information about the actual root-cause
of the failure.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc...
This patch fixes all such occurrences in the code.
And also use BIT for bit definitions.
Signed-off-by: Vaibhav Hiremath
56 matches
Mail list logo
