RE: [PATCH 1/3i v6] MMC/SD: Add callback function to detect card

2013-03-22 Thread Huang Changming-R66093
: > >> >> Jerry, > >> >> > >> >> Function _mmc_detect_card_removed should only be called when card > >> >> insert/removal or i/o error occur unless POLLING is used(called > >> >> once per second). So it should _not_ impact performance much. > >> > [jerry] > >> > No, your understanding is wrong. >

RE: [PATCH 1/3i v6] MMC/SD: Add callback function to detect card

2013-03-22 Thread Huang Changming-R66093
> -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Kevin Liu > Sent: Friday, March 22, 2013 2:55 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball; Ulf Hansson > Subject: Re

RE: [PATCH 1/3i v6] MMC/SD: Add callback function to detect card

2013-03-21 Thread Huang Changming-R66093
with the tool Iozne (or FIO). I don't understand you "your commit message isn't reasonable", could you point it out? Best Regards Jerry Huang > -Original Message- > From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] > Sent: Friday, March 22, 2013 2:24 PM &g

RE: [PATCH 1/3i v6] MMC/SD: Add callback function to detect card

2013-03-21 Thread Huang Changming-R66093
;. Function "mmc_sd_detect", "mmc_sdio_detect" and "mmc_detect" will call this function to detect the card. > Thanks > Kevin > > > Best Regards > > Jerry Huang > > > > > >> -Original Message----- > >> Fr

RE: [PATCH 1/3i v6] MMC/SD: Add callback function to detect card

2013-03-21 Thread Huang Changming-R66093
test (fio or Iozone). Best Regards Jerry Huang > -Original Message- > From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] > Sent: Friday, March 22, 2013 1:44 PM > To: Huang Changming-R66093 > Cc: Ulf Hansson; linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PAT

RE: [PATCH 1/3i v6] MMC/SD: Add callback function to detect card

2013-03-20 Thread Huang Changming-R66093
rom: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Wednesday, March 20, 2013 5:29 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PATCH 1/3i v6] MMC/SD: Add callback function to detect card > > On 20 March 2013 10:04, Huang Changming-R66093

RE: [PATCH 1/3i v6] MMC/SD: Add callback function to detect card

2013-03-20 Thread Huang Changming-R66093
ade. Maybe Kevin can base on this patch. Best Regards Jerry Huang > -Original Message- > From: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Wednesday, March 20, 2013 4:43 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re:

RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

2012-11-25 Thread Huang Changming-R66093
ge- > From: kbuild test robot [mailto:fengguang...@intel.com] > Sent: Monday, November 26, 2012 7:14 AM > To: Zhang Haijun-B42677 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Chris Ball > Subject: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined &g

[PATCH] SDHC: support command with busy response expecting for TC

2012-11-23 Thread r66093
From: Jerry Huang The IP verions older than 2.3 didn't support the command with busy response which expect for TC bit set. But after the VVN2.3, eSDHC IP has supported it. Signed-off-by: Jerry Huang CC: Anton Vorontsov CC: Chris Ball --- drivers/mmc/host/sdhci-of-esdhc.c |3 +++ 1 file c

RE: [PATCH] mmc,sdio: advancing the setting of dev name in mmc_sdio_init_card()

2012-11-19 Thread Huang Changming-R66093
This is new version? Maybe you should add prefix v2 in subject and the version history. Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Chuansheng Liu > Sent: Tuesday, November 20, 2012 1:38 AM

[PATCH 3/3 v5] ESDHC: add callback esdhc_of_get_cd to detect card

2012-11-18 Thread r66093
From: Jerry Huang In order to check if the card is present, we will read the PRESENT STATE register and check the bit13(Card detect pin level) and bit15(CINS). Signed-off-by: Jerry Huang Reviewed-by: Anton Vorontsov CC: Chris Ball --- changes for v2: - add new callback for esdhc to de

[PATCH 2/3 v6] SDHCI: add sdhci_get_cd callback to detect the card

2012-11-18 Thread r66093
From: Jerry Huang Add callback function sdhci_get_cd to detect the card. And one new callback added to implement the card detect in sdhci struncture. If special platform has the card detect callback, it will return the card state, the value zero is for absent cardi and one is for present card. If

[PATCH 1/3 v5] MMC/SD: Add callback function to detect card

2012-11-18 Thread r66093
From: Jerry Huang In order to check whether the card has been removed, the function mmc_send_status() will send command CMD13 to card and ask the card to send its status register to sdhc driver, which will generate many interrupts repeatedly and make the system performance bad. Therefore, add ca

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-11-18 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Anton Vorontsov > Sent: Monday, November 19, 2012 11:31 AM > To: Huang Changming-R66093 > Cc: Chris Ball; linux-mmc@vger.ke

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-11-18 Thread Huang Changming-R66093
> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Monday, November 19, 2012 10:58 AM > To: Huang Changming-R66093 > Cc: Chris Ball; linux-mmc@vger.kernel.org > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect >

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-11-18 Thread Huang Changming-R66093
> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Monday, November 19, 2012 11:06 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Chris Ball > Subject: Re: [PATCH 2/4 v4] MMC/SD: Add callback

RE: [PATCH 4/4 v4] ESDHC: add callback esdhc_of_get_cd to detect card

2012-11-18 Thread Huang Changming-R66093
Hi, Anton, No any feedback since posted. Could you give some comment about it? Best Regards Jerry Huang > -Original Message- > From: Huang Changming-R66093 > Sent: Tuesday, October 30, 2012 4:13 PM > To: linux-mmc@vger.kernel.org > Cc: Huang Changming-R66093; Anton Voront

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-11-18 Thread Huang Changming-R66093
Anton, No any feedback since posted. Could you give some comment about it? Best Regards Jerry Huang > -Original Message- > From: Huang Changming-R66093 > Sent: Tuesday, October 30, 2012 4:13 PM > To: linux-mmc@vger.kernel.org > Cc: Huang Changming-R66093; Anton Voront

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-11-18 Thread Huang Changming-R66093
Hi, Anton and Chris This patch has been Reviewed-By: Johan Rudholm on Nov 05. Could you give some comment about it? Best Regards Jerry Huang > -Original Message- > From: Johan Rudholm [mailto:jrudh...@gmail.com] > Sent: Monday, November 05, 2012 10:08 PM > To: Huang Chan

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-11-12 Thread Huang Changming-R66093
Hi, Anton and Chris Have you any comment about this serial patches[patch 2/3/4, except 1]? Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Huang Changming-R66093 > Sent: Tuesday,

RE: [PATCH V4] Powerpc eSDHC Recover from the ADMA error

2012-11-12 Thread Huang Changming-R66093
; Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093 > Subject: Re: [PATCH V4] Powerpc eSDHC Recover from the ADMA error > > On Thu, Sep 20, 2012 at 10:19:23AM +0800, haijun.zh...@freescale.com > wrote: > > From: Haijun Zhang > > > > Signed-off-by: Haijun Zhang > >

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-11-05 Thread Huang Changming-R66093
t; To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Anton Vorontsov; Chris Ball > Subject: Re: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card > > Hi, > > 2012/11/5 Huang Changming-R66093 : > >> > >> 2012/11/2 Huang Changmi

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-11-05 Thread Huang Changming-R66093
Thanks a lot, Johan. Best Regards Jerry Huang > -Original Message- > From: Johan Rudholm [mailto:jrudh...@gmail.com] > Sent: Monday, November 05, 2012 10:08 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Anton Vorontsov; Chris Ball > Subject: Re: [PA

RE: [PATCH V4] Powerpc eSDHC Recover from the ADMA error

2012-11-05 Thread Huang Changming-R66093
-B42677 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093 > Subject: Re: [PATCH V4] Powerpc eSDHC Recover from the ADMA error > > On Thu, Sep 20, 2012 at 10:19:23AM +0800, haijun.zh...@freescale.com > wrote: > > From: Haijun Zhang > > > > Signed-off-by: Haijun

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-11-04 Thread Huang Changming-R66093
> > 2012/11/2 Huang Changming-R66093 : > > Hi, Johan, > > When quicks SDHCI_QUIRK_BROKEN_CARD_DETECTION is set, the driver will > poll the card status with the command CMD13 periodically, then many > interrupts will be generated, which affect the performance. > > O

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-11-01 Thread Huang Changming-R66093
Hi, Johan, When quicks SDHCI_QUIRK_BROKEN_CARD_DETECTION is set, the driver will poll the card status with the command CMD13 periodically, then many interrupts will be generated, which affect the performance. Yes, some cases to detect GPIO can't be trusted, so I only just implement this callbac

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-10-30 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] > Sent: Wednesday, October 31, 2012 12:29 PM > To: Huang Changming-R66093 > Cc: Girish K S; linux-mmc@vger.kernel.org; Anton Vorontsov; Chris Ball > Subject: Re: [PA

RE: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()

2012-10-30 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Wednesday, October 31, 2012 7:09 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Anton Vorontsov; > Chris Ball > Subje

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-10-30 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Girish K S > Sent: Tuesday, October 30, 2012 7:35 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huan

[PATCH 4/4 v4] ESDHC: add callback esdhc_of_get_cd to detect card

2012-10-30 Thread r66093
From: Jerry Huang In order to check if the card is present, we will read the PRESENT STATE register and check the bit13(Card detect pin level) and bit15(CINS). Signed-off-by: Jerry Huang CC: Anton Vorontsov CC: Chris Ball --- changes for v2: - add new callback for esdhc to detect the

[PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-10-30 Thread r66093
From: Jerry Huang Add callback function sdhci_get_cd to detect the card. And one new callback added to implement the card detect in sdhci struncture. If special platform has the card detect callback, it will return the card state, the value zero is for absent cardi and one is for present card. If

[PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-10-30 Thread r66093
From: Jerry Huang In order to check whether the card has been removed, the function mmc_send_status() will send command CMD13 to card and ask the card to send its status register to sdhc driver, which will generate many interrupts repeatedly and make the system performance bad. Therefore, add ca

[PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()

2012-10-30 Thread r66093
From: Jerry Huang When f_init is zero, the SDHC can't work correctly. So f_min will replace f_init, when f_init is zero. Signed-off-by: Jerry Huang CC: Anton Vorontsov CC: Chris Ball --- changes for v2: - add the CC changes for v3: - enalbe the controller clock in platform, in

RE: [PATCH] powerpc/esdhc: enable the card insert/remove interrupt

2012-10-28 Thread Huang Changming-R66093
> Hello Huang, > > On Fri, Oct 26, 2012 at 02:42:36AM +, Huang Changming-R66093 wrote: > > For the current polling mode, driver will send CMD13 to poll the card > status periodically , which will cause too many interrupts. > > Once I sent patches to detect the card

RE: [PATCH] powerpc/esdhc: enable the card insert/remove interrupt

2012-10-25 Thread Huang Changming-R66093
om: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Anton Vorontsov > Sent: Thursday, October 25, 2012 6:31 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball; Kumar Gala; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [PAT

RE: [PATCH v6] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-10-25 Thread Huang Changming-R66093
No problem, thanks a lot, Chris. Best Regards Jerry Huang > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Thursday, October 25, 2012 8:53 PM > To: Anton Vorontsov > Cc: Huang Changming-R66093; linux-mmc@vger.kernel.org; Huang Changming- > R

RE: [PATCH] powerpc/esdhc: enable the card insert/remove interrupt

2012-10-25 Thread Huang Changming-R66093
Hi, Anton. Could you have any comment about it? If not, I will resend this patch with v2. Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Huang Changming-R66093 > Sent: Tuesday

RE: [PATCH v6] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-10-25 Thread Huang Changming-R66093
Thank you very much, Anton. Best Regards Jerry Huang > -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Thursday, October 25, 2012 4:01 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Xie Shaohui-

RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-10-24 Thread Huang Changming-R66093
Hi, anton, I have resent this patch according to your suggestion. Please review. Thanks. Best Regards Jerry Huang > -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Wednesday, October 24, 2012 4:39 PM > To: Huang Changming-R66093 >

[PATCH v6] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-10-24 Thread r66093
From: Jerry Huang CMD23 causes lots of errors in kernel on some freescale SoCs (P1020, P1021, P1022, P1024, P1025 and P4080) when MMC card used, which is because these controllers does not support CMD23, even on the SoCs which declares CMD23 is supported. Therefore, we'll not use CMD23. Signed-o

RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-10-23 Thread Huang Changming-R66093
Anton, could you give some comment about this patch? Reviewed by Girish last month. Best Regards Jerry Huang > -Original Message- > From: Huang Changming-R66093 > Sent: Monday, October 15, 2012 11:07 AM > To: Huang Changming-R66093; Anton Vorontsov; Chris Ball >

RE: [PATCH] powerpc/esdhc: enable the card insert/remove interrupt

2012-10-23 Thread Huang Changming-R66093
le the PIO mode, but the later version has fixed this issue). Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Anton Vorontsov > Sent: Tuesday, October 23, 2012 4:27 PM > To: Hu

[PATCH] powerpc/esdhc: enable the card insert/remove interrupt

2012-10-23 Thread r66093
From: Jerry Huang The current eSDHC driver use the poll mode to detect if the SD/MMC card is inserted or removed, which will generate many interrupts and impact the performance. Therefore, change the default card detect to interrupt mode, if the board can't support this mode, we still use the po

RE: [PATCH V4] Powerpc eSDHC Recover from the ADMA error

2012-10-22 Thread Huang Changming-R66093
; Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093 > Subject: Re: [PATCH V4] Powerpc eSDHC Recover from the ADMA error > > On Thu, Sep 20, 2012 at 10:19:23AM +0800, haijun.zh...@freescale.com > wrote: > > From: Haijun Zhang > > > > Signed-off-by: Haijun Zhang

RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-10-14 Thread Huang Changming-R66093
Anton, Have you any comment about this patch? Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Huang Changming-R66093 > Sent: Tuesday, October 09, 2012 2:24 PM > To: Anton Voront

RE: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-10-08 Thread Huang Changming-R66093
Wednesday, September 26, 2012 9:04 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Xie Shaohui-B21989; > Anton Vorontsov; Chris Ball > Subject: Re: [PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale > SoCs > > Looks good > Rev

[PATCH v5] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-25 Thread r66093
From: Jerry Huang CMD23 causes lots of errors in kernel on some freescale SoCs (P1020, P1021, P1022, P1024, P1025 and P4080) when MMC card used, which is because these controllers does not support CMD23, even on the SoCs which declares CMD23 is supported. Therefore, we'll not use CMD23. Signed-o

RE: [PATCH v4] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-25 Thread Huang Changming-R66093
Next version, I will change it to the warning and report to user. Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Huang Changming-R66093 > Sent: Wednesday, September 26, 2012 1

RE: [PATCH v4] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-25 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: Girish K S [mailto:girish.shivananja...@linaro.org] > Sent: Tuesday, September 25, 2012 10:45 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Xie Shaohui-B21989; > Anton Vor

[PATCH v4] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-25 Thread r66093
From: Jerry Huang CMD23 causes lots of errors in kernel on some freescale SoCs (P1020, P1021, P1022, P1024, P1025 and P4080) when MMC card used, which is because these controllers does not support CMD23, even on the SoCs which declares CMD23 is supported. Therefore, we'll not use CMD23. Signed-o

RE: [PATCH v3] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-24 Thread Huang Changming-R66093
> Hi, > > On Fri, Sep 21 2012, r66...@freescale.com wrote: > > --- a/drivers/mmc/host/sdhci-of-esdhc.c > > +++ b/drivers/mmc/host/sdhci-of-esdhc.c > > @@ -143,6 +143,35 @@ static void esdhc_of_resume(struct sdhci_host > > *host) } #endif > > > > +static const

RE: [PATCH v3] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-23 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Huang Changming-R66093 > Sent: Monday, September 24, 2012 10:37 AM > To: Kumar Gala; Chris Ball > Cc: linux-mmc@vger.kerne

RE: [PATCH v3] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-23 Thread Huang Changming-R66093
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Saturday, September 22, 2012 2:36 AM > To: Chris Ball > Cc: Huang Changming-R66093; linux-mmc@vger.kernel.org; Huang Changming- > R66093; Xie Shaohui-B21989; Anton Vorontsov > S

RE: [PATCH v3] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-23 Thread Huang Changming-R66093
> -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Saturday, September 22, 2012 12:09 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Xie Shaohui-B21989; > Anton Vorontsov; Kumar Gala > Subject: Re: [PA

[PATCH v3] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-21 Thread r66093
From: Jerry Huang CMD23 causes lots of errors in kernel on some freescale SoCs (P1020, P1021, P1022, P1024, P1025 and P4080) when MMC card used, which is because these controllers does not support CMD23, even on the SoCs which declares CMD23 is supported. Therefore, we'll not use CMD23. Signed-o

RE: [PATCH v2] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-21 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: Girish K S [mailto:girish.shivananja...@linaro.org] > Sent: Friday, September 21, 2012 5:56 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Xie Shaohui-B21989; > Anton Voron

[PATCH v2] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-21 Thread r66093
From: Jerry Huang CMD23 causes lots of errors in kernel on some freescale SoCs (P1020, P1021, P1022, P1024, P1025 and P4080) when mmc card used, which is because these controllers does not support CMD23, but even on SoCs which declare CMD23 is supported, so we'll not use CMD23. Signed-off-by: Je

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-17 Thread Huang Changming-R66093
> On Sep 17, 2012, at 7:36 AM, Chris Ball wrote: > > > Hi, > > > > On Thu, Sep 13 2012, Kumar Gala wrote: > Can you list out which SoCs support it and which don't. Having > this list will be useful in understanding which controller versions > supported it. > > >>> P1020, p1021, p10

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-13 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Thursday, September 13, 2012 8:48 PM > To: Huang Changming-R66093 > Cc: Chris Ball; linuxppc-...@lists.ozlabs.org list; linux- > m...@vger.kernel.org; Anton V

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-13 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Wednesday, September 12, 2012 11:38 AM > To: Huang Changming-R66093 > Cc: Wood Scott-B07421; linuxppc-...@lists.ozlabs.org; linux- > m...@vger.kernel.org >

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-12 Thread Huang Changming-R66093
> > > >> -Original Message- > >> From: Chris Ball [mailto:c...@laptop.org] > >> Sent: Wednesday, September 12, 2012 4:59 AM > >> To: Kumar Gala > >> Cc: Huang Changming-R66093; linuxppc-...@lists.ozlabs.org list; > >> linux- m...

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Wednesday, September 12, 2012 4:59 AM > To: Kumar Gala > Cc: Huang Changming-R66093; linuxppc-...@lists.ozlabs.org list; linux- > m...@vger.kernel.org; Anton Voron

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Huang Changming-R66093
Best Regards Jerry Huang > -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, September 12, 2012 2:28 AM > To: Anton Vorontsov > Cc: Huang Changming-R66093; linuxppc-...@lists.ozlabs.org; linux- > m...@vger.kernel.org > Subject: Re: [PATCH 2/3] powerp

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Huang Changming-R66093
Thanks, Anton. If it is necessary, I will resend this patch to linuxppc-...@lists.ozlabs.org. Best Regards Jerry Huang > -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Tuesday, September 11, 2012 4:05 PM > To: Huang Changming-R66093 >

RE: [PATCH V4] Powerpc eSDHC Recover from the ADMA error

2012-09-06 Thread Huang Changming-R66093
Hi, Anyone has some comment? Best Regards Jerry Huang > -Original Message- > From: Zhang Haijun-B42677 > Sent: Friday, August 31, 2012 3:36 PM > To: linux-mmc@vger.kernel.org > Cc: Zhang Haijun-B42677; Huang Changming-R66093 > Subject: [PATCH V4] Powerpc eSDHC Rec

RE: [PATCH] eSDHC: Add ADMA mode support for eSDHC

2012-08-05 Thread Huang Changming-R66093
Thanks a lot, Chris and Anton. Best Regards Jerry Huang > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Chris Ball > Sent: Monday, August 06, 2012 11:08 AM > To: Huang Changming-R66093 > Cc: linux-m

RE: [PATCH] eSDHC: Add ADMA mode support for eSDHC

2012-08-05 Thread Huang Changming-R66093
Huang Changming-R66093 > Sent: Thursday, March 08, 2012 11:25 AM > To: linux-mmc@vger.kernel.org > Cc: Huang Changming-R66093; Pan Jiafei-B37022; Jin Zhengxiong-R64188; > Chris Ball; Anton Vorontsov > Subject: [PATCH] eSDHC: Add ADMA mode support for eSDHC > > From: Jerry Huang >

[PATCH] eSDHC: Add ADMA mode support for eSDHC

2012-03-07 Thread r66093
From: Jerry Huang The register of eSDHC Host Controller Capabilities is not compatible with standard SDHC register, and eSDHC cannot support End Attribute in NOP ADMA descriptor. With this patch eSDHC can works in ADMA mode and performance can be improved. Signed-off-by: Jerry Huang Signed-off-

RE: [PATCH] ESDHC: Workaround for data crc error on p1010rdb

2012-02-14 Thread Huang Changming-R66093
Thanks a lot, Chris. Thanks Jerry Huang > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Tuesday, February 14, 2012 7:11 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Jain Priyanka- > B32167 > Subje

RE: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-13 Thread Huang Changming-R66093
Thanks Jerry Huang > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Tuesday, February 14, 2012 4:44 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Jain Priyanka-B32167 > Subject: Re: [PATCH v7] ESDHC: Workaround for data crc

[PATCH] ESDHC: Workaround for data crc error on p1010rdb

2012-02-13 Thread r66093
From: Jerry Huang SD card read was failing (data crc error)on some cards at maximum possible frequency on P1010(CCB frequency set to 400MHz). Some clock deviations are also observed at this frequency. Hence reduced the mmc clock freq. Signed-off-by: Priyanka Jain Singed-off-by: Jerry Huang CC:

RE: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-12 Thread Huang Changming-R66093
> > On Sun, Feb 12 2012, Chris Ball wrote: > > Hi, > > > > On Sun, Feb 12 2012, Huang Changming-R66093 wrote: > >> You are right. > >> I want to use the below code in header file "drivers/mmc/host/sdhci- > esdhc.h": > >> if (of_find

RE: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-12 Thread Huang Changming-R66093
Hi, Chris > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Sunday, February 12, 2012 5:20 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Jain Priyanka-B32167 > Subject: Re: [PATCH v7] ESDHC: Workaround for data crc error o

RE: [PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-08 Thread Huang Changming-R66093
> -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Wednesday, February 08, 2012 11:07 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Jain Priyanka- > B32167 > Subject: Re: [PATCH v7] ESDHC: Workaround

[PATCH v7] ESDHC: Workaround for data crc error on p1010rdb

2012-02-08 Thread r66093
From: Jerry Huang SD card read was failing (data crc error)on some cards at maximum possible frequency on P1010(CCB frequency set to 400MHz). Some clock deviations are also observed at this frequency. Hence reduced the mmc clock freq. Signed-off-by: Priyanka Jain Singed-off-by: Jerry Huang CC:

RE: [PATCH v6] ESDHC: Workaround for data crc error on p1010rdb

2012-02-08 Thread Huang Changming-R66093
> > diff --git a/include/linux/mmc/sdhci.h b/include/linux/mmc/sdhci.h > > index c750f85..2418c91 100644 > > --- a/include/linux/mmc/sdhci.h > > +++ b/include/linux/mmc/sdhci.h > > @@ -90,6 +90,9 @@ struct sdhci_host { > > > > unsigned int quirks2; /* More deviations from spec. */ > > > > +/*

RE: [PATCH v3 2/2] mmc: sdhci-s3c: add platform data for the second capability

2012-02-07 Thread Huang Changming-R66093
Sorry, please discard my previous reply. > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Huang Changming-R66093 > Sent: Wednesday, February 08, 2012 11:32 AM > To: Chris Ball; Jaehoon Chung > Cc

RE: [PATCH 4/4 v5] ESDHC: Workaround for data crc error on p1010rdb

2012-02-07 Thread Huang Changming-R66093
Hi, Chris, I have reworked it and send it to the maillist, please review it. Best regards Jerry Huang > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Sunday, February 05, 2012 6:22 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org;

[PATCH v6] ESDHC: Workaround for data crc error on p1010rdb

2012-02-07 Thread r66093
From: Jerry Huang SD card read was failing (data crc error)on some cards at maximum possible frequency on P1010(CCB frequency set to 400MHz). Some clock deviations are also observed at this frequency. Hence reduced the mmc clock freq. Signed-off-by: Priyanka Jain Singed-off-by: Jerry Huang CC:

RE: [PATCH v3 2/2] mmc: sdhci-s3c: add platform data for the second capability

2012-02-07 Thread Huang Changming-R66093
Hi, Chris, I have reworked it and send it to the maillist, please review it. > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Chris Ball > Sent: Monday, February 06, 2012 7:20 PM > To: Jaehoon Chung > Cc: linux-mmc; linu

RE: [PATCH 4/4 v5] ESDHC: Workaround for data crc error on p1010rdb

2012-02-07 Thread Huang Changming-R66093
Chris, Thanks. I will think about how to handle it and rework it. > -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Sunday, February 05, 2012 6:22 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Jain Pri

[PATCH 2/4 v3] ESDHC: set the timeout to the max value

2012-01-15 Thread r66093
From: Jerry Huang When access the card on some FSL platform board (e.g p2020, p1010, mpc8536), the following error is reported with the timeout value calculated: mmc0: Got data interrupt 0x0020 even though no data operation was in progress. mmc0: Got data interrupt 0x0020 even though no

[PATCH 4/4 v5] ESDHC: Workaround for data crc error on p1010rdb

2012-01-15 Thread r66093
From: Jerry Huang SD card read was failing (data crc error)on some cards at maximum possible frequency on P1010(CCB frequency set to 400MHz). Some clock deviations are also observed at this frequency. Hence reduced the mmc clock freq. Signed-off-by: Priyanka Jain Singed-off-by: Jerry Huang CC:

[PATCH 3/4 v5] ESDHC: Power management for ESDHC

2012-01-15 Thread r66093
From: Jerry Huang For FSL ESDHC controllor, when enter the sleep, the controller will power off, therefore the register will lost its valuse, and driver should save value of register during suspend and used during resume. Signed-off-by: Jerry Huang Signed-off-by: Jiang Yutang CC: Chris Ball A

[PATCH 1/4 v3] ESDHC: add PIO mode support

2012-01-15 Thread r66093
From: Jerry Huang For some FSL ESDHC controller(e.g. P2020E, Rev1.0), the SDHC can not work on DMA mode because of the hardware bug, so we set a broken dma flag and use PIO mode. Signed-off-by: Gao Guanhua Signed-off-by: Jerry Huang CC: Chris Ball Acked-by: Anton Vorontsov --- changes for v2

[PATCH 0/4] new version workaround for FSL's eSDHC controller

2012-01-15 Thread r66093
From: Jerry Huang The below new verison patches are the workaround for FSL's eSDHC controller. all patches have been acked-by Anton Vorontsov . Signed-off-by: Jerry Huang -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.o

RE: [PATCH 4/5 v4] ESDHC: Workaround for data crc error on p1010rdb

2012-01-15 Thread Huang Changming-R66093
> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Friday, January 13, 2012 8:13 PM > To: Huang Changming-R66093 > Cc: Chris Ball; linux-mmc@vger.kernel.org > Subject: Re: [PATCH 4/5 v4] ESDHC: Workaround for data crc error on > p101

RE: [PATCH 2/5 v2] ESDHC: set the timeout to the max value

2012-01-15 Thread Huang Changming-R66093
Thanks, Anton. I will post it again. > -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Friday, January 13, 2012 7:55 PM > To: Huang Changming-R66093 > Cc: Chris Ball; linux-mmc@vger.kernel.org > Subject: Re: [PATCH 2/5 v2] ESDHC: set

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-01-12 Thread Huang Changming-R66093
If you read the previous email about this serial patches discussed with other guys, you can understand. > -Original Message- > From: Aaron Lu [mailto:aaron...@amd.com] > Sent: Friday, January 13, 2012 2:28 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.

RE: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()

2012-01-12 Thread Huang Changming-R66093
> -Original Message- > From: Aaron Lu [mailto:aaron...@amd.com] > Sent: Friday, January 13, 2012 2:32 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() > > Hi, > &

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-01-12 Thread Huang Changming-R66093
> -Original Message- > From: Aaron Lu [mailto:aaron...@amd.com] > Sent: Friday, January 13, 2012 2:21 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect > the card >

RE: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card

2012-01-12 Thread Huang Changming-R66093
> -Original Message- > From: Aaron Lu [mailto:aaron...@amd.com] > Sent: Friday, January 13, 2012 11:27 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PATCH 2/4 v4] MMC/SD: Add callback function to detect card > > Hi, &

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-01-12 Thread Huang Changming-R66093
> -Original Message- > From: Aaron Lu [mailto:aaron...@amd.com] > Sent: Friday, January 13, 2012 11:27 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect > the card >

RE: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()

2012-01-12 Thread Huang Changming-R66093
> -Original Message- > From: Aaron Lu [mailto:aaron...@amd.com] > Sent: Friday, January 13, 2012 11:27 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() > > Hi, > &

RE: [PATCH 4/5 v4] ESDHC: Workaround for data crc error on p1010rdb

2012-01-12 Thread Huang Changming-R66093
Hi, Anton, Could you have any comment about this serial patch? Thanks Jerry Huang > -Original Message- > From: Huang Changming-R66093 > Sent: Friday, January 06, 2012 1:33 PM > To: linux-mmc@vger.kernel.org > Cc: Huang Changming-R66093; Jain Priyanka-B32167; Chris Ball &g

RE: [PATCH 3/5 v4] ESDHC: Power management for ESDHC

2012-01-12 Thread Huang Changming-R66093
Hi, Anton, Could you have any comment about this serial patch? Thanks Jerry Huang > -Original Message- > From: Huang Changming-R66093 > Sent: Friday, January 06, 2012 1:33 PM > To: linux-mmc@vger.kernel.org > Cc: Huang Changming-R66093; Jiang Yutang-B14898; Chris Ball >

RE: [PATCH 2/5 v2] ESDHC: set the timeout to the max value

2012-01-12 Thread Huang Changming-R66093
Hi, Anton, Could you have any comment about this serial patch? Thanks Jerry Huang > -Original Message- > From: Huang Changming-R66093 > Sent: Friday, January 06, 2012 1:33 PM > To: linux-mmc@vger.kernel.org > Cc: Huang Changming-R66093; Gao Guanhua-B22826; Xie Xiaobo-R6306

RE: [PATCH 1/5 v2] ESDHC: add PIO mode support

2012-01-12 Thread Huang Changming-R66093
Hi, Anton, Could you have any comment about this serial patch? Thanks Jerry Huang > -Original Message- > From: Huang Changming-R66093 > Sent: Friday, January 06, 2012 1:33 PM > To: linux-mmc@vger.kernel.org > Cc: Huang Changming-R66093; Gao Guanhua-B22826; Chris Ball > S

RE: [PATCH 5/5 v3] ESDHC: Fix DMA errors in kernel booting on P1010

2012-01-12 Thread Huang Changming-R66093
Yes, please ignore this patch. Thanks. > -Original Message- > From: Zang Roy-R61911 > Sent: Thursday, January 12, 2012 3:29 PM > To: Huang Changming-R66093; linux-mmc@vger.kernel.org > Cc: Huang Changming-R66093; Jain Priyanka-B32167; Chris Ball > Subject: RE: [PATCH

RE: [PATCH 4/4 v3] ESDHC: add callback esdhc_of_get_cd to detect card

2012-01-12 Thread Huang Changming-R66093
Hi, Chris, Could you have any comment about this patch? Can it go into 3.3 or 3.4? Thanks Jerry Huang > -Original Message- > From: Huang Changming-R66093 > Sent: Friday, December 09, 2011 10:54 AM > To: linux-mmc@vger.kernel.org > Cc: Huang Changming-R66093; Chris Ball &g

  1   2   >