Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-10-04 Thread Chris Ball
Hi Linus, On Thu, Sep 30, 2010 at 09:22:17AM +0200, Linus Walleij wrote: > That's it. If there is interest I can surely pick it up and wrap the > current enable/disable calls around it or even rewrite all drivers > to use the set_ios() approach as in this patchset I think. > > What happened was t

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-30 Thread Nicolas Pitre
On Thu, 30 Sep 2010, Linus Walleij wrote: > 2010/9/30 Kyungmin Park : > > So try to find another method and implemente it at SDHCI drivers. > > Why? The only difference between this solution and the one > that is inside the kernel now is that this will use set_ios() with > a zero argument to gate

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-30 Thread Linus Walleij
2010/9/30 Kyungmin Park : > On Thu, Sep 30, 2010 at 1:09 PM, Chris Ball wrote: >> Hi, >> >> On Wed, Sep 29, 2010 at 11:42:01PM -0400, Nicolas Pitre wrote: >>> As I already said here: >>> >>>       http://article.gmane.org/gmane.linux.ports.arm.omap/39411 >>> >>> I find those callbacks rather probl

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-29 Thread Kyungmin Park
On Thu, Sep 30, 2010 at 1:09 PM, Chris Ball wrote: > Hi, > > On Wed, Sep 29, 2010 at 11:42:01PM -0400, Nicolas Pitre wrote: >> As I already said here: >> >>       http://article.gmane.org/gmane.linux.ports.arm.omap/39411 >> >> I find those callbacks rather problematic.  Currently, >> mmc_host_disa

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-29 Thread Chris Ball
Hi, On Wed, Sep 29, 2010 at 11:42:01PM -0400, Nicolas Pitre wrote: > As I already said here: > > http://article.gmane.org/gmane.linux.ports.arm.omap/39411 > > I find those callbacks rather problematic. Currently, > mmc_host_disable() is called by the host driver (currently OMAP) and >

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-29 Thread Nicolas Pitre
On Thu, 30 Sep 2010, Chris Ball wrote: > Hi Jaehoon/Adrian, > > On Thu, Sep 16, 2010 at 03:46:50PM +0900, Jaehoon Chung wrote: > > Hi all, > > This is a RFC patch that support clock-gating for saving power > > consumption. > > I found mmc_host_enable/mmc_host_disable function in core.c > >

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-29 Thread Chris Ball
Hi Jaehoon/Adrian, On Thu, Sep 16, 2010 at 03:46:50PM +0900, Jaehoon Chung wrote: > Hi all, > This is a RFC patch that support clock-gating for saving power consumption. > I found mmc_host_enable/mmc_host_disable function in core.c > (using MMC_CAP_DSIABLE. i think that use when host enable/

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-27 Thread Jaehoon Chung
Jae hoon Chung wrote: > 2010/9/17 Matt Fleming : >> On Thu, Sep 16, 2010 at 03:46:50PM +0900, Jaehoon Chung wrote: >>> Hi all, >>> This is a RFC patch that support clock-gating for saving power >>> consumption. >>> I found mmc_host_enable/mmc_host_disable function in core.c >>> (using MMC_CA

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-25 Thread Jae hoon Chung
2010/9/17 Matt Fleming : > On Thu, Sep 16, 2010 at 03:46:50PM +0900, Jaehoon Chung wrote: >> Hi all, >>   This is a RFC patch that support clock-gating for saving power consumption. >>   I found mmc_host_enable/mmc_host_disable function in core.c >>   (using MMC_CAP_DSIABLE. i think that use when h

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-17 Thread Matt Fleming
On Thu, Sep 16, 2010 at 03:46:50PM +0900, Jaehoon Chung wrote: > Hi all, > This is a RFC patch that support clock-gating for saving power consumption. > I found mmc_host_enable/mmc_host_disable function in core.c > (using MMC_CAP_DSIABLE. i think that use when host enable/disable) > So, i u

[RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-15 Thread Jaehoon Chung
Hi all, This is a RFC patch that support clock-gating for saving power consumption. I found mmc_host_enable/mmc_host_disable function in core.c (using MMC_CAP_DSIABLE. i think that use when host enable/disable) So, i used that functions and implemented some functions in sdhci-s3c.c & sdhci