> -Original Message-
> From: Dan Williams [mailto:dan.j.willi...@intel.com]
> Sent: Thursday, April 19, 2018 11:10 AM
> To: Qi, Fuli/斉 福利
> Cc: linux-nvdimm
> Subject: Re: [PATCH 1/2] ndctl, util: add OPT_STRING_LIST to parse_option
>
> On Wed, Apr 18, 2018 at 7:06 PM, Qi, Fuli wrote:
>
> From: Verma, Vishal L [mailto:vishal.l.ve...@intel.com]
> Sent: Thursday, April 19, 2018 1:06 AM
> To: Williams, Dan J ; Qi, Fuli/斉 福利
>
> Cc: linux-nvdimm@lists.01.org
> Subject: Re: [PATCH v2] ndctl, filter: refacor util__filter() to support
> multiple
> space-seperated arguments
>
> On Wed,
On Wed, Apr 18, 2018 at 7:06 PM, Qi, Fuli wrote:
>> > Thank you very much, I made a v2 patch by referring to your sample patch.
>> >
>> > Going back to the OPT_STRING_LIST, I think it is necessary for ndctl.
>> > Because the other options in monitor like --dimm-event, --bus-event
>> > also need to
> > Thank you very much, I made a v2 patch by referring to your sample patch.
> >
> > Going back to the OPT_STRING_LIST, I think it is necessary for ndctl.
> > Because the other options in monitor like --dimm-event, --bus-event
> > also need to support multiple space-separated arguments, these opti
The struct resource uses singly linked list to link siblings. It's not
easy to do reverse iteration on sibling list. So replace it with list_head.
And this makes codes in kernel/resource.c more readable after refactoring
than pointer operation.
Besides, type of member variables of struct resource
On Wed, Apr 18, 2018 at 04:04:02PM -0600, Vishal Verma wrote:
> We neglected adding the inject-smart man page to the documentation
> Makefile, resulting in the man page never getting generated.
>
> Reported-by: Jacek Zloch
> Signed-off-by: Vishal Verma
Yep, works.
Reviewed-by: Ross Zwisler
__
We neglected adding the inject-smart man page to the documentation
Makefile, resulting in the man page never getting generated.
Reported-by: Jacek Zloch
Signed-off-by: Vishal Verma
---
Documentation/ndctl/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/ndctl/Makefi
On Wed, 2018-04-18 at 07:31 -0700, Dan Williams wrote:
> On Tue, Apr 17, 2018 at 11:32 PM, QI Fuli wrote:
> > This patch refactors util__filter to support multiple space-
> > seperated
> > arguments. Currently, only one can be filtered by 's
> > name
> > in util__filter(). As a result, when users
On Tue, Apr 17, 2018 at 11:32 PM, QI Fuli wrote:
> This patch refactors util__filter to support multiple space-seperated
> arguments. Currently, only one can be filtered by 's name
> in util__filter(). As a result, when users want to moniotr multiple
> dimms, they have to run multiple monitor pro
On Wed, Apr 18, 2018 at 3:09 AM, Qi, Fuli wrote:
>> >> As far as I can see we do not need to allocate a list or add this new
>> >> OPT_STRING_LIST argument type. Just teach the util__filter()
>> routines
>> >> that the 'ident' argument may be a space delimited list. See the attached
>> patch:
>>
> >> As far as I can see we do not need to allocate a list or add this new
> >> OPT_STRING_LIST argument type. Just teach the util__filter()
> routines
> >> that the 'ident' argument may be a space delimited list. See the attached
> patch:
> >
> > Thank you for your comment.
> >
> > The OPT_STRING
11 matches
Mail list logo
