On Sun, Mar 07, 2010 at 10:59:01PM +, Ben Dooks wrote:
On Sun, Mar 07, 2010 at 09:47:58AM -0800, Cory Maccarrone wrote:
From: Marek Belisko marek.beli...@open-nandra.com
The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring
a modification of the register addresses
Reddy, Teerth wrote:
From: Teerth Reddy tee...@ti.com
Dynamic Calculation of SDRC stall latency during DVFS
The patch has the changes to calculate the dpll3 clock stabilization delay
dynamically. The SRAM delay is calibrated during bootup using the gptimers and
used while calculating the
The clock divider range check is wrong for the OMAP3.
The MCSPI_CHxCONF.CLKD register field has a max value 0x0C
not 0x0F. Reference was the OMAP3 TRM Rev. D manual.
I don't know whether the old value was correct for OMAP24xxx
boards so I put in some #ifdef stuff. Maybe someone with access
to
Scott Ellis wrote:
The clock divider range check is wrong for the OMAP3.
The MCSPI_CHxCONF.CLKD register field has a max value 0x0C
not 0x0F. Reference was the OMAP3 TRM Rev. D manual.
I don't know whether the old value was correct for OMAP24xxx
boards so I put in some #ifdef stuff.
Check spi-controller_state before dereferencing.
Check spi-chip_select for range before using.
Neither are guaranteed to be valid when spi_dev_put() is called.
Submitted previously to the linux-kernel list but without the
chip_select check.
Signed-off-by: Scott Ellis sc...@jumpnowtek.com
omap2_mcspi_transfer() gets called in omap2_mcspi_work() when the
transaction speed_hz or bits_per_word fields are non-zero.
omap2_mcspi_transfer() does not look at the speed_hz field so
the override speed value is ignored.
The code should probably change to one of these options.
1. Skip the
On Mon, Mar 08, 2010 at 06:56:51AM -0500, Scott Ellis wrote:
diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index fe1b56d..a73127b 100644
--- a/drivers/spi/omap2_mcspi.c
+++ b/drivers/spi/omap2_mcspi.c
@@ -38,8 +38,17 @@
#include plat/dma.h
#include plat/clock.h
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Aguirre, Sergio
Sent: Friday, March 05, 2010 5:12 PM
To: Kevin Hilman
Cc: linux-omap@vger.kernel.org
Subject: RE: [RFC part1/2 merge][PATCH 06/10] omap3: serial: Fix
Aguirre, Sergio saagui...@ti.com writes:
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Aguirre, Sergio
Sent: Friday, March 05, 2010 5:12 PM
To: Kevin Hilman
Cc: linux-omap@vger.kernel.org
Subject: RE: [RFC part1/2
From: Kevin Hilman [mailto:khil...@deeprootsystems.com]
Sent: Monday, March 08, 2010 10:52 AM
Aguirre, Sergio saagui...@ti.com writes:
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Aguirre, Sergio
Sent:
tero.kri...@nokia.com writes:
[...]
True, ancient info there. OFF for example has been supported for ages already.
+ if (state != PWRDM_POWER_INACTIVE)
+ while (!(pwrdm-pwrsts (1 state))) {
+ if (state == PWRDM_POWER_OFF)
+ return
This check is invalid, since we haven't filled the
omap_revision var at this point.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/serial.c | 14 +-
1 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/arch/arm/mach-omap2/serial.c
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/plat-omap/include/plat/irqs.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/irqs.h
b/arch/arm/plat-omap/include/plat/irqs.h
index b65088a..a7ae3f3 100644
---
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/pm34xx.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index fee2efb..81082f2 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++
This patch makes the following:
- Adds missing wakeup padding register handling.
- Fixes a hardcode to use PER module ONLY on UART3.
- Corrects IRQ number to 80 for 3630 case.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/serial.c |9 -
1 files changed, 8
This bits are exclusive of omap 36xx family of chips.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/cm-regbits-34xx.h |2 ++
arch/arm/mach-omap2/prcm-common.h |4
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git
All UARTs seem physically reachable, so, enable them all.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/board-3630sdp.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
mode change 100755 = 100644 arch/arm/mach-omap2/board-3630sdp.c
diff --git
This is for protecting a wrong mapping attempt of a zero-based
physical address.
The result is that, no serial port will be attempted to be mapped.
Also add an additional protection for NULL clocks before attempting
to enable them (if above condition applies)
Signed-off-by: Sergio Aguirre
This is useless, since in Zoom2/3 boards, the ports aren't even
physically accessible.
They must be explicitly initted in the board-zoom2.c, board-zoom3.c
and board-3630sdp.c files instead.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c |1 -
There's no more serial ports available, so, doesn't make sense
to create 4 device nodes.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/configs/omap_zoom2_defconfig |2 +-
arch/arm/configs/omap_zoom3_defconfig |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
This is only valid for omap 36xx family of chips.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/clock3xxx_data.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/clock3xxx_data.c
This is now changed to PLAT8250_DEV_PLATFORM (= 0), because
it is the only port that's going to be initted in Zoom 2/3 boards.
So, it doesn't make sense to keep the hardcoded 3 value anymore.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/board-zoom-debugboard.c |2
This patch series adds support for the updated 45nm smrtrelfex IP
supported in OMAP3630 and OMAP4 in the smartreflex driver and
adds support to enable smartreflex autocompensation for OMAP3630
using test nvalues.
This patch series is based on the following patch series/patches
for proper
This patch sets and unsets is_sr_reset is appropriate places so that
trying to enable smart reflex in a non-supported OMAP chip does not
lead to unnecessary crash
Signed-off-by: Thara Gopinath th...@ti.com
---
arch/arm/mach-omap2/smartreflex.c | 31 +--
1 files
This patch adapts smartreflex driver to support OMAP3630 also.
Changes involve:
1. Separate hwmod structures for OMAP3630 distinguished from
3430 structures using omap_chip attribute.
2. Introducing new test nvalues for OMAP3630.
3. OMAP3630 specific changes for srconfig err_minlimit field,
OMAP3430 uses the 65nm version of the smartreflex IP where as
OMAP3630 and OMAP4430 uses the 45nm updated IP.
This patch adds support for the updated smartreflex IP used
in OMAP3630 and OMAP4 in the smartreflex driver.
Major changes between the two versions of IP involve:
1. Change in offset
-Original Message-
From: Aguirre, Sergio
Sent: Monday, March 08, 2010 11:21 AM
To: linux-omap@vger.kernel.org
Cc: Kevin Hilman; Pandita, Vikram; Paul Walmsley; Tony Lindgren; Aguirre,
Sergio
Subject: [RFC part1/2 merge v2][PATCH 00/11] omap2/3/4: uart4 fixes +
zoom2/3 changes
This is for protecting a wrong mapping attempt of a zero-based
physical address.
The result is that, no serial port will be attempted to be mapped.
Also add an additional protection for NULL clocks before attempting
to enable them (if above condition applies)
Signed-off-by: Sergio Aguirre
This is only valid for omap 36xx family of chips.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/clock3xxx_data.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/clock3xxx_data.c
This check is invalid, since we haven't filled the
omap_revision var at this point.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/serial.c | 14 +-
1 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/arch/arm/mach-omap2/serial.c
All UARTs seem physically reachable, so, enable them all.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/board-3630sdp.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
mode change 100755 = 100644 arch/arm/mach-omap2/board-3630sdp.c
diff --git
This bits are exclusive of omap 36xx family of chips.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/cm-regbits-34xx.h |2 ++
arch/arm/mach-omap2/prcm-common.h |4
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git
There's no more serial ports available, so, doesn't make sense
to create 4 device nodes.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/configs/omap_zoom2_defconfig |2 +-
arch/arm/configs/omap_zoom3_defconfig |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
This patch makes the following:
- Adds missing wakeup padding register handling.
- Fixes a hardcode to use PER module ONLY on UART3.
- Adds UART4 IRQ number define for 36xx chips.
- Corrects IRQ number for 3630 case.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
Hi,
This is v2 of my serial work series merge found here: [1]
And it's meant to be applied on top of Thomas's patch: [2]
Changelog compared to previous version:
- Replaced hardcoded IRQ for UART4 in 3630 by newly created
INT_36XX_UART4_IRQ define. (Thanks Kevin)
Please let me know your
This is useless, since in Zoom2/3 boards, the ports aren't even
physically accessible.
They must be explicitly initted in the board-zoom2.c, board-zoom3.c
and board-3630sdp.c files instead.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c |1 -
This is now changed to PLAT8250_DEV_PLATFORM (= 0), because
it is the only port that's going to be initted in Zoom 2/3 boards.
So, it doesn't make sense to keep the hardcoded 3 value anymore.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/board-zoom-debugboard.c |2
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/pm34xx.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index fee2efb..81082f2 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++
Thara Gopinath th...@ti.com writes:
This patch series adds support for the updated 45nm smrtrelfex IP
supported in OMAP3630 and OMAP4 in the smartreflex driver and
adds support to enable smartreflex autocompensation for OMAP3630
using test nvalues.
This patch series is based on the
Thara Gopinath th...@ti.com writes:
This patch sets and unsets is_sr_reset is appropriate places so that
trying to enable smart reflex in a non-supported OMAP chip does not
lead to unnecessary crash
$SUBJECT needs to be more desciptive. Patch content looks fine.
Kevin
Signed-off-by:
Thara Gopinath th...@ti.com writes:
OMAP3430 uses the 65nm version of the smartreflex IP where as
OMAP3630 and OMAP4430 uses the 45nm updated IP.
This patch adds support for the updated smartreflex IP used
in OMAP3630 and OMAP4 in the smartreflex driver.
Major changes between the two
Sergio Aguirre saagui...@ti.com writes:
Signed-off-by: Sergio Aguirre saagui...@ti.com
This one needs a descriptive changelog.
Kevin
---
arch/arm/mach-omap2/pm34xx.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c
Hi,
Deleted: dspbridge-next-camelcase
Published dspbridge-camelcase-v2
Following patches were dropped:
dspbridge: camelcase replace DSP_FAILED for dsp_failed
dspbridge: camelcase replace GB_NOBITS for gb_nobits
dspbridge: camelcase replace BITS_PER_BYTE for bits_per_byte
dspbridge: camelcase
Sergio Aguirre saagui...@ti.com writes:
This is now changed to PLAT8250_DEV_PLATFORM (= 0), because
it is the only port that's going to be initted in Zoom 2/3 boards.
^^^
minor nit: not a word. :) please use the much harder to spell:
initialized.
From: Kevin Hilman [mailto:khil...@deeprootsystems.com]
Sent: Monday, March 08, 2010 11:56 AM
Sergio Aguirre saagui...@ti.com writes:
Signed-off-by: Sergio Aguirre saagui...@ti.com
This one needs a descriptive changelog.
Agreed. Will fix.
Regards,
Sergio
snip
--
To unsubscribe from
From: Kevin Hilman [mailto:khil...@deeprootsystems.com]
Sent: Monday, March 08, 2010 11:59 AM
Sergio Aguirre saagui...@ti.com writes:
This is now changed to PLAT8250_DEV_PLATFORM (= 0), because
it is the only port that's going to be initted in Zoom 2/3 boards.
On Mon, Mar 08, 2010 at 10:50:49PM +0530, Thara Gopinath wrote:
This patch sets and unsets is_sr_reset is appropriate places so that
trying to enable smart reflex in a non-supported OMAP chip does not
lead to unnecessary crash
Signed-off-by: Thara Gopinath th...@ti.com
$SUBJECT is not
Omar,
Missing your Signed-off-by for all the patches in
dspbridge-camelcase-v2 branch.
Thanks,
Deepak
Omar Ramirez Luna wrote:
Hi,
Deleted: dspbridge-next-camelcase
Published dspbridge-camelcase-v2
Following patches were dropped:
dspbridge: camelcase replace DSP_FAILED for dsp_failed
On Mon, Mar 08, 2010 at 10:50:50PM +0530, Thara Gopinath wrote:
+static inline int sr_type(void)
+{
+ if (cpu_is_omap3630())
+ return SR_TYPE_V2;
+ else if (cpu_is_omap343x())
+ return SR_TYPE_V1;
+ else {
+ pr_err(Trying to enable SR for
hi,
On Mon, Mar 08, 2010 at 10:50:51PM +0530, Thara Gopinath wrote:
@@ -289,32 +311,66 @@ static void __init vp_reg_configure(int vp_id)
vp_reg[vp_id].vp_offs = omap3_vp_offs[vp_id];
if (vp_id == VP1) {
- /*
- * OMAP3430
On Mon, Mar 08, 2010 at 11:28:43AM -0600, Sergio Aguirre wrote:
@@ -727,6 +733,10 @@ void __init omap_serial_init_port(int port)
pdev = uart-pdev;
dev = pdev-dev;
+ /* Don't proceed if there's no clocks available */
+ if (!uart-ick || !uart-fck)
+ return;
When building for multi-omap, and OMAP4 is enabled, CONFIG_ARCH_OMAP4
will be true and prevent included code from building/running for
OMAP2/3 as well.
This problem exists in io.c where some hwmod/PM/SDRC init code is
prevented from running even on OMAP2/3 when OMAP4 is included in a
multi-OMAP
On Mon, Mar 08, 2010 at 11:28:46AM -0600, Sergio Aguirre wrote:
@@ -3420,6 +3440,7 @@ static struct omap_clk omap3xxx_clks[] = {
CLK(NULL, per_96m_fck, per_96m_fck, CK_3XXX),
CLK(NULL, per_48m_fck, per_48m_fck, CK_3XXX),
CLK(NULL, uart3_fck,
When building for multi-omap, and OMAP4 is enabled, CONFIG_ARCH_OMAP4
will be true and prevent included code from building/running for
OMAP2/3 as well.
This problem exists in io.c where some hwmod/PM/SDRC init code is
prevented from running even on OMAP2/3 when OMAP4 is included in a
multi-OMAP
Hi,
It will be fixed once they are pushed as a single patch.
Regards,
Omar
On 3/8/2010 12:10 PM, Chitriki Rudramuni, Deepak wrote:
Omar,
Missing your Signed-off-by for all the patches in
dspbridge-camelcase-v2 branch.
Thanks,
Deepak
Omar Ramirez Luna wrote:
Hi,
Deleted:
When building for multi-omap, and OMAP4 is enabled, CONFIG_ARCH_OMAP4
will be true and prevent included code from building/running for
OMAP2/3 as well.
This problem exists in io.c where some hwmod/PM/SDRC init code is
prevented from running even on OMAP2/3 when OMAP4 is included in a
multi-OMAP
Hi,
I've started working on beagle board.
Using pre-compiled kernel (angstrom) - i've got nand driver loaded and running.
When I am trying to compile my own kernel from the source, I get error:
probe of omap2-nand failed with -16 (EBUSY)
I've selected all configs for Nand...
Am I missing
-Original Message-
From: Felipe Balbi [mailto:m...@felipebalbi.com]
Sent: Monday, March 08, 2010 12:25 PM
To: Aguirre, Sergio
Cc: linux-omap@vger.kernel.org; Kevin Hilman; Pandita, Vikram; Paul
Walmsley; Tony Lindgren
Subject: Re: [RFC part1/2 merge v2 RESEND][PATCH 01/10] OMAP3:
-Original Message-
From: Felipe Balbi [mailto:m...@felipebalbi.com]
Sent: Monday, March 08, 2010 12:29 PM
To: Aguirre, Sergio
Cc: linux-omap@vger.kernel.org; Kevin Hilman; Pandita, Vikram; Paul
Walmsley; Tony Lindgren
Subject: Re: [RFC part1/2 merge v2 RESEND][PATCH 04/10] OMAP
Aguirre, Sergio saagui...@ti.com writes:
-Original Message-
From: Felipe Balbi [mailto:m...@felipebalbi.com]
Sent: Monday, March 08, 2010 12:25 PM
To: Aguirre, Sergio
Cc: linux-omap@vger.kernel.org; Kevin Hilman; Pandita, Vikram; Paul
Walmsley; Tony Lindgren
Subject: Re: [RFC
Aguirre, Sergio saagui...@ti.com writes:
-Original Message-
From: Felipe Balbi [mailto:m...@felipebalbi.com]
Sent: Monday, March 08, 2010 12:29 PM
To: Aguirre, Sergio
Cc: linux-omap@vger.kernel.org; Kevin Hilman; Pandita, Vikram; Paul
Walmsley; Tony Lindgren
Subject: Re: [RFC
* Felipe Balbi felipe.ba...@nokia.com [100304 23:00]:
On Thu, Mar 04, 2010 at 08:15:27PM +0100, ext m...@felipebalbi.com wrote:
Hi,
On Thu, 4 Mar 2010 18:33:15 +0530, Gadiyar, Anand gadi...@ti.com
wrote:
This patch fixes that for the ehci_hdc_omap_platform_data.
should be
* Cory Maccarrone darkstar6...@gmail.com [100306 20:53]:
All,
I've finally gotten some time to test the latest linux-omap code, and
found the following commit:
4f2c49fedf... omap: Clean the serial port defines
breaks current omap7xx support. To get linux-omap master to boot, I
had
* Felipe Contreras felipe.contre...@gmail.com [100305 13:15]:
Hey Sergio,
On Fri, Mar 5, 2010 at 8:17 PM, Aguirre, Sergio saagui...@ti.com wrote:
Hey!
You guys take a chill pill, ok? :) Let's not start shouting at people and
point fingers.
I'm not really angry, and I'm not blaming
On Mon, Mar 8, 2010 at 4:48 PM, Tony Lindgren t...@atomide.com wrote:
* Cory Maccarrone darkstar6...@gmail.com [100306 20:53]:
All,
I've finally gotten some time to test the latest linux-omap code, and
found the following commit:
4f2c49fedf... omap: Clean the serial port defines
* Cory Maccarrone darkstar6...@gmail.com [100308 17:49]:
On Mon, Mar 8, 2010 at 4:48 PM, Tony Lindgren t...@atomide.com wrote:
* Cory Maccarrone darkstar6...@gmail.com [100306 20:53]:
If you don't have any serial output with that, then try this:
- reset some branch to 4f2c49fedf
-
On Mon, Mar 8, 2010 at 6:46 PM, Tony Lindgren t...@atomide.com wrote:
* Cory Maccarrone darkstar6...@gmail.com [100308 17:49]:
On Mon, Mar 8, 2010 at 4:48 PM, Tony Lindgren t...@atomide.com wrote:
* Cory Maccarrone darkstar6...@gmail.com [100306 20:53]:
If you don't have any serial output
On Tue, Mar 9, 2010 at 1:34 AM, Pablo Bitton pablo.bit...@gmail.com wrote:
Hi,
I've started working on beagle board.
Using pre-compiled kernel (angstrom) - i've got nand driver loaded and
running.
When I am trying to compile my own kernel from the source, I get error:
probe of
On Tue, Mar 09, 2010 at 02:42:36AM +0100, ext Tony Lindgren wrote:
After a quick search for mailing list netiquette I cam up with
the following links:
http://linux.sgms-centre.com/misc/netiquette.php
http://en.opensuse.org/OpenSUSE_mailing_list_netiquette
We can add that to some of the wiki
69 matches
Mail list logo