Re: [RFC 7/8] drivers: introduce rpmsg, a remote-processor messaging bus

2011-06-28 Thread Ohad Ben-Cohen
Hi Randy, Thanks for your comments ! On Wed, Jun 29, 2011 at 2:44 AM, Randy Dunlap wrote: >> +hardware accelerators, and therefore are often used to offload cpu-intensive > > prefer:                                                           CPU- > throughout. Isn't that changing the meaning a b

[PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

2011-06-28 Thread Shubhrajyoti D
Currently the fifo depth is set to zero for OMAP4 which disables the FIFO usage. This patch enables the FIFO usage for I2C transactions on OMAP4 also. Reported-By:Nishanth Menon Signed-off-by: Shubhrajyoti D --- drivers/i2c/busses/i2c-omap.c |9 - 1 files changed, 4 insertions(+), 5

Re: [PATCH] OMAP: DSS: dispc: enable/disable clocks in error handler

2011-06-28 Thread Tomi Valkeinen
On Tue, 2011-06-28 at 09:19 -0700, Archit Taneja wrote: > Hi, > > On Monday 27 June 2011 10:31 AM, Dima Zavin wrote: > > There's no guarantee that the error handler worker thread > > will run while the dispc clocks are on. Explicitly enable/disable > > them. > > I agree with this. Yes, I think t

[PATCH v2 2/2] OMAP: HSMMC: Fix GPIO muxing

2011-06-28 Thread Silesh C V
Use generic gpio call to check the validity of the gpio. Note that this includes gpio 0 also which was missing before. Signed-off-by: Silesh C V --- arch/arm/mach-omap2/hsmmc.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/m

[PATCH v2 1/2] OMAP: 4430SDP: Register the card detect GPIO properly

2011-06-28 Thread Silesh C V
Without this the HSMMC driver takes GPIO 0 to be the card detect gpio and requests/configures it. This will give rise to issues when another driver needs to use GPIO 0. On 4430SDP, the card detection is through TWL 6030. Signed-off-by: Silesh C V --- Changes for v2 : - Made it a series to

Re: [PATCH] OMAP: HSMMC: Fix GPIO muxing

2011-06-28 Thread Silesh C V
Hi Igor, On Tue, Jun 28, 2011 at 10:50 PM, Igor Grinberg wrote: > Hi Silesh, > > > IMHO, you should not separate the patches > (this one and OMAP: 4430SDP: Register the card detect GPIO properly), > because the 4430sdp fix should come before or together with this patch, > otherwise 4430sdp will b

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Colin Cross
On Tue, Jun 28, 2011 at 4:46 PM, Russell King - ARM Linux wrote: > On Tue, Jun 28, 2011 at 04:37:08PM -0700, Colin Cross wrote: >> I don't think it affects bogomips - loops_per_jiffy can still be >> calibrated and updated by cpufreq, udelay just wont use them. > > No, you can't avoid it.  __delay(

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Russell King - ARM Linux
On Tue, Jun 28, 2011 at 04:37:08PM -0700, Colin Cross wrote: > I don't think it affects bogomips - loops_per_jiffy can still be > calibrated and updated by cpufreq, udelay just wont use them. No, you can't avoid it. __delay(), udelay(), and the global loops_per_jiffy are all linked together - for

Re: [RFC 7/8] drivers: introduce rpmsg, a remote-processor messaging bus

2011-06-28 Thread Randy Dunlap
On Tue, 21 Jun 2011 10:18:33 +0300 Ohad Ben-Cohen wrote: > Add a virtio-based IPC bus, which enables kernel users to communicate > with remote processors over shared memory using a simple messaging > protocol. > > Assign a local address for every local endpoint that is created, > and bind it to t

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Colin Cross
On Tue, Jun 28, 2011 at 4:17 PM, Russell King - ARM Linux wrote: > On Tue, Jun 28, 2011 at 03:58:57PM -0700, Colin Cross wrote: >> On Tue, Jun 28, 2011 at 3:55 PM, Russell King - ARM Linux >> wrote: >> > On Tue, Jun 28, 2011 at 03:29:57PM -0700, Colin Cross wrote: >> >> Can't this rewrite the loo

Re: [PATCHv2 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-28 Thread Kevin Hilman
+Rajendra Balaji T K writes: > add runtime pm support to HSMMC host controller > Use runtime pm API to enable/disable HSMMC clock > Use runtime autosuspend APIs to enable auto suspend delay > > Based on OMAP HSMMC runtime implementation by Kevin Hilman, Kishore Kadiyala > > Signed-off-by: Balaji

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Russell King - ARM Linux
On Tue, Jun 28, 2011 at 03:58:57PM -0700, Colin Cross wrote: > On Tue, Jun 28, 2011 at 3:55 PM, Russell King - ARM Linux > wrote: > > On Tue, Jun 28, 2011 at 03:29:57PM -0700, Colin Cross wrote: > >> Can't this rewrite the loops_per_jiffy for the other CPU while it is > >> in a udelay?  If it has

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Santosh Shilimkar
On 6/28/2011 4:03 PM, Russell King - ARM Linux wrote: On Tue, Jun 28, 2011 at 03:45:22PM -0700, Santosh Shilimkar wrote: The udelay code doesn't use the per-cpu lpj variable. It uses the global lpj. Secondly the calibration of no. of loops to be done is precalculateed so overwrite shouldn't impa

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Santosh Shilimkar
On 6/28/2011 4:00 PM, Santosh Shilimkar wrote: On 6/28/2011 3:53 PM, Colin Cross wrote: On Tue, Jun 28, 2011 at 3:45 PM, Santosh Shilimkar mailto:santosh.shilim...@ti.com>> wrote: [] Can't this rewrite the loops_per_jiffy for the other CPU while it is in a udelay? If it has already calcu

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Russell King - ARM Linux
On Tue, Jun 28, 2011 at 03:45:22PM -0700, Santosh Shilimkar wrote: > The udelay code doesn't use the per-cpu lpj variable. It uses the global > lpj. Secondly the calibration of no. of loops to be done is > precalculateed so overwrite shouldn't impact the scenario you mentioned. > > Though it has an

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Santosh Shilimkar
On 6/28/2011 3:53 PM, Colin Cross wrote: On Tue, Jun 28, 2011 at 3:45 PM, Santosh Shilimkar mailto:santosh.shilim...@ti.com>> wrote: [] Can't this rewrite the loops_per_jiffy for the other CPU while it is in a udelay? If it has already calculated the number of loops

Re: [RFC 7/8] drivers: introduce rpmsg, a remote-processor messaging bus

2011-06-28 Thread Ohad Ben-Cohen
On Wed, Jun 29, 2011 at 1:51 AM, Grant Likely wrote: > It's not the device_for_each_child() that you're 'putting' back from > here.  Its the original kref initialization when the device was > created. device_unregister() is already calling put_device(), doesn't that deal with the original kref in

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Colin Cross
On Tue, Jun 28, 2011 at 3:55 PM, Russell King - ARM Linux wrote: > On Tue, Jun 28, 2011 at 03:29:57PM -0700, Colin Cross wrote: >> Can't this rewrite the loops_per_jiffy for the other CPU while it is >> in a udelay?  If it has already calculated the number of loops >> necessary, and the CPU freque

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Colin Cross
On Tue, Jun 28, 2011 at 3:45 PM, Santosh Shilimkar wrote: > > On 6/28/2011 3:29 PM, Colin Cross wrote: >> >> >> >> On Fri, Jun 24, 2011 at 6:53 AM, Sanjeev Premi  wrote: >>> > >>> +#ifdef CONFIG_SMP >>> +       /* Adjust jiffies before transition */ >>> +       for_each_cpu(i, policy->cpus) { >

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Russell King - ARM Linux
On Tue, Jun 28, 2011 at 03:29:57PM -0700, Colin Cross wrote: > Can't this rewrite the loops_per_jiffy for the other CPU while it is > in a udelay? If it has already calculated the number of loops > necessary, and the CPU frequency increases, it could end up returning > too early from udelay. udel

Re: [RFC 7/8] drivers: introduce rpmsg, a remote-processor messaging bus

2011-06-28 Thread Grant Likely
On Tue, Jun 28, 2011 at 4:46 PM, Ohad Ben-Cohen wrote: > Hi Grant, > > On Tue, Jun 28, 2011 at 1:21 AM, Grant Likely > wrote: >>> +static int rpmsg_remove_device(struct device *dev, void *data) >>> +{ >>> +     struct rpmsg_channel *rpdev = to_rpmsg_channel(dev); >>> + >>> +     device_unregiste

Re: [RFC 7/8] drivers: introduce rpmsg, a remote-processor messaging bus

2011-06-28 Thread Ohad Ben-Cohen
Hi Grant, On Tue, Jun 28, 2011 at 1:21 AM, Grant Likely wrote: > Nice patch.  I'm quite thrilled to see this implemented.  Some > comments below, but otherwise I think it looks pretty good. Thanks ! >> +source "drivers/virtio/Kconfig" > > What happens when kvm and rpmsg both get enabled on the

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Santosh Shilimkar
On 6/28/2011 3:29 PM, Colin Cross wrote: On Fri, Jun 24, 2011 at 6:53 AM, Sanjeev Premi wrote: +#ifdef CONFIG_SMP + /* Adjust jiffies before transition */ + for_each_cpu(i, policy->cpus) { + unsigned long lpj = per_cpu(cpu_data, i).loops_per_jiffy; + +

Re: [PATCHv2] omap2+: pm: cpufreq: Fix loops_per_jiffy calculation

2011-06-28 Thread Colin Cross
On Fri, Jun 24, 2011 at 6:53 AM, Sanjeev Premi wrote: > > Currently, loops_per_jiffy is being calculated twice for > non-SMP processors. >  - Before calling cpufreq_notify_transition() >  - From within cpufreq_notify_transition() > > Double adjustment leads to incorrect value being assigned to >

Re: [PATCH v3 8/8] OMAP2+: hwmod: Follow the recommended PRCM module enable sequence

2011-06-28 Thread Cousson, Benoit
On 6/29/2011 12:03 AM, Nayak, Rajendra wrote: On 6/28/2011 6:05 AM, Cousson, Benoit wrote: Hi Kevin, On 6/28/2011 2:11 AM, Hilman, Kevin wrote: Benoit Coussonwrites: From: Rajendra Nayak On OMAP4, the PRCM recommended sequence for enabling a module after power-on-reset is: -1- Force clk

Re: [PATCH v3 8/8] OMAP2+: hwmod: Follow the recommended PRCM module enable sequence

2011-06-28 Thread Rajendra Nayak
On 6/28/2011 6:05 AM, Cousson, Benoit wrote: Hi Kevin, On 6/28/2011 2:11 AM, Hilman, Kevin wrote: Benoit Cousson writes: From: Rajendra Nayak On OMAP4, the PRCM recommended sequence for enabling a module after power-on-reset is: -1- Force clkdm to SW_WKUP -2- Enabling the clocks -3- Config

Re: [RFC 1/8] drivers: add generic remoteproc framework

2011-06-28 Thread Ohad Ben-Cohen
On Tue, Jun 28, 2011 at 2:29 AM, Russell King - ARM Linux wrote: > (Don't have the original message to reply to...) Sorry about that. My recent emails to linux-arm-kernel were bounced with a "Message has a suspicious header" reason. not sure what am I doing wrong.. > Do we really want to end up

Re: [PATCH v3 8/8] OMAP2+: hwmod: Follow the recommended PRCM module enable sequence

2011-06-28 Thread Rajendra Nayak
On 6/28/2011 2:33 PM, Cousson, Benoit wrote: On 6/28/2011 7:16 PM, Hilman, Kevin wrote: Benoit Cousson writes: From: Rajendra Nayak On OMAP4, the PRCM recommended sequence for enabling a module after power-on-reset is: -1- Force clkdm to SW_WKUP -2- Enabling the clocks -3- Configure desired m

Re: [RFC 1/8] drivers: add generic remoteproc framework

2011-06-28 Thread Ohad Ben-Cohen
Hi Grant, Thanks a lot for the exhaustive review and comments ! On Mon, Jun 27, 2011 at 11:49 PM, Grant Likely wrote: >> +     my_rproc = rproc_get("ipu"); > > I tend to be suspicious of apis whose primary interface is by-name > lookup.  It works fine when the system is small, but it can get > u

Re: [PATCH v3 8/8] OMAP2+: hwmod: Follow the recommended PRCM module enable sequence

2011-06-28 Thread Cousson, Benoit
On 6/28/2011 7:16 PM, Hilman, Kevin wrote: Benoit Cousson writes: From: Rajendra Nayak On OMAP4, the PRCM recommended sequence for enabling a module after power-on-reset is: -1- Force clkdm to SW_WKUP -2- Enabling the clocks -3- Configure desired module mode to "enable" or "auto" -4- Wait for

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-28 Thread Kevin Hilman
"T Krishnamoorthy, Balaji" writes: > On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley wrote: >> (cc'ing Adrian also) >> >> Hi Balaji >> >> On Wed, 22 Jun 2011, Balaji T K wrote: >> >>> Use runtime autosuspend APIs to enable auto suspend delay >> >> Does this really need to use runtime autosuspend

Re: [PATCH 2/7] OMAP: omap_device: Create clkdev entry for hwmod main_clk

2011-06-28 Thread Cousson, Benoit
On 6/28/2011 8:21 PM, Todd Poynor wrote: On Tue, Jun 28, 2011 at 04:10:55PM +0200, Cousson, Benoit wrote: On 6/27/2011 8:56 PM, Todd Poynor wrote: On Mon, Jun 27, 2011 at 06:33:06PM +0200, Benoit Cousson wrote: ... + r = clk_get_sys(dev_name(&od->pdev.dev), clk_alias); + if (!IS_ER

Re: [linux-pm] Runtime PM discussion notes

2011-06-28 Thread Paul Walmsley
Hello Arve, On Fri, 24 Jun 2011, Arve Hjønnevåg wrote: > On Fri, Jun 24, 2011 at 12:53 PM, Paul Walmsley wrote: > > > > As I understand it, in the original Android implementation, the hardware > > that they were using didn't have fine-grained power management.  So > > system-wide suspend made mo

Re: [PATCH] omap: iommu: fix pte attributes for super section

2011-06-28 Thread Anna, Suman
On Mon, May 16, 2011 at 2:11 AM, Hiroshi DOYU wrote: > From: "ext Anna, Suman" > Subject: [PATCH] omap: iommu: fix pte attributes for super section > Date: Tue, 10 May 2011 10:25:17 -0700 > >> From 5796d8d8a0ea5aee342b78ca6ead229971cff6c5 Mon Sep 17 00:00:00 2001 >> From: Suman Anna >> Date: Wed

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-28 Thread Paul Walmsley
On Tue, 28 Jun 2011, T Krishnamoorthy, Balaji wrote: > On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley wrote: > > > > On Wed, 22 Jun 2011, Balaji T K wrote: > > > >> Use runtime autosuspend APIs to enable auto suspend delay > > > > Does this really need to use runtime autosuspend?  Seems to me th

Re: [PATCH 2/7] OMAP: omap_device: Create clkdev entry for hwmod main_clk

2011-06-28 Thread Todd Poynor
On Tue, Jun 28, 2011 at 04:10:55PM +0200, Cousson, Benoit wrote: > On 6/27/2011 8:56 PM, Todd Poynor wrote: > >On Mon, Jun 27, 2011 at 06:33:06PM +0200, Benoit Cousson wrote: > >... > >>+ r = clk_get_sys(dev_name(&od->pdev.dev), clk_alias); > >>+ if (!IS_ERR(r)) { > >>+ pr_warning("om

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-28 Thread T Krishnamoorthy, Balaji
On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley wrote: > (cc'ing Adrian also) > > Hi Balaji > > On Wed, 22 Jun 2011, Balaji T K wrote: > >> Use runtime autosuspend APIs to enable auto suspend delay > > Does this really need to use runtime autosuspend?  Seems to me that since > PM runtime is just c

[PATCHv2 3/3] MMC: OMAP: HSMMC: Remove unused iclk

2011-06-28 Thread Balaji T K
After runtime conversion to handle clk, iclk node is not used However fclk node is still used to get clock rate. Signed-off-by: Balaji T K --- drivers/mmc/host/omap_hsmmc.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/

[PATCHv2 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-28 Thread Balaji T K
add runtime pm support to HSMMC host controller Use runtime pm API to enable/disable HSMMC clock Use runtime autosuspend APIs to enable auto suspend delay Based on OMAP HSMMC runtime implementation by Kevin Hilman, Kishore Kadiyala Signed-off-by: Balaji T K --- changes since v1 Removed pm_runtim

[PATCHv2 1/3] MMC: OMAP: HSMMC: Remove lazy_disable

2011-06-28 Thread Balaji T K
lazy_disable framework in OMAP HSMMC manages multiple low power states and Card is powered off after inactivity time of 8 seconds. Based on previous discussion on the list, card power (regulator) handling (when to power OFF/ON) should ideally be handled by core layer. Remove usage of lazy disable t

[PATCHv2 0/3] OMAP: HSMMC: cleanup and runtime pm

2011-06-28 Thread Balaji T K
Removing the custom state machine - lazy disable framework in omap_hsmmc to make way for runtime pm to handle host controller power states. This allows mmc_host_enable/mmc_host_disable to be replaced by runtime get_sync and put_sync at host controller driver. Enable runtime PM in omap_hsmmc Rebas

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-28 Thread Paul Walmsley
(cc'ing Adrian also) Hi Balaji On Wed, 22 Jun 2011, Balaji T K wrote: > Use runtime autosuspend APIs to enable auto suspend delay Does this really need to use runtime autosuspend? Seems to me that since PM runtime is just controlling the MMC IP blocks and not the regulators in this instance,

Re: [PATCH v3 8/8] OMAP2+: hwmod: Follow the recommended PRCM module enable sequence

2011-06-28 Thread Kevin Hilman
Benoit Cousson writes: > From: Rajendra Nayak > > On OMAP4, the PRCM recommended sequence for enabling > a module after power-on-reset is: > -1- Force clkdm to SW_WKUP > -2- Enabling the clocks > -3- Configure desired module mode to "enable" or "auto" > -4- Wait for the desired module idle statu

Re: [PATCH] OMAP: DSS: dispc: enable/disable clocks in error handler

2011-06-28 Thread Archit Taneja
Hi, On Monday 27 June 2011 10:31 AM, Dima Zavin wrote: There's no guarantee that the error handler worker thread will run while the dispc clocks are on. Explicitly enable/disable them. I agree with this. Tomi, We could get prevent scheduling of the error worker by registering omap_dispc_irq

Re: [RFC] OMAP3: powerdomains: Match silicon revision to select the correct "core_pwrdm" definition

2011-06-28 Thread Kevin Hilman
"Koyamangalath, Abhilash" writes: > powerdomains3xxx_data.c defines core_3xxx_pre_es3_1_pwrdm and > core_3xxx_es3_1_pwrdm to take care of differences in "core_pwrdm" > implementations across revisions. > However,_pwrdm_lookup("core_pwrdm") always matches the first definition for > 3630 ES 1.1 and

Re: [PATCH 6/7] OMAP4: hwmod data: TEMP: Fix timer1 main_clk

2011-06-28 Thread Kevin Hilman
"Cousson, Benoit" writes: > On 6/28/2011 2:19 AM, Hilman, Kevin wrote: >> Benoit Cousson writes: >> >>> Since the timer is still not pm_runtime adapted, it is still >>> using directly the physical clock nodes at init time. >>> >>> Replace the clock node by the original one in the clock data >>>

Re: [PATCH] omap1: select GENERIC_IRQ_CHIP for TI OMAP1

2011-06-28 Thread Kevin Hilman
Axel Lin writes: > The gpio-omap driver has been converted to use generic IRQ chip. > Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error. > > LD vmlinux > drivers/built-in.o: In function `omap_mpuio_alloc_gc': > drivers/gpio/gpio-omap.c:1087: undefined reference to `irq_all

Re: [PATCH] OMAP1: enable GENERIC_IRQ_CHIP

2011-06-28 Thread Kevin Hilman
On Tue, 2011-06-14 at 04:50 -0700, Tony Lindgren wrote: > * Kevin Hilman [110607 16:58]: > > OMAP1 needs this also since GPIO driver (common for all OMAPs) is > > being converted to use generic IRQ chip. > > > > Signed-off-by: Kevin Hilman > > Maybe queue this together with your GPIO patches? >

Re: [PATCH 0/7] OMAP4: Add modulemode support to hwmod framework (part 2)

2011-06-28 Thread Cousson, Benoit
Hi Kevin, On 6/28/2011 2:30 AM, Hilman, Kevin wrote: Hi Benoit, Benoit Cousson writes: Here is the second part of the modulemode series. The goal here is to do the cleanup on the clock nodes and PRCM macros that are not needed anymore by the hwmod data. Some macros are still needed because o

Re: [PATCH 2/7] OMAP: omap_device: Create clkdev entry for hwmod main_clk

2011-06-28 Thread Cousson, Benoit
On 6/27/2011 8:56 PM, Todd Poynor wrote: On Mon, Jun 27, 2011 at 06:33:06PM +0200, Benoit Cousson wrote: ... + r = clk_get_sys(dev_name(&od->pdev.dev), clk_alias); + if (!IS_ERR(r)) { + pr_warning("omap_device: %s: %s already exist\n", + dev_nam

Re: [PATCH] OMAP: HSMMC: Fix GPIO muxing

2011-06-28 Thread Igor Grinberg
Hi Silesh, On 06/28/11 11:45, Silesh C V wrote: > Use generic gpio call to check the validity of the gpio. Note that > this includes gpio 0 also which was missing before. > > Signed-off-by: Silesh C V > --- > arch/arm/mach-omap2/hsmmc.c |7 +++ > 1 files changed, 3 insertions(+), 4 dele

RE: [RFC PATCHv5 1/7] HSI: hsi: Introducing HSI framework

2011-06-28 Thread Sjur BRENDELAND
Hi Carlos, > > What about information about the supported transmission speeds? > > Is it any way to obtain this information, so we can know the legal > > values for speed in hsi_config? > > For TX speed sets the max tx speed the HSI should go. The controller > driver will try to get as close as

Re: [PATCH v3 8/8] OMAP2+: hwmod: Follow the recommended PRCM module enable sequence

2011-06-28 Thread Cousson, Benoit
Hi Kevin, On 6/28/2011 2:11 AM, Hilman, Kevin wrote: > Benoit Cousson writes: > >> From: Rajendra Nayak >> >> On OMAP4, the PRCM recommended sequence for enabling >> a module after power-on-reset is: >> -1- Force clkdm to SW_WKUP >> -2- Enabling the clocks >> -3- Configure desired module mode to

Re: [PATCH] OMAP: HSMMC: Fix GPIO muxing

2011-06-28 Thread S, Venkatraman
On Tue, Jun 28, 2011 at 2:15 PM, Silesh C V wrote: > Use generic gpio call to check the validity of the gpio. Note that > this includes gpio 0 also which was missing before. > > Signed-off-by: Silesh C V > --- >  arch/arm/mach-omap2/hsmmc.c |    7 +++ >  1 files changed, 3 insertions(+), 4 de

Re: [RFC 0/8] Introducing a generic AMP/IPC framework

2011-06-28 Thread Brian Swetland
On Tue, Jun 28, 2011 at 4:26 AM, Ohad Ben-Cohen wrote: > On Tue, Jun 28, 2011 at 12:22 AM, Grosen, Mark wrote: >> 2. We added a special section (resource table) that is interpreted as part >> of the loading process. The tool that generates our simple format just >> recognizes a named section (".r

Re: [RFC 0/8] Introducing a generic AMP/IPC framework

2011-06-28 Thread Ohad Ben-Cohen
On Tue, Jun 28, 2011 at 12:22 AM, Grosen, Mark wrote: > 2. We added a special section (resource table) that is interpreted as part > of the loading process. The tool that generates our simple format just > recognizes a named section (".resource_table"), so perhaps that could be > done with the PIL

Re: [RFC 6/8] davinci: da850: add remoteproc dsp device

2011-06-28 Thread Sergei Shtylyov
Hello. On 21.06.2011 11:18, Ohad Ben-Cohen wrote: From: Mark Grosen Add davinci remoteproc device for the da850's C674x dsp remote processor, and support it on the da850-evm and omapl138-hawk boards. Signed-off-by: Mark Grosen Signed-off-by: Ohad Ben-Cohen [...] diff --git a/arch/arm/

[PATCH] OMAP: board-omap3evm: Fix compillation error

2011-06-28 Thread Peter Ujfalusi
Signed-off-by: Peter Ujfalusi --- Hello Tony, While rebasing my series on top of your devel-cleanup branch, I found this compillation error. You can pick it right away, or I can queue this within my series. But I still waiting for Samuel's saying on the series, so it might be faster if you just

[RFC] OMAP3: powerdomains: Match silicon revision to select the correct "core_pwrdm" definition

2011-06-28 Thread Koyamangalath, Abhilash
powerdomains3xxx_data.c defines core_3xxx_pre_es3_1_pwrdm and core_3xxx_es3_1_pwrdm to take care of differences in "core_pwrdm" implementations across revisions. However,_pwrdm_lookup("core_pwrdm") always matches the first definition for 3630 ES 1.1 and 1.2 which is incorrect. This patch fixes this

Re: [PATCH 3/7] OMAP4: hwmod data: TEMP: Do not idle MMC1 & MMC2 after boot

2011-06-28 Thread Cousson, Benoit
On 6/28/2011 2:17 AM, Hilman, Kevin wrote: Benoit Cousson writes: Since the MMC driver is not pm_runtime adapted, do not put them in idle after boot. It will allow the driver to work as expected until the migration to pm_runtime. Signed-off-by: Benoit Cousson Cc: Paul Walmsley Cc: Rajendra Na

RE: [RFC 5/8] remoteproc: add davinci implementation

2011-06-28 Thread Nori, Sekhar
Hi Mark, On Mon, Jun 27, 2011 at 23:50:25, Grosen, Mark wrote: > > >>> +static inline int davinci_rproc_start(struct rproc *rproc, u64 > > >> bootaddr) > > >>> +{ > > >>> + struct device *dev = rproc->dev; > > >>> + struct davinci_rproc_pdata *pdata = dev->platform_data; > > >>> +

Re: [PATCH 6/7] OMAP4: hwmod data: TEMP: Fix timer1 main_clk

2011-06-28 Thread Cousson, Benoit
On 6/28/2011 2:19 AM, Hilman, Kevin wrote: > Benoit Cousson writes: > >> Since the timer is still not pm_runtime adapted, it is still >> using directly the physical clock nodes at init time. >> >> Replace the clock node by the original one in the clock data >> file. >> >> Keep the original name u

Re: [PATCH 0/7] OMAP4: Add modulemode support to hwmod framework (part 2)

2011-06-28 Thread Tomi Valkeinen
On Tue, 2011-06-28 at 11:14 +0200, Cousson, Benoit wrote: > On 6/28/2011 10:29 AM, Valkeinen, Tomi wrote: > > My current pm_runtime patch set removes the omapdss clock aliases from > > arch/arm/mach-omap2/clock44xx_data.c, as the driver uses the opt-clock > > names. Isn't that correct way? > > Ye

Re: [PATCH 0/7] OMAP4: Add modulemode support to hwmod framework (part 2)

2011-06-28 Thread Cousson, Benoit
On 6/28/2011 10:29 AM, Valkeinen, Tomi wrote: On Tue, 2011-06-28 at 10:14 +0200, Cousson, Benoit wrote: On 6/28/2011 8:56 AM, Valkeinen, Tomi wrote: On Mon, 2011-06-27 at 18:33 +0200, Benoit Cousson wrote: Hi Paul, Here is the second part of the modulemode series. The goal here is to do the c

[PATCH] omap1: select GENERIC_IRQ_CHIP for TI OMAP1

2011-06-28 Thread Axel Lin
The gpio-omap driver has been converted to use generic IRQ chip. Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error. LD vmlinux drivers/built-in.o: In function `omap_mpuio_alloc_gc': drivers/gpio/gpio-omap.c:1087: undefined reference to `irq_alloc_generic_chip' drivers/gpio/

[PATCH] OMAP: HSMMC: Fix GPIO muxing

2011-06-28 Thread Silesh C V
Use generic gpio call to check the validity of the gpio. Note that this includes gpio 0 also which was missing before. Signed-off-by: Silesh C V --- arch/arm/mach-omap2/hsmmc.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/m

Re: [PATCH 4/7] OMAP4: hwmod data: Replace main_clk with the real input clock

2011-06-28 Thread Tomi Valkeinen
On Tue, 2011-06-28 at 10:27 +0200, Cousson, Benoit wrote: > On 6/28/2011 10:14 AM, Valkeinen, Tomi wrote: > > On Tue, 2011-06-28 at 10:10 +0200, Cousson, Benoit wrote: > >> Hi Tomi, > >> > >> On 6/28/2011 8:40 AM, Valkeinen, Tomi wrote: > >>> On Mon, 2011-06-27 at 18:33 +0200, Benoit Cousson wrote:

Re: [PATCH 0/7] OMAP4: Add modulemode support to hwmod framework (part 2)

2011-06-28 Thread Tomi Valkeinen
On Tue, 2011-06-28 at 10:14 +0200, Cousson, Benoit wrote: > On 6/28/2011 8:56 AM, Valkeinen, Tomi wrote: > > On Mon, 2011-06-27 at 18:33 +0200, Benoit Cousson wrote: > >> Hi Paul, > >> > >> Here is the second part of the modulemode series. > >> The goal here is to do the cleanup on the clock nodes

Re: [PATCH 4/7] OMAP4: hwmod data: Replace main_clk with the real input clock

2011-06-28 Thread Cousson, Benoit
On 6/28/2011 10:14 AM, Valkeinen, Tomi wrote: On Tue, 2011-06-28 at 10:10 +0200, Cousson, Benoit wrote: Hi Tomi, On 6/28/2011 8:40 AM, Valkeinen, Tomi wrote: On Mon, 2011-06-27 at 18:33 +0200, Benoit Cousson wrote: Previously, main_clk was a fake clock node that was accessing the PRCM modulem

Re: [PATCH 4/7] OMAP4: hwmod data: Replace main_clk with the real input clock

2011-06-28 Thread Tomi Valkeinen
On Tue, 2011-06-28 at 10:10 +0200, Cousson, Benoit wrote: > Hi Tomi, > > On 6/28/2011 8:40 AM, Valkeinen, Tomi wrote: > > On Mon, 2011-06-27 at 18:33 +0200, Benoit Cousson wrote: > >> Previously, main_clk was a fake clock node that was accessing the > >> PRCM modulemode register. Since the module

Re: [PATCH 0/7] OMAP4: Add modulemode support to hwmod framework (part 2)

2011-06-28 Thread Cousson, Benoit
On 6/28/2011 8:56 AM, Valkeinen, Tomi wrote: On Mon, 2011-06-27 at 18:33 +0200, Benoit Cousson wrote: Hi Paul, Here is the second part of the modulemode series. The goal here is to do the cleanup on the clock nodes and PRCM macros that are not needed anymore by the hwmod data. Some macros are s

Re: [PATCH 4/7] OMAP4: hwmod data: Replace main_clk with the real input clock

2011-06-28 Thread Cousson, Benoit
Hi Tomi, On 6/28/2011 8:40 AM, Valkeinen, Tomi wrote: On Mon, 2011-06-27 at 18:33 +0200, Benoit Cousson wrote: Previously, main_clk was a fake clock node that was accessing the PRCM modulemode register. Since the module mode is directly controlled by the hwmod fmwk, these fake clock node are no

Re: [PATCH 0/7] OMAP4: Add modulemode support to hwmod framework (part 2)

2011-06-28 Thread Tomi Valkeinen
On Mon, 2011-06-27 at 18:33 +0200, Benoit Cousson wrote: > Hi Paul, > > Here is the second part of the modulemode series. > The goal here is to do the cleanup on the clock nodes and PRCM macros > that are not needed anymore by the hwmod data. > Some macros are still needed because of clock data.