[PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-24 Thread Ameya Palande
-by: Ameya Palande ameya.pala...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 08e86d7..053cc15 100644 --- a/arch/arm/mach-omap2

[PATCH] OMAP4: Clock: Force a DPLL clkdm/pwrdm ON before a relock

2012-01-19 Thread Ameya Palande
of USB DPLL. CC: Nishanth Menon n...@ti.com Tested-by: Ameya Palande ameya.pala...@ti.com Signed-off-by: Rajendra Nayak rna...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm

[PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL

2012-01-18 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 08e86d7..053cc15 100644 --- a/arch/arm/mach

Re: [PATCHv2] omap: rx51: Platform support for lp5523 led chip

2011-04-05 Thread Ameya Palande
Hi Felipe, On 03/31/2011 06:44 PM, ext Felipe Balbi wrote: On Thu, Mar 31, 2011 at 06:30:32PM +0300, Ameya Palande wrote: Hi Felipe, On 03/31/2011 05:26 PM, ext Felipe Balbi wrote: Hi, On Thu, Mar 31, 2011 at 04:38:12PM +0300, Ameya Palande wrote: +static int rx51_lp5523_setup(void

Re: RX-51: Platform support for lp5523

2011-04-05 Thread Ameya Palande
the lp5523 chip? The chip driver itself is in the mainline kernel since 2.6.37-rc2. Got a patch for that? As always, patches related to blinking leds have a special high priority here! :) Ameya Palande has written one, which is available at [0]. I added him to CC, so that he can comment

Re: RX-51: Platform support for lp5523

2011-04-05 Thread Ameya Palande
On 04/05/2011 03:19 PM, ext Felipe Balbi wrote: On Tue, Apr 05, 2011 at 03:10:41PM +0300, Ameya Palande wrote: Hi Tony, On 03/29/2011 10:33 PM, ext Tony Lindgren wrote: * Sebastian Reichels...@debian.org [110329 11:13]: On Tue, Mar 29, 2011 at 10:36:47AM -0700, Tony Lindgren wrote

Re: RX-51: Platform support for lp5523

2011-04-05 Thread Ameya Palande
On 04/05/2011 03:30 PM, ext Felipe Balbi wrote: On Tue, Apr 05, 2011 at 03:23:12PM +0300, Ameya Palande wrote: On 04/05/2011 03:19 PM, ext Felipe Balbi wrote: On Tue, Apr 05, 2011 at 03:10:41PM +0300, Ameya Palande wrote: Hi Tony, On 03/29/2011 10:33 PM, ext Tony Lindgren wrote: * Sebastian

Re: RX-51: Platform support for lp5523

2011-04-05 Thread Ameya Palande
Hi Felipe, On 04/05/2011 03:38 PM, ext Felipe Balbi wrote: Hi, On Tue, Apr 05, 2011 at 03:34:08PM +0300, Ameya Palande wrote: Exactly, adding a new feature. Let me put it this way: which bug or regression are you fixing with this patch ? I never claimed that it is fixing a bug/regression

Re: [PATCHv2] omap: rx51: Platform support for lp5523 led chip

2011-04-01 Thread Ameya Palande
Hi Felipe, On 03/31/2011 06:44 PM, ext Felipe Balbi wrote: On Thu, Mar 31, 2011 at 06:30:32PM +0300, Ameya Palande wrote: Hi Felipe, On 03/31/2011 05:26 PM, ext Felipe Balbi wrote: Hi, On Thu, Mar 31, 2011 at 04:38:12PM +0300, Ameya Palande wrote: +static int rx51_lp5523_setup(void

[PATCHv3] omap: rx51: Platform support for lp5523 led chip

2011-04-01 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Mathias Nyman mathias.ny...@nokia.com --- arch/arm/mach-omap2/board-rx51-peripherals.c | 66 ++ 1 files changed, 66 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51

[PATCH] omap: rx51: Platform support for lp5523 led chip

2011-03-31 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Mathias Nyman mathias.ny...@nokia.com --- arch/arm/mach-omap2/board-rx51-peripherals.c | 81 ++ 1 files changed, 81 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51

Re: RX-51: Platform support for lp5523

2011-03-31 Thread Ameya Palande
the lp5523 chip? The chip driver itself is in the mainline kernel since 2.6.37-rc2. Got a patch for that? As always, patches related to blinking leds have a special high priority here! :) Ameya Palande has written one, which is available at [0]. I added him to CC, so that he can comment

[PATCHv2] omap: rx51: Platform support for lp5523 led chip

2011-03-31 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Mathias Nyman mathias.ny...@nokia.com --- arch/arm/mach-omap2/board-rx51-peripherals.c | 74 ++ 1 files changed, 74 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51

Re: [PATCHv2] omap: rx51: Platform support for lp5523 led chip

2011-03-31 Thread Ameya Palande
Hi Felipe, On 03/31/2011 05:26 PM, ext Felipe Balbi wrote: Hi, On Thu, Mar 31, 2011 at 04:38:12PM +0300, Ameya Palande wrote: +static int rx51_lp5523_setup(void) +{ + int err; + + err = gpio_request_one(RX51_LP5523_CHIP_EN_GPIO, GPIOF_DIR_OUT, + lp5523_enable

[PATCHv2] OMAP3: Keypad: Fix failure exit path in probe

2010-09-07 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@nokia.com Cc: Tony Lindgren t...@atomide.com --- drivers/input/keyboard/twl4030_keypad.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c

Re: [PATCHv2 2/2] omap: rx51: add support for USB chargers

2010-08-20 Thread Ameya Palande
Hi Heikki, On Thu, 2010-08-19 at 15:09 +0200, Krogerus Heikki (EXT-Teleca/Helsinki) wrote: On Thu, Aug 19, 2010 at 02:40:42PM +0200, ext Anton Vorontsov wrote: On Thu, Aug 19, 2010 at 03:09:37PM +0300, Krogerus Heikki (EXT-Teleca/Helsinki) wrote: @@ -909,5 +913,6 @@ void __init

Re: [PATCH] Board changes for gpio-keys

2010-08-20 Thread Ameya Palande
Hi Shubhrajyoti, On Fri, 2010-08-20 at 10:12 +0200, ext Shubhrajyoti D wrote: Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c | 64 +++ 1 files changed, 64 insertions(+), 0 deletions(-) It will be nice if you can

DSS2 broken with 36-rc1

2010-08-16 Thread Ameya Palande
Hi Tomi, When I tried to boot 2.6.36-rc1 kernel on Nokia N900, omapfb failed with following error messages: [0.124145] OMAP DSS rev 2.0 [0.124237] OMAP DISPC rev 3.0 [0.303833] acx565akm spi1.2: omapfb: acx565akm rev 8b LCD detected [0.805419] omapfb omapfb: failed to allocate

Re: DSS2 broken with 36-rc1

2010-08-16 Thread Ameya Palande
On Mon, 2010-08-16 at 14:59 +0200, ext Pawel Moll wrote: Hi Ameya, [0.805419] omapfb omapfb: failed to allocate framebuffer [0.810882] omapfb omapfb: failed to allocate fbmem [0.815856] omapfb omapfb: failed to setup omapfb [0.820648] omapfb: probe of omapfb failed with

Re: [PATCH v2] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-12 Thread Ameya Palande
wakeups. Found when debugging PM/CPUidle related problems reported by Ameya Palande ameya.pala...@nokia.com. Problems were triggered particularily on boards with UART2 consoles (n900, Overo) since UART2 is in the PER powerdomain. Tested on l-o master (omap3_defonfig + CONFIG_CPU_IDLE=y

Re: [PATCH v2] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-12 Thread Ameya Palande
On Thu, 2010-08-12 at 13:51 +0200, ext Tony Lindgren wrote: * Ameya Palande ameya.pala...@nokia.com [100812 13:28]: Hi Kevin, On Wed, 2010-08-11 at 18:03 +0200, ext Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com Commit 5a5f561 (convert OMAP3 PRCM macros to the _SHIFT/_MASK

CONFIG_CPU_IDLE broken for N900

2010-08-10 Thread Ameya Palande
Hi, When I enable CONFIG_CPU_IDLE and boot kernel, it hangs around the point when it switches to user space. I am able to reproduce this for 2.6.35 on linux-omap and linux-2.6 trees. Has anyone else noticed the same thing for omap3 based boards? Cheers, Ameya. -- To unsubscribe from this list:

Re: CONFIG_CPU_IDLE broken for N900

2010-08-10 Thread Ameya Palande
On Tue, 2010-08-10 at 14:21 +0200, Palande Ameya (Nokia-MS/Helsinki) wrote: Hi, When I enable CONFIG_CPU_IDLE and boot kernel, it hangs around the point when it switches to user space. I am able to reproduce this for 2.6.35 on linux-omap and linux-2.6 trees. Has anyone else noticed the

Re: CONFIG_CPU_IDLE broken for N900

2010-08-10 Thread Ameya Palande
Hi Jarkko, On Tue, 2010-08-10 at 15:03 +0200, ext Jarkko Nikula wrote: On Tue, 10 Aug 2010 15:35:18 +0300 Ameya Palande ameya.pala...@nokia.com wrote: When I enable CONFIG_CPU_IDLE and boot kernel, it hangs around the point when it switches to user space. I am able to reproduce

Re: [PATCH 09/13] tsl2563 ALS support for Nokia N900

2010-07-08 Thread Ameya Palande
Hi Tony, On Wed, 2010-07-07 at 11:44 +0200, ext Tony Lindgren wrote: From: Ameya Palande ameya.pala...@nokia.com This commit will enable usage of tsl2563 ambient light sensor on Nokia N900. Signed-off-by: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Tony Lindgren t...@atomide.com

Re: [PATCH 0/2] dspbridge: reorganize initialization and probe

2010-06-09 Thread Ameya Palande
On Wed, 2010-06-09 at 09:25 +0200, ext Felipe Contreras wrote: On Wed, Jun 9, 2010 at 3:48 AM, Omar Ramirez Luna omar.rami...@ti.com wrote: Split the functions to have cleaner error handling paths, this will aslo cover a case where bridge initialization has failed but device entry is still

[PATCH] tsl2563 ALS support for Nokia N900

2010-05-19 Thread Ameya Palande
This commit will enable usage of tsl2563 ambient light sensor on Nokia N900. Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/mach-omap2/board-rx51-peripherals.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51

[PATCH] twl4030_wdt: Disable watchdog while probing

2010-05-17 Thread Ameya Palande
If we are not able to register then it is better to have watchdog in disabled state than noticing a system reboot. Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/watchdog/twl4030_wdt.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/watchdog

Re: Upstream linux-omap kernel on Nokia N900?

2010-04-20 Thread Ameya Palande
On Tue, 2010-04-20 at 10:36 +0200, Quadros Roger (Nokia-D/Helsinki) wrote: ext Tony Lindgren wrote: * Roger Quadros roger.quad...@nokia.com [100419 05:06]: Balbi Felipe (Nokia-D/Helsinki) wrote: Hi, On Mon, Apr 19, 2010 at 01:49:15PM +0200, ext Arnaud Ebalard wrote: Nokia N900 is

Re: [dspbridge] news: omap mailbox implementation

2010-03-23 Thread Ameya Palande
Hi Omar, On Tue, 2010-03-23 at 19:08 +0100, ext Omar Ramirez Luna wrote: Hi All, When updating the custom dspbridge mailbox functions with the ones avaliable through omap mailbox (by pulling latest dspbridge), PLEASE remember to enable omap mailbox through menuconfig: make menuconfig

Re: [dspbridge] news: omap mailbox implementation

2010-03-23 Thread Ameya Palande
On Tue, 2010-03-23 at 19:29 +0100, ext Omar Ramirez Luna wrote: On 3/23/2010 12:54 PM, Ameya Palande wrote: Hi Omar, On Tue, 2010-03-23 at 19:08 +0100, ext Omar Ramirez Luna wrote: Hi All, When updating the custom dspbridge mailbox functions with the ones avaliable through omap

Re: PATCH] DSPBRIDGE: MMU-Fault debugging enhancements

2010-03-05 Thread Ameya Palande
Hi Ernesto, On Fri, 2010-03-05 at 01:39 +0100, ext Ramos Falcon, Ernesto wrote: From 1d7f5d634176be558d5a60e26ee2bdeddffd7d3b Mon Sep 17 00:00:00 2001 From: Cris Jansson cjans...@ti.com Date: Thu, 25 Feb 2010 11:38:23 -0600 Subject: [PATCH] DSPBRIDGE: MMU-Fault debugging enhancements These

RE: [PATCHv4 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Ameya Palande
Hi Fernando, On Thu, 2010-02-18 at 02:52 +0100, ext Guzman Lugo, Fernando wrote: Hi, -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Wednesday, February 17, 2010 12:06 PM To: linux-omap@vger.kernel.org Cc: felipe.contre...@nokia.com; Menon, Nishanth

[PATCHv5 0/4] DSPBRIDGE: Improved reserved and mapped resource cleanup

2010-02-18 Thread Ameya Palande
PROC_UnReserveMemory() http://marc.info/?l=linux-omapm=126637211831587w=2 3. Rebased patchset on top of following commit: DSPBRIDGE: Remove conditional check from the InputMsg function Changed since v1: 1. Reduced indentation http://marc.info/?l=linux-omapm=126624982331523w=2 Ameya Palande (4

[PATCH 2/4] DSPBRIDGE: New reserved memory accounting framework

2010-02-18 Thread Ameya Palande
DSP_RSV_OBJECT is introduced to track reserved memory accounting information. This will allow us to do proper cleanup for memory reserved using PROC_ReserveMemory(). Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/drv.h | 10 arch/arm/plat

[PATCH 1/4] DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT

2010-02-18 Thread Ameya Palande
In its current state DMM_RES_OBJECT is not correctly tracking reserve and unreserve but only map and unmap. So lets rename it to DMM_MAP_OBJECT to clarify what it is really doing! In addition to this, this patch also does some trivial code cleanup. Signed-off-by: Ameya Palande ameya.pala

[PATCH 3/4] DSPBRIDGE: Fix memory corruption in DRV_ProcFreeDMMRes

2010-02-18 Thread Ameya Palande
-by: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Felipe Contreras felipe.contre...@nokia.com --- drivers/dsp/bridge/rmgr/drv.c | 12 ++-- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/drv.c b/drivers/dsp/bridge/rmgr/drv.c index 12ba7e0

[PATCH 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Ameya Palande
as they are not needed anymore: DRV_ProcFreeDMMRes() DRV_UpdateDMMResElement() DRV_InsertDMMResElement() DRV_GetDMMResElement() DRV_RemoveDMMResElement() Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/drv.h | 30 +--- .../plat-omap/include

Re: [PATCHv4 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Ameya Palande
Hi Felipe, On Thu, 2010-02-18 at 15:27 +0100, Contreras Felipe (Nokia-D/Helsinki) wrote: On Thu, Feb 18, 2010 at 01:15:55PM +0100, Ameya Palande wrote: On Thu, 2010-02-18 at 02:52 +0100, ext Guzman Lugo, Fernando wrote: What do you think about it? Instead of removing

RE: [PATCHv4 2/4] DSPBRIDGE: New reserved memory accounting framework

2010-02-18 Thread Ameya Palande
Hi Fernando, On Thu, 2010-02-18 at 02:40 +0100, ext Guzman Lugo, Fernando wrote: Hi, -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Wednesday, February 17, 2010 12:06 PM To: linux-omap@vger.kernel.org Cc: felipe.contre...@nokia.com; Menon, Nishanth

Re: [RESEND] [PATCH] DSPBRIDGE: Adding protection Resource cleanup linked lists

2010-02-17 Thread Ameya Palande
Hi Fernando, On Wed, 2010-02-10 at 09:32 +0100, ext Guzman Lugo, Fernando wrote: Please discard previous one. Regards, Fernando. From 6bcdc02f6265246e385194433775e75db7ad44cf Mon Sep 17 00:00:00 2001 From: Fernando Guzman Lugo x0095...@ti.com Date: Wed, 10 Feb 2010 02:31:40 -0600

[PATCHv3 1/2] DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT

2010-02-17 Thread Ameya Palande
In its current state DMM_RES_OBJECT is not correctly tracking reserve and unreserve but only map and unmap. So lets rename it to DMM_MAP_OBJECT to clarify what it is really doing! In addition to this, this patch also does some trivial code cleanup. Signed-off-by: Ameya Palande ameya.pala

[PATCHv3 0/2] DSPBRIDGE: Improved reserved memory cleanup

2010-02-17 Thread Ameya Palande
=126637211831587w=2 3. Rebased patchset on top of following commit: DSPBRIDGE: Remove conditional check from the InputMsg function Changed since v1: 1. Reduced indentation http://marc.info/?l=linux-omapm=126624982331523w=2 Ameya Palande (2): DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT

[PATCHv3 2/2] DSPBRIDGE: New reserved memory accounting framework

2010-02-17 Thread Ameya Palande
DSP_RSV_OBJECT is introduced to track reserved memory accounting information. This will allow us to do proper cleanup for memory reserved using PROC_ReserveMemory(). Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/drv.h | 10 + arch/arm/plat

[PATCHv2] DSPBRIDGE: Fix memory corruption in DRV_ProcFreeDMMRes

2010-02-17 Thread Ameya Palande
-by: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Felipe Contreras felipe.contre...@nokia.com --- Changes since V1: 1. Rebased on top of: [PATCHv3 0/2] DSPBRIDGE: Improved reserved memory cleanup drivers/dsp/bridge/rmgr/drv.c | 12 ++-- 1 files changed, 2 insertions(+), 10 deletions

[PATCHv4 1/4] DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT

2010-02-17 Thread Ameya Palande
In its current state DMM_RES_OBJECT is not correctly tracking reserve and unreserve but only map and unmap. So lets rename it to DMM_MAP_OBJECT to clarify what it is really doing! In addition to this, this patch also does some trivial code cleanup. Signed-off-by: Ameya Palande ameya.pala

[PATCHv4 3/4] DSPBRIDGE: Fix memory corruption in DRV_ProcFreeDMMRes

2010-02-17 Thread Ameya Palande
-by: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Felipe Contreras felipe.contre...@nokia.com --- drivers/dsp/bridge/rmgr/drv.c | 12 ++-- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/drv.c b/drivers/dsp/bridge/rmgr/drv.c index 12ba7e0..b88b5a3

[PATCHv4 0/4] DSPBRIDGE: Improved reserved and mapped resource cleanup

2010-02-17 Thread Ameya Palande
PROC_UnReserveMemory() http://marc.info/?l=linux-omapm=126637211831587w=2 3. Rebased patchset on top of following commit: DSPBRIDGE: Remove conditional check from the InputMsg function Changed since v1: 1. Reduced indentation http://marc.info/?l=linux-omapm=126624982331523w=2 Ameya Palande (4

[PATCHv4 2/4] DSPBRIDGE: New reserved memory accounting framework

2010-02-17 Thread Ameya Palande
DSP_RSV_OBJECT is introduced to track reserved memory accounting information. This will allow us to do proper cleanup for memory reserved using PROC_ReserveMemory(). Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/drv.h | 10 + arch/arm/plat

[PATCHv4 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-17 Thread Ameya Palande
as they are not needed anymore: DRV_ProcFreeDMMRes() DRV_UpdateDMMResElement() DRV_InsertDMMResElement() DRV_GetDMMResElement() DRV_RemoveDMMResElement() Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/drv.h | 30 +--- .../plat-omap/include

Re: [PATCH] DSPBRIDGE: Fix memory corruption in DRV_ProcFreeDMMRes

2010-02-16 Thread Ameya Palande
Hi Felipe, On Mon, 2010-02-15 at 16:59 +0100, Contreras Felipe (Nokia-D/Helsinki) wrote: On Mon, Feb 15, 2010 at 04:36:31PM +0100, Ameya Palande wrote: This patch fixes following issues: 1. pDMMRes was dereferenced and modified when it was already freed by PROC_Ummap(). This results

[PATCHv2 0/2] DSPBRIDGE: Improved reserved memory cleanup

2010-02-16 Thread Ameya Palande
mechanism will work perfectly in a use case where a big chunk of memory is reserved and then lot of mappings are created inside it. v2: Addresses following comments about reducing indentation http://marc.info/?l=linux-omapm=126624982331523w=2 Ameya Palande (2): DSPBRIDGE: Rename DMM_RES_OBJECT

[PATCH 2/2] DSPBRIDGE: New reserved memory accounting framework

2010-02-16 Thread Ameya Palande
DSP_RSV_OBJECT is introduced to track reserved memory accounting information. This will allow us to do proper cleanup for memory reserved using PROC_ReserveMemory(). Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/drv.h | 13 ++ arch/arm/plat

[PATCH 1/2] DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT

2010-02-16 Thread Ameya Palande
In its current state DMM_RES_OBJECT is not correctly tracking reserve and unreserve but only map and unmap. So lets rename it to DMM_MAP_OBJECT to clarify what it is really doing! In addition to this, this patch also does some trivial code cleanup. Signed-off-by: Ameya Palande ameya.pala

[PATCH] DSPBRIDGE: Get rid of memset() from MEM_Calloc()

2010-02-16 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/dsp/bridge/services/mem.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/dsp/bridge/services/mem.c b/drivers/dsp/bridge/services/mem.c index 614396e..2501eee 100644 --- a/drivers/dsp

[PATCH 0/2] DSPBRIDGE: Improved reserved memory cleanup

2010-02-15 Thread Ameya Palande
mechanism will work perfectly in a use case where a big chunk of memory is reserved and then lot of mappings are created inside it. Ameya Palande (2): DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT DSPBRIDGE: New reserved memory accounting framework arch/arm/plat-omap/include/dspbridge/drv.h

[PATCH 1/2] DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT

2010-02-15 Thread Ameya Palande
In its current state DMM_RES_OBJECT is not correctly tracking reserve and unreserve but only map and unmap. So lets rename it to DMM_MAP_OBJECT to clarify what it is really doing! In addition to this, this patch also does some trivial code cleanup. Signed-off-by: Ameya Palande ameya.pala

Re: [PATCH 0/3] DSPBRIDGE: Replace custom mailbox implementation with kernel mailbox module

2010-02-15 Thread Ameya Palande
On Mon, 2010-02-15 at 16:07 +0100, Contreras Felipe (Nokia-D/Helsinki) wrote: On Sat, Feb 13, 2010 at 03:01:57AM +0100, ext Guzman Lugo, Fernando wrote: From d287e11cdb126f2c9b4be8d6d6f958ffdf7ff716 Mon Sep 17 00:00:00 2001 From: Fernando Guzman Lugo x0095...@ti.com Date: Fri, 12 Feb 2010

RE: [PATCH] DSPBRIDGE: Validate Processor Handle from user

2010-02-11 Thread Ameya Palande
On Tue, 2010-02-09 at 18:51 +0100, ext Ramos Falcon, Ernesto wrote: -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Tuesday, February 09, 2010 11:27 AM To: Ramos Falcon, Ernesto Cc: linux-omap@vger.kernel.org; Contreras Felipe (Nokia-D/Helsinki); Doyu

RE: [PATCH] DSPBRIDGE: Validate node handle from user

2010-02-11 Thread Ameya Palande
On Tue, 2010-02-09 at 18:52 +0100, ext Ramos Falcon, Ernesto wrote: -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Tuesday, February 09, 2010 11:32 AM To: Ramos Falcon, Ernesto Cc: linux-omap@vger.kernel.org; Contreras Felipe (Nokia-D/Helsinki); Doyu

Re: [PATCH v2] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-11 Thread Ameya Palande
Hi Deepak, On Thu, 2010-02-11 at 18:33 +0100, ext Deepak Chitriki wrote: Removed NTFY_Notify() in WMD_MSG_Get() to avoid locking contention as NTFY_Notify() is already invoked in InputMsg(). Cc: Ameya Palande ameya.pala...@nokia.com Cc: Omar Ramirez Luna omar.rami...@ti.com Cc: Nishanth

Re: [PATCH] DSPBRIDGE: Prevent memory corruption in DRV_ProcFreeDMMRes

2010-02-11 Thread Ameya Palande
Hi all, On Thu, 2010-02-11 at 16:53 +0100, Contreras Felipe (Nokia-D/Helsinki) wrote: On Wed, Feb 10, 2010 at 06:31:35PM +0100, ext Guzman Lugo, Fernando wrote: -Original Message- From: Felipe Contreras [mailto:felipe.contre...@nokia.com] Resource cleanup does not support that

Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-11 Thread Ameya Palande
On Thu, 2010-02-11 at 22:54 +0100, ext Deepak Chitriki wrote: Removed NTFY_Notify() in WMD_MSG_Get() to avoid locking contention as NTFY_Notify() is already invoked in InputMsg(). Cc: Ameya Palande ameya.pala...@nokia.com Cc: Omar Ramirez Luna omar.rami...@ti.com Cc: Nishanth Menon n

RE: [PATCH] DSPBRIDGE: Validate node handle from user

2010-02-11 Thread Ameya Palande
Hi Ernesto, On Thu, 2010-02-11 at 19:44 +0100, ext Ramos Falcon, Ernesto wrote: -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Thursday, February 11, 2010 7:51 AM To: Ramos Falcon, Ernesto Cc: linux-omap@vger.kernel.org; Contreras Felipe (Nokia-D

Re: [PATCH] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-10 Thread Ameya Palande
()in WMD_MSG_Get()function. Cc: Ameya Palande ameya.pala...@nokia.com Cc: Omar Ramirez Luna omar.rami...@ti.com Cc: Nishanth Menon n...@ti.com Signed-off-by: Deepak Chitriki deepak.chitr...@ti.com --- drivers/dsp/bridge/wmd/msg_sm.c |4 1 files changed, 4 insertions(+), 0 deletions

Re: [PATCH] DSPBRIDGE: check pointer before calling Proc_Detach

2010-02-10 Thread Ameya Palande
Hi, On Thu, 2010-02-04 at 22:17 +0100, ext Omar Ramirez Luna wrote: From: Ernest Ramos Falcon erne...@ti.com This patch adds a check before calling Proc_Detach, otherwise in case a failure occurs on PROC_Attach and hProcessor is invalid when the userspace task closes its handle, unexpected

Re: [PATCH] DSPBRIDGE: Validate Processor Handle from user

2010-02-09 Thread Ameya Palande
Hi Ernesto, On Tue, 2010-02-09 at 18:07 +0100, ext Ramos Falcon, Ernesto wrote: From 07b9f6d30c9d363ba0c4cefded8068662e1048c4 Mon Sep 17 00:00:00 2001 From: Ernesto Ramos erne...@ti.com Date: Wed, 3 Feb 2010 19:43:31 -0600 Subject: [PATCH] DSPBRIDGE: Validate Processor Handle from user.

Re: [PATCH] DSPBRIDGE: Validate node handle from user

2010-02-09 Thread Ameya Palande
Hi Ernesto, On Tue, 2010-02-09 at 18:08 +0100, ext Ramos Falcon, Ernesto wrote: From 8310b586b025b0703c3951560849c4ea0250b6e1 Mon Sep 17 00:00:00 2001 From: Ernesto Ramos erne...@ti.com Date: Fri, 29 Jan 2010 16:21:59 -0600 Subject: [PATCH] DSPBRIDGE: Validate node handle from user. Add

Re: [PATCH] DSPBRIDGE: Validate stream handle from user

2010-02-09 Thread Ameya Palande
Hi Ernesto, On Tue, 2010-02-09 at 18:09 +0100, ext Ramos Falcon, Ernesto wrote: From 991bd676e160a5500cb511a78afcac838ff003e4 Mon Sep 17 00:00:00 2001 From: Ernesto Ramos erne...@ti.com Date: Fri, 29 Jan 2010 20:00:26 -0600 Subject: [PATCH] DSPBRIDGE: Validate stream handle from user. Add

[PATCH] DSPBRIDGE: Prevent memory corruption in DRV_ProcFreeDMMRes

2010-02-08 Thread Ameya Palande
: Nishanth Menon n...@ti.com CC: Deepak Chitriki Rudramuni deepak.chitr...@ti.com CC: Felipe Contreras felipe.contre...@nokia.com CC: Phil Carmody ext-phil.2.carm...@nokia.com Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/drv.h | 14

[PATCHv2 0/3] DSPBRIDGE: MEM Module cleanup series

2010-02-04 Thread Ameya Palande
This series contains patches which remove following things from the MEM module: 1. MEM_CHECK memory leak debugging mechanism 2. MEM_Free() function 3. MEM_VFree() function There was some issue while applying patches from V1, which should be solved in V2. Ameya Palande (3): DSPBRIDGE: Get rid

[PATCH 3/3] DSPBRIDGE: Get rid of MEM_VFree()

2010-02-04 Thread Ameya Palande
vfree() is NULL safe so MEM_VFree() doesn't provide any significant advantage. By getting rid of MEM_VFree() and the NULL pointer check associated with it, we can save on: 1. One level of indirection which translates to a function call cost. 2. NULL pointer checking cost. Signed-off-by: Ameya

dspbridge patches in patchwork

2010-02-03 Thread Ameya Palande
Hi Tony, As more and more people start contributing to dspbridge code (as we have seen recently) tracking patches is becoming difficult. Is it possible to delegate dspbridge patches to dspbridge maintainer in patchwork? Cheers, Ameya. -- To unsubscribe from this list: send the line unsubscribe

Re: dspbridge patches in patchwork

2010-02-03 Thread Ameya Palande
On Wed, 2010-02-03 at 18:08 +0100, ext Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [100203 09:00]: * Ameya Palande ameya.pala...@nokia.com [100203 04:24]: Hi Tony, As more and more people start contributing to dspbridge code (as we have seen recently) tracking patches

Re: dspbridge patches in patchwork

2010-02-03 Thread Ameya Palande
Hi Omar, On Wed, 2010-02-03 at 18:08 +0100, ext Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [100203 09:00]: * Ameya Palande ameya.pala...@nokia.com [100203 04:24]: Hi Tony, As more and more people start contributing to dspbridge code (as we have seen recently) tracking

[PATCH 0/3] DSPBRIDGE: MEM Module cleanup series

2010-02-03 Thread Ameya Palande
This series contains patches which remove following things from the MEM module: 1. MEM_CHECK memory leak debugging mechanism 2. MEM_Free() function 3. MEM_VFree() function Ameya Palande (3): DSPBRIDGE: Get rid of MEM_CHECK mechanism DSPBRIDGE: Get rid of MEM_Free() DSPBRIDGE: Get rid

[PATCH 1/3] DSPBRIDGE: Get rid of MEM_CHECK mechanism

2010-02-03 Thread Ameya Palande
kmemleak offeres the same functionality as custom MEM_CHECK mechanism, so get rid of MEM_CHECK. Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/dsp/bridge/services/mem.c | 212 + 1 files changed, 2 insertions(+), 210 deletions(-) diff --git

[PATCH 3/3] DSPBRIDGE: Get rid of MEM_VFree()

2010-02-03 Thread Ameya Palande
vfree() is NULL safe so MEM_VFree() doesn't provide any significant advantage. By getting rid of MEM_VFree() and the NULL pointer check associated with it, we can save on: 1. One level of indirection which translates to a function call cost. 2. NULL pointer checking cost. Signed-off-by: Ameya

[PATCH 2/3] DSPBRIDGE: Get rid of MEM_Free()

2010-02-03 Thread Ameya Palande
-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/mem.h | 19 +-- drivers/dsp/bridge/gen/gs.c|4 +- drivers/dsp/bridge/pmgr/cmm.c | 12 ++-- drivers/dsp/bridge/pmgr/cod.c |4 +- drivers/dsp/bridge/pmgr

Re: [PATCH] DSPBRIDGE: Get rid of driver_minor global variable

2010-02-02 Thread Ameya Palande
Hi Nishanth, On Mon, 2010-02-01 at 20:48 +0100, ext Menon, Nishanth wrote: Ameya Palande said the following on 02/01/2010 08:18 PM: Since there is only 1 device there is no need of driver_minor global variable. i am a little skeptical about this change - mainly coz, it might be a good

Re: [PATCH] DSPBRIDGE: MEM_Free() cleanup

2010-02-02 Thread Ameya Palande
On Mon, 2010-02-01 at 17:57 +0100, Palande Ameya (Nokia-D/Helsinki) wrote: Since kfree() checks for null pointer, there is no need to check is again in MEM_Free(). This patch also reorganizes the function to make it more readable. Signed-off-by: Ameya Palande ameya.pala...@nokia.com

Re: [PATCH] DSPBRIDGE: MEM_VFree() cleanup

2010-02-02 Thread Ameya Palande
On Mon, 2010-02-01 at 21:00 +0100, ext Menon, Nishanth wrote: Ameya Palande said the following on 02/01/2010 07:56 PM: Since vfree() checks for null pointer, there is no need to check is again in MEM_VFree(). This patch also reorganizes the function to make it more readable. Signed

RE: [PATCH] DSPBRIDGE: Remove conditional check from the InputMsg function

2010-02-01 Thread Ameya Palande
Hi Shivananda, On Wed, 2010-01-27 at 18:04 +0100, ext Hebbar, Shivananda wrote: -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Wednesday, January 27, 2010 3:44 AM To: Ramirez Luna, Omar Cc: linux-omap; Doyu Hiroshi (Nokia-D/Helsinki); Contreras

dspbridge unneeded headers

2010-02-01 Thread Ameya Palande
Hi Omar, What is the plan for following files in bridgedriver source? ./arch/arm/plat-omap/include/dspbridge/mem.h.orig ./arch/arm/plat-omap/include/dspbridge/dbc.h.orig ./arch/arm/plat-omap/include/dspbridge/gt.h.orig ./arch/arm/plat-omap/include/dspbridge/dbg.h.orig

[PATCH] DSPBRIDGE: MEM_Free() cleanup

2010-02-01 Thread Ameya Palande
Since kfree() checks for null pointer, there is no need to check is again in MEM_Free(). This patch also reorganizes the function to make it more readable. Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/dsp/bridge/services/mem.c | 40 ++-- 1

Re: dspbridge unneeded headers

2010-02-01 Thread Ameya Palande
Hi Omar, On Mon, 2010-02-01 at 17:55 +0100, ext Omar Ramirez Luna wrote: Hi Ameya, On 2/1/2010 5:08 AM, Ameya Palande wrote: Hi Omar, What is the plan for following files in bridgedriver source? ./arch/arm/plat-omap/include/dspbridge/mem.h.orig ./arch/arm/plat-omap/include

Re: [PATCH] DSPBRIDGE: Fix memory leak in PROC_AutoStart()

2010-02-01 Thread Ameya Palande
Hi Omar, On Mon, 2010-01-25 at 20:21 +0100, ext Omar Ramirez Luna wrote: Hi, On 1/21/2010 7:03 AM, Ameya Palande wrote: Signed-off-by: Ameya Palandeameya.pala...@nokia.com --- drivers/dsp/bridge/rmgr/proc.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCHv2] DSPBRIDGE: Fix memory leak in PROC_AutoStart()

2010-02-01 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/dsp/bridge/rmgr/proc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c index 491661f..ff3329f 100644 --- a/drivers/dsp/bridge/rmgr/proc.c

[PATCH] DSPBRIDGE: MEM_VFree() cleanup

2010-02-01 Thread Ameya Palande
Since vfree() checks for null pointer, there is no need to check is again in MEM_VFree(). This patch also reorganizes the function to make it more readable. Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/dsp/bridge/services/mem.c | 42 +++-- 1

[PATCH] DSPBRIDGE: Get rid of driver_minor global variable

2010-02-01 Thread Ameya Palande
Since there is only 1 device there is no need of driver_minor global variable. Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/dsp/bridge/rmgr/drv_interface.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c

[PATCH] DSPBRIDGE: Get rid of bridge_dev and bridge_device pointer

2010-02-01 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/dsp/bridge/rmgr/drv_interface.c | 28 ++-- 1 files changed, 6 insertions(+), 22 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c b/drivers/dsp/bridge/rmgr/drv_interface.c index de79f26

Re: [PATCH 2/2] DSPBRIDGE: Remove DRV_ProcUpdatestate function

2010-01-28 Thread Ameya Palande
) DRV_RemoveAllSTRMResElements(pCtxt); DRV_RemoveAllNodeResElements(pCtxt); DRV_RemoveAllDMMResElements(pCtxt); - DRV_ProcUpdatestate(pCtxt, PROC_RES_FREED); + pCtxt-resState = PROC_RES_FREED; return status; } #endif Acked-by: Ameya Palande ameya.pala...@nokia.com

Re: [PATCH] DSPBRIDGE: Resource clean up always enabled.

2010-01-28 Thread Ameya Palande
, Error copying kernel buffer to user, %d -- 1.5.4.5 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Ameya Palande

Re: [PATCH] DSPBRIDGE: Remove conditional check from the InputMsg function

2010-01-27 Thread Ameya Palande
Hi Shivananda, On Wed, 2010-01-27 at 02:44 +0100, ext Omar Ramirez Luna wrote: From: Shivananda Hebbar x0heb...@ti.com This patch removes the conditional check which can result in message skip. Discovered-by: Bhavin Shah bs...@ti.com Signed-off-by: Shivananda Hebbar x0heb...@ti.com ---

[PATCH] DSPBRIDGE: Fix memory leak in PROC_AutoStart()

2010-01-21 Thread Ameya Palande
Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/dsp/bridge/rmgr/proc.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c index a75b64a..91ab64f 100644 --- a/drivers/dsp/bridge/rmgr/proc.c

[PATCH] DSPBRIDGE: Various compile warning fixes

2010-01-21 Thread Ameya Palande
to be first one in variable declaration Signed-off-by: Mika Kukkonen mika.kukko...@nokia.com Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/dbc.h |6 +++--- arch/arm/plat-omap/include/dspbridge/dbg.h |4 ++-- arch/arm/plat-omap/include/dspbridge/gt.h

Re: [PATCH] DSPBRIDGE: Various compile warning fixes

2010-01-21 Thread Ameya Palande
On Thu, 2010-01-21 at 17:01 +0100, ext Andy Shevchenko wrote: On Thu, Jan 21, 2010 at 3:40 PM, Ameya Palande ameya.pala...@nokia.com wrote: --- a/drivers/dsp/bridge/wmd/io_sm.c +++ b/drivers/dsp/bridge/wmd/io_sm.c @@ -1210,7 +1210,7 @@ static void InputChnl(struct IO_MGR *pIOMgr, struct

[no subject]

2010-01-20 Thread Ameya Palande
unsubscribe linux-omap -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack

2010-01-20 Thread Ameya Palande
init_timer_on_stack. Cc: Ameya Palande ameya.pala...@nokia.com Cc: Deepak Chitriki deepak.chitr...@ti.com Cc: Felipe Contreras felipe.contre...@nokia.com Cc: Hiroshi Doyu hiroshi.d...@nokia.com Cc: Omar Ramirez Luna omar.rami...@ti.com Signed-off-by: Nishanth Menon n...@ti.com --- drivers/dsp/bridge

Re: [PATCH] DSPBRIDGE: dont pass invalid DSP OPP requests

2010-01-20 Thread Ameya Palande
. this is an invalid OPP ID and should not be passed anywhere. we add a param check for this prior to passing it along to the workqueue. Cc: Ameya Palande ameya.pala...@nokia.com Cc: Deepak Chitriki deepak.chitr...@ti.com Cc: Felipe Contreras felipe.contre...@nokia.com Cc: Hiroshi Doyu hiroshi.d

  1   2   3   >