Re: [PATCH v2 8/8] DT:omap3+ads7846: use new common touchscreen bindings

2015-11-16 Thread Grazvydas Ignotas
Hi, On Fri, Nov 13, 2015 at 10:35 PM, H. Nikolaus Schaller wrote: > The standard touch screen bindings [1] replace the private ti,swap-xy > with touchscreen-swaped-x-y. And for the Openpandora we use > touchscreen-size etc. to match the LCD screen size. > > [1]: Documentation/devicetree/bindings/

Re: [PATCH 2/2] ARM: dts: Fix WLAN regression on omap5-uevm

2015-09-19 Thread Grazvydas Ignotas
On Fri, Sep 18, 2015 at 9:39 PM, Robert Nelson wrote: > On Fri, Sep 18, 2015 at 11:51 AM, Tony Lindgren wrote: >> * Robert Nelson [150918 09:45]: >>> On Fri, Sep 18, 2015 at 11:29 AM, Tony Lindgren wrote: >>> > Commit 99f84cae43df ("ARM: dts: add wl12xx/wl18xx bindings") added >>> > device tree

[PATCH] ARM: omap2plus_defconfig: enable GPIO_PCA953X

2015-09-15 Thread Grazvydas Ignotas
This enables tca6424a GPIO expander driver that in turn enables TPD12S015 HDMI ESD protection and level shifter on OMAP5 uevm. In other words, it makes HDMI work on OMAP5 uevm. Signed-off-by: Grazvydas Ignotas --- arch/arm/configs/omap2plus_defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] ARM: dts: omap5-uevm.dts: fix i2c5 pinctrl offsets

2015-09-15 Thread Grazvydas Ignotas
The i2c5 pinctrl offsets are wrong. If the bootloader doesn't set the pins up, communication with tca6424a doesn't work (controller timeouts) and it is not possible to enable HDMI. Fixes: 9be495c42609 ("ARM: dts: omap5-evm: Add I2c pinctrl data") Signed-off-by: Grazvydas Ig

Re: mysterious crashes on OMAP5 uevm

2015-09-15 Thread Grazvydas Ignotas
>> While we're waiting for Grazvydas to test.. Looks good to me: >> >> Acked-by: Tony Lindgren > > I have tested on: > * GTA04 with DM3730 (OMAP3) > * Pyra prototype with OMAP5432 > No X server crashes seen any more. > > Tested-by: H. Nikolaus Schaller

Re: mysterious crashes on OMAP5 uevm

2015-09-11 Thread Grazvydas Ignotas
On Thu, Sep 10, 2015 at 10:30 AM, Russell King - ARM Linux wrote: > On Thu, Sep 10, 2015 at 08:42:57AM +0200, Dr. H. Nikolaus Schaller wrote: >> ... >> >> Now, disabling CONFIG_ARCH_MULTI_V6 also makes the bug go away and adding the >> >> #if 0 //__LINUX_ARM_ARCH__ >= 7 >> makes it re-appear. >> >

Re: mysterious crashes on OMAP5 uevm

2015-09-08 Thread Grazvydas Ignotas
On Tue, Sep 8, 2015 at 4:38 PM, Tony Lindgren wrote: > * Grazvydas Ignotas [150908 05:50]: >> Hi, >> >> this is a longstanding problem I'm seeing since the very beginning, >> which was around 3.12 or so (when I've first got the hardware) and it >> s

mysterious crashes on OMAP5 uevm

2015-09-08 Thread Grazvydas Ignotas
Hi, this is a longstanding problem I'm seeing since the very beginning, which was around 3.12 or so (when I've first got the hardware) and it seems 4.2 is affected by it still. Basically what happens is Xorg randomly segfaults at some "impossible" location. I don't have the details at the moment (

[PATCH] twl4030_charger: fix another compile error

2015-09-04 Thread Grazvydas Ignotas
eported-by: Randy Dunlap Signed-off-by: Grazvydas Ignotas --- drivers/power/twl4030_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c index f4f2c1f..5bcc76f 100644 --- a/drivers/power/twl4030_charger.c +++

[PATCH 3/4] ARM: OMAP2+: omap3-pandora: add backlight support

2015-07-20 Thread Grazvydas Ignotas
Add backlight support via pdata-quirks as it's driver lacks DT support. Signed-off-by: Grazvydas Ignotas --- arch/arm/mach-omap2/pdata-quirks.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c

[PATCH 2/4] ARM: dts: omap3-pandora: add support for usb host and 32k buffer

2015-07-20 Thread Grazvydas Ignotas
This adds missing bits for EHCI HS USB host support and 32k clock buffer control for the wg7210 bt+wifi module. Signed-off-by: Grazvydas Ignotas --- arch/arm/boot/dts/omap3-pandora-common.dtsi | 36 + 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH 4/4] ARM: OMAP2+: omap3-pandora: add wifi support

2015-07-20 Thread Grazvydas Ignotas
Add wl1251 support via pdata-quirks as it's driver lacks DT support. MMC3 is marked disabled in DT so that MMC3 instance of hsmmc driver is probed using platform data with special card init callback. Signed-off-by: Grazvydas Ignotas --- arch/arm/boot/dts/omap3-pandora-common.dtsi | 5 ++

[PATCH 1/4] ARM: dts: omap3-pandora: miscellaneous corrections

2015-07-20 Thread Grazvydas Ignotas
: Grazvydas Ignotas --- arch/arm/boot/dts/omap3-pandora-1ghz.dts| 2 +- arch/arm/boot/dts/omap3-pandora-600mhz.dts | 2 +- arch/arm/boot/dts/omap3-pandora-common.dtsi | 13 + 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/omap3-pandora-1ghz.dts b/arch

Re: [PATCH 2/2] ARM: OMAP2+: Remove legacy booting support for Pandora

2015-07-17 Thread Grazvydas Ignotas
On Fri, Jul 17, 2015 at 7:54 AM, Tony Lindgren wrote: > * Tony Lindgren [150716 09:28]: >> * Grazvydas Ignotas [150716 07:16]: >> > Hi, >> > >> > On Thu, Jul 16, 2015 at 2:59 PM, Tony Lindgren wrote: >> > > We've been moving all omap2+ base

Re: [PATCH 2/2] ARM: OMAP2+: Remove legacy booting support for Pandora

2015-07-16 Thread Grazvydas Ignotas
is as pandora's .dts currently lacks all that stuff. That said I'm not aware of any mainline users (everyone seems to be on our "vendor" kernel), so maybe we can add those later. > > Cc: Signed-off-by: Grazvydas Ignotas I have not signed this off... > Signed-off-by: Ton

Re: [RFC] Fix omap3 booting with thumb2 compiled kernel

2015-05-28 Thread Grazvydas Ignotas
On Thu, May 28, 2015 at 1:55 AM, Tony Lindgren wrote: > 8 <-- > From: Tony Lindgren > Date: Wed, 27 May 2015 15:33:57 -0700 > Subject: [PATCH] ARM: OMAP3: Fix booting with thumb2 kernel > > We get a NULL pointer dereference on omap3 for thumb2 compiled kernels: > > Internal er

Re: [PATCH] thermal: ti-soc-thermal: dra7: Implement Workaround for Errata i813

2015-04-16 Thread Grazvydas Ignotas
On Thu, Apr 16, 2015 at 1:18 PM, Keerthy wrote: > DESCRIPTION > > Spurious Thermal Alert: Talert can happen randomly while the device remains > under the temperature limit > defined for this event to trig. This spurious event is caused by a incorrect > re-synchronization between > clock domains.

Re: ARM errata 430973 on multi platform kernels

2015-04-10 Thread Grazvydas Ignotas
On Fri, Apr 10, 2015 at 1:44 AM, Tony Lindgren wrote: > * Grazvydas Ignotas [150409 15:37]: >> On Tue, Apr 7, 2015 at 5:23 AM, Tony Lindgren wrote: >> > * Matthijs van Duin [150406 11:15]: >> >> >> >> On 6 April 2015 at 19:42, Tony Lindgren w

Re: [PATCH] ti-soc-thermal: implement omap3 support

2015-03-31 Thread Grazvydas Ignotas
On Tue, Mar 31, 2015 at 11:42 AM, Pavel Machek wrote: > > This adds support for OMAP3 chips to ti-soc-thermal. As requested by > TI people, it is marked unreliable and warning is printed. > > Signed-off-by: Pavel Machek > > --- > ... > --- /dev/null > +++ b/drivers/thermal/ti-soc-thermal/omap3-th

Re: twl4030_charger: need changes to get probed?

2015-03-07 Thread Grazvydas Ignotas
On Sat, Mar 7, 2015 at 12:56 AM, Pali Rohár wrote: > On Friday 06 March 2015 23:40:34 Pavel Machek wrote: >> On Sat 2015-03-07 00:12:07, Grazvydas Ignotas wrote: >> > On Fri, Mar 6, 2015 at 11:57 PM, Pali Rohár >> > wrote: >> > > On Friday 06 March 2015

Re: twl4030_charger: need changes to get probed?

2015-03-06 Thread Grazvydas Ignotas
On Fri, Mar 6, 2015 at 11:57 PM, Pali Rohár wrote: > On Friday 06 March 2015 22:24:17 Pavel Machek wrote: >> Hi! >> >> According to n900 dts, twl4030-bci (aka charger) should be >> included. >> > > AFAIK it is not present on n900... Right, it uses twl5030 variant without the charger, charging on

Re: [PATCH 13/15] twl4030_charger: add ac/mode to match usb/mode

2015-03-06 Thread Grazvydas Ignotas
On Tue, Feb 24, 2015 at 6:33 AM, NeilBrown wrote: > This allows AC charging to be turned off, much like usb charging. > > "continuous" (aka "linear") mode maps to the CVENAC (constant voltage) > feature of the twl4030. Are you sure? Before your patches CVENAC was set at all times and and charger

Re: Enabling DBGEN signal in GP OMAP3

2015-02-28 Thread Grazvydas Ignotas
h case parts, etc. I've already performed the mod (just a solder bridge) and it works fine. On Thu, Feb 26, 2015 at 6:01 AM, Matthijs van Duin wrote: > On 26 February 2015 at 02:09, Grazvydas Ignotas wrote: > >> Anyway I'm attaching my code too > > Ah, if this works

Re: Enabling DBGEN signal in GP OMAP3

2015-02-25 Thread Grazvydas Ignotas
On Mon, Feb 23, 2015 at 1:52 PM, Matthijs van Duin wrote: > At least on the am335x, the trick actually works! I have a working > demo which configures ICEPick registers and even performs transactions > on the debug interconnect. Nice! > I've been lazy and imported a bunch of files from my barem

Re: [PATCH v2 0/3] ARM: dts: add openpandora device support

2015-02-19 Thread Grazvydas Ignotas
On Tue, Feb 17, 2015 at 9:52 PM, Marek Belisko wrote: > changes from v1: > - add new boards to makefile in patch 2,3 (don't add them > in separate commit together), fix gpmc issues (reported by Tony Lindgren) > > - fix various issues reported by Grazvydas Ignotas > (dro

Re: [PATCH v2 1/3] ARM: dts: omap3-pandora: add common device tree

2015-02-19 Thread Grazvydas Ignotas
On Tue, Feb 17, 2015 at 9:52 PM, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > This device tree allows to boot, supports the panel, > framebuffer, touch screen, as well as some more peripherals. > Since there is a OMAP3530 based 600 MHz variant and a DM3730 based > 1 GHz variant we must

Re: Enabling DBGEN signal in GP OMAP3

2015-02-18 Thread Grazvydas Ignotas
On Wed, Feb 18, 2015 at 5:00 AM, Matthijs van Duin wrote: > > 030-040 are the core debug control regs... in fact, judging by their > values and the fact you mentioned bit 13 controls DBGEN, these regs > look very much like the ICEPick-D core debug control regs, which > themselves are simplified ve

Re: Enabling DBGEN signal in GP OMAP3

2015-02-17 Thread Grazvydas Ignotas
d it referenced anywhere (and I'll admit I don't have experience with hardware debuggers). On Mon, Feb 16, 2015 at 10:09 PM, Matthijs van Duin wrote: > On 15 February 2015 at 22:30, Grazvydas Ignotas wrote: >> "The DBGEM signal on the Cortex-A8 is driven by setting bit 13

Enabling DBGEN signal in GP OMAP3

2015-02-15 Thread Grazvydas Ignotas
Hi, Does anyone know if there is a way to make DBGEN signal high on OMAP3530 and/or DM3730 without using a hardware debugger? My goal is to make use of hardware watchpoints in Cortex-A8, but that requires DBGEN to be high. The TRM states: "The DBGEM signal on the Cortex-A8 is driven by setting bi

Re: [PATCH 3/4] ARM: dts: omap3-pandora: add DM3730 1 GHz version

2015-02-12 Thread Grazvydas Ignotas
On Thu, Feb 12, 2015 at 3:03 PM, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/omap3-pandora-1ghz.dts | 65 > > 1 file changed, 65 insertions(+) > create mode 100644 arch/arm/boot/dts/omap

Re: [PATCH 1/4] ARM: dts: omap3-pandora: add common device tree

2015-02-12 Thread Grazvydas Ignotas
On Thu, Feb 12, 2015 at 3:03 PM, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > This device tree allows to boot, supports the panel, > framebuffer, touch screen, as well as some more peripherals. > Since there is a OMAP3530 based 600 MHz variant and a DM3730 based > 1 GHz variant we must

Re: [PATCH 0/4] add openpandora device support

2015-02-12 Thread Grazvydas Ignotas
On Thu, Feb 12, 2015 at 3:03 PM, Marek Belisko wrote: > This series of patches adds initial device tree support for the > OpenPandora. The most important parts are working (display, keyboard, > touch, charging, fuel gauge, musb port, sd/mmc ports, leds, buttons). > Not yet supported are: usb host

Re: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor

2014-12-29 Thread Grazvydas Ignotas
On Fri, Dec 26, 2014 at 2:34 PM, Sebastian Reichel wrote: > OMAP34xx and OMAP36xx processors contain a register in the syscon area, > which can be used to determine the SoCs temperature. This patch provides > a DT based driver for the temperature sensor based on an older driver > written by Peter

Re: [PATCH 4/4] arm: dts: omap3-gta04: Add static configuration for devconf1 register

2014-11-14 Thread Grazvydas Ignotas
On Fri, Nov 14, 2014 at 1:58 AM, Tony Lindgren wrote: > * Paul Walmsley [141113 15:01]: >> Hi >> >> On Thu, 13 Nov 2014, Tony Lindgren wrote: >> >> > * Tomi Valkeinen [141113 03:33]: >> > > On 12/11/14 17:02, Tony Lindgren wrote: >> > > >> > > >> And, with a quick grep, I see CONTROL_DEVCONF1 to

Re: [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled

2014-11-12 Thread Grazvydas Ignotas
On Tue, Nov 4, 2014 at 5:42 PM, Tony Lindgren wrote: > * Igor Grinberg [141104 05:22]: >> Hi Tony, >> >> On 11/02/14 20:07, Tony Lindgren wrote: >> > Commit e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset >> > configuration") enabled configuring the PM features for twl4030. >> > >> > This ca

Re: [PATCH 07/10] ARM: OMAP5 / DRA7: Enable CPU RET on suspend

2014-09-08 Thread Grazvydas Ignotas
Hi, On Sat, Sep 6, 2014 at 12:15 AM, Nishanth Menon wrote: > > Hi, > > Updated patch below: > Do let me know if this is ok with folks. > > ---8< > From 1b9e11834dac2bd75c396aa7495c806b027653fe Mon Sep 17 00:00:00 2001 > From: Rajendra Nayak > Date: Mon, 27 May 2013 15:46:44 +0530 > Subject:

Re: [PATCH] usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down

2014-08-22 Thread Grazvydas Ignotas
Hi, On Thu, Aug 21, 2014 at 7:48 PM, Tony Lindgren wrote: > Commit 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect") > added twl4030_id_workaround_work() to deal with lost interrupts > after ID pin goes down. However, this currently only works for the > insertion. The PHY interrupts

Re: [PATCH 1/3] mtd: nand: omap: Revert to using software ECC by default

2014-08-06 Thread Grazvydas Ignotas
On Wed, Aug 6, 2014 at 11:02 AM, Roger Quadros wrote: > Hi Gražvydas, > > On 08/05/2014 07:15 PM, Grazvydas Ignotas wrote: >> On Tue, Aug 5, 2014 at 1:11 PM, Roger Quadros wrote: >>> For v3.12 and prior, 1-bit Hamming code ECC via software was the >>> default cho

Re: [PATCH 1/3] mtd: nand: omap: Revert to using software ECC by default

2014-08-05 Thread Grazvydas Ignotas
On Tue, Aug 5, 2014 at 1:11 PM, Roger Quadros wrote: > For v3.12 and prior, 1-bit Hamming code ECC via software was the > default choice. Commit c66d039197e4 in v3.13 changed the behaviour > to use 1-bit Hamming code via Hardware using a different ECC layout > i.e. (ROM code layout) than what is u

Re: [PATCH V2 2/2] power: twl4030_charger: attempt to power off in case of critical events

2014-06-04 Thread Grazvydas Ignotas
On Wed, Jun 4, 2014 at 4:01 PM, Nishanth Menon wrote: > On 06/04/2014 05:04 AM, Grazvydas Ignotas wrote: >> On Thu, May 29, 2014 at 12:46 AM, Nishanth Menon wrote: >>> Attempt to power off in case of critical events such as battery removal, >>> over voltage events. &g

Re: [PATCH V2 2/2] power: twl4030_charger: attempt to power off in case of critical events

2014-06-04 Thread Grazvydas Ignotas
On Thu, May 29, 2014 at 12:46 AM, Nishanth Menon wrote: > Attempt to power off in case of critical events such as battery removal, > over voltage events. > > There is no guarentee that we'd be in a safe scenario here, but the very > least we can try to do is to power off the device to prevent dama

Re: [PATCH 02/11] ARM: OMAP3: Fix idle mode signaling for sys_clkreq and sys_off_mode

2014-04-16 Thread Grazvydas Ignotas
On Wed, Apr 16, 2014 at 1:56 AM, Tony Lindgren wrote: > * Grazvydas Ignotas [140414 15:51]: >> On Fri, Apr 11, 2014 at 2:47 AM, Tony Lindgren wrote: >> > @@ -282,6 +283,7 @@ void omap_sram_idle(void) >> > >> > /* CORE */ >> >

Re: [PATCH 02/11] ARM: OMAP3: Fix idle mode signaling for sys_clkreq and sys_off_mode

2014-04-14 Thread Grazvydas Ignotas
On Fri, Apr 11, 2014 at 2:47 AM, Tony Lindgren wrote: > While debugging legacy mode vs device tree booted PM regressions, > I noticed that omap3 is not toggling sys_clkreq and sys_off_mode > pins like it should. > > The sys_clkreq and sys_off_mode pins are not toggling because of > the following i

Re: [PATCH V3] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-12-18 Thread Grazvydas Ignotas
On Wed, Dec 18, 2013 at 5:35 PM, Felipe Balbi wrote: > Hi, > > On Tue, Dec 17, 2013 at 05:48:33PM +0100, anaum...@ultratronik.de wrote: >> From: Andreas Naumann >> >> This is a hard to reproduce problem which leads to non-functional >> USB-OTG port in 0.1%-1% of all boots. Tracked it down to comm

Re: [PATCH V3] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-12-18 Thread Grazvydas Ignotas
On Wed, Dec 18, 2013 at 9:41 AM, Andreas Naumann wrote: > Am 17.12.2013 18:22, schrieb David Cohen: > >> On Tue, Dec 17, 2013 at 05:48:33PM +0100, anaum...@ultratronik.de wrote: >>> >>> From: Andreas Naumann >>> >>> This is a hard to reproduce problem which leads to non-functional >>> USB-OTG por

Re: WG: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-16 Thread Grazvydas Ignotas
On Fri, Dec 13, 2013 at 6:27 PM, Andreas Naumann wrote: > On 13.12.2013 13:34, Grazvydas Ignotas wrote: >> >> Hmm I don't know about that, this would be inconsistent with what all >> other OMAP drivers do. Maybe we should do what musb_core.c does just > > Ok, thats

Re: WG: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-13 Thread Grazvydas Ignotas
On Thu, Dec 12, 2013 at 11:29 PM, Andreas Naumann wrote: > Hi Grazvydas, > >> Von: Grazvydas Ignotas [mailto:nota...@gmail.com] >> Gesendet: Donnerstag, 12. Dezember 2013 01:21 >> An: linux-...@vger.kernel.org >> Cc: Felipe Balbi; linux-omap@vger.kernel.org; Naumann

[PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-11 Thread Grazvydas Ignotas
ved in the context as it's invalid value, so we use it as an indicator that context hasn't been saved yet). This issue was originally found by Andreas Naumann: http://marc.info/?l=linux-usb&m=138562574719654&w=2 Reported-and-bisected-by: Andreas Naumann Signed-off-by: Grazvydas

Re: [PATCH V2] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-11-29 Thread Grazvydas Ignotas
On Fri, Nov 29, 2013 at 10:34 AM, Andreas Naumann wrote: >> Nice find, I think I'm also affected by this. However this crashes on >> OMAP3530 pandora because you now access INTERFSEL before interface >> clock is enabled.. This is not a problem on DM37xx because it uses >> different interconnects.

Re: [PATCH 01/12 diet] ARM: OMAP2+: Remove legacy omap3 board-*.c files and make mach-omap2 DT only for booting

2013-11-28 Thread Grazvydas Ignotas
On Tue, Nov 26, 2013 at 3:17 AM, Tony Lindgren wrote: > We can now boot all mach-omap2 related boards using appended device > tree by creating a related .dts file with pretty much the same > functionality as booted in the legacy platform data mode. Not really the same, quite some drivers are stil

Re: [PATCH V2] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-11-28 Thread Grazvydas Ignotas
On Thu, Nov 28, 2013 at 9:51 AM, wrote: > From: Andreas Naumann > > This is a hard to reproduce problem which leads to non-functional > USB-OTG port in 0.1%-1% of all boots. Tracked it down to commit > e25bec160158abe86c276d7d206264afc3646281, which introduces save/restore > of OTG_INTERFSEL ove

Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver

2013-10-28 Thread Grazvydas Ignotas
On Sun, Oct 27, 2013 at 10:12 PM, Sebastian Reichel wrote: > On Sun, Oct 27, 2013 at 08:24:16PM +0400, Alexander Shiyan wrote: >> > Move the power GPIO handling from the board code into >> > the driver. This is a dependency for device tree support. >> > >> > Signed-off-by: Sebastian Reichel >> >

Re: [PATCH 4/4] wl1251: spi: add device tree support

2013-10-28 Thread Grazvydas Ignotas
On Mon, Oct 28, 2013 at 8:37 AM, Kumar Gala wrote: > On Oct 27, 2013, at 11:14 AM, Sebastian Reichel wrote: > > +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > > @@ -0,0 +1,36 @@ > > +* Texas Instruments wl1251 controller > > + > > +The wl1251 chip can be connected via SPI or

Re: [PATCH v2 0/9] wilink: add device tree support

2013-07-03 Thread Grazvydas Ignotas
Hi, On Tue, Jul 2, 2013 at 5:55 PM, Luciano Coelho wrote: > Hi, > > This is a follow-up on a previous patch set that had a smaller > audience. This time, I added the lists and people who were involved > in the review of the bindings documentation, since most of my changes > in v2 are coming from

Re: Request for OMAPDSS testing

2013-06-09 Thread Grazvydas Ignotas
upply[] = { With that it shows Tux and fb console fine, so with above hunk: Tested-by: Grazvydas Ignotas -- Gražvydas -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: USB ehci suspend/resume on beagleboard

2013-04-05 Thread Grazvydas Ignotas
On Thu, Apr 4, 2013 at 2:50 PM, Roger Quadros wrote: > correcting misleading subject line. > was (Re: MUSB regression in linux next at least for pandboard) > > On 04/04/2013 02:36 PM, Roger Quadros wrote: >> Hi, >> >> On 02/07/2013 04:10 PM, Grazvydas Ignotas wrote:

Re: [PATCH] Revert "OMAP/serial: Fix incorrect Rx FIFO threshold setting, LSR validation on Tx, and Tx FIFO IRQ generation"

2013-04-04 Thread Grazvydas Ignotas
On Thu, Apr 4, 2013 at 12:06 AM, Alexey Pelykh wrote: > > Is it possible to check behavior on 3.0-3.2 kernels? We use 3.2 on pandora as production kernel and it doesn't have this issue that 3.9 had. 3.2 serial PM code is vastly different from what's in later ones though. > > On Wed, Apr 3, 2013

Re: [PATCH] Revert "OMAP/serial: Fix incorrect Rx FIFO threshold setting, LSR validation on Tx, and Tx FIFO IRQ generation"

2013-04-03 Thread Grazvydas Ignotas
Hi, On Wed, Apr 3, 2013 at 12:19 AM, Alexey Pelykh wrote: > > But, since we've found the issue, I suggest that we should look at it > closer, especially since at this moment only you can reproduce it. As FWIW I was also affected by it, maybe because my console is on UART3 and that is on differen

[PATCHv3 2/3] usb: musb: omap2430: turn off vbus on cable disconnect

2013-03-24 Thread Grazvydas Ignotas
-off-by: Grazvydas Ignotas --- drivers/usb/musb/omap2430.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 798e029..3551f1a 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -291,6 +291,7 @@ static

[PATCHv3 1/3] usb: phy: twl4030-usb: check if vbus is driven by twl itself

2013-03-24 Thread Grazvydas Ignotas
At least on pandora, STS_VBUS gets set even when VBUS is driven by twl itself. Reporting VBUS in this case confuses OMAP musb glue and charger driver, so check if OTG VBUS charge pump is on before reporting VBUS event to avoid this problem. Signed-off-by: Grazvydas Ignotas --- drivers/usb/phy

[PATCHv3 3/3] usb: musb: gadget: use platform callback to enable vbus

2013-03-24 Thread Grazvydas Ignotas
after that. Signed-off-by: Grazvydas Ignotas --- drivers/usb/musb/musb_gadget.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index ff6ba3a..4be4865 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/driver

[PATCHv3 0/3] usb: phy: remaining twl4030-usb/omap fixes

2013-03-24 Thread Grazvydas Ignotas
en when ID is grounded at the same time (like it was before the patch). Grazvydas Ignotas (3): usb: phy: twl4030-usb: check if vbus is driven by twl itself usb: musb: omap2430: turn off vbus on cable disconnect usb: musb: gadget: use platform callback to enable vbus drivers/usb/musb/musb_gadge

Re: [PATCHv2 5/7] usb: phy: twl4030-usb: check if vbus is driven by twl itself

2013-03-21 Thread Grazvydas Ignotas
On Wed, Mar 20, 2013 at 3:07 PM, Felipe Balbi wrote: > On Sun, Mar 17, 2013 at 08:23:25PM +0200, Grazvydas Ignotas wrote: >> At least on pandora, STS_VBUS gets set even when VBUS is driven by twl >> itself. Reporting VBUS in this case confuses OMAP musb glue and charger >> dr

[PATCHv2 5/7] usb: phy: twl4030-usb: check if vbus is driven by twl itself

2013-03-17 Thread Grazvydas Ignotas
At least on pandora, STS_VBUS gets set even when VBUS is driven by twl itself. Reporting VBUS in this case confuses OMAP musb glue and charger driver, so check if OTG VBUS charge pump is on before reporting VBUS event to avoid this problem. Signed-off-by: Grazvydas Ignotas --- drivers/usb/phy

[PATCHv2 7/7] usb: musb: gadget: use platform callback to enable vbus

2013-03-17 Thread Grazvydas Ignotas
after that. Signed-off-by: Grazvydas Ignotas --- drivers/usb/musb/musb_gadget.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index ae59ee6..60eef20 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/driver

[PATCHv2 6/7] usb: musb: omap2430: turn off vbus on cable disconnect

2013-03-17 Thread Grazvydas Ignotas
-off-by: Grazvydas Ignotas --- drivers/usb/musb/omap2430.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index ec460ea..780a750 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -291,6 +291,7 @@ static

[PATCHv2 4/7] usb: phy: twl4030-usb: poll for ID disconnect

2013-03-17 Thread Grazvydas Ignotas
linkstat update code to callers so that changes can be handled in thread safe way (as polling work can trigger at the same time as real irq now). TI PSP kernels have similar workarounds, so (many?) more boards are likely affected. Signed-off-by: Grazvydas Ignotas --- drivers/usb/phy/phy-twl4030-usb.

[PATCHv2 3/7] usb: phy: twl4030-usb: don't switch the phy on/off needlessly

2013-03-17 Thread Grazvydas Ignotas
ut no gadget driver is loaded. This will also have side effect of automatic USB charging no longer working without twl4030_charger driver, because a regulator needed for charging will no longer be enabled, so be sure to enable charger driver if charging is needed. Signed-off-by: Grazvydas Ig

[PATCHv2 2/7] usb: phy: twl4030-usb: ignore duplicate events

2013-03-17 Thread Grazvydas Ignotas
defaults to "no cable" state, so only bother it if we have VBUS or ID. Signed-off-by: Grazvydas Ignotas Reviewed-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-twl4030-usb.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/d

[PATCHv2 1/7] usb: phy: twl4030-usb: don't enable PHY during init

2013-03-17 Thread Grazvydas Ignotas
There is no need to do it, otg.set_suspend(false) (which itself comes from runtime_pm OMAP glue calls) will enable it later anyway. This used to be the place where things were enabled if booted with cable connected before runtime_pm conversion, but now can be dropped. Signed-off-by: Grazvydas

[PATCHv2 0/7] usb: phy: twl4030-usb fixes

2013-03-17 Thread Grazvydas Ignotas
races between work item and IRQ - changed patch 6 to only disable VBUS if not runtime suspended, otherwise we get data abort on OMAP3 Grazvydas Ignotas (7): usb: phy: twl4030-usb: don't enable PHY during init usb: phy: twl4030-usb: ignore duplicate events usb: phy: twl4030-usb: don

Re: [PATCH v2 2/4] usb: otg: twl4030: use devres API for regulator get and request irq

2013-03-15 Thread Grazvydas Ignotas
On Thu, Mar 14, 2013 at 5:48 PM, Felipe Balbi wrote: > On Thu, Mar 14, 2013 at 11:53:57AM +0530, Kishon Vijay Abraham I wrote: >> Used devres APIs devm_request_threaded_irq and devm_regulator_get for >> requesting irq and for getting regulator respectively. >> >> Signed-off-by: Kishon Vijay Abraha

Re: [PATCH 0/5] usb: musb/otg: cleanup and fixes

2013-03-13 Thread Grazvydas Ignotas
sg81563.html > (Grazvydas Ignotas patch series) > > Tested for g_zero enumeration in pandaboard and beagleboard in both > cold plug and hot plug case. Any kind of testing for this series is welcome. > > Kishon Vijay Abraham I (5): > usb: musb: omap: remove the check before c

Re: [PATCH 2/5] usb: musb: omap: always glue have the correct vbus/id status

2013-03-13 Thread Grazvydas Ignotas
On Wed, Mar 13, 2013 at 10:47 AM, Kishon Vijay Abraham I wrote: > In the case where omap glue is loaded and musb core is not, glue->status > wont have a valid status if the phy drivers call omap_musb_mailbox. So > fixed the conditions here. There already seems to be another patch named "usb: musb

Re: [PATCH 6/7] usb: musb: omap2430: turn off vbus on cable disconnect

2013-03-12 Thread Grazvydas Ignotas
On Tue, Mar 12, 2013 at 3:37 PM, kishon wrote: > Hi, > > > On Sunday 10 March 2013 06:38 AM, Grazvydas Ignotas wrote: >> >> On USB_EVENT_ID event the musb glue enables VBUS by calling >> omap2430_musb_set_vbus(musb, 1) that sets the session bit, but on >> US

Re: [PATCH 2/7] usb: otg: twl4030-usb: ignore duplicate events

2013-03-12 Thread Grazvydas Ignotas
On Tue, Mar 12, 2013 at 3:32 PM, kishon wrote: > Hi, > > > On Sunday 10 March 2013 06:37 AM, Grazvydas Ignotas wrote: >> >> In some rare cases we may get multiple interrupts that will generate >> duplicate omap_musb_mailbox() calls. This is a problem because e

[PATCH] ARM: OMAP3: hwmod data: keep MIDLEMODE in force-standby for musb

2013-03-11 Thread Grazvydas Ignotas
ork and device still functions properly, as musb has driver-controlled OTG_FORCESTDBY register that controls MSTANDBY signal. Note that TI PSP kernels also have similar workarounds. This patch also fixes HWMOD_SWSUP_MSTANDBY documentation to match the actual flag name. Signed-off-by: Grazvydas Ign

Re: [PATCH] usb: musb: log VBUS error

2013-03-11 Thread Grazvydas Ignotas
On Mon, Mar 11, 2013 at 6:24 PM, Tony Lindgren wrote: > * Grazvydas Ignotas [130309 16:53]: >> VBUS_ERROR is a serious error that the driver often doesn't recover from >> in my tests, so we should at least inform the user about it. > > Patch makes sens to me, just a rel

Re: [PATCH] ARM: OMAP3: hwmod data: disable MIDLEMODE control for musb

2013-03-11 Thread Grazvydas Ignotas
On Mon, Mar 11, 2013 at 1:15 AM, Paul Walmsley wrote: > Hi Gražvydas, > > On Sun, 10 Mar 2013, Grazvydas Ignotas wrote: > >> For some unknown reason, allowing hwmod to control MIDLEMODE causes >> core_pwrdm to not hit idle states for musb in DM3730 at least. >>

Re: [PATCH 4/7] usb: otg: twl4030-usb: poll for ID disconnect

2013-03-10 Thread Grazvydas Ignotas
On Sun, Mar 10, 2013 at 1:03 PM, Michael Trimarchi wrote: > Hi > > just one comment. > > On 10/03/13 02:07, Grazvydas Ignotas wrote: >> On pandora, STS_USB interrupt doesn't arrive on USB host cable disconnect >> for some reason while VBUS is driven by twl its

[PATCH 1/7] usb: otg: twl4030-usb: don't enable PHY during init

2013-03-09 Thread Grazvydas Ignotas
There is no need to do it, otg.set_suspend(false) (which itself comes from runtime_pm OMAP glue calls) will enable it later anyway. This used to be the place where things were enabled if booted with cable connected before runtime_pm conversion, but now can be dropped. Signed-off-by: Grazvydas

[PATCH 7/7] usb: musb: gadget: use platform callback to enable vbus

2013-03-09 Thread Grazvydas Ignotas
after that. Signed-off-by: Grazvydas Ignotas --- drivers/usb/musb/musb_gadget.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index be18537..19998e9 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/driver

[PATCH 6/7] usb: musb: omap2430: turn off vbus on cable disconnect

2013-03-09 Thread Grazvydas Ignotas
works. Signed-off-by: Grazvydas Ignotas --- drivers/usb/musb/omap2430.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 2a39c11..d430677 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -296,6

[PATCH 4/7] usb: otg: twl4030-usb: poll for ID disconnect

2013-03-09 Thread Grazvydas Ignotas
ounds, so (many?) more boards are likely affected. Signed-off-by: Grazvydas Ignotas --- drivers/usb/otg/twl4030-usb.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c index 90a19ff..2c1c27e 1

[PATCH 5/7] usb: otg: twl4030-usb: check if vbus is driven by twl itself

2013-03-09 Thread Grazvydas Ignotas
At least on pandora, STS_VBUS gets set even when VBUS is driven by twl itself. Reporting VBUS in this case confuses OMAP musb glue and charger driver, so check if OTG VBUS charge pump is on before reporting VBUS event to avoid this problem. Signed-off-by: Grazvydas Ignotas --- drivers/usb/otg

[PATCH 3/7] usb: otg: twl4030-usb: don't switch the phy on/off needlessly

2013-03-09 Thread Grazvydas Ignotas
ut no gadget driver is loaded. This will also have side effect of automatic USB charging no longer working without twl4030_charger driver, so be sure to enable it if charging is needed. Signed-off-by: Grazvydas Ignotas --- drivers/usb/otg/twl4030-usb.c |6 -- 1 file changed, 6 dele

[PATCH 2/7] usb: otg: twl4030-usb: ignore duplicate events

2013-03-09 Thread Grazvydas Ignotas
defaults to "no cable" state, so only bother it if we have VBUS or ID. Signed-off-by: Grazvydas Ignotas --- drivers/usb/otg/twl4030-usb.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c index 1515c0

[PATCH 0/7] usb: otg: twl4030-usb fixes

2013-03-09 Thread Grazvydas Ignotas
OMAP3: hwmod data: disable MIDLEMODE control for musb" is needed that was sent separately). This also fixes power drain when cable is plugged an no gadget driver is loaded. Grazvydas Ignotas (7): usb: otg: twl4030-usb: don't enable PHY during init usb: otg: twl4030-usb: ignore duplica

[PATCH] usb: musb: log VBUS error

2013-03-09 Thread Grazvydas Ignotas
VBUS_ERROR is a serious error that the driver often doesn't recover from in my tests, so we should at least inform the user about it. Signed-off-by: Grazvydas Ignotas --- drivers/usb/musb/musb_core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH] usb: musb: gadget: clear gadget_driver when gadget is stopped

2013-03-09 Thread Grazvydas Ignotas
. Clear the gadget_driver pointer on remove, it's invalid after stop anyway. Signed-off-by: Grazvydas Ignotas --- drivers/usb/musb/musb_gadget.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index 19998e9..1ddb889 100644

[PATCH] usb: musb: honour initial transceiver state

2013-03-09 Thread Grazvydas Ignotas
As the OTG transceiver driver usually starts first, it should already have default_a variable set according to ID pin state, so don't override it. In case default_a was not changed by trasceiver, it will default to 0 and this code will work as before. Signed-off-by: Grazvydas Ig

[PATCH] ARM: OMAP3: hwmod data: disable MIDLEMODE control for musb

2013-03-09 Thread Grazvydas Ignotas
trols MSTANDBY signal, so perhaps MIDLEMODE is not even needed? Note that TI PSP kernels also have similar workarounds. Signed-off-by: Grazvydas Ignotas --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --

[PATCH] OMAPDSS: tpo-td043 panel: fix data passing between SPI/DSS parts

2013-02-16 Thread Grazvydas Ignotas
device, so use a global pointer to accomplish this instead, like other SPI panel drivers do. Signed-off-by: Grazvydas Ignotas --- .../video/omap2/displays/panel-tpo-td043mtea1.c| 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/video/omap2/displays/panel

Re: [PATCH 1/2] ARM: OMAP2+: Prevent potential crash if GPMC probe fails

2013-02-16 Thread Grazvydas Ignotas
unreserve ended > JON >> up in the gpmc_calc_timings() function. Here is a patch to fix. Just wasted a hour or a few trying to figure out this problem, can we get this merged now? Maybe Jon can resend this with all the tested-bys to catch Tony's attention? Tested-by: Grazvydas Ignotas

Re: MUSB regression in linux next at least for pandboard

2013-02-07 Thread Grazvydas Ignotas
On Thu, Feb 7, 2013 at 11:16 AM, Roger Quadros wrote: > It seems the beagleboard problem is related to OMAP silicon errata [1]. > Apparently, remote wakeup as well as host issued wakeup break omap-ehci and > have > nothing to do with the hub or it's driver. > > I'll work on this issue after I'm

Re: MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Grazvydas Ignotas
On Fri, Dec 14, 2012 at 11:53 AM, Ian Coolidge wrote: > we find that with about a 2% chance, the gadget comes up in some kind of > firmware failed state, driving VBUS. > In this condition, we found that MUSB_DEVCTL_SESSION bit was set. > I understand this to be indicative of MUSB thinking it is i

Re: [PATCH 00/16] OMAP USB Host cleanup

2012-12-04 Thread Grazvydas Ignotas
On Tue, Nov 27, 2012 at 6:30 PM, Felipe Balbi wrote: > On Tue, Nov 27, 2012 at 04:42:47PM +0200, Roger Quadros wrote: >> Kevin, >> >> I gave a quick look at the issue. It seems that the High Speed USB Host >> module is kept in Software forced wakeup mode as a quick fix workaround >> to a bunch of

Re: [PATCH 0/5] OMAPFB: use dma_alloc instead of omap's vram

2012-11-12 Thread Grazvydas Ignotas
Hi, On Mon, Nov 12, 2012 at 12:25 PM, Tomi Valkeinen wrote: > This series changes omapfb to use standard dma_alloc funcs instead of omap > specific vram allocator. This let's us remove the omap vram allocator, making > omapfb platform independent. > > However, note that using standard dma funcs c

Re: [PATCH 3/3] pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of PMICs

2012-11-08 Thread Grazvydas Ignotas
On Thu, Nov 8, 2012 at 9:34 AM, Péter Ujfalusi wrote: > On 11/07/2012 07:12 PM, Grazvydas Ignotas wrote: >>> +static int twl4030_pwmled_config(struct pwm_chip *chip, struct pwm_device >>> *pwm, >>> + int duty_ns, int period_ns) >

Re: [PATCH 2/3] pwm: New driver to support PWMs on TWL4030/6030 series of PMICs

2012-11-08 Thread Grazvydas Ignotas
On Thu, Nov 8, 2012 at 9:14 AM, Péter Ujfalusi wrote: > On 11/07/2012 06:50 PM, Grazvydas Ignotas wrote: >>> + if (pwm->hwpwm) { >>> + /* PWM 1 */ >>> + mask = TWL4030_GPIO7_VIBRASYNC_PWM1_MASK; >>> +

  1   2   3   4   5   >